rho-coding-agent 1.48.0

A lightweight agent harness inspired by Pi
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186

use pretty_assertions::assert_eq;

use super::{
    candidate_agent_id, candidate_item, merge_live_candidates, picker, retire_departed_live_runs,
    visible_candidates, AttachCandidate, WorkspaceRunFilter,
};
use crate::subagent::RunState;

// Covers: attach rows show role, title, and current activity instead of a run id.
// Owner: attach picker
#[test]
fn attach_row_uses_role_title_and_activity() {
    let cases = [
        (
            AttachCandidate {
                run_id: "abc123".into(),
                agent_id: "worker".into(),
                title: Some("Review the auth path".into()),
                last_activity: Some("tool: read".into()),
                state: RunState::Running,
                elapsed_seconds: 12,
            },
            "worker",
            "Review the auth path",
            "read",
        ),
        (
            AttachCandidate {
                run_id: "def456".into(),
                agent_id: "explorer".into(),
                title: None,
                last_activity: None,
                state: RunState::Starting,
                elapsed_seconds: 1,
            },
            "explorer",
            "untitled",
            "starting",
        ),
    ];

    for (candidate, role, label, activity) in cases {
        let run_id = candidate.run_id.clone();
        let item = candidate_item(&candidate);
        assert_eq!(item.section.as_deref(), Some(role));
        assert_eq!(item.label, label);
        assert_eq!(item.value, run_id);
        assert_eq!(
            item.badge.as_ref().map(|badge| badge.text.as_str()),
            Some(activity)
        );
        assert!(!item.detail.as_deref().unwrap_or_default().contains(&run_id));
    }
}

fn candidate(run_id: &str, state: RunState) -> AttachCandidate {
    AttachCandidate {
        run_id: run_id.into(),
        agent_id: "worker".into(),
        title: Some(run_id.into()),
        last_activity: None,
        state,
        elapsed_seconds: 1,
    }
}

// Covers: running-only must hide finished transcripts until the user toggles.
// Owner: attach picker
#[test]
fn running_only_hides_terminal_runs() {
    let candidates = [
        candidate("aaaaaa", RunState::Running),
        candidate("bbbbbb", RunState::Ok),
        candidate("cccccc", RunState::Error),
    ];

    let running_ids = visible_candidates(&candidates, WorkspaceRunFilter::RunningOnly)
        .into_iter()
        .map(|run| run.run_id.as_str())
        .collect::<Vec<_>>();
    let all_ids = visible_candidates(&candidates, WorkspaceRunFilter::All)
        .into_iter()
        .map(|run| run.run_id.as_str())
        .collect::<Vec<_>>();

    assert_eq!(running_ids, ["aaaaaa"]);
    assert_eq!(all_ids, ["aaaaaa", "bbbbbb", "cccccc"]);
}

// Covers: an empty inventory must still build an attach overlay.
// Owner: attach picker
#[test]
fn empty_inventory_still_builds_a_picker() {
    let empty = picker(&[], WorkspaceRunFilter::RunningOnly);
    assert!(empty.items.is_empty());
    assert_eq!(empty.selected_item().map(|item| item.value.as_str()), None);
}

// Covers: live panel rows overlay matching disk rows and keep panel order for new lives.
// Owner: attach picker
#[test]
fn live_candidates_replace_matching_disk_rows() {
    let disk = vec![
        candidate("aaaaaa", RunState::Ok),
        candidate("bbbbbb", RunState::Running),
    ];
    let mut live = candidate("bbbbbb", RunState::Running);
    live.title = Some("updated".into());
    live.elapsed_seconds = 9;
    let first_missing = candidate("cccccc", RunState::Starting);
    let second_missing = candidate("dddddd", RunState::Starting);

    let merged = merge_live_candidates(disk, vec![live, first_missing, second_missing]);

    assert_eq!(
        merged
            .iter()
            .map(|run| (
                run.run_id.as_str(),
                run.title.as_deref(),
                run.elapsed_seconds
            ))
            .collect::<Vec<_>>(),
        [
            ("cccccc", Some("cccccc"), 1),
            ("dddddd", Some("dddddd"), 1),
            ("aaaaaa", Some("aaaaaa"), 1),
            ("bbbbbb", Some("updated"), 9),
        ]
    );
}

// Covers: finished transcripts keep their role after the picker closes.
// Owner: attach picker
#[test]
fn finished_run_agent_id_comes_from_candidates() {
    let mut finished = candidate("aaaaaa", RunState::Ok);
    finished.agent_id = "explorer".into();

    assert_eq!(candidate_agent_id(&[finished], "aaaaaa"), Some("explorer"));
    assert_eq!(candidate_agent_id(&[], "aaaaaa"), None);
}

// Covers: a run that leaves the live panel must not stay listed as running.
// Owner: attach picker
#[test]
fn departed_live_run_uses_real_terminal_state() {
    let mut candidates = vec![
        candidate("aaaaaa", RunState::Running),
        candidate("bbbbbb", RunState::Running),
        candidate("cccccc", RunState::Running),
        candidate("dddddd", RunState::Running),
    ];
    let previously_live = [
        "aaaaaa".into(),
        "bbbbbb".into(),
        "cccccc".into(),
        "dddddd".into(),
    ]
    .into();
    let live_ids = ["dddddd".into()].into();

    retire_departed_live_runs(
        &mut candidates,
        &live_ids,
        &previously_live,
        |run_id| match run_id {
            "aaaaaa" => RunState::Ok,
            "bbbbbb" => RunState::Error,
            _ => RunState::Stopped,
        },
    );

    assert_eq!(
        candidates
            .iter()
            .map(|run| (run.run_id.as_str(), run.state))
            .collect::<Vec<_>>(),
        [
            ("aaaaaa", RunState::Ok),
            ("bbbbbb", RunState::Error),
            ("cccccc", RunState::Stopped),
            ("dddddd", RunState::Running),
        ]
    );
}