req-cli 0.5.0-rc.2

Managed requirements CLI for LLM agents and humans
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
// Implements REQ-0026 (default coverage scan), REQ-0032 (--unlinked-files),
// REQ-0033 (--by-file) and REQ-0034 (--remap with --apply).
use anyhow::Result;
use once_cell::sync::Lazy;
use regex::Regex;
use std::collections::{BTreeMap, BTreeSet};
use std::fs;
use std::path::{Path, PathBuf};

use crate::cli::CoverageArgs;
use crate::model::Status;
use crate::storage::load_resolved;

static REQ_RE: Lazy<Regex> = Lazy::new(|| Regex::new(r"REQ-\d{4}").unwrap());
// REQ-0135: safety-requirement markers (// SR-NNNN:) are traced the same
// way as REQ markers so the safety spec↔code loop closes too.
static SR_RE: Lazy<Regex> = Lazy::new(|| Regex::new(r"SR-\d{4}").unwrap());

// REQ-0033: default extension list for source scanning. Schema-as-code
// (SQL migrations, init scripts) is a first-class implementation surface
// for most backends, so `sql` is here too.
pub const DEFAULT_EXTS: &[&str] = &[
    "rs", "py", "js", "ts", "tsx", "go", "java", "md", "toml", "c", "cpp", "h", "sql",
];

/// REQ-0110: resolve extension list with CLI > _config > built-in defaults.
fn resolve_extensions(cli_exts: &[String], project: &crate::model::Project) -> Vec<String> {
    if !cli_exts.is_empty() {
        return cli_exts.to_vec();
    }
    if let Some(cfg) = project
        .config
        .as_ref()
        .and_then(|c| c.coverage.as_ref())
        .and_then(|c| c.extensions.as_ref())
    {
        if !cfg.is_empty() {
            return cfg.clone();
        }
    }
    DEFAULT_EXTS.iter().map(|s| s.to_string()).collect()
}
// REQ-0124: directory skip-list moved into source_walk via the
// `ignore` crate, which honours .gitignore + .ignore + global git
// excludes. Hard-coded SKIP_DIRS removed.

#[derive(serde::Serialize)]
struct Report {
    referenced: BTreeMap<String, Vec<String>>,
    /// REQ-0070: requirements referenced ONLY by test files — implementation
    /// markers absent. Distinct from `referenced` so a test-only marker
    /// does not falsely claim impl coverage.
    test_only: BTreeMap<String, Vec<String>>,
    /// Non-Draft, non-Obsolete requirements with no source marker. This
    /// is the strict-mode gating set: things the spec promises but the
    /// code doesn't cite.
    orphans: Vec<String>,
    /// REQ-0121: Draft requirements that also have no source marker.
    /// Reported separately so `req coverage` surfaces the full picture
    /// (and adopters running coverage on a fresh project see why the
    /// orphan count is zero) without breaking strict-mode gating.
    drafts_unmarked: Vec<String>,
    ghosts: BTreeMap<String, Vec<String>>,
    obsolete_referenced: BTreeMap<String, Vec<String>>,
    /// REQ-0135: the same three views for safety requirements (SR-NNNN).
    /// Omitted from JSON when empty so non-safety projects are unchanged.
    #[serde(skip_serializing_if = "BTreeMap::is_empty")]
    sr_referenced: BTreeMap<String, Vec<String>>,
    #[serde(skip_serializing_if = "Vec::is_empty")]
    sr_orphans: Vec<String>,
    #[serde(skip_serializing_if = "BTreeMap::is_empty")]
    sr_ghosts: BTreeMap<String, Vec<String>>,
}

pub fn run(args: CoverageArgs, file: &Option<PathBuf>) -> Result<()> {
    // REQ-0110: load the project up front so `_config.coverage.extensions`
    // contributes to extension resolution even on branches (unlinked_files,
    // by_file, remap) that didn't previously need the project.
    let (_, project) = load_resolved(file)?;
    let exts: Vec<String> = resolve_extensions(&args.extensions, &project);

    if args.unlinked_files {
        return run_unlinked_files(&args.path, &exts, args.json);
    }
    if args.by_file {
        return run_by_file(&args.path, &exts, args.json);
    }
    // REQ-0127: inverse view — REQ-NNNN → list of files referencing it.
    if args.by_req {
        return run_by_req(&args.path, &exts, args.json);
    }
    if !args.remap.is_empty() {
        return run_remap(&args.path, &exts, &args.remap, args.apply);
    }

    let mut hits: BTreeMap<String, Vec<String>> = BTreeMap::new();
    let mut sr_hits: BTreeMap<String, Vec<String>> = BTreeMap::new();
    walk(&args.path, &exts, &mut |path, line_no, line| {
        for m in REQ_RE.find_iter(line) {
            hits.entry(m.as_str().to_string())
                .or_default()
                .push(format!("{}:{}", path.display(), line_no));
        }
        for m in SR_RE.find_iter(line) {
            sr_hits
                .entry(m.as_str().to_string())
                .or_default()
                .push(format!("{}:{}", path.display(), line_no));
        }
    });

    let known: BTreeSet<&String> = project.requirements.keys().collect();
    let mut report = Report {
        referenced: BTreeMap::new(),
        test_only: BTreeMap::new(),
        orphans: Vec::new(),
        drafts_unmarked: Vec::new(),
        ghosts: BTreeMap::new(),
        obsolete_referenced: BTreeMap::new(),
        sr_referenced: BTreeMap::new(),
        sr_orphans: Vec::new(),
        sr_ghosts: BTreeMap::new(),
    };

    // REQ-0135: safety-requirement coverage. A marker pointing at a known
    // SR is referenced; one pointing at nothing is a ghost; an SR that is
    // implemented-or-beyond with no marker is an orphan (Draft/Obsolete
    // excluded, same rule as requirements).
    for (id, refs) in &sr_hits {
        match project.safety_requirements.get(id) {
            Some(_) => {
                report.sr_referenced.insert(id.clone(), refs.clone());
            }
            None => {
                report.sr_ghosts.insert(id.clone(), refs.clone());
            }
        }
    }
    for (id, sr) in &project.safety_requirements {
        if sr_hits.contains_key(id) {
            continue;
        }
        if !matches!(sr.status, Status::Draft | Status::Obsolete) {
            report.sr_orphans.push(id.clone());
        }
    }
    report.sr_orphans.sort();

    for (id, refs) in &hits {
        let has_impl = refs.iter().any(|r| !is_test_path(r));
        match project.requirements.get(id) {
            Some(r) if matches!(r.status, Status::Obsolete) => {
                report.obsolete_referenced.insert(id.clone(), refs.clone());
            }
            Some(_) if !has_impl => {
                // REQ-0070: only test files reference this requirement.
                report.test_only.insert(id.clone(), refs.clone());
            }
            Some(_) => {
                report.referenced.insert(id.clone(), refs.clone());
            }
            None => {
                report.ghosts.insert(id.clone(), refs.clone());
            }
        }
    }
    // Orphan = a requirement exists in the spec but no source marker
    // references it. Drafts haven't been implemented yet, so expecting
    // a marker is wrong by definition — exclude them. Obsolete reqs
    // are also excluded (already retired). This makes `req coverage
    // --strict` safe to use on projects that record near-term backlog
    // as Drafts without flooding CI with orphan findings.
    for id in known {
        if !hits.contains_key(id) {
            let r = &project.requirements[id];
            match r.status {
                Status::Obsolete => {}
                Status::Draft => report.drafts_unmarked.push(id.clone()),
                _ => report.orphans.push(id.clone()),
            }
        }
    }

    if args.json {
        println!("{}", serde_json::to_string_pretty(&report)?);
        if args.strict {
            let allow: std::collections::HashSet<&String> = args.allow_orphans.iter().collect();
            let unexpected = report
                .orphans
                .iter()
                .filter(|id| !allow.contains(*id))
                .count();
            let sr_unexpected = report
                .sr_orphans
                .iter()
                .filter(|id| !allow.contains(*id))
                .count();
            let findings = unexpected
                + report.ghosts.len()
                + report.obsolete_referenced.len()
                + sr_unexpected
                + report.sr_ghosts.len();
            if findings > 0 {
                std::process::exit(1);
            }
        }
        return Ok(());
    }

    println!("Coverage report (root: {})", args.path.display());
    println!(
        "  referenced       : {}  (impl + maybe test markers)",
        report.referenced.len()
    );
    println!(
        "  test-only        : {}  (test marker but no impl marker)",
        report.test_only.len()
    );
    println!(
        "  orphans          : {}  (non-Draft non-Obsolete reqs with no marker — gated by --strict)",
        report.orphans.len()
    );
    println!(
        "  drafts unmarked  : {}  (Draft reqs with no marker — informational, not gated)",
        report.drafts_unmarked.len()
    );
    println!("  ghosts           : {}", report.ghosts.len());
    println!("  obsolete-in-code : {}", report.obsolete_referenced.len());
    if !report.orphans.is_empty() {
        println!("\nORPHANS (requirement exists but is not mentioned in code):");
        for id in &report.orphans {
            println!("  {}", id);
        }
    }
    if !report.drafts_unmarked.is_empty() {
        println!("\nDRAFTS UNMARKED (Draft reqs with no code marker yet — advance with `req update <id> --status implemented` once you add the marker):");
        for id in &report.drafts_unmarked {
            println!("  {}", id);
        }
    }
    if !report.ghosts.is_empty() {
        println!("\nGHOSTS (code mentions an unknown ID):");
        for (id, refs) in &report.ghosts {
            println!("  {}", id);
            for r in refs {
                println!("    {}", r);
            }
        }
    }
    if !report.test_only.is_empty() {
        println!("\nTEST-ONLY (referenced only by test files):");
        for (id, refs) in &report.test_only {
            println!("  {}", id);
            for r in refs {
                println!("    {}", r);
            }
        }
    }
    if !report.obsolete_referenced.is_empty() {
        println!("\nOBSOLETE-IN-CODE (code still references retired requirements):");
        for (id, refs) in &report.obsolete_referenced {
            println!("  {}", id);
            for r in refs {
                println!("    {}", r);
            }
        }
    }
    // REQ-0135: safety-requirement coverage, printed only when the project
    // has any SR markers or safety requirements.
    if !project.safety_requirements.is_empty() || !report.sr_ghosts.is_empty() {
        println!(
            "\nSafety requirements: {} referenced, {} orphan(s), {} ghost(s)",
            report.sr_referenced.len(),
            report.sr_orphans.len(),
            report.sr_ghosts.len()
        );
        if !report.sr_orphans.is_empty() {
            println!("  SR ORPHANS (safety requirement exists but is not mentioned in code):");
            for id in &report.sr_orphans {
                println!("    {}", id);
            }
        }
        if !report.sr_ghosts.is_empty() {
            println!("  SR GHOSTS (code mentions an unknown SR id):");
            for (id, refs) in &report.sr_ghosts {
                println!("    {}", id);
                for r in refs {
                    println!("      {}", r);
                }
            }
        }
    }
    // REQ-0065: strict mode turns findings into a non-zero exit.
    if args.strict {
        let allow: std::collections::HashSet<&String> = args.allow_orphans.iter().collect();
        let unexpected_orphans: Vec<&String> = report
            .orphans
            .iter()
            .filter(|id| !allow.contains(*id))
            .collect();
        let sr_unexpected = report
            .sr_orphans
            .iter()
            .filter(|id| !allow.contains(*id))
            .count();
        let findings = unexpected_orphans.len()
            + report.ghosts.len()
            + report.obsolete_referenced.len()
            + sr_unexpected
            + report.sr_ghosts.len();
        if findings > 0 {
            eprintln!(
                "\ncoverage --strict: {} unallowed finding(s); exiting non-zero.",
                findings
            );
            std::process::exit(1);
        }
    }
    Ok(())
}

#[derive(serde::Serialize)]
struct UnlinkedReport {
    scanned: usize,
    linked: usize,
    unlinked: Vec<String>,
}

fn run_unlinked_files(root: &Path, exts: &[String], json: bool) -> Result<()> {
    let mut scanned = 0usize;
    let mut linked = 0usize;
    let mut unlinked: Vec<String> = Vec::new();
    walk_files(root, exts, &mut |path, has_marker| {
        scanned += 1;
        if has_marker {
            linked += 1;
        } else {
            unlinked.push(path.display().to_string());
        }
    });
    unlinked.sort();
    let report = UnlinkedReport {
        scanned,
        linked,
        unlinked,
    };

    if json {
        println!("{}", serde_json::to_string_pretty(&report)?);
        return Ok(());
    }

    let pct = if report.scanned == 0 {
        0.0
    } else {
        100.0 * (report.linked as f64) / (report.scanned as f64)
    };
    println!("Unlinked-files report (root: {})", root.display());
    println!("  scanned   : {}", report.scanned);
    println!("  linked    : {} ({:.0}%)", report.linked, pct);
    println!("  unlinked  : {}", report.unlinked.len());
    if !report.unlinked.is_empty() {
        println!("\nFiles with no REQ-NNNN markers:");
        for f in &report.unlinked {
            println!("  {}", f);
        }
    }
    Ok(())
}

// REQ-0124: gitignore-aware variant for the --unlinked-files / per-file
// reports. Yields each in-scope file with a bool indicating whether any
// REQ-marker is present.
fn walk_files(root: &Path, exts: &[String], visit: &mut impl FnMut(&Path, bool)) {
    crate::source_walk::walk_source_tree(root, exts, |path| {
        let has = fs::read_to_string(path)
            .map(|t| REQ_RE.is_match(&t))
            .unwrap_or(false);
        visit(path, has);
    });
}

#[derive(serde::Serialize)]
struct ByFileEntry {
    file: String,
    req_ids: Vec<String>,
}

/// REQ-0127: inverse of run_by_file — per-requirement list of files
/// referencing it.
fn run_by_req(root: &Path, exts: &[String], json: bool) -> Result<()> {
    let mut per_req: BTreeMap<String, BTreeSet<String>> = BTreeMap::new();
    walk(root, exts, &mut |path, _line_no, line| {
        for m in REQ_RE.find_iter(line) {
            per_req
                .entry(m.as_str().to_string())
                .or_default()
                .insert(path.display().to_string());
        }
    });

    if json {
        // Flat REQ → [paths] map.
        let map: BTreeMap<&String, Vec<&String>> = per_req
            .iter()
            .map(|(id, files)| (id, files.iter().collect()))
            .collect();
        println!("{}", serde_json::to_string_pretty(&map)?);
        return Ok(());
    }

    if per_req.is_empty() {
        println!(
            "No files under {} contain REQ-NNNN markers.",
            root.display()
        );
        return Ok(());
    }
    println!("Per-requirement coverage (root: {}):\n", root.display());
    for (id, files) in &per_req {
        println!("  {}", id);
        for f in files {
            println!("    {}", f);
        }
    }
    Ok(())
}

fn run_by_file(root: &Path, exts: &[String], json: bool) -> Result<()> {
    let mut per_file: BTreeMap<String, BTreeSet<String>> = BTreeMap::new();
    walk(root, exts, &mut |path, _line_no, line| {
        for m in REQ_RE.find_iter(line) {
            per_file
                .entry(path.display().to_string())
                .or_default()
                .insert(m.as_str().to_string());
        }
    });

    let entries: Vec<ByFileEntry> = per_file
        .into_iter()
        .map(|(file, ids)| ByFileEntry {
            file,
            req_ids: ids.into_iter().collect(),
        })
        .collect();

    if json {
        println!("{}", serde_json::to_string_pretty(&entries)?);
        return Ok(());
    }

    if entries.is_empty() {
        println!(
            "No files under {} contain REQ-NNNN markers.",
            root.display()
        );
        return Ok(());
    }
    println!("Per-file coverage (root: {}):\n", root.display());
    for e in &entries {
        println!("  {}", e.file);
        for id in &e.req_ids {
            println!("    {}", id);
        }
    }
    Ok(())
}

fn run_remap(root: &Path, exts: &[String], pairs: &[String], apply: bool) -> Result<()> {
    let mut map: BTreeMap<String, String> = BTreeMap::new();
    for raw in pairs {
        let (old, new) = raw
            .split_once('=')
            .ok_or_else(|| anyhow::anyhow!("--remap expects OLD=NEW, got '{}'", raw))?;
        if !REQ_RE.is_match(old) || !REQ_RE.is_match(new) {
            return Err(anyhow::anyhow!(
                "--remap values must look like REQ-NNNN: '{}={}' rejected",
                old,
                new
            ));
        }
        map.insert(old.to_string(), new.to_string());
    }

    let mut plan: Vec<(String, usize, String, String)> = Vec::new();
    walk(root, exts, &mut |path, line_no, line| {
        for (old, new) in &map {
            if line.contains(old) {
                plan.push((
                    path.display().to_string(),
                    line_no,
                    old.clone(),
                    new.clone(),
                ));
            }
        }
    });

    if plan.is_empty() {
        println!(
            "No occurrences of {} in {}.",
            pairs.join(", "),
            root.display()
        );
        return Ok(());
    }

    println!(
        "{} occurrence(s) of {} in {}:",
        plan.len(),
        pairs.join(", "),
        root.display()
    );
    for (file, line, old, new) in &plan {
        println!("  {}:{}  {} -> {}", file, line, old, new);
    }

    if !apply {
        println!("\nDry-run. Re-run with --apply to rewrite the files.");
        return Ok(());
    }

    let mut files: BTreeSet<String> = BTreeSet::new();
    for (file, _, _, _) in &plan {
        files.insert(file.clone());
    }
    for file in &files {
        let text = fs::read_to_string(file)?;
        let mut new_text = text.clone();
        for (old, new) in &map {
            new_text = new_text.replace(old.as_str(), new.as_str());
        }
        if new_text != text {
            fs::write(file, new_text)?;
        }
    }
    println!("\nRewrote {} file(s).", files.len());
    Ok(())
}

/// REQ-0070: classify a file:line marker as test-source or implementation.
/// Heuristic by path: anything under a `tests/` directory or matching
/// `*_test.<ext>` / `*_tests.<ext>` / `*.test.<ext>` counts as test.
pub fn is_test_path(file_ref: &str) -> bool {
    let normalised = file_ref.replace('\\', "/");
    let lower = normalised.to_lowercase();
    if lower.contains("/tests/") || lower.starts_with("tests/") || lower.starts_with("./tests/") {
        return true;
    }
    // strip `:lineno` suffix before suffix-matching
    let path_only = lower.split(':').next().unwrap_or(&lower);
    let suffixes = [
        "_test.rs",
        "_tests.rs",
        ".test.ts",
        ".test.tsx",
        ".test.js",
        "_test.py",
        "_test.go",
    ];
    suffixes.iter().any(|s| path_only.ends_with(s))
}

// REQ-0124: delegate the directory walk to source_walk, which honours
// .gitignore + .ignore + global excludes. The line-level marker scan
// stays per-file here.
fn walk(root: &Path, exts: &[String], visit: &mut impl FnMut(&Path, usize, &str)) {
    crate::source_walk::walk_source_tree(root, exts, |path| {
        if let Ok(text) = fs::read_to_string(path) {
            for (i, line) in text.lines().enumerate() {
                // REQ-0135: pass lines carrying either a REQ or an SR
                // marker so safety-requirement coverage sees SR-only lines.
                if REQ_RE.is_match(line) || SR_RE.is_match(line) {
                    visit(path, i + 1, line);
                }
            }
        }
    });
}