reinhardt-middleware 0.1.2

Middleware system for request/response processing pipeline
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
//! Redirect fallback middleware
//!
//! Provides automatic redirection for 404 errors to a fallback URL.
//! Useful for handling missing pages gracefully.

use async_trait::async_trait;
use hyper::StatusCode;
use regex::Regex;
use reinhardt_http::{Handler, Middleware, Request, Response, Result};
use serde::{Deserialize, Serialize};
use std::sync::Arc;

/// Configuration for redirect fallback behavior
#[non_exhaustive]
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RedirectResponseConfig {
	/// The fallback URL to redirect to on 404 errors
	pub fallback_url: String,
	/// Optional path patterns to match (if None, matches all 404s)
	pub path_patterns: Option<Vec<String>>,
	/// Status code to use for redirect (default: 302 Found)
	pub redirect_status: Option<u16>,
}

impl RedirectResponseConfig {
	/// Create a new configuration with a fallback URL
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::RedirectResponseConfig;
	///
	/// let config = RedirectResponseConfig::new("/404".to_string());
	/// assert_eq!(config.fallback_url, "/404");
	/// ```
	pub fn new(fallback_url: String) -> Self {
		Self {
			fallback_url,
			path_patterns: None,
			redirect_status: None,
		}
	}

	/// Add path patterns to match
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::RedirectResponseConfig;
	///
	/// let config = RedirectResponseConfig::new("/404".to_string())
	///     .with_patterns(vec!["/api/.*".to_string()]);
	/// ```
	pub fn with_patterns(mut self, patterns: Vec<String>) -> Self {
		self.path_patterns = Some(patterns);
		self
	}

	/// Set custom redirect status code
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::RedirectResponseConfig;
	///
	/// let config = RedirectResponseConfig::new("/404".to_string())
	///     .with_status(301);
	/// ```
	pub fn with_status(mut self, status: u16) -> Self {
		self.redirect_status = Some(status);
		self
	}
}

/// Middleware that redirects 404 errors to a fallback URL
///
/// # Examples
///
/// ```
/// use std::sync::Arc;
/// use reinhardt_middleware::{RedirectFallbackMiddleware, RedirectResponseConfig};
/// use reinhardt_http::{Handler, Middleware, Request, Response};
/// use hyper::{StatusCode, Method, Version, HeaderMap};
/// use bytes::Bytes;
///
/// struct NotFoundHandler;
///
/// #[async_trait::async_trait]
/// impl Handler for NotFoundHandler {
///     async fn handle(&self, _request: Request) -> reinhardt_core::exception::Result<Response> {
///         Ok(Response::new(StatusCode::NOT_FOUND))
///     }
/// }
///
/// # tokio_test::block_on(async {
/// let config = RedirectResponseConfig::new("/404".to_string());
/// let middleware = RedirectFallbackMiddleware::new(config);
/// let handler = Arc::new(NotFoundHandler);
///
/// let request = Request::builder()
///     .method(Method::GET)
///     .uri("/missing")
///     .version(Version::HTTP_11)
///     .headers(HeaderMap::new())
///     .body(Bytes::new())
///     .build()
///     .unwrap();
///
/// let response = middleware.process(request, handler).await.unwrap();
/// assert_eq!(response.status, StatusCode::FOUND);
/// assert_eq!(
///     response.headers.get(hyper::header::LOCATION).unwrap(),
///     "/404"
/// );
/// # });
/// ```
pub struct RedirectFallbackMiddleware {
	config: RedirectResponseConfig,
	compiled_patterns: Option<Vec<Regex>>,
}

impl RedirectFallbackMiddleware {
	/// Create a new RedirectFallbackMiddleware with the given configuration
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::{RedirectFallbackMiddleware, RedirectResponseConfig};
	///
	/// let config = RedirectResponseConfig::new("/404".to_string());
	/// let middleware = RedirectFallbackMiddleware::new(config);
	/// ```
	pub fn new(config: RedirectResponseConfig) -> Self {
		let compiled_patterns = config
			.path_patterns
			.as_ref()
			.map(|patterns| patterns.iter().filter_map(|p| Regex::new(p).ok()).collect());

		Self {
			config,
			compiled_patterns,
		}
	}

	/// Check if the path matches any configured patterns
	fn matches_pattern(&self, path: &str) -> bool {
		match &self.compiled_patterns {
			None => true, // No patterns means match all
			Some(patterns) => patterns.iter().any(|re| re.is_match(path)),
		}
	}

	/// Get the redirect status code to use
	fn redirect_status(&self) -> StatusCode {
		self.config
			.redirect_status
			.and_then(|code| StatusCode::from_u16(code).ok())
			.unwrap_or(StatusCode::FOUND)
	}

	/// Check if we should redirect to avoid loops
	fn should_redirect(&self, path: &str) -> bool {
		// Prevent redirect loop: don't redirect if already at fallback URL
		path != self.config.fallback_url
	}
}

#[async_trait]
impl Middleware for RedirectFallbackMiddleware {
	async fn process(&self, request: Request, handler: Arc<dyn Handler>) -> Result<Response> {
		let path = request.uri.path().to_string();

		// Convert errors to responses so post-processing always runs,
		// even when invoked outside MiddlewareChain. (#3244)
		let response = match handler.handle(request).await {
			Ok(resp) => resp,
			Err(e) => Response::from(e),
		};

		// Only redirect on 404 errors
		if response.status != StatusCode::NOT_FOUND {
			return Ok(response);
		}

		// Check if we should redirect (pattern match and loop prevention)
		if !self.matches_pattern(&path) || !self.should_redirect(&path) {
			return Ok(response);
		}

		// Create redirect response
		let mut redirect_response = Response::new(self.redirect_status());
		redirect_response.headers.insert(
			hyper::header::LOCATION,
			self.config
				.fallback_url
				.parse()
				.unwrap_or_else(|_| hyper::header::HeaderValue::from_static("/")),
		);

		Ok(redirect_response)
	}
}

#[cfg(test)]
mod tests {
	use super::*;
	use bytes::Bytes;
	use hyper::{HeaderMap, Method, StatusCode, Version};

	struct NotFoundHandler;

	#[async_trait]
	impl Handler for NotFoundHandler {
		async fn handle(&self, _request: Request) -> Result<Response> {
			Ok(Response::new(StatusCode::NOT_FOUND))
		}
	}

	struct OkHandler;

	#[async_trait]
	impl Handler for OkHandler {
		async fn handle(&self, _request: Request) -> Result<Response> {
			Ok(Response::new(StatusCode::OK).with_body(Bytes::from("OK")))
		}
	}

	#[tokio::test]
	async fn test_redirect_on_404() {
		let config = RedirectResponseConfig::new("/404".to_string());
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		let request = Request::builder()
			.method(Method::GET)
			.uri("/missing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::FOUND);
		assert_eq!(
			response.headers.get(hyper::header::LOCATION).unwrap(),
			"/404"
		);
	}

	#[tokio::test]
	async fn test_no_redirect_on_200() {
		let config = RedirectResponseConfig::new("/404".to_string());
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(OkHandler);

		let request = Request::builder()
			.method(Method::GET)
			.uri("/existing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::OK);
		assert!(!response.headers.contains_key(hyper::header::LOCATION));
	}

	#[tokio::test]
	async fn test_pattern_matching_redirect() {
		let config = RedirectResponseConfig::new("/404".to_string())
			.with_patterns(vec!["/api/.*".to_string()]);
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Should redirect for /api/* paths
		let request = Request::builder()
			.method(Method::GET)
			.uri("/api/missing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::FOUND);
		assert_eq!(
			response.headers.get(hyper::header::LOCATION).unwrap(),
			"/404"
		);
	}

	#[tokio::test]
	async fn test_pattern_no_match_no_redirect() {
		let config = RedirectResponseConfig::new("/404".to_string())
			.with_patterns(vec!["/api/.*".to_string()]);
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Should NOT redirect for non-/api/* paths
		let request = Request::builder()
			.method(Method::GET)
			.uri("/other/missing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::NOT_FOUND);
		assert!(!response.headers.contains_key(hyper::header::LOCATION));
	}

	#[tokio::test]
	async fn test_custom_redirect_status() {
		let config = RedirectResponseConfig::new("/404".to_string()).with_status(301);
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		let request = Request::builder()
			.method(Method::GET)
			.uri("/missing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::MOVED_PERMANENTLY);
		assert_eq!(
			response.headers.get(hyper::header::LOCATION).unwrap(),
			"/404"
		);
	}

	#[tokio::test]
	async fn test_prevent_redirect_loop() {
		let config = RedirectResponseConfig::new("/404".to_string());
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Request to the fallback URL itself should not redirect
		let request = Request::builder()
			.method(Method::GET)
			.uri("/404")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::NOT_FOUND);
		assert!(!response.headers.contains_key(hyper::header::LOCATION));
	}

	#[tokio::test]
	async fn test_multiple_pattern_matching() {
		let config = RedirectResponseConfig::new("/error".to_string())
			.with_patterns(vec!["/api/.*".to_string(), "/v1/.*".to_string()]);
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Test first pattern
		let request1 = Request::builder()
			.method(Method::GET)
			.uri("/api/test")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response1 = middleware.process(request1, handler.clone()).await.unwrap();
		assert_eq!(response1.status, StatusCode::FOUND);

		// Test second pattern
		let request2 = Request::builder()
			.method(Method::GET)
			.uri("/v1/test")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response2 = middleware.process(request2, handler).await.unwrap();
		assert_eq!(response2.status, StatusCode::FOUND);
	}

	#[tokio::test]
	async fn test_different_http_methods() {
		let config = RedirectResponseConfig::new("/404".to_string());
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Test POST
		let request = Request::builder()
			.method(Method::POST)
			.uri("/missing")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();

		assert_eq!(response.status, StatusCode::FOUND);
		assert_eq!(
			response.headers.get(hyper::header::LOCATION).unwrap(),
			"/404"
		);
	}

	#[tokio::test]
	async fn test_no_patterns_matches_all() {
		let config = RedirectResponseConfig::new("/fallback".to_string());
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Any path should redirect when no patterns are specified
		let paths = vec!["/api/test", "/admin/test", "/any/path/here"];

		for path in paths {
			let request = Request::builder()
				.method(Method::GET)
				.uri(path)
				.version(Version::HTTP_11)
				.headers(HeaderMap::new())
				.body(Bytes::new())
				.build()
				.unwrap();

			let response = middleware.process(request, handler.clone()).await.unwrap();

			assert_eq!(response.status, StatusCode::FOUND);
			assert_eq!(
				response.headers.get(hyper::header::LOCATION).unwrap(),
				"/fallback"
			);
		}
	}

	#[tokio::test]
	async fn test_complex_pattern_matching() {
		let config = RedirectResponseConfig::new("/404".to_string())
			.with_patterns(vec!["/api/v[0-9]+/.*".to_string()]);
		let middleware = RedirectFallbackMiddleware::new(config);
		let handler = Arc::new(NotFoundHandler);

		// Should match /api/v1/, /api/v2/, etc.
		let request1 = Request::builder()
			.method(Method::GET)
			.uri("/api/v1/users")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response1 = middleware.process(request1, handler.clone()).await.unwrap();
		assert_eq!(response1.status, StatusCode::FOUND);

		// Should NOT match /api/version/
		let request2 = Request::builder()
			.method(Method::GET)
			.uri("/api/version/users")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response2 = middleware.process(request2, handler).await.unwrap();
		assert_eq!(response2.status, StatusCode::NOT_FOUND);
	}
}