reinhardt-middleware 0.1.2

Middleware system for request/response processing pipeline
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
//! Messages middleware
//!
//! Provides Django-style flash messages for one-time notifications.
//! Messages can be stored in sessions or cookies and are displayed once.
//!
//! # Middleware Ordering
//!
//! For best results, ensure `SessionMiddleware` runs before `MessageMiddleware`:
//!
//! ```ignore
//! app.middleware(SessionMiddleware::new(config))
//!    .middleware(MessageMiddleware::new(storage));
//! ```
//!
//! This allows `MessageMiddleware` to use the session ID from
//! `SessionMiddleware` via request extensions.

use async_trait::async_trait;
use hyper::header::COOKIE;
use reinhardt_http::{Handler, Middleware, Request, Response, Result};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::sync::{Arc, RwLock};

use crate::session::SessionData;

/// Message header for passing messages between middleware and handlers
pub const MESSAGE_HEADER: &str = "X-Messages";

/// Message severity levels
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
pub enum MessageLevel {
	/// Diagnostic information for developers, not shown to end users.
	Debug,
	/// Informational message for the user.
	Info,
	/// Indicates an operation completed successfully.
	Success,
	/// Indicates a potential issue that the user should be aware of.
	Warning,
	/// Indicates an operation failed or an error occurred.
	Error,
}

/// A single flash message
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Message {
	/// The severity level of this message.
	pub level: MessageLevel,
	/// The message text to display to the user.
	pub text: String,
}

impl Message {
	/// Create a new message
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::messages::{Message, MessageLevel};
	///
	/// let msg = Message::new(MessageLevel::Success, "Saved successfully!".to_string());
	/// assert_eq!(msg.level, MessageLevel::Success);
	/// ```
	pub fn new(level: MessageLevel, text: String) -> Self {
		Self { level, text }
	}

	/// Create a debug message
	pub fn debug(text: String) -> Self {
		Self::new(MessageLevel::Debug, text)
	}

	/// Create an info message
	pub fn info(text: String) -> Self {
		Self::new(MessageLevel::Info, text)
	}

	/// Create a success message
	pub fn success(text: String) -> Self {
		Self::new(MessageLevel::Success, text)
	}

	/// Create a warning message
	pub fn warning(text: String) -> Self {
		Self::new(MessageLevel::Warning, text)
	}

	/// Create an error message
	pub fn error(text: String) -> Self {
		Self::new(MessageLevel::Error, text)
	}
}

/// Message storage trait
pub trait MessageStorage: Send + Sync {
	/// Add a message to storage
	fn add_message(&self, session_id: &str, message: Message);
	/// Get all messages for a session and clear them
	fn get_and_clear_messages(&self, session_id: &str) -> Vec<Message>;
	/// Get messages without clearing
	fn get_messages(&self, session_id: &str) -> Vec<Message>;
}

/// Session-based message storage
///
/// Stores messages in memory keyed by session ID.
/// In production, this should be backed by a persistent session store.
pub struct SessionStorage {
	messages: Arc<RwLock<HashMap<String, Vec<Message>>>>,
}

impl SessionStorage {
	/// Create a new SessionStorage
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::messages::SessionStorage;
	///
	/// let storage = SessionStorage::new();
	/// ```
	pub fn new() -> Self {
		Self {
			messages: Arc::new(RwLock::new(HashMap::new())),
		}
	}
}

impl Default for SessionStorage {
	fn default() -> Self {
		Self::new()
	}
}

impl MessageStorage for SessionStorage {
	fn add_message(&self, session_id: &str, message: Message) {
		let mut messages = self.messages.write().unwrap_or_else(|e| e.into_inner());
		messages
			.entry(session_id.to_string())
			.or_default()
			.push(message);
	}

	fn get_and_clear_messages(&self, session_id: &str) -> Vec<Message> {
		let mut messages = self.messages.write().unwrap_or_else(|e| e.into_inner());
		messages.remove(session_id).unwrap_or_default()
	}

	fn get_messages(&self, session_id: &str) -> Vec<Message> {
		let messages = self.messages.read().unwrap_or_else(|e| e.into_inner());
		messages.get(session_id).cloned().unwrap_or_default()
	}
}

/// Cookie-based message storage
///
/// Stores messages in memory similar to SessionStorage but designed
/// to be serialized to cookies in production.
pub struct CookieStorage {
	messages: Arc<RwLock<HashMap<String, Vec<Message>>>>,
}

impl CookieStorage {
	/// Create a new CookieStorage
	///
	/// # Examples
	///
	/// ```
	/// use reinhardt_middleware::messages::CookieStorage;
	///
	/// let storage = CookieStorage::new();
	/// ```
	pub fn new() -> Self {
		Self {
			messages: Arc::new(RwLock::new(HashMap::new())),
		}
	}
}

impl Default for CookieStorage {
	fn default() -> Self {
		Self::new()
	}
}

impl MessageStorage for CookieStorage {
	fn add_message(&self, session_id: &str, message: Message) {
		let mut messages = self.messages.write().unwrap_or_else(|e| e.into_inner());
		messages
			.entry(session_id.to_string())
			.or_default()
			.push(message);
	}

	fn get_and_clear_messages(&self, session_id: &str) -> Vec<Message> {
		let mut messages = self.messages.write().unwrap_or_else(|e| e.into_inner());
		messages.remove(session_id).unwrap_or_default()
	}

	fn get_messages(&self, session_id: &str) -> Vec<Message> {
		let messages = self.messages.read().unwrap_or_else(|e| e.into_inner());
		messages.get(session_id).cloned().unwrap_or_default()
	}
}

/// Message framework middleware
///
/// Provides flash message functionality similar to Django's messages framework.
///
/// # Examples
///
/// ```
/// use std::sync::Arc;
/// use reinhardt_middleware::messages::{MessageMiddleware, SessionStorage, Message, MessageLevel};
/// use reinhardt_http::{Handler, Middleware, Request, Response};
/// use hyper::{StatusCode, Method, Version, HeaderMap};
/// use bytes::Bytes;
///
/// struct TestHandler {
///     storage: Arc<dyn reinhardt_middleware::messages::MessageStorage>,
/// }
///
/// #[async_trait::async_trait]
/// impl Handler for TestHandler {
///     async fn handle(&self, _request: Request) -> reinhardt_core::exception::Result<Response> {
///         // Add a message
///         self.storage.add_message("test-session", Message::success("Operation successful!".to_string()));
///         Ok(Response::new(StatusCode::OK).with_body(Bytes::from("OK")))
///     }
/// }
///
/// # tokio_test::block_on(async {
/// let storage: Arc<dyn reinhardt_middleware::messages::MessageStorage> = Arc::new(SessionStorage::new());
/// let middleware = MessageMiddleware::new(storage.clone());
/// let handler = Arc::new(TestHandler { storage: storage.clone() });
///
/// let mut headers = HeaderMap::new();
/// headers.insert(hyper::header::COOKIE, "sessionid=test-session".parse().unwrap());
///
/// let request = Request::builder()
///     .method(Method::GET)
///     .uri("/page")
///     .version(Version::HTTP_11)
///     .headers(headers)
///     .body(Bytes::new())
///     .build()
///     .unwrap();
///
/// let _response = middleware.process(request, handler).await.unwrap();
/// let messages = storage.get_and_clear_messages("test-session");
/// assert_eq!(messages.len(), 1);
/// assert_eq!(messages[0].level, MessageLevel::Success);
/// # });
/// ```
// Allow dead_code: public API for middleware pipeline integration, not yet wired into default stack
#[allow(dead_code)]
pub struct MessageMiddleware {
	storage: Arc<dyn MessageStorage>,
}

impl MessageMiddleware {
	/// Create a new MessageMiddleware with the given storage backend
	///
	/// # Examples
	///
	/// ```
	/// use std::sync::Arc;
	/// use reinhardt_middleware::messages::{MessageMiddleware, SessionStorage};
	///
	/// let storage = Arc::new(SessionStorage::new());
	/// let middleware = MessageMiddleware::new(storage);
	/// ```
	pub fn new(storage: Arc<dyn MessageStorage>) -> Self {
		Self { storage }
	}

	/// Extract session ID from request
	///
	/// This method first checks for `SessionData` in request extensions
	/// (set by `SessionMiddleware`), then falls back to cookie extraction.
	fn get_session_id(request: &Request) -> String {
		// Check for SessionData set by SessionMiddleware
		if let Some(session_data) = request.extensions.get::<SessionData>() {
			return session_data.id.clone();
		}

		// Fallback: extract from cookie
		request
			.headers
			.get(COOKIE)
			.and_then(|c| c.to_str().ok())
			.and_then(|cookies| {
				for cookie in cookies.split(';') {
					let cookie = cookie.trim();
					if let Some((name, value)) = cookie.split_once('=')
						&& name == "sessionid"
					{
						return Some(value.to_string());
					}
				}
				None
			})
			.unwrap_or_else(|| "default".to_string())
	}
}

#[async_trait]
impl Middleware for MessageMiddleware {
	async fn process(&self, request: Request, handler: Arc<dyn Handler>) -> Result<Response> {
		let _session_id = Self::get_session_id(&request);

		// Convert errors to responses so post-processing always runs,
		// even when invoked outside MiddlewareChain. (#3244)
		let response = match handler.handle(request).await {
			Ok(resp) => resp,
			Err(e) => Response::from(e),
		};

		// Messages are stored in the storage and can be retrieved by handlers
		// In a complete implementation, we'd add messages to the response or template context
		Ok(response)
	}
}

#[cfg(test)]
mod tests {
	use super::*;
	use bytes::Bytes;
	use hyper::{HeaderMap, Method, StatusCode, Version};

	#[test]
	fn test_message_creation() {
		let msg = Message::debug("Debug message".to_string());
		assert_eq!(msg.level, MessageLevel::Debug);

		let msg = Message::info("Info message".to_string());
		assert_eq!(msg.level, MessageLevel::Info);

		let msg = Message::success("Success message".to_string());
		assert_eq!(msg.level, MessageLevel::Success);

		let msg = Message::warning("Warning message".to_string());
		assert_eq!(msg.level, MessageLevel::Warning);

		let msg = Message::error("Error message".to_string());
		assert_eq!(msg.level, MessageLevel::Error);
	}

	#[test]
	fn test_session_storage_add_and_get() {
		let storage = SessionStorage::new();
		let session_id = "test-session";

		storage.add_message(session_id, Message::info("Message 1".to_string()));
		storage.add_message(session_id, Message::success("Message 2".to_string()));

		let messages = storage.get_messages(session_id);
		assert_eq!(messages.len(), 2);
		assert_eq!(messages[0].level, MessageLevel::Info);
		assert_eq!(messages[1].level, MessageLevel::Success);
	}

	#[test]
	fn test_session_storage_clear() {
		let storage = SessionStorage::new();
		let session_id = "test-session";

		storage.add_message(session_id, Message::info("Message 1".to_string()));
		storage.add_message(session_id, Message::info("Message 2".to_string()));

		let messages = storage.get_and_clear_messages(session_id);
		assert_eq!(messages.len(), 2);

		// Messages should be cleared
		let messages = storage.get_messages(session_id);
		assert_eq!(messages.len(), 0);
	}

	#[test]
	fn test_cookie_storage_add_and_get() {
		let storage = CookieStorage::new();
		let session_id = "test-session";

		storage.add_message(session_id, Message::warning("Warning 1".to_string()));
		storage.add_message(session_id, Message::error("Error 1".to_string()));

		let messages = storage.get_messages(session_id);
		assert_eq!(messages.len(), 2);
		assert_eq!(messages[0].level, MessageLevel::Warning);
		assert_eq!(messages[1].level, MessageLevel::Error);
	}

	#[test]
	fn test_cookie_storage_clear() {
		let storage = CookieStorage::new();
		let session_id = "test-session";

		storage.add_message(session_id, Message::info("Info 1".to_string()));

		let messages = storage.get_and_clear_messages(session_id);
		assert_eq!(messages.len(), 1);

		// Messages should be cleared
		let messages = storage.get_messages(session_id);
		assert_eq!(messages.len(), 0);
	}

	#[test]
	fn test_separate_sessions() {
		let storage = SessionStorage::new();

		storage.add_message("session1", Message::info("Session 1 message".to_string()));
		storage.add_message(
			"session2",
			Message::success("Session 2 message".to_string()),
		);

		let messages1 = storage.get_messages("session1");
		let messages2 = storage.get_messages("session2");

		assert_eq!(messages1.len(), 1);
		assert_eq!(messages2.len(), 1);
		assert_eq!(messages1[0].level, MessageLevel::Info);
		assert_eq!(messages2[0].level, MessageLevel::Success);
	}

	struct TestHandler {
		storage: Arc<dyn MessageStorage>,
	}

	#[async_trait]
	impl Handler for TestHandler {
		async fn handle(&self, request: Request) -> Result<Response> {
			let session_id = MessageMiddleware::get_session_id(&request);
			self.storage
				.add_message(&session_id, Message::success("Test message".to_string()));
			Ok(Response::new(StatusCode::OK).with_body(Bytes::from("OK")))
		}
	}

	#[tokio::test]
	async fn test_middleware_with_session_storage() {
		let storage: Arc<dyn MessageStorage> = Arc::new(SessionStorage::new());
		let middleware = MessageMiddleware::new(storage.clone());
		let handler = Arc::new(TestHandler {
			storage: storage.clone(),
		});

		let mut headers = HeaderMap::new();
		headers.insert(COOKIE, "sessionid=test-session".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/page")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();
		assert_eq!(response.status, StatusCode::OK);

		// Verify message was stored
		let messages = storage.get_and_clear_messages("test-session");
		assert_eq!(messages.len(), 1);
		assert_eq!(messages[0].level, MessageLevel::Success);
	}

	#[tokio::test]
	async fn test_middleware_default_session() {
		let storage: Arc<dyn MessageStorage> = Arc::new(SessionStorage::new());
		let middleware = MessageMiddleware::new(storage.clone());
		let handler = Arc::new(TestHandler {
			storage: storage.clone(),
		});

		// No session cookie
		let request = Request::builder()
			.method(Method::GET)
			.uri("/page")
			.version(Version::HTTP_11)
			.headers(HeaderMap::new())
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();
		assert_eq!(response.status, StatusCode::OK);

		// Should use default session
		let messages = storage.get_messages("default");
		assert_eq!(messages.len(), 1);
	}

	#[tokio::test]
	async fn test_middleware_with_cookie_storage() {
		let storage: Arc<dyn MessageStorage> = Arc::new(CookieStorage::new());
		let middleware = MessageMiddleware::new(storage.clone());
		let handler = Arc::new(TestHandler {
			storage: storage.clone(),
		});

		let mut headers = HeaderMap::new();
		headers.insert(COOKIE, "sessionid=cookie-session".parse().unwrap());

		let request = Request::builder()
			.method(Method::GET)
			.uri("/page")
			.version(Version::HTTP_11)
			.headers(headers)
			.body(Bytes::new())
			.build()
			.unwrap();

		let response = middleware.process(request, handler).await.unwrap();
		assert_eq!(response.status, StatusCode::OK);

		// Verify message was stored
		let messages = storage.get_and_clear_messages("cookie-session");
		assert_eq!(messages.len(), 1);
		assert_eq!(messages[0].level, MessageLevel::Success);
	}
}