rav1d-safe 0.5.5

Safe SIMD fork of rav1d - Rust AV1 decoder with archmage intrinsics
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
//! Safe ARM NEON rectangular inverse transforms (8x32, 32x8, 16x32, 32x16)
//!
//! Port of the large rectangular inverse transform functions from `src/arm/64/itx.S`
//! to safe Rust NEON intrinsics. Only DCT_DCT and Identity_Identity are valid for
//! blocks with a 32-wide dimension.
//!
//! **8x32** (8 columns, 32 rows):
//!   - Row transform: 8-point on 8h, with scale_input
//!   - Column transform: 32-point on 8h
//!   - Uses scratch buffer for intermediate results
//!
//! **32x8** (32 columns, 8 rows):
//!   - Row transform: 32-point DCT on 8h
//!   - Column transform: 8-point on 8h
//!   - Uses scratch buffer for intermediate results
//!
//! **16x32** (16 columns, 32 rows):
//!   - Row transform: 16-point on 8h
//!   - Column transform: 32-point on 8h
//!   - Uses scratch buffer for intermediate results
//!
//! **32x16** (32 columns, 16 rows):
//!   - Row transform: 32-point DCT on 8h
//!   - Column transform: 16-point on 8h
//!   - Uses scratch buffer for intermediate results

#![allow(clippy::too_many_arguments)]
#![cfg_attr(not(feature = "unchecked"), forbid(unsafe_code))]
#![cfg_attr(feature = "unchecked", deny(unsafe_code))]

#[cfg(target_arch = "aarch64")]
use core::arch::aarch64::*;

#[cfg(target_arch = "aarch64")]
use archmage::{Arm64, arcane, rite};

#[cfg(target_arch = "aarch64")]
use safe_unaligned_simd::aarch64 as safe_simd;

use super::itx_arm_neon_8x8::idct_8_q;
use super::itx_arm_neon_8x8::transpose_8x8h;
use super::itx_arm_neon_16x16::idct_16_q;
use super::itx_arm_neon_32::{
    V16, horz_dct_32x8, idct32_odd_q, load_v16, rev128_s16, store_v16, vert_dct_add_8x32_8bpc,
    vert_dct_add_8x32_16bpc,
};

// ============================================================================
// DC-only fast paths
// ============================================================================

/// DC-only fast path for DCT_DCT rectangular blocks (8bpc).
///
/// For 8x32/32x8: shift=2 (one level of scaling per dimension)
/// For 16x32/32x16: shift=2
/// These all use rect2 scaling (extra sqrdmulh for 2:1 ratio).
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn dc_only_large_rect_8bpc(
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    w: usize,
    h: usize,
    shift: i32,
) {
    let dc = coeff[0];
    coeff[0] = 0;

    let scale = vdupq_n_s16((2896 * 8) as i16);
    let v = vdupq_n_s16(dc);

    // First sqrdmulh
    let v = vqrdmulhq_s16(v, scale);
    // For ratio >1: extra rect2 sqrdmulh
    let v = vqrdmulhq_s16(v, scale);
    // Apply shift
    let v = match shift {
        1 => vrshrq_n_s16::<1>(v),
        2 => vrshrq_n_s16::<2>(v),
        _ => v,
    };
    // Second sqrdmulh
    let v = vqrdmulhq_s16(v, scale);
    // Final srshr >>4
    let v = vrshrq_n_s16::<4>(v);

    for y in 0..h {
        let row_off = dst_base.wrapping_add_signed(y as isize * dst_stride);
        for half in 0..(w / 8) {
            let off = row_off + half * 8;
            let dst_bytes: [u8; 8] = dst[off..off + 8].try_into().unwrap();
            let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
            let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(v), dst_u8));
            let result = vqmovun_s16(sum);
            let mut out = [0u8; 8];
            safe_simd::vst1_u8(&mut out, result);
            dst[off..off + 8].copy_from_slice(&out);
        }
    }
}

/// DC-only fast path for DCT_DCT rectangular blocks (16bpc).
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn dc_only_large_rect_16bpc(
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i32],
    w: usize,
    h: usize,
    shift: i32,
    bitdepth_max: i32,
) {
    let dc_val = coeff[0];
    coeff[0] = 0;

    let scale = 2896i32 * 8;
    let mut dc = ((dc_val as i64 * scale as i64 + 16384) >> 15) as i32;
    // Extra rect2 sqrdmulh
    dc = ((dc as i64 * scale as i64 + 16384) >> 15) as i32;
    // Apply shift
    dc = match shift {
        1 => (dc + 1) >> 1,
        2 => (dc + 2) >> 2,
        _ => dc,
    };
    // Second sqrdmulh
    dc = ((dc as i64 * scale as i64 + 16384) >> 15) as i32;
    // Final shift
    dc = (dc + 8) >> 4;

    let dc = dc.clamp(i16::MIN as i32, i16::MAX as i32) as i16;
    let dc_vec = vdupq_n_s16(dc);
    let bd_max = vdupq_n_s16(bitdepth_max as i16);
    let zero = vdupq_n_s16(0);

    for y in 0..h {
        let row_off = dst_base.wrapping_add_signed(y as isize * dst_stride);
        for half in 0..(w / 8) {
            let off = row_off + half * 8;
            let mut arr = [0i16; 8];
            for j in 0..8 {
                arr[j] = dst[off + j] as i16;
            }
            let d = safe_simd::vld1q_s16(&arr);
            let sum = vqaddq_s16(d, dc_vec);
            let clamped = vminq_s16(vmaxq_s16(sum, zero), bd_max);
            let mut out_arr = [0i16; 8];
            safe_simd::vst1q_s16(&mut out_arr, clamped);
            for j in 0..8 {
                dst[off + j] = out_arr[j] as u16;
            }
        }
    }
}

// ============================================================================
// Scale input helper (for 8 vectors)
// ============================================================================

/// Scale 8 int16x8_t vectors by 2896*8 using sqrdmulh.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn scale_input_q_8(v: &mut [int16x8_t; 8]) {
    let scale = vdupq_n_s16((2896 * 8) as i16);
    for vi in v.iter_mut() {
        *vi = vqrdmulhq_s16(*vi, scale);
    }
}

/// Scale 16 int16x8_t vectors by 2896*8 using sqrdmulh.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn scale_input_q_16(v: &mut [int16x8_t; 16]) {
    let scale = vdupq_n_s16((2896 * 8) as i16);
    for vi in v.iter_mut() {
        *vi = vqrdmulhq_s16(*vi, scale);
    }
}

// ============================================================================
// Add-to-destination helpers
// ============================================================================

/// Add 8 rows of 8 pixels to destination (8bpc) with shift>>4.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn add_to_dst_8x8_8bpc(dst: &mut [u8], dst_base: usize, stride: isize, v: [int16x8_t; 8]) {
    for (i, &row) in v.iter().enumerate() {
        let row_off = dst_base.wrapping_add_signed(i as isize * stride);
        let shifted = vrshrq_n_s16::<4>(row);
        let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
        let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
        let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
        let result = vqmovun_s16(sum);
        let mut out = [0u8; 8];
        safe_simd::vst1_u8(&mut out, result);
        dst[row_off..row_off + 8].copy_from_slice(&out);
    }
}

/// Add 16 rows of 8 pixels to destination (8bpc) with shift>>4.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn add_to_dst_8x16_8bpc(dst: &mut [u8], dst_base: usize, stride: isize, v: [int16x8_t; 16]) {
    for (i, &row) in v.iter().enumerate() {
        let row_off = dst_base.wrapping_add_signed(i as isize * stride);
        let shifted = vrshrq_n_s16::<4>(row);
        let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
        let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
        let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
        let result = vqmovun_s16(sum);
        let mut out = [0u8; 8];
        safe_simd::vst1_u8(&mut out, result);
        dst[row_off..row_off + 8].copy_from_slice(&out);
    }
}

// ============================================================================
// Horizontal 8-point row transform for 8x32 (on 8 rows at a time)
// ============================================================================

/// Horizontal DCT-8 on 8 rows of 8 coefficients.
///
/// For 8x32: coeff layout is column-major (coeff[row + col * 32]).
/// Loads 8 columns x 8 rows, applies scale_input, then 8-point DCT,
/// srshr>>1, transposes, and stores to scratch.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn horz_dct8_for_8x32(
    coeff: &mut [i16],
    coeff_base: usize,
    coeff_stride: usize,
    scratch: &mut [i16],
    scratch_base: usize,
    scratch_stride: usize,
) {
    let zero_vec = vdupq_n_s16(0);

    // Load 8 columns, 8 rows each
    let mut v = [zero_vec; 8];
    for c in 0..8 {
        let base = coeff_base + c * coeff_stride;
        let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
        v[c] = safe_simd::vld1q_s16(&arr);
        coeff[base..base + 8].fill(0);
    }

    // Scale input
    scale_input_q_8(&mut v);

    // Apply 8-point DCT
    let (r0, r1, r2, r3, r4, r5, r6, r7) = idct_8_q(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7]);

    // srshr>>1 (rectangular normalization)
    let r0 = vrshrq_n_s16::<1>(r0);
    let r1 = vrshrq_n_s16::<1>(r1);
    let r2 = vrshrq_n_s16::<1>(r2);
    let r3 = vrshrq_n_s16::<1>(r3);
    let r4 = vrshrq_n_s16::<1>(r4);
    let r5 = vrshrq_n_s16::<1>(r5);
    let r6 = vrshrq_n_s16::<1>(r6);
    let r7 = vrshrq_n_s16::<1>(r7);

    // Transpose 8x8
    let (t0, t1, t2, t3, t4, t5, t6, t7) = transpose_8x8h(r0, r1, r2, r3, r4, r5, r6, r7);

    // Store to scratch
    let rows = [t0, t1, t2, t3, t4, t5, t6, t7];
    for (i, &row) in rows.iter().enumerate() {
        store_v16(scratch, scratch_base + i * scratch_stride, row);
    }
}

/// Horizontal DCT-16 on 8 rows of 16 coefficients.
///
/// For 16x32: coeff layout is column-major (coeff[row + col * 32]).
/// Loads 16 columns x 8 rows, applies scale_input, then 16-point DCT,
/// srshr>>1, transposes in two 8x8 blocks, and stores to scratch.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn horz_dct16_for_16x32(
    coeff: &mut [i16],
    coeff_base: usize,
    coeff_stride: usize,
    scratch: &mut [i16],
    scratch_base: usize,
    scratch_stride: usize,
) {
    let zero_vec = vdupq_n_s16(0);

    // Load 16 columns, 8 rows each
    let mut v: V16 = [zero_vec; 16];
    for c in 0..16 {
        let base = coeff_base + c * coeff_stride;
        let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
        v[c] = safe_simd::vld1q_s16(&arr);
        coeff[base..base + 8].fill(0);
    }

    // Scale input
    scale_input_q_16(&mut v);

    // Apply 16-point DCT
    let result = idct_16_q(v);

    // srshr>>1
    let mut shifted = [zero_vec; 16];
    for i in 0..16 {
        shifted[i] = vrshrq_n_s16::<1>(result[i]);
    }

    // Transpose first 8x8 block (cols 0-7)
    let (t0, t1, t2, t3, t4, t5, t6, t7) = transpose_8x8h(
        shifted[0], shifted[1], shifted[2], shifted[3], shifted[4], shifted[5], shifted[6],
        shifted[7],
    );
    let first = [t0, t1, t2, t3, t4, t5, t6, t7];
    for (i, &row) in first.iter().enumerate() {
        store_v16(scratch, scratch_base + i * scratch_stride, row);
    }

    // Transpose second 8x8 block (cols 8-15)
    let (t0, t1, t2, t3, t4, t5, t6, t7) = transpose_8x8h(
        shifted[8],
        shifted[9],
        shifted[10],
        shifted[11],
        shifted[12],
        shifted[13],
        shifted[14],
        shifted[15],
    );
    let second = [t0, t1, t2, t3, t4, t5, t6, t7];
    for (i, &row) in second.iter().enumerate() {
        store_v16(scratch, scratch_base + i * scratch_stride + 8, row);
    }
}

// ============================================================================
// Vertical 16-point column transform + add to destination
// ============================================================================

/// Vertical DCT-16 on 8 columns from scratch, add to 8bpc destination.
///
/// For 32x16 col transform: reads 16 rows x 8 cols from scratch,
/// applies 16-point DCT, shifts >>4, adds to destination.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn vert_dct16_add_8x16_8bpc(
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    scratch: &[i16],
    scratch_base: usize,
    scratch_stride: usize,
) {
    let zero_vec = vdupq_n_s16(0);

    // Load 16 rows of 8 values each
    let mut v: V16 = [zero_vec; 16];
    for i in 0..16 {
        v[i] = load_v16(scratch, scratch_base + i * scratch_stride);
    }

    // Apply 16-point DCT
    let result = idct_16_q(v);

    // Add to destination with shift>>4
    add_to_dst_8x16_8bpc(dst, dst_base, dst_stride, result);
}

/// Vertical DCT-16 on 8 columns from scratch, add to 16bpc destination.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn vert_dct16_add_8x16_16bpc(
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    scratch: &[i16],
    scratch_base: usize,
    scratch_stride: usize,
    bitdepth_max: i32,
) {
    let zero_vec = vdupq_n_s16(0);
    let bd_max = vdupq_n_s16(bitdepth_max as i16);
    let zero = vdupq_n_s16(0);

    // Load 16 rows
    let mut v: V16 = [zero_vec; 16];
    for i in 0..16 {
        v[i] = load_v16(scratch, scratch_base + i * scratch_stride);
    }

    let result = idct_16_q(v);

    // Add to destination
    for i in 0..16 {
        let shifted = vrshrq_n_s16::<4>(result[i]);
        let row_off = dst_base.wrapping_add_signed(i as isize * dst_stride);
        let mut arr = [0i16; 8];
        for j in 0..8 {
            arr[j] = dst[row_off + j] as i16;
        }
        let d = safe_simd::vld1q_s16(&arr);
        let sum = vqaddq_s16(d, shifted);
        let clamped = vminq_s16(vmaxq_s16(sum, zero), bd_max);
        let mut out = [0i16; 8];
        safe_simd::vst1q_s16(&mut out, clamped);
        for j in 0..8 {
            dst[row_off + j] = out[j] as u16;
        }
    }
}

/// Vertical 8-point DCT on 8 columns from scratch, add to 8bpc destination.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn vert_dct8_add_8x8_8bpc(
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    scratch: &[i16],
    scratch_base: usize,
    scratch_stride: usize,
) {
    // Load 8 rows
    let v0 = load_v16(scratch, scratch_base);
    let v1 = load_v16(scratch, scratch_base + scratch_stride);
    let v2 = load_v16(scratch, scratch_base + 2 * scratch_stride);
    let v3 = load_v16(scratch, scratch_base + 3 * scratch_stride);
    let v4 = load_v16(scratch, scratch_base + 4 * scratch_stride);
    let v5 = load_v16(scratch, scratch_base + 5 * scratch_stride);
    let v6 = load_v16(scratch, scratch_base + 6 * scratch_stride);
    let v7 = load_v16(scratch, scratch_base + 7 * scratch_stride);

    // Apply 8-point DCT
    let (r0, r1, r2, r3, r4, r5, r6, r7) = idct_8_q(v0, v1, v2, v3, v4, v5, v6, v7);

    // Add to destination
    add_to_dst_8x8_8bpc(dst, dst_base, dst_stride, [r0, r1, r2, r3, r4, r5, r6, r7]);
}

/// Vertical 8-point DCT on 8 columns from scratch, add to 16bpc destination.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn vert_dct8_add_8x8_16bpc(
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    scratch: &[i16],
    scratch_base: usize,
    scratch_stride: usize,
    bitdepth_max: i32,
) {
    let bd_max = vdupq_n_s16(bitdepth_max as i16);
    let zero = vdupq_n_s16(0);

    // Load 8 rows
    let v0 = load_v16(scratch, scratch_base);
    let v1 = load_v16(scratch, scratch_base + scratch_stride);
    let v2 = load_v16(scratch, scratch_base + 2 * scratch_stride);
    let v3 = load_v16(scratch, scratch_base + 3 * scratch_stride);
    let v4 = load_v16(scratch, scratch_base + 4 * scratch_stride);
    let v5 = load_v16(scratch, scratch_base + 5 * scratch_stride);
    let v6 = load_v16(scratch, scratch_base + 6 * scratch_stride);
    let v7 = load_v16(scratch, scratch_base + 7 * scratch_stride);

    let (r0, r1, r2, r3, r4, r5, r6, r7) = idct_8_q(v0, v1, v2, v3, v4, v5, v6, v7);
    let rows = [r0, r1, r2, r3, r4, r5, r6, r7];

    for (i, &row) in rows.iter().enumerate() {
        let shifted = vrshrq_n_s16::<4>(row);
        let row_off = dst_base.wrapping_add_signed(i as isize * dst_stride);
        let mut arr = [0i16; 8];
        for j in 0..8 {
            arr[j] = dst[row_off + j] as i16;
        }
        let d = safe_simd::vld1q_s16(&arr);
        let sum = vqaddq_s16(d, shifted);
        let clamped = vminq_s16(vmaxq_s16(sum, zero), bd_max);
        let mut out = [0i16; 8];
        safe_simd::vst1q_s16(&mut out, clamped);
        for j in 0..8 {
            dst[row_off + j] = out[j] as u16;
        }
    }
}

// ============================================================================
// 8x32 DCT_DCT (8 columns, 32 rows)
// ============================================================================

/// NEON implementation of 8x32 DCT_DCT inverse transform add for 8bpc.
///
/// Row transform: 8-point DCT on 8h with scale_input + srshr>>1
/// Column transform: 32-point DCT on 8h
/// eob thresholds: [36, 136, 300, 1024] for the 4 column groups (here only 1 group of 8 cols)
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_8x32_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    // DC-only fast path
    if eob == 0 {
        dc_only_large_rect_8bpc(dst, dst_base, dst_stride, coeff, 8, 32, 1);
        return;
    }

    // eob thresholds for 8x32 row groups (32 rows in 4 groups of 8)
    let eob_thresholds: [i32; 4] = [36, 136, 300, 1024];

    // Scratch: 32 rows x 8 columns
    let mut scratch = [0i16; 256];

    // Row transform: process 4 groups of 8 rows
    for group in 0..4 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }

        // coeff layout is column-major: coeff[row + col * 32]
        horz_dct8_for_8x32(
            coeff,
            row_start,
            32, // coeff_stride = height = 32
            &mut scratch,
            row_start * 8, // scratch offset (row-major, 8 i16/row)
            8,             // scratch_stride
        );
    }

    // Column transform: single group of 8 columns
    vert_dct_add_8x32_8bpc(
        dst, dst_base, dst_stride, &scratch, 0, 8, // scratch_stride = 8
    );
}

/// NEON implementation of 8x32 DCT_DCT for 16bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_8x32_16bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i32],
    eob: i32,
    bitdepth_max: i32,
) {
    // DC-only fast path
    if eob == 0 {
        dc_only_large_rect_16bpc(dst, dst_base, dst_stride, coeff, 8, 32, 1, bitdepth_max);
        return;
    }

    // For 16bpc, coeff is i32. Convert to i16 scratch for the NEON transform.
    // The 8-point row transform has limited dynamic range, so i16 is sufficient
    // after proper scaling.
    let mut scratch = [0i16; 256];

    let eob_thresholds: [i32; 4] = [36, 136, 300, 1024];

    // Row transform: scalar i32 -> i16 scratch
    for group in 0..4 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }

        // Convert i32 coeff to i16 for this group, do scalar row transform
        for r in 0..8 {
            let y = row_start + r;
            let mut input = [0i32; 8];
            for x in 0..8 {
                input[x] = coeff[y + x * 32];
                coeff[y + x * 32] = 0;
            }
            // scale_input: sqrdmulh by 2896*8
            let scale = 2896i64 * 8;
            for val in input.iter_mut() {
                *val = ((*val as i64 * scale + 16384) >> 15) as i32;
            }
            // 8-point DCT (scalar)
            let out = scalar_dct8_1d(&input);
            // srshr>>1
            for x in 0..8 {
                let v = (out[x] + 1) >> 1;
                scratch[(y * 8 + x) as usize] = v.clamp(i16::MIN as i32, i16::MAX as i32) as i16;
            }
        }
    }

    // Column transform: 32-point DCT on NEON
    vert_dct_add_8x32_16bpc(dst, dst_base, dst_stride, &scratch, 0, 8, bitdepth_max);
}

// ============================================================================
// 32x8 DCT_DCT (32 columns, 8 rows)
// ============================================================================

/// NEON implementation of 32x8 DCT_DCT inverse transform add for 8bpc.
///
/// Row transform: 32-point DCT on 8h (reuses horz_dct_32x8 from 32x32)
/// Column transform: 8-point DCT on 8h
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_32x8_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_8bpc(dst, dst_base, dst_stride, coeff, 32, 8, 1);
        return;
    }

    // Scratch: 8 rows x 32 columns
    let mut scratch = [0i16; 256];

    // Row transform: single group of 8 rows, 32-point DCT
    // coeff layout is column-major: coeff[row + col * 8]
    horz_dct_32x8(
        coeff,
        0, // coeff_base
        8, // coeff_stride = height = 8
        &mut scratch,
        0, // scratch_base
        1, // shift=1 for rect2. Actually horz_dct_32x8 uses shift param.
           // Let's check: it uses vrshrq_n_s16::<2> hardcoded.
           // For 32x8 we need shift=1 not shift=2.
    );

    // Wait - horz_dct_32x8 hardcodes vrshrq_n_s16::<2> (shift=2 for 32x32).
    // For 32x8 we need shift=1. We need a different approach.
    // Let me re-implement the horizontal pass with correct shift.

    // Actually, looking at the assembly, for 32x8 the shift should be:
    // row_shift = 2 (for 32-point) BUT the rect2 scaling changes this.
    // For 32x8 (ratio 4:1): shift=1 per the assembly's `def_fn_32x8`.
    // But horz_dct_32x8 hardcodes shift=2.
    //
    // Since horz_dct_32x8 ignores its shift parameter (see `let _ = shift;`),
    // we need to redo this differently.
    //
    // Actually, let me re-read. The scratch is the output of the row transform.
    // After the row transform, a shift is applied. For 32x32 it's >>2, for 32x8 it's >>1.
    // The column transform then applies >>4 when adding to dest.
    //
    // Total shift: row_shift + 4 = total. For 32x8, the spec says total shift = 5 (>>256 = >>9).
    // hmm, (shift_row + shift_col) should match. Let me use the correct
    // approach: call horz_dct_32x8 which applies >>2, and for the column
    // transform the >>4 gives total >>6. But the scalar uses >>9.
    // That means row produces 1D output, and the final >>9 = (row_shift + col_shift).
    //
    // The NEON approach from 32x32 applies:
    //   row: >>2 in scratch
    //   col: >>4 when adding to dest
    //   total: >>6. But 32x32 scalar uses >>10 total.
    //   Hmm, the NEON row transform produces values in a different scale.
    //
    // Let me just use the simpler approach for 32x8:
    // Use the scalar row transform, then NEON column add.

    // Actually, let me reconsider. I'll re-implement the scratch properly.
    // For now, clear scratch and redo.
    scratch.fill(0);

    horz_32x8_rect(coeff, 0, 8, &mut scratch, 0);

    // Column transform: 4 groups of 8 columns
    for group in 0..4 {
        let col_start = group * 8;
        vert_dct8_add_8x8_8bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            32, // scratch_stride = 32 (32 i16 per row)
        );
    }
}

/// Horizontal 32-point DCT on 8 rows for rectangular 32x8 (shift=1).
///
/// Same as horz_dct_32x8 from the 32x32 module but with >>1 shift for rect2.
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn horz_32x8_rect(
    coeff: &mut [i16],
    coeff_base: usize,
    coeff_stride: usize,
    scratch: &mut [i16],
    scratch_base: usize,
) {
    let zero_vec = vdupq_n_s16(0);

    // Phase 1: Load even-indexed columns for 8 rows
    let mut even_in: V16 = [zero_vec; 16];
    for c in 0..16 {
        let col = c * 2;
        let base = coeff_base + col * coeff_stride;
        let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
        even_in[c] = safe_simd::vld1q_s16(&arr);
        coeff[base..base + 8].fill(0);
    }

    let even_out = idct_16_q(even_in);

    // Transpose even results
    let (et0, et1, et2, et3, et4, et5, et6, et7) = transpose_8x8h(
        even_out[0],
        even_out[1],
        even_out[2],
        even_out[3],
        even_out[4],
        even_out[5],
        even_out[6],
        even_out[7],
    );
    let (et8, et9, et10, et11, et12, et13, et14, et15) = transpose_8x8h(
        even_out[8],
        even_out[9],
        even_out[10],
        even_out[11],
        even_out[12],
        even_out[13],
        even_out[14],
        even_out[15],
    );

    let even_t = [
        [et0, et8],
        [et1, et9],
        [et2, et10],
        [et3, et11],
        [et4, et12],
        [et5, et13],
        [et6, et14],
        [et7, et15],
    ];

    // Phase 2: Load odd-indexed columns
    let mut odd_in: V16 = [zero_vec; 16];
    for c in 0..16 {
        let col = c * 2 + 1;
        let base = coeff_base + col * coeff_stride;
        let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
        odd_in[c] = safe_simd::vld1q_s16(&arr);
        coeff[base..base + 8].fill(0);
    }

    let odd_out = idct32_odd_q(odd_in);

    // Transpose odd in reverse order
    let (ot15, ot14, ot13, ot12, ot11, ot10, ot9, ot8) = transpose_8x8h(
        odd_out[15],
        odd_out[14],
        odd_out[13],
        odd_out[12],
        odd_out[11],
        odd_out[10],
        odd_out[9],
        odd_out[8],
    );
    let (ot7, ot6, ot5, ot4, ot3, ot2, ot1, ot0) = transpose_8x8h(
        odd_out[7], odd_out[6], odd_out[5], odd_out[4], odd_out[3], odd_out[2], odd_out[1],
        odd_out[0],
    );

    let odd_t_hi = [ot15, ot14, ot13, ot12, ot11, ot10, ot9, ot8];
    let odd_t_lo = [ot7, ot6, ot5, ot4, ot3, ot2, ot1, ot0];

    // Phase 3: Butterfly combine with >>1 shift (rect2)
    for row in 0..8 {
        let e_lo = even_t[row][0];
        let e_hi = even_t[row][1];
        let o_hi = odd_t_hi[row];
        let o_lo = odd_t_lo[row];

        let first_lo = vqaddq_s16(e_lo, o_hi);
        let first_hi = vqaddq_s16(e_hi, o_lo);

        let sub_lo = vqsubq_s16(e_lo, o_hi);
        let sub_hi = vqsubq_s16(e_hi, o_lo);
        let rev_lo = rev128_s16(sub_hi);
        let rev_hi = rev128_s16(sub_lo);

        // Apply >>1 shift (rect2) instead of >>2 for 32x32
        let r0 = vrshrq_n_s16::<1>(first_lo);
        let r1 = vrshrq_n_s16::<1>(first_hi);
        let r2 = vrshrq_n_s16::<1>(rev_lo);
        let r3 = vrshrq_n_s16::<1>(rev_hi);

        let soff = scratch_base + row * 32;
        store_v16(scratch, soff, r0);
        store_v16(scratch, soff + 8, r1);
        store_v16(scratch, soff + 16, r2);
        store_v16(scratch, soff + 24, r3);
    }
}

/// NEON implementation of 32x8 DCT_DCT for 16bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_32x8_16bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i32],
    eob: i32,
    bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_16bpc(dst, dst_base, dst_stride, coeff, 32, 8, 1, bitdepth_max);
        return;
    }

    // For 16bpc, use i16 scratch via scalar row transform
    let mut scratch = [0i16; 256];

    // Scalar 32-point row transform on 8 rows
    for y in 0..8 {
        let mut input = [0i32; 32];
        for x in 0..32 {
            input[x] = coeff[y + x * 8];
            coeff[y + x * 8] = 0;
        }
        let out = scalar_dct32_1d(&input);
        // shift >>1 for rect2
        for x in 0..32 {
            let v = (out[x] + 1) >> 1;
            scratch[y * 32 + x] = v.clamp(i16::MIN as i32, i16::MAX as i32) as i16;
        }
    }

    // Column transform: 4 groups of 8 columns
    for group in 0..4 {
        let col_start = group * 8;
        vert_dct8_add_8x8_16bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            32,
            bitdepth_max,
        );
    }
}

// ============================================================================
// 16x32 DCT_DCT (16 columns, 32 rows)
// ============================================================================

/// NEON implementation of 16x32 DCT_DCT inverse transform add for 8bpc.
///
/// Row transform: 16-point DCT on 8h with scale_input + srshr>>1
/// Column transform: 32-point DCT on 8h
/// Processes as 4 groups of 8 rows for the row transform,
/// then 2 groups of 8 columns for the column transform.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_16x32_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_8bpc(dst, dst_base, dst_stride, coeff, 16, 32, 1);
        return;
    }

    let eob_thresholds: [i32; 4] = [36, 136, 300, 1024];

    // Scratch: 32 rows x 16 columns
    let mut scratch = [0i16; 512];

    // Row transform: 4 groups of 8 rows, 16-point DCT
    for group in 0..4 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }

        horz_dct16_for_16x32(
            coeff,
            row_start,
            32, // coeff_stride = height = 32
            &mut scratch,
            row_start * 16, // scratch offset
            16,             // scratch_stride
        );
    }

    // Column transform: 2 groups of 8 columns, 32-point DCT
    for group in 0..2 {
        let col_start = group * 8;
        vert_dct_add_8x32_8bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            16, // scratch_stride = 16
        );
    }
}

/// NEON implementation of 16x32 DCT_DCT for 16bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_16x32_16bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i32],
    eob: i32,
    bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_16bpc(dst, dst_base, dst_stride, coeff, 16, 32, 1, bitdepth_max);
        return;
    }

    let eob_thresholds: [i32; 4] = [36, 136, 300, 1024];

    // Scratch: 32 rows x 16 columns
    let mut scratch = [0i16; 512];

    // Scalar 16-point row transform
    for group in 0..4 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }
        for r in 0..8 {
            let y = row_start + r;
            let mut input = [0i32; 16];
            for x in 0..16 {
                input[x] = coeff[y + x * 32];
                coeff[y + x * 32] = 0;
            }
            let scale = 2896i64 * 8;
            for val in input.iter_mut() {
                *val = ((*val as i64 * scale + 16384) >> 15) as i32;
            }
            let out = scalar_dct16_1d(&input);
            for x in 0..16 {
                let v = (out[x] + 1) >> 1;
                scratch[y * 16 + x] = v.clamp(i16::MIN as i32, i16::MAX as i32) as i16;
            }
        }
    }

    // Column transform: 2 groups of 8 columns
    for group in 0..2 {
        let col_start = group * 8;
        vert_dct_add_8x32_16bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            16,
            bitdepth_max,
        );
    }
}

// ============================================================================
// 32x16 DCT_DCT (32 columns, 16 rows)
// ============================================================================

/// NEON implementation of 32x16 DCT_DCT inverse transform add for 8bpc.
///
/// Row transform: 32-point DCT on 8h
/// Column transform: 16-point DCT on 8h
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_32x16_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_8bpc(dst, dst_base, dst_stride, coeff, 32, 16, 1);
        return;
    }

    let eob_thresholds: [i32; 2] = [36, 512];

    // Scratch: 16 rows x 32 columns
    let mut scratch = [0i16; 512];

    // Row transform: 2 groups of 8 rows, 32-point DCT
    for group in 0..2 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }

        horz_32x16_rect(
            coeff,
            row_start,
            16, // coeff_stride = height = 16
            &mut scratch,
            row_start * 32,
        );
    }

    // Column transform: 4 groups of 8 columns, 16-point DCT
    for group in 0..4 {
        let col_start = group * 8;
        vert_dct16_add_8x16_8bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            32, // scratch_stride = 32
        );
    }
}

/// Horizontal 32-point DCT on 8 rows for 32x16 (shift=1 for rect2).
#[cfg(target_arch = "aarch64")]
#[rite(neon)]
fn horz_32x16_rect(
    coeff: &mut [i16],
    coeff_base: usize,
    coeff_stride: usize,
    scratch: &mut [i16],
    scratch_base: usize,
) {
    // Reuse the same logic as horz_32x8_rect
    horz_32x8_rect(coeff, coeff_base, coeff_stride, scratch, scratch_base);
}

/// NEON implementation of 32x16 DCT_DCT for 16bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_dct_dct_32x16_16bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u16],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i32],
    eob: i32,
    bitdepth_max: i32,
) {
    if eob == 0 {
        dc_only_large_rect_16bpc(dst, dst_base, dst_stride, coeff, 32, 16, 1, bitdepth_max);
        return;
    }

    let eob_thresholds: [i32; 2] = [36, 512];
    let mut scratch = [0i16; 512];

    // Scalar 32-point row transform on 16 rows
    for group in 0..2 {
        let row_start = group * 8;
        if group > 0 && eob < eob_thresholds[group - 1] {
            break;
        }
        for r in 0..8 {
            let y = row_start + r;
            let mut input = [0i32; 32];
            for x in 0..32 {
                input[x] = coeff[y + x * 16];
                coeff[y + x * 16] = 0;
            }
            let out = scalar_dct32_1d(&input);
            for x in 0..32 {
                let v = (out[x] + 1) >> 1;
                scratch[y * 32 + x] = v.clamp(i16::MIN as i32, i16::MAX as i32) as i16;
            }
        }
    }

    // Column transform: 4 groups of 8 columns
    for group in 0..4 {
        let col_start = group * 8;
        vert_dct16_add_8x16_16bpc(
            dst,
            dst_base + col_start,
            dst_stride,
            &scratch,
            col_start,
            32,
            bitdepth_max,
        );
    }
}

// ============================================================================
// Identity transforms for 8x32, 32x8, 16x32, 32x16
// ============================================================================

/// Identity 8x32 for 8bpc: transpose 8x8 blocks and add with shift.
///
/// For 8x32 identity: identity scaling is a no-op (identity * rect2 cancels).
/// Just load, transpose, add with appropriate shift.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_identity_identity_8x32_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    let eob_thresholds: [i32; 4] = [36, 136, 300, 1024];

    // Process in 4 groups of 8 rows
    for rg in 0..4 {
        if rg > 0 && eob < eob_thresholds[rg - 1] {
            break;
        }

        let row_start = rg * 8;

        // Load 8 columns x 8 rows (column-major)
        let zero_vec = vdupq_n_s16(0);
        let mut v: [int16x8_t; 8] = [zero_vec; 8];
        for c in 0..8 {
            let base = c * 32 + row_start;
            let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
            v[c] = safe_simd::vld1q_s16(&arr);
            coeff[base..base + 8].fill(0);
        }

        // Transpose
        let (r0, r1, r2, r3, r4, r5, r6, r7) =
            transpose_8x8h(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7]);

        // Add with shift >>2 (identity shift for 32-height blocks)
        let rows = [r0, r1, r2, r3, r4, r5, r6, r7];
        for r in 0..8 {
            let shifted = vrshrq_n_s16::<2>(rows[r]);
            let row_off = dst_base.wrapping_add_signed((row_start + r) as isize * dst_stride);

            let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
            let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
            let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
            let result = vqmovun_s16(sum);
            let mut out = [0u8; 8];
            safe_simd::vst1_u8(&mut out, result);
            dst[row_off..row_off + 8].copy_from_slice(&out);
        }
    }
}

/// Identity 32x8 for 8bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_identity_identity_32x8_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    _eob: i32,
    _bitdepth_max: i32,
) {
    // 32x8: 4 column groups of 8, 1 row group of 8
    for cg in 0..4 {
        let col_start = cg * 8;

        let zero_vec = vdupq_n_s16(0);
        let mut v: [int16x8_t; 8] = [zero_vec; 8];
        for c in 0..8 {
            let col = col_start + c;
            let base = col * 8;
            let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
            v[c] = safe_simd::vld1q_s16(&arr);
            coeff[base..base + 8].fill(0);
        }

        let (r0, r1, r2, r3, r4, r5, r6, r7) =
            transpose_8x8h(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7]);

        let rows = [r0, r1, r2, r3, r4, r5, r6, r7];
        for r in 0..8 {
            let shifted = vrshrq_n_s16::<2>(rows[r]);
            let row_off = dst_base.wrapping_add_signed(r as isize * dst_stride) + col_start;

            let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
            let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
            let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
            let result = vqmovun_s16(sum);
            let mut out = [0u8; 8];
            safe_simd::vst1_u8(&mut out, result);
            dst[row_off..row_off + 8].copy_from_slice(&out);
        }
    }
}

/// Identity 16x32 for 8bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_identity_identity_16x32_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    let eob_row_thresholds: [i32; 4] = [36, 136, 300, 1024];
    let eob_col_thresholds: [i32; 2] = [36, 512];

    for rg in 0..4 {
        if rg > 0 && eob < eob_row_thresholds[rg - 1] {
            break;
        }
        let row_start = rg * 8;

        for cg in 0..2 {
            if cg > 0 && eob < eob_col_thresholds[cg - 1] {
                break;
            }
            let col_start = cg * 8;

            let zero_vec = vdupq_n_s16(0);
            let mut v: [int16x8_t; 8] = [zero_vec; 8];
            for c in 0..8 {
                let col = col_start + c;
                let base = col * 32 + row_start;
                let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
                v[c] = safe_simd::vld1q_s16(&arr);
                coeff[base..base + 8].fill(0);
            }

            let (r0, r1, r2, r3, r4, r5, r6, r7) =
                transpose_8x8h(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7]);

            let rows = [r0, r1, r2, r3, r4, r5, r6, r7];
            for r in 0..8 {
                let shifted = vrshrq_n_s16::<2>(rows[r]);
                let row_off =
                    dst_base.wrapping_add_signed((row_start + r) as isize * dst_stride) + col_start;

                let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
                let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
                let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
                let result = vqmovun_s16(sum);
                let mut out = [0u8; 8];
                safe_simd::vst1_u8(&mut out, result);
                dst[row_off..row_off + 8].copy_from_slice(&out);
            }
        }
    }
}

/// Identity 32x16 for 8bpc.
#[cfg(target_arch = "aarch64")]
#[arcane]
pub(crate) fn inv_txfm_add_identity_identity_32x16_8bpc_neon_inner(
    _token: Arm64,
    dst: &mut [u8],
    dst_base: usize,
    dst_stride: isize,
    coeff: &mut [i16],
    eob: i32,
    _bitdepth_max: i32,
) {
    let eob_row_thresholds: [i32; 2] = [36, 512];
    let eob_col_thresholds: [i32; 4] = [36, 136, 300, 1024];

    for rg in 0..2 {
        if rg > 0 && eob < eob_row_thresholds[rg - 1] {
            break;
        }
        let row_start = rg * 8;

        for cg in 0..4 {
            if cg > 0 && eob < eob_col_thresholds[cg - 1] {
                break;
            }
            let col_start = cg * 8;

            let zero_vec = vdupq_n_s16(0);
            let mut v: [int16x8_t; 8] = [zero_vec; 8];
            for c in 0..8 {
                let col = col_start + c;
                let base = col * 16 + row_start;
                let arr: [i16; 8] = coeff[base..base + 8].try_into().unwrap();
                v[c] = safe_simd::vld1q_s16(&arr);
                coeff[base..base + 8].fill(0);
            }

            let (r0, r1, r2, r3, r4, r5, r6, r7) =
                transpose_8x8h(v[0], v[1], v[2], v[3], v[4], v[5], v[6], v[7]);

            let rows = [r0, r1, r2, r3, r4, r5, r6, r7];
            for r in 0..8 {
                let shifted = vrshrq_n_s16::<2>(rows[r]);
                let row_off =
                    dst_base.wrapping_add_signed((row_start + r) as isize * dst_stride) + col_start;

                let dst_bytes: [u8; 8] = dst[row_off..row_off + 8].try_into().unwrap();
                let dst_u8 = safe_simd::vld1_u8(&dst_bytes);
                let sum = vreinterpretq_s16_u16(vaddw_u8(vreinterpretq_u16_s16(shifted), dst_u8));
                let result = vqmovun_s16(sum);
                let mut out = [0u8; 8];
                safe_simd::vst1_u8(&mut out, result);
                dst[row_off..row_off + 8].copy_from_slice(&out);
            }
        }
    }
}

// ============================================================================
// Scalar helper functions (for 16bpc paths)
// ============================================================================

/// Scalar 8-point DCT.
#[allow(dead_code)]
fn scalar_dct8_1d(input: &[i32; 8]) -> [i32; 8] {
    // Stage 1: butterfly
    let s0 = input[0] + input[7];
    let s1 = input[1] + input[6];
    let s2 = input[2] + input[5];
    let s3 = input[3] + input[4];
    let s4 = input[0] - input[7];
    let s5 = input[1] - input[6];
    let s6 = input[2] - input[5];
    let s7 = input[3] - input[4];

    // 4-point DCT on even
    let a0 = s0 + s3;
    let a1 = s1 + s2;
    let a2 = s0 - s3;
    let a3 = s1 - s2;

    let e0 = a0 + a1;
    let e1 = a0 - a1;
    let e2 = (a2 * 1567 + a3 * 3784 + 2048) >> 12;
    let e3 = (a2 * 3784 - a3 * 1567 + 2048) >> 12;

    // Odd part
    let t8a = (s4 * 799 + s7 * 4017 + 2048) >> 12;
    let t15a = (s4 * 4017 - s7 * 799 + 2048) >> 12;
    let t9a = (s5 * 3406 + s6 * 2276 + 2048) >> 12;
    let t14a = (s5 * 2276 - s6 * 3406 + 2048) >> 12;

    let t8 = t8a + t9a;
    let t9 = t8a - t9a;
    let t14 = t15a - t14a;
    let t15 = t15a + t14a;

    let t9a = (t14 * 2896 - t9 * 2896 + 2048) >> 12;
    let t14a = (t14 * 2896 + t9 * 2896 + 2048) >> 12;

    [
        e0 + t15,
        e2 + t14a,
        e1 + t9a,
        e3 + t8,
        e3 - t8,
        e1 - t9a,
        e2 - t14a,
        e0 - t15,
    ]
}

/// Scalar 16-point DCT (full precision).
#[allow(dead_code)]
fn scalar_dct16_1d(input: &[i32; 16]) -> [i32; 16] {
    let mut even = [0i32; 8];
    for i in 0..8 {
        even[i] = input[2 * i];
    }
    let even_out = scalar_dct8_1d(&even);

    let c = [401i32, 4076, 3166, 2598, 1931, 3612, 3920, 1189];

    let t8a = (input[1] * c[0] - input[15] * c[1] + 2048) >> 12;
    let t15a = (input[1] * c[1] + input[15] * c[0] + 2048) >> 12;
    let t9a = (input[9] * c[2] - input[7] * c[3] + 2048) >> 12;
    let t14a = (input[9] * c[3] + input[7] * c[2] + 2048) >> 12;
    let t10a = (input[5] * c[4] - input[11] * c[5] + 2048) >> 12;
    let t13a = (input[5] * c[5] + input[11] * c[4] + 2048) >> 12;
    let t11a = (input[13] * c[6] - input[3] * c[7] + 2048) >> 12;
    let t12a = (input[13] * c[7] + input[3] * c[6] + 2048) >> 12;

    let t8 = t8a + t9a;
    let t9 = t8a - t9a;
    let t10 = t11a - t10a;
    let t11 = t11a + t10a;
    let t12 = t12a + t13a;
    let t13 = t12a - t13a;
    let t14 = t15a - t14a;
    let t15 = t15a + t14a;

    let t9a = (t14 * 1567 - t9 * 3784 + 2048) >> 12;
    let t14a = (t14 * 3784 + t9 * 1567 + 2048) >> 12;
    let t13a = (t13 * 1567 - t10 * 3784 + 2048) >> 12;
    let t10a = -((t13 * 3784 + t10 * 1567 + 2048) >> 12);

    let t8a = t8 + t11;
    let t11a = t8 - t11;
    let t9b = t9a + t10a;
    let t10b = t9a - t10a;
    let t12a = t15 - t12;
    let t15a = t15 + t12;
    let t13b = t14a - t13a;
    let t14b = t14a + t13a;

    let t11_f = (t12a * 2896 - t11a * 2896 + 2048) >> 12;
    let t12_f = (t12a * 2896 + t11a * 2896 + 2048) >> 12;
    let t10_f = (t13b * 2896 - t10b * 2896 + 2048) >> 12;
    let t13_f = (t13b * 2896 + t10b * 2896 + 2048) >> 12;

    let mut out = [0i32; 16];
    out[0] = even_out[0] + t15a;
    out[1] = even_out[1] + t14b;
    out[2] = even_out[2] + t13_f;
    out[3] = even_out[3] + t12_f;
    out[4] = even_out[4] + t11_f;
    out[5] = even_out[5] + t10_f;
    out[6] = even_out[6] + t9b;
    out[7] = even_out[7] + t8a;
    out[8] = even_out[7] - t8a;
    out[9] = even_out[6] - t9b;
    out[10] = even_out[5] - t10_f;
    out[11] = even_out[4] - t11_f;
    out[12] = even_out[3] - t12_f;
    out[13] = even_out[2] - t13_f;
    out[14] = even_out[1] - t14b;
    out[15] = even_out[0] - t15a;
    out
}

/// Scalar 32-point DCT.
#[allow(dead_code)]
fn scalar_dct32_1d(input: &[i32; 32]) -> [i32; 32] {
    let mut even = [0i32; 16];
    for i in 0..16 {
        even[i] = input[2 * i];
    }
    let even_out = scalar_dct16_1d(&even);

    let c0 = [201i32, 4091, 3035, 2751, 1751, 3703, 3857, 1380];
    let c1 = [995i32, 3973, 3513, 2106, 2440, 3290, 4052, 601];

    let t16a = (input[1] * c0[0] - input[31] * c0[1] + 2048) >> 12;
    let t31a = (input[1] * c0[1] + input[31] * c0[0] + 2048) >> 12;
    let t17a = (input[17] * c0[2] - input[15] * c0[3] + 2048) >> 12;
    let t30a = (input[17] * c0[3] + input[15] * c0[2] + 2048) >> 12;
    let t18a = (input[9] * c0[4] - input[23] * c0[5] + 2048) >> 12;
    let t29a = (input[9] * c0[5] + input[23] * c0[4] + 2048) >> 12;
    let t19a = (input[25] * c0[6] - input[7] * c0[7] + 2048) >> 12;
    let t28a = (input[25] * c0[7] + input[7] * c0[6] + 2048) >> 12;
    let t20a = (input[5] * c1[0] - input[27] * c1[1] + 2048) >> 12;
    let t27a = (input[5] * c1[1] + input[27] * c1[0] + 2048) >> 12;
    let t21a = (input[21] * c1[2] - input[11] * c1[3] + 2048) >> 12;
    let t26a = (input[21] * c1[3] + input[11] * c1[2] + 2048) >> 12;
    let t22a = (input[13] * c1[4] - input[19] * c1[5] + 2048) >> 12;
    let t25a = (input[13] * c1[5] + input[19] * c1[4] + 2048) >> 12;
    let t23a = (input[29] * c1[6] - input[3] * c1[7] + 2048) >> 12;
    let t24a = (input[29] * c1[7] + input[3] * c1[6] + 2048) >> 12;

    let s16 = t16a + t17a;
    let s17 = t16a - t17a;
    let s18 = t19a - t18a;
    let s19 = t19a + t18a;
    let s20 = t20a + t21a;
    let s21 = t20a - t21a;
    let s22 = t23a - t22a;
    let s23 = t23a + t22a;
    let s24 = t24a + t25a;
    let s25 = t24a - t25a;
    let s26 = t27a - t26a;
    let s27 = t27a + t26a;
    let s28 = t28a + t29a;
    let s29 = t28a - t29a;
    let s30 = t31a - t30a;
    let s31 = t31a + t30a;

    let u17a = (s30 * 799 - s17 * 4017 + 2048) >> 12;
    let u30a = (s30 * 4017 + s17 * 799 + 2048) >> 12;
    let u18a = -((s29 * 4017 + s18 * 799 + 2048) >> 12);
    let u29a = (s29 * 799 - s18 * 4017 + 2048) >> 12;
    let u21a = (s26 * 3406 - s21 * 2276 + 2048) >> 12;
    let u26a = (s26 * 2276 + s21 * 3406 + 2048) >> 12;
    let u22a = -((s25 * 2276 + s22 * 3406 + 2048) >> 12);
    let u25a = (s25 * 3406 - s22 * 2276 + 2048) >> 12;

    let w16a = s16 + s19;
    let w19a = s16 - s19;
    let w17 = u17a + u18a;
    let w18 = u17a - u18a;
    let w20a = s23 - s20;
    let w23a = s23 + s20;
    let w21 = u22a - u21a;
    let w22 = u22a + u21a;
    let w24a = s24 + s27;
    let w27a = s24 - s27;
    let w25 = u25a + u26a;
    let w26 = u25a - u26a;
    let w28a = s31 - s28;
    let w31a = s31 + s28;
    let w29 = u30a - u29a;
    let w30 = u30a + u29a;

    let x18a = (w29 * 1567 - w18 * 3784 + 2048) >> 12;
    let x29a = (w29 * 3784 + w18 * 1567 + 2048) >> 12;
    let x19 = (w28a * 1567 - w19a * 3784 + 2048) >> 12;
    let x28 = (w28a * 3784 + w19a * 1567 + 2048) >> 12;
    let x20 = -((w27a * 3784 + w20a * 1567 + 2048) >> 12);
    let x27 = (w27a * 1567 - w20a * 3784 + 2048) >> 12;
    let x21a = -((w26 * 3784 + w21 * 1567 + 2048) >> 12);
    let x26a = (w26 * 1567 - w21 * 3784 + 2048) >> 12;

    let y16 = w16a + w23a;
    let y23 = w16a - w23a;
    let y17a = w17 + w22;
    let y22a = w17 - w22;
    let y18 = x18a + x21a;
    let y21 = x18a - x21a;
    let y19a = x19 + x20;
    let y20a = x19 - x20;
    let y24 = w31a - w24a;
    let y31 = w31a + w24a;
    let y25a = w30 - w25;
    let y30a = w30 + w25;
    let y26 = x29a - x26a;
    let y29 = x29a + x26a;
    let y27a = x28 - x27;
    let y28a = x28 + x27;

    let z20 = (y27a * 2896 - y20a * 2896 + 2048) >> 12;
    let z27 = (y27a * 2896 + y20a * 2896 + 2048) >> 12;
    let z21a = (y26 * 2896 - y21 * 2896 + 2048) >> 12;
    let z26a = (y26 * 2896 + y21 * 2896 + 2048) >> 12;
    let z22 = (y25a * 2896 - y22a * 2896 + 2048) >> 12;
    let z25 = (y25a * 2896 + y22a * 2896 + 2048) >> 12;
    let z23a = (y24 * 2896 - y23 * 2896 + 2048) >> 12;
    let z24a = (y24 * 2896 + y23 * 2896 + 2048) >> 12;

    let mut out = [0i32; 32];
    let odd = [
        y16, y17a, y18, y19a, z20, z21a, z22, z23a, z24a, z25, z26a, z27, y28a, y29, y30a, y31,
    ];
    for i in 0..16 {
        out[i] = even_out[i] + odd[15 - i];
        out[31 - i] = even_out[i] - odd[15 - i];
    }
    out
}