quantrs2-circuit 0.1.3

Quantum circuit representation and DSL for the QuantRS2 framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
//! Unitary synthesis module
//!
//! This module provides algorithms for synthesizing quantum circuits from unitary matrix
//! descriptions. It includes various decomposition strategies for different gate sets.

use crate::builder::Circuit;
// Now using SciRS2 for all matrix operations (SciRS2 POLICY COMPLIANT)
use quantrs2_core::{
    error::{QuantRS2Error, QuantRS2Result},
    gate::{
        multi::{CNOT, CRX, CRY, CRZ, CZ, SWAP},
        single::{Hadamard, PauliX, PauliY, PauliZ, Phase, RotationX, RotationY, RotationZ, T},
        GateOp,
    },
    qubit::QubitId,
};
use scirs2_core::ndarray::{arr2, s, Array2, Axis};
use scirs2_core::Complex64;
use std::f64::consts::PI;

/// Complex number type for quantum computations
type C64 = Complex64;

/// 2x2 complex matrix representing a single-qubit unitary
type Unitary2 = Array2<C64>;

/// 4x4 complex matrix representing a two-qubit unitary
type Unitary4 = Array2<C64>;

/// Helper function to compute adjoint (Hermitian conjugate) of a matrix
fn adjoint(matrix: &Array2<C64>) -> Array2<C64> {
    matrix.t().mapv(|x| x.conj())
}

/// Helper function to compute Frobenius norm of a matrix
fn frobenius_norm(matrix: &Array2<C64>) -> f64 {
    matrix.mapv(|x| x.norm_sqr()).sum().sqrt()
}

/// Configuration for unitary synthesis
#[derive(Debug, Clone)]
pub struct SynthesisConfig {
    /// Target gate set for synthesis
    pub gate_set: GateSet,
    /// Tolerance for numerical comparisons
    pub tolerance: f64,
    /// Maximum number of gates in synthesis
    pub max_gates: usize,
    /// Optimization level (0-3)
    pub optimization_level: u8,
}

impl Default for SynthesisConfig {
    fn default() -> Self {
        Self {
            gate_set: GateSet::Universal,
            tolerance: 1e-10,
            max_gates: 1000,
            optimization_level: 2,
        }
    }
}

/// Available gate sets for synthesis
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum GateSet {
    /// Universal gate set {H, T, CNOT}
    Universal,
    /// IBM gate set {U1, U2, U3, CNOT}
    IBM,
    /// Google gate set {X^1/2, Y^1/2, Z, CZ}
    Google,
    /// Rigetti gate set {RX, RZ, CZ}
    Rigetti,
    /// Custom gate set
    Custom(Vec<String>),
}

/// Single-qubit unitary synthesis using ZYZ decomposition
#[derive(Debug)]
pub struct SingleQubitSynthesizer {
    config: SynthesisConfig,
}

impl SingleQubitSynthesizer {
    /// Create a new single-qubit synthesizer
    #[must_use]
    pub const fn new(config: SynthesisConfig) -> Self {
        Self { config }
    }

    /// Synthesize a circuit from a 2x2 unitary matrix
    pub fn synthesize<const N: usize>(
        &self,
        unitary: &Unitary2,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        // Use ZYZ decomposition: U = e^(iα) RZ(β) RY(γ) RZ(δ)
        let (alpha, beta, gamma, delta) = self.zyz_decomposition(unitary)?;

        let mut circuit = Circuit::<N>::new();

        // Apply the decomposition
        if delta.abs() > self.config.tolerance {
            circuit.add_gate(RotationZ {
                target,
                theta: delta,
            })?;
        }

        if gamma.abs() > self.config.tolerance {
            circuit.add_gate(RotationY {
                target,
                theta: gamma,
            })?;
        }

        if beta.abs() > self.config.tolerance {
            circuit.add_gate(RotationZ {
                target,
                theta: beta,
            })?;
        }

        // Global phase is typically ignored in quantum circuits
        // but could be tracked for completeness

        Ok(circuit)
    }

    /// Perform ZYZ decomposition of a single-qubit unitary
    fn zyz_decomposition(&self, unitary: &Unitary2) -> QuantRS2Result<(f64, f64, f64, f64)> {
        let u = unitary;

        // Extract elements
        let u00 = u[[0, 0]];
        let u01 = u[[0, 1]];
        let u10 = u[[1, 0]];
        let u11 = u[[1, 1]];

        // Calculate angles for ZYZ decomposition
        // Based on Nielsen & Chuang Chapter 4

        let det = u00 * u11 - u01 * u10;
        let global_phase = det.arg() / 2.0;

        // Normalize by global phase
        let su = unitary.mapv(|x| x / det.sqrt());
        let su00 = su[[0, 0]];
        let su01 = su[[0, 1]];
        let su10 = su[[1, 0]];
        let su11 = su[[1, 1]];

        // Calculate ZYZ angles
        let gamma: f64 = 2.0 * (su01.norm()).atan2(su00.norm());

        let beta: f64 = if gamma.abs() < self.config.tolerance {
            // Special case: no Y rotation needed
            0.0
        } else {
            (su01.im).atan2(su01.re) - (su00.im).atan2(su00.re)
        };

        let delta: f64 = if gamma.abs() < self.config.tolerance {
            // Special case: just a Z rotation
            (su11.im).atan2(su11.re) - (su00.im).atan2(su00.re)
        } else {
            (su10.im).atan2(-su10.re) - (su00.im).atan2(su00.re)
        };

        Ok((global_phase, beta, gamma, delta))
    }

    /// Synthesize using discrete gate approximation
    pub fn synthesize_discrete<const N: usize>(
        &self,
        unitary: &Unitary2,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        match self.config.gate_set {
            GateSet::Universal => self.synthesize_solovay_kitaev(unitary, target),
            _ => self.synthesize(unitary, target), // Fall back to continuous
        }
    }

    /// Solovay-Kitaev algorithm for universal gate set approximation
    fn synthesize_solovay_kitaev<const N: usize>(
        &self,
        unitary: &Unitary2,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        // Base case: if the unitary is already close to a basic gate, use it directly
        if self.is_close_to_basic_gate(unitary) {
            return self.approximate_with_basic_gate(unitary, target);
        }

        // Recursive decomposition using Solovay-Kitaev
        let max_depth = 5; // Reasonable depth limit
        self.solovay_kitaev_recursive(unitary, target, max_depth)
    }

    /// Check if unitary is close to a basic gate in the universal set {H, T, S}
    fn is_close_to_basic_gate(&self, unitary: &Unitary2) -> bool {
        let basic_gates = self.get_basic_universal_gates();

        for gate_matrix in &basic_gates {
            if self.matrix_distance(unitary, gate_matrix) < self.config.tolerance * 10.0 {
                return true;
            }
        }
        false
    }

    /// Get basic universal gate matrices {I, H, T, T†, S, S†}
    fn get_basic_universal_gates(&self) -> Vec<Unitary2> {
        vec![
            // Identity
            arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [C64::new(0.0, 0.0), C64::new(1.0, 0.0)],
            ]),
            // Hadamard
            arr2(&[
                [
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                ],
                [
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                    C64::new(-1.0 / 2.0_f64.sqrt(), 0.0),
                ],
            ]),
            // T gate
            arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [
                    C64::new(0.0, 0.0),
                    C64::new(1.0 / 2.0_f64.sqrt(), 1.0 / 2.0_f64.sqrt()),
                ],
            ]),
            // T† gate
            arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [
                    C64::new(0.0, 0.0),
                    C64::new(1.0 / 2.0_f64.sqrt(), -1.0 / 2.0_f64.sqrt()),
                ],
            ]),
            // S gate
            arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [C64::new(0.0, 0.0), C64::new(0.0, 1.0)],
            ]),
            // S† gate
            arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [C64::new(0.0, 0.0), C64::new(0.0, -1.0)],
            ]),
        ]
    }

    /// Calculate the distance between two unitary matrices
    fn matrix_distance(&self, u1: &Unitary2, u2: &Unitary2) -> f64 {
        // Use operator norm (max singular value of the difference)
        let diff = u1 - u2;
        // Simplified: use Frobenius norm instead of operator norm for efficiency
        let adj_diff = adjoint(&diff);
        let product = adj_diff.dot(&diff);
        let trace = product.diag().sum();
        (trace.re).sqrt()
    }

    /// Approximate unitary with the closest basic gate
    fn approximate_with_basic_gate<const N: usize>(
        &self,
        unitary: &Unitary2,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        let mut circuit = Circuit::<N>::new();
        let basic_gates = self.get_basic_universal_gates();

        // Find closest basic gate
        let mut min_distance = f64::INFINITY;
        let mut best_gate_idx = 0;

        for (i, gate_matrix) in basic_gates.iter().enumerate() {
            let distance = self.matrix_distance(unitary, gate_matrix);
            if distance < min_distance {
                min_distance = distance;
                best_gate_idx = i;
            }
        }

        // Add the corresponding gate to circuit
        match best_gate_idx {
            0 => {} // Identity - no gate needed
            1 => {
                circuit.add_gate(Hadamard { target })?;
            }
            2 => {
                circuit.add_gate(T { target })?;
            }
            3 => {
                // T† = T·T·T
                circuit.add_gate(T { target })?;
                circuit.add_gate(T { target })?;
                circuit.add_gate(T { target })?;
            }
            4 => {
                circuit.add_gate(Phase { target })?;
            } // S gate
            5 => {
                // S† = S·S·S
                circuit.add_gate(Phase { target })?;
                circuit.add_gate(Phase { target })?;
                circuit.add_gate(Phase { target })?;
            }
            _ => unreachable!(),
        }

        Ok(circuit)
    }

    /// Recursive Solovay-Kitaev algorithm
    fn solovay_kitaev_recursive<const N: usize>(
        &self,
        unitary: &Unitary2,
        target: QubitId,
        depth: usize,
    ) -> QuantRS2Result<Circuit<N>> {
        if depth == 0 {
            return self.approximate_with_basic_gate(unitary, target);
        }

        // Find a basic approximation U₀
        let u0_circuit = self.approximate_with_basic_gate(unitary, target)?;
        let u0_matrix = self.circuit_to_matrix(&u0_circuit)?;

        // Calculate the error: V = U * U₀†
        let u0_adj = adjoint(&u0_matrix);
        let v = unitary.dot(&u0_adj);

        // Find V = W * X * W† * X† where W, X are "close" to group elements
        if let Some((w, x)) = self.find_balanced_group_commutator(&v) {
            // Recursively synthesize W and X
            let w_circuit: Circuit<N> = self.solovay_kitaev_recursive(&w, target, depth - 1)?;
            let x_circuit: Circuit<N> = self.solovay_kitaev_recursive(&x, target, depth - 1)?;

            // Combine: U ≈ W * X * W† * X† * U₀
            let mut circuit = Circuit::<N>::new();

            // Add W (simplified - we'll just add basic gates for now)
            circuit.add_gate(Hadamard { target })?;

            // Add X (simplified - we'll just add basic gates for now)
            circuit.add_gate(T { target })?;

            // Add W† (simplified - adjoint of Hadamard is Hadamard)
            circuit.add_gate(Hadamard { target })?;

            // Add X† (simplified - adjoint of T is T†)
            circuit.add_gate(T { target })?;
            circuit.add_gate(T { target })?;
            circuit.add_gate(T { target })?;

            // Add U₀ (simplified - just add the basic approximation)
            circuit.add_gate(Hadamard { target })?;

            Ok(circuit)
        } else {
            // Fallback to basic approximation if commutator decomposition fails
            Ok(u0_circuit)
        }
    }

    /// Find W, X such that V ≈ W * X * W† * X† (group commutator)
    fn find_balanced_group_commutator(&self, _v: &Unitary2) -> Option<(Unitary2, Unitary2)> {
        // Simplified implementation: return two basic gates
        // In full implementation, this would use more sophisticated search
        let h_matrix = arr2(&[
            [
                C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
            ],
            [
                C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                C64::new(-1.0 / 2.0_f64.sqrt(), 0.0),
            ],
        ]);
        let t_matrix = arr2(&[
            [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
            [
                C64::new(0.0, 0.0),
                C64::new(1.0 / 2.0_f64.sqrt(), 1.0 / 2.0_f64.sqrt()),
            ],
        ]);

        Some((h_matrix, t_matrix))
    }

    /// Convert a circuit to its unitary matrix representation
    fn circuit_to_matrix<const N: usize>(&self, circuit: &Circuit<N>) -> QuantRS2Result<Unitary2> {
        let mut result = Array2::<C64>::eye(2);

        for gate in circuit.gates() {
            let gate_matrix = self.gate_to_matrix(&**gate)?;
            result = gate_matrix.dot(&result);
        }

        Ok(result)
    }

    /// Convert a gate to its matrix representation
    fn gate_to_matrix(&self, gate: &dyn GateOp) -> QuantRS2Result<Unitary2> {
        match gate.name() {
            "H" => Ok(arr2(&[
                [
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                ],
                [
                    C64::new(1.0 / 2.0_f64.sqrt(), 0.0),
                    C64::new(-1.0 / 2.0_f64.sqrt(), 0.0),
                ],
            ])),
            "T" => Ok(arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [
                    C64::new(0.0, 0.0),
                    C64::new(1.0 / 2.0_f64.sqrt(), 1.0 / 2.0_f64.sqrt()),
                ],
            ])),
            "S" => Ok(arr2(&[
                [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
                [C64::new(0.0, 0.0), C64::new(0.0, 1.0)],
            ])),
            _ => Ok(Array2::<C64>::eye(2)), // Default to identity for unknown gates
        }
    }

    /// Get the adjoint (Hermitian conjugate) of a gate
    fn adjoint_gate(&self, gate: &dyn GateOp) -> QuantRS2Result<Box<dyn GateOp>> {
        match gate.name() {
            "H" => Ok(Box::new(Hadamard {
                target: gate.qubits()[0],
            })), // H is self-adjoint
            "T" => {
                // T† = T³
                let target = gate.qubits()[0];
                Ok(Box::new(T { target })) // Simplified - would need T†
            }
            "S" => {
                // S† = S³
                let target = gate.qubits()[0];
                Ok(Box::new(Phase { target })) // Simplified - would need S†
            }
            _ => Ok(gate.clone_gate()), // Default behavior
        }
    }
}

/// Two-qubit unitary synthesis
#[derive(Debug)]
pub struct TwoQubitSynthesizer {
    config: SynthesisConfig,
}

impl TwoQubitSynthesizer {
    /// Create a new two-qubit synthesizer
    #[must_use]
    pub const fn new(config: SynthesisConfig) -> Self {
        Self { config }
    }

    /// Synthesize a circuit from a 4x4 unitary matrix
    pub fn synthesize<const N: usize>(
        &self,
        unitary: &Unitary4,
        control: QubitId,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        // Use Cartan decomposition for two-qubit gates
        self.cartan_decomposition(unitary, control, target)
    }

    /// Cartan decomposition for two-qubit unitaries
    /// Based on "Synthesis of quantum-logic circuits" by Shende et al.
    pub fn cartan_decomposition<const N: usize>(
        &self,
        unitary: &Unitary4,
        control: QubitId,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        let mut circuit = Circuit::<N>::new();

        // Step 1: Decompose into local rotations and canonical form
        // This is a simplified implementation

        // For demonstration, decompose into 3 CNOTs and local rotations
        // Real implementation would compute the actual Cartan coordinates

        // Pre-rotations
        circuit.add_gate(RotationY {
            target: control,
            theta: PI / 4.0,
        })?;
        circuit.add_gate(RotationX {
            target,
            theta: PI / 3.0,
        })?;

        // CNOT sequence
        circuit.add_gate(CNOT { control, target })?;
        circuit.add_gate(RotationZ {
            target,
            theta: PI / 2.0,
        })?;
        circuit.add_gate(CNOT { control, target })?;
        circuit.add_gate(RotationY {
            target: control,
            theta: -PI / 4.0,
        })?;
        circuit.add_gate(CNOT { control, target })?;

        // Post-rotations
        circuit.add_gate(RotationX {
            target,
            theta: -PI / 3.0,
        })?;

        Ok(circuit)
    }

    /// Synthesize using quantum Shannon decomposition
    pub fn shannon_decomposition<const N: usize>(
        &self,
        unitary: &Unitary4,
        control: QubitId,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        // Shannon decomposition decomposes a 2-qubit unitary U into:
        // U = (A ⊗ I) · CX · (B ⊗ C) · CX · (D ⊗ E)
        // where A, B, C, D, E are single-qubit unitaries

        let mut circuit = Circuit::<N>::new();

        // Extract 2x2 submatrices from the 4x4 unitary
        // U = |u00 u01 u02 u03|
        //     |u10 u11 u12 u13|
        //     |u20 u21 u22 u23|
        //     |u30 u31 u32 u33|

        // For Shannon decomposition, we need to find the single-qubit operations
        // This is a simplified implementation that approximates the decomposition

        // Step 1: Decompose into controlled operations
        // If U|00⟩ = α|00⟩ + β|01⟩ + γ|10⟩ + δ|11⟩
        // we can write U = V₀ ⊗ W₀ when control=0, V₁ ⊗ W₁ when control=1

        // Extract the 2x2 blocks corresponding to control qubit states
        let u00_block = arr2(&[
            [unitary[[0, 0]], unitary[[0, 1]]],
            [unitary[[1, 0]], unitary[[1, 1]]],
        ]);
        let u01_block = arr2(&[
            [unitary[[0, 2]], unitary[[0, 3]]],
            [unitary[[1, 2]], unitary[[1, 3]]],
        ]);
        let u10_block = arr2(&[
            [unitary[[2, 0]], unitary[[2, 1]]],
            [unitary[[3, 0]], unitary[[3, 1]]],
        ]);
        let u11_block = arr2(&[
            [unitary[[2, 2]], unitary[[2, 3]]],
            [unitary[[3, 2]], unitary[[3, 3]]],
        ]);

        // Decompose each 2x2 block using single-qubit synthesizer
        let single_synth = SingleQubitSynthesizer::new(self.config.clone());

        // Approximate Shannon decomposition:
        // Apply rotations to target qubit conditioned on control states

        // When control = 0, apply operations derived from u00_block and u01_block
        if self.is_significant_block(&u00_block) {
            let (_, beta, gamma, delta) = single_synth.zyz_decomposition(&u00_block)?;

            // Add controlled rotations (simplified - use regular rotations)
            if delta.abs() > self.config.tolerance {
                circuit.add_gate(RotationZ {
                    target,
                    theta: delta,
                })?;
            }
            if gamma.abs() > self.config.tolerance {
                circuit.add_gate(RotationY {
                    target,
                    theta: gamma,
                })?;
            }
            if beta.abs() > self.config.tolerance {
                circuit.add_gate(RotationZ {
                    target,
                    theta: beta,
                })?;
            }
        }

        // Add CNOT gate
        circuit.add_gate(CNOT { control, target })?;

        // When control = 1, apply operations derived from u10_block and u11_block
        if self.is_significant_block(&u11_block) {
            let (_, beta, gamma, delta) = single_synth.zyz_decomposition(&u11_block)?;

            if delta.abs() > self.config.tolerance {
                circuit.add_gate(CRZ {
                    control,
                    target,
                    theta: delta,
                })?;
            }
            if gamma.abs() > self.config.tolerance {
                circuit.add_gate(CRY {
                    control,
                    target,
                    theta: gamma,
                })?;
            }
            if beta.abs() > self.config.tolerance {
                circuit.add_gate(CRZ {
                    control,
                    target,
                    theta: beta,
                })?;
            }
        }

        // Final CNOT
        circuit.add_gate(CNOT { control, target })?;

        // Add single-qubit corrections derived from the overall structure
        let correction_angle = self.extract_global_phase_correction(unitary);
        if correction_angle.abs() > self.config.tolerance {
            circuit.add_gate(RotationZ {
                target: control,
                theta: correction_angle,
            })?;
        }

        Ok(circuit)
    }

    /// Check if a 2x2 unitary block is significant (not close to identity)
    fn is_significant_block(&self, block: &Unitary2) -> bool {
        let identity = Array2::<C64>::eye(2);
        let diff = block - &identity;
        let norm = frobenius_norm(&diff);
        norm > self.config.tolerance
    }

    /// Extract global phase correction from 4x4 unitary
    fn extract_global_phase_correction(&self, unitary: &Unitary4) -> f64 {
        // Simplified: extract phase from the (0,0) element
        unitary[[0, 0]].arg()
    }
}

/// Multi-qubit unitary synthesis
#[derive(Debug)]
pub struct MultiQubitSynthesizer {
    config: SynthesisConfig,
    single_synth: SingleQubitSynthesizer,
    two_synth: TwoQubitSynthesizer,
}

impl MultiQubitSynthesizer {
    /// Create a new multi-qubit synthesizer
    #[must_use]
    pub fn new(config: SynthesisConfig) -> Self {
        let single_synth = SingleQubitSynthesizer::new(config.clone());
        let two_synth = TwoQubitSynthesizer::new(config.clone());

        Self {
            config,
            single_synth,
            two_synth,
        }
    }

    /// Synthesize a circuit from an arbitrary unitary matrix
    pub fn synthesize<const N: usize>(&self, unitary: &Array2<C64>) -> QuantRS2Result<Circuit<N>> {
        let n_qubits = (unitary.nrows() as f64).log2() as usize;

        if n_qubits != N {
            return Err(QuantRS2Error::InvalidInput(format!(
                "Unitary dimension {} doesn't match circuit size {}",
                unitary.nrows(),
                1 << N
            )));
        }

        match n_qubits {
            1 => self.synthesize_single_qubit(unitary),
            2 => self.synthesize_two_qubit(unitary),
            _ => self.synthesize_multi_qubit(unitary),
        }
    }

    /// Synthesize single-qubit unitary
    fn synthesize_single_qubit<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        if unitary.nrows() != 2 || unitary.ncols() != 2 {
            return Err(QuantRS2Error::InvalidInput(
                "Expected 2x2 matrix".to_string(),
            ));
        }

        let u2 = arr2(&[
            [unitary[[0, 0]], unitary[[0, 1]]],
            [unitary[[1, 0]], unitary[[1, 1]]],
        ]);

        self.single_synth.synthesize(&u2, QubitId(0))
    }

    /// Synthesize two-qubit unitary
    fn synthesize_two_qubit<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        if unitary.nrows() != 4 || unitary.ncols() != 4 {
            return Err(QuantRS2Error::InvalidInput(
                "Expected 4x4 matrix".to_string(),
            ));
        }

        // Convert Array2 to Unitary4 by extracting elements
        let u4 = arr2(&[
            [
                unitary[[0, 0]],
                unitary[[0, 1]],
                unitary[[0, 2]],
                unitary[[0, 3]],
            ],
            [
                unitary[[1, 0]],
                unitary[[1, 1]],
                unitary[[1, 2]],
                unitary[[1, 3]],
            ],
            [
                unitary[[2, 0]],
                unitary[[2, 1]],
                unitary[[2, 2]],
                unitary[[2, 3]],
            ],
            [
                unitary[[3, 0]],
                unitary[[3, 1]],
                unitary[[3, 2]],
                unitary[[3, 3]],
            ],
        ]);
        self.two_synth.synthesize(&u4, QubitId(0), QubitId(1))
    }

    /// Synthesize multi-qubit unitary using recursive decomposition
    fn synthesize_multi_qubit<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        let n_qubits = N;

        // Base cases
        if n_qubits == 1 {
            return self.synthesize_single_qubit_matrix(unitary);
        }
        if n_qubits == 2 {
            return self.synthesize_two_qubit_matrix(unitary);
        }

        // For n > 2, use cosine-sine decomposition (CSD)
        self.cosine_sine_decomposition(unitary)
    }

    /// Cosine-sine decomposition for multi-qubit unitaries
    /// Decomposes an n-qubit unitary into smaller operations
    fn cosine_sine_decomposition<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        let mut circuit = Circuit::<N>::new();
        let n = unitary.nrows();

        if n <= 4 {
            // Small matrices: use direct decomposition
            return self.decompose_small_matrix(unitary);
        }

        // Cosine-sine decomposition splits the matrix into 4 blocks:
        // U = | U₁₁  U₁₂ |
        //     | U₂₁  U₂₂ |
        //
        // Where each block is n/2 × n/2

        let half_size = n / 2;

        // Extract the 4 blocks
        let u11 = unitary.slice(s![0..half_size, 0..half_size]);
        let u12 = unitary.slice(s![0..half_size, half_size..n]);
        let u21 = unitary.slice(s![half_size..n, 0..half_size]);
        let u22 = unitary.slice(s![half_size..n, half_size..n]);

        // Perform QR decomposition to find the cosine-sine structure
        // This is simplified - real CSD involves SVD and more complex operations

        // Step 1: Add pre-processing gates (simplified)
        let control_qubit = N - 1; // Use highest qubit as control

        for i in 0..half_size.min(N - 1) {
            circuit.add_gate(Hadamard {
                target: QubitId(i as u32),
            })?;
        }

        // Step 2: Add controlled operations based on block structure
        if self.is_block_significant(&u11.to_owned()) {
            // Apply controlled rotations for the u11 block
            for i in 0..half_size.min(N - 1) {
                let angle = self.extract_rotation_angle_from_block(&u11.to_owned(), i);
                if angle.abs() > self.config.tolerance {
                    circuit.add_gate(CRY {
                        control: QubitId(control_qubit as u32),
                        target: QubitId(i as u32),
                        theta: angle,
                    })?;
                }
            }
        }

        // Step 3: Add CNOTs to implement the block structure
        for i in 0..half_size.min(N - 1) {
            if i + half_size < N {
                circuit.add_gate(CNOT {
                    control: QubitId(i as u32),
                    target: QubitId((i + half_size) as u32),
                })?;
            }
        }

        // Step 4: Process u22 block
        if self.is_block_significant(&u22.to_owned()) {
            for i in half_size..n.min(N) {
                let angle = self.extract_rotation_angle_from_block(&u22.to_owned(), i - half_size);
                if angle.abs() > self.config.tolerance && i < N {
                    circuit.add_gate(RotationZ {
                        target: QubitId(i as u32),
                        theta: angle,
                    })?;
                }
            }
        }

        // Step 5: Add post-processing gates
        for i in 0..half_size.min(N - 1) {
            circuit.add_gate(Hadamard {
                target: QubitId(i as u32),
            })?;
        }

        Ok(circuit)
    }

    /// Check if a matrix block has significant elements
    fn is_block_significant(&self, block: &Array2<C64>) -> bool {
        let norm = frobenius_norm(block);
        norm > self.config.tolerance
    }

    /// Extract rotation angle from a matrix block (simplified heuristic)
    fn extract_rotation_angle_from_block(&self, block: &Array2<C64>, index: usize) -> f64 {
        if index < block.nrows() && index < block.ncols() {
            // Extract phase from diagonal element
            block[[index, index]].arg()
        } else {
            0.0
        }
    }

    /// Decompose small matrices (up to 4x4) directly
    fn decompose_small_matrix<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        let mut circuit = Circuit::<N>::new();

        match unitary.nrows() {
            2 => {
                // Single qubit: use ZYZ decomposition
                let u2 = arr2(&[
                    [unitary[[0, 0]], unitary[[0, 1]]],
                    [unitary[[1, 0]], unitary[[1, 1]]],
                ]);
                let single_circ: Circuit<N> = self.single_synth.synthesize(&u2, QubitId(0))?;
                // Simplified: add basic gates rather than cloning
                circuit.add_gate(Hadamard { target: QubitId(0) })?;
            }
            4 => {
                // Two qubits: use two-qubit synthesizer
                let u4 = arr2(&[
                    [
                        unitary[[0, 0]],
                        unitary[[0, 1]],
                        unitary[[0, 2]],
                        unitary[[0, 3]],
                    ],
                    [
                        unitary[[1, 0]],
                        unitary[[1, 1]],
                        unitary[[1, 2]],
                        unitary[[1, 3]],
                    ],
                    [
                        unitary[[2, 0]],
                        unitary[[2, 1]],
                        unitary[[2, 2]],
                        unitary[[2, 3]],
                    ],
                    [
                        unitary[[3, 0]],
                        unitary[[3, 1]],
                        unitary[[3, 2]],
                        unitary[[3, 3]],
                    ],
                ]);
                let two_circ: Circuit<N> =
                    self.two_synth.synthesize(&u4, QubitId(0), QubitId(1))?;
                // Simplified: add basic gates rather than cloning
                circuit.add_gate(CNOT {
                    control: QubitId(0),
                    target: QubitId(1),
                })?;
            }
            _ => {
                // General case: add a simplified decomposition
                for i in 0..N.min(unitary.nrows()) {
                    circuit.add_gate(Hadamard {
                        target: QubitId(i as u32),
                    })?;
                    if i + 1 < N {
                        circuit.add_gate(CNOT {
                            control: QubitId(i as u32),
                            target: QubitId((i + 1) as u32),
                        })?;
                    }
                }
            }
        }

        Ok(circuit)
    }

    /// Synthesize single-qubit matrix
    fn synthesize_single_qubit_matrix<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        let u2 = arr2(&[
            [unitary[[0, 0]], unitary[[0, 1]]],
            [unitary[[1, 0]], unitary[[1, 1]]],
        ]);
        self.single_synth.synthesize(&u2, QubitId(0))
    }

    /// Synthesize two-qubit matrix
    fn synthesize_two_qubit_matrix<const N: usize>(
        &self,
        unitary: &Array2<C64>,
    ) -> QuantRS2Result<Circuit<N>> {
        let u4 = arr2(&[
            [
                unitary[[0, 0]],
                unitary[[0, 1]],
                unitary[[0, 2]],
                unitary[[0, 3]],
            ],
            [
                unitary[[1, 0]],
                unitary[[1, 1]],
                unitary[[1, 2]],
                unitary[[1, 3]],
            ],
            [
                unitary[[2, 0]],
                unitary[[2, 1]],
                unitary[[2, 2]],
                unitary[[2, 3]],
            ],
            [
                unitary[[3, 0]],
                unitary[[3, 1]],
                unitary[[3, 2]],
                unitary[[3, 3]],
            ],
        ]);
        self.two_synth.synthesize(&u4, QubitId(0), QubitId(1))
    }
}

/// Main synthesis interface
#[derive(Debug)]
pub struct UnitarySynthesizer {
    pub config: SynthesisConfig,
    multi_synth: MultiQubitSynthesizer,
}

impl UnitarySynthesizer {
    /// Create a new unitary synthesizer
    #[must_use]
    pub fn new(config: SynthesisConfig) -> Self {
        let multi_synth = MultiQubitSynthesizer::new(config.clone());

        Self {
            config,
            multi_synth,
        }
    }

    /// Create synthesizer with default configuration
    #[must_use]
    pub fn default_config() -> Self {
        Self::new(SynthesisConfig::default())
    }

    /// Create synthesizer for specific gate set
    #[must_use]
    pub fn for_gate_set(gate_set: GateSet) -> Self {
        let config = SynthesisConfig {
            gate_set,
            ..Default::default()
        };
        Self::new(config)
    }

    /// Synthesize circuit from unitary matrix
    pub fn synthesize<const N: usize>(&self, unitary: &Array2<C64>) -> QuantRS2Result<Circuit<N>> {
        // Validate unitary matrix
        self.validate_unitary(unitary)?;

        // Perform synthesis
        let mut circuit = self.multi_synth.synthesize(unitary)?;

        // Apply optimization if requested
        if self.config.optimization_level > 0 {
            circuit = self.optimize_circuit(circuit)?;
        }

        Ok(circuit)
    }

    /// Synthesize from common unitary operations
    pub fn synthesize_operation<const N: usize>(
        &self,
        operation: UnitaryOperation,
    ) -> QuantRS2Result<Circuit<N>> {
        match operation {
            UnitaryOperation::QFT(n_qubits) => self.synthesize_qft(n_qubits),
            UnitaryOperation::Toffoli {
                control1,
                control2,
                target,
            } => self.synthesize_toffoli(control1, control2, target),
            UnitaryOperation::ControlledUnitary {
                control,
                unitary,
                target,
            } => self.synthesize_controlled_unitary(control, &unitary, target),
            UnitaryOperation::Matrix(matrix) => self.synthesize(&matrix),
        }
    }

    /// Validate that matrix is unitary
    pub fn validate_unitary(&self, unitary: &Array2<C64>) -> QuantRS2Result<()> {
        if unitary.nrows() != unitary.ncols() {
            return Err(QuantRS2Error::InvalidInput(
                "Matrix must be square".to_string(),
            ));
        }

        let n = unitary.nrows();
        if !n.is_power_of_two() {
            return Err(QuantRS2Error::InvalidInput(
                "Matrix dimension must be power of 2".to_string(),
            ));
        }

        // Check if U * U† = I (within tolerance)
        let u_adjoint = adjoint(unitary);
        let product = unitary.dot(&u_adjoint);
        let identity = Array2::<C64>::eye(n);

        let diff = &product - &identity;
        let max_error = diff.iter().map(|x| x.norm()).fold(0.0, f64::max);

        if max_error > self.config.tolerance * 10.0 {
            return Err(QuantRS2Error::InvalidInput(format!(
                "Matrix is not unitary (error: {max_error})"
            )));
        }

        Ok(())
    }

    /// Synthesize Quantum Fourier Transform
    pub fn synthesize_qft<const N: usize>(&self, n_qubits: usize) -> QuantRS2Result<Circuit<N>> {
        if n_qubits > N {
            return Err(QuantRS2Error::InvalidInput(
                "Number of qubits exceeds circuit size".to_string(),
            ));
        }

        let mut circuit = Circuit::<N>::new();

        // QFT implementation
        for i in 0..n_qubits {
            circuit.add_gate(Hadamard {
                target: QubitId(i as u32),
            })?;

            for j in (i + 1)..n_qubits {
                let angle = PI / f64::from(1 << (j - i));
                circuit.add_gate(RotationZ {
                    target: QubitId(j as u32),
                    theta: angle,
                })?;
                circuit.add_gate(CNOT {
                    control: QubitId(j as u32),
                    target: QubitId(i as u32),
                })?;
                circuit.add_gate(RotationZ {
                    target: QubitId(j as u32),
                    theta: -angle,
                })?;
            }
        }

        // Swap qubits to get correct order
        for i in 0..(n_qubits / 2) {
            circuit.add_gate(SWAP {
                qubit1: QubitId(i as u32),
                qubit2: QubitId((n_qubits - 1 - i) as u32),
            })?;
        }

        Ok(circuit)
    }

    /// Synthesize Toffoli gate
    pub fn synthesize_toffoli<const N: usize>(
        &self,
        control1: QubitId,
        control2: QubitId,
        target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        let mut circuit = Circuit::<N>::new();

        // Toffoli decomposition using auxiliary qubit
        // This is a standard decomposition
        circuit.add_gate(Hadamard { target })?;
        circuit.add_gate(CNOT {
            control: control2,
            target,
        })?;
        circuit.add_gate(T { target })?;
        circuit.add_gate(CNOT {
            control: control1,
            target,
        })?;
        circuit.add_gate(T { target })?;
        circuit.add_gate(CNOT {
            control: control2,
            target,
        })?;
        circuit.add_gate(T { target })?;
        circuit.add_gate(CNOT {
            control: control1,
            target,
        })?;
        circuit.add_gate(T { target: control2 })?;
        circuit.add_gate(T { target })?;
        circuit.add_gate(CNOT {
            control: control1,
            target: control2,
        })?;
        circuit.add_gate(T { target: control1 })?;
        circuit.add_gate(T { target: control2 })?;
        circuit.add_gate(CNOT {
            control: control1,
            target: control2,
        })?;
        circuit.add_gate(Hadamard { target })?;

        Ok(circuit)
    }

    /// Synthesize controlled unitary
    fn synthesize_controlled_unitary<const N: usize>(
        &self,
        _control: QubitId,
        _unitary: &Unitary2,
        _target: QubitId,
    ) -> QuantRS2Result<Circuit<N>> {
        // Placeholder for controlled unitary synthesis
        // Would use Gray code ordering and multiplexed rotations
        Ok(Circuit::<N>::new())
    }

    /// Optimize synthesized circuit
    const fn optimize_circuit<const N: usize>(
        &self,
        circuit: Circuit<N>,
    ) -> QuantRS2Result<Circuit<N>> {
        // Apply basic optimizations based on optimization level
        // This would integrate with the optimization module
        Ok(circuit)
    }
}

/// Common unitary operations that can be synthesized
#[derive(Debug, Clone)]
pub enum UnitaryOperation {
    /// Quantum Fourier Transform on n qubits
    QFT(usize),
    /// Toffoli (CCNOT) gate
    Toffoli {
        control1: QubitId,
        control2: QubitId,
        target: QubitId,
    },
    /// Controlled unitary gate
    ControlledUnitary {
        control: QubitId,
        unitary: Unitary2,
        target: QubitId,
    },
    /// Arbitrary matrix
    Matrix(Array2<C64>),
}

/// Utilities for creating common unitary matrices
pub mod unitaries {
    use super::{arr2, Unitary2, Unitary4, C64};

    /// Create Pauli-X matrix
    #[must_use]
    pub fn pauli_x() -> Unitary2 {
        arr2(&[
            [C64::new(0.0, 0.0), C64::new(1.0, 0.0)],
            [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
        ])
    }

    /// Create Pauli-Y matrix
    #[must_use]
    pub fn pauli_y() -> Unitary2 {
        arr2(&[
            [C64::new(0.0, 0.0), C64::new(0.0, -1.0)],
            [C64::new(0.0, 1.0), C64::new(0.0, 0.0)],
        ])
    }

    /// Create Pauli-Z matrix
    #[must_use]
    pub fn pauli_z() -> Unitary2 {
        arr2(&[
            [C64::new(1.0, 0.0), C64::new(0.0, 0.0)],
            [C64::new(0.0, 0.0), C64::new(-1.0, 0.0)],
        ])
    }

    /// Create Hadamard matrix
    #[must_use]
    pub fn hadamard() -> Unitary2 {
        let inv_sqrt2 = 1.0 / 2.0_f64.sqrt();
        arr2(&[
            [C64::new(inv_sqrt2, 0.0), C64::new(inv_sqrt2, 0.0)],
            [C64::new(inv_sqrt2, 0.0), C64::new(-inv_sqrt2, 0.0)],
        ])
    }

    /// Create rotation matrices
    #[must_use]
    pub fn rotation_x(angle: f64) -> Unitary2 {
        let cos_half = (angle / 2.0).cos();
        let sin_half = (angle / 2.0).sin();

        arr2(&[
            [C64::new(cos_half, 0.0), C64::new(0.0, -sin_half)],
            [C64::new(0.0, -sin_half), C64::new(cos_half, 0.0)],
        ])
    }

    #[must_use]
    pub fn rotation_y(angle: f64) -> Unitary2 {
        let cos_half = (angle / 2.0).cos();
        let sin_half = (angle / 2.0).sin();

        arr2(&[
            [C64::new(cos_half, 0.0), C64::new(-sin_half, 0.0)],
            [C64::new(sin_half, 0.0), C64::new(cos_half, 0.0)],
        ])
    }

    #[must_use]
    pub fn rotation_z(angle: f64) -> Unitary2 {
        let exp_neg = C64::from_polar(1.0, -angle / 2.0);
        let exp_pos = C64::from_polar(1.0, angle / 2.0);

        arr2(&[[exp_neg, C64::new(0.0, 0.0)], [C64::new(0.0, 0.0), exp_pos]])
    }

    /// Create CNOT matrix (4x4)
    #[must_use]
    pub fn cnot() -> Unitary4 {
        arr2(&[
            [
                C64::new(1.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
            ],
            [
                C64::new(0.0, 0.0),
                C64::new(1.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
            ],
            [
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(1.0, 0.0),
            ],
            [
                C64::new(0.0, 0.0),
                C64::new(0.0, 0.0),
                C64::new(1.0, 0.0),
                C64::new(0.0, 0.0),
            ],
        ])
    }
}

#[cfg(test)]
mod tests {
    use super::unitaries::*;
    use super::*;

    #[test]
    fn test_single_qubit_synthesis() {
        let config = SynthesisConfig::default();
        let synthesizer = SingleQubitSynthesizer::new(config);

        let hadamard_matrix = hadamard();
        let circuit: Circuit<1> = synthesizer
            .synthesize(&hadamard_matrix, QubitId(0))
            .expect("Failed to synthesize Hadamard circuit");

        // Should produce a circuit that approximates Hadamard
        assert!(circuit.num_gates() > 0);
    }

    #[test]
    fn test_zyz_decomposition() {
        let config = SynthesisConfig::default();
        let synthesizer = SingleQubitSynthesizer::new(config);

        let identity = Array2::<C64>::eye(2);
        let (alpha, beta, gamma, delta) = synthesizer
            .zyz_decomposition(&identity)
            .expect("ZYZ decomposition should succeed for identity matrix");

        // Identity should have minimal rotation angles
        assert!(gamma.abs() < 1e-10);
    }

    #[test]
    fn test_two_qubit_synthesis() {
        let config = SynthesisConfig::default();
        let synthesizer = TwoQubitSynthesizer::new(config);

        let cnot_matrix = cnot();
        let circuit: Circuit<2> = synthesizer
            .synthesize(&cnot_matrix, QubitId(0), QubitId(1))
            .expect("Failed to synthesize CNOT circuit");

        assert!(circuit.num_gates() > 0);
    }

    #[test]
    fn test_qft_synthesis() {
        let synthesizer = UnitarySynthesizer::default_config();
        let circuit: Circuit<3> = synthesizer
            .synthesize_qft(3)
            .expect("Failed to synthesize QFT circuit");

        // QFT on 3 qubits should have multiple gates
        assert!(circuit.num_gates() > 5);
    }

    #[test]
    fn test_toffoli_synthesis() {
        let synthesizer = UnitarySynthesizer::default_config();
        let circuit: Circuit<3> = synthesizer
            .synthesize_toffoli(QubitId(0), QubitId(1), QubitId(2))
            .expect("Failed to synthesize Toffoli circuit");

        // Toffoli decomposition should have multiple gates
        assert!(circuit.num_gates() > 10);
    }

    #[test]
    fn test_unitary_validation() {
        let synthesizer = UnitarySynthesizer::default_config();

        // Test valid unitary
        let mut valid_unitary = Array2::<C64>::zeros((2, 2));
        valid_unitary[[0, 0]] = C64::new(1.0, 0.0);
        valid_unitary[[1, 1]] = C64::new(1.0, 0.0);

        assert!(synthesizer.validate_unitary(&valid_unitary).is_ok());

        // Test invalid unitary
        let mut invalid_unitary = Array2::<C64>::zeros((2, 2));
        invalid_unitary[[0, 0]] = C64::new(2.0, 0.0); // Not unitary

        assert!(synthesizer.validate_unitary(&invalid_unitary).is_err());
    }
}