quadraui 0.6.0

//! Shell runner infrastructure: [`ShellApp`] trait + [`ShellConfig`].
//!
//! Apps that want an AppShell (activity bar + sidebar + main content)
//! implement [`ShellApp`] instead of [`AppLogic`](crate::AppLogic).
//! Per-backend `run_with_shell()` functions handle the full lifecycle:
//! window creation, event wiring, AppShell chrome rendering, and event
//! routing — the consumer renders only its own content.

use std::cell::{Cell, Ref, RefCell, RefMut};

use crate::compose::app_shell::{
    AppShell, AppShellEvent, AppShellLayout, BottomBand, PanelDefinition, ShellPosition,
};
use crate::compose::bottom_panel::{BottomPanelConfig, BottomPanelEvent};
use crate::event::{Point, Rect};
use crate::primitives::image::ImageSource;
use crate::types::{Color, Icon, WidgetId};
use crate::{Backend, Reaction, ResizeEdge, UiEvent};

/// Configuration for creating an AppShell.
pub struct ShellConfig {
    pub panels: Vec<PanelDefinition>,
    pub bottom_items: Vec<PanelDefinition>,
    pub title: String,
    pub default_sidebar_width: f32,
    pub min_sidebar_width: f32,
    pub max_sidebar_width: f32,
    /// Activity bar width in line-height multiples (`4.0` by default,
    /// giving 4 TUI columns: 1 accent + 2 icon cells (double-width nerd
    /// font glyph) + 1 separator) — same unit as
    /// `default_sidebar_width`. Set via [`Self::with_activity_bar_width`].
    /// See [`Self::activity_bar_width_px`] for a fixed-pixel alternative
    /// that doesn't move with the app's editor font.
    pub activity_bar_width: f32,
    /// Fixed-pixel activity bar width override, on pixel backends. `Some(48.0)`
    /// by default, matching VS Code's activity bar and the `ACTIVITY_ROW_PX`
    /// row height GTK/macOS already paint each item at — regardless of
    /// `line_height`. Set via [`Self::with_activity_bar_width_px`]; pass
    /// `None` to fall back to `activity_bar_width` (a line-height multiple)
    /// instead. **TUI ignores this field** — a cell grid has no literal
    /// pixels, so a px override there would become a column count instead
    /// of a width; `activity_bar_width` always drives TUI.
    pub activity_bar_width_px: Option<f32>,
    pub position: ShellPosition,
    pub has_title_bar: bool,
    pub title_bar_height_lh: f32,
    /// Fixed-pixel floor under `title_bar_height_lh * line_height`, on pixel
    /// backends. `Some(35.0)` by default, matching VS Code's tab/title bar.
    /// See [`AppShell::with_title_bar_min_px`] for the full rationale and
    /// why this is a floor rather than [`Self::activity_bar_width_px`]'s
    /// hard override. Set via [`Self::with_title_bar_min_px`]; pass `None`
    /// to leave `title_bar_height_lh * line_height` in sole charge. **TUI
    /// ignores this field**, for the same reason as `activity_bar_width_px`.
    pub title_bar_min_px: Option<f32>,
    /// Ask the backend not to also draw its own native titlebar band on
    /// top of an app-painted one. `false` (the default) leaves
    /// every backend's previous window-creation behavior unchanged.
    ///
    /// This is **not** GTK's `set_decorated(false)` "undecorated" model —
    /// on macOS the native traffic-light controls (close/minimize/zoom)
    /// stay live and native even with this set; only the native title
    /// text and titlebar background go away
    /// (`NSWindowStyleMask::FullSizeContentView` +
    /// `setTitlebarAppearsTransparent(true)` +
    /// `NSWindowTitleVisibility::Hidden` — see
    /// `macos::run::window_style_mask`).
    ///
    /// **macOS is the only backend that acts on this today.** TUI has no
    /// window concept, and GTK/Win-GUI still ignore the field: their
    /// windows keep full native chrome whether it is set or not. Don't
    /// hardcode "macOS reserves 78pt, everyone else reserves nothing" on
    /// the strength of that — ask
    /// [`crate::Backend::titlebar_control_inset`] instead, which reports
    /// how much of the leading edge of
    /// [`crate::compose::app_shell::AppShellLayout::title_bar_bounds`] to
    /// leave clear (`Rect::default()`, i.e. "paint the whole band", on
    /// every backend that ignores this field) and keeps working
    /// unchanged when GTK/Win-GUI do grow client-side decorations.
    ///
    /// Set via [`Self::with_client_side_titlebar`].
    pub client_side_titlebar: bool,
    pub has_bottom_panel: bool,
    pub bottom_panel_height_lh: f32,
    pub min_bottom_panel_height_lh: f32,
    pub max_bottom_panel_height_lh: f32,
    pub has_command_line: bool,
    pub has_status_bar: bool,
    /// Fixed-pixel status bar height, on pixel backends, when
    /// [`Self::has_status_bar`] is set. `Some(22.0)` by default, matching
    /// VS Code's status bar. `None` falls back to one line-height (the
    /// same fallback [`AppShell`] has always used). Set via
    /// [`Self::with_status_bar_height_px`]. **TUI ignores this field** —
    /// a cell grid has no literal pixels, so a px override there would
    /// become a row count instead of a height; the one-line-height
    /// fallback always drives TUI.
    pub status_bar_height_px: Option<f32>,
    /// Carve the status bar and command line from the main column's width
    /// instead of the full window width, letting the activity bar and
    /// sidebar run the full height below the title bar. Off by default.
    /// Set via [`Self::with_status_bar_under_main_column`].
    pub status_bar_under_main_column: bool,
    /// Optional tabbed bottom panel. `None` (the default) preserves the
    /// existing no-panel layout. When `Some`, the shell runner creates a
    /// [`crate::compose::bottom_panel::BottomPanelController`] that renders
    /// the tab strip and delegates content to each tab's `BackendWidget`.
    ///
    /// Setting this field automatically enables an AppShell bottom panel
    /// region — no need to also call [`Self::with_bottom_panel`] unless you
    /// want to tune the height via the old API as well.
    pub bottom_panel: Option<BottomPanelConfig>,
    /// Independently-gated bottom bands stacked below the editor content
    /// area, generalizing the single `bottom_panel`/`bottom_panel`-drawer
    /// model to **N** rungs — e.g. a terminal toolbar, a
    /// debug toolbar, a quickfix list, a wildmenu, a separated status row,
    /// each present/sized independently of the others. Empty by default,
    /// so nothing that predates this field changes behavior. See
    /// [`BottomBand`] for the stacking order and how this interacts with
    /// [`Self::bottom_panel`] / [`Self::with_bottom_panel`]. Set via
    /// [`Self::with_bottom_bands`]; toggle presence/height at runtime via
    /// `ctx.shell_mut().set_bottom_band_visible(...)` /
    /// `set_bottom_band_height(...)` ([`AppShell`]'s own methods, reached
    /// through [`ShellContext::shell_mut`]).
    pub bottom_bands: Vec<BottomBand>,
    /// Editor font override: `(family, size_pt)`. `None` (the default)
    /// leaves each backend's built-in default in place (GTK:
    /// `"Monospace 11"`; TUI: fixed-cell, no font concept — the value is
    /// ignored). Set via [`Self::with_editor_font`]; the shell runner
    /// applies it once via [`crate::Backend::set_editor_font`] during
    /// [`crate::shell_adapter::ShellAdapter`]'s one-time `setup()`, before
    /// the app's own `setup()` runs, so painted glyphs and click-column
    /// math derive from the same font from the very first frame.
    pub editor_font: Option<(String, f32)>,
    /// GTK application id, e.g. `"io.github.jdonaghy.VimCode"`. Feeds
    /// `gtk4::Application::builder().application_id(..)` in the GTK shell
    /// runner (`quadraui::gtk::run_with_shell`), which is what a live GDK
    /// backend derives the toplevel's identity from: Wayland
    /// `xdg_toplevel.set_app_id`, X11 `WM_CLASS`. The window manager uses
    /// that id to match a live window to an installed `.desktop` file —
    /// with the default generic id, every downstream app's taskbar/dock/
    /// alt-tab entry shows a generic icon instead of the app's own.
    /// Defaults to `"org.quadraui.app"` so existing callers are
    /// unaffected. Set via [`Self::with_app_id`]. Backends with no
    /// window-manager concept (TUI) ignore this field.
    pub app_id: String,
    /// Themed icon name, e.g. `"io.github.jdonaghy.vimcode"`, matching an
    /// icon installed under an XDG icon theme directory. Feeds
    /// `gtk4::Window::set_icon_name` in the GTK shell runner so themed-icon
    /// lookup works even on window managers that don't resolve the app id
    /// to a `.desktop` file. `None` (the default) leaves GTK's own
    /// fallback icon in place. Set via [`Self::with_icon_name`]. Backends
    /// with no icon-theme concept (TUI) ignore this field.
    pub icon_name: Option<String>,
    /// Per-panel Nerd-Font glyph + ASCII fallback overrides, replayed onto
    /// the built [`AppShell`] via [`AppShell::with_panel_icon`] by
    /// [`crate::shell_adapter::build_shell_adapter`]. Covers both top
    /// panels (`panels`) and [`Self::bottom_items`] — same seam,
    /// [`AppShell::with_panel_icon`] doesn't distinguish the two. Empty by
    /// default, so nothing that predates this field changes behavior:
    /// every panel keeps painting its single [`PanelDefinition::icon`]
    /// string under both settings of `nerd_fonts_enabled`, exactly as
    /// before.
    ///
    /// Set via [`Self::with_panel_icon`]. Before this field existed, a
    /// `ShellConfig`-based consumer had no way to reach
    /// [`AppShell::with_panel_icon`] at all — `build_shell_adapter` builds
    /// the `AppShell` directly from `panels/bottom_items` and never
    /// exposed a hook for it.
    pub panel_icons: Vec<(WidgetId, Icon)>,
    /// App icon (Dock/app-switcher on macOS, big+small taskbar/titlebar
    /// icon on Win-GUI). `None` (the default) leaves each backend's
    /// previous behaviour unchanged: macOS shows the generic
    /// unbundled-executable icon, Win-GUI shows no titlebar/taskbar icon.
    ///
    /// This is a **window-manager identity concern**, not a paint-time
    /// [`crate::primitives::image::Image`] primitive — there is no
    /// `Backend::draw_*` method for it, mirroring [`Self::app_id`] /
    /// [`Self::icon_name`] (GTK's equivalent window-manager identity
    /// fields, also consulted only by each backend's own shell runner,
    /// never by [`crate::shell_adapter`]). GTK keeps using
    /// [`Self::icon_name`] (the themed icon) and ignores this field —
    /// backends with no separate Dock/taskbar icon concept (TUI) ignore
    /// it too.
    ///
    /// Set via [`Self::with_app_icon`].
    pub app_icon: Option<ImageSource>,
    /// Activity-bar accent colour, forwarded to
    /// [`AppShell::with_active_accent`] at construction and available via
    /// [`AppShell::set_active_accent`] at runtime.  `None` (the default)
    /// paints no accent strip — see [`crate::ActivityBar::active_accent`].
    ///
    /// Set via [`Self::with_active_accent`].
    pub active_accent: Option<Color>,
    /// Keyboard-selection background, forwarded to
    /// [`AppShell::with_selection_bg`].  `None` (the default) lets each
    /// backend fall back to its own default.
    ///
    /// Set via [`Self::with_selection_bg`].
    pub selection_bg: Option<Color>,
}

impl ShellConfig {
    pub fn new(title: impl Into<String>, panels: Vec<PanelDefinition>) -> Self {
        Self {
            panels,
            bottom_items: Vec::new(),
            title: title.into(),
            default_sidebar_width: 20.0,
            min_sidebar_width: 8.0,
            max_sidebar_width: 50.0,
            activity_bar_width: 4.0,
            activity_bar_width_px: Some(48.0),
            position: ShellPosition::Left,
            has_title_bar: false,
            title_bar_height_lh: 1.5,
            title_bar_min_px: Some(35.0),
            client_side_titlebar: false,
            has_bottom_panel: false,
            bottom_panel_height_lh: 10.0,
            min_bottom_panel_height_lh: 3.0,
            max_bottom_panel_height_lh: 30.0,
            has_command_line: false,
            has_status_bar: false,
            status_bar_height_px: Some(22.0),
            status_bar_under_main_column: false,
            bottom_panel: None,
            bottom_bands: Vec::new(),
            editor_font: None,
            app_id: "org.quadraui.app".to_string(),
            icon_name: None,
            panel_icons: Vec::new(),
            app_icon: None,
            active_accent: None,
            selection_bg: None,
        }
    }

    pub fn with_bottom_items(mut self, items: Vec<PanelDefinition>) -> Self {
        self.bottom_items = items;
        self
    }

    pub fn with_position(mut self, position: ShellPosition) -> Self {
        self.position = position;
        self
    }

    /// Override the activity bar width in line-height multiples (`4.0` by
    /// default). Same unit as `default_sidebar_width`. See
    /// [`Self::with_activity_bar_width_px`] for a fixed-pixel alternative
    pub fn with_activity_bar_width(mut self, width_lh: f32) -> Self {
        self.activity_bar_width = width_lh;
        self
    }

    /// Pin the activity bar to a fixed pixel width, overriding
    /// `activity_bar_width`. Independent of `line_height` — defaults to
    /// `48.0`, keeping the bar square against `ACTIVITY_ROW_PX` regardless
    /// of the app's editor font size. To fall back to the line-height
    /// multiple instead, set the `activity_bar_width_px` field directly to
    /// `None` (it is `pub`).
    pub fn with_activity_bar_width_px(mut self, width_px: f32) -> Self {
        self.activity_bar_width_px = Some(width_px);
        self
    }

    pub fn with_title_bar(mut self, height_lh: f32) -> Self {
        self.has_title_bar = true;
        self.title_bar_height_lh = height_lh;
        self
    }

    /// Pin a fixed-pixel floor under the title bar's line-height-derived
    /// height — see [`AppShell::with_title_bar_min_px`] for the full
    /// rationale. Defaults to `35.0`. Set the `title_bar_min_px` field
    /// directly to `None` to leave `title_bar_height_lh * line_height` in
    /// sole charge instead.
    pub fn with_title_bar_min_px(mut self, min_px: f32) -> Self {
        self.title_bar_min_px = Some(min_px);
        self
    }

    /// Opt into a client-side titlebar: ask the backend not to
    /// also paint its own native titlebar band on top of an app-drawn
    /// [`Self::with_title_bar`] region. See [`Self::client_side_titlebar`]
    /// for the per-backend mechanism and why it is not GTK's
    /// "undecorated" model on macOS.
    ///
    /// Typically paired with [`Self::with_title_bar`] — this field alone
    /// only affects window creation, not layout; the app still reserves
    /// the band via `with_title_bar`.
    pub fn with_client_side_titlebar(mut self) -> Self {
        self.client_side_titlebar = true;
        self
    }

    pub fn with_bottom_panel(mut self, height_lh: f32) -> Self {
        self.has_bottom_panel = true;
        self.bottom_panel_height_lh = height_lh;
        self
    }

    pub fn with_bottom_panel_limits(mut self, min: f32, max: f32) -> Self {
        self.min_bottom_panel_height_lh = min;
        self.max_bottom_panel_height_lh = max;
        self
    }

    pub fn with_command_line(mut self) -> Self {
        self.has_command_line = true;
        self
    }

    pub fn with_status_bar(mut self) -> Self {
        self.has_status_bar = true;
        self
    }

    /// Pin the status bar to a fixed pixel height. Defaults to `22.0`,
    /// matching VS Code's status bar. Set the `status_bar_height_px` field
    /// directly to `None` to fall back to one line-height instead.
    pub fn with_status_bar_height_px(mut self, height_px: f32) -> Self {
        self.status_bar_height_px = Some(height_px);
        self
    }

    pub fn with_status_bar_under_main_column(mut self) -> Self {
        self.status_bar_under_main_column = true;
        self
    }

    /// Attach a tabbed bottom panel.
    ///
    /// This is the preferred way to add a bottom panel when you want tab
    /// switching, close buttons, and per-tab [`crate::compose::bottom_panel::BackendWidget`]
    /// content. It automatically enables the AppShell bottom panel region;
    /// the initial height comes from [`BottomPanelConfig::height_fraction`].
    ///
    /// Use [`Self::with_bottom_panel`] + [`Self::with_bottom_panel_limits`]
    /// instead when you only need a bare unstyled region below main content.
    pub fn with_bottom_panel_config(mut self, config: BottomPanelConfig) -> Self {
        self.bottom_panel = Some(config);
        self
    }

    /// Register the ordered list of independently-gated bottom bands
    /// — see [`Self::bottom_bands`] / [`BottomBand`].
    ///
    /// Replaces any previously-registered list. Combine freely with
    /// [`Self::with_bottom_panel`] / [`Self::with_bottom_panel_config`]:
    /// the legacy drawer always docks directly above these bands.
    pub fn with_bottom_bands(mut self, bands: Vec<BottomBand>) -> Self {
        self.bottom_bands = bands;
        self
    }

    /// Override the font painted for editor content (family name + size
    /// in points).
    ///
    /// `family` should name a monospace font — primitives that map
    /// columns to pixels assume uniform glyph width. Applied once via
    /// [`crate::Backend::set_editor_font`] during the shell runner's
    /// one-time `setup()` call (see [`Self::editor_font`]); call
    /// [`crate::Backend::set_editor_font`] directly at runtime (e.g. from
    /// [`ShellApp::handle`]) to change it again after startup, such as a
    /// zoom-in/out keybinding.
    pub fn with_editor_font(mut self, family: impl Into<String>, size_pt: f32) -> Self {
        self.editor_font = Some((family.into(), size_pt));
        self
    }

    /// Override the GTK application id (`"org.quadraui.app"` by default).
    ///
    /// Should be a reverse-DNS id — see the
    /// [GNOME application ID guidelines](https://developer.gnome.org/documentation/tutorials/application-id.html).
    /// GTK warns and ignores a malformed id rather than rejecting it
    /// outright, so this method does not validate the string itself.
    /// See [`Self::app_id`] for why this matters.
    pub fn with_app_id(mut self, app_id: impl Into<String>) -> Self {
        self.app_id = app_id.into();
        self
    }

    /// Set a themed icon name for the window (unset — GTK's own fallback —
    /// by default). See [`Self::icon_name`] for why this matters.
    pub fn with_icon_name(mut self, icon_name: impl Into<String>) -> Self {
        self.icon_name = Some(icon_name.into());
        self
    }

    /// Attach a distinct Nerd-Font glyph + ASCII fallback pair to one
    /// activity-bar row, mirroring [`AppShell::with_panel_icon`] — the
    /// consuming-builder method [`crate::shell_adapter::build_shell_adapter`]
    /// replays every registered pair onto during construction.
    ///
    /// `id` may name a top panel (`panels`) or a [`Self::bottom_items`]
    /// entry; unknown ids are stored but never consulted, so call order
    /// relative to `ShellConfig::new` / [`Self::with_bottom_items`] doesn't
    /// matter. Calling this twice for the same id keeps the last pair —
    /// same last-write-wins semantics as `AppShell::with_panel_icon`, since
    /// both are ultimately backed by the same `HashMap`.
    pub fn with_panel_icon(mut self, id: WidgetId, icon: Icon) -> Self {
        self.panel_icons.push((id, icon));
        self
    }

    /// Set the app icon (Dock/app-switcher on macOS, taskbar/titlebar on
    /// Win-GUI) — see [`Self::app_icon`] for the per-backend contract
    pub fn with_app_icon(mut self, icon: ImageSource) -> Self {
        self.app_icon = Some(icon);
        self
    }

    /// Set the activity-bar accent colour forwarded to
    /// [`AppShell::with_active_accent`] at construction. See
    /// [`Self::active_accent`] for the full contract.
    pub fn with_active_accent(mut self, color: Color) -> Self {
        self.active_accent = Some(color);
        self
    }

    /// Set the keyboard-selection background forwarded to
    /// [`AppShell::with_selection_bg`] at construction. See
    /// [`Self::selection_bg`] for the full contract.
    pub fn with_selection_bg(mut self, color: Color) -> Self {
        self.selection_bg = Some(color);
        self
    }
}

/// Context passed to [`ShellApp::handle`] so the consumer can route
/// events by panel without tracking shell state themselves.
pub struct ShellContext<'a> {
    /// Currently active sidebar panel, if any.
    pub active_panel_id: Option<&'a WidgetId>,
    /// Whether the sidebar is visible.
    pub sidebar_visible: bool,
    /// Layout bounds from the last render.
    pub layout: &'a AppShellLayout,
    /// Set via [`Self::request_activity_keyboard_focus`]; consumed by
    /// [`crate::shell_adapter::ShellAdapter::handle`] after
    /// `ShellApp::handle` returns. `Cell` because `ShellContext` is passed
    /// by shared reference — the consumer can request focus without a
    /// `&mut` hook back into the shell.
    activity_focus_requested: Cell<bool>,
    /// A scoped mutable borrow of the [`AppShell`] instance
    /// [`crate::shell_adapter::ShellAdapter`] actually renders, lent out for
    /// the duration of one `ShellApp::handle` dispatch.
    ///
    /// Before this existed, a `ShellApp` consumer had no way to reach the
    /// rendered shell at all — `ShellAdapter::shell` is `pub(crate)` — so
    /// driving shell state programmatically (e.g. a `Ctrl+B` toggle-sidebar
    /// binding) required keeping a second, shadow `AppShell` that silently
    /// drifted from the one actually painted (vimcode `Ctrl+B` was dead on
    /// GTK because of exactly this: the shadow toggled, the rendered
    /// instance never learned about it).
    ///
    /// `RefCell` because `ShellContext` is passed by shared reference (see
    /// `activity_focus_requested` above) — access via [`Self::shell`] /
    /// [`Self::shell_mut`]. `AppShell` remains solely owned and constructed
    /// by `ShellAdapter`; this only lends a scoped borrow for one dispatch,
    /// so the single-owner invariant that makes drift impossible is
    /// preserved.
    shell: RefCell<&'a mut AppShell>,
}

impl<'a> ShellContext<'a> {
    /// Construct a [`ShellContext`] for one `ShellApp::handle` dispatch.
    /// Only called by [`crate::shell_adapter::ShellAdapter`]; downstream
    /// consumers receive an already-built context, they don't build one.
    ///
    /// `cfg`-gated with `ShellAdapter` itself: under a feature set
    /// with no shell runner there is no caller, so this and
    /// `take_activity_focus_requested` below go dead-code under
    /// `-D warnings`. `macos` and `win` are included in the gate to match
    /// their respective shell runners. `test` is included so tests in
    /// this module can build a `ShellContext` directly.
    #[cfg(any(
        feature = "tui",
        feature = "gtk",
        all(feature = "macos", target_os = "macos"),
        feature = "win",
        test
    ))]
    pub(crate) fn new(
        active_panel_id: Option<&'a WidgetId>,
        sidebar_visible: bool,
        layout: &'a AppShellLayout,
        shell: &'a mut AppShell,
    ) -> Self {
        Self {
            active_panel_id,
            sidebar_visible,
            layout,
            activity_focus_requested: Cell::new(false),
            shell: RefCell::new(shell),
        }
    }

    /// Borrow the real, rendered [`AppShell`] read-only.
    ///
    /// Prefer the narrow accessors above (`in_sidebar`, `sidebar_bounds`,
    /// ...) for layout queries — this exists for the rest of `AppShell`'s
    /// API (e.g. `bottom_panel_visible()`, `activity_selected_id()`) that
    /// `ShellContext` doesn't otherwise mirror.
    ///
    /// # Panics
    /// Panics if [`Self::shell_mut`] is borrowed at the same time (standard
    /// `RefCell` rules). Each borrow is meant to be short-lived — grab it,
    /// read, drop.
    pub fn shell(&self) -> Ref<'_, &'a mut AppShell> {
        self.shell.borrow()
    }

    /// Borrow the real, rendered [`AppShell`] mutably.
    ///
    /// Call any `AppShell` mutator directly on the instance
    /// [`crate::shell_adapter::ShellAdapter`] actually renders —
    /// `ctx.shell_mut().toggle_sidebar()`,
    /// `ctx.shell_mut().show_bottom_panel()`,
    /// `ctx.shell_mut().set_sidebar_width(w)`, etc. — to keep shell state
    /// in sync with the rendered display.
    ///
    /// # Panics
    /// Panics if [`Self::shell`] / [`Self::shell_mut`] is borrowed at the
    /// same time (standard `RefCell` rules). Each borrow is meant to be
    /// short-lived — grab it, mutate, drop.
    pub fn shell_mut(&self) -> RefMut<'_, &'a mut AppShell> {
        self.shell.borrow_mut()
    }

    /// Request that the activity bar take keyboard focus, with its cursor
    /// reset to the top item, once the current `ShellApp::handle` call
    /// returns.
    ///
    /// Call this from your own `handle()` in response to whatever key you
    /// want to bind as the "focus the activity bar" trigger (`Tab`,
    /// `Ctrl+W`, a command-palette action, ...) — quadraui does not
    /// reserve a key for this itself, so different consumers can pick
    /// different triggers. Once focused, [`crate::shell_adapter::ShellAdapter`]
    /// owns the navigation keys (`j`/`k`/arrows to move, `Enter`/`Space` to
    /// activate, `Esc` to cancel) by driving the same
    /// [`crate::compose::app_shell::AppShell`] methods the raw `AppLogic`
    /// pattern uses directly — see `examples/common/shell_app.rs`.
    ///
    /// A no-op if called more than once per `handle()` call (the flag is
    /// simply set, not counted).
    pub fn request_activity_keyboard_focus(&self) {
        self.activity_focus_requested.set(true);
    }

    /// Consume the pending focus request, if any. `pub(crate)` — only
    /// [`crate::shell_adapter::ShellAdapter::handle`] calls this, after
    /// `ShellApp::handle` returns.
    ///
    /// `cfg`-gated with `ShellAdapter` itself; see [`Self::new`].
    #[cfg(any(
        feature = "tui",
        feature = "gtk",
        all(feature = "macos", target_os = "macos"),
        feature = "win"
    ))]
    pub(crate) fn take_activity_focus_requested(&self) -> bool {
        self.activity_focus_requested.replace(false)
    }

    /// Check if a mouse position lands inside the sidebar content area.
    pub fn in_sidebar(&self, x: f32, y: f32) -> bool {
        self.layout
            .sidebar_content_bounds
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Check if a mouse position lands inside the main content area.
    pub fn in_main(&self, x: f32, y: f32) -> bool {
        self.layout.main_content_bounds.contains(Point::new(x, y))
    }

    /// Check if a mouse position lands inside the bottom panel.
    pub fn in_bottom_panel(&self, x: f32, y: f32) -> bool {
        self.layout
            .bottom_panel_bounds
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Check if a mouse position lands inside the title bar.
    pub fn in_title_bar(&self, x: f32, y: f32) -> bool {
        self.layout
            .title_bar_bounds
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Check if a mouse position lands inside the status bar.
    pub fn in_status_bar(&self, x: f32, y: f32) -> bool {
        self.layout
            .status_bar_bounds
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Check if a mouse position lands inside the command line.
    pub fn in_command_line(&self, x: f32, y: f32) -> bool {
        self.layout
            .command_line_bounds
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Sidebar content bounds (convenience for coordinate translation).
    pub fn sidebar_bounds(&self) -> Option<Rect> {
        self.layout.sidebar_content_bounds
    }

    /// Main content bounds.
    pub fn main_bounds(&self) -> Rect {
        self.layout.main_content_bounds
    }

    /// Bottom panel bounds.
    pub fn bottom_panel_bounds(&self) -> Option<Rect> {
        self.layout.bottom_panel_bounds
    }

    /// Resolved bounds for one currently-visible [`BottomBand`],
    /// or `None` if `id` names no registered band or the
    /// band is not visible in the last computed layout.
    ///
    /// Reads [`AppShell::bottom_band_bounds`] rather than a field on
    /// [`AppShellLayout`] — see that struct's doc for why bottom-band
    /// bounds live there instead of on the layout snapshot.
    pub fn bottom_band_bounds(&self, id: &WidgetId) -> Option<Rect> {
        self.shell()
            .bottom_band_bounds()
            .into_iter()
            .find(|(band_id, _)| band_id == id)
            .map(|(_, rect)| rect)
    }

    /// Check if a mouse position lands inside one currently-visible
    /// [`BottomBand`].
    pub fn in_bottom_band(&self, id: &WidgetId, x: f32, y: f32) -> bool {
        self.bottom_band_bounds(id)
            .is_some_and(|r| r.contains(Point::new(x, y)))
    }

    /// Title bar bounds.
    pub fn title_bar_bounds(&self) -> Option<Rect> {
        self.layout.title_bar_bounds
    }

    /// The full window/viewport bounds this layout was computed against.
    pub fn window_bounds(&self) -> Rect {
        self.layout.window_bounds
    }

    /// Which edge or corner of the window `(x, y)` is within `margin` of,
    /// or `None` if the position isn't near any outer border.
    ///
    /// Mirrors [`Self::in_title_bar`]'s pattern: the app hit-tests the
    /// pointer against a stored bounds field every frame rather than the
    /// backend owning edge detection. Callers should derive `margin` from a
    /// portable backend unit (e.g. `backend.line_height()`) rather than a
    /// hardcoded pixel/cell constant — see `quadraui/docs/LESSONS.md`
    /// "Shared AppLogic code must not hardcode backend-native units".
    ///
    /// Call from a `MouseDown` handler (pass the result to
    /// [`Backend::begin_window_resize`]) and from a `MouseMoved` handler
    /// (pass `PointerShape::Resize(edge)` / `PointerShape::Default` to
    /// [`Backend::set_cursor`]).
    pub fn window_edge(&self, x: f32, y: f32, margin: f32) -> Option<ResizeEdge> {
        let r = self.layout.window_bounds;
        // Points outside the window entirely (shouldn't normally happen —
        // mouse events are clipped to the window — but defend anyway) never
        // resolve to an edge.
        if x < r.x || x > r.x + r.width || y < r.y || y > r.y + r.height {
            return None;
        }
        // `near_right`/`near_bottom` use `>=` (not `>`) so the last valid
        // cell index is included on TUI, mirroring `Rect::contains`'s own
        // `x < r.x + r.width` upper bound (which treats column
        // `r.width - 1` as inside). With continuous GTK pixel coordinates
        // the `=` case is a single point of measure zero and doesn't
        // change behaviour; on TUI's discrete cell grid it's the
        // difference between the bottom-right corner being reachable at
        // all and a permanently-dead corner (margin == 1 cell exactly
        // covers the last row/column, so a strict `>` would never fire).
        let margin = margin.max(0.0);
        let near_left = x < r.x + margin;
        let near_right = x >= r.x + r.width - margin;
        let near_top = y < r.y + margin;
        let near_bottom = y >= r.y + r.height - margin;

        // Corners first, then single edges. An if-chain (rather than an
        // exhaustive match on all four bools) reads clearer and handles the
        // degenerate case of a window smaller than `2 * margin` in one
        // dimension (both `near_top` and `near_bottom` true, no left/right)
        // by falling through to a deterministic single-edge pick instead of
        // requiring a meaningless tie-break arm.
        if near_top && near_left {
            Some(ResizeEdge::NorthWest)
        } else if near_top && near_right {
            Some(ResizeEdge::NorthEast)
        } else if near_bottom && near_left {
            Some(ResizeEdge::SouthWest)
        } else if near_bottom && near_right {
            Some(ResizeEdge::SouthEast)
        } else if near_top {
            Some(ResizeEdge::North)
        } else if near_bottom {
            Some(ResizeEdge::South)
        } else if near_left {
            Some(ResizeEdge::West)
        } else if near_right {
            Some(ResizeEdge::East)
        } else {
            None
        }
    }

    /// Status bar bounds.
    pub fn status_bar_bounds(&self) -> Option<Rect> {
        self.layout.status_bar_bounds
    }

    /// Command line bounds.
    pub fn command_line_bounds(&self) -> Option<Rect> {
        self.layout.command_line_bounds
    }
}

/// Application trait for apps that use the AppShell chrome.
///
/// The shell handles: activity bar rendering + clicks, sidebar
/// header + divider, panel switching, and resize drag. The consumer
/// renders panel content and main-area content into the bounds the
/// shell provides via [`AppShellLayout`].
pub trait ShellApp {
    /// Render content into the shell's content zones. The shell has
    /// already drawn its chrome (activity bar, sidebar header, divider);
    /// the consumer draws sidebar panel content + main content here.
    fn render_content(&self, backend: &mut dyn Backend, layout: &AppShellLayout);

    /// Render one currently-visible [`crate::compose::app_shell::BottomBand`].
    /// Called once per visible band, after `render_content`,
    /// in the same bottom-up stacking order the band list was given.
    ///
    /// This is a separate hook rather than a field on [`AppShellLayout`]
    /// deliberately: `AppShellLayout` is an all-`pub`-field struct a real
    /// downstream consumer builds with an exhaustive struct literal (see
    /// that struct's doc and `quadraui/tests/downstream_struct_literals.rs`),
    /// so growing its field list breaks that call site. A new trait method
    /// with a default (no-op) implementation is additive instead — see
    /// `docs/PRIMITIVE_RULES.md` rule 8.
    ///
    /// Default: no-op — apps that never call
    /// [`crate::compose::app_shell::AppShell::with_bottom_bands`] /
    /// [`ShellConfig::bottom_bands`] are unaffected.
    fn render_bottom_band(&self, _backend: &mut dyn Backend, _id: &WidgetId, _bounds: Rect) {}

    /// Handle events the shell didn't consume. The [`ShellContext`]
    /// provides the active panel ID and layout bounds so the consumer
    /// can route per-panel without tracking shell state.
    fn handle(&mut self, event: UiEvent, backend: &mut dyn Backend, ctx: &ShellContext)
        -> Reaction;

    /// Called once after the shell is built. Optional.
    fn setup(&mut self, _backend: &mut dyn Backend) {}

    /// Called every frame before the shell reads `chrome_line_height` and
    /// computes its layout.  Apps that update backend font metrics (e.g.
    /// via `set_ui_font` / `set_editor_font` / `set_theme`) should do so
    /// here so the shell layout uses the current values on the same frame.
    fn pre_render(&self, _backend: &mut dyn Backend) {}

    /// Notified when a panel switch occurs (activity bar click or
    /// programmatic). Optional.
    ///
    /// The [`ShellContext`] lends the same scoped `&mut AppShell` borrow
    /// [`Self::handle`] receives — call `ctx.shell_mut()` mutators
    /// here (e.g. `set_title_bar_visible`, `set_sidebar_width`,
    /// `show_panel`, `toggle_sidebar`) to push state back into the shell
    /// on the *same frame* this event fires.
    ///
    /// Default implementation is a no-op.
    fn on_shell_event_ctx(&mut self, _event: &AppShellEvent, _ctx: &ShellContext) {}

    /// Poll for a pending **app-initiated** panel switch — e.g. an action
    /// handler that jumps straight to a different panel (a "launch
    /// interactive session" command landing in the Terminal panel) without
    /// the user clicking the ActivityBar.
    ///
    /// [`ShellAdapter`](crate::shell_adapter::ShellAdapter) calls this once
    /// immediately after every [`Self::handle`] dispatch. Returning
    /// `Some(panel_id)` applies the switch to the underlying `AppShell`
    /// (updating the ActivityBar highlight and sidebar panel header, which
    /// are otherwise owned entirely by `AppShell` and invisible to
    /// `ShellApp` implementors) and re-notifies via
    /// [`Self::on_shell_event_ctx`] with [`AppShellEvent::PanelChanged`], the
    /// same notification a mouse click produces — so app code that already
    /// syncs its own view state from `on_shell_event_ctx` doesn't need a
    /// second code path.
    ///
    /// Default: never requests a switch. `&mut self` (not `&self`) so
    /// implementors can `.take()` a stored `Option` field rather than
    /// needing interior mutability.
    fn take_requested_panel(&mut self) -> Option<WidgetId> {
        None
    }

    /// Notified when the bottom panel tab strip emits an event
    /// (tab activation, close, maximise toggle, or resize).
    ///
    /// Only called when `ShellConfig.bottom_panel` is `Some`. The
    /// [`crate::compose::bottom_panel::BottomPanelController`] has already
    /// applied the state change (switched active tab, removed a closed tab,
    /// toggled maximised) before this method is called. Use it for any
    /// higher-level bookkeeping — re-rendering is triggered automatically.
    ///
    /// Default: no-op.
    fn on_bottom_panel_event(&mut self, _event: &BottomPanelEvent) {}

    /// Periodic callback invoked by the runner on every frame (≈60Hz on
    /// the TUI backend, GTK timeout on GTK). Use for timer-driven work —
    /// polling background tasks, expiring caches, draining channels —
    /// that must happen without a user input event. Default is no-op.
    fn tick(&mut self, _backend: &mut dyn Backend) -> Reaction {
        Reaction::Continue
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// Build a bare (no panels, no chrome) `AppShellLayout` sized `w x h`
    /// starting at the origin — just enough to exercise `window_bounds`.
    fn layout_for(w: f32, h: f32) -> AppShellLayout {
        AppShell::new(Vec::new(), 20.0).layout(Rect::new(0.0, 0.0, w, h), 1.0)
    }

    fn ctx<'a>(layout: &'a AppShellLayout, shell: &'a mut AppShell) -> ShellContext<'a> {
        ShellContext::new(None, false, layout, shell)
    }

    /// A fresh `ShellConfig` has no editor-font override — backends
    /// keep their own default (GTK: "Monospace 11").
    #[test]
    fn shell_config_editor_font_defaults_to_none() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.editor_font, None);
    }

    /// `with_editor_font` stores the family/size pair verbatim for
    /// the shell runner to apply via `Backend::set_editor_font`.
    #[test]
    fn shell_config_with_editor_font_sets_family_and_size() {
        let config = ShellConfig::new("test", Vec::new()).with_editor_font("Fira Code", 14.0);
        assert_eq!(config.editor_font, Some(("Fira Code".to_string(), 14.0)));
    }

    /// A fresh `ShellConfig` keeps the generic app id and no icon
    /// override, so nothing that predates this field changes behavior.
    #[test]
    fn shell_config_app_id_defaults_to_generic() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.app_id, "org.quadraui.app");
        assert_eq!(config.icon_name, None);
    }

    /// `with_app_id` stores the caller's id verbatim, replacing the
    /// generic default the GTK shell runner would otherwise announce to
    /// the window manager (Wayland `app_id` / X11 `WM_CLASS`).
    #[test]
    fn shell_config_with_app_id_overrides_the_default() {
        let config = ShellConfig::new("test", Vec::new()).with_app_id("io.github.jdonaghy.VimCode");
        assert_eq!(config.app_id, "io.github.jdonaghy.VimCode");
    }

    /// A fresh `ShellConfig` keeps `client_side_titlebar` off, so
    /// every existing consumer's window-creation call keeps getting
    /// today's native chrome unchanged.
    #[test]
    fn shell_config_client_side_titlebar_defaults_to_false() {
        let config = ShellConfig::new("test", Vec::new());
        assert!(!config.client_side_titlebar);
    }

    /// `with_client_side_titlebar` opts in, mirroring the no-arg
    /// `with_command_line`/`with_status_bar` builders above since there's
    /// no accompanying data (unlike `with_title_bar`'s height).
    #[test]
    fn shell_config_with_client_side_titlebar_opts_in() {
        let config = ShellConfig::new("test", Vec::new()).with_client_side_titlebar();
        assert!(config.client_side_titlebar);
    }

    /// `with_icon_name` stores the themed icon name for the GTK
    /// shell runner to apply via `gtk4::Window::set_icon_name`.
    #[test]
    fn shell_config_with_icon_name_sets_the_icon() {
        let config =
            ShellConfig::new("test", Vec::new()).with_icon_name("io.github.jdonaghy.vimcode");
        assert_eq!(
            config.icon_name,
            Some("io.github.jdonaghy.vimcode".to_string())
        );
    }

    /// A fresh `ShellConfig` keeps `AppShell`'s own line-height-multiple
    /// default (4.0, giving 4 TUI columns: 1 accent + 2 icon cells for
    /// double-width nerd font glyphs + 1 separator) available as a
    /// fallback, but leads with a px-first default matching VS Code's
    /// activity bar (`48.0`) on pixel backends.
    #[test]
    fn shell_config_activity_bar_width_defaults_match_app_shell() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.activity_bar_width, 4.0);
        assert_eq!(config.activity_bar_width_px, Some(48.0));
    }

    /// `with_activity_bar_width` stores the line-height multiple
    /// verbatim for `build_shell_adapter` to pass through to `AppShell`.
    #[test]
    fn shell_config_with_activity_bar_width_overrides_the_multiple() {
        let config = ShellConfig::new("test", Vec::new()).with_activity_bar_width(2.4);
        assert_eq!(config.activity_bar_width, 2.4);
    }

    /// `with_activity_bar_width_px` stores a fixed-pixel override,
    /// letting a consumer pin the bar to VS Code's 48px regardless of the
    /// app's editor font / line height.
    #[test]
    fn shell_config_with_activity_bar_width_px_sets_the_override() {
        let config = ShellConfig::new("test", Vec::new()).with_activity_bar_width_px(48.0);
        assert_eq!(config.activity_bar_width_px, Some(48.0));
    }

    /// A fresh `ShellConfig` defaults the title-bar-min-px floor to `35.0`,
    /// matching VS Code's tab/title bar on pixel backends.
    #[test]
    fn shell_config_title_bar_min_px_defaults_to_35() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.title_bar_min_px, Some(35.0));
    }

    /// `with_title_bar_min_px` stores the floor for
    /// `build_shell_adapter` to pass through to `AppShell`.
    #[test]
    fn shell_config_with_title_bar_min_px_sets_the_floor() {
        let config = ShellConfig::new("test", Vec::new()).with_title_bar_min_px(34.0);
        assert_eq!(config.title_bar_min_px, Some(34.0));
    }

    /// A fresh `ShellConfig` defaults the status bar height to `22.0`,
    /// matching VS Code's status bar on pixel backends.
    #[test]
    fn shell_config_status_bar_height_px_defaults_to_22() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.status_bar_height_px, Some(22.0));
    }

    /// `with_status_bar_height_px` stores the override for
    /// `build_shell_adapter` to pass through to `AppShell`.
    #[test]
    fn shell_config_with_status_bar_height_px_sets_the_override() {
        let config = ShellConfig::new("test", Vec::new()).with_status_bar_height_px(30.0);
        assert_eq!(config.status_bar_height_px, Some(30.0));
    }

    /// A fresh `ShellConfig` has no panel-icon overrides — nothing
    /// that predates this field changes behavior.
    #[test]
    fn shell_config_panel_icons_defaults_to_empty() {
        let config = ShellConfig::new("test", Vec::new());
        assert!(config.panel_icons.is_empty());
    }

    /// `with_panel_icon` appends `(id, icon)` pairs verbatim, in call
    /// order, for `build_shell_adapter` to replay onto the `AppShell`.
    #[test]
    fn shell_config_with_panel_icon_appends_overrides_in_order() {
        let config = ShellConfig::new("test", Vec::new())
            .with_panel_icon(WidgetId::new("panel:explorer"), Icon::new("\u{f07c}", "E"))
            .with_panel_icon(WidgetId::new("panel:settings"), Icon::new("\u{f013}", "S"));
        assert_eq!(
            config.panel_icons,
            vec![
                (WidgetId::new("panel:explorer"), Icon::new("\u{f07c}", "E")),
                (WidgetId::new("panel:settings"), Icon::new("\u{f013}", "S")),
            ]
        );
    }

    /// A fresh `ShellConfig` has no app-icon override — every
    /// existing consumer keeps whatever generic icon its backend showed
    /// before this field existed (macOS: the unbundled-executable icon;
    /// Win-GUI: no titlebar/taskbar icon).
    #[test]
    fn shell_config_app_icon_defaults_to_none() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.app_icon, None);
    }

    /// `with_app_icon` stores the source verbatim for each
    /// backend's shell runner to thread onto its own `RunConfig`.
    #[test]
    fn shell_config_with_app_icon_sets_the_source() {
        let config =
            ShellConfig::new("test", Vec::new()).with_app_icon(ImageSource::Bytes(vec![1, 2, 3]));
        assert_eq!(config.app_icon, Some(ImageSource::Bytes(vec![1, 2, 3])));
    }

    /// A fresh `ShellConfig` has no accent or selection background
    /// override — nothing that predates these fields changes behavior.
    #[test]
    fn shell_config_accent_defaults_to_none() {
        let config = ShellConfig::new("test", Vec::new());
        assert_eq!(config.active_accent, None);
        assert_eq!(config.selection_bg, None);
    }

    /// `with_active_accent` and `with_selection_bg` store the colours
    /// verbatim for `build_shell_adapter` to forward to `AppShell`.
    #[test]
    fn shell_config_accent_flows_to_app_shell_via_adapter() {
        let accent = Color::rgb(100, 200, 50);
        let sel = Color::rgb(50, 50, 80);
        let config = ShellConfig::new("test", Vec::new())
            .with_active_accent(accent)
            .with_selection_bg(sel);
        assert_eq!(config.active_accent, Some(accent));
        assert_eq!(config.selection_bg, Some(sel));
    }

    /// A fresh `ShellConfig` registers no bottom bands — nothing
    /// that predates this field changes behavior.
    #[test]
    fn shell_config_bottom_bands_defaults_to_empty() {
        let config = ShellConfig::new("test", Vec::new());
        assert!(config.bottom_bands.is_empty());
    }

    /// `with_bottom_bands` stores the ordered list verbatim for
    /// `build_shell_adapter` to replay onto the `AppShell`.
    #[test]
    fn shell_config_with_bottom_bands_stores_the_list() {
        let bands = vec![
            BottomBand::new(WidgetId::new("band:qf"), 3.0),
            BottomBand::new(WidgetId::new("band:wildmenu"), 1.0),
        ];
        let config = ShellConfig::new("test", Vec::new()).with_bottom_bands(bands.clone());
        assert_eq!(config.bottom_bands, bands);
    }

    /// `ShellContext::bottom_band_bounds`/`in_bottom_band` resolve
    /// against a band registered on the underlying `AppShell`, mirroring
    /// the existing `bottom_panel_bounds`/`in_bottom_panel` accessors.
    #[test]
    fn shell_context_resolves_bottom_band_bounds_and_hit_test() {
        let band_id = WidgetId::new("band:qf");
        let mut shell = AppShell::new(Vec::new(), 20.0)
            .with_bottom_bands(vec![BottomBand::new(band_id.clone(), 2.0)]);
        let layout = shell.layout(Rect::new(0.0, 0.0, 100.0, 40.0), 1.0);
        let c = ctx(&layout, &mut shell);

        let bounds = c
            .bottom_band_bounds(&band_id)
            .expect("registered band has bounds");
        assert_eq!(bounds.height, 2.0);
        assert!(c.in_bottom_band(&band_id, bounds.x + 1.0, bounds.y + 0.5));
        assert!(!c.in_bottom_band(&band_id, bounds.x + 1.0, bounds.y - 1.0));

        let unknown = WidgetId::new("band:nope");
        assert!(c.bottom_band_bounds(&unknown).is_none());
        assert!(!c.in_bottom_band(&unknown, 0.0, 0.0));
    }

    #[test]
    fn window_edge_none_in_the_middle() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        assert_eq!(ctx(&layout, &mut shell).window_edge(50.0, 20.0, 4.0), None);
    }

    #[test]
    fn window_edge_detects_each_side() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        let c = ctx(&layout, &mut shell);
        assert_eq!(c.window_edge(50.0, 0.0, 4.0), Some(ResizeEdge::North));
        assert_eq!(c.window_edge(50.0, 40.0, 4.0), Some(ResizeEdge::South));
        assert_eq!(c.window_edge(0.0, 20.0, 4.0), Some(ResizeEdge::West));
        assert_eq!(c.window_edge(100.0, 20.0, 4.0), Some(ResizeEdge::East));
    }

    #[test]
    fn window_edge_detects_each_corner() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        let c = ctx(&layout, &mut shell);
        assert_eq!(c.window_edge(0.0, 0.0, 4.0), Some(ResizeEdge::NorthWest));
        assert_eq!(c.window_edge(100.0, 0.0, 4.0), Some(ResizeEdge::NorthEast));
        assert_eq!(c.window_edge(0.0, 40.0, 4.0), Some(ResizeEdge::SouthWest));
        assert_eq!(c.window_edge(100.0, 40.0, 4.0), Some(ResizeEdge::SouthEast));
    }

    /// A point outside the window bounds entirely never resolves to an
    /// edge, even if it would be "within margin" of one in absolute terms.
    #[test]
    fn window_edge_none_outside_window() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        assert_eq!(ctx(&layout, &mut shell).window_edge(-2.0, 20.0, 4.0), None);
        assert_eq!(ctx(&layout, &mut shell).window_edge(50.0, 45.0, 4.0), None);
    }

    /// A window narrower/shorter than `2 * margin` must still resolve
    /// deterministically (no panic) rather than requiring an ambiguous
    /// top-vs-bottom / left-vs-right tie-break.
    #[test]
    fn window_edge_degenerate_tiny_window_is_deterministic() {
        let layout = layout_for(3.0, 3.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        let c = ctx(&layout, &mut shell);
        // Every point in a 3x3 window is within margin=4.0 of every edge;
        // just assert this doesn't panic and returns a corner (checked
        // first in the priority chain).
        assert_eq!(c.window_edge(1.5, 1.5, 4.0), Some(ResizeEdge::NorthWest));
    }

    /// `ctx.shell_mut()` reaches the real `AppShell` — a `ShellApp`
    /// can drive shell state (e.g. a `Ctrl+B` toggle-sidebar binding)
    /// directly on the instance that's actually rendered, with no shadow
    /// copy required.
    #[test]
    fn shell_mut_toggles_the_real_app_shell() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        assert!(shell.sidebar_visible());
        {
            let c = ctx(&layout, &mut shell);
            c.shell_mut().toggle_sidebar();
        }
        assert!(!shell.sidebar_visible());
    }

    /// `ctx.shell()` gives read access without requiring a mutable
    /// borrow, mirroring the read-only convenience accessors above.
    #[test]
    fn shell_read_reflects_current_state() {
        let layout = layout_for(100.0, 40.0);
        let mut shell = AppShell::new(Vec::new(), 20.0);
        shell.hide_sidebar();
        let c = ctx(&layout, &mut shell);
        assert!(!c.shell().sidebar_visible());
    }
}