1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
// Copyright © 2024 Marvin Beckmann
//
// This file is part of qFALL-math.
//
// qFALL-math is free software: you can redistribute it and/or modify it under
// the terms of the Mozilla Public License Version 2.0 as published by the
// Mozilla Foundation. See <https://mozilla.org/en-US/MPL/2.0/>.
//! This module includes functionality for rounding instances of [`MatQ`] entrywise.
use super::MatQ;
use crate::{
error::MathError,
integer::MatZ,
rational::Q,
traits::{MatrixDimensions, MatrixGetEntry, MatrixSetEntry},
};
impl MatQ {
/// Rounds all entries of the given rational matrix [`MatQ`] down to the next integer
/// as a [`MatZ`].
///
/// # Examples
/// ```
/// use qfall_math::rational::MatQ;
/// use qfall_math::integer::MatZ;
/// use std::str::FromStr;
///
/// let value = MatQ::from_str("[[5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[2, 1]]").unwrap(), value.floor());
///
/// let value = MatQ::from_str("[[-5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[-3, 1]]").unwrap(), value.floor());
/// ```
pub fn floor(&self) -> MatZ {
let mut out = MatZ::new(self.get_num_rows(), self.get_num_columns());
for i in 0..out.get_num_rows() {
for j in 0..out.get_num_columns() {
let entry = unsafe { self.get_entry_unchecked(i, j) }.floor();
unsafe { out.set_entry_unchecked(i, j, entry) };
}
}
out
}
/// Rounds all entries of the given rational matrix [`MatQ`] up to the next integer
/// as a [`MatZ`].
///
/// # Examples
/// ```
/// use qfall_math::rational::MatQ;
/// use qfall_math::integer::MatZ;
/// use std::str::FromStr;
///
/// let value = MatQ::from_str("[[5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[3, 1]]").unwrap(), value.ceil());
///
/// let value = MatQ::from_str("[[-5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[-2, 1]]").unwrap(), value.ceil());
/// ```
pub fn ceil(&self) -> MatZ {
let mut out = MatZ::new(self.get_num_rows(), self.get_num_columns());
for i in 0..out.get_num_rows() {
for j in 0..out.get_num_columns() {
let entry = unsafe { self.get_entry_unchecked(i, j) }.ceil();
unsafe { out.set_entry_unchecked(i, j, entry) };
}
}
out
}
/// Rounds all entries of the given rational matrix [`MatQ`] to the closest integer
/// as a [`MatZ`].
///
/// # Examples
/// ```
/// use qfall_math::rational::MatQ;
/// use qfall_math::integer::MatZ;
/// use std::str::FromStr;
///
/// let value = MatQ::from_str("[[5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[3, 1]]").unwrap(), value.round());
///
/// let value = MatQ::from_str("[[-5/2, 1]]").unwrap();
/// assert_eq!(MatZ::from_str("[[-2, 1]]").unwrap(), value.round());
/// ```
pub fn round(&self) -> MatZ {
let mut out = MatZ::new(self.get_num_rows(), self.get_num_columns());
for i in 0..out.get_num_rows() {
for j in 0..out.get_num_columns() {
let entry = unsafe { self.get_entry_unchecked(i, j) }.round();
unsafe { out.set_entry_unchecked(i, j, entry) };
}
}
out
}
/// Returns a matrix, where each entry was simplified using [`Q::simplify`],
/// i.e. each entry becomes the smallest rational with the smallest denominator in the range
/// `\[entry - |precision|, entry + |precision|\]`.
///
/// This function allows to free memory in exchange for the specified loss of
/// precision (see Example 3). Be aware that this loss of precision is propagated by
/// arithmetic operations depending on the size of the matrices.
/// This functions allows to trade precision for efficiency.
///
/// This function ensures that simplifying does not change the sign of any entry in the matrix.
///
/// Parameters:
/// - `precision`: the precision the new entries can differ from `self`.
/// Note that the absolute value is relevant, not the sign.
///
/// Returns a new [`MatQ`] with each entry being the simplest fraction within the defined range.
///
/// # Examples
/// ```
/// use qfall_math::rational::{MatQ, Q};
/// use qfall_math::traits::{MatrixGetEntry, MatrixSetEntry};
/// let mut matrix = MatQ::new(1, 2);
/// matrix.set_entry(0, 0, Q::from((17, 20))).unwrap();
/// let precision = Q::from((1, 20));
///
/// let matrix_simplified = matrix.simplify(precision);
///
/// assert_eq!(Q::from((4, 5)), matrix_simplified.get_entry(0, 0).unwrap());
/// ```
///
/// ```
/// use qfall_math::rational::{MatQ, Q};
/// use qfall_math::traits::{MatrixGetEntry, MatrixSetEntry};
/// let mut matrix = MatQ::new(2, 1);
/// matrix.set_entry(0, 0, Q::from((3, 2))).unwrap();
///
/// let mat_simplified = matrix.simplify(0.5);
///
/// assert_eq!(Q::ONE, mat_simplified.get_entry(0, 0).unwrap());
/// ```
///
/// ## Simplify with reasonable precision loss
/// This example uses [`Q::INV_MAX32`], i.e. a loss of precision of at most `1 / 2^31 - 2` behind the decimal point.
/// If you require higher precision, [`Q::INV_MAX62`] is available.
/// ```
/// use qfall_math::rational::{MatQ, Q};
/// use qfall_math::traits::{MatrixGetEntry, MatrixSetEntry};
/// let mut matrix = MatQ::new(1, 1);
/// matrix.set_entry(0, 0, Q::PI).unwrap();
///
/// let mat_simplified = matrix.simplify(Q::INV_MAX32);
///
/// let entry_simplified = mat_simplified.get_entry(0, 0).unwrap();
///
/// assert_ne!(&Q::PI, &entry_simplified);
/// assert!(&entry_simplified >= &(Q::PI - Q::INV_MAX32));
/// assert!(&entry_simplified <= &(Q::PI + Q::INV_MAX32));
/// ```
pub fn simplify(&self, precision: impl Into<Q>) -> MatQ {
let precision = precision.into();
let mut out = MatQ::new(self.get_num_rows(), self.get_num_columns());
for i in 0..self.get_num_rows() {
for j in 0..self.get_num_columns() {
let entry = unsafe { self.get_entry_unchecked(i, j) };
let simplified_entry = entry.simplify(&precision);
unsafe { out.set_entry_unchecked(i, j, simplified_entry) };
}
}
out
}
/// Performs the randomized rounding algorithm entrywise
/// by sampling from a discrete Gaussian over the integers shifted
/// by `self` with gaussian parameter `r`.
///
/// Parameters:
/// - `r`: specifies the Gaussian parameter, which is proportional
/// to the standard deviation `sigma * sqrt(2 * pi) = r`
///
/// Returns the rounded matrix as a [`MatZ`] or an error if `r < 0`.
///
/// # Examples
/// ```
/// use qfall_math::rational::MatQ;
/// use std::str::FromStr;
///
/// let value = MatQ::from_str("[[5/2, 1]]").unwrap();
/// let rounded = value.randomized_rounding(3).unwrap();
/// ```
///
/// # Errors and Failures
/// - Returns a [`MathError`] of type [`InvalidIntegerInput`](MathError::InvalidIntegerInput)
/// if `r < 0`.
///
/// This function implements randomized rounding according to:
/// - \[1\] Peikert, C. (2010, August).
/// An efficient and parallel Gaussian sampler for lattices.
/// In: Annual Cryptology Conference (pp. 80-97).
/// <https://link.springer.com/chapter/10.1007/978-3-642-14623-7_5>
pub fn randomized_rounding(&self, r: impl Into<Q>) -> Result<MatZ, MathError> {
let mut out = MatZ::new(self.get_num_rows(), self.get_num_columns());
let r = r.into();
for i in 0..out.get_num_rows() {
for j in 0..out.get_num_columns() {
let entry = unsafe { self.get_entry_unchecked(i, j) }.randomized_rounding(&r)?;
unsafe { out.set_entry_unchecked(i, j, entry) };
}
}
Ok(out)
}
}
#[cfg(test)]
mod test_floor {
use crate::{integer::MatZ, rational::MatQ};
use std::str::FromStr;
// Ensure that positive rationals are rounded correctly
#[test]
fn positive() {
let value = MatQ::from_str(&format!("[[1/{}, {}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[0, {}]]", (i64::MAX - 1) / 2)).unwrap();
assert_eq!(cmp, value.floor());
}
// Ensure that negative rationals are rounded correctly
#[test]
fn negative() {
let value = MatQ::from_str(&format!("[[-1/{}, -{}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[-1, {}]]", (-i64::MAX - 1) / 2)).unwrap();
assert_eq!(cmp, value.floor());
}
}
#[cfg(test)]
mod test_ceil {
use crate::{integer::MatZ, rational::MatQ};
use std::str::FromStr;
// Ensure that positive rationals are rounded correctly
#[test]
fn positive() {
let value = MatQ::from_str(&format!("[[1/{}, {}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[1, {}]]", (i64::MAX - 1) / 2 + 1)).unwrap();
assert_eq!(cmp, value.ceil());
}
// Ensure that negative rationals are rounded correctly
#[test]
fn negative() {
let value = MatQ::from_str(&format!("[[-1/{}, -{}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[0, {}]]", (-i64::MAX - 1) / 2 + 1)).unwrap();
assert_eq!(cmp, value.ceil());
}
}
#[cfg(test)]
mod test_round {
use crate::{integer::MatZ, rational::MatQ};
use std::str::FromStr;
// Ensure that positive rationals are rounded correctly
#[test]
fn positive() {
let value = MatQ::from_str(&format!("[[1/{}, {}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[0, {}]]", (i64::MAX - 1) / 2 + 1)).unwrap();
assert_eq!(cmp, value.round());
}
// Ensure that negative rationals are rounded correctly
#[test]
fn negative() {
let value = MatQ::from_str(&format!("[[-1/{}, -{}/2]]", u64::MAX, i64::MAX)).unwrap();
let cmp = MatZ::from_str(&format!("[[0, {}]]", (-i64::MAX - 1) / 2 + 1)).unwrap();
assert_eq!(cmp, value.round());
}
}
#[cfg(test)]
mod test_randomized_rounding {
use crate::rational::MatQ;
use std::str::FromStr;
/// Ensure that a `r < 0` throws an error
#[test]
fn negative_r() {
let value = MatQ::from_str("[[5/2, 1]]").unwrap();
assert!(value.randomized_rounding(-1).is_err());
}
}