1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
// Copyright © 2023 Marcel Luca Schmidt
//
// This file is part of qFALL-math.
//
// qFALL-math is free software: you can redistribute it and/or modify it under
// the terms of the Mozilla Public License Version 2.0 as published by the
// Mozilla Foundation. See <https://mozilla.org/en-US/MPL/2.0/>.
//! Implementations to create a [`MatQ`] value from other types.
//!
//! The explicit functions contain the documentation.
use super::MatQ;
use crate::{
error::MathError,
integer::MatZ,
macros::for_others::implement_for_owned,
rational::Q,
traits::{MatrixDimensions, MatrixSetEntry},
utils::{dimensions::find_matrix_dimensions, parse::parse_matrix_string},
};
use flint_sys::fmpq_mat::fmpq_mat_set_fmpz_mat;
use std::str::FromStr;
impl FromStr for MatQ {
type Err = MathError;
/// Creates a [`MatQ`] matrix with entries in [`Q`] from a [`String`].
///
/// Parameters:
/// - `string`: the matrix of form: `"[[1/2, 2/3, 3/4],[4/5, 5/6, 6/7]"`
/// for a 2x3 matrix with entries 1/2, 2/3, 3/4 in the first row
/// and 4/5, 5/6, 6/7 in the second row.
///
/// Returns a [`MatQ`] or an error if the matrix is not formatted in a suitable way,
/// the number of rows or columns is too large (must fit into [`i64`]),
/// the number of entries in rows is unequal or an entry is not formatted correctly.
///
/// # Examples
/// ```
/// use qfall_math::rational::MatQ;
/// use std::str::FromStr;
///
/// let matrix = MatQ::from_str("[[1/2, 2/3, 3/4],[4/5, 5/6, 6/7]]").unwrap();
/// ```
///
/// ```
/// use qfall_math::rational::MatQ;
/// use std::str::FromStr;
///
/// let str_1 = "[[1/2, 2/3, 3/4],[4/5, 5/6, 6/7]]";
/// let matrix = MatQ::from_str(str_1).unwrap();
/// ```
///
/// ```
/// use qfall_math::rational::MatQ;
/// use std::str::FromStr;
///
/// let string = String::from("[[1/2, 2/3, 3/4],[4/5, 5/6, 6/7]]");
/// let matrix = MatQ::from_str(&string).unwrap();
/// ```
///
/// # Errors and Failures
/// - Returns a [`MathError`] of type [`StringConversionError`](MathError::StringConversionError)
/// - if the matrix is not formatted in a suitable way,
/// - if the number of rows or columns is too large (must fit into i64),
/// - if the number of entries in rows is unequal, or
/// - if an entry is not formatted correctly.
/// For further information see [`Q::from_str`].
///
/// # Panics ...
/// - if the provided number of rows and columns are not suited to create a matrix.
/// For further information see [`MatQ::new`].
fn from_str(string: &str) -> Result<Self, MathError> {
let string_matrix = parse_matrix_string(string)?;
let (num_rows, num_cols) = find_matrix_dimensions(&string_matrix)?;
let mut matrix = MatQ::new(num_rows, num_cols);
// fill entries of matrix according to entries in string_matrix
for (row_num, row) in string_matrix.iter().enumerate() {
for (col_num, entry) in row.iter().enumerate() {
let q_entry = Q::from_str(entry)?;
matrix.set_entry(row_num, col_num, q_entry)?;
}
}
Ok(matrix)
}
}
impl From<&MatZ> for MatQ {
/// Creates a [`MatQ`] from a [`MatZ`].
///
/// Parameters:
/// - `matrix`: the matrix from which the entries are taken
///
/// Returns a new [`MatQ`] matrix with entries from the [`MatZ`] instance.
///
/// # Examples
/// ```
/// use qfall_math::integer::MatZ;
/// use qfall_math::rational::MatQ;
/// use std::str::FromStr;
///
/// let m = MatZ::from_str("[[1, 2],[3, -1]]").unwrap();
///
/// let a = MatQ::from(&m);
/// ```
fn from(matrix: &MatZ) -> Self {
let mut out = MatQ::new(matrix.get_num_rows(), matrix.get_num_columns());
unsafe { fmpq_mat_set_fmpz_mat(&mut out.matrix, &matrix.matrix) };
out
}
}
implement_for_owned!(MatZ, MatQ, From);
impl From<&MatQ> for MatQ {
/// Alias for [`MatQ::clone`].
fn from(value: &MatQ) -> Self {
value.clone()
}
}
#[cfg(test)]
mod test_from_mat_zq {
use crate::{
integer::MatZ,
rational::{MatQ, Q},
traits::{MatrixDimensions, MatrixGetEntry, MatrixSetEntry},
};
use std::str::FromStr;
/// Test if the dimensions are taken over correctly
#[test]
fn dimensions() {
let matz = MatZ::new(15, 17);
let matq_1 = MatQ::from(&matz);
assert_eq!(15, matq_1.get_num_rows());
assert_eq!(17, matq_1.get_num_columns());
}
/// Test if entries are taken over correctly
#[test]
fn entries_taken_over_correctly() {
let mut matz = MatZ::new(2, 2);
matz.set_entry(0, 0, u64::MAX - 58).unwrap();
matz.set_entry(0, 1, i64::MIN).unwrap();
let matq_1 = MatQ::from(&matz);
assert_eq!(Q::from(i64::MIN), matq_1.get_entry(0, 1).unwrap());
assert_eq!(Q::from(u64::MAX - 58), matq_1.get_entry(0, 0).unwrap());
}
/// Ensure that the conversion works for owned values
#[test]
fn availability() {
let m = MatZ::from_str("[[1, 2],[3, -1]]").unwrap();
let _ = MatQ::from(m);
}
}
#[cfg(test)]
mod test_from_str {
use crate::{
integer::Z,
rational::{MatQ, Q},
traits::MatrixGetEntry,
};
use std::str::FromStr;
/// Ensure that initialization works.
#[test]
fn init_works() {
let matrix_str_1 = "[[1/2, 2/3, 3/4],[4/5, 5/6, 6/7]]";
assert_eq!(
Q::from((1, 2)),
MatQ::from_str(matrix_str_1)
.unwrap()
.get_entry(0, 0)
.unwrap()
);
}
/// Ensure that initialization works with integers.
#[test]
fn init_integer_works() {
let matrix_str_1 = "[[1, 2, 3],[3, 4, 5]]";
assert_eq!(
Z::ONE,
Z {
value: MatQ::from_str(matrix_str_1)
.unwrap()
.get_entry(0, 0)
.unwrap()
.value
.num
}
);
assert_eq!(
Z::ONE,
Z {
value: MatQ::from_str(matrix_str_1)
.unwrap()
.get_entry(0, 0)
.unwrap()
.value
.den
}
);
}
/// Ensure that initialization with positive numerators and denominators
/// that are larger than [`i64`] works.
#[test]
fn init_works_large_numbers() {
let matrix_string = format!("[[{}/1, 1/{}, 3],[3, 4, 5]]", u64::MAX, u64::MAX);
assert_eq!(
Z::from_str(&format!("{}", u64::MAX)).unwrap(),
Z {
value: MatQ::from_str(&matrix_string)
.unwrap()
.get_entry(0, 0)
.unwrap()
.value
.num
}
);
assert_eq!(
Z::from_str(&format!("{}", u64::MAX)).unwrap(),
Z {
value: MatQ::from_str(&matrix_string)
.unwrap()
.get_entry(0, 1)
.unwrap()
.value
.den
}
);
}
/// Ensure that initialization with negative large numerators and denominators
/// that are larger than [`i64`] works.
#[test]
fn init_works_small_numbers() {
let matrix_string = format!("[[-{}/1, 1/-{}, 3],[3, 4, 5]]", u64::MAX, u64::MAX);
assert_eq!(
Q::from_str(&format!("-{}", u64::MAX)).unwrap(),
MatQ::from_str(&matrix_string)
.unwrap()
.get_entry(0, 0)
.unwrap()
);
assert_eq!(
Q::from_str(&format!("1/-{}", u64::MAX)).unwrap(),
MatQ::from_str(&matrix_string)
.unwrap()
.get_entry(0, 1)
.unwrap()
);
}
/// Ensure that entries can have leading and trailing whitespaces.
#[test]
fn whitespaces_in_entries_works() {
let matrix_str_1 = "[[ 1/2, 2/3 , 3/4 ],[3/4 , 4/5, 5/6 ]]";
assert_eq!(
Q::from((1, 2)),
MatQ::from_str(matrix_str_1)
.unwrap()
.get_entry(0, 0)
.unwrap()
);
}
/// Ensure that a wrong format causes an error.
#[test]
fn wrong_format_error() {
let matrix_str_1 = "[1/2, 2, 3],[3, 4/7, 5]]";
let matrix_str_2 = "[[1, 2/9, 3][3, 4, 5/5]]";
let matrix_str_3 = "[[1, 2, 3/2], 3, 4, 5]";
let matrix_str_4 = "[1, 2, 3, 4/5, 5]";
let matrix_str_5 = "[ [1, 2/8, 3],[3, 4, 5]]";
let matrix_str_6 = "[[1, 2, 3],[3, 4/9, 5]8]";
let matrix_str_7 = "";
let matrix_str_8 = "[]";
let matrix_str_9 = "[[]]";
assert!(MatQ::from_str(matrix_str_1).is_err());
assert!(MatQ::from_str(matrix_str_2).is_err());
assert!(MatQ::from_str(matrix_str_3).is_err());
assert!(MatQ::from_str(matrix_str_4).is_err());
assert!(MatQ::from_str(matrix_str_5).is_err());
assert!(MatQ::from_str(matrix_str_6).is_err());
assert!(MatQ::from_str(matrix_str_7).is_err());
assert!(MatQ::from_str(matrix_str_8).is_err());
assert!(MatQ::from_str(matrix_str_9).is_err());
}
}