use crate::{
ChromaLocation, KernelMatrix, PixelSink,
resample::{AreaResampler, ResampleError},
sinker::{AlphaMode, MixedSinker, MixedSinkerError},
source::{Yuv420p, Yuva420p, Yuva420pRow, Yuva444p, yuv420p_to, yuva420p_to, yuva444p_to},
};
use mediaframe::frame::{Yuv420pFrame, Yuva420pFrame, Yuva444pFrame};
const M: KernelMatrix = KernelMatrix::Bt601;
const FR: bool = true;
fn rdhu(a: u64, d: u64) -> u64 {
let q = a / d;
let r = a % d;
q + u64::from(r >= d - d / 2)
}
fn area_weights(src: usize, out: usize) -> Vec<(usize, Vec<u64>)> {
let (src64, out64) = (src as u64, out as u64);
(0..out)
.map(|o| {
let lo = o as u64 * src64;
let hi = lo + src64;
let start = (lo / out64) as usize;
let mut w = Vec::new();
let mut i = start as u64;
loop {
let clo = i * out64;
if clo >= hi {
break;
}
let chi = clo + out64;
let ov = chi.min(hi) - clo.max(lo);
if ov == 0 {
break;
}
w.push(ov);
if chi >= hi {
break;
}
i += 1;
}
(start, w)
})
.collect()
}
fn bin_cosited(plane: &[u8], sw: usize, sh: usize, ow: usize, oh: usize) -> Vec<u8> {
let hw = area_weights(sw, ow);
let vw = area_weights(sh, oh);
let denom = (sw * sh) as u64;
let mut out = vec![0u8; ow * oh];
for (oy, (vs, vwin)) in vw.iter().enumerate() {
for (ox, (hs, hwin)) in hw.iter().enumerate() {
let mut s = 0u64;
for (dy, &vwt) in vwin.iter().enumerate() {
let mut hsum = 0u64;
for (dx, &hwt) in hwin.iter().enumerate() {
hsum += hwt * u64::from(plane[(vs + dy) * sw + hs + dx]);
}
s += vwt * hsum;
}
out[oy * ow + ox] = rdhu(s, denom) as u8;
}
}
out
}
fn bin_chroma_centered(c: &[u8], cw: usize, ch: usize, ow: usize, oh: usize) -> Vec<u8> {
let full = 2 * cw;
let mut r4 = vec![0u32; full * ch];
for r in 0..ch {
let row = &c[r * cw..r * cw + cw];
for j in 0..cw {
let l = u32::from(row[j.saturating_sub(1)]);
let m = u32::from(row[j]);
let rt = u32::from(row[if j + 1 < cw { j + 1 } else { j }]);
r4[r * full + 2 * j] = l + 3 * m;
r4[r * full + 2 * j + 1] = 3 * m + rt;
}
}
let hw = area_weights(full, ow);
let vw = area_weights(ch, oh);
let denom = (4 * full * ch) as u64;
let mut out = vec![0u8; ow * oh];
for (oy, (vs, vwin)) in vw.iter().enumerate() {
for (ox, (hs, hwin)) in hw.iter().enumerate() {
let mut s = 0u64;
for (dy, &vwt) in vwin.iter().enumerate() {
let mut hsum = 0u64;
for (dx, &hwt) in hwin.iter().enumerate() {
hsum += hwt * u64::from(r4[(vs + dy) * full + hs + dx]);
}
s += vwt * hsum;
}
out[oy * ow + ox] = rdhu(s, denom) as u8;
}
}
out
}
fn ramp(sw: usize, sh: usize) -> (Vec<u8>, Vec<u8>, Vec<u8>, Vec<u8>) {
let cw = sw / 2;
let ch = sh / 2;
let mut y = vec![0u8; sw * sh];
let mut u = vec![0u8; cw * ch];
let mut v = vec![0u8; cw * ch];
let mut a = vec![0u8; sw * sh];
for (i, p) in y.iter_mut().enumerate() {
*p = 40 + ((i as u32 * 3) % 160) as u8;
}
for r in 0..ch {
for c in 0..cw {
u[r * cw + c] = (30 + c * 44 + r * 4).min(240) as u8;
v[r * cw + c] = (230u32.saturating_sub((c * 44 + r * 4) as u32)).max(16) as u8;
}
}
for (i, p) in a.iter_mut().enumerate() {
*p = 20 + ((i as u32 * 11) % 220) as u8;
}
(y, u, v, a)
}
fn flat_chroma(sw: usize, sh: usize) -> (Vec<u8>, Vec<u8>, Vec<u8>, Vec<u8>) {
let cw = sw / 2;
let ch = sh / 2;
let mut y = vec![0u8; sw * sh];
let mut a = vec![0u8; sw * sh];
for (i, p) in y.iter_mut().enumerate() {
*p = 40 + ((i as u32 * 7) % 170) as u8;
}
for (i, p) in a.iter_mut().enumerate() {
*p = 30 + ((i as u32 * 13) % 200) as u8;
}
(y, vec![110u8; cw * ch], vec![140u8; cw * ch], a)
}
type YuvaOuts = (
Vec<u8>,
Vec<u8>,
(Vec<u8>, Vec<u8>, Vec<u8>),
Vec<u8>,
Vec<u16>,
);
type YuvOuts = (Vec<u8>, (Vec<u8>, Vec<u8>, Vec<u8>), Vec<u8>, Vec<u16>);
#[allow(clippy::too_many_arguments)]
fn run(
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
sw: usize,
sh: usize,
ow: usize,
oh: usize,
loc: ChromaLocation,
native: bool,
simd: bool,
) -> YuvaOuts {
let cw = sw / 2;
let mut rgb = vec![0u8; ow * oh * 3];
let mut rgba = vec![0u8; ow * oh * 4];
let (mut hh, mut ss, mut vv) = (vec![0u8; ow * oh], vec![0u8; ow * oh], vec![0u8; ow * oh]);
let mut luma = vec![0u8; ow * oh];
let mut luma_u16 = vec![0u16; ow * oh];
{
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(sw, sh, AreaResampler::to(ow, oh))
.unwrap()
.with_native(native)
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(loc.clone())
.with_simd(simd)
.with_rgb(&mut rgb)
.unwrap()
.with_rgba(&mut rgba)
.unwrap()
.with_hsv(&mut hh, &mut ss, &mut vv)
.unwrap()
.with_luma(&mut luma)
.unwrap()
.with_luma_u16(&mut luma_u16)
.unwrap();
let f = Yuva420pFrame::try_new(
y, u, v, a, sw as u32, sh as u32, sw as u32, cw as u32, cw as u32, sw as u32,
)
.unwrap();
yuva420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
(rgb, rgba, (hh, ss, vv), luma, luma_u16)
}
#[allow(clippy::too_many_arguments)]
fn run_yuv420p(
y: &[u8],
u: &[u8],
v: &[u8],
sw: usize,
sh: usize,
ow: usize,
oh: usize,
loc: ChromaLocation,
native: bool,
simd: bool,
) -> YuvOuts {
let cw = sw / 2;
let mut rgb = vec![0u8; ow * oh * 3];
let (mut hh, mut ss, mut vv) = (vec![0u8; ow * oh], vec![0u8; ow * oh], vec![0u8; ow * oh]);
let mut luma = vec![0u8; ow * oh];
let mut luma_u16 = vec![0u16; ow * oh];
{
let mut sink =
MixedSinker::<Yuv420p, AreaResampler>::with_resampler(sw, sh, AreaResampler::to(ow, oh))
.unwrap()
.with_native(native)
.with_chroma_location(loc.clone())
.with_simd(simd)
.with_rgb(&mut rgb)
.unwrap()
.with_hsv(&mut hh, &mut ss, &mut vv)
.unwrap()
.with_luma(&mut luma)
.unwrap()
.with_luma_u16(&mut luma_u16)
.unwrap();
let f = Yuv420pFrame::new(
y, u, v, sw as u32, sh as u32, sw as u32, cw as u32, cw as u32,
);
yuv420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
(rgb, (hh, ss, vv), luma, luma_u16)
}
#[allow(clippy::too_many_arguments)]
fn native_rgba_oracle(
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
sw: usize,
sh: usize,
ow: usize,
oh: usize,
simd: bool,
) -> Vec<u8> {
let cw = sw / 2;
let ch = sh / 2;
let yb = bin_cosited(y, sw, sh, ow, oh);
let ub = bin_chroma_centered(u, cw, ch, ow, oh);
let vb = bin_chroma_centered(v, cw, ch, ow, oh);
let ab = bin_cosited(a, sw, sh, ow, oh);
let mut rgba = vec![0u8; ow * oh * 4];
{
let mut sink = MixedSinker::<Yuva444p>::new(ow, oh)
.with_alpha_mode(AlphaMode::Straight)
.with_simd(simd)
.with_rgba(&mut rgba)
.unwrap();
let f = Yuva444pFrame::try_new(
&yb, &ub, &vb, &ab, ow as u32, oh as u32, ow as u32, ow as u32, ow as u32, ow as u32,
)
.unwrap();
yuva444p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
rgba
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn cosited_group_is_byte_identical_across_tiers() {
let (y, u, v, a) = ramp(8, 8);
for native in [true, false] {
let base = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Unspecified,
native,
true,
);
for loc in [
ChromaLocation::Left,
ChromaLocation::other("unassigned-7"),
] {
let got = run(&y, &u, &v, &a, 8, 8, 4, 4, loc.clone(), native, true);
assert_eq!(got.0, base.0, "rgb {loc:?} native={native}");
assert_eq!(got.1, base.1, "rgba {loc:?} native={native}");
assert_eq!(got.2, base.2, "hsv {loc:?} native={native}");
assert_eq!(got.3, base.3, "luma {loc:?} native={native}");
assert_eq!(got.4, base.4, "luma_u16 {loc:?} native={native}");
}
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_chroma_matches_yuv420p_centered_across_tiers() {
for (sw, sh, ow, oh) in [(8, 8, 4, 4), (8, 8, 5, 3), (12, 8, 4, 4), (16, 8, 6, 5)] {
let (y, u, v, a) = ramp(sw, sh);
for native in [true, false] {
for loc in [
ChromaLocation::Center,
ChromaLocation::Bottom,
ChromaLocation::BottomLeft,
ChromaLocation::Top,
ChromaLocation::TopLeft,
] {
let ya = run(&y, &u, &v, &a, sw, sh, ow, oh, loc.clone(), native, true);
let yv = run_yuv420p(&y, &u, &v, sw, sh, ow, oh, loc.clone(), native, true);
assert_eq!(
ya.0, yv.0,
"rgb {loc:?} native={native} {sw}x{sh}->{ow}x{oh}"
);
assert_eq!(
ya.2, yv.1,
"hsv {loc:?} native={native} {sw}x{sh}->{ow}x{oh}"
);
assert_eq!(
ya.3, yv.2,
"luma {loc:?} native={native} {sw}x{sh}->{ow}x{oh}"
);
assert_eq!(
ya.4, yv.3,
"luma_u16 {loc:?} native={native} {sw}x{sh}->{ow}x{oh}"
);
for px in 0..ow * oh {
assert_eq!(
&ya.1[px * 4..px * 4 + 3],
&ya.0[px * 3..px * 3 + 3],
"rgba colour {loc:?} native={native} px {px}"
);
}
}
}
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_native_rgba_equals_code_domain_oracle() {
for (sw, sh, ow, oh) in [(8, 8, 4, 4), (8, 8, 5, 3), (12, 8, 4, 4), (16, 8, 6, 5)] {
let (y, u, v, a) = ramp(sw, sh);
let oracle = native_rgba_oracle(&y, &u, &v, &a, sw, sh, ow, oh, true);
let n = run(
&y,
&u,
&v,
&a,
sw,
sh,
ow,
oh,
ChromaLocation::Center,
true,
true,
);
assert_eq!(n.1, oracle, "native rgba Center {sw}x{sh}->{ow}x{oh}");
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn alpha_is_identical_between_cosited_and_centered() {
let (y, u, v, a) = ramp(8, 8);
for native in [true, false] {
let cos = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Left,
native,
true,
);
let cen = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
native,
true,
);
let cos_a: Vec<u8> = cos.1.iter().skip(3).step_by(4).copied().collect();
let cen_a: Vec<u8> = cen.1.iter().skip(3).step_by(4).copied().collect();
assert_eq!(
cen_a, cos_a,
"centered alpha must equal co-sited alpha (native={native})"
);
assert_ne!(
cen.0, cos.0,
"centered colour must differ from co-sited (native={native})"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_differs_from_cosited_on_a_chroma_ramp() {
let (y, u, v, a) = ramp(8, 8);
for native in [true, false] {
let cos = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Unspecified,
native,
true,
);
let cen = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
native,
true,
);
assert_ne!(
cen.0, cos.0,
"centered rgb must differ from co-sited (native={native})"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_equals_cosited_on_flat_chroma() {
let (y, u, v, a) = flat_chroma(8, 8);
for native in [true, false] {
let cos = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Left,
native,
true,
);
let cen = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
native,
true,
);
assert_eq!(cen.0, cos.0, "flat-chroma rgb (native={native})");
assert_eq!(cen.1, cos.1, "flat-chroma rgba (native={native})");
assert_eq!(cen.2, cos.2, "flat-chroma hsv (native={native})");
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_native_simd_matches_scalar() {
let (y, u, v, a) = ramp(8, 8);
let s = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
true,
false,
);
let d = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
true,
true,
);
assert_eq!(s.0, d.0, "rgb scalar vs simd");
assert_eq!(s.1, d.1, "rgba scalar vs simd");
assert_eq!(s.2, d.2, "hsv scalar vs simd");
assert_eq!(s.3, d.3, "luma scalar vs simd");
}
#[allow(clippy::too_many_arguments)]
fn run_reuse_native(
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
sw: usize,
sh: usize,
ow: usize,
oh: usize,
loc1: ChromaLocation,
loc2: ChromaLocation,
) -> YuvaOuts {
let cw = sw / 2;
let mut rgb = vec![0u8; ow * oh * 3];
let mut rgba = vec![0u8; ow * oh * 4];
let (mut hh, mut ss, mut vv) = (vec![0u8; ow * oh], vec![0u8; ow * oh], vec![0u8; ow * oh]);
let mut luma = vec![0u8; ow * oh];
let mut luma_u16 = vec![0u16; ow * oh];
{
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(sw, sh, AreaResampler::to(ow, oh))
.unwrap()
.with_native(true)
.with_alpha_mode(AlphaMode::Straight)
.with_rgb(&mut rgb)
.unwrap()
.with_rgba(&mut rgba)
.unwrap()
.with_hsv(&mut hh, &mut ss, &mut vv)
.unwrap()
.with_luma(&mut luma)
.unwrap()
.with_luma_u16(&mut luma_u16)
.unwrap();
let f = Yuva420pFrame::try_new(
y, u, v, a, sw as u32, sh as u32, sw as u32, cw as u32, cw as u32, sw as u32,
)
.unwrap();
sink.set_chroma_location(loc1.clone());
yuva420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
sink.set_chroma_location(loc2.clone());
yuva420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
(rgb, rgba, (hh, ss, vv), luma, luma_u16)
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn native_join_rebuilds_on_siting_change_across_frames() {
let (y, u, v, a) = ramp(8, 8);
for (p, q) in [
(ChromaLocation::Left, ChromaLocation::Center),
(ChromaLocation::Center, ChromaLocation::Left),
] {
let reused = run_reuse_native(&y, &u, &v, &a, 8, 8, 4, 4, p.clone(), q.clone());
let fresh = run(&y, &u, &v, &a, 8, 8, 4, 4, q.clone(), true, true);
assert_eq!(reused.0, fresh.0, "native rgb {p:?}->{q:?} stale carryover");
assert_eq!(reused.1, fresh.1, "native rgba {p:?}->{q:?}");
assert_eq!(reused.2, fresh.2, "native hsv {p:?}->{q:?}");
let stale = run(&y, &u, &v, &a, 8, 8, 4, 4, p.clone(), true, true);
assert_ne!(fresh.0, stale.0, "sitings {p:?} vs {q:?} must differ");
}
}
fn in_sequence_flip_row1<R>(
mut sink: MixedSinker<'_, Yuva420p, R>,
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
loc1: ChromaLocation,
loc2: ChromaLocation,
) -> Result<(), MixedSinkerError> {
let cw = 4usize;
sink.set_chroma_location(loc1.clone());
PixelSink::begin_frame(&mut sink, 8, 8).unwrap();
let row0 = Yuva420pRow::for_tests(&y[0..8], &u[0..cw], &v[0..cw], &a[0..8], 0, M, FR);
PixelSink::process(&mut sink, row0).unwrap();
sink.set_chroma_location(loc2.clone());
let row1 = Yuva420pRow::for_tests(&y[8..16], &u[0..cw], &v[0..cw], &a[8..16], 1, M, FR);
PixelSink::process(&mut sink, row1)
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn in_sequence_mid_frame_phase_change_rejected_across_tiers() {
let (y, u, v, a) = ramp(8, 8);
for (loc1, loc2) in [
(ChromaLocation::Center, ChromaLocation::Left),
(ChromaLocation::Left, ChromaLocation::Center),
(ChromaLocation::Center, ChromaLocation::Bottom),
(ChromaLocation::Bottom, ChromaLocation::Center),
(ChromaLocation::Left, ChromaLocation::BottomLeft),
(ChromaLocation::BottomLeft, ChromaLocation::Left),
(ChromaLocation::BottomLeft, ChromaLocation::Bottom),
(ChromaLocation::Bottom, ChromaLocation::BottomLeft),
] {
let mut rgb = vec![0u8; 4 * 4 * 3];
let sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(true)
.with_rgb(&mut rgb)
.unwrap();
let err = in_sequence_flip_row1(sink, &y, &u, &v, &a, loc1.clone(), loc2.clone()).unwrap_err();
assert!(
matches!(err, MixedSinkerError::ChromaSitingChanged(_)),
"native {loc1:?}->{loc2:?}: want ChromaSitingChanged, got {err:?}"
);
let mut rgb = vec![0u8; 4 * 4 * 3];
let sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_rgb(&mut rgb)
.unwrap();
let err = in_sequence_flip_row1(sink, &y, &u, &v, &a, loc1.clone(), loc2.clone()).unwrap_err();
assert!(
matches!(err, MixedSinkerError::ChromaSitingChanged(_)),
"encoded {loc1:?}->{loc2:?}: want ChromaSitingChanged, got {err:?}"
);
let (mut hh, mut ss, mut vv) = (vec![0u8; 4 * 4], vec![0u8; 4 * 4], vec![0u8; 4 * 4]);
let sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_hsv(&mut hh, &mut ss, &mut vv)
.unwrap();
let err = in_sequence_flip_row1(sink, &y, &u, &v, &a, loc1.clone(), loc2.clone()).unwrap_err();
assert!(
matches!(err, MixedSinkerError::ChromaSitingChanged(_)),
"hsv {loc1:?}->{loc2:?}: want ChromaSitingChanged, got {err:?}"
);
let mut rgb = vec![0u8; 4 * 4 * 3];
let sink = MixedSinker::<
Yuva420p,
crate::resample::FilteredResampler<crate::resample::Triangle>,
>::with_resampler(
8,
8,
crate::resample::FilteredResampler::new(4, 4, crate::resample::Triangle),
)
.unwrap()
.with_rgb(&mut rgb)
.unwrap();
let err = in_sequence_flip_row1(sink, &y, &u, &v, &a, loc1.clone(), loc2.clone()).unwrap_err();
assert!(
matches!(err, MixedSinkerError::ChromaSitingChanged(_)),
"filter {loc1:?}->{loc2:?}: want ChromaSitingChanged, got {err:?}"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn out_of_sequence_centered_first_row_is_rejected_before_the_chroma_reserve() {
let (y, u, v, a) = ramp(8, 8);
let cw = 4usize;
let mut rgb = vec![0u8; 4 * 4 * 3];
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_chroma_location(ChromaLocation::Center)
.with_rgb(&mut rgb)
.unwrap();
PixelSink::begin_frame(&mut sink, 8, 8).unwrap();
super::super::arm_chroma_full_alloc_failure();
let bad = Yuva420pRow::for_tests(
&y[5 * 8..6 * 8],
&u[2 * cw..3 * cw],
&v[2 * cw..3 * cw],
&a[5 * 8..6 * 8],
5,
M,
FR,
);
let err = PixelSink::process(&mut sink, bad).unwrap_err();
assert!(
matches!(
err,
MixedSinkerError::Resample(ResampleError::OutOfSequenceRow(_))
),
"out-of-sequence centered first row must be OutOfSequenceRow (reserve unreached), got {err:?}"
);
assert_eq!(
sink.chroma_full.len(),
0,
"a rejected row must allocate no chroma scratch"
);
let good = Yuva420pRow::for_tests(&y[0..8], &u[0..cw], &v[0..cw], &a[0..8], 0, M, FR);
let err0 = PixelSink::process(&mut sink, good).unwrap_err();
assert!(
matches!(
err0,
MixedSinkerError::Resample(ResampleError::AllocationFailed(_))
),
"a valid centered row reaches the reserve (failpoint fires), got {err0:?}"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn luma_only_centered_area_does_not_reserve_chroma() {
let (y, u, v, a) = ramp(8, 8);
let cw = 4usize;
let mut luma = vec![0u8; 4 * 4];
{
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_chroma_location(ChromaLocation::Center)
.with_luma(&mut luma)
.unwrap();
PixelSink::begin_frame(&mut sink, 8, 8).unwrap();
super::super::arm_chroma_full_alloc_failure();
for r in 0..8 {
let cr = r / 2;
let row = Yuva420pRow::for_tests(
&y[r * 8..r * 8 + 8],
&u[cr * cw..cr * cw + cw],
&v[cr * cw..cr * cw + cw],
&a[r * 8..r * 8 + 8],
r,
M,
FR,
);
PixelSink::process(&mut sink, row).unwrap();
}
assert_eq!(
sink.chroma_full.len(),
0,
"luma-only centered resample must never reserve chroma scratch"
);
}
let mut rgb = vec![0u8; 4 * 4 * 3];
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_chroma_location(ChromaLocation::Center)
.with_rgb(&mut rgb)
.unwrap();
let f = Yuva420pFrame::try_new(&y, &u, &v, &a, 8, 8, 8, cw as u32, cw as u32, 8).unwrap();
let _ = yuva420p_to(&f, FR, sink.set_kernel_matrix(M));
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_filter_bicublin_rejected_before_the_chroma_reserve() {
use crate::resample::Bicublin;
let (y, u, v, a) = ramp(8, 8);
let cw = 4usize;
let mut rgba = vec![0u8; 4 * 4 * 4];
let mut sink = MixedSinker::<Yuva420p, Bicublin>::with_resampler(8, 8, Bicublin::to(4, 4))
.unwrap()
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(ChromaLocation::Center)
.with_rgba(&mut rgba)
.unwrap();
let f = Yuva420pFrame::try_new(&y, &u, &v, &a, 8, 8, 8, cw as u32, cw as u32, 8).unwrap();
super::super::arm_chroma_full_alloc_failure();
let err = yuva420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap_err();
assert!(
matches!(
err,
MixedSinkerError::Resample(ResampleError::UnsupportedFilter(_))
),
"a BICUBLIN filter plan must be UnsupportedFilter (reserve unreached), got {err:?}"
);
assert_eq!(
sink.chroma_full.len(),
0,
"a rejected filter plan allocates no chroma scratch"
);
let mut rgb = vec![0u8; 4 * 4 * 3];
let mut consume =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(8, 8, AreaResampler::to(4, 4))
.unwrap()
.with_native(false)
.with_chroma_location(ChromaLocation::Center)
.with_rgb(&mut rgb)
.unwrap();
let cf = Yuva420pFrame::try_new(&y, &u, &v, &a, 8, 8, 8, cw as u32, cw as u32, 8).unwrap();
let _ = yuva420p_to(&cf, FR, consume.set_kernel_matrix(M));
}
fn bin_chroma_bottom(c: &[u8], cw: usize, ch: usize, ow: usize, oh: usize) -> Vec<u8> {
let full = 2 * cw;
let sh = 2 * ch;
let mut r8 = vec![0u64; full * sh];
for r in 0..sh {
let cr = r / 2;
let prev = cr.saturating_sub(1);
let vrow: Vec<u32> = (0..cw)
.map(|j| {
if r & 1 == 0 {
u32::from(c[prev * cw + j]) + u32::from(c[cr * cw + j]) } else {
2 * u32::from(c[cr * cw + j]) }
})
.collect();
for j in 0..cw {
let l = vrow[j.saturating_sub(1)];
let m = vrow[j];
let rt = vrow[if j + 1 < cw { j + 1 } else { j }];
r8[r * full + 2 * j] = u64::from(l + 3 * m); r8[r * full + 2 * j + 1] = u64::from(3 * m + rt); }
}
let hw = area_weights(full, ow);
let vw = area_weights(sh, oh);
let denom = (8 * full * sh) as u64; let mut out = vec![0u8; ow * oh];
for (oy, (vs, vwin)) in vw.iter().enumerate() {
for (ox, (hs, hwin)) in hw.iter().enumerate() {
let mut s = 0u64;
for (dy, &vwt) in vwin.iter().enumerate() {
let mut hsum = 0u64;
for (dx, &hwt) in hwin.iter().enumerate() {
hsum += hwt * r8[(vs + dy) * full + hs + dx];
}
s += vwt * hsum;
}
out[oy * ow + ox] = rdhu(s, denom) as u8;
}
}
out
}
#[allow(clippy::too_many_arguments)]
fn bottom_native_rgba_oracle(
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
sw: usize,
sh: usize,
ow: usize,
oh: usize,
simd: bool,
) -> Vec<u8> {
let cw = sw / 2;
let ch = sh / 2;
let yb = bin_cosited(y, sw, sh, ow, oh);
let ub = bin_chroma_bottom(u, cw, ch, ow, oh);
let vb = bin_chroma_bottom(v, cw, ch, ow, oh);
let ab = bin_cosited(a, sw, sh, ow, oh);
let mut rgba = vec![0u8; ow * oh * 4];
{
let mut sink = MixedSinker::<Yuva444p>::new(ow, oh)
.with_alpha_mode(AlphaMode::Straight)
.with_simd(simd)
.with_rgba(&mut rgba)
.unwrap();
let f = Yuva444pFrame::try_new(
&yb, &ub, &vb, &ab, ow as u32, oh as u32, ow as u32, ow as u32, ow as u32, ow as u32,
)
.unwrap();
yuva444p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
rgba
}
fn vramp(sw: usize, sh: usize) -> (Vec<u8>, Vec<u8>, Vec<u8>, Vec<u8>) {
let cw = sw / 2;
let ch = sh / 2;
let y = vec![128u8; sw * sh];
let mut u = vec![0u8; cw * ch];
let mut v = vec![0u8; cw * ch];
let mut a = vec![0u8; sw * sh];
for r in 0..ch {
for c in 0..cw {
u[r * cw + c] = (20 + r * 40).min(240) as u8;
v[r * cw + c] = (220u32.saturating_sub((r * 40) as u32)).max(16) as u8;
}
}
for (i, p) in a.iter_mut().enumerate() {
*p = 25 + ((i as u32 * 9) % 210) as u8;
}
(y, u, v, a)
}
fn direct_bottom_yuva_rgba(
y: &[u8],
u: &[u8],
v: &[u8],
a: &[u8],
sw: usize,
sh: usize,
) -> Vec<u8> {
let cw = sw / 2;
let mut rgba = vec![0u8; sw * sh * 4];
{
let mut sink = MixedSinker::<Yuva420p>::new(sw, sh)
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(ChromaLocation::Bottom)
.with_rgba(&mut rgba)
.unwrap();
let f = Yuva420pFrame::try_new(
y, u, v, a, sw as u32, sh as u32, sw as u32, cw as u32, cw as u32, sw as u32,
)
.unwrap();
yuva420p_to(&f, FR, sink.set_kernel_matrix(M)).unwrap();
}
rgba
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_native_rgba_equals_code_domain_oracle() {
for (sw, sh, ow, oh) in [(8, 8, 4, 4), (8, 8, 5, 3), (12, 8, 4, 4), (16, 8, 6, 5)] {
let (y, u, v, a) = ramp(sw, sh);
let oracle = bottom_native_rgba_oracle(&y, &u, &v, &a, sw, sh, ow, oh, true);
let n = run(
&y,
&u,
&v,
&a,
sw,
sh,
ow,
oh,
ChromaLocation::Bottom,
true,
true,
);
assert_eq!(n.1, oracle, "native bottom rgba {sw}x{sh}->{ow}x{oh}");
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_native_simd_matches_scalar() {
let (y, u, v, a) = ramp(8, 8);
let s = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Bottom,
true,
false,
);
let d = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Bottom,
true,
true,
);
assert_eq!(s.0, d.0, "rgb scalar vs simd");
assert_eq!(s.1, d.1, "rgba scalar vs simd");
assert_eq!(s.2, d.2, "hsv scalar vs simd");
assert_eq!(s.3, d.3, "luma scalar vs simd");
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_differs_from_center_on_a_vertical_chroma_ramp() {
let (y, u, v, a) = vramp(8, 8);
for native in [true, false] {
let cen = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Center,
native,
true,
);
let bot = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Bottom,
native,
true,
);
assert_ne!(
bot.0, cen.0,
"bottom rgb must differ from center (native={native})"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_equals_cosited_on_flat_chroma() {
let (y, u, v, a) = flat_chroma(8, 8);
for native in [true, false] {
let cos = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Left,
native,
true,
);
let bot = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Bottom,
native,
true,
);
assert_eq!(bot.0, cos.0, "flat-chroma bottom rgb (native={native})");
assert_eq!(bot.1, cos.1, "flat-chroma bottom rgba (native={native})");
assert_eq!(bot.2, cos.2, "flat-chroma bottom hsv (native={native})");
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_alpha_is_identical_to_cosited() {
let (y, u, v, a) = vramp(8, 8);
for native in [true, false] {
let cos = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Left,
native,
true,
);
let bot = run(
&y,
&u,
&v,
&a,
8,
8,
4,
4,
ChromaLocation::Bottom,
native,
true,
);
let cos_a: Vec<u8> = cos.1.iter().skip(3).step_by(4).copied().collect();
let bot_a: Vec<u8> = bot.1.iter().skip(3).step_by(4).copied().collect();
assert_eq!(
bot_a, cos_a,
"bottom alpha must equal co-sited alpha (native={native})"
);
assert_ne!(
bot.0, cos.0,
"bottom colour must differ from co-sited (native={native})"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_identity_matches_direct_decode() {
let (y, u, v, a) = vramp(8, 8);
let res = run(
&y,
&u,
&v,
&a,
8,
8,
8,
8,
ChromaLocation::Bottom,
false,
true,
);
let direct = direct_bottom_yuva_rgba(&y, &u, &v, &a, 8, 8);
assert_eq!(
res.1, direct,
"identity encoded resample bottom rgba == direct decode"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_odd_height_final_even_row_reserve_failure_retries_with_blend() {
use super::super::MixedSinkerError;
use crate::resample::ResampleError;
let (sw, sh, ow, oh) = (8usize, 7usize, 4usize, 3usize);
let cw = sw / 2;
let ch = sh.div_ceil(2);
let y = vec![128u8; sw * sh];
let mut u = vec![0u8; cw * ch];
let mut v = vec![0u8; cw * ch];
for r in 0..ch {
for c in 0..cw {
u[r * cw + c] = (20 + r * 40).min(240) as u8;
v[r * cw + c] = (220u32.saturating_sub((r * 40) as u32)).max(16) as u8;
}
}
let mut a = vec![0u8; sw * sh];
for (i, p) in a.iter_mut().enumerate() {
*p = 25 + ((i as u32 * 9) % 210) as u8;
}
let run_frame = |arm_fail: bool, loc: ChromaLocation| -> (Vec<u8>, Vec<u8>) {
let mut rgb = vec![0u8; ow * oh * 3];
let mut rgba = vec![0u8; ow * oh * 4];
{
let mut sink =
MixedSinker::<Yuva420p, AreaResampler>::with_resampler(sw, sh, AreaResampler::to(ow, oh))
.unwrap()
.with_native(false)
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(loc.clone())
.with_rgb(&mut rgb)
.unwrap()
.with_rgba(&mut rgba)
.unwrap();
sink.begin_frame(sw as u32, sh as u32).unwrap();
let feed = |sink: &mut MixedSinker<'_, Yuva420p, AreaResampler>, r: usize| {
let yr = &y[r * sw..(r + 1) * sw];
let cr = r / 2;
let ur = &u[cr * cw..(cr + 1) * cw];
let vr = &v[cr * cw..(cr + 1) * cw];
let ar = &a[r * sw..(r + 1) * sw];
sink.process(Yuva420pRow::for_tests(yr, ur, vr, ar, r, M, FR))
};
for r in 0..sh - 1 {
feed(&mut sink, r).unwrap();
}
if arm_fail {
super::super::arm_chroma_prev_alloc_failure();
let err = feed(&mut sink, sh - 1).unwrap_err();
assert!(
matches!(
err,
MixedSinkerError::Resample(ResampleError::AllocationFailed(_))
),
"armed final-row lookback reserve must surface AllocationFailed, got {err:?}"
);
}
feed(&mut sink, sh - 1).unwrap();
}
(rgb, rgba)
};
let reference = run_frame(false, ChromaLocation::Bottom);
let retried = run_frame(true, ChromaLocation::Bottom);
assert_eq!(
retried.0, reference.0,
"the post-failure retry of the final EVEN row must blend rgb with the predecessor (not clamp)"
);
assert_eq!(
retried.1, reference.1,
"the post-failure retry rgba (colour + α) must match the clean run"
);
assert_ne!(
reference.0,
run_frame(false, ChromaLocation::Center).0,
"the bottom vertical blend must move the final even row vs co-sited Center"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn bottom_direct_luma_only_then_late_colour_attach_blends_not_clamps() {
let (y, u, v, a) = vramp(8, 8);
let (sw, sh, cw) = (8usize, 8usize, 4usize);
let feed = |sink: &mut MixedSinker<'_, Yuva420p, crate::resample::NoopResampler>, r: usize| {
let cr = r / 2;
let row = Yuva420pRow::for_tests(
&y[r * sw..r * sw + sw],
&u[cr * cw..cr * cw + cw],
&v[cr * cw..cr * cw + cw],
&a[r * sw..r * sw + sw],
r,
M,
FR,
);
PixelSink::process(sink, row)
};
let reference = direct_bottom_yuva_rgba(&y, &u, &v, &a, sw, sh);
let mut luma = vec![0u8; sw * sh];
let mut rgba = vec![0u8; sw * sh * 4];
{
let mut sink = MixedSinker::<Yuva420p>::new(sw, sh)
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(ChromaLocation::Bottom)
.with_luma(&mut luma)
.unwrap();
PixelSink::begin_frame(&mut sink, sw as u32, sh as u32).unwrap();
for r in 0..2 {
feed(&mut sink, r).unwrap();
}
sink.set_rgba(&mut rgba).unwrap();
for r in 2..sh {
feed(&mut sink, r).unwrap();
}
}
let (row2, row3) = (2 * sw * 4, 3 * sw * 4);
assert_eq!(
&rgba[row2..row3],
&reference[row2..row3],
"late-colour-attach row 2 must box-blend the luma-only-staged chroma, not clamp"
);
for c in 0..sw {
assert_eq!(
rgba[(2 * sw + c) * 4 + 3],
a[2 * sw + c],
"row 2 alpha at col {c} must equal the source alpha plane (siting never touches α)"
);
}
let mut rgba_clamp = vec![0u8; sw * sh * 4];
{
let mut sink = MixedSinker::<Yuva420p>::new(sw, sh)
.with_alpha_mode(AlphaMode::Straight)
.with_chroma_location(ChromaLocation::Bottom)
.with_rgba(&mut rgba_clamp)
.unwrap();
PixelSink::begin_frame(&mut sink, sw as u32, sh as u32).unwrap();
feed(&mut sink, 2).unwrap();
}
assert_ne!(
&rgba_clamp[row2..row3],
&reference[row2..row3],
"control: a clamped row 2 (empty lookback) must differ from the blended reference"
);
}