use super::*;
use crate::{ChromaLocation, ColorMatrix};
const W: u32 = 16;
const H: u32 = 8;
fn ramp_yuv422p() -> (Vec<u8>, Vec<u8>, Vec<u8>) {
let w = W as usize;
let h = H as usize;
let cw = w / 2;
let y = std::vec![128u8; w * h];
let mut u = std::vec![0u8; cw * h];
let mut v = std::vec![0u8; cw * h];
for r in 0..h {
for c in 0..cw {
u[r * cw + c] = (16 + c * 24 + r * 3).min(240) as u8;
v[r * cw + c] = (240 - c * 24).max(16) as u8;
}
}
(y, u, v)
}
fn ref_upsample_center_h(c_half: &[u8], width: usize) -> Vec<u8> {
let half = width / 2;
let mut out = std::vec![0u8; width];
for j in 0..half {
let l = c_half[j.saturating_sub(1)] as i32;
let m = c_half[j] as i32;
let r = c_half[if j + 1 < half { j + 1 } else { j }] as i32;
out[2 * j] = ((l + 3 * m + 2) >> 2) as u8;
out[2 * j + 1] = ((3 * m + r + 2) >> 2) as u8;
}
out
}
fn ref_full_chroma(u422: &[u8], v422: &[u8]) -> (Vec<u8>, Vec<u8>) {
let w = W as usize;
let h = H as usize;
let cw = w / 2;
let mut u444 = std::vec![0u8; w * h];
let mut v444 = std::vec![0u8; w * h];
for r in 0..h {
let urow = ref_upsample_center_h(&u422[r * cw..r * cw + cw], w);
let vrow = ref_upsample_center_h(&v422[r * cw..r * cw + cw], w);
u444[r * w..r * w + w].copy_from_slice(&urow);
v444[r * w..r * w + w].copy_from_slice(&vrow);
}
(u444, v444)
}
fn convert_rgb(loc: ChromaLocation, simd: bool) -> Vec<u8> {
let (yp, up, vp) = ramp_yuv422p();
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgb = std::vec![0u8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(loc.clone())
.with_simd(simd);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
rgb
}
#[test]
fn center_upsample_kernel_matches_hand_computed() {
let c_half = [0u8, 0, 100, 100];
let mut out = [0u8; 8];
crate::row::scalar::chroma_upsample_2to1_center_h(&c_half, &mut out, 8);
assert_eq!(out, [0, 0, 0, 25, 75, 100, 100, 100]);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn default_and_cosited_sitings_are_byte_identical() {
let baseline = convert_rgb(ChromaLocation::Unspecified, true);
for loc in [
ChromaLocation::Unspecified,
ChromaLocation::other("unassigned-99"),
ChromaLocation::Left,
ChromaLocation::TopLeft,
ChromaLocation::BottomLeft,
] {
assert_eq!(
convert_rgb(loc.clone(), true),
baseline,
"siting {loc:?} must keep the byte-identical default decode"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn default_path_does_not_allocate_chroma_scratch() {
let (yp, up, vp) = ramp_yuv422p();
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgb = std::vec![0u8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(ChromaLocation::Left);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
let chroma_len = sink.chroma_full.len();
drop(sink);
assert_eq!(
chroma_len, 0,
"co-sited path must not grow the chroma scratch"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn center_grows_chroma_scratch_to_full_width() {
let (yp, up, vp) = ramp_yuv422p();
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgb = std::vec![0u8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(ChromaLocation::Center);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
let chroma_len = sink.chroma_full.len();
drop(sink);
assert_eq!(
chroma_len,
2 * W as usize,
"centered path stages U+V at full width"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn center_rgb_matches_upsample_then_444_reference() {
let (yp, up, vp) = ramp_yuv422p();
let (u444, v444) = ref_full_chroma(&up, &vp);
let ref_src = Yuv444pFrame::new(&yp, &u444, &v444, W, H, W, W, W);
let mut rgb_ref = std::vec![0u8; (W * H * 3) as usize];
let mut ref_sink = MixedSinker::<Yuv444p>::new(W as usize, H as usize)
.with_rgb(&mut rgb_ref)
.unwrap();
yuv444p_to(
&ref_src,
false,
ref_sink.set_kernel_matrix(KernelMatrix::Bt601),
)
.unwrap();
assert_eq!(
convert_rgb(ChromaLocation::Center, true),
rgb_ref,
"centered 4:2:2 RGB must equal upsample-then-4:4:4"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn top_center_bottom_horizontally_equal() {
let center = convert_rgb(ChromaLocation::Center, true);
assert_eq!(
convert_rgb(ChromaLocation::Top, true),
center,
"Top shares Center's horizontal phase (4:2:2 has no vertical axis)"
);
assert_eq!(
convert_rgb(ChromaLocation::Bottom, true),
center,
"Bottom shares Center's horizontal phase (4:2:2 has no vertical axis)"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_phase_differs_from_default() {
assert_ne!(
convert_rgb(ChromaLocation::Center, true),
convert_rgb(ChromaLocation::Left, true),
"centered siting must shift chroma vs the co-sited default"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_path_simd_matches_scalar() {
assert_eq!(
convert_rgb(ChromaLocation::Center, true),
convert_rgb(ChromaLocation::Center, false),
"centered path must be bit-identical across the SIMD and scalar tiers"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn center_rgba_and_hsv_match_444_reference() {
let (yp, up, vp) = ramp_yuv422p();
let (u444, v444) = ref_full_chroma(&up, &vp);
{
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgba = std::vec![0u8; (W * H * 4) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgba(&mut rgba)
.unwrap()
.with_chroma_location(ChromaLocation::Center);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
let ref_src = Yuv444pFrame::new(&yp, &u444, &v444, W, H, W, W, W);
let mut rgba_ref = std::vec![0u8; (W * H * 4) as usize];
let mut ref_sink = MixedSinker::<Yuv444p>::new(W as usize, H as usize)
.with_rgba(&mut rgba_ref)
.unwrap();
yuv444p_to(
&ref_src,
false,
ref_sink.set_kernel_matrix(KernelMatrix::Bt601),
)
.unwrap();
assert_eq!(
rgba, rgba_ref,
"centered RGBA must equal upsample-then-4:4:4"
);
}
{
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let (mut h, mut s, mut v) = (
std::vec![0u8; (W * H) as usize],
std::vec![0u8; (W * H) as usize],
std::vec![0u8; (W * H) as usize],
);
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_hsv(&mut h, &mut s, &mut v)
.unwrap()
.with_chroma_location(ChromaLocation::Center);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
let ref_src = Yuv444pFrame::new(&yp, &u444, &v444, W, H, W, W, W);
let (mut hr, mut sr, mut vr) = (
std::vec![0u8; (W * H) as usize],
std::vec![0u8; (W * H) as usize],
std::vec![0u8; (W * H) as usize],
);
let mut ref_sink = MixedSinker::<Yuv444p>::new(W as usize, H as usize)
.with_hsv(&mut hr, &mut sr, &mut vr)
.unwrap();
yuv444p_to(
&ref_src,
false,
ref_sink.set_kernel_matrix(KernelMatrix::Bt601),
)
.unwrap();
assert_eq!(
(h, s, v),
(hr, sr, vr),
"centered HSV must equal upsample-then-4:4:4"
);
}
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_alloc_failure_leaves_outputs_untouched() {
use crate::resample::ResampleError;
let (yp, up, vp) = ramp_yuv422p();
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut luma = std::vec![0xABu8; (W * H) as usize];
let mut rgb = std::vec![0xCDu8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_luma(&mut luma)
.unwrap()
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(ChromaLocation::Center);
super::super::arm_chroma_full_alloc_failure();
let err = yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap_err();
drop(sink);
assert!(
matches!(
err,
MixedSinkerError::Resample(ResampleError::AllocationFailed(_))
),
"centered chroma-scratch refusal must surface as a recoverable AllocationFailed, got {err:?}"
);
assert!(
luma.iter().all(|&b| b == 0xAB),
"luma must be untouched on the centered alloc-failure path"
);
assert!(
rgb.iter().all(|&b| b == 0xCD),
"rgb must be untouched on the centered alloc-failure path"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn no_output_row_does_not_allocate_chroma_scratch() {
let (yp, up, vp) = ramp_yuv422p();
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_chroma_location(ChromaLocation::Center);
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt601)).unwrap();
let chroma_len = sink.chroma_full.len();
drop(sink);
assert_eq!(
chroma_len, 0,
"a no-output centered row must not reserve the chroma scratch"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "constructs an absurd geometry; the no-op contract is the point, not Miri"
)]
fn no_output_row_large_geometry_does_not_overflow() {
let w: usize = 4;
let idx: usize = 1 << 30;
let h: usize = idx + 1; assert!(
(idx as u64) * (w as u64) > u32::MAX as u64,
"test geometry must exceed u32::MAX to exercise the 32-bit offset overflow"
);
let y = std::vec![128u8; w];
let c = std::vec![128u8; w / 2];
let mut sink = MixedSinker::<Yuv422p>::new(w, h).with_chroma_location(ChromaLocation::Center);
let row = Yuv422pRow::for_tests(&y, &c, &c, idx, KernelMatrix::Bt601, false);
crate::PixelSink::process(&mut sink, row).unwrap();
let chroma_len = sink.chroma_full.len();
drop(sink);
assert_eq!(
chroma_len, 0,
"a no-output large-geometry row must allocate nothing"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn centered_chroma_derived_ncl_consistent_with_default() {
use crate::{ColorInfo, ColorSpec, DynamicRange, PixelFormat, Primaries, Transfer};
let (yp, up, vp) = ramp_yuv422p();
let spec = |loc: ChromaLocation| {
ColorSpec::from_info(
PixelFormat::Yuv422p,
ColorInfo::new(
Primaries::Bt2020,
Transfer::Bt709,
ColorMatrix::ChromaDerivedNcl,
DynamicRange::Limited,
loc,
),
)
};
let decode_cdn = |loc: ChromaLocation| -> Vec<u8> {
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgb = std::vec![0u8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgb(&mut rgb)
.unwrap()
.with_color_spec(&spec(loc))
.unwrap();
yuv422p_to(
&src,
false,
sink.set_kernel_matrix(KernelMatrix::ChromaDerivedNcl),
)
.unwrap();
rgb
};
let decode_bt709 = |loc: ChromaLocation| -> Vec<u8> {
let src = Yuv422pFrame::new(&yp, &up, &vp, W, H, W, W / 2, W / 2);
let mut rgb = std::vec![0u8; (W * H * 3) as usize];
let mut sink = MixedSinker::<Yuv422p>::new(W as usize, H as usize)
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(loc.clone());
yuv422p_to(&src, false, sink.set_kernel_matrix(KernelMatrix::Bt709)).unwrap();
rgb
};
assert_eq!(
decode_cdn(ChromaLocation::Center),
decode_bt709(ChromaLocation::Center),
"centered ChromaDerivedNcl must resolve via the BT.709 matrix-tag fallback"
);
assert_eq!(
decode_cdn(ChromaLocation::Left),
decode_bt709(ChromaLocation::Left),
"default ChromaDerivedNcl must resolve via the same BT.709 fallback"
);
assert_ne!(
decode_cdn(ChromaLocation::Center),
decode_cdn(ChromaLocation::Left),
"centered ChromaDerivedNcl must still shift chroma vs the co-sited default"
);
}
#[test]
#[cfg_attr(
miri,
ignore = "SIMD-dispatched row kernels use intrinsics unsupported by Miri"
)]
fn direct_path_mid_frame_siting_flip_is_rejected() {
use super::super::MixedSinkerError;
let (yp, up, vp) = ramp_yuv422p();
let w = W as usize;
let h = H as usize;
let cw = w / 2;
for (loc1, loc2) in [
(ChromaLocation::Left, ChromaLocation::Center),
(ChromaLocation::Center, ChromaLocation::Left),
] {
let want = convert_rgb(loc1.clone(), true);
let mut rgb = std::vec![0u8; w * h * 3];
let mut sink = MixedSinker::<Yuv422p>::new(w, h)
.with_rgb(&mut rgb)
.unwrap()
.with_chroma_location(loc1.clone())
.with_simd(true);
crate::PixelSink::begin_frame(&mut sink, W, H).unwrap();
let row0 = Yuv422pRow::for_tests(
&yp[0..w],
&up[0..cw],
&vp[0..cw],
0,
KernelMatrix::Bt601,
false,
);
crate::PixelSink::process(&mut sink, row0).unwrap();
let scratch_len = sink.chroma_full.len();
sink.set_chroma_location(loc2.clone());
let row1 = Yuv422pRow::for_tests(
&yp[w..2 * w],
&up[cw..2 * cw],
&vp[cw..2 * cw],
1,
KernelMatrix::Bt601,
false,
);
let err = crate::PixelSink::process(&mut sink, row1).unwrap_err();
assert!(
matches!(err, MixedSinkerError::ChromaSitingChanged(_)),
"direct path {loc1:?}->{loc2:?}: want ChromaSitingChanged, got {err:?}"
);
assert_eq!(
sink.chroma_full.len(),
scratch_len,
"{loc1:?}->{loc2:?}: a rejected flip must not grow the chroma scratch"
);
sink.set_chroma_location(loc1.clone());
for r in 1..h {
let row = Yuv422pRow::for_tests(
&yp[r * w..(r + 1) * w],
&up[r * cw..(r + 1) * cw],
&vp[r * cw..(r + 1) * cw],
r,
KernelMatrix::Bt601,
false,
);
crate::PixelSink::process(&mut sink, row).unwrap();
}
drop(sink);
assert_eq!(
rgb, want,
"{loc1:?}: retry after a rejected flip must match a clean in-order decode"
);
}
}