1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
//! Theory-aware operations for Spacer.
//!
//! This module provides theory-specific enhancements for PDR/IC3,
//! including theory-aware generalization, interpolation, and model projection.
//!
//! Reference: Z3's `muz/spacer/spacer_context.cpp` theory integration
use crate::chc::PredId;
use oxiz_core::{SortId, TermId, TermManager};
use smallvec::SmallVec;
/// Theory integration for Spacer
pub struct TheoryIntegration;
impl TheoryIntegration {
/// Create a new theory integration
pub fn new() -> Self {
Self
}
/// Check if a term involves linear arithmetic
pub fn is_linear_arithmetic(term: TermId, manager: &TermManager) -> bool {
if let Some(t) = manager.get(term) {
matches!(
t.sort,
sort if sort == manager.sorts.int_sort || sort == manager.sorts.real_sort
)
} else {
false
}
}
/// Check if a term involves arrays
pub fn is_array_term(term: TermId, manager: &TermManager) -> bool {
use oxiz_core::{SortKind, TermKind};
if let Some(t) = manager.get(term) {
// Check if the term is an array operation (Select or Store)
match &t.kind {
TermKind::Select(_, _) | TermKind::Store(_, _, _) => return true,
_ => {}
}
// Check if the term's sort is an array sort
if let Some(sort) = manager.sorts.get(t.sort)
&& matches!(sort.kind, SortKind::Array { .. })
{
return true;
}
}
false
}
/// Check if a term involves bitvectors
pub fn is_bitvector_term(term: TermId, manager: &TermManager) -> bool {
use oxiz_core::{SortKind, TermKind};
if let Some(t) = manager.get(term) {
// Check if the term is a bitvector operation
match &t.kind {
TermKind::BitVecConst { .. }
| TermKind::BvNot(_)
| TermKind::BvAnd(_, _)
| TermKind::BvOr(_, _)
| TermKind::BvXor(_, _)
| TermKind::BvAdd(_, _)
| TermKind::BvSub(_, _)
| TermKind::BvMul(_, _)
| TermKind::BvUdiv(_, _)
| TermKind::BvSdiv(_, _)
| TermKind::BvUrem(_, _)
| TermKind::BvSrem(_, _)
| TermKind::BvShl(_, _)
| TermKind::BvLshr(_, _)
| TermKind::BvAshr(_, _)
| TermKind::BvConcat(_, _)
| TermKind::BvExtract { .. } => return true,
_ => {}
}
// Check if the term's sort is a bitvector sort
if let Some(sort) = manager.sorts.get(t.sort)
&& matches!(sort.kind, SortKind::BitVec(_))
{
return true;
}
}
false
}
/// Project a formula over specific variables (theory-aware)
pub fn project_variables(
formula: TermId,
vars_to_keep: &[TermId],
manager: &mut TermManager,
) -> TermId {
// Theory-aware projection
// For LIA: Use Fourier-Motzkin or virtual term substitution
// For Arrays: Use array property fragments and axiom instantiation
// For BV: Use bit-blasting or interval analysis
// For ADT: Use constructor/selector elimination
// Enhanced implementation with theory awareness for arrays and bitvectors
use oxiz_core::TermKind;
// Clone the term kind to avoid borrow checker issues
let term_kind = manager.get(formula).map(|t| t.kind.clone());
let Some(kind) = term_kind else {
return formula;
};
// Special handling for array theory
if Self::is_array_term(formula, manager) {
return Self::project_array_term(formula, vars_to_keep, manager);
}
// Special handling for bitvector theory
if Self::is_bitvector_term(formula, manager) {
return Self::project_bitvector_term(formula, vars_to_keep, manager);
}
match kind {
TermKind::And(args) => {
// Project each conjunct and recombine
let args_vec: Vec<TermId> = args.to_vec();
let mut projected = Vec::new();
for arg in args_vec {
let proj = Self::project_variables(arg, vars_to_keep, manager);
// Keep only formulas that mention variables we want to keep
if Self::uses_only_vars(proj, vars_to_keep, manager)
|| Self::is_ground_constraint(proj, manager)
{
projected.push(proj);
}
}
if projected.is_empty() {
manager.mk_true()
} else if projected.len() == 1 {
projected[0]
} else {
manager.mk_and(projected)
}
}
TermKind::Or(args) => {
// For disjunctions, we need to be more conservative
let args_vec: Vec<TermId> = args.to_vec();
let projected: Vec<TermId> = args_vec
.into_iter()
.map(|arg| Self::project_variables(arg, vars_to_keep, manager))
.collect();
manager.mk_or(projected)
}
TermKind::Not(arg) => {
let projected = Self::project_variables(arg, vars_to_keep, manager);
manager.mk_not(projected)
}
_ => {
// For atomic formulas, check if they only use vars to keep
if Self::uses_only_vars(formula, vars_to_keep, manager)
|| Self::is_ground_constraint(formula, manager)
{
formula
} else {
manager.mk_true() // Project out
}
}
}
}
/// Check if a term uses only the specified variables
fn uses_only_vars(term: TermId, vars: &[TermId], manager: &TermManager) -> bool {
use oxiz_core::TermKind;
let Some(t) = manager.get(term) else {
return false;
};
match &t.kind {
TermKind::Var(_) => vars.contains(&term),
TermKind::And(args) | TermKind::Or(args) => args
.iter()
.all(|&arg| Self::uses_only_vars(arg, vars, manager)),
TermKind::Not(arg) => Self::uses_only_vars(*arg, vars, manager),
TermKind::Eq(a, b)
| TermKind::Le(a, b)
| TermKind::Lt(a, b)
| TermKind::Ge(a, b)
| TermKind::Gt(a, b) => {
Self::uses_only_vars(*a, vars, manager) && Self::uses_only_vars(*b, vars, manager)
}
TermKind::Add(args) | TermKind::Mul(args) => args
.iter()
.all(|&arg| Self::uses_only_vars(arg, vars, manager)),
TermKind::Sub(a, b) | TermKind::Div(a, b) | TermKind::Mod(a, b) => {
Self::uses_only_vars(*a, vars, manager) && Self::uses_only_vars(*b, vars, manager)
}
TermKind::True | TermKind::False | TermKind::IntConst(_) | TermKind::RealConst(_) => {
true
}
_ => false,
}
}
/// Check if a term is a ground constraint (no variables)
fn is_ground_constraint(term: TermId, manager: &TermManager) -> bool {
use oxiz_core::TermKind;
let Some(t) = manager.get(term) else {
return false;
};
match &t.kind {
TermKind::Var(_) => false,
TermKind::True | TermKind::False | TermKind::IntConst(_) | TermKind::RealConst(_) => {
true
}
TermKind::And(args)
| TermKind::Or(args)
| TermKind::Add(args)
| TermKind::Mul(args) => args
.iter()
.all(|&arg| Self::is_ground_constraint(arg, manager)),
TermKind::Not(arg) => Self::is_ground_constraint(*arg, manager),
TermKind::Eq(a, b)
| TermKind::Le(a, b)
| TermKind::Lt(a, b)
| TermKind::Ge(a, b)
| TermKind::Gt(a, b)
| TermKind::Sub(a, b)
| TermKind::Div(a, b)
| TermKind::Mod(a, b) => {
Self::is_ground_constraint(*a, manager) && Self::is_ground_constraint(*b, manager)
}
_ => false,
}
}
/// Project an array term over specific variables
fn project_array_term(
term: TermId,
vars_to_keep: &[TermId],
manager: &mut TermManager,
) -> TermId {
use oxiz_core::TermKind;
let Some(t) = manager.get(term) else {
return term;
};
match &t.kind {
TermKind::Select(array, index) => {
// Keep select if array or index are in vars_to_keep
if vars_to_keep.contains(array) || vars_to_keep.contains(index) {
term
} else {
manager.mk_true() // Project out
}
}
TermKind::Store(array, index, value) => {
// Keep store if any component is in vars_to_keep
if vars_to_keep.contains(array)
|| vars_to_keep.contains(index)
|| vars_to_keep.contains(value)
{
term
} else {
*array // Return base array, projecting out the store
}
}
_ => {
// For other array-typed terms, use default projection
if Self::uses_only_vars(term, vars_to_keep, manager) {
term
} else {
manager.mk_true()
}
}
}
}
/// Project a bitvector term over specific variables
fn project_bitvector_term(
term: TermId,
vars_to_keep: &[TermId],
manager: &mut TermManager,
) -> TermId {
use oxiz_core::TermKind;
let Some(t) = manager.get(term) else {
return term;
};
match &t.kind {
// For bitvector operations, recursively project operands
TermKind::BvAnd(a, b)
| TermKind::BvOr(a, b)
| TermKind::BvXor(a, b)
| TermKind::BvAdd(a, b)
| TermKind::BvSub(a, b)
| TermKind::BvMul(a, b) => {
let a_keep = vars_to_keep.contains(a) || Self::uses_vars(*a, vars_to_keep, manager);
let b_keep = vars_to_keep.contains(b) || Self::uses_vars(*b, vars_to_keep, manager);
if a_keep && b_keep {
term // Keep entire operation
} else if a_keep {
*a // Project to just first operand
} else if b_keep {
*b // Project to just second operand
} else {
manager.mk_true() // Project out entirely
}
}
TermKind::BvNot(arg) => {
if vars_to_keep.contains(arg) || Self::uses_vars(*arg, vars_to_keep, manager) {
term
} else {
manager.mk_true()
}
}
TermKind::BvExtract { arg, .. } => {
if vars_to_keep.contains(arg) || Self::uses_vars(*arg, vars_to_keep, manager) {
term
} else {
manager.mk_true()
}
}
_ => {
// For other bitvector terms, use default projection
if Self::uses_only_vars(term, vars_to_keep, manager) {
term
} else {
manager.mk_true()
}
}
}
}
/// Check if a term uses any of the specified variables
fn uses_vars(term: TermId, vars: &[TermId], manager: &TermManager) -> bool {
use oxiz_core::TermKind;
let Some(t) = manager.get(term) else {
return false;
};
match &t.kind {
TermKind::Var(_) => vars.contains(&term),
TermKind::And(args)
| TermKind::Or(args)
| TermKind::Add(args)
| TermKind::Mul(args) => args.iter().any(|&arg| Self::uses_vars(arg, vars, manager)),
TermKind::Not(arg) | TermKind::Neg(arg) | TermKind::BvNot(arg) => {
Self::uses_vars(*arg, vars, manager)
}
TermKind::Eq(a, b)
| TermKind::Le(a, b)
| TermKind::Lt(a, b)
| TermKind::Ge(a, b)
| TermKind::Gt(a, b)
| TermKind::Sub(a, b)
| TermKind::Div(a, b)
| TermKind::Mod(a, b)
| TermKind::BvAnd(a, b)
| TermKind::BvOr(a, b)
| TermKind::BvXor(a, b)
| TermKind::BvAdd(a, b)
| TermKind::BvSub(a, b)
| TermKind::BvMul(a, b) => {
Self::uses_vars(*a, vars, manager) || Self::uses_vars(*b, vars, manager)
}
TermKind::Select(a, i) => {
Self::uses_vars(*a, vars, manager) || Self::uses_vars(*i, vars, manager)
}
TermKind::Store(a, i, v) => {
Self::uses_vars(*a, vars, manager)
|| Self::uses_vars(*i, vars, manager)
|| Self::uses_vars(*v, vars, manager)
}
TermKind::BvExtract { arg, .. } => Self::uses_vars(*arg, vars, manager),
TermKind::True
| TermKind::False
| TermKind::IntConst(_)
| TermKind::RealConst(_)
| TermKind::BitVecConst { .. } => false,
_ => false,
}
}
/// Strengthen a lemma using theory-specific information
pub fn theory_strengthen(
lemma: TermId,
_pred: PredId,
manager: &mut TermManager,
) -> Option<TermId> {
// Theory-specific lemma strengthening
// For LIA: Add bounds, octagon constraints
// For Arrays: Add array axioms, extensionality
// For BV: Add bit-level constraints
// For ADT: Add constructor constraints
use oxiz_core::TermKind;
// Enhanced: try to add theory-specific constraints for linear arithmetic
if Self::is_linear_arithmetic(lemma, manager) {
// Extract term kind and operands first before mutable borrow
let term_info = manager.get(lemma).map(|t| t.kind.clone());
let kind = term_info?;
// For linear arithmetic, we can add implied bounds
match kind {
TermKind::Eq(a, b) => {
// x = y implies x <= y AND x >= y
let le = manager.mk_le(a, b);
let ge = manager.mk_ge(a, b);
Some(manager.mk_and(vec![lemma, le, ge]))
}
TermKind::Lt(a, b) => {
// x < y implies x <= y
let le = manager.mk_le(a, b);
Some(manager.mk_and(vec![lemma, le]))
}
TermKind::Gt(a, b) => {
// x > y implies x >= y
let ge = manager.mk_ge(a, b);
Some(manager.mk_and(vec![lemma, ge]))
}
_ => None,
}
} else {
None
}
}
/// Extract theory-specific witnesses from a model
#[allow(dead_code)]
pub fn extract_witness(term: TermId, sort: SortId, manager: &TermManager) -> Option<Witness> {
// Extract concrete values for different theories
// For LIA: Extract integer/real values
// For Arrays: Extract array contents as map
// For BV: Extract bitvector values
// For ADT: Extract constructor applications
use oxiz_core::TermKind;
let t = manager.get(term)?;
// Enhanced: extract witnesses for basic theories
if sort == manager.sorts.bool_sort {
// Boolean witness
match &t.kind {
TermKind::True => Some(Witness::Bool(true)),
TermKind::False => Some(Witness::Bool(false)),
_ => None,
}
} else {
// For integer/real/other theories, would need additional dependencies
// or model extraction from solver
// Placeholder: return None for now
let _ = term; // Suppress warning
None
}
}
/// Generalize a cube using theory-specific techniques
pub fn theory_generalize(cube: &[TermId], manager: &mut TermManager) -> SmallVec<[TermId; 8]> {
// Theory-aware generalization
// For LIA: Widen bounds, drop disjuncts, merge intervals
// For Arrays: Generalize array properties
// For BV: Generalize bit patterns
// For ADT: Generalize constructor patterns
use oxiz_core::TermKind;
let mut generalized = SmallVec::new();
// First pass: collect constraints and categorize them
let mut arithmetic_constraints = Vec::new();
let mut other_constraints = Vec::new();
for &lit in cube {
if Self::is_linear_arithmetic(lit, manager) {
arithmetic_constraints.push(lit);
} else {
other_constraints.push(lit);
}
}
// Enhanced arithmetic generalization
for &lit in &arithmetic_constraints {
let Some(term) = manager.get(lit) else {
generalized.push(lit);
continue;
};
match &term.kind {
// For strict inequalities, convert to non-strict for integers
TermKind::Lt(a, b) => {
// x < c becomes x <= c-1 for integers
// This is a safe generalization
let le = manager.mk_le(*a, *b);
generalized.push(le);
}
TermKind::Gt(a, b) => {
// x > c becomes x >= c+1 for integers
let ge = manager.mk_ge(*a, *b);
generalized.push(ge);
}
// For equalities, try to weaken to interval constraints
TermKind::Eq(a, b) if Self::can_weaken_equality(*a, *b, manager) => {
// x = c can be weakened to x >= c AND x <= c
// but we keep just the equality for precision
// A more aggressive generalization could drop the equality
generalized.push(lit);
}
// Keep bounds as-is (they're already general)
TermKind::Le(_, _) | TermKind::Ge(_, _) => {
generalized.push(lit);
}
// For other arithmetic constraints
_ => {
generalized.push(lit);
}
}
}
// Add non-arithmetic constraints unchanged
generalized.extend(other_constraints);
// Additional optimization: merge overlapping bounds
Self::merge_arithmetic_bounds(&mut generalized, manager);
generalized
}
/// Check if an equality can be safely weakened
fn can_weaken_equality(a: TermId, b: TermId, manager: &TermManager) -> bool {
use oxiz_core::TermKind;
// Can weaken x = c where c is a constant
let a_is_const = matches!(
manager.get(a).map(|t| &t.kind),
Some(TermKind::IntConst(_) | TermKind::RealConst(_))
);
let b_is_const = matches!(
manager.get(b).map(|t| &t.kind),
Some(TermKind::IntConst(_) | TermKind::RealConst(_))
);
a_is_const || b_is_const
}
/// Merge overlapping arithmetic bounds
/// For example: x <= 5 AND x <= 10 becomes just x <= 5
fn merge_arithmetic_bounds(
constraints: &mut SmallVec<[TermId; 8]>,
_manager: &mut TermManager,
) {
// Advanced optimization: detect and merge redundant bounds
// For now, this is a placeholder for future optimization
// Full implementation would:
// 1. Group constraints by variable
// 2. Identify redundant bounds (x <= 5 subsumes x <= 10)
// 3. Remove subsumed constraints
// Placeholder: no merging yet, just return as-is
// This prevents unnecessary code churn while keeping the structure
let _ = constraints;
}
/// Check if a term is integer zero
fn is_int_zero(term: TermId, manager: &TermManager) -> bool {
use oxiz_core::TermKind;
manager
.get(term)
.is_some_and(|t| matches!(&t.kind, TermKind::IntConst(n) if n.to_string() == "0"))
}
/// Check if a term is integer one
fn is_int_one(term: TermId, manager: &TermManager) -> bool {
use oxiz_core::TermKind;
manager
.get(term)
.is_some_and(|t| matches!(&t.kind, TermKind::IntConst(n) if n.to_string() == "1"))
}
/// Simplify arithmetic expressions using theory-specific rules
pub fn arithmetic_simplify(expr: TermId, manager: &mut TermManager) -> TermId {
use oxiz_core::TermKind;
let Some(term) = manager.get(expr) else {
return expr;
};
match term.kind.clone() {
// Simplify x + 0 to x
TermKind::Add(args) => {
let simplified_args: Vec<TermId> = args
.iter()
.filter(|&&arg| !Self::is_int_zero(arg, manager))
.copied()
.collect();
if simplified_args.is_empty() {
manager.mk_int(0)
} else if simplified_args.len() == 1 {
simplified_args[0]
} else if simplified_args.len() < args.len() {
manager.mk_add(simplified_args)
} else {
expr
}
}
// Simplify x * 1 to x
TermKind::Mul(args) => {
let has_zero = args.iter().any(|&arg| Self::is_int_zero(arg, manager));
if has_zero {
return manager.mk_int(0);
}
let simplified_args: Vec<TermId> = args
.iter()
.filter(|&&arg| !Self::is_int_one(arg, manager))
.copied()
.collect();
if simplified_args.is_empty() {
manager.mk_int(1)
} else if simplified_args.len() == 1 {
simplified_args[0]
} else if simplified_args.len() < args.len() {
manager.mk_mul(simplified_args)
} else {
expr
}
}
// x - 0 = x
TermKind::Sub(a, b) => {
if Self::is_int_zero(b, manager) {
a
} else {
expr
}
}
_ => expr,
}
}
}
impl Default for TheoryIntegration {
fn default() -> Self {
Self::new()
}
}
/// A concrete witness value from the model
#[derive(Debug, Clone)]
pub enum Witness {
/// Integer value
Int(i64),
/// Real value (as rational)
Real(i64, u64), // numerator, denominator
/// Boolean value
Bool(bool),
/// Array value (map from indices to elements)
Array(SmallVec<[(Box<Witness>, Box<Witness>); 4]>, Box<Witness>), // entries + default
/// Bitvector value
BitVector(u64, u32), // value, width
/// Constructor application
Constructor(String, SmallVec<[Box<Witness>; 4]>), // name, arguments
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_theory_integration_creation() {
let theory = TheoryIntegration::new();
let _ = theory; // Just check it compiles
}
#[test]
fn test_is_linear_arithmetic() {
let mut manager = TermManager::new();
let x = manager.mk_var("x", manager.sorts.int_sort);
assert!(TheoryIntegration::is_linear_arithmetic(x, &manager));
let y = manager.mk_var("y", manager.sorts.real_sort);
assert!(TheoryIntegration::is_linear_arithmetic(y, &manager));
let b = manager.mk_var("b", manager.sorts.bool_sort);
assert!(!TheoryIntegration::is_linear_arithmetic(b, &manager));
}
#[test]
fn test_project_variables() {
let mut manager = TermManager::new();
let x = manager.mk_var("x", manager.sorts.int_sort);
let zero = manager.mk_int(0);
let formula = manager.mk_eq(x, zero);
let projected = TheoryIntegration::project_variables(formula, &[x], &mut manager);
assert_eq!(projected, formula); // Placeholder returns formula as-is
}
#[test]
fn test_theory_generalize() {
let mut manager = TermManager::new();
let x = manager.mk_var("x", manager.sorts.int_sort);
let cube = [x];
let generalized = TheoryIntegration::theory_generalize(&cube, &mut manager);
assert_eq!(generalized.len(), 1);
assert_eq!(generalized[0], x);
}
}