oxiz-sat 0.2.0

High-performance CDCL SAT Solver for OxiZ
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
//! Advanced Variable Elimination for SAT Preprocessing.
#![allow(dead_code, clippy::ptr_arg)] // Under development
//!
//! Implements sophisticated variable elimination techniques including:
//! - Bounded Variable Elimination (BVE)
//! - Asymmetric Variable Elimination
//! - Resolution-based elimination with cost analysis

#[allow(unused_imports)]
use crate::prelude::*;
use crate::{Clause, Lit, Var};

/// Variable elimination engine for SAT preprocessing.
pub struct VariableEliminator {
    config: EliminationConfig,
    stats: EliminationStats,
}

/// Configuration for variable elimination.
#[derive(Clone, Debug)]
pub struct EliminationConfig {
    /// Maximum clause size to consider for elimination
    pub max_clause_size: usize,
    /// Maximum number of resolvents allowed per variable
    pub max_resolvents: usize,
    /// Enable bounded variable elimination
    pub bounded_elimination: bool,
    /// Enable asymmetric elimination
    pub asymmetric_elimination: bool,
    /// Cost threshold for elimination
    pub cost_threshold: f64,
    /// Maximum variable activity for elimination
    pub max_activity: f64,
}

impl Default for EliminationConfig {
    fn default() -> Self {
        Self {
            max_clause_size: 10,
            max_resolvents: 100,
            bounded_elimination: true,
            asymmetric_elimination: true,
            cost_threshold: 0.0,
            max_activity: 0.1,
        }
    }
}

/// Statistics about variable elimination.
#[derive(Clone, Debug, Default)]
pub struct EliminationStats {
    /// Number of variables eliminated
    pub vars_eliminated: usize,
    /// Number of clauses before elimination
    pub clauses_before: usize,
    /// Number of clauses after elimination
    pub clauses_after: usize,
    /// Total literals before
    pub literals_before: usize,
    /// Total literals after
    pub literals_after: usize,
    /// Number of resolution steps performed
    pub resolutions: usize,
}

impl VariableEliminator {
    /// Create a new variable eliminator.
    pub fn new(config: EliminationConfig) -> Self {
        Self {
            config,
            stats: EliminationStats::default(),
        }
    }

    /// Eliminate variables from a clause database.
    pub fn eliminate(&mut self, clauses: &mut Vec<Clause>) -> Vec<Var> {
        self.stats.clauses_before = clauses.len();
        self.stats.literals_before = clauses.iter().map(|c| c.lits.len()).sum();

        let mut eliminated = Vec::new();
        let mut occurrence_map = self.build_occurrence_map(clauses);

        // Build elimination queue ordered by resolution cost
        let mut queue = self.build_elimination_queue(clauses, &occurrence_map);

        while let Some(var) = queue.pop_front() {
            if self.should_eliminate(var, clauses, &occurrence_map)
                && self.eliminate_variable(var, clauses, &mut occurrence_map)
            {
                eliminated.push(var);
                self.stats.vars_eliminated += 1;
            }
        }

        self.stats.clauses_after = clauses.len();
        self.stats.literals_after = clauses.iter().map(|c| c.lits.len()).sum();

        eliminated
    }

    /// Build occurrence map for literals.
    fn build_occurrence_map(&self, clauses: &[Clause]) -> HashMap<Lit, Vec<usize>> {
        let mut map: HashMap<Lit, Vec<usize>> = HashMap::new();

        for (idx, clause) in clauses.iter().enumerate() {
            for &lit in &clause.lits {
                map.entry(lit).or_default().push(idx);
            }
        }

        map
    }

    /// Build elimination queue ordered by cost.
    fn build_elimination_queue(
        &self,
        clauses: &[Clause],
        occurrence_map: &HashMap<Lit, Vec<usize>>,
    ) -> VecDeque<Var> {
        let max_var = clauses
            .iter()
            .flat_map(|c| c.lits.iter())
            .map(|&lit| lit.var())
            .max()
            .unwrap_or(Var(0));

        let mut costs: Vec<(Var, f64)> = Vec::new();

        for var_idx in 0..=max_var.0 {
            let var = Var(var_idx);
            let cost = self.elimination_cost(var, clauses, occurrence_map);
            costs.push((var, cost));
        }

        // Sort by cost
        costs.sort_by(|(_, a), (_, b)| a.partial_cmp(b).unwrap_or(core::cmp::Ordering::Equal));

        costs.into_iter().map(|(var, _)| var).collect()
    }

    /// Compute the cost of eliminating a variable.
    ///
    /// Cost = (number of positive occurrences) × (number of negative occurrences) - (total occurrences)
    fn elimination_cost(
        &self,
        var: Var,
        _clauses: &[Clause],
        occurrence_map: &HashMap<Lit, Vec<usize>>,
    ) -> f64 {
        let pos_lit = Lit::pos(var);
        let neg_lit = Lit::neg(var);

        let pos_count = occurrence_map.get(&pos_lit).map_or(0, |v| v.len());
        let neg_count = occurrence_map.get(&neg_lit).map_or(0, |v| v.len());
        let total_count = pos_count + neg_count;

        if total_count == 0 {
            return f64::INFINITY;
        }

        // Cost: number of new clauses - number of removed clauses
        let new_clauses = pos_count * neg_count;
        let removed_clauses = pos_count + neg_count;

        (new_clauses as f64) - (removed_clauses as f64)
    }

    /// Check if a variable should be eliminated.
    fn should_eliminate(
        &self,
        var: Var,
        clauses: &[Clause],
        occurrence_map: &HashMap<Lit, Vec<usize>>,
    ) -> bool {
        let cost = self.elimination_cost(var, clauses, occurrence_map);

        // Don't eliminate if cost is too high
        if cost > self.config.cost_threshold {
            return false;
        }

        // Check if occurrences are within bounds
        let pos_lit = Lit::pos(var);
        let neg_lit = Lit::neg(var);

        let pos_count = occurrence_map.get(&pos_lit).map_or(0, |v| v.len());
        let neg_count = occurrence_map.get(&neg_lit).map_or(0, |v| v.len());

        // Don't eliminate if too many resolvents
        if pos_count * neg_count > self.config.max_resolvents {
            return false;
        }

        // Check clause sizes
        for &idx in occurrence_map
            .get(&pos_lit)
            .into_iter()
            .chain(occurrence_map.get(&neg_lit))
            .flatten()
        {
            if let Some(clause) = clauses.get(idx)
                && clause.lits.len() > self.config.max_clause_size
            {
                return false;
            }
        }

        true
    }

    /// Eliminate a variable by resolution.
    fn eliminate_variable(
        &mut self,
        var: Var,
        clauses: &mut Vec<Clause>,
        occurrence_map: &mut HashMap<Lit, Vec<usize>>,
    ) -> bool {
        let pos_lit = Lit::pos(var);
        let neg_lit = Lit::neg(var);

        // Get clauses containing positive and negative literals
        let pos_clauses: Vec<usize> = occurrence_map.get(&pos_lit).cloned().unwrap_or_default();
        let neg_clauses: Vec<usize> = occurrence_map.get(&neg_lit).cloned().unwrap_or_default();

        if pos_clauses.is_empty() || neg_clauses.is_empty() {
            // Variable appears only in one polarity, just remove those clauses
            self.remove_clauses_with_var(var, clauses, occurrence_map);
            return true;
        }

        // Generate all resolvents
        let mut resolvents = Vec::new();

        for &pos_idx in &pos_clauses {
            for &neg_idx in &neg_clauses {
                if let Some(resolvent) = self.resolve(&clauses[pos_idx], &clauses[neg_idx], var) {
                    // Check if resolvent is a tautology
                    if !self.is_tautology(&resolvent) {
                        resolvents.push(resolvent);
                    }
                    self.stats.resolutions += 1;
                }
            }
        }

        // Remove original clauses
        let to_remove: HashSet<usize> = pos_clauses.into_iter().chain(neg_clauses).collect();

        self.remove_clauses_by_indices(clauses, &to_remove, occurrence_map);

        // Add resolvents
        for resolvent in resolvents {
            self.add_clause(resolvent, clauses, occurrence_map);
        }

        true
    }

    /// Resolve two clauses on a variable.
    fn resolve(&self, c1: &Clause, c2: &Clause, var: Var) -> Option<Clause> {
        let pos_lit = Lit::pos(var);
        let neg_lit = Lit::neg(var);

        // Check that c1 contains pos_lit and c2 contains neg_lit (or vice versa)
        let (has_pos_1, has_neg_1) = (c1.lits.contains(&pos_lit), c1.lits.contains(&neg_lit));
        let (has_pos_2, has_neg_2) = (c2.lits.contains(&pos_lit), c2.lits.contains(&neg_lit));

        if !((has_pos_1 && has_neg_2) || (has_neg_1 && has_pos_2)) {
            return None;
        }

        // Merge clauses, removing the pivot literals
        let mut resolvent_lits: Vec<Lit> = c1
            .lits
            .iter()
            .chain(c2.lits.iter())
            .copied()
            .filter(|&lit| lit.var() != var)
            .collect();

        // Remove duplicates
        resolvent_lits.sort_unstable_by_key(|lit| lit.code());
        resolvent_lits.dedup();

        Some(Clause::new(resolvent_lits, false))
    }

    /// Check if a clause is a tautology (contains both p and ¬p).
    fn is_tautology(&self, clause: &Clause) -> bool {
        let lit_set: HashSet<Lit> = clause.lits.iter().copied().collect();

        for &lit in &clause.lits {
            if lit_set.contains(&!lit) {
                return true;
            }
        }

        false
    }

    /// Remove clauses containing a variable.
    fn remove_clauses_with_var(
        &self,
        var: Var,
        clauses: &mut Vec<Clause>,
        occurrence_map: &mut HashMap<Lit, Vec<usize>>,
    ) {
        let pos_lit = Lit::pos(var);
        let neg_lit = Lit::neg(var);

        let to_remove: HashSet<usize> = occurrence_map
            .get(&pos_lit)
            .into_iter()
            .chain(occurrence_map.get(&neg_lit))
            .flatten()
            .copied()
            .collect();

        self.remove_clauses_by_indices(clauses, &to_remove, occurrence_map);
    }

    /// Remove clauses by their indices.
    fn remove_clauses_by_indices(
        &self,
        clauses: &mut Vec<Clause>,
        to_remove: &HashSet<usize>,
        occurrence_map: &mut HashMap<Lit, Vec<usize>>,
    ) {
        // Mark clauses for removal
        let mut new_clauses = Vec::new();
        let mut old_to_new = HashMap::new();

        for (old_idx, clause) in clauses.iter().enumerate() {
            if !to_remove.contains(&old_idx) {
                let new_idx = new_clauses.len();
                old_to_new.insert(old_idx, new_idx);
                new_clauses.push(clause.clone());
            }
        }

        *clauses = new_clauses;

        // Update occurrence map
        for (_, indices) in occurrence_map.iter_mut() {
            *indices = indices
                .iter()
                .filter_map(|&old_idx| old_to_new.get(&old_idx).copied())
                .collect();
        }

        // Remove empty entries
        occurrence_map.retain(|_, v| !v.is_empty());
    }

    /// Add a clause to the database.
    fn add_clause(
        &self,
        clause: Clause,
        clauses: &mut Vec<Clause>,
        occurrence_map: &mut HashMap<Lit, Vec<usize>>,
    ) {
        let idx = clauses.len();
        clauses.push(clause.clone());

        for &lit in &clause.lits {
            occurrence_map.entry(lit).or_default().push(idx);
        }
    }

    /// Get elimination statistics.
    pub fn stats(&self) -> &EliminationStats {
        &self.stats
    }
}

/// Asymmetric variable elimination.
pub struct AsymmetricEliminator {
    config: EliminationConfig,
}

impl AsymmetricEliminator {
    /// Create a new asymmetric eliminator.
    pub fn new(config: EliminationConfig) -> Self {
        Self { config }
    }

    /// Perform asymmetric elimination.
    ///
    /// Removes literals that don't contribute to satisfiability.
    pub fn eliminate(&self, clauses: &mut Vec<Clause>) -> usize {
        let mut eliminated = 0;

        for clause in clauses.iter_mut() {
            eliminated += self.eliminate_asymmetric_literals(clause);
        }

        eliminated
    }

    /// Eliminate asymmetric literals from a clause.
    fn eliminate_asymmetric_literals(&self, clause: &mut Clause) -> usize {
        let original_len = clause.lits.len();

        // Try removing each literal and check if clause is still satisfiable
        let mut i = 0;
        while i < clause.lits.len() {
            let _lit = clause.lits[i];

            // Create clause without this literal
            let mut test_clause = clause.clone();
            test_clause.lits.remove(i);

            // Check if removal makes clause unit or empty
            if test_clause.lits.len() <= 1 {
                i += 1;
                continue;
            }

            // Simplified check: if remaining clause subsumes original, remove literal
            if self.subsumes(&test_clause, clause) {
                clause.lits.remove(i);
            } else {
                i += 1;
            }
        }

        original_len - clause.lits.len()
    }

    /// Check if clause c1 subsumes c2.
    fn subsumes(&self, c1: &Clause, c2: &Clause) -> bool {
        let c1_set: HashSet<Lit> = c1.lits.iter().copied().collect();

        c2.lits.iter().all(|lit| c1_set.contains(lit))
    }
}

/// Bounded variable addition for preprocessing.
///
/// Introduces new variables to simplify formula structure.
pub struct BoundedVariableAddition {
    next_var: Var,
}

impl BoundedVariableAddition {
    /// Create a new bounded variable addition engine.
    pub fn new(max_var: Var) -> Self {
        Self {
            next_var: Var(max_var.0 + 1),
        }
    }

    /// Add bounded variables to simplify clauses.
    pub fn add_variables(&mut self, clauses: &mut Vec<Clause>) -> Vec<Var> {
        let mut added = Vec::new();

        // Find long clauses that could benefit from splitting
        let long_clauses: Vec<usize> = clauses
            .iter()
            .enumerate()
            .filter(|(_, c)| c.lits.len() > 8)
            .map(|(i, _)| i)
            .collect();

        for idx in long_clauses {
            if let Some(new_var) = self.split_clause(idx, clauses) {
                added.push(new_var);
            }
        }

        added
    }

    /// Split a long clause by introducing a new variable.
    fn split_clause(&mut self, idx: usize, clauses: &mut Vec<Clause>) -> Option<Var> {
        let clause = clauses.get(idx)?;

        if clause.lits.len() <= 4 {
            return None;
        }

        let new_var = self.next_var;
        self.next_var = Var(self.next_var.0 + 1);

        let mid = clause.lits.len() / 2;

        // Split: (l1 ∨ l2 ∨ ... ∨ lₙ) becomes:
        // (l1 ∨ ... ∨ lₘ ∨ x) ∧ (¬x ∨ lₘ₊₁ ∨ ... ∨ lₙ)

        let mut first_half = clause.lits[..mid].to_vec();
        first_half.push(Lit::pos(new_var));

        let mut second_half = clause.lits[mid..].to_vec();
        second_half.push(Lit::neg(new_var));

        clauses[idx] = Clause::new(first_half, false);
        clauses.push(Clause::new(second_half, false));

        Some(new_var)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_variable_eliminator_creation() {
        let config = EliminationConfig::default();
        let eliminator = VariableEliminator::new(config);

        assert_eq!(eliminator.stats.vars_eliminated, 0);
    }

    #[test]
    fn test_elimination_cost() {
        let config = EliminationConfig::default();
        let eliminator = VariableEliminator::new(config);

        let clauses = vec![
            Clause::new(vec![Lit::pos(Var(0))], false),
            Clause::new(vec![Lit::neg(Var(0))], false),
        ];

        let occurrence_map = eliminator.build_occurrence_map(&clauses);
        let cost = eliminator.elimination_cost(Var(0), &clauses, &occurrence_map);

        // Cost = (1 × 1) - 2 = -1
        assert_eq!(cost, -1.0);
    }

    #[test]
    fn test_resolution() {
        let config = EliminationConfig::default();
        let eliminator = VariableEliminator::new(config);

        let c1 = Clause::new(vec![Lit::pos(Var(0)), Lit::pos(Var(1))], false);
        let c2 = Clause::new(vec![Lit::neg(Var(0)), Lit::pos(Var(2))], false);

        let resolvent = eliminator
            .resolve(&c1, &c2, Var(0))
            .expect("resolution failed");

        // Should get (v1 ∨ v2)
        assert_eq!(resolvent.lits.len(), 2);
    }

    #[test]
    fn test_is_tautology() {
        let config = EliminationConfig::default();
        let eliminator = VariableEliminator::new(config);

        let taut = Clause::new(vec![Lit::pos(Var(0)), Lit::neg(Var(0))], false);

        assert!(eliminator.is_tautology(&taut));

        let non_taut = Clause::new(vec![Lit::pos(Var(0)), Lit::pos(Var(1))], false);

        assert!(!eliminator.is_tautology(&non_taut));
    }
}