oxiz-sat 0.2.0

High-performance CDCL SAT Solver for OxiZ
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
//! Advanced SAT Preprocessing
//!
//! This module implements sophisticated preprocessing techniques for CNF formulas:
//! - Variable elimination (bounded variable elimination)
//! - Subsumption and self-subsuming resolution
//! - Vivification (clause strengthening)
//! - Blocked clause elimination
//! - Equivalent literal substitution

#![allow(missing_docs)] // Under development - documentation in progress
#[allow(unused_imports)]
use crate::prelude::*;

/// Literal representation (positive/negative variable)
pub type Lit = i32;

/// Variable identifier
pub type Var = u32;

/// Clause identifier
pub type ClauseId = usize;

/// Clause (set of literals)
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub struct Clause {
    pub literals: Vec<Lit>,
}

impl Clause {
    /// Create a new clause
    pub fn new(literals: Vec<Lit>) -> Self {
        Self { literals }
    }

    /// Check if clause is unit (single literal)
    pub fn is_unit(&self) -> bool {
        self.literals.len() == 1
    }

    /// Check if clause is binary
    pub fn is_binary(&self) -> bool {
        self.literals.len() == 2
    }

    /// Check if clause is empty (contradiction)
    pub fn is_empty(&self) -> bool {
        self.literals.is_empty()
    }

    /// Check if clause contains a literal
    pub fn contains(&self, lit: Lit) -> bool {
        self.literals.contains(&lit)
    }

    /// Get clause size
    pub fn size(&self) -> usize {
        self.literals.len()
    }
}

/// Statistics for preprocessing
#[derive(Debug, Clone, Default)]
pub struct PreprocessingStats {
    pub variables_eliminated: u64,
    pub clauses_eliminated: u64,
    pub literals_eliminated: u64,
    pub subsumptions: u64,
    pub self_subsuming_resolutions: u64,
    pub vivifications: u64,
    pub blocked_clauses: u64,
    pub equivalent_literals: u64,
}

/// Configuration for preprocessing
#[derive(Debug, Clone)]
pub struct PreprocessingConfig {
    /// Enable bounded variable elimination
    pub enable_bve: bool,
    /// Maximum clause growth for BVE
    pub bve_clause_limit: usize,
    /// Enable subsumption
    pub enable_subsumption: bool,
    /// Enable vivification
    pub enable_vivification: bool,
    /// Enable blocked clause elimination
    pub enable_bce: bool,
    /// Enable equivalent literal substitution
    pub enable_equiv_literals: bool,
    /// Maximum preprocessing iterations
    pub max_iterations: usize,
}

impl Default for PreprocessingConfig {
    fn default() -> Self {
        Self {
            enable_bve: true,
            bve_clause_limit: 100,
            enable_subsumption: true,
            enable_vivification: true,
            enable_bce: true,
            enable_equiv_literals: true,
            max_iterations: 10,
        }
    }
}

/// Advanced SAT preprocessor
pub struct AdvancedPreprocessor {
    config: PreprocessingConfig,
    stats: PreprocessingStats,
    /// Formula clauses
    clauses: Vec<Clause>,
    /// Occurrence lists: literal -> clause IDs
    occurrences: FxHashMap<Lit, Vec<ClauseId>>,
    /// Variable elimination order
    elim_order: Vec<Var>,
    /// Eliminated variables
    eliminated: FxHashSet<Var>,
}

impl AdvancedPreprocessor {
    /// Create a new preprocessor
    pub fn new(config: PreprocessingConfig) -> Self {
        Self {
            config,
            stats: PreprocessingStats::default(),
            clauses: Vec::new(),
            occurrences: FxHashMap::default(),
            elim_order: Vec::new(),
            eliminated: FxHashSet::default(),
        }
    }

    /// Preprocess a CNF formula
    pub fn preprocess(&mut self, clauses: Vec<Clause>) -> Result<Vec<Clause>, String> {
        self.clauses = clauses;
        self.build_occurrence_lists();

        // Main preprocessing loop
        for _iteration in 0..self.config.max_iterations {
            let mut changed = false;

            // Unit propagation
            changed |= self.unit_propagation()?;

            // Subsumption
            if self.config.enable_subsumption {
                changed |= self.subsumption()?;
            }

            // Self-subsuming resolution
            if self.config.enable_subsumption {
                changed |= self.self_subsuming_resolution()?;
            }

            // Vivification
            if self.config.enable_vivification {
                changed |= self.vivification()?;
            }

            // Bounded variable elimination
            if self.config.enable_bve {
                changed |= self.bounded_variable_elimination()?;
            }

            // Blocked clause elimination
            if self.config.enable_bce {
                changed |= self.blocked_clause_elimination()?;
            }

            // Equivalent literal substitution
            if self.config.enable_equiv_literals {
                changed |= self.equivalent_literal_substitution()?;
            }

            // Stop if no progress
            if !changed {
                break;
            }
        }

        // Return preprocessed formula
        Ok(self.clauses.clone())
    }

    /// Build occurrence lists for efficient lookup
    fn build_occurrence_lists(&mut self) {
        self.occurrences.clear();

        for (clause_id, clause) in self.clauses.iter().enumerate() {
            for &lit in &clause.literals {
                self.occurrences.entry(lit).or_default().push(clause_id);
            }
        }
    }

    /// Unit propagation
    fn unit_propagation(&mut self) -> Result<bool, String> {
        let mut changed = false;

        loop {
            // Find unit clauses
            let unit_clauses: Vec<_> = self
                .clauses
                .iter()
                .filter(|c| c.is_unit())
                .cloned()
                .collect();

            if unit_clauses.is_empty() {
                break;
            }

            for unit_clause in unit_clauses {
                let unit_lit = unit_clause.literals[0];

                // Propagate this literal
                self.propagate_literal(unit_lit)?;
                changed = true;
            }
        }

        Ok(changed)
    }

    /// Propagate a unit literal
    fn propagate_literal(&mut self, lit: Lit) -> Result<(), String> {
        let neg_lit = -lit;

        // Remove clauses containing lit
        self.clauses.retain(|c| !c.contains(lit));

        // Remove -lit from clauses
        for clause in &mut self.clauses {
            if clause.contains(neg_lit) {
                clause.literals.retain(|&l| l != neg_lit);
                self.stats.literals_eliminated += 1;
            }
        }

        // Check for empty clause (contradiction)
        if self.clauses.iter().any(|c| c.is_empty()) {
            return Err("Formula is unsatisfiable".to_string());
        }

        self.build_occurrence_lists();
        Ok(())
    }

    /// Subsumption: remove clauses subsumed by smaller clauses
    fn subsumption(&mut self) -> Result<bool, String> {
        let mut changed = false;
        let mut to_remove = FxHashSet::default();

        for i in 0..self.clauses.len() {
            if to_remove.contains(&i) {
                continue;
            }

            for j in (i + 1)..self.clauses.len() {
                if to_remove.contains(&j) {
                    continue;
                }

                // Check if clause i subsumes clause j
                if self.subsumes(&self.clauses[i], &self.clauses[j]) {
                    to_remove.insert(j);
                    self.stats.subsumptions += 1;
                    changed = true;
                }
                // Check if clause j subsumes clause i
                else if self.subsumes(&self.clauses[j], &self.clauses[i]) {
                    to_remove.insert(i);
                    self.stats.subsumptions += 1;
                    changed = true;
                    break;
                }
            }
        }

        // Remove subsumed clauses
        let mut new_clauses = Vec::new();
        for (i, clause) in self.clauses.iter().enumerate() {
            if !to_remove.contains(&i) {
                new_clauses.push(clause.clone());
            }
        }

        self.clauses = new_clauses;
        self.stats.clauses_eliminated += to_remove.len() as u64;

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Check if clause1 subsumes clause2
    fn subsumes(&self, clause1: &Clause, clause2: &Clause) -> bool {
        if clause1.size() > clause2.size() {
            return false;
        }

        clause1.literals.iter().all(|lit| clause2.contains(*lit))
    }

    /// Self-subsuming resolution
    fn self_subsuming_resolution(&mut self) -> Result<bool, String> {
        let mut changed = false;

        for i in 0..self.clauses.len() {
            for j in (i + 1)..self.clauses.len() {
                // Check if we can perform self-subsuming resolution
                if let Some(resolvent) =
                    self.try_self_subsuming_resolution(&self.clauses[i], &self.clauses[j])
                {
                    // Replace the longer clause with the resolvent
                    if self.clauses[i].size() > self.clauses[j].size() {
                        self.clauses[i] = resolvent;
                    } else {
                        self.clauses[j] = resolvent;
                    }

                    self.stats.self_subsuming_resolutions += 1;
                    changed = true;
                }
            }
        }

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Try self-subsuming resolution between two clauses
    fn try_self_subsuming_resolution(&self, c1: &Clause, c2: &Clause) -> Option<Clause> {
        // Find pivot literal
        for &lit in &c1.literals {
            if c2.contains(-lit) {
                // Check if c1 \ {lit} ⊆ c2
                let c1_without_lit: FxHashSet<_> =
                    c1.literals.iter().filter(|&&l| l != lit).copied().collect();

                if c1_without_lit.iter().all(|l| c2.contains(*l)) {
                    // Self-subsuming resolution: c2 \ {-lit}
                    let resolvent_lits: Vec<_> = c2
                        .literals
                        .iter()
                        .filter(|&&l| l != -lit)
                        .copied()
                        .collect();

                    return Some(Clause::new(resolvent_lits));
                }
            }
        }

        None
    }

    /// Vivification: strengthen clauses by trying to derive shorter clauses
    fn vivification(&mut self) -> Result<bool, String> {
        let mut changed = false;

        // Collect indices of clauses to process (avoiding borrow checker issues)
        let indices_to_process: Vec<usize> = self
            .clauses
            .iter()
            .enumerate()
            .filter(|(_, clause)| clause.size() > 2)
            .map(|(i, _)| i)
            .collect();

        for idx in indices_to_process {
            let clause = &self.clauses[idx];
            // Try to find a subset that implies the clause
            if let Some(strengthened) = self.try_strengthen_clause(clause) {
                self.clauses[idx] = strengthened;
                self.stats.vivifications += 1;
                changed = true;
            }
        }

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Try to strengthen a clause
    fn try_strengthen_clause(&self, clause: &Clause) -> Option<Clause> {
        // Placeholder: would use unit propagation to check if subset implies clause
        // For now, just check for duplicate literals
        let mut unique_lits: Vec<_> = clause.literals.clone();
        unique_lits.sort();
        unique_lits.dedup();

        if unique_lits.len() < clause.literals.len() {
            Some(Clause::new(unique_lits))
        } else {
            None
        }
    }

    /// Bounded variable elimination
    fn bounded_variable_elimination(&mut self) -> Result<bool, String> {
        let mut changed = false;

        // Compute elimination order (prefer variables with few occurrences)
        self.compute_elimination_order();

        for &var in &self.elim_order.clone() {
            if self.eliminated.contains(&var) {
                continue;
            }

            // Try to eliminate this variable
            if self.try_eliminate_variable(var)? {
                self.eliminated.insert(var);
                self.stats.variables_eliminated += 1;
                changed = true;
            }
        }

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Compute variable elimination order
    fn compute_elimination_order(&mut self) {
        let mut var_occurrences: FxHashMap<Var, usize> = FxHashMap::default();

        for clause in &self.clauses {
            for &lit in &clause.literals {
                let var = lit.unsigned_abs();
                *var_occurrences.entry(var).or_insert(0) += 1;
            }
        }

        // Sort by occurrence count
        let mut vars: Vec<_> = var_occurrences.into_iter().collect();
        vars.sort_by_key(|(_, count)| *count);

        self.elim_order = vars.into_iter().map(|(var, _)| var).collect();
    }

    /// Try to eliminate a variable by resolution
    fn try_eliminate_variable(&mut self, var: Var) -> Result<bool, String> {
        let pos_lit = var as Lit;
        let neg_lit = -(var as Lit);

        // Get clauses containing the variable
        let pos_clauses: Vec<_> = self
            .clauses
            .iter()
            .filter(|c| c.contains(pos_lit))
            .cloned()
            .collect();

        let neg_clauses: Vec<_> = self
            .clauses
            .iter()
            .filter(|c| c.contains(neg_lit))
            .cloned()
            .collect();

        // Compute resolvent clauses
        let mut resolvents = Vec::new();

        for pos_clause in &pos_clauses {
            for neg_clause in &neg_clauses {
                if let Some(resolvent) = self.resolve(pos_clause, neg_clause, pos_lit) {
                    resolvents.push(resolvent);
                }
            }
        }

        // Check if elimination is beneficial (bounded variable elimination)
        let old_clause_count = pos_clauses.len() + neg_clauses.len();
        let new_clause_count = resolvents.len();

        if new_clause_count > self.config.bve_clause_limit
            || new_clause_count > old_clause_count * 2
        {
            return Ok(false);
        }

        // Remove old clauses and add resolvents
        self.clauses
            .retain(|c| !c.contains(pos_lit) && !c.contains(neg_lit));
        self.clauses.extend(resolvents);

        self.stats.clauses_eliminated += old_clause_count as u64;

        Ok(true)
    }

    /// Resolve two clauses on a literal
    fn resolve(&self, c1: &Clause, c2: &Clause, pivot: Lit) -> Option<Clause> {
        let mut resolvent_lits = FxHashSet::default();

        // Add literals from c1 except pivot
        for &lit in &c1.literals {
            if lit != pivot {
                resolvent_lits.insert(lit);
            }
        }

        // Add literals from c2 except -pivot
        for &lit in &c2.literals {
            if lit != -pivot {
                // Check for tautology
                if resolvent_lits.contains(&-lit) {
                    return None;
                }
                resolvent_lits.insert(lit);
            }
        }

        Some(Clause::new(resolvent_lits.into_iter().collect()))
    }

    /// Blocked clause elimination
    fn blocked_clause_elimination(&mut self) -> Result<bool, String> {
        let mut changed = false;
        let mut to_remove = FxHashSet::default();

        for (clause_id, clause) in self.clauses.iter().enumerate() {
            // Check if clause is blocked on any literal
            for &lit in &clause.literals {
                if self.is_blocked(clause, lit) {
                    to_remove.insert(clause_id);
                    self.stats.blocked_clauses += 1;
                    changed = true;
                    break;
                }
            }
        }

        // Remove blocked clauses
        let mut new_clauses = Vec::new();
        for (i, clause) in self.clauses.iter().enumerate() {
            if !to_remove.contains(&i) {
                new_clauses.push(clause.clone());
            }
        }

        self.clauses = new_clauses;

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Check if a clause is blocked on a literal
    fn is_blocked(&self, clause: &Clause, lit: Lit) -> bool {
        // Clause is blocked on lit if all resolvents are tautologies
        let neg_lit = -lit;

        for other_clause in &self.clauses {
            if other_clause.contains(neg_lit)
                && let Some(_resolvent) = self.resolve(clause, other_clause, lit)
            {
                // Found a non-tautological resolvent
                return false;
            }
        }

        true
    }

    /// Equivalent literal substitution
    fn equivalent_literal_substitution(&mut self) -> Result<bool, String> {
        let mut changed = false;

        // Find equivalent literals using binary clauses
        let equiv_classes = self.find_equivalent_literals();

        // Substitute equivalent literals
        for (representative, equivalents) in equiv_classes {
            for equiv in equivalents {
                self.substitute_literal(equiv, representative);
                self.stats.equivalent_literals += 1;
                changed = true;
            }
        }

        if changed {
            self.build_occurrence_lists();
        }

        Ok(changed)
    }

    /// Find equivalent literals using binary implications
    fn find_equivalent_literals(&self) -> FxHashMap<Lit, Vec<Lit>> {
        let mut implications: FxHashMap<Lit, Vec<Lit>> = FxHashMap::default();

        // Extract binary implications
        for clause in &self.clauses {
            if clause.is_binary() {
                let lit1 = clause.literals[0];
                let lit2 = clause.literals[1];

                // (lit1 ∨ lit2) ≡ (¬lit1 → lit2)
                implications.entry(-lit1).or_default().push(lit2);
                implications.entry(-lit2).or_default().push(lit1);
            }
        }

        // Find strongly connected components (equivalent literals)
        let mut equiv_classes = FxHashMap::default();

        // Placeholder: would use Tarjan's algorithm
        // For now, just find simple equivalences (lit1 → lit2 and lit2 → lit1)
        for (&lit1, targets) in &implications {
            for &lit2 in targets {
                if implications.get(&lit2).is_some_and(|t| t.contains(&lit1)) {
                    // Found equivalence: lit1 ≡ lit2
                    equiv_classes
                        .entry(lit1.min(lit2))
                        .or_insert_with(Vec::new)
                        .push(lit1.max(lit2));
                }
            }
        }

        equiv_classes
    }

    /// Substitute a literal with another
    fn substitute_literal(&mut self, from: Lit, to: Lit) {
        for clause in &mut self.clauses {
            for lit in &mut clause.literals {
                if *lit == from {
                    *lit = to;
                } else if *lit == -from {
                    *lit = -to;
                }
            }
        }
    }

    /// Get statistics
    pub fn stats(&self) -> &PreprocessingStats {
        &self.stats
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_preprocessor_creation() {
        let config = PreprocessingConfig::default();
        let preprocessor = AdvancedPreprocessor::new(config);
        assert_eq!(preprocessor.stats.variables_eliminated, 0);
    }

    #[test]
    fn test_unit_propagation() {
        let config = PreprocessingConfig::default();
        let mut preprocessor = AdvancedPreprocessor::new(config);

        let clauses = vec![
            Clause::new(vec![1]),     // Unit clause
            Clause::new(vec![1, 2]),  // Should be removed (contains 1)
            Clause::new(vec![-1, 3]), // Should become (3)
        ];

        let result = preprocessor.preprocess(clauses);
        assert!(result.is_ok());

        let preprocessed = result.expect("Preprocessing must succeed");
        assert!(preprocessed.len() < 3);
    }

    #[test]
    fn test_subsumption() {
        let config = PreprocessingConfig::default();
        let mut preprocessor = AdvancedPreprocessor::new(config);

        let clauses = vec![
            Clause::new(vec![1, 2]),    // Subsumes next clause
            Clause::new(vec![1, 2, 3]), // Should be removed
        ];

        let result = preprocessor.preprocess(clauses);
        assert!(result.is_ok());

        let preprocessed = result.expect("Preprocessing must succeed");
        // Verify preprocessing ran successfully
        assert!(preprocessed.len() <= 2);
    }

    #[test]
    fn test_clause_operations() {
        let clause = Clause::new(vec![1, 2, 3]);

        assert!(clause.contains(2));
        assert!(!clause.contains(4));
        assert_eq!(clause.size(), 3);
        assert!(!clause.is_unit());
        assert!(!clause.is_binary());
    }

    #[test]
    fn test_subsumes_check() {
        let preprocessor = AdvancedPreprocessor::new(PreprocessingConfig::default());

        let c1 = Clause::new(vec![1, 2]);
        let c2 = Clause::new(vec![1, 2, 3]);

        assert!(preprocessor.subsumes(&c1, &c2));
        assert!(!preprocessor.subsumes(&c2, &c1));
    }

    #[test]
    fn test_resolution() {
        let preprocessor = AdvancedPreprocessor::new(PreprocessingConfig::default());

        let c1 = Clause::new(vec![1, 2]);
        let c2 = Clause::new(vec![-1, 3]);

        let resolvent = preprocessor.resolve(&c1, &c2, 1);
        assert!(resolvent.is_some());

        let res = resolvent.expect("Resolution must produce resolvent");
        assert!(res.contains(2));
        assert!(res.contains(3));
        assert!(!res.contains(1));
    }

    #[test]
    fn test_tautology_detection() {
        let preprocessor = AdvancedPreprocessor::new(PreprocessingConfig::default());

        let c1 = Clause::new(vec![1, 2]);
        let c2 = Clause::new(vec![-1, -2]);

        // Resolution should produce tautology (2, -2)
        let resolvent = preprocessor.resolve(&c1, &c2, 1);
        assert!(resolvent.is_none());
    }

    #[test]
    fn test_empty_clause() {
        let clause = Clause::new(vec![]);
        assert!(clause.is_empty());
    }
}