omni-dev 0.46.0

AI-powered git commit rewriter, PR generator, and MCP server for Jira, Confluence, Datadog, Gmail, and Drive.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
//! Gated, single-file Trash and restore operations (ADR-0092).

use std::time::{Duration, Instant};

use serde::Serialize;

use crate::cli::drive::format::{write_scalar_jsonl, JsonlSerialize};
use crate::drive::client::DriveClient;
use crate::drive::files_api::FilesApi;
use crate::drive::folder_ancestry::{self, DecisionSource};
use crate::drive::types::GOOGLE_FOLDER_MIME_TYPE;
use crate::drive::write_gate::{self, DecidingRule, DriveOperation, FolderPermissionRule, Verdict};
use crate::request_log::{self, DriveMutationOutcome};

/// Options for changing an individual file's trashed state.
#[derive(Debug, Clone)]
pub struct TrashOptions {
    /// Target Drive file ID.
    pub file_id: String,
    /// Restore from Trash instead of moving to Trash.
    pub restore: bool,
    /// Evaluate permissions and report the action without mutating.
    pub dry_run: bool,
}

/// The result of a Trash or restore attempt.
#[derive(Debug, Clone, Serialize)]
#[serde(tag = "status", rename_all = "kebab-case")]
pub enum TrashResult {
    /// The permitted preview would move the file to Trash.
    WouldTrash,
    /// The file was moved to Trash.
    Trashed,
    /// The permitted preview would restore the file.
    WouldUntrash,
    /// The file was restored.
    Untrashed,
    /// The permitted target is already in Trash; no PATCH was sent.
    AlreadyTrashed,
    /// The permitted target is already outside Trash; no PATCH was sent.
    NotTrashed,
    /// Folders affect descendants and are refused even with a file-ID grant.
    RefusedFolder,
    /// There are no visible parents and no file-ID rule granting access.
    RefusedNoVisibleParents,
    /// The permission gate denied access.
    Blocked {
        /// The deciding rule, or `None` for the default policy.
        decided_by: Option<DecidingRule>,
    },
    /// Metadata lookup, permission evaluation or mutation failed.
    Failed {
        /// Human-readable error detail.
        detail: String,
    },
}

impl TrashResult {
    /// Stable status used by the mutation audit log.
    fn log_status(&self) -> &'static str {
        match self {
            Self::WouldTrash => "would-trash",
            Self::Trashed => "trashed",
            Self::WouldUntrash => "would-untrash",
            Self::Untrashed => "untrashed",
            Self::AlreadyTrashed => "already-trashed",
            Self::NotTrashed => "not-trashed",
            Self::RefusedFolder => "refused-folder",
            Self::RefusedNoVisibleParents => "refused-no-visible-parents",
            Self::Blocked { .. } => "blocked",
            Self::Failed { .. } => "failed",
        }
    }
}

/// Structured outcome, shared by terminal output, JSON and audit logging.
#[derive(Debug, Clone, Serialize)]
pub struct TrashOutcome {
    /// Target Drive file ID.
    pub file_id: String,
    /// Target's name, once metadata has been fetched.
    pub file_name: Option<String>,
    /// The single current parent evaluated by the gate, if applicable.
    /// Absent for file-ID rules, multiple parents and pre-gate refusals.
    pub resolved_folder_id: Option<String>,
    /// The attempt's result.
    pub result: TrashResult,
}

impl JsonlSerialize for TrashOutcome {
    fn write_jsonl(&self, out: &mut dyn std::io::Write) -> Result<(), anyhow::Error> {
        write_scalar_jsonl(self, out)
    }
}

/// Changes the target's trashed state after evaluating `trash` permissions.
///
/// Every real attempt writes a best-effort mutation record, including refusals
/// and no-ops. Dry runs never mutate or write mutation records.
pub async fn trash(
    client: &DriveClient,
    opts: &TrashOptions,
    rules: &[FolderPermissionRule],
) -> TrashOutcome {
    let started = Instant::now();
    let outcome = trash_inner(client, opts, rules).await;
    if !opts.dry_run {
        record_attempt(&outcome, opts.restore, started.elapsed());
    }
    outcome
}

async fn trash_inner(
    client: &DriveClient,
    opts: &TrashOptions,
    rules: &[FolderPermissionRule],
) -> TrashOutcome {
    let mut outcome = TrashOutcome {
        file_id: opts.file_id.clone(),
        file_name: None,
        resolved_folder_id: None,
        result: TrashResult::Failed {
            detail: String::new(),
        },
    };
    let files_api = FilesApi::new(client);
    let target = match files_api.get_metadata(&opts.file_id).await {
        Ok(target) => target,
        Err(err) => {
            outcome.result = TrashResult::Failed {
                detail: err.to_string(),
            };
            return outcome;
        }
    };
    outcome.file_name = Some(target.name.clone());
    if target.mime_type == GOOGLE_FOLDER_MIME_TYPE {
        outcome.result = TrashResult::RefusedFolder;
        return outcome;
    }
    let evaluated = match folder_ancestry::resolve_decision_for_file_target(
        &files_api,
        &target,
        DriveOperation::Trash,
        rules,
    )
    .await
    {
        Ok(evaluated) => evaluated,
        Err(err) => {
            outcome.result = TrashResult::Failed {
                detail: err.to_string(),
            };
            return outcome;
        }
    };
    if evaluated.source == DecisionSource::NoVisibleParents {
        outcome.result = TrashResult::RefusedNoVisibleParents;
        return outcome;
    }
    outcome.resolved_folder_id = evaluated.resolved_folder_id;
    if evaluated.decision.verdict == Verdict::Deny {
        outcome.result = TrashResult::Blocked {
            decided_by: evaluated.decision.decided_by,
        };
        return outcome;
    }
    let Some(trashed) = target.trashed else {
        outcome.result = TrashResult::Failed {
            detail: "Drive metadata omitted the requested trashed state".to_string(),
        };
        return outcome;
    };
    if trashed != opts.restore {
        outcome.result = if opts.restore {
            TrashResult::NotTrashed
        } else {
            TrashResult::AlreadyTrashed
        };
        return outcome;
    }
    if opts.dry_run {
        outcome.result = if opts.restore {
            TrashResult::WouldUntrash
        } else {
            TrashResult::WouldTrash
        };
        return outcome;
    }
    // ADR-0092 extends ADR-0080's lease exemptions. Ignore
    // FileTargetDecision::requires_lease as its documentation requires for
    // operations that can never take a lease: Trash provides recovery itself.
    let updated = if opts.restore {
        files_api.untrash(&opts.file_id).await
    } else {
        files_api.trash(&opts.file_id).await
    };
    outcome.result = match updated {
        Ok(updated) if updated.trashed != Some(!opts.restore) => TrashResult::Failed {
            detail: if opts.restore {
                "Drive did not confirm restoration; the file may still be in a trashed parent folder"
            } else {
                "Drive did not confirm the requested trashed state"
            }.to_string(),
        },
        Ok(_) if opts.restore => TrashResult::Untrashed,
        Ok(_) => TrashResult::Trashed,
        Err(err) => TrashResult::Failed {
            detail: err.to_string(),
        },
    };
    outcome
}

fn record_attempt(outcome: &TrashOutcome, restore: bool, duration: Duration) {
    let error = match &outcome.result {
        TrashResult::Failed { detail } => Some(detail.clone()),
        _ => None,
    };
    let decided_by = match &outcome.result {
        TrashResult::Blocked { decided_by } => decided_by.as_ref(),
        _ => None,
    };
    let decided_by = write_gate::decided_by_log_fields(decided_by);
    request_log::record_drive_mutation(DriveMutationOutcome {
        operation: if restore { "untrash" } else { "trash" },
        file_id: outcome.file_id.clone(),
        file_name: outcome.file_name.clone().unwrap_or_default(),
        status: outcome.result.log_status().to_string(),
        resolved_folder_id: outcome.resolved_folder_id.clone(),
        decided_by_folder_id: decided_by.folder_id,
        decided_by_file_id: decided_by.file_id,
        decided_by_depth: decided_by.depth,
        error,
        duration,
        ..Default::default()
    });
}

#[cfg(test)]
#[allow(clippy::unwrap_used, clippy::expect_used)]
mod tests {
    use super::*;
    use crate::drive::auth::{DriveCredentials, DriveGrantedScopes};
    use crate::utils::secret::Secret;
    use wiremock::matchers::{body_json, method, path, query_param};
    use wiremock::{Mock, MockServer, ResponseTemplate};

    fn test_credentials() -> DriveCredentials {
        DriveCredentials {
            client_id: "client-1".to_string(),
            client_secret: Secret::new("secret-1"),
            refresh_token: Secret::new("refresh-1"),
            scope: DriveGrantedScopes::READONLY,
        }
    }

    async fn client_with_bootstrapped_token(server: &wiremock::MockServer) -> DriveClient {
        wiremock::Mock::given(wiremock::matchers::method("POST"))
            .and(wiremock::matchers::path("/token"))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "access_token": "test-token",
                    "expires_in": 3600,
                })),
            )
            .mount(server)
            .await;

        let mut client = DriveClient::new(&server.uri(), &test_credentials()).unwrap();
        crate::drive::client::test_support::replace_session(
            &mut client,
            &test_credentials(),
            &format!("{}/token", server.uri()),
        );
        client
    }

    fn mount_file(id: &str, mime_type: &str, parents: &[&str]) -> wiremock::Mock {
        let parents_json: Vec<&str> = parents.to_vec();
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path(format!("/drive/v3/files/{id}")))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": id, "name": id, "mimeType": mime_type, "parents": parents_json,
                    "version": "1", "trashed": false,
                })),
            )
    }

    fn mount_folder(id: &str) -> wiremock::Mock {
        wiremock::Mock::given(wiremock::matchers::method("GET"))
            .and(wiremock::matchers::path(format!("/drive/v3/files/{id}")))
            .respond_with(
                wiremock::ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": id, "name": id, "mimeType": GOOGLE_FOLDER_MIME_TYPE,
                })),
            )
    }

    fn opts(restore: bool, dry_run: bool) -> TrashOptions {
        TrashOptions {
            file_id: "file-1".into(),
            restore,
            dry_run,
        }
    }

    fn allow() -> FolderPermissionRule {
        // Default require_lease=true deliberately proves Trash is exempt.
        FolderPermissionRule::folder("parent-1").allowing([DriveOperation::Trash])
    }

    async fn no_patch(server: &MockServer) {
        Mock::given(method("PATCH"))
            .respond_with(ResponseTemplate::new(500))
            .expect(0)
            .mount(server)
            .await;
    }

    async fn trashed_file(server: &MockServer) {
        Mock::given(method("GET"))
            .and(path("/drive/v3/files/file-1"))
            .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "id": "file-1", "name": "file-1", "mimeType": "text/plain",
                "parents": ["parent-1"], "trashed": true
            })))
            .mount(server)
            .await;
    }

    #[tokio::test]
    async fn gate_refusals_and_folder_boundaries_never_patch() {
        for (mime, parents, rules, expected) in [
            ("text/plain", vec!["parent-1"], vec![], "blocked"),
            (
                "text/plain",
                vec!["parent-1"],
                vec![FolderPermissionRule::folder("parent-1").denying([DriveOperation::Trash])],
                "blocked",
            ),
            (
                "text/plain",
                vec!["parent-1"],
                vec![
                    allow(),
                    FolderPermissionRule::file("file-1").denying([DriveOperation::Trash]),
                ],
                "blocked",
            ),
            (
                "text/plain",
                vec![],
                vec![allow()],
                "refused-no-visible-parents",
            ),
            (
                GOOGLE_FOLDER_MIME_TYPE,
                vec!["parent-1"],
                vec![FolderPermissionRule::file("file-1").allowing([DriveOperation::Trash])],
                "refused-folder",
            ),
        ] {
            for restore in [false, true] {
                let server = MockServer::start().await;
                let client = client_with_bootstrapped_token(&server).await;
                mount_file("file-1", mime, &parents).mount(&server).await;
                mount_folder("parent-1").mount(&server).await;
                no_patch(&server).await;
                let outcome = trash(&client, &opts(restore, true), &rules).await;
                assert_eq!(outcome.result.log_status(), expected);
            }
        }
    }

    #[tokio::test]
    async fn dry_runs_and_noops_never_patch() {
        for (restore, trashed, dry_run, expected) in [
            (false, false, true, "would-trash"),
            (true, true, true, "would-untrash"),
            (false, true, true, "already-trashed"),
            (true, false, true, "not-trashed"),
        ] {
            let server = MockServer::start().await;
            let client = client_with_bootstrapped_token(&server).await;
            if trashed {
                trashed_file(&server).await;
            } else {
                mount_file("file-1", "text/plain", &["parent-1"])
                    .mount(&server)
                    .await;
            }
            mount_folder("parent-1").mount(&server).await;
            no_patch(&server).await;
            let outcome = trash(&client, &opts(restore, dry_run), &[allow()]).await;
            assert_eq!(outcome.result.log_status(), expected);
            assert_eq!(outcome.resolved_folder_id.as_deref(), Some("parent-1"));
        }
    }

    #[tokio::test]
    async fn noops_are_still_gated() {
        let server = MockServer::start().await;
        let client = client_with_bootstrapped_token(&server).await;
        trashed_file(&server).await;
        mount_folder("parent-1").mount(&server).await;
        no_patch(&server).await;
        let outcome = trash(&client, &opts(false, true), &[]).await;
        assert!(matches!(outcome.result, TrashResult::Blocked { .. }));
    }

    #[tokio::test]
    async fn file_rule_grants_parentless_native_document() {
        let server = MockServer::start().await;
        let client = client_with_bootstrapped_token(&server).await;
        mount_file("file-1", "application/vnd.google-apps.spreadsheet", &[])
            .mount(&server)
            .await;
        no_patch(&server).await;
        let rule = FolderPermissionRule::file("file-1").allowing([DriveOperation::Trash]);
        let outcome = trash(&client, &opts(false, true), &[rule]).await;
        assert!(matches!(outcome.result, TrashResult::WouldTrash));
        assert_eq!(outcome.resolved_folder_id, None);
    }

    #[tokio::test]
    async fn ancestor_allow_and_multiple_parent_deny_use_the_shared_gate() {
        let server = MockServer::start().await;
        let client = client_with_bootstrapped_token(&server).await;
        mount_file("file-1", "text/plain", &["parent-1", "parent-2"])
            .mount(&server)
            .await;
        mount_folder("parent-1").mount(&server).await;
        mount_file("parent-2", GOOGLE_FOLDER_MIME_TYPE, &["parent-1"])
            .mount(&server)
            .await;
        no_patch(&server).await;
        let rules = [allow().recursive(true)];
        let outcome = trash(&client, &opts(false, true), &rules).await;
        assert!(matches!(outcome.result, TrashResult::WouldTrash));
        assert_eq!(outcome.resolved_folder_id, None);
        let rules = [
            allow().recursive(true),
            FolderPermissionRule::folder("parent-2").denying([DriveOperation::Trash]),
        ];
        let outcome = trash(&client, &opts(false, true), &rules).await;
        assert!(matches!(outcome.result, TrashResult::Blocked { .. }));
    }

    #[tokio::test]
    async fn metadata_and_ancestry_errors_never_patch() {
        for failed_id in ["file-1", "parent-1"] {
            let server = MockServer::start().await;
            let client = client_with_bootstrapped_token(&server).await;
            if failed_id == "parent-1" {
                mount_file("file-1", "text/plain", &["parent-1"])
                    .mount(&server)
                    .await;
            }
            Mock::given(method("GET"))
                .and(path(format!("/drive/v3/files/{failed_id}")))
                .respond_with(ResponseTemplate::new(500).set_body_string("lookup failed"))
                .mount(&server)
                .await;
            no_patch(&server).await;
            let outcome = trash(&client, &opts(false, true), &[allow()]).await;
            assert!(matches!(outcome.result, TrashResult::Failed { .. }));
        }
    }

    #[tokio::test]
    async fn missing_requested_state_never_reports_a_noop_or_patches() {
        let server = MockServer::start().await;
        let client = client_with_bootstrapped_token(&server).await;
        Mock::given(method("GET"))
            .and(path("/drive/v3/files/file-1"))
            .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
                "id": "file-1", "name": "file-1", "mimeType": "text/plain"
            })))
            .mount(&server)
            .await;
        no_patch(&server).await;
        let rules = [FolderPermissionRule::file("file-1").allowing([DriveOperation::Trash])];
        for restore in [false, true] {
            let outcome = trash(&client, &opts(restore, true), &rules).await;
            assert!(
                matches!(outcome.result, TrashResult::Failed { ref detail } if detail.contains("omitted"))
            );
        }
    }

    #[tokio::test]
    async fn successful_patch_must_confirm_the_requested_state() {
        let _env = crate::drive::test_support::EnvGuard::take();
        let dir = tempfile::tempdir().unwrap();
        let log_path = dir.path().join("mutations.jsonl");
        let _log =
            crate::utils::env::ScopedEnvVar::set("OMNI_DEV_LOG_FILE", log_path.to_str().unwrap());
        for (restore, returned) in [(true, Some(true)), (false, Some(false)), (true, None)] {
            let server = MockServer::start().await;
            let client = client_with_bootstrapped_token(&server).await;
            if restore {
                trashed_file(&server).await;
            } else {
                mount_file("file-1", "text/plain", &["parent-1"])
                    .mount(&server)
                    .await;
            }
            mount_folder("parent-1").mount(&server).await;
            Mock::given(method("PATCH"))
                .and(path("/drive/v3/files/file-1"))
                .and(body_json(serde_json::json!({"trashed": !restore})))
                .respond_with(ResponseTemplate::new(200).set_body_json(serde_json::json!({
                    "id": "file-1", "name": "file-1", "trashed": returned
                })))
                .expect(1)
                .mount(&server)
                .await;
            let outcome = trash(&client, &opts(restore, false), &[allow()]).await;
            assert!(
                matches!(outcome.result, TrashResult::Failed { ref detail } if detail.contains("did not confirm")),
                "{outcome:?}"
            );
        }
    }

    #[tokio::test]
    async fn mutations_noops_failures_and_previews_record_the_expected_log() {
        let _env = crate::drive::test_support::EnvGuard::take();
        let dir = tempfile::tempdir().unwrap();
        let log_path = dir.path().join("mutations.jsonl");
        let _log =
            crate::utils::env::ScopedEnvVar::set("OMNI_DEV_LOG_FILE", log_path.to_str().unwrap());
        let _enabled = crate::utils::env::ScopedEnvVar::set("OMNI_DEV_LOG_DISABLE", "false");
        for (restore, trashed, dry_run, code, expected, count) in [
            (false, false, false, 200, "trashed", 1),
            (true, true, false, 200, "untrashed", 1),
            (false, false, false, 403, "failed", 1),
            (true, true, false, 403, "failed", 1),
            (false, true, false, 200, "already-trashed", 0),
            (true, false, false, 200, "not-trashed", 0),
            (false, false, true, 200, "would-trash", 0),
            (false, false, false, 200, "blocked", 0),
        ] {
            std::fs::write(&log_path, "").unwrap();
            // Other engine tests can log concurrently without changing env vars.
            // Exercise that contamination explicitly, even for a serial run.
            request_log::record_drive_mutation(DriveMutationOutcome {
                operation: "edit",
                file_id: "file-1".into(),
                status: "edited".into(),
                ..Default::default()
            });
            let server = MockServer::start().await;
            let client = client_with_bootstrapped_token(&server).await;
            if trashed {
                trashed_file(&server).await;
            } else {
                mount_file("file-1", "text/plain", &["parent-1"])
                    .mount(&server)
                    .await;
            }
            mount_folder("parent-1").mount(&server).await;
            Mock::given(method("PATCH"))
                .and(path("/drive/v3/files/file-1"))
                .and(query_param("supportsAllDrives", "true"))
                .and(body_json(serde_json::json!({"trashed": !restore})))
                .respond_with(
                    ResponseTemplate::new(code).set_body_json(serde_json::json!({
                        "id": "file-1", "name": "file-1", "trashed": !restore,
                        "error": {"message": "permission denied"}
                    })),
                )
                .expect(count)
                .mount(&server)
                .await;
            let rules = if expected == "blocked" {
                vec![]
            } else {
                vec![allow()]
            };
            assert!(allow().require_lease);
            let outcome = trash(&client, &opts(restore, dry_run), &rules).await;
            assert_eq!(outcome.result.log_status(), expected, "{outcome:?}");
            let records: Vec<serde_json::Value> = std::fs::read_to_string(&log_path)
                .unwrap()
                .lines()
                .map(|line| serde_json::from_str(line).unwrap())
                .filter(|rec: &serde_json::Value| {
                    rec["kind"] == "drivemutation"
                        && rec["context"]["file_id"] == "file-1"
                        && rec["command"]
                            == serde_json::json!([
                                "drive",
                                if restore { "untrash" } else { "trash" }
                            ])
                })
                .collect();
            assert_eq!(records.len(), usize::from(!dry_run));
            if !dry_run {
                assert_eq!(records[0]["context"]["status"], expected);
                assert_eq!(records[0]["context"]["file_id"], "file-1");
                assert_eq!(
                    records[0]["command"][1],
                    if restore { "untrash" } else { "trash" }
                );
                if expected == "failed" {
                    assert!(records[0]["error"].as_str().unwrap().contains("403"));
                }
            }
        }
    }
}