neser 1.2.0

NESER - Nintendo Emulation Systems Engine (Rust). Desktop and WebAssembly frontends.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
//! Mapper 040 - NTDEC 2722 (Super Mario Bros. 2 Japanese)
//!
//! Known Limitations:
//! - Submapper 1 (NTDEC 2752 multicart outer bank register) not implemented.
//!
//! Specification: <https://www.nesdev.org/wiki/INES_Mapper_040>

use crate::nes::cartridge::BaseMapper;
use crate::nes::cartridge::{Mapper, MapperCapabilities};

use crate::nes::cartridge::cpu_cycle_irq::{CpuCycleIrq, CpuCycleIrqMode};

/// Mapper 040 - NTDEC 2722
///
/// Hardware: NTDEC 2722 PCB, used in Super Mario Bros. 2 (Japanese) conversions.
///
/// Specifications:
/// - Main: <https://www.nesdev.org/wiki/INES_Mapper_040>
/// - PRG-ROM: 64KB (8 × 8KB banks, with specific fixed and switchable windows)
/// - CHR: 8KB fixed CHR-ROM (no banking)
/// - Mirroring: Fixed from ROM header
///
/// PRG window map (8KB each):
/// - $6000-$7FFF: Fixed bank 6
/// - $8000-$9FFF: Fixed bank 4
/// - $A000-$BFFF: Fixed bank 5
/// - $C000-$DFFF: Switchable (via $E000 write)
/// - $E000-$FFFF: Fixed bank 7
///
/// Register map (range $8000-$FFFF, mask $E000):
/// - $8000: Disable and acknowledge IRQ
/// - $A000: Enable IRQ (counter resets to 0, starts counting)
/// - $E000: Select 8KB PRG bank for $C000 window (bits 2:0)
///
/// IRQ: CD4020 CPU-cycle counter; fires after 4096 cycles, self-acks at 8192.
///
/// Known games: Super Mario Bros. 2 (Japanese, aka The Lost Levels)
pub struct Ntdec2722Mapper {
    base: BaseMapper,
    /// Switchable bank index for the $C000-$DFFF window.
    prg_bank: u8,
    irq: CpuCycleIrq,
}

impl Ntdec2722Mapper {
    const PRG_BANK_SIZE: usize = 0x2000; // 8KB

    // Fixed PRG window bank assignments (hardwired per spec)
    const BANK_AT_6000: usize = 6;

    pub fn new(ctx: crate::nes::cartridge::mapper::MapperContext) -> Self {
        let mirroring = ctx.mirroring;
        let capabilities = MapperCapabilities {
            has_irq: true,
            prg_bank_size_kb: 8,
            chr_bank_size_kb: 8,
            ..Default::default()
        };

        let mut base = BaseMapper::new(&ctx, capabilities);
        base.configure_prg_banking(Self::PRG_BANK_SIZE);
        base.configure_prg_6000_banking();
        base.set_mirroring(mirroring);

        let mut mapper = Self {
            base,
            prg_bank: 0,
            irq: CpuCycleIrq::new(CpuCycleIrqMode::UpSelfAck {
                fire_count: 4096,
                ack_count: 8192,
            }),
        };

        mapper.update_banks();
        mapper
    }

    fn update_banks(&mut self) {
        // $6000-$7FFF: fixed bank 6
        self.base.select_prg_6000_page(Self::BANK_AT_6000 as i16);

        // $8000=bank4, $A000=bank5, $C000=switchable, $E000=bank7
        self.base.select_prg_page(0, 4);
        self.base.select_prg_page(1, 5);
        self.base.select_prg_page(2, self.prg_bank as i16);
        self.base.select_prg_page(3, 7);
    }
}

impl Mapper for Ntdec2722Mapper {
    fn base(&self) -> &BaseMapper {
        &self.base
    }
    fn base_mut(&mut self) -> &mut BaseMapper {
        &mut self.base
    }

    fn write_prg(&mut self, addr: u16, value: u8) {
        match addr & 0xE000 {
            0x8000 => {
                // Disable and acknowledge IRQ
                self.irq.set_enabled(false);
                self.irq.acknowledge();
                self.irq.set_counter(0);
            }
            0xA000 => {
                // Enable IRQ, reset counter
                self.irq.set_enabled(true);
                self.irq.set_counter(0);
            }
            0xE000 => {
                // Select 8KB PRG bank for $C000 window
                self.prg_bank = value;
                self.update_banks();
            }
            _ => {}
        }
    }

    fn cpu_cycle(&mut self) {
        self.irq.tick();
    }

    fn irq_pending(&self) -> bool {
        self.irq.is_pending()
    }

    fn registers_snapshot(&self) -> Vec<u8> {
        let flags = (self.irq.enabled() as u8) | ((self.irq.is_pending() as u8) << 1);
        vec![
            self.prg_bank,
            flags,
            (self.irq.counter() & 0xFF) as u8,
            (self.irq.counter() >> 8) as u8,
        ]
    }

    fn restore_registers(&mut self, data: &[u8]) {
        if data.len() >= 4 {
            self.prg_bank = data[0];
            self.irq.set_enabled((data[1] & 1) != 0);
            self.irq.set_pending((data[1] & 2) != 0);
            self.irq
                .set_counter((data[2] as u16) | ((data[3] as u16) << 8));
            self.update_banks();
        }
    }
}

#[cfg(test)]
mod tests {
    use super::Ntdec2722Mapper;
    use crate::nes::cartridge::NametableLayout;
    use crate::nes::cartridge::mapper::{Mapper, MapperContext, create_mapper};
    use crate::nes::cartridge::test_helpers::banked_data;

    // 11 banks × 8KB = non-power-of-two to prevent false-pass wrapping.
    const PRG_BANKS: usize = 11;
    const CHR_BANKS: usize = 1; // 8KB fixed

    fn make_mapper() -> Box<dyn Mapper> {
        let prg_rom = banked_data(8 * 1024, PRG_BANKS);
        let chr_rom = banked_data(8 * 1024, CHR_BANKS);
        create_mapper(MapperContext::new_for_test(
            40,
            prg_rom,
            chr_rom,
            NametableLayout::Vertical,
        ))
        .expect("Mapper 40 should be implemented")
    }

    fn make_mapper_direct() -> Ntdec2722Mapper {
        let prg_rom = banked_data(8 * 1024, PRG_BANKS);
        let chr_rom = banked_data(8 * 1024, CHR_BANKS);
        Ntdec2722Mapper::new(MapperContext::new_for_test(
            40,
            prg_rom,
            chr_rom,
            NametableLayout::Vertical,
        ))
    }

    // --- Factory ---

    #[test]
    fn mapper_40_is_registered_in_factory() {
        // create_mapper should return Some for mapper id 40
        let prg_rom = banked_data(8 * 1024, PRG_BANKS);
        let chr_rom = banked_data(8 * 1024, CHR_BANKS);
        let result = create_mapper(MapperContext::new_for_test(
            40,
            prg_rom,
            chr_rom,
            NametableLayout::Vertical,
        ));
        assert!(
            result.is_ok(),
            "Mapper 40 must be registered in the factory"
        );
    }

    // --- PRG banking ---

    #[test]
    fn prg_bank4_is_fixed_at_8000() {
        // With 11-bank ROM, bank 4 is filled with 0x04.
        let mapper = make_mapper();
        assert_eq!(
            mapper.read_prg(0x8000),
            4,
            "$8000 window must be hardwired to PRG bank 4"
        );
    }

    #[test]
    fn prg_bank5_is_fixed_at_a000() {
        let mapper = make_mapper();
        assert_eq!(
            mapper.read_prg(0xA000),
            5,
            "$A000 window must be hardwired to PRG bank 5"
        );
    }

    #[test]
    fn prg_bank6_is_fixed_at_6000() {
        let mapper = make_mapper();
        assert_eq!(
            mapper.read_prg(0x6000),
            6,
            "$6000 window must be hardwired to PRG bank 6"
        );
    }

    #[test]
    fn prg_bank7_is_fixed_at_e000() {
        let mapper = make_mapper();
        assert_eq!(
            mapper.read_prg(0xE000),
            7,
            "$E000 window must be hardwired to PRG bank 7"
        );
    }

    #[test]
    fn prg_c000_is_switchable_via_e000_register() {
        let mut mapper = make_mapper();
        // Select bank 3 for the $C000 window
        mapper.write_prg(0xE000, 3);
        assert_eq!(
            mapper.read_prg(0xC000),
            3,
            "$C000 window must map to the bank selected by $E000 register"
        );
    }

    #[test]
    fn prg_c000_bank_selection_wraps() {
        // With 11 banks, bank 11 wraps to bank 0.
        let mut mapper = make_mapper();
        mapper.write_prg(0xE000, 11);
        assert_eq!(
            mapper.read_prg(0xC000),
            0,
            "$C000 bank register must wrap around total bank count (11 % 11 = 0)"
        );
    }

    #[test]
    fn prg_read_offset_within_bank_is_correct() {
        // Bank 4 is all 0x04; the last byte of the window should also be 0x04.
        let mapper = make_mapper();
        assert_eq!(
            mapper.read_prg(0x9FFF),
            4,
            "last byte of $8000 window must still be bank 4"
        );
    }

    // --- Mirroring ---

    #[test]
    fn mirroring_is_preserved_from_header() {
        let prg_rom = banked_data(8 * 1024, PRG_BANKS);
        let chr_rom = banked_data(8 * 1024, CHR_BANKS);
        let mapper = Ntdec2722Mapper::new(MapperContext::new_for_test(
            40,
            prg_rom,
            chr_rom,
            NametableLayout::Horizontal,
        ));
        assert_eq!(mapper.get_mirroring(), NametableLayout::Horizontal);
    }

    // --- IRQ ---

    #[test]
    fn irq_not_pending_initially() {
        let mapper = make_mapper_direct();
        assert!(!mapper.irq_pending(), "IRQ must not be pending on power-on");
    }

    #[test]
    fn irq_fires_after_4096_cpu_cycles() {
        let mut mapper = make_mapper_direct();
        mapper.write_prg(0xA000, 0); // enable IRQ
        for _ in 0..4096 {
            mapper.cpu_cycle();
        }
        assert!(mapper.irq_pending(), "IRQ must fire after 4096 CPU cycles");
    }

    #[test]
    fn irq_does_not_fire_before_4096_cycles() {
        let mut mapper = make_mapper_direct();
        mapper.write_prg(0xA000, 0); // enable IRQ
        for _ in 0..4095 {
            mapper.cpu_cycle();
        }
        assert!(
            !mapper.irq_pending(),
            "IRQ must NOT fire before 4096 CPU cycles have elapsed"
        );
    }

    #[test]
    fn irq_acknowledged_and_disabled_by_8000_write() {
        let mut mapper = make_mapper_direct();
        mapper.write_prg(0xA000, 0); // enable IRQ
        for _ in 0..4096 {
            mapper.cpu_cycle();
        }
        assert!(mapper.irq_pending(), "IRQ should be pending before ack");
        mapper.write_prg(0x8000, 0); // disable + ack
        assert!(
            !mapper.irq_pending(),
            "IRQ must be cleared after $8000 write"
        );
    }

    #[test]
    fn irq_counter_resets_when_re_enabled() {
        // After ack, re-enabling should restart the 4096-cycle count from zero.
        let mut mapper = make_mapper_direct();
        mapper.write_prg(0xA000, 0); // enable
        for _ in 0..4096 {
            mapper.cpu_cycle();
        }
        mapper.write_prg(0x8000, 0); // ack
        mapper.write_prg(0xA000, 0); // re-enable
        // 4095 more cycles should NOT fire
        for _ in 0..4095 {
            mapper.cpu_cycle();
        }
        assert!(
            !mapper.irq_pending(),
            "IRQ must not fire until 4096 cycles after re-enable"
        );
    }

    #[test]
    fn irq_self_acknowledges_at_8192_cycles() {
        // The CD4020 counter bit 13 fires at 8192 and clears the IRQ line.
        let mut mapper = make_mapper_direct();
        mapper.write_prg(0xA000, 0); // enable
        for _ in 0..8192 {
            mapper.cpu_cycle();
        }
        assert!(
            !mapper.irq_pending(),
            "IRQ must self-acknowledge after 8192 CPU cycles (CD4020 bit 13)"
        );
    }

    // --- Registers snapshot ---

    #[test]
    fn registers_snapshot_and_restore() {
        let prg_rom = banked_data(8 * 1024, PRG_BANKS);
        let chr_rom = banked_data(8 * 1024, CHR_BANKS);
        let mut mapper = Ntdec2722Mapper::new(MapperContext::new_for_test(
            40,
            prg_rom.clone(),
            chr_rom.clone(),
            NametableLayout::Vertical,
        ));

        // Set up state
        mapper.write_prg(0xE000, 2); // $C000 bank = 2
        mapper.write_prg(0xA000, 0); // enable IRQ
        for _ in 0..100 {
            mapper.cpu_cycle();
        }

        let snap = mapper.registers_snapshot();

        let mut restored = Ntdec2722Mapper::new(MapperContext::new_for_test(
            40,
            prg_rom,
            chr_rom,
            NametableLayout::Vertical,
        ));
        restored.restore_registers(&snap);

        assert_eq!(
            restored.read_prg(0xC000),
            2,
            "Restored $C000 bank must match snapshotted value"
        );
        assert!(
            restored.irq_pending() == mapper.irq_pending(),
            "Restored IRQ pending state must match"
        );
    }
}