neser 1.2.0

NESER - Nintendo Emulation Systems Engine (Rust). Desktop and WebAssembly frontends.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
//! Mapper 188 – Bandai Karaoke Studio
//!
//! Known Limitations:
//! - Microphone ADC input is not emulated (always returns "not pressed / no signal").

use crate::nes::cartridge::base_mapper::BaseMapper;
use crate::nes::cartridge::common::ChrMemory;
use crate::nes::cartridge::mapper::{Mapper, MapperCapabilities, MapperContext};

#[allow(dead_code)]
const MAPPER_NUMBER: u16 = 188;
const PRG_BANK_SIZE: usize = 16 * 1024;
const CHR_RAM_SIZE: usize = 8 * 1024;
/// Number of internal ROM 16 KiB banks (128 KiB cartridge ROM = 8 banks)
const INTERNAL_ROM_BANKS: i16 = 8;
/// Fixed page (last internal bank)
const LAST_INTERNAL_BANK: i16 = INTERNAL_ROM_BANKS - 1;

/// Mapper 188 – Bandai Karaoke Studio (Karaoke Studio cartridge)
///
/// Hardware: Bandai FCG-1 / FCG-2 based Karaoke cartridge.
///
/// Specifications:
/// - Main: <https://www.nesdev.org/wiki/INES_Mapper_188>
/// - PRG-ROM: Up to 128 KiB internal + 128 KiB on expansion cartridge (16 × 16 KiB total)
/// - PRG-ROM page at $8000–$BFFF: switchable 16 KiB bank
/// - PRG-ROM page at $C000$FFFF: fixed to last bank of internal ROM (bank 7)
/// - CHR: 8 KiB CHR-RAM, fixed at bank 0
/// - Mirroring: software-controlled Vertical / Horizontal
/// - Bus conflicts: yes
/// - $6000–$7FFF: read returns microphone / button status (not writable)
///
/// Register layout (write to $8000–$FFFF):
///
/// ```text
/// 7  bit  0
/// ---- ----
/// .LXR BBBB
/// ||||||||
/// ||||++++— PRG bank select for $8000–$BFFF (3 bits used: B2..B0)
/// |||+————— R: 0 = external ROM chip, 1 = internal ROM chip
/// ||+—————— X: CIRAM A10 — 0 = PPU A10 (Vertical), 1 = PPU A11 (Horizontal)
/// |+——————— L: 1-bit latch, present but unused
/// +———————— Unused
/// ```
///
/// Microphone register ($6000–$7FFF, read-only):
///
/// ```text
/// 7  bit  0
/// ---- ----
/// xxxx xMBA
///       |||
///       ||+— A button: 0 = pressed
///       |+—— B button: 0 = pressed
///       +——— Microphone ADC input
/// ```
///
/// This emulator returns 0x03 (A + B not pressed, no microphone signal).
pub struct Mapper188 {
    base: BaseMapper,
    prg_bank: u8,
    internal_selected: bool,
    mirroring_horizontal: bool,
    has_expansion_rom: bool,
}

impl Mapper188 {
    pub fn new(ctx: MapperContext) -> Self {
        let has_expansion_rom = ctx.prg_rom.len() >= 2 * 128 * 1024;
        let capabilities = MapperCapabilities {
            has_chr_banking: false,
            has_dynamic_mirroring: true,
            prg_bank_size_kb: PRG_BANK_SIZE / 1024,
            chr_bank_size_kb: CHR_RAM_SIZE / 1024,
            max_prg_ram_kb: 0,
            ..Default::default()
        };
        let mut base = BaseMapper::new(&ctx, capabilities);
        base.configure_prg_banking(PRG_BANK_SIZE);
        base.set_chr_memory(ChrMemory::new_ram(CHR_RAM_SIZE));
        base.set_bus_conflicts(true);

        let mut mapper = Self {
            base,
            prg_bank: 0,
            internal_selected: true,
            mirroring_horizontal: false,
            has_expansion_rom,
        };
        mapper.update_banks();
        mapper
    }

    fn update_banks(&mut self) {
        let bank_8000 = if self.internal_selected {
            self.prg_bank as i16
        } else if self.has_expansion_rom {
            (self.prg_bank as i16) | INTERNAL_ROM_BANKS
        } else {
            // No expansion ROM — $8000-$BFFF is open bus; use a dummy mapping (intercepted in read)
            0
        };
        self.base.select_prg_page(0, bank_8000);
        self.base.select_prg_page(1, LAST_INTERNAL_BANK);
        self.base.set_mirroring_hv(self.mirroring_horizontal);
    }

    /// Returns true when reads from $8000–$BFFF should return open bus.
    fn is_8000_open_bus(&self) -> bool {
        !self.internal_selected && !self.has_expansion_rom
    }
}

impl Mapper for Mapper188 {
    fn base(&self) -> &BaseMapper {
        &self.base
    }

    fn base_mut(&mut self) -> &mut BaseMapper {
        &mut self.base
    }

    fn read_prg(&self, addr: u16) -> u8 {
        match addr {
            0x6000..=0x7FFF => 0x03,
            0x8000..=0xBFFF if self.is_8000_open_bus() => 0,
            0x8000..=0xFFFF => self.base.read_prg_banked(addr),
            _ => 0,
        }
    }

    fn read_prg_open_bus(&self, addr: u16, open_bus: u8) -> u8 {
        match addr {
            0x6000..=0x7FFF => 0x03,
            0x8000..=0xBFFF if self.is_8000_open_bus() => open_bus,
            0x8000..=0xFFFF => self.base.read_prg_banked(addr),
            _ => open_bus,
        }
    }

    fn write_prg(&mut self, addr: u16, value: u8) {
        if addr >= 0x8000 {
            // Skip bus-conflict masking when $8000-$BFFF is open bus (no expansion ROM):
            // there is no ROM driving the bus, so the write value passes through unchanged.
            let effective = if addr < 0xC000 && self.is_8000_open_bus() {
                value
            } else {
                self.base.apply_bus_conflict(addr, value)
            };
            self.prg_bank = effective & 0x07;
            self.internal_selected = (effective & 0x10) != 0;
            self.mirroring_horizontal = (effective & 0x20) != 0;
            self.update_banks();
        }
    }

    fn reset(&mut self) {
        self.prg_bank = 0;
        self.internal_selected = true;
        self.mirroring_horizontal = false;
        self.update_banks();
    }

    fn registers_snapshot(&self) -> Vec<u8> {
        vec![
            self.prg_bank,
            self.internal_selected as u8,
            self.mirroring_horizontal as u8,
        ]
    }

    fn restore_registers(&mut self, data: &[u8]) {
        if data.len() < 3 {
            return;
        }
        self.prg_bank = data[0] & 0x07;
        self.internal_selected = data[1] != 0;
        self.mirroring_horizontal = data[2] != 0;
        self.update_banks();
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::nes::cartridge::NametableLayout;
    use crate::nes::cartridge::mapper::{MapperContext, create_mapper};

    /// Bank ID offset within a 16 KiB bank used for identification in reads.
    const BANK_ID_OFFSET: u16 = 0x100;

    /// Build a PRG-ROM with all bytes set to 0xFF (so bus-conflict AND is transparent).
    /// The bank index (mod 256) is stored at offset BANK_ID_OFFSET within each bank.
    fn make_prg_rom(bank_count: usize) -> Vec<u8> {
        let mut rom = vec![0xFF_u8; PRG_BANK_SIZE * bank_count];
        for bank in 0..bank_count {
            rom[bank * PRG_BANK_SIZE + BANK_ID_OFFSET as usize] = bank as u8;
        }
        rom
    }

    fn make_internal_only_mapper() -> Mapper188 {
        let ctx = MapperContext::new_for_test(
            MAPPER_NUMBER,
            make_prg_rom(8),
            vec![],
            NametableLayout::Vertical,
        )
        .with_prg_ram_banks(0);
        Mapper188::new(ctx)
    }

    fn make_with_expansion_mapper() -> Mapper188 {
        // 256 KiB ROM: 8 banks internal + 8 banks expansion
        let ctx = MapperContext::new_for_test(
            MAPPER_NUMBER,
            make_prg_rom(16),
            vec![],
            NametableLayout::Vertical,
        )
        .with_prg_ram_banks(0);
        Mapper188::new(ctx)
    }

    /// Read bank identifier from a 16 KiB window at window_base.
    fn read_bank_id(mapper: &Mapper188, window_base: u16) -> u8 {
        mapper.read_prg(window_base + BANK_ID_OFFSET)
    }

    // ── Registration ──────────────────────────────────────────────────────────

    #[test]
    fn mapper_188_is_registered() {
        let result = create_mapper(MapperContext::new_for_test(
            MAPPER_NUMBER,
            make_prg_rom(8),
            vec![],
            NametableLayout::Vertical,
        ));
        assert!(
            result.is_ok(),
            "Mapper 188 must be registered in the factory"
        );
    }

    // ── Power-on state ────────────────────────────────────────────────────────

    #[test]
    fn power_on_page0_is_bank0_internal() {
        let mapper = make_internal_only_mapper();
        assert_eq!(read_bank_id(&mapper, 0x8000), 0, "$8000 must map to bank 0");
    }

    #[test]
    fn power_on_page1_fixed_to_last_internal_bank() {
        let mapper = make_internal_only_mapper();
        assert_eq!(
            read_bank_id(&mapper, 0xC000),
            7,
            "$C000 must map to bank 7 (last internal)"
        );
    }

    #[test]
    fn power_on_mirroring_is_vertical() {
        let mapper = make_internal_only_mapper();
        assert_eq!(mapper.get_mirroring(), NametableLayout::Vertical);
    }

    // ── Internal ROM bank switching ───────────────────────────────────────────

    #[test]
    fn write_selects_internal_bank() {
        let mut mapper = make_internal_only_mapper();
        // bit4=1 = internal ROM, bits2:0 = bank 3; all bytes are 0xFF so bus conflict is transparent
        mapper.write_prg(0x8000, 0x13);
        assert_eq!(read_bank_id(&mapper, 0x8000), 3);
    }

    #[test]
    fn page1_stays_fixed_after_bank_switch() {
        let mut mapper = make_internal_only_mapper();
        mapper.write_prg(0x8000, 0x15); // bank 5, internal
        assert_eq!(
            read_bank_id(&mapper, 0xC000),
            7,
            "page 1 must stay at last internal bank"
        );
    }

    #[test]
    fn internal_banks_0_through_7_accessible() {
        let mut mapper = make_internal_only_mapper();
        for bank in 0u8..8 {
            mapper.write_prg(0x8000, 0x10 | bank); // bit4=1 = internal
            assert_eq!(
                read_bank_id(&mapper, 0x8000),
                bank,
                "internal bank {bank} not accessible"
            );
        }
    }

    // ── External ROM ──────────────────────────────────────────────────────────

    #[test]
    fn external_bank_selection_with_expansion_rom() {
        let mut mapper = make_with_expansion_mapper();
        // bit4=0 = external ROM, bits2:0 = bank 2 → absolute bank 10 (8+2)
        mapper.write_prg(0x8000, 0x02);
        assert_eq!(read_bank_id(&mapper, 0x8000), 10);
    }

    #[test]
    fn page1_fixed_to_internal_even_with_expansion_selected() {
        let mut mapper = make_with_expansion_mapper();
        mapper.write_prg(0x8000, 0x03); // external, bank 3
        assert_eq!(
            read_bank_id(&mapper, 0xC000),
            7,
            "page 1 must remain at last internal bank"
        );
    }

    #[test]
    fn external_open_bus_without_expansion_rom() {
        let mut mapper = make_internal_only_mapper();
        // Select external ROM (bit4=0) but no expansion ROM present
        mapper.write_prg(0x8000, 0x00);
        // read_prg_open_bus must return open_bus value
        assert_eq!(mapper.read_prg_open_bus(0x8000, 0xAB), 0xAB);
    }

    // ── Mirroring ─────────────────────────────────────────────────────────────

    #[test]
    fn write_bit5_set_selects_horizontal_mirroring() {
        let mut mapper = make_internal_only_mapper();
        // bit5=1 → horizontal, bit4=1 → internal
        mapper.write_prg(0x8000, 0x30);
        assert_eq!(mapper.get_mirroring(), NametableLayout::Horizontal);
    }

    #[test]
    fn write_bit5_clear_selects_vertical_mirroring() {
        let mut mapper = make_internal_only_mapper();
        mapper.write_prg(0x8000, 0x30); // set horizontal first
        mapper.write_prg(0x8000, 0x10); // clear bit5 → vertical
        assert_eq!(mapper.get_mirroring(), NametableLayout::Vertical);
    }

    // ── Bus conflicts ─────────────────────────────────────────────────────────

    #[test]
    fn bus_conflict_masks_write_value_with_rom() {
        // Build ROM where first byte of bank 0 is 0x07 (not 0xFF)
        let mut prg = make_prg_rom(8);
        prg[0] = 0x07; // $8000 in bank 0 has 0x07
        let ctx =
            MapperContext::new_for_test(MAPPER_NUMBER, prg, vec![], NametableLayout::Vertical)
                .with_prg_ram_banks(0);
        let mut mapper = Mapper188::new(ctx);
        // Write 0xFF; bus conflict: 0xFF & 0x07 = 0x07; bit4=0 → external; bits2:0 = 7
        // No expansion ROM → open bus for $8000-$BFFF
        mapper.write_prg(0x8000, 0xFF);
        assert_eq!(
            mapper.read_prg_open_bus(0x8000, 0xAB),
            0xAB,
            "bus conflict should yield external mode"
        );
    }

    // ── Microphone register ───────────────────────────────────────────────────

    #[test]
    fn read_6000_returns_microphone_idle() {
        let mapper = make_internal_only_mapper();
        assert_eq!(mapper.read_prg(0x6000), 0x03, "A+B not pressed, no mic");
        assert_eq!(mapper.read_prg(0x7FFF), 0x03);
    }

    #[test]
    fn open_bus_read_6000_returns_microphone_not_open_bus() {
        let mapper = make_internal_only_mapper();
        // Microphone register overrides open bus
        assert_eq!(mapper.read_prg_open_bus(0x6000, 0xDE), 0x03);
    }

    // ── Snapshot / restore ────────────────────────────────────────────────────

    #[test]
    fn snapshot_restore_preserves_state() {
        let mut mapper = make_internal_only_mapper();
        mapper.write_prg(0x8000, 0x35); // bit5=1 horizontal, bit4=1 internal, bank 5
        let snapshot = mapper.registers_snapshot();

        let mut restored = make_internal_only_mapper();
        restored.restore_registers(&snapshot);

        assert_eq!(
            read_bank_id(&restored, 0x8000),
            read_bank_id(&mapper, 0x8000)
        );
        assert_eq!(
            read_bank_id(&restored, 0xC000),
            read_bank_id(&mapper, 0xC000)
        );
        assert_eq!(restored.get_mirroring(), mapper.get_mirroring());
    }

    #[test]
    fn restore_with_too_short_data_is_ignored() {
        let mut mapper = make_internal_only_mapper();
        mapper.write_prg(0x8000, 0x15); // bank 5, internal
        let bank_before = read_bank_id(&mapper, 0x8000);
        mapper.restore_registers(&[0x02]); // too short
        assert_eq!(
            read_bank_id(&mapper, 0x8000),
            bank_before,
            "state must be unchanged after short restore"
        );
    }

    // ── Reset ─────────────────────────────────────────────────────────────────

    #[test]
    fn reset_restores_power_on_state() {
        let mut mapper = make_internal_only_mapper();
        mapper.write_prg(0x8000, 0x35); // horizontal, internal, bank 5
        mapper.reset();
        assert_eq!(read_bank_id(&mapper, 0x8000), 0, "bank must reset to 0");
        assert_eq!(
            read_bank_id(&mapper, 0xC000),
            7,
            "page 1 must stay at last internal bank"
        );
        assert_eq!(
            mapper.get_mirroring(),
            NametableLayout::Vertical,
            "mirroring must reset to Vertical"
        );
    }

    // ── Bus conflict bypass when open bus ──────────────────────────────────────

    #[test]
    fn no_bus_conflict_masking_when_8000_is_open_bus() {
        let mut prg = make_prg_rom(8);
        // Put 0x00 at bank 0 offset 0, which would mask all bits if conflicts applied
        prg[0] = 0x00;
        let ctx =
            MapperContext::new_for_test(MAPPER_NUMBER, prg, vec![], NametableLayout::Vertical)
                .with_prg_ram_banks(0);
        let mut mapper = Mapper188::new(ctx);
        // First select external ROM (no expansion ROM → open bus region)
        // bank 0 byte is 0x00, but since we start internal, bus conflict = 0x00 & 0x00 = 0x00 → external
        mapper.write_prg(0x8000, 0x00); // external selected, no expansion ROM
        assert!(mapper.is_8000_open_bus(), "mapper must be in open-bus mode");
        // Now write 0x10 (internal, bank 0); without bypass this would be 0x10 & ROM = 0, staying external
        mapper.write_prg(0x8000, 0x10);
        // With bypass, value 0x10 passes through, selecting internal ROM bank 0
        assert_eq!(
            read_bank_id(&mapper, 0x8000),
            0,
            "internal bank 0 must be accessible after write with bypass"
        );
    }
}