lisette-semantics 0.3.3

Little language inspired by Rust that compiles to Go
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177

use crate::passes::walk::NodeCtx;
use syntax::ast::{BinaryOperator, Expression};
use syntax::types::Type;

use super::helpers::{bool_literal, is_one_literal, is_side_effect_free, is_zero_literal};

enum Outcome {
    /// The operation returns its other operand unchanged (`x + 0`, `x && true`).
    Identity,
    /// The operation always evaluates to a constant (`x * 0`, `x && false`).
    Constant(&'static str),
}

pub fn check_redundant_operation(expression: &Expression, ctx: &NodeCtx) {
    let Expression::Binary {
        operator,
        left,
        right,
        span,
        ..
    } = expression
    else {
        return;
    };

    let left = left.unwrap_parens();
    let right = right.unwrap_parens();

    let Some((other, outcome)) = classify(*operator, left, right) else {
        return;
    };

    if let Outcome::Constant(value) = outcome {
        if !is_side_effect_free(other) {
            return;
        }
        ctx.sink
            .push(diagnostics::lint::redundant_operation(span, Some(value)));
    } else {
        ctx.sink
            .push(diagnostics::lint::redundant_operation(span, None));
    }
}

fn classify<'a>(
    operator: BinaryOperator,
    left: &'a Expression,
    right: &'a Expression,
) -> Option<(&'a Expression, Outcome)> {
    use BinaryOperator::*;

    if let And | Or = operator {
        return classify_boolean(operator, left, right);
    }

    let (other, outcome) = match operator {
        Addition => {
            if is_zero_literal(right) {
                (left, Outcome::Identity)
            } else if is_zero_literal(left) {
                (right, Outcome::Identity)
            } else {
                return None;
            }
        }
        Subtraction => {
            if is_zero_literal(right) {
                (left, Outcome::Identity)
            } else {
                return None;
            }
        }
        Multiplication => {
            if is_one_literal(right) {
                (left, Outcome::Identity)
            } else if is_one_literal(left) {
                (right, Outcome::Identity)
            } else if is_zero_literal(right) {
                (left, Outcome::Constant("0"))
            } else if is_zero_literal(left) {
                (right, Outcome::Constant("0"))
            } else {
                return None;
            }
        }
        Division => {
            if is_one_literal(right) {
                (left, Outcome::Identity)
            } else {
                return None;
            }
        }
        Remainder => {
            if is_one_literal(right) {
                (left, Outcome::Constant("0"))
            } else {
                return None;
            }
        }
        BitwiseOr | BitwiseXor => {
            if is_zero_literal(right) {
                (left, Outcome::Identity)
            } else if is_zero_literal(left) {
                (right, Outcome::Identity)
            } else {
                return None;
            }
        }
        BitwiseAnd => {
            if is_zero_literal(right) {
                (left, Outcome::Constant("0"))
            } else if is_zero_literal(left) {
                (right, Outcome::Constant("0"))
            } else {
                return None;
            }
        }
        BitwiseAndNot => {
            if is_zero_literal(right) {
                (left, Outcome::Identity)
            } else if is_zero_literal(left) {
                (right, Outcome::Constant("0"))
            } else {
                return None;
            }
        }
        ShiftLeft | ShiftRight => {
            // `0 << n` is not folded to `0`: a negative `n` panics at runtime,
            // so the result is not unconditionally `0`.
            if is_zero_literal(right) {
                (left, Outcome::Identity)
            } else {
                return None;
            }
        }
        _ => return None,
    };

    if !is_integer(&other.get_type()) {
        return None;
    }
    Some((other, outcome))
}

fn classify_boolean<'a>(
    operator: BinaryOperator,
    left: &'a Expression,
    right: &'a Expression,
) -> Option<(&'a Expression, Outcome)> {
    let is_and = matches!(operator, BinaryOperator::And);
    let (other, outcome) = if let Some(value) = bool_literal(right) {
        boolean_outcome(left, value, is_and)
    } else if let Some(value) = bool_literal(left) {
        boolean_outcome(right, value, is_and)
    } else {
        return None;
    };
    if !other.get_type().is_boolean() {
        return None;
    }
    Some((other, outcome))
}

fn boolean_outcome(other: &Expression, literal: bool, is_and: bool) -> (&Expression, Outcome) {
    if is_and == literal {
        (other, Outcome::Identity)
    } else if is_and {
        (other, Outcome::Constant("false"))
    } else {
        (other, Outcome::Constant("true"))
    }
}

fn is_integer(ty: &Type) -> bool {
    ty.as_simple()
        .is_some_and(|kind| kind.is_signed_int() || kind.is_unsigned_int())
}