lisette-semantics 0.3.3

use syntax::ast::{BinaryOperator, Expression};
use syntax::program::CallKind;

use crate::passes::walk::NodeCtx;

use super::helpers::{flip_comparison, is_zero_literal};

pub fn check_non_negative_comparison(expression: &Expression, ctx: &NodeCtx) {
    let Expression::Binary {
        operator,
        left,
        right,
        span,
        ..
    } = expression
    else {
        return;
    };

    use BinaryOperator::*;
    if !matches!(
        operator,
        Equal | NotEqual | LessThan | LessThanOrEqual | GreaterThan | GreaterThanOrEqual
    ) {
        return;
    }

    let operator = match (
        is_native_length_call(left.unwrap_parens()),
        is_native_length_call(right.unwrap_parens()),
    ) {
        (true, false) if is_zero_literal(right.unwrap_parens()) => *operator,
        (false, true) if is_zero_literal(left.unwrap_parens()) => flip_comparison(*operator),
        _ => return,
    };

    let always_true = match operator {
        LessThan => false,
        GreaterThanOrEqual => true,
        _ => return,
    };

    ctx.sink.push(diagnostics::lint::non_negative_comparison(
        span,
        always_true,
    ));
}

fn is_native_length_call(expression: &Expression) -> bool {
    let Expression::Call {
        expression: callee,
        call_kind,
        ..
    } = expression
    else {
        return false;
    };

    if !matches!(
        call_kind,
        Some(CallKind::NativeMethod(_) | CallKind::NativeMethodIdentifier(_))
    ) {
        return false;
    }

    native_method_name(callee.unwrap_parens()) == Some("length")
}

fn native_method_name(callee: &Expression) -> Option<&str> {
    match callee {
        Expression::DotAccess { member, .. } => Some(member),
        Expression::Identifier { value, .. } => {
            Some(value.split_once('.').map_or(value, |(_, m)| m))
        }
        _ => None,
    }
}