lisette-semantics 0.2.17

Little language inspired by Rust that compiles to Go
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103

use diagnostics::LisetteDiagnostic;
use syntax::ast::{Expression, Pattern};
use syntax::program::{CallKind, DotAccessKind};

use crate::facts::Facts;

pub fn check_redundant_closure(
    expression: &Expression,
    facts: &Facts,
    diagnostics: &mut Vec<LisetteDiagnostic>,
) {
    let Expression::Lambda {
        params, body, span, ..
    } = expression
    else {
        return;
    };

    let Expression::Call {
        expression: callee,
        args,
        spread,
        type_args,
        call_kind,
        ..
    } = lambda_body(body)
    else {
        return;
    };

    if !matches!(call_kind, Some(CallKind::Regular))
        || spread.is_some()
        || !type_args.is_empty()
        || args.len() != params.len()
    {
        return;
    }

    let mut param_names = Vec::with_capacity(params.len());
    for (param, arg) in params.iter().zip(args) {
        let Pattern::Identifier { identifier, .. } = &param.pattern else {
            return;
        };
        let Expression::Identifier { value, .. } = arg.unwrap_parens() else {
            return;
        };
        if identifier.as_str() != value.as_str() {
            return;
        }
        param_names.push(identifier.as_str());
    }

    let Some(callee_name) = hoistable_callee(callee.unwrap_parens(), &param_names, facts) else {
        return;
    };

    diagnostics.push(diagnostics::lint::redundant_closure(span, &callee_name));
}

fn lambda_body(body: &Expression) -> &Expression {
    match body.unwrap_parens() {
        Expression::Block { items, .. } if items.len() == 1 => items[0].unwrap_parens(),
        other => other,
    }
}

fn hoistable_callee(callee: &Expression, params: &[&str], facts: &Facts) -> Option<String> {
    // A `mut`-param callee (e.g. `sort.Ints`) is valid only wrapped in a closure,
    // never as a bare function value.
    if callee.get_type().get_param_mutability().iter().any(|m| *m) {
        return None;
    }
    match callee {
        Expression::Identifier {
            value, binding_id, ..
        } => {
            if params.contains(&value.as_str()) {
                return None;
            }
            // A reassignable capture is read lazily by the closure but bound
            // eagerly as a bare reference, so hoisting it would change behavior.
            if let Some(id) = binding_id {
                match facts.bindings.get(id) {
                    Some(binding) if !binding.kind.is_mutable() => {}
                    _ => return None,
                }
            }
            Some(value.to_string())
        }
        Expression::DotAccess {
            expression: base,
            member,
            dot_access_kind: Some(DotAccessKind::ModuleMember),
            ..
        } => {
            let Expression::Identifier { value: base, .. } = base.unwrap_parens() else {
                return None;
            };
            Some(format!("{base}.{member}"))
        }
        _ => None,
    }
}