lisette-semantics 0.2.17

Little language inspired by Rust that compiles to Go
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79

use diagnostics::LisetteDiagnostic;
use syntax::ast::{BinaryOperator, Expression, MatchOrigin, Span};

use crate::checker::infer::expressions::patterns::collect_pattern_bindings;

use super::helpers::{expressions_equivalent, is_empty_block};

pub fn check_identical_match_arms(
    expression: &Expression,
    diagnostics: &mut Vec<LisetteDiagnostic>,
) {
    let Expression::Match {
        subject,
        arms,
        origin,
        span,
        ..
    } = expression
    else {
        return;
    };

    if !matches!(origin, MatchOrigin::Explicit) {
        return;
    }

    if arms.len() < 2 {
        return;
    }

    if !is_safe_to_drop(subject) {
        return;
    }

    // A bound name ties a body to its own arm; a guard makes the arm conditional.
    if arms
        .iter()
        .any(|arm| arm.has_guard() || !collect_pattern_bindings(&arm.pattern).is_empty())
    {
        return;
    }

    let first = &arms[0].expression;

    // Empty blocks are in-progress stubs; `empty_match_arm` covers them.
    if is_empty_block(first) {
        return;
    }

    if !arms[1..]
        .iter()
        .all(|arm| expressions_equivalent(first, &arm.expression))
    {
        return;
    }

    let match_keyword_span = Span::new(span.file_id, span.byte_offset, 5);
    diagnostics.push(diagnostics::lint::identical_match_arms(&match_keyword_span));
}

fn is_safe_to_drop(expression: &Expression) -> bool {
    let expression = expression.unwrap_parens();
    let node_is_safe = match expression {
        Expression::Identifier { .. }
        | Expression::Literal { .. }
        | Expression::Unary { .. }
        | Expression::DotAccess { .. } => true,
        Expression::Binary { operator, .. } => !matches!(
            operator,
            BinaryOperator::Division
                | BinaryOperator::Remainder
                | BinaryOperator::ShiftLeft
                | BinaryOperator::ShiftRight
        ),
        _ => false,
    };

    node_is_safe && expression.children().into_iter().all(is_safe_to_drop)
}