ktstr 0.6.0

Test harness for Linux process schedulers
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
//! Unit tests for [`super`] (the `initramfs` module).
//! Co-located via the `tests` submodule pattern.

#![cfg(test)]

use super::*;

/// Thin test wrapper over [`build_suffix`] that takes only the
/// args tests commonly vary. The remaining [`SuffixParams`] fields
/// default to empty, so assertions stay focused on the args- and
/// sched-args-only suffix shape.
fn build_suffix_args(base_len: usize, args: &[String], sched_args: &[String]) -> Result<Vec<u8>> {
    build_suffix(
        base_len,
        &SuffixParams {
            args,
            sched_args,
            ..Default::default()
        },
    )
}

/// Thin test wrapper that produces a complete cpio newc archive by
/// concatenating [`build_initramfs_base`] and [`build_suffix_args`]
/// output. Production callers build base and suffix separately so
/// they can stream the parts into guest memory without an
/// intermediate `Vec`; the monolithic form is only needed for
/// round-trip archive-shape assertions in tests.
fn build_initramfs(
    payload: &Path,
    extra_binaries: &[(&str, &Path)],
    args: &[String],
) -> Result<Vec<u8>> {
    let base = build_initramfs_base(payload, extra_binaries, &[], false)?;
    let suffix = build_suffix_args(base.len(), args, &[])?;
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    Ok(archive)
}

/// Extract cpio entry names from a newc archive for test assertions.
fn cpio_entry_names(archive: &[u8]) -> Vec<String> {
    let mut names = Vec::new();
    let mut remaining: &[u8] = archive;
    while let Ok(reader) = cpio::newc::Reader::new(remaining) {
        let name = reader.entry().name().to_string();
        if reader.entry().is_trailer() {
            break;
        }
        names.push(name);
        remaining = reader.finish().unwrap();
    }
    names
}

/// Extract cpio entries with name, size, mode, and inode for diagnostics.
fn cpio_entries(archive: &[u8]) -> Vec<(String, u32, u32, u32)> {
    let mut entries = Vec::new();
    let mut remaining: &[u8] = archive;
    while let Ok(reader) = cpio::newc::Reader::new(remaining) {
        if reader.entry().is_trailer() {
            break;
        }
        let name = reader.entry().name().to_string();
        let size = reader.entry().file_size();
        let mode = reader.entry().mode();
        let ino = reader.entry().ino();
        entries.push((name, size, mode, ino));
        remaining = reader.finish().unwrap();
    }
    entries
}

#[test]
fn cpio_header_format() {
    let mut archive = Vec::new();
    write_entry(&mut archive, "test", b"hello", 0o100644).unwrap();
    assert_eq!(&archive[..6], b"070701");
}

#[test]
fn cpio_trailer() {
    let mut archive = Vec::new();
    write_entry(&mut archive, "test", b"data", 0o100755).unwrap();
    cpio::newc::trailer(&mut archive as &mut dyn std::io::Write).unwrap();
    let s = String::from_utf8_lossy(&archive);
    assert!(s.contains("TRAILER!!!"));
}

#[test]
fn build_initramfs_has_init() {
    let exe = crate::resolve_current_exe().unwrap();
    let initrd = build_initramfs(&exe, &[], &[]).unwrap();
    let s = String::from_utf8_lossy(&initrd);
    assert!(s.contains("init"), "should contain init entry");
    assert!(s.contains("TRAILER!!!"));
}

#[test]
fn build_initramfs_base_is_valid_cpio() {
    let exe = crate::resolve_current_exe().unwrap();
    let initrd = build_initramfs_base(&exe, &[], &[], false).unwrap();
    assert_eq!(&initrd[..6], b"070701");
    // Base is NOT 512-aligned on its own; only base+suffix is.
    let full = build_initramfs(&exe, &[], &[]).unwrap();
    assert!(initrd.len() <= full.len());
}

#[test]
fn build_initramfs_padded() {
    let exe = crate::resolve_current_exe().unwrap();
    let initrd = build_initramfs(&exe, &[], &[]).unwrap();
    assert_eq!(initrd.len() % 512, 0);
}

#[test]
fn initramfs_nonexistent_file() {
    let result = build_initramfs(Path::new("/nonexistent"), &[], &[]);
    assert!(result.is_err());
}

#[test]
fn initramfs_nonexistent_extra_binary() {
    let exe = crate::resolve_current_exe().unwrap();
    let result = build_initramfs(&exe, &[("bad", Path::new("/nonexistent"))], &[]);
    assert!(result.is_err());
}

#[test]
fn initramfs_with_args() {
    let exe = crate::resolve_current_exe().unwrap();
    let args = vec!["run".into(), "--json".into(), "scenario".into()];
    let initrd = build_initramfs(&exe, &[], &args).unwrap();
    let s = String::from_utf8_lossy(&initrd);
    assert!(s.contains("args"));
}

#[test]
fn initramfs_empty_args() {
    let exe = crate::resolve_current_exe().unwrap();
    let initrd = build_initramfs(&exe, &[], &[]).unwrap();
    assert_eq!(initrd.len() % 512, 0);
}

// -- base + suffix split tests --

#[test]
fn suffix_adds_args_and_trailer() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let args = vec!["run".into(), "--json".into()];
    let suffix = build_suffix_args(base.len(), &args, &[]).unwrap();
    let s = String::from_utf8_lossy(&suffix);
    assert!(s.contains("args"), "suffix should contain args entry");
    assert!(s.contains("TRAILER!!!"), "suffix should contain trailer");
    assert_eq!(
        (base.len() + suffix.len()) % 512,
        0,
        "base+suffix should be 512-byte aligned"
    );
}

#[test]
fn split_matches_monolithic() {
    let exe = crate::resolve_current_exe().unwrap();
    let args = vec!["run".into(), "--json".into(), "scenario".into()];
    let monolithic = build_initramfs(&exe, &[], &args).unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let suffix = build_suffix_args(base.len(), &args, &[]).unwrap();
    let mut split = Vec::with_capacity(base.len() + suffix.len());
    split.extend_from_slice(&base);
    split.extend_from_slice(&suffix);
    assert_eq!(
        monolithic, split,
        "split path should produce identical output"
    );
}

#[test]
fn suffix_different_args_differ() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let a = build_suffix_args(base.len(), &["a".into()], &[]).unwrap();
    let b = build_suffix_args(base.len(), &["b".into()], &[]).unwrap();
    assert_ne!(a, b, "different args should produce different suffixes");
}

#[test]
fn suffix_empty_args() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let suffix = build_suffix_args(base.len(), &[], &[]).unwrap();
    assert_eq!((base.len() + suffix.len()) % 512, 0);
    let s = String::from_utf8_lossy(&suffix);
    assert!(s.contains("TRAILER!!!"));
}

#[test]
fn suffix_with_sched_enable() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let sched_enable = vec!["echo 1 > /sys/kernel/sched_ext/enable".to_string()];
    let suffix = build_suffix(
        base.len(),
        &SuffixParams {
            sched_enable: &sched_enable,
            ..Default::default()
        },
    )
    .unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let entries = cpio_entries(&archive);
    let entry = entries
        .iter()
        .find(|(name, ..)| name == "sched_enable")
        .expect("sched_enable entry missing");
    assert_eq!(
        entry.1 as usize,
        sched_enable[0].len(),
        "sched_enable size should match joined content length",
    );
    // 0o100755 = S_IFREG | 0o755 (executable — it's a shell script).
    assert_eq!(entry.2, 0o100755, "sched_enable must be executable");
}

#[test]
fn suffix_with_sched_disable() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let sched_disable = vec!["echo 0 > /sys/kernel/sched_ext/enable".to_string()];
    let suffix = build_suffix(
        base.len(),
        &SuffixParams {
            sched_disable: &sched_disable,
            ..Default::default()
        },
    )
    .unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let entries = cpio_entries(&archive);
    let entry = entries
        .iter()
        .find(|(name, ..)| name == "sched_disable")
        .expect("sched_disable entry missing");
    assert_eq!(entry.1 as usize, sched_disable[0].len());
    assert_eq!(entry.2, 0o100755, "sched_disable must be executable");
}

#[test]
fn suffix_with_exec_cmd() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let cmd = "/usr/bin/stress-ng --cpu 1 --timeout 5s";
    let suffix = build_suffix(
        base.len(),
        &SuffixParams {
            exec_cmd: Some(cmd),
            ..Default::default()
        },
    )
    .unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let entries = cpio_entries(&archive);
    let entry = entries
        .iter()
        .find(|(name, ..)| name == "exec_cmd")
        .expect("exec_cmd entry missing");
    assert_eq!(entry.1 as usize, cmd.len());
    // 0o100644 = S_IFREG | 0o644 (non-executable data file — read by init, not exec'd).
    assert_eq!(entry.2, 0o100644, "exec_cmd must be a plain data file");
}

#[test]
fn suffix_omits_empty_optional_entries() {
    // Confirms the is_empty() / Option::None guards in build_suffix —
    // empty sched_enable, empty sched_disable, and None exec_cmd must
    // not leave zero-length cpio entries in the archive.
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let suffix = build_suffix(base.len(), &SuffixParams::default()).unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let names = cpio_entry_names(&archive);
    assert!(!names.iter().any(|n| n == "sched_enable"));
    assert!(!names.iter().any(|n| n == "sched_disable"));
    assert!(!names.iter().any(|n| n == "exec_cmd"));
    // Same guard for the staged-scheduler path: empty
    // `staged_sched_args` must NOT emit `staging/...` entries.
    assert!(!names.iter().any(|n| n.starts_with("staging/")));
}

/// Each non-empty `staged_sched_args` entry must materialize as a
/// `staging/schedulers/<name>/sched_args` cpio entry carrying the
/// joined argv. The boot-time `/sched_args` parser will read this
/// at scheduler-spawn time inside the guest — wrong path or
/// missing entry would silently spawn the staged scheduler with
/// the WRONG arg vector, masking the very mid-experiment behavior
/// the lifecycle Ops are designed to expose.
#[test]
fn suffix_emits_per_staged_scheduler_args_entries() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let staged = vec![
        (
            "mitosis_args_a".to_string(),
            vec!["--slice-us".to_string(), "5000".to_string()],
        ),
        (
            "mitosis_args_b".to_string(),
            vec!["--slice-us".to_string(), "20000".to_string()],
        ),
    ];
    let suffix = build_suffix(
        base.len(),
        &SuffixParams {
            staged_sched_args: &staged,
            ..Default::default()
        },
    )
    .unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let entries = cpio_entries(&archive);

    for (name, args) in &staged {
        let archive_path = format!("staging/schedulers/{name}/sched_args");
        let entry = entries
            .iter()
            .find(|(n, ..)| n == &archive_path)
            .unwrap_or_else(|| panic!("staged args entry missing for {archive_path}"));
        let expected = args.join("\n");
        assert_eq!(
            entry.1 as usize,
            expected.len(),
            "{archive_path} size mismatch",
        );
        assert_eq!(
            entry.2, 0o100644,
            "{archive_path} must be a plain data file (parser reads, init does not exec)",
        );
    }
}

/// A staged entry with empty `args` must be skipped — same is_empty()
/// guard shape as `sched_args` / `sched_enable`. Catches a future
/// regression that emits a zero-byte `sched_args` file the boot
/// parser would then interpret as "no args" silently overriding
/// whatever the operator intended.
#[test]
fn suffix_skips_staged_entries_with_empty_args() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let staged = vec![
        ("populated".to_string(), vec!["--flag".to_string()]),
        ("empty".to_string(), vec![]),
    ];
    let suffix = build_suffix(
        base.len(),
        &SuffixParams {
            staged_sched_args: &staged,
            ..Default::default()
        },
    )
    .unwrap();
    let mut archive = Vec::with_capacity(base.len() + suffix.len());
    archive.extend_from_slice(&base);
    archive.extend_from_slice(&suffix);
    let names = cpio_entry_names(&archive);
    assert!(
        names
            .iter()
            .any(|n| n == "staging/schedulers/populated/sched_args"),
        "populated args must emit an entry: {names:?}"
    );
    assert!(
        !names
            .iter()
            .any(|n| n == "staging/schedulers/empty/sched_args"),
        "empty args must NOT emit a zero-byte entry: {names:?}"
    );
}

#[test]
fn try_cow_overlay_rejects_cross_region_span() {
    // The bounds check in try_cow_overlay relies on
    // GuestMemoryMmap::get_slice failing when a range would cross
    // a region boundary. This test locks that semantic in: two
    // non-contiguous regions; a range that starts in region A but
    // extends past its end must be rejected. If this ever passes
    // (e.g. vm-memory swaps in multi-region get_slices semantics
    // here), try_cow_overlay's MAP_FIXED would silently clobber
    // whatever host mapping sits between the regions.
    use vm_memory::{GuestAddress, GuestMemory};
    let region_a_size: usize = 64 * 1024;
    let region_b_size: usize = 64 * 1024;
    let region_a_start: u64 = 0;
    let region_b_start: u64 = 1 << 20; // 1 MiB gap
    let mem = vm_memory::GuestMemoryMmap::<()>::from_ranges(&[
        (GuestAddress(region_a_start), region_a_size),
        (GuestAddress(region_b_start), region_b_size),
    ])
    .unwrap();

    // Range fully inside region A: must succeed.
    assert!(
        mem.get_slice(GuestAddress(region_a_start), region_a_size)
            .is_ok(),
        "full-region slice must succeed"
    );

    // Range starting mid-region-A and extending past region A's
    // end: must fail. This is the exact shape of the hazardous
    // cow_overlay case.
    let overrun_start = region_a_start + (region_a_size as u64 / 2);
    let overrun_len = region_a_size; // well past the region's end
    assert!(
        mem.get_slice(GuestAddress(overrun_start), overrun_len)
            .is_err(),
        "cross-boundary slice must fail"
    );

    // Range starting at a GPA inside the gap between regions:
    // also fails (no region covers the start address).
    let gap_addr = (region_a_start + region_a_size as u64) + 0x1000;
    assert!(
        mem.get_slice(GuestAddress(gap_addr), 4).is_err(),
        "gap-start slice must fail"
    );
}

#[test]
fn try_cow_overlay_preserves_adjacent_region_bytes() {
    // Proves the invariant at the application layer: with the
    // bounds check in place, we never invoke mmap(MAP_FIXED),
    // which means bytes outside the validated range stay
    // untouched. We simulate "before" bytes in region B, run the
    // same bounds check try_cow_overlay uses, observe that it
    // rejects the request, and check region B's bytes survive.
    use vm_memory::{Bytes, GuestAddress, GuestMemory};
    let region_a_size: usize = 64 * 1024;
    let region_b_size: usize = 64 * 1024;
    let region_a_start: u64 = 0;
    let region_b_start: u64 = 1 << 20;
    let mem = vm_memory::GuestMemoryMmap::<()>::from_ranges(&[
        (GuestAddress(region_a_start), region_a_size),
        (GuestAddress(region_b_start), region_b_size),
    ])
    .unwrap();

    // Seed region B with a detectable marker.
    let marker: Vec<u8> = (0..region_b_size).map(|i| (i & 0xff) as u8).collect();
    mem.write_slice(&marker, GuestAddress(region_b_start))
        .unwrap();

    // Compute an oversized COW request: starts in region A, len
    // spans the whole guest range up to the end of region B.
    let overrun_load_addr = region_a_start;
    let overrun_len = (region_b_start + region_b_size as u64) as usize;

    // This is the same check try_cow_overlay uses; on failure it
    // returns early and never invokes cow_overlay. We assert the
    // rejection and the preservation of region B's contents.
    assert!(
        mem.get_slice(GuestAddress(overrun_load_addr), overrun_len)
            .is_err(),
        "oversized overlay must be rejected before MAP_FIXED"
    );
    let mut readback = vec![0u8; region_b_size];
    mem.read_slice(&mut readback, GuestAddress(region_b_start))
        .unwrap();
    assert_eq!(
        readback, marker,
        "region B must be untouched when bounds check rejects cow_overlay"
    );
}

#[test]
fn load_initramfs_parts_sequential() {
    let part1 = vec![0xAAu8; 4096];
    let part2 = vec![0xBBu8; 512];
    let mem =
        vm_memory::GuestMemoryMmap::<()>::from_ranges(&[(vm_memory::GuestAddress(0), 16 << 20)])
            .unwrap();
    let (addr, size) = load_initramfs_parts(&mem, &[&part1, &part2], 0x200000).unwrap();
    assert_eq!(addr, 0x200000);
    assert_eq!(size, 4608);
    let mut buf = vec![0u8; 4608];
    use vm_memory::{Bytes, GuestAddress};
    mem.read_slice(&mut buf, GuestAddress(0x200000)).unwrap();
    assert_eq!(&buf[..4096], &part1[..]);
    assert_eq!(&buf[4096..], &part2[..]);
}

// -- shared lib resolution tests --

#[test]
fn resolve_shared_libs_nonexistent_returns_error() {
    let result = resolve_shared_libs(Path::new("/nonexistent/binary"));
    // Nonexistent file cannot be read.
    assert!(result.is_err());
}

#[test]
fn resolve_shared_libs_non_elf_returns_empty() {
    let _tempfile_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-resolve-nonelf-")
        .tempfile()
        .unwrap();
    let tmp = _tempfile_keep_alive.path();
    std::fs::write(tmp, b"not an elf").unwrap();
    let result = resolve_shared_libs(tmp).unwrap();
    assert!(result.found.is_empty());
    assert!(result.missing.is_empty());
}

#[test]
fn resolve_shared_libs_dynamic_binary() {
    let sh = Path::new("/bin/sh");
    if sh.exists() {
        let shared = resolve_shared_libs(sh).unwrap();
        if !shared.found.is_empty() {
            assert!(
                shared.found.iter().any(|(g, _)| g.contains("libc")),
                "dynamic binary should depend on libc: {:?}",
                shared.found
            );
            for (g, _) in &shared.found {
                assert!(!g.starts_with('/'), "guest path should be relative: {g}");
            }
        }
    }
}

#[test]
fn elf_dynamic_needed_extracts_sonames() {
    let sh = Path::new("/bin/sh");
    if !sh.exists() || !is_elf(sh) {
        skip!("/bin/sh not ELF");
    }
    let data = std::fs::read(sh).unwrap();
    let elf = goblin::elf::Elf::parse(&data).unwrap();
    let needed: Vec<&str> = elf.libraries.clone();
    assert!(
        needed.iter().any(|n| n.contains("libc")),
        "/bin/sh should need libc: {:?}",
        needed
    );
}

#[test]
fn resolve_soname_finds_libc() {
    let result = resolve_soname("libc.so.6", &ElfSearchPaths::default(), &[]);
    assert!(
        result.is_some(),
        "should resolve libc.so.6 via default paths"
    );
    assert!(result.unwrap().is_file());
}

/// Regression for glibc-divergence bug in [`resolve_soname`]: DT_RPATH
/// must be consulted BEFORE DT_RUNPATH (via the LD_LIBRARY_PATH step),
/// and DT_RUNPATH must come BEFORE interp-relative hints.
///
/// The test populates both a unique `rpath` dir and a unique `runpath`
/// dir, each containing a distinct "library" file with the same
/// soname. The file picked must be the one from `rpath` — matching
/// glibc's "DT_RPATH before LD_LIBRARY_PATH, LD_LIBRARY_PATH before
/// DT_RUNPATH" ordering.
#[test]
fn resolve_soname_rpath_beats_runpath_when_both_present() {
    let tmp = tempfile::TempDir::new().unwrap();
    let rpath_dir = tmp.path().join("rpath");
    let runpath_dir = tmp.path().join("runpath");
    std::fs::create_dir_all(&rpath_dir).unwrap();
    std::fs::create_dir_all(&runpath_dir).unwrap();
    let soname = "libktstrfake-rpath-beats-runpath.so.1";
    std::fs::write(rpath_dir.join(soname), b"rpath-copy").unwrap();
    std::fs::write(runpath_dir.join(soname), b"runpath-copy").unwrap();

    let paths = ElfSearchPaths {
        rpath: vec![rpath_dir.clone()],
        runpath: vec![runpath_dir.clone()],
    };
    let got = resolve_soname(soname, &paths, &[]).expect("should resolve");
    assert_eq!(
        got,
        rpath_dir.join(soname),
        "DT_RPATH must be preferred over DT_RUNPATH when both are \
             populated (the LD_LIBRARY_PATH step separates them)"
    );
}

/// Regression: DT_RUNPATH must beat the interp-hint fallback,
/// otherwise a binary with a perfectly good DT_RUNPATH could pick
/// up a wrong copy from the dynamic linker's directory.
#[test]
fn resolve_soname_runpath_beats_interp_hints() {
    let tmp = tempfile::TempDir::new().unwrap();
    let runpath_dir = tmp.path().join("runpath");
    let interp_dir = tmp.path().join("interp");
    std::fs::create_dir_all(&runpath_dir).unwrap();
    std::fs::create_dir_all(&interp_dir).unwrap();
    let soname = "libktstrfake-runpath-beats-interp.so.1";
    std::fs::write(runpath_dir.join(soname), b"runpath-copy").unwrap();
    std::fs::write(interp_dir.join(soname), b"interp-copy").unwrap();

    let paths = ElfSearchPaths {
        rpath: Vec::new(),
        runpath: vec![runpath_dir.clone()],
    };
    let got =
        resolve_soname(soname, &paths, std::slice::from_ref(&interp_dir)).expect("should resolve");
    assert_eq!(
        got,
        runpath_dir.join(soname),
        "DT_RUNPATH must be searched before interp-relative hints"
    );
}

/// Legacy-binary path: when [`elf_search_paths`] populates `rpath`
/// with `runpath` empty (binary has DT_RPATH and no DT_RUNPATH),
/// DT_RPATH must resolve the soname before interp-relative hints
/// get a chance. This guards the "rpath precedes interp_hints"
/// ordering in [`resolve_soname`] for the legacy-only-RPATH case.
#[test]
fn resolve_soname_rpath_only_wins_when_runpath_empty() {
    let tmp = tempfile::TempDir::new().unwrap();
    let rpath_dir = tmp.path().join("rpath-legacy");
    let interp_dir = tmp.path().join("interp");
    std::fs::create_dir_all(&rpath_dir).unwrap();
    std::fs::create_dir_all(&interp_dir).unwrap();
    let soname = "libktstrfake-rpath-legacy.so.1";
    std::fs::write(rpath_dir.join(soname), b"rpath-copy").unwrap();
    std::fs::write(interp_dir.join(soname), b"interp-copy").unwrap();

    let paths = ElfSearchPaths {
        rpath: vec![rpath_dir.clone()],
        runpath: Vec::new(),
    };
    let got =
        resolve_soname(soname, &paths, std::slice::from_ref(&interp_dir)).expect("should resolve");
    assert_eq!(
        got,
        rpath_dir.join(soname),
        "legacy binary with DT_RPATH (no DT_RUNPATH) must resolve \
             via DT_RPATH, not interp hints"
    );
}

#[test]
fn suffix_with_sched_args() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let sched_args = vec!["--enable-borrow".into(), "--llc".into()];
    let suffix = build_suffix_args(base.len(), &[], &sched_args).unwrap();
    let s = String::from_utf8_lossy(&suffix);
    assert!(
        s.contains("sched_args"),
        "suffix should contain sched_args entry"
    );
    assert!(s.contains("TRAILER!!!"));
    assert_eq!((base.len() + suffix.len()) % 512, 0);
}

#[test]
fn suffix_without_sched_args_omits_entry() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let suffix = build_suffix_args(base.len(), &[], &[]).unwrap();
    let s = String::from_utf8_lossy(&suffix);
    assert!(
        !s.contains("sched_args"),
        "empty sched_args should not produce entry"
    );
}

#[test]
fn shm_segment_name_format() {
    let name = shm_segment_name(0xDEADBEEF);
    assert!(name.starts_with("/ktstr-base-"));
    assert!(name.contains("deadbeef"));
}

#[test]
fn is_deleted_self_returns_false_for_nonexistent() {
    assert!(!is_deleted_self(Path::new("/nonexistent/binary")));
}

#[test]
fn is_deleted_self_returns_false_for_current() {
    let exe = crate::resolve_current_exe().unwrap();
    // Current binary is not deleted.
    assert!(!is_deleted_self(&exe));
}

#[test]
fn shm_store_load_unlink_roundtrip() {
    let hash = 0xABCD_EF01_2345_6789u64;
    let data = vec![0x42u8; 1024];
    shm_store_base(hash, &data).unwrap();
    let loaded = shm_load_base(hash);
    assert!(loaded.is_some());
    assert_eq!(loaded.unwrap().as_ref(), &data[..]);
    shm_unlink_base(hash);
    // After unlink, load should return None.
    assert!(shm_load_base(hash).is_none());
}

#[test]
fn shm_load_nonexistent_returns_none() {
    let hash = 0xFFFF_FFFF_FFFF_FFFFu64;
    shm_unlink_base(hash); // ensure clean
    assert!(shm_load_base(hash).is_none());
}

#[test]
fn shm_store_last_writer_wins_even_with_size_change() {
    // Documents actual semantics: shm_store reuses the segment name,
    // so a second write with different size overwrites the first.
    // Idempotent writes (same content_hash → same contents) rely on
    // callers to derive the hash from the actual content — this test
    // deliberately uses differently-sized payloads to prove the
    // writer does NOT assume the old name's size is still valid.
    let hash = 0x1234_5678_9ABC_DEF0u64;
    let d1 = vec![0x11u8; 64];
    let d2 = vec![0x22u8; 128];
    shm_store_base(hash, &d1).unwrap();
    shm_store_base(hash, &d2).unwrap();
    let loaded = shm_load_base(hash);
    assert!(loaded.is_some());
    assert_eq!(loaded.unwrap().as_ref(), &d2[..]);
    shm_unlink_base(hash);
}

#[test]
fn shm_segment_name_unique_per_hash() {
    let n1 = shm_segment_name(0);
    let n2 = shm_segment_name(1);
    assert_ne!(n1, n2);
    assert!(n1.starts_with("/ktstr-base-"));
    assert!(n2.starts_with("/ktstr-base-"));
}

#[test]
fn shm_unlink_nonexistent_is_noop() {
    // Should not panic.
    shm_unlink_base(0xDEAD_DEAD_DEAD_DEADu64);
}

#[test]
fn mapped_shm_send_sync() {
    fn assert_send_sync<T: Send + Sync>() {}
    assert_send_sync::<MappedShm>();
}

#[test]
fn shm_load_base_holds_lock_until_drop() {
    // Invariant: as long as a MappedShm is live, the SHM
    // segment's flock is held in LOCK_SH. A concurrent writer
    // calling LOCK_EX | LOCK_NB must fail with EWOULDBLOCK. Once
    // the MappedShm is dropped, the lock releases and a subsequent
    // LOCK_EX | LOCK_NB must succeed.
    //
    // This is the core invariant — if it regresses, shm_store's
    // ftruncate can race with a live reader and cause SIGBUS on
    // the mapped pages.
    let hash = 0xD0D0_BEEF_F00D_BA5Eu64;
    shm_unlink_base(hash); // clean any stale segment
    shm_store_base(hash, &vec![0x55u8; 256]).unwrap();
    let loaded = shm_load_base(hash).expect("load must succeed");

    // Open a second fd and attempt LOCK_EX|LOCK_NB. Should fail
    // with EWOULDBLOCK because the MappedShm holds LOCK_SH.
    let name = shm_segment_name(hash);
    let fd2 = rustix::shm::open(
        name.as_str(),
        rustix::shm::OFlags::RDONLY,
        rustix::fs::Mode::empty(),
    )
    .expect("second shm_open must succeed");
    let err = rustix::fs::flock(&fd2, rustix::fs::FlockOperation::NonBlockingLockExclusive);
    assert!(
        matches!(err, Err(e) if e == rustix::io::Errno::WOULDBLOCK),
        "LOCK_EX|LOCK_NB must be blocked by the live reader's LOCK_SH (got {err:?})",
    );
    drop(fd2);

    // Drop the mapping; lock releases.
    drop(loaded);

    // Now LOCK_EX|LOCK_NB must succeed on a fresh fd.
    let fd3 = rustix::shm::open(
        name.as_str(),
        rustix::shm::OFlags::RDONLY,
        rustix::fs::Mode::empty(),
    )
    .expect("third shm_open must succeed");
    rustix::fs::flock(&fd3, rustix::fs::FlockOperation::NonBlockingLockExclusive)
        .expect("LOCK_EX|LOCK_NB must succeed after the MappedShm is dropped");
    rustix::fs::flock(&fd3, rustix::fs::FlockOperation::Unlock).ok();
    drop(fd3);
    shm_unlink_base(hash);
}

#[test]
fn strip_debug_current_exe() {
    let exe = crate::resolve_current_exe().unwrap();
    let data = strip_debug(&exe).unwrap();
    assert!(!data.is_empty());
    // Stripped binary should be an ELF (first 4 bytes = 0x7f ELF).
    assert_eq!(&data[..4], b"\x7fELF");
}

#[test]
fn strip_debug_nonexistent_fails() {
    let result = strip_debug(Path::new("/nonexistent/binary"));
    assert!(result.is_err());
}

#[test]
fn build_initramfs_base_contains_init() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let s = String::from_utf8_lossy(&base);
    assert!(s.contains("init"), "base should contain init entry");
}

#[test]
fn build_initramfs_base_includes_extra_shared_libs() {
    let exe = crate::resolve_current_exe().unwrap();
    let sched = crate::test_support::require_binary("scx-ktstr");
    let extras: Vec<(&str, &Path)> = vec![("scheduler", sched.as_path())];
    let base = build_initramfs_base(&exe, &extras, &[], false).unwrap();
    let s = String::from_utf8_lossy(&base);
    assert!(
        s.contains("lib64/libelf"),
        "initramfs with scx-ktstr extra should contain libelf; \
             resolved libs: {:?}",
        resolve_shared_libs(sched.as_path()).unwrap().found
    );
}

#[test]
fn load_initramfs_to_memory() {
    let data = vec![0xAA; 4096];
    let mem =
        vm_memory::GuestMemoryMmap::<()>::from_ranges(&[(vm_memory::GuestAddress(0), 16 << 20)])
            .unwrap();
    let (addr, size) = load_initramfs_parts(&mem, &[&data], 0x200000).unwrap();
    assert_eq!(addr, 0x200000);
    assert_eq!(size, 4096);
    let mut buf = vec![0u8; 4096];
    use vm_memory::{Bytes, GuestAddress};
    mem.read_slice(&mut buf, GuestAddress(0x200000)).unwrap();
    assert_eq!(buf, data);
}

// -- include_files and busybox tests --

#[test]
fn busybox_with_include_files() {
    let exe = crate::resolve_current_exe().unwrap();
    // Per-test tempdir: TempDir generates a unique directory name
    // per invocation and cleans up on Drop. Replaces a fixed
    // `/tmp/ktstr-test-include-busybox` path that collided across
    // parallel nextest runs and left orphans after test panics.
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("included");
    std::fs::write(&tmp, b"hello").unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/test.txt", tmp.as_path())];
    let base = build_initramfs_base(&exe, &[], &includes, true).unwrap();
    let names = cpio_entry_names(&base);
    assert!(
        names.iter().any(|n| n == "bin/busybox"),
        "busybox=true should have bin/busybox entry: {:?}",
        names
    );
}

#[test]
fn include_files_no_busybox_when_empty() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let names = cpio_entry_names(&base);
    assert!(
        !names.iter().any(|n| n == "bin/busybox"),
        "busybox=false should not have bin/busybox entry: {:?}",
        names
    );
}

#[test]
fn include_files_preserves_mode() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("script");
    std::fs::write(&tmp, b"script content").unwrap();
    // Set executable mode.
    std::fs::set_permissions(&tmp, std::fs::Permissions::from_mode(0o100755)).unwrap();

    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/run.sh", tmp.as_path())];
    let base = build_initramfs_base(&exe, &[], &includes, true).unwrap();
    let s = String::from_utf8_lossy(&base);
    assert!(
        s.contains("include-files/run.sh"),
        "include path should appear in cpio"
    );
}

#[test]
fn include_files_elf_gets_shared_libs() {
    // /bin/sh is a dynamic ELF on most systems.
    let sh = Path::new("/bin/sh");
    if !sh.exists() {
        skip!("/bin/sh not found");
    }
    if !is_elf(sh) {
        skip!("/bin/sh is not ELF");
    }
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/sh", sh)];
    let base = build_initramfs_base(&exe, &[], &includes, true).unwrap();
    let s = String::from_utf8_lossy(&base);
    // Dynamic ELF should pull in libc shared libs.
    let shared = resolve_shared_libs(sh).unwrap();
    if !shared.found.is_empty() {
        assert!(
            shared.found.iter().any(|(g, _)| s.contains(g.as_str())),
            "include ELF shared libs should appear in archive: {:?}",
            shared.found
        );
    }
}

#[test]
fn include_files_non_elf_no_shared_libs() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("hello.sh");
    std::fs::write(&tmp, b"#!/bin/sh\necho hello\n").unwrap();
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/hello.sh", tmp.as_path())];
    // Should not fail (ELF parsing skipped for non-ELF).
    let base = build_initramfs_base(&exe, &[], &includes, true).unwrap();
    let s = String::from_utf8_lossy(&base);
    assert!(s.contains("include-files/hello.sh"));
}

#[test]
fn include_files_adds_directory_entries() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("file.txt");
    std::fs::write(&tmp, b"data").unwrap();
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> =
        vec![("include-files/subdir/nested/file.txt", tmp.as_path())];
    let base = build_initramfs_base(&exe, &[], &includes, true).unwrap();
    let s = String::from_utf8_lossy(&base);
    assert!(s.contains("include-files"), "should have include-files dir");
    assert!(
        s.contains("include-files/subdir"),
        "should have subdir entry"
    );
    assert!(
        s.contains("include-files/subdir/nested"),
        "should have nested subdir entry"
    );
    assert!(s.contains("bin"), "should have bin dir for busybox");
}

#[test]
fn is_elf_detects_elf_binary() {
    let exe = crate::resolve_current_exe().unwrap();
    assert!(is_elf(&exe), "test binary should be ELF");
}

#[test]
fn is_elf_rejects_non_elf() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("not-elf");
    std::fs::write(&tmp, b"not an elf file").unwrap();
    assert!(!is_elf(&tmp));
}

#[test]
fn is_elf_rejects_short_file() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("short-elf");
    std::fs::write(&tmp, b"ab").unwrap();
    assert!(!is_elf(&tmp));
}

#[test]
fn is_elf_nonexistent_returns_false() {
    assert!(!is_elf(Path::new("/nonexistent/file")));
}

#[test]
fn include_files_rejects_path_traversal() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("payload");
    std::fs::write(&tmp, b"data").unwrap();
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/../etc/passwd", tmp.as_path())];
    let result = build_initramfs_base(&exe, &[], &includes, true);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains(".."),
        "error should mention path traversal: {err}"
    );
}

#[test]
fn include_files_rejects_fifo() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let fifo_path = tmp_dir.path().join("fifo");
    // Create a FIFO.
    let c_path = std::ffi::CString::new(fifo_path.to_str().unwrap()).unwrap();
    let rc = unsafe { libc::mkfifo(c_path.as_ptr(), 0o644) };
    assert_eq!(
        rc,
        0,
        "ktstr: mkfifo({}) failed -- test infrastructure broken",
        fifo_path.display(),
    );
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/pipe", fifo_path.as_path())];
    let result = build_initramfs_base(&exe, &[], &includes, true);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("not a regular file"),
        "error should reject FIFO: {err}"
    );
}

#[test]
fn include_files_rejects_directory() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let dir_path = tmp_dir.path().join("mydir");
    std::fs::create_dir(&dir_path).unwrap();
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/mydir", dir_path.as_path())];
    let result = build_initramfs_base(&exe, &[], &includes, true);
    assert!(result.is_err());
    let err = result.unwrap_err().to_string();
    assert!(
        err.contains("not a regular file"),
        "error should reject directory: {err}"
    );
}

#[test]
fn busybox_independent_of_include_files() {
    let exe = crate::resolve_current_exe().unwrap();
    // busybox=true but no include_files.
    let base = build_initramfs_base(&exe, &[], &[], true).unwrap();
    let names = cpio_entry_names(&base);
    assert!(
        names.iter().any(|n| n == "bin/busybox"),
        "busybox=true should have bin/busybox entry even without includes: {:?}",
        names
    );
}

// -- ld.so.cache parsing tests --

#[test]
fn parse_ld_so_cache_finds_libc() {
    let cache = parse_ld_so_cache(Path::new("/etc/ld.so.cache"));
    // libc.so.6 is in every glibc system's ld.so.cache.
    assert!(
        cache.contains_key("libc.so.6"),
        "ld.so.cache should contain libc.so.6: found {} entries",
        cache.len(),
    );
    let path = &cache["libc.so.6"];
    assert!(
        path.is_file(),
        "cached libc path should exist: {}",
        path.display()
    );
}

#[test]
fn parse_ld_so_cache_nonexistent_returns_empty() {
    let cache = parse_ld_so_cache(Path::new("/nonexistent/ld.so.cache"));
    assert!(cache.is_empty());
}

#[test]
fn parse_ld_so_cache_bad_magic_returns_empty() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("ldcache");
    std::fs::write(&tmp, b"not a valid cache file").unwrap();
    let cache = parse_ld_so_cache(&tmp);
    assert!(cache.is_empty());
}

#[test]
fn parse_ld_so_cache_truncated_returns_empty() {
    let tmp_dir = tempfile::TempDir::new().unwrap();
    let tmp = tmp_dir.path().join("ldcache");
    // Valid magic but truncated header.
    let mut data = LD_CACHE_MAGIC.to_vec();
    data.extend_from_slice(&[0u8; 10]); // not enough for full header
    std::fs::write(&tmp, &data).unwrap();
    let cache = parse_ld_so_cache(&tmp);
    assert!(cache.is_empty());
}

#[test]
fn ld_so_cache_consistent_with_resolve_soname() {
    // If libc.so.6 is in the cache, resolve_soname should find it.
    let result = resolve_soname("libc.so.6", &ElfSearchPaths::default(), &[]);
    assert!(
        result.is_some(),
        "resolve_soname should find libc.so.6 (cache or paths)"
    );
    assert!(result.unwrap().is_file());
}

#[test]
fn no_duplicate_cpio_entries() {
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let entries = cpio_entries(&base);
    let mut seen = std::collections::HashSet::new();
    let mut duplicates = Vec::new();
    for (name, size, mode, ino) in &entries {
        if !seen.insert(name.clone()) {
            duplicates.push((name.clone(), *size, *mode, *ino));
        }
    }
    assert!(
        duplicates.is_empty(),
        "archive contains duplicate entries: {:?}",
        duplicates
    );
}

#[test]
fn no_duplicate_entries_with_include_files() {
    let exe = crate::resolve_current_exe().unwrap();
    // Create include files in a deeply nested path mimicking custom
    // linker library directories.
    let tmp_dir_guard = tempfile::TempDir::new().unwrap();
    let tmp_dir = tmp_dir_guard.path();
    let lib_data = vec![0xCCu8; 4096];
    let f1 = tmp_dir.join("libcustom1.so");
    let f2 = tmp_dir.join("libcustom2.so");
    let f3 = tmp_dir.join("libcustom3.so");
    std::fs::write(&f1, &lib_data).unwrap();
    std::fs::write(&f2, &lib_data).unwrap();
    std::fs::write(&f3, &lib_data).unwrap();

    let includes: Vec<(&str, &Path)> = vec![
        ("usr/local/custom/platform/lib/libcustom1.so", f1.as_path()),
        ("usr/local/custom/platform/lib/libcustom2.so", f2.as_path()),
        ("usr/local/custom/platform/lib/libcustom3.so", f3.as_path()),
    ];

    let base = build_initramfs_base(&exe, &[], &includes, false).unwrap();
    let entries = cpio_entries(&base);
    let entry_names: Vec<&str> = entries.iter().map(|(n, _, _, _)| n.as_str()).collect();

    // Check that all include files are present.
    for (archive_path, _) in &includes {
        assert!(
            entry_names.contains(archive_path),
            "missing include file entry '{}'; archive entries: {:?}",
            archive_path,
            entry_names
        );
    }

    // Check that all include files have correct size.
    for (archive_path, _) in &includes {
        let entry = entries.iter().find(|(n, _, _, _)| n == archive_path);
        assert!(
            entry.is_some_and(|(_, size, _, _)| *size == lib_data.len() as u32),
            "include file '{}' has wrong size: {:?}",
            archive_path,
            entry
        );
    }

    // Check that directory entries exist for the nested path.
    assert!(entry_names.contains(&"usr"), "missing 'usr' dir entry");
    assert!(
        entry_names.contains(&"usr/local"),
        "missing 'usr/local' dir entry"
    );
    assert!(
        entry_names.contains(&"usr/local/custom"),
        "missing 'usr/local/custom' dir entry"
    );
    assert!(
        entry_names.contains(&"usr/local/custom/platform"),
        "missing 'usr/local/custom/platform' dir entry"
    );
    assert!(
        entry_names.contains(&"usr/local/custom/platform/lib"),
        "missing 'usr/local/custom/platform/lib' dir entry"
    );

    // Check that directories come before files they contain.
    let dir_pos = entries
        .iter()
        .position(|(n, _, _, _)| n == "usr/local/custom/platform/lib")
        .unwrap();
    for (archive_path, _) in &includes {
        let file_pos = entries
            .iter()
            .position(|(n, _, _, _)| n == *archive_path)
            .unwrap();
        assert!(
            dir_pos < file_pos,
            "directory entry must precede file '{}': dir at {}, file at {}",
            archive_path,
            dir_pos,
            file_pos
        );
    }

    // No duplicate entries.
    let mut seen = std::collections::HashSet::new();
    let mut duplicates = Vec::new();
    for (name, _, _, _) in &entries {
        if !seen.insert(name.clone()) {
            duplicates.push(name.clone());
        }
    }
    assert!(
        duplicates.is_empty(),
        "duplicate entries in archive: {:?}",
        duplicates
    );
}

#[test]
fn include_elf_shared_libs_all_present_in_archive() {
    // Use /bin/sh as an include file — its shared libs must all
    // appear in the archive with non-zero sizes.
    let sh_path = Path::new("/bin/sh");
    let sh_resolved = std::fs::canonicalize(sh_path).unwrap_or_else(|_| sh_path.to_path_buf());
    let sh = sh_resolved.as_path();
    if !sh.exists() || !is_elf(sh) {
        skip!("/bin/sh not available or not ELF");
    }
    let exe = crate::resolve_current_exe().unwrap();
    let includes: Vec<(&str, &Path)> = vec![("include-files/sh", sh)];
    let base = build_initramfs_base(&exe, &[], &includes, false).unwrap();
    let entries = cpio_entries(&base);
    let entry_map: std::collections::HashMap<&str, (u32, u32, u32)> = entries
        .iter()
        .map(|(n, s, m, i)| (n.as_str(), (*s, *m, *i)))
        .collect();

    let shared = resolve_shared_libs(sh).unwrap();
    for (guest_path, _host_path) in &shared.found {
        assert!(
            entry_map.contains_key(guest_path.as_str()),
            "shared lib '{}' missing from archive; entries: {:?}",
            guest_path,
            entries
                .iter()
                .map(|(n, _, _, _)| n.as_str())
                .collect::<Vec<_>>()
        );
        let (size, _, _) = entry_map[guest_path.as_str()];
        assert!(
            size > 0,
            "shared lib '{}' has zero size in archive",
            guest_path
        );
    }

    // Check the include file itself is present.
    assert!(
        entry_map.contains_key("include-files/sh"),
        "include file itself missing from archive"
    );
}

#[test]
fn all_inode_zero_entries_have_nlink_one() {
    // Check that all entries use ino=0 and nlink=1, so the kernel
    // initramfs unpacker never enters the hardlink path.
    let exe = crate::resolve_current_exe().unwrap();
    let base = build_initramfs_base(&exe, &[], &[], false).unwrap();
    let mut remaining: &[u8] = base.as_slice();
    while let Ok(reader) = cpio::newc::Reader::new(remaining) {
        if reader.entry().is_trailer() {
            break;
        }
        let name = reader.entry().name().to_string();
        let ino = reader.entry().ino();
        let nlink = reader.entry().nlink();
        assert_eq!(
            ino, 0,
            "entry '{}' has non-zero inode {}: risk of kernel hardlink confusion",
            name, ino
        );
        assert_eq!(
            nlink, 1,
            "entry '{}' has nlink {}: kernel only hardlinks when nlink >= 2",
            name, nlink
        );
        remaining = reader.finish().unwrap();
    }
}

#[test]
fn lz4_legacy_compress_format() {
    let data = vec![0xAAu8; 4096];
    let compressed = lz4_legacy_compress(&data);
    // Must start with LZ4 legacy magic.
    assert_eq!(
        &compressed[..4],
        &LZ4_LEGACY_MAGIC,
        "output must start with LZ4 legacy magic 0x184C2102"
    );
    // First chunk: 4-byte compressed size follows magic.
    let chunk_size = u32::from_le_bytes(compressed[4..8].try_into().unwrap()) as usize;
    assert!(
        chunk_size > 0 && chunk_size < data.len(),
        "compressed chunk should be non-empty and smaller than input: {}",
        chunk_size
    );
    // Decompress and check roundtrip.
    let decompressed = lz4_flex::block::decompress(&compressed[8..8 + chunk_size], data.len())
        .expect("lz4 block decompress failed");
    assert_eq!(decompressed, data);
}

#[test]
fn lz4_legacy_compress_large_input_splits_chunks() {
    // Input larger than LZ4_CHUNK_SIZE (8MB) must produce multiple chunks.
    let data = vec![0xBBu8; LZ4_CHUNK_SIZE + 1024];
    let compressed = lz4_legacy_compress(&data);
    assert_eq!(&compressed[..4], &LZ4_LEGACY_MAGIC);
    // Parse chunks: should be at least 2.
    let mut pos = 4;
    let mut chunk_count = 0;
    let mut total_decompressed = Vec::new();
    while pos + 4 <= compressed.len() {
        let chunk_size = u32::from_le_bytes(compressed[pos..pos + 4].try_into().unwrap()) as usize;
        if chunk_size == 0 {
            break;
        }
        pos += 4;
        let remaining_uncompressed = data.len() - total_decompressed.len();
        let expected_chunk_len = remaining_uncompressed.min(LZ4_CHUNK_SIZE);
        let decompressed =
            lz4_flex::block::decompress(&compressed[pos..pos + chunk_size], expected_chunk_len)
                .expect("lz4 block decompress failed");
        total_decompressed.extend_from_slice(&decompressed);
        pos += chunk_size;
        chunk_count += 1;
    }
    assert!(
        chunk_count >= 2,
        "input > 8MB should produce >= 2 chunks, got {}",
        chunk_count
    );
    assert_eq!(total_decompressed, data);
}

#[test]
fn lz4_legacy_compress_empty_input() {
    let compressed = lz4_legacy_compress(&[]);
    // Empty input: just the magic, no chunks.
    assert_eq!(compressed, LZ4_LEGACY_MAGIC);
}

/// Build a synthetic cpio archive from generated data for LZ4 tests.
/// Uses generic paths to avoid banned terms.
fn build_synthetic_cpio(total_size: usize) -> Vec<u8> {
    let mut archive = Vec::new();
    // Directory entries.
    write_entry(&mut archive, "lib", &[], 0o40755).unwrap();
    write_entry(&mut archive, "data", &[], 0o40755).unwrap();

    // Fill with generated binary data to reach target size.
    // Use a simple PRNG for reproducible high-entropy content.
    let mut rng_state = 0x12345678u64;
    let entry_size = 256 * 1024; // 256KB per entry
    let mut entry_num = 0;
    while archive.len() + entry_size < total_size {
        let mut payload = vec![0u8; entry_size];
        for byte in &mut payload {
            rng_state = rng_state.wrapping_mul(6364136223846793005).wrapping_add(1);
            *byte = (rng_state >> 33) as u8;
        }
        let name = format!("lib/test_{entry_num:04}.so");
        write_entry(&mut archive, &name, &payload, 0o100755).unwrap();
        entry_num += 1;
    }

    // Pad remaining space with a data file.
    if archive.len() < total_size {
        let remaining = total_size - archive.len() - 200; // room for header
        let remaining = remaining.min(total_size);
        let mut payload = vec![0u8; remaining];
        for byte in &mut payload {
            rng_state = rng_state.wrapping_mul(6364136223846793005).wrapping_add(1);
            *byte = (rng_state >> 33) as u8;
        }
        write_entry(&mut archive, "data/fill.bin", &payload, 0o100644).unwrap();
    }

    // Trailer and padding.
    cpio::newc::trailer(&mut archive as &mut dyn std::io::Write).unwrap();
    let pad = (512 - (archive.len() % 512)) % 512;
    archive.extend(std::iter::repeat_n(0u8, pad));
    archive
}

/// Simulate the kernel's unlz4() decompression loop (non-fill path).
/// This mirrors lib/decompress_unlz4.c behavior:
///   1. Read and validate 4-byte magic (0x184C2102)
///   2. Loop: read 4-byte LE chunk size, decompress chunk, advance
///   3. Handle concatenated magic (re-encounter mid-stream)
///   4. Terminate on size < 4 or size == 0
fn simulate_kernel_unlz4(input: &[u8]) -> Result<Vec<u8>, String> {
    const UNCOMP_CHUNK_SIZE: usize = 8 << 20; // LZ4_DEFAULT_UNCOMPRESSED_CHUNK_SIZE

    if input.len() < 4 {
        return Err("input too short for magic".into());
    }

    let mut inp = 0usize; // current position
    let mut size = input.len() as isize; // remaining bytes

    // Read and validate magic.
    let magic = u32::from_le_bytes(input[inp..inp + 4].try_into().unwrap());
    if magic != 0x184C2102 {
        return Err(format!("invalid header: 0x{magic:08X}"));
    }
    inp += 4;
    size -= 4;

    let mut output = Vec::new();

    loop {
        if size < 4 {
            // End of input — clean exit.
            break;
        }

        let chunksize = u32::from_le_bytes(input[inp..inp + 4].try_into().unwrap()) as usize;

        // Handle concatenated magic mid-stream.
        if chunksize == 0x184C2102 {
            inp += 4;
            size -= 4;
            continue;
        }

        // Zero chunk size — end of stream.
        if chunksize == 0 {
            break;
        }

        inp += 4;
        size -= 4;

        // Kernel: LZ4_decompress_safe(inp, outp, chunksize, dest_len)
        // dest_len = uncomp_chunksize (8MB max output)
        let chunk_data = &input[inp..inp + chunksize];
        let decompressed = lz4_flex::block::decompress(chunk_data, UNCOMP_CHUNK_SIZE)
            .map_err(|e| format!("LZ4_decompress_safe failed: {e}"))?;

        output.extend_from_slice(&decompressed);

        size -= chunksize as isize;
        if size == 0 {
            break;
        } else if size < 0 {
            return Err("data corrupted: size went negative".into());
        }
        inp += chunksize;
    }

    Ok(output)
}

/// Roundtrip test with synthetic cpio data through the kernel's
/// unlz4() decompression logic. Uses generated test data with
/// generic paths.
#[test]
fn lz4_legacy_kernel_unlz4_roundtrip() {
    // Single chunk (< 8MB).
    let small = build_synthetic_cpio(1 << 20); // ~1MB
    let compressed = lz4_legacy_compress(&small);
    let decompressed =
        simulate_kernel_unlz4(&compressed).expect("kernel unlz4 simulation failed on small input");
    assert_eq!(decompressed, small);

    // Multi-chunk (> 8MB, forces chunk splitting).
    let large = build_synthetic_cpio(10 << 20); // ~10MB
    let compressed = lz4_legacy_compress(&large);
    let decompressed = simulate_kernel_unlz4(&compressed)
        .expect("kernel unlz4 simulation failed on multi-chunk input");
    assert_eq!(decompressed, large);
}

/// Test concatenated LZ4 legacy streams (base + suffix) through
/// the kernel unlz4 simulation. This is the format used when
/// base and suffix are compressed separately.
#[test]
fn lz4_legacy_kernel_unlz4_concatenated() {
    let base = build_synthetic_cpio(2 << 20); // ~2MB
    let suffix_data = b"arg1\narg2\narg3\n";

    let lz4_base = lz4_legacy_compress(&base);
    let lz4_suffix = lz4_legacy_compress(suffix_data);

    // Concatenate the two streams.
    let mut combined = Vec::with_capacity(lz4_base.len() + lz4_suffix.len());
    combined.extend_from_slice(&lz4_base);
    combined.extend_from_slice(&lz4_suffix);

    let decompressed = simulate_kernel_unlz4(&combined)
        .expect("kernel unlz4 simulation failed on concatenated streams");

    let mut expected = Vec::with_capacity(base.len() + suffix_data.len());
    expected.extend_from_slice(&base);
    expected.extend_from_slice(suffix_data);
    assert_eq!(decompressed, expected);
}

/// Check lz4_flex block output is decompressible by the C lz4
/// library (same decompressor as the kernel's LZ4_decompress_safe).
/// Uses synthetic cpio data with generic paths.
#[test]
fn lz4_legacy_compress_c_compat() {
    let lz4_check = std::process::Command::new("lz4").arg("--version").output();
    if lz4_check.is_err() {
        skip!("lz4 CLI not found");
    }

    let data = build_synthetic_cpio(2 << 20); // ~2MB
    let compressed = lz4_legacy_compress(&data);
    let _compressed_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-compat-compressed-")
        .suffix(".lz4")
        .tempfile()
        .unwrap();
    let _decompressed_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-compat-decompressed-")
        .suffix(".bin")
        .tempfile()
        .unwrap();
    let compressed_path = _compressed_keep_alive.path();
    let decompressed_path = _decompressed_keep_alive.path();
    std::fs::write(compressed_path, &compressed).unwrap();

    let output = std::process::Command::new("lz4")
        .args(["-d", "-f", "--no-frame-crc"])
        .arg(compressed_path)
        .arg(decompressed_path)
        .output()
        .expect("lz4 -d failed to execute");

    assert!(
        output.status.success(),
        "lz4 -d failed: stderr={}",
        String::from_utf8_lossy(&output.stderr),
    );

    let result = std::fs::read(decompressed_path).unwrap();
    assert_eq!(result.len(), data.len(), "decompressed size mismatch");
    assert_eq!(&result[..], &data[..], "decompressed content mismatch");
}

/// Check our output can be decompressed by `lz4 -d` when compressed
/// with `lz4 -l` as reference. Tests cross-compatibility of our
/// legacy format framing with the reference implementation.
#[test]
fn lz4_legacy_reference_cross_compat() {
    let lz4_check = std::process::Command::new("lz4").arg("--version").output();
    if lz4_check.is_err() {
        skip!("lz4 CLI not found");
    }

    let data = build_synthetic_cpio(2 << 20);

    // Compress with `lz4 -l` (reference legacy mode).
    let _input_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-ref-input-")
        .suffix(".bin")
        .tempfile()
        .unwrap();
    let _ref_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-ref-")
        .suffix(".lz4")
        .tempfile()
        .unwrap();
    let input_path = _input_keep_alive.path();
    let ref_path = _ref_keep_alive.path();
    std::fs::write(input_path, &data).unwrap();

    let ref_output = std::process::Command::new("lz4")
        .args(["-l", "-f"])
        .arg(input_path)
        .arg(ref_path)
        .output()
        .expect("lz4 -l failed to execute");

    assert!(
        ref_output.status.success(),
        "lz4 -l failed: stderr={}",
        String::from_utf8_lossy(&ref_output.stderr),
    );

    // Decompress reference output through our kernel simulation.
    let ref_compressed = std::fs::read(ref_path).unwrap();

    let ref_decompressed = simulate_kernel_unlz4(&ref_compressed)
        .expect("kernel unlz4 simulation failed on lz4 -l output");
    assert_eq!(
        ref_decompressed, data,
        "reference lz4 -l roundtrip mismatch"
    );

    // Also compress with our encoder, decompress with lz4 -d.
    let our_compressed = lz4_legacy_compress(&data);
    let _our_lz4_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-ref-ours-")
        .suffix(".lz4")
        .tempfile()
        .unwrap();
    let _our_decompressed_keep_alive = tempfile::Builder::new()
        .prefix("ktstr-test-lz4-ref-ours-decompressed-")
        .suffix(".bin")
        .tempfile()
        .unwrap();
    let our_lz4_path = _our_lz4_keep_alive.path();
    let our_decompressed_path = _our_decompressed_keep_alive.path();
    std::fs::write(our_lz4_path, &our_compressed).unwrap();

    let our_output = std::process::Command::new("lz4")
        .args(["-d", "-f", "--no-frame-crc"])
        .arg(our_lz4_path)
        .arg(our_decompressed_path)
        .output()
        .expect("lz4 -d on our output failed to execute");

    assert!(
        our_output.status.success(),
        "lz4 -d on our output failed: stderr={}",
        String::from_utf8_lossy(&our_output.stderr),
    );

    let our_result = std::fs::read(our_decompressed_path).unwrap();
    assert_eq!(our_result, data, "our lz4 output cross-compat mismatch");
}