kaldera 0.1.0

Lightweight 3D renderer powered by Vulkan
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111

use crate::ffi::vk::*;
use super::error::Result;
use super::error::ErrorCode;
use super::instance::{Instance, QueueFamily, PhysicalDevice, PhysicalDevicesBuilder};
use super::device::{Device, CommandPool, CommandBuffer, CommandBufferBuilder, ShaderModule, ShaderModuleSource};
use super::memory::{StorageBuffer, UniformBuffer, DedicatedBufferMemory, DedicatedStagingBuffer};
use super::image::{ColorImage};

use std::ptr;
use std::mem;
use std::mem::MaybeUninit;
use libc::{c_float, c_void, size_t};
use std::sync::Arc;
use std::io::Read;
use std::ffi::CString;

use VkStructureType::*;
use VkStructureTypeExtRay::*;
use VkBuildAccelerationStructureFlagBitsKHR::*;
use VkAccelerationStructureTypeKHR::*;
use VkAccelerationStructureMemoryRequirementsTypeKHR::*;
use VkAccelerationStructureBuildTypeKHR::*;
use VkMemoryPropertyFlagBits::*;
use VkMemoryAllocateFlagBits::*;
use VkBufferUsageFlagBits::*;
use VkGeometryFlagBitsKHR::*;
use VkPipelineStageFlagBits::*;
use VkGeometryInstanceFlagBitsKHR::*;

pub struct BottomLevelAccelerationStructure {
    objects: Vec<Arc<BottomLevelAccelerationStructureGeometryObject>>,
}

impl BottomLevelAccelerationStructure {
    pub fn new(
        command_pool: &Arc<CommandPool>,
        geometries: Vec<Arc<BottomLevelAccelerationStructureGeometry>>,
    ) -> Result<Arc<Self>> {
        unsafe { Self::init(command_pool, geometries) }
    }

    unsafe fn init(
        command_pool: &Arc<CommandPool>,
        geometries: Vec<Arc<BottomLevelAccelerationStructureGeometry>>,
    ) -> Result<Arc<Self>> {
        let device = command_pool.queue().device();
        let builders = geometries.into_iter()
            .map(|v| BottomLevelAccelerationStructureGeometryBuilder::new(device, v))
            .collect::<Result<Vec<_>>>()?;
        let scratch_size = builders.iter()
            .map(|v| v.structure())
            .map(|v| v.scratch_memory_requirements())
            .map(|v| v.memoryRequirements.size)
            .max()
            .unwrap();
        let scratch_buffer_memory = DedicatedBufferMemory::new(
            device, 
            VK_BUFFER_USAGE_RAY_TRACING_BIT_KHR as VkBufferUsageFlags
                | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT as VkBufferUsageFlags,
            VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
            scratch_size)
            .unwrap();
        let objects: Vec<_> = builders.into_iter()
            .map(|v| v.build(command_pool, &scratch_buffer_memory))
            .collect();
        // build
        {
            let command_buffers: Vec<_> = objects.iter()
                .map(|v| v.command_buffer().handle())
                .collect();
            command_pool.queue()
                .submit_then_wait(command_buffers.as_slice())
                .unwrap();
        }
        let objects: Vec<_> = objects.into_iter()
            .map(|v| v.finalize())
            .collect();
        let structure = BottomLevelAccelerationStructure {
            objects,
        };
        Ok(Arc::new(structure))
    }

    fn structure_device_address(&self) -> VkDeviceAddress {
        assert_eq!(self.objects.len(), 1, "multiple geometries not supported yet");
        let object = self.objects.first().unwrap();
        object.structure_device_address()
    }
}

pub struct BottomLevelAccelerationStructureGeometry {
    type_info_vec: Vec<VkAccelerationStructureCreateGeometryTypeInfoKHR>,
    info_vec: Vec<VkAccelerationStructureGeometryKHR>,
    offset_vec: Vec<VkAccelerationStructureBuildOffsetInfoKHR>,
    vertex_buffer_memory: Arc<DedicatedBufferMemory>,
    index_buffer_memory: Arc<DedicatedBufferMemory>,
}

impl BottomLevelAccelerationStructureGeometry {
    pub fn new(
        num_vertices: u32,
        vertex_stride: VkDeviceSize,
        vertex_buffer_memory: &Arc<DedicatedBufferMemory>,
        num_indices: u32,
        index_buffer_memory: &Arc<DedicatedBufferMemory>,
    ) -> Result<Arc<Self>> {
        unsafe { Self::init(num_vertices, vertex_stride, vertex_buffer_memory, num_indices, index_buffer_memory) }
    }

    unsafe fn init(
        num_vertices: u32,
        vertex_stride: VkDeviceSize,
        vertex_buffer_memory: &Arc<DedicatedBufferMemory>,
        num_indices: u32,
        index_buffer_memory: &Arc<DedicatedBufferMemory>,
    ) -> Result<Arc<Self>> {
        // assumes single type info
        let primitive_count = num_indices / 3;
        let type_info = VkAccelerationStructureCreateGeometryTypeInfoKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_GEOMETRY_TYPE_INFO_KHR,
            pNext: ptr::null(),
            geometryType: VkGeometryTypeKHR::VK_GEOMETRY_TYPE_TRIANGLES_KHR,
            maxPrimitiveCount: primitive_count,
            indexType: VkIndexType::VK_INDEX_TYPE_UINT32,
            maxVertexCount: num_vertices,
            vertexFormat: VkFormat::VK_FORMAT_R32G32B32_SFLOAT,
            allowsTransforms: VK_FALSE,
        };
        let triangles_data = VkAccelerationStructureGeometryTrianglesDataKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_TRIANGLES_DATA_KHR,
            pNext: ptr::null(),
            vertexFormat: VkFormat::VK_FORMAT_R32G32B32_SFLOAT,
            vertexData: vertex_buffer_memory.buffer_device_address(),
            vertexStride: vertex_stride,
            indexType: VkIndexType::VK_INDEX_TYPE_UINT32,
            indexData: index_buffer_memory.buffer_device_address(),
            transformData: 0,
        };
        let geometry_data = VkAccelerationStructureGeometryDataKHR {
            triangles: triangles_data,
        };
        let info = VkAccelerationStructureGeometryKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_KHR,
            pNext: ptr::null(),
            geometryType: VkGeometryTypeKHR::VK_GEOMETRY_TYPE_TRIANGLES_KHR,
            geometry: geometry_data,
            flags: VK_GEOMETRY_OPAQUE_BIT_KHR as VkGeometryFlagsKHR,
        };
        let offset = VkAccelerationStructureBuildOffsetInfoKHR {
            primitiveCount: primitive_count,
            primitiveOffset: 0,
            firstVertex: 0,
            transformOffset: 0,
        };
        let geometry = Self {
            type_info_vec: vec![type_info],
            info_vec: vec![info],
            offset_vec: vec![offset],
            vertex_buffer_memory: Arc::clone(vertex_buffer_memory),
            index_buffer_memory: Arc::clone(index_buffer_memory),
        };
        Ok(Arc::new(geometry))
    }

    fn type_info_vec(&self) -> &Vec<VkAccelerationStructureCreateGeometryTypeInfoKHR> {
        &self.type_info_vec
    }

    fn info_vec(&self) -> &Vec<VkAccelerationStructureGeometryKHR> {
        &self.info_vec
    }

    fn offset_vec(&self) -> &Vec<VkAccelerationStructureBuildOffsetInfoKHR> {
        &self.offset_vec
    }
}

pub struct BottomLevelAccelerationStructureGeometryBuilder {
    geometry: Arc<BottomLevelAccelerationStructureGeometry>,
    structure: Arc<AccelerationStructure>,
}

impl BottomLevelAccelerationStructureGeometryBuilder {
    unsafe fn new(device: &Arc<Device>, geometry: Arc<BottomLevelAccelerationStructureGeometry>) -> Result<Self> {
        let create_info = VkAccelerationStructureCreateInfoKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_INFO_KHR,
            pNext: ptr::null(),
            compactedSize: 0,
            r#type: VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR,
            flags: VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR as VkFlags,
            maxGeometryCount: geometry.type_info_vec().len() as u32,
            pGeometryInfos: geometry.type_info_vec().as_ptr(),
            deviceAddress: 0,
        };
        let structure = AccelerationStructure::new(device, &create_info)
            .unwrap();
        let object = Self {
            geometry: geometry,
            structure,
        };
        Ok(object)
    }

    fn structure(&self) -> &Arc<AccelerationStructure> {
        &self.structure
    }

    unsafe fn build(self, 
        command_pool: &Arc<CommandPool>, 
        scratch_buffer_memory: &Arc<DedicatedBufferMemory>,
    ) -> BottomLevelAccelerationStructureGeometryBuild {
        let structure = self.structure;
        let geometry = self.geometry;
        let device = command_pool.queue().device();
        let command_buffer = CommandBufferBuilder::new(command_pool).build(|command_buffer| {
            let build_info = VkAccelerationStructureBuildGeometryInfoKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_BUILD_GEOMETRY_INFO_KHR,
                pNext: ptr::null(),
                r#type: VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR,
                flags: VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR as VkFlags,
                update: VK_FALSE,
                srcAccelerationStructure: ptr::null_mut(),
                dstAccelerationStructure: structure.handle(),
                geometryArrayOfPointers: VK_FALSE,
                geometryCount: geometry.info_vec().len() as u32,
                ppGeometries: &geometry.info_vec().as_ptr(),
                scratchData: scratch_buffer_memory.buffer_device_address(),
            };
            // converts to an array of pointers to arrays of VkAccelerationStructureBuildOffsetInfoKHR
            let offset_ptr_vec = geometry.offset_vec().iter()
                .map(|v| v as *const VkAccelerationStructureBuildOffsetInfoKHR)
                .collect::<Vec<_>>();
            dispatch_vkCmdBuildAccelerationStructureKHR(device.handle(), 
                command_buffer, 1, &build_info, offset_ptr_vec.as_ptr());
            // memory barrier allowing reuse of scratch across builds
            let memory_barrier = VkMemoryBarrier {
                sType: VK_STRUCTURE_TYPE_MEMORY_BARRIER,
                pNext: ptr::null(),
                srcAccessMask: VkAccessFlagBits::VK_ACCESS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR as VkAccessFlags,
                dstAccessMask: VkAccessFlagBits::VK_ACCESS_ACCELERATION_STRUCTURE_READ_BIT_KHR as VkAccessFlags
            };
            vkCmdPipelineBarrier(command_buffer, 
                VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR as VkPipelineStageFlags,
                VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR as VkPipelineStageFlags, 
                0, 
                1, &memory_barrier,
                0, ptr::null(),
                0, ptr::null(),
            );
        });
        BottomLevelAccelerationStructureGeometryBuild::new(
            geometry,
            structure,
            command_buffer,
            scratch_buffer_memory,
        )
    }
}

pub struct BottomLevelAccelerationStructureGeometryBuild {
    geometry: Arc<BottomLevelAccelerationStructureGeometry>,
    structure: Arc<AccelerationStructure>,
    command_buffer: Arc<CommandBuffer>,
    scratch_buffer_memory: Arc<DedicatedBufferMemory>,
}

impl BottomLevelAccelerationStructureGeometryBuild {
    fn new(
        geometry: Arc<BottomLevelAccelerationStructureGeometry>,
        structure: Arc<AccelerationStructure>,
        command_buffer: Arc<CommandBuffer>,
        scratch_buffer_memory: &Arc<DedicatedBufferMemory>,
    ) -> Self {
        let object = Self {
            geometry,
            structure,
            command_buffer,
            scratch_buffer_memory: Arc::clone(scratch_buffer_memory),
        };
        object
    }

    fn command_buffer(&self) -> &Arc<CommandBuffer> {
        &self.command_buffer
    }

    fn finalize(self) -> Arc<BottomLevelAccelerationStructureGeometryObject> {
        BottomLevelAccelerationStructureGeometryObject::new(self.geometry, self.structure)
    }
}

pub struct BottomLevelAccelerationStructureGeometryObject {
    geometry: Arc<BottomLevelAccelerationStructureGeometry>,
    structure: Arc<AccelerationStructure>,
}

impl BottomLevelAccelerationStructureGeometryObject {
    fn new(
        geometry: Arc<BottomLevelAccelerationStructureGeometry>,
        structure: Arc<AccelerationStructure>,
    ) -> Arc<Self> {
        let object = Self {
            geometry,
            structure,
        };
        Arc::new(object)
    }

    #[inline]
    pub fn structure_device_address(&self) -> VkDeviceAddress {
        self.structure.device_address()
    }
}

pub struct AccelerationStructure {
    device: Arc<Device>,
    handle: VkAccelerationStructureKHR,
    memory: VkDeviceMemory,
    memory_requirements: VkMemoryRequirements2,
}

impl AccelerationStructure {
    pub fn new(
        device: &Arc<Device>, 
        create_info: &VkAccelerationStructureCreateInfoKHR,
    ) -> Result<Arc<Self>> {
        unsafe { Self::init(device, create_info) }
    }

    unsafe fn init(device: &Arc<Device>, create_info: &VkAccelerationStructureCreateInfoKHR) -> Result<Arc<Self>> {
        let mut structure_handle = MaybeUninit::<VkAccelerationStructureKHR>::zeroed();
        vkCreateAccelerationStructureKHR(device.handle(), create_info, ptr::null(), structure_handle.as_mut_ptr())
            .into_result()
            .unwrap();
        let structure_handle = structure_handle.assume_init();
        // find memory requirements
        let mut requirements = MaybeUninit::<VkMemoryRequirements2>::zeroed();
        {
            {
                let requirements = requirements.as_mut_ptr().as_mut().unwrap();
                requirements.sType = VK_STRUCTURE_TYPE_MEMORY_REQUIREMENTS_2;
            }
            let memory_info = VkAccelerationStructureMemoryRequirementsInfoKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_MEMORY_REQUIREMENTS_INFO_KHR,
                pNext: ptr::null(),
                r#type: VK_ACCELERATION_STRUCTURE_MEMORY_REQUIREMENTS_TYPE_OBJECT_KHR,
                accelerationStructure: structure_handle,
                buildType: VK_ACCELERATION_STRUCTURE_BUILD_TYPE_DEVICE_KHR,
            };
            vkGetAccelerationStructureMemoryRequirementsKHR(device.handle(), &memory_info, requirements.as_mut_ptr());
        }
        let requirements = requirements.assume_init();
        // allocate memory
        let mut memory = MaybeUninit::<VkDeviceMemory>::zeroed();
        {
            let memory_type_index = device.physical_device()
                .memory_type_index(&requirements.memoryRequirements, 
                    VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags)
                .ok_or_else(|| ErrorCode::SuitableBufferMemoryTypeNotFound)
                .unwrap();
            let allocate_flags_info = VkMemoryAllocateFlagsInfo {
                sType: VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_FLAGS_INFO,
                pNext: ptr::null(),
                flags: VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT as VkMemoryAllocateFlags,
                deviceMask: 0,
            };
            let allocate_info = VkMemoryAllocateInfo {
                sType: VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO,
                pNext: &allocate_flags_info as *const _ as *const c_void,
                allocationSize: requirements.memoryRequirements.size,
                memoryTypeIndex: memory_type_index,
            };
            vkAllocateMemory(device.handle(), &allocate_info, ptr::null(), memory.as_mut_ptr())
                .into_result()
                .unwrap();
        }
        let memory = memory.assume_init();
        // bind memory
        {
            let bind_info = VkBindAccelerationStructureMemoryInfoKHR {
                sType: VK_STRUCTURE_TYPE_BIND_ACCELERATION_STRUCTURE_MEMORY_INFO_KHR,
                pNext: ptr::null(),
                accelerationStructure: structure_handle,
                memory: memory,
                memoryOffset: 0,
                deviceIndexCount: 0,
                pDeviceIndices: ptr::null(),
            };
            vkBindAccelerationStructureMemoryKHR(device.handle(), 1, &bind_info)
                .into_result()
                .unwrap();
        }
        let structure = AccelerationStructure {
            device: Arc::clone(device),
            handle: structure_handle,
            memory,
            memory_requirements: requirements,
        };
        Ok(Arc::new(structure))
    }

    #[inline]
    pub fn handle(&self) -> VkAccelerationStructureKHR {
        self.handle
    }

    pub fn device_address(&self) -> VkDeviceAddress {
        unsafe {
            let info = VkAccelerationStructureDeviceAddressInfoKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_DEVICE_ADDRESS_INFO_KHR,
                pNext: ptr::null(),
                accelerationStructure: self.handle,
            };
            vkGetAccelerationStructureDeviceAddressKHR(self.device.handle(), &info)
        }
    }

    fn memory_requirements(&self) -> &VkMemoryRequirements2 {
        &self.memory_requirements
    }

    fn scratch_memory_requirements(&self) -> VkMemoryRequirements2 {
        let mut requirements = MaybeUninit::<VkMemoryRequirements2>::zeroed();
        unsafe {
            {
                let requirements = requirements.as_mut_ptr().as_mut().unwrap();
                requirements.sType = VK_STRUCTURE_TYPE_MEMORY_REQUIREMENTS_2;
            }
            let memory_info = VkAccelerationStructureMemoryRequirementsInfoKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_MEMORY_REQUIREMENTS_INFO_KHR,
                pNext: ptr::null(),
                r#type: VK_ACCELERATION_STRUCTURE_MEMORY_REQUIREMENTS_TYPE_BUILD_SCRATCH_KHR,
                accelerationStructure: self.handle(),
                buildType: VK_ACCELERATION_STRUCTURE_BUILD_TYPE_DEVICE_KHR,
            };
            vkGetAccelerationStructureMemoryRequirementsKHR(self.device.handle(), &memory_info, requirements.as_mut_ptr());
            requirements.assume_init()
        }
    }
}

impl Drop for AccelerationStructure {
    fn drop(&mut self) {
        unsafe {
            log_debug!("Drop AccelerationStructure");
            vkDestroyAccelerationStructureKHR(self.device.handle(), self.handle, ptr::null());
            vkFreeMemory(self.device.handle(), self.memory, ptr::null());
        }
    }
}

pub struct AccelerationVertexStagingBuffer {
    vertex_buffer: Arc<DedicatedStagingBuffer>,
    index_buffer: Arc<DedicatedStagingBuffer>,
    index_count: usize,
}

impl AccelerationVertexStagingBuffer {
    pub fn new<Vertex>(command_pool: &Arc<CommandPool>, vertices: &[Vertex], indices: &[u32]) -> Arc<Self> {
        let vertex_buffer_size = std::mem::size_of::<Vertex>() * vertices.len();
        let vertex_buffer = DedicatedStagingBuffer::new(
            command_pool, 
            VK_BUFFER_USAGE_VERTEX_BUFFER_BIT as VkBufferUsageFlags 
                | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT as  VkBufferUsageFlags
                | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT as VkBufferUsageFlags,
            VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
            vertex_buffer_size as VkDeviceSize,
        ).unwrap();
        let index_buffer_size = std::mem::size_of::<u32>() * indices.len();
        let index_buffer = DedicatedStagingBuffer::new(
            command_pool, 
            VK_BUFFER_USAGE_INDEX_BUFFER_BIT as VkBufferUsageFlags 
                | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT as  VkBufferUsageFlags
                | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT as VkBufferUsageFlags,
            VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
            vertex_buffer_size as VkDeviceSize,
        ).unwrap();
        // transfer
        vertex_buffer.write(vertices.as_ptr() as *const c_void, vertex_buffer_size);
        index_buffer.write(indices.as_ptr() as *const c_void, index_buffer_size);
        let buffer = AccelerationVertexStagingBuffer {
            vertex_buffer,
            index_buffer,
            index_count: indices.len(),
        };
        Arc::new(buffer)
    }

    #[inline]
    pub fn vertex_buffer(&self) -> &Arc<DedicatedStagingBuffer> {
        &self.vertex_buffer
    }

    #[inline]
    pub fn index_buffer(&self) -> &Arc<DedicatedStagingBuffer> {
        &self.index_buffer
    }

    #[inline]
    pub fn index_count(&self) -> usize {
        self.index_count
    }
}

pub struct TopLevelAccelerationStructure {
    instances_buffer: Arc<DedicatedStagingBuffer>,
    structure: Arc<AccelerationStructure>,
    bottom_level: Arc<BottomLevelAccelerationStructure>,
}

impl TopLevelAccelerationStructure {
    pub fn new(
        command_pool: &Arc<CommandPool>, 
        bottom_level: &Arc<BottomLevelAccelerationStructure>,
    ) -> Result<Arc<Self>> {
        unsafe {
            Self::init(command_pool, bottom_level)
        }
    }

    unsafe fn init(
        command_pool: &Arc<CommandPool>, 
        bottom_level: &Arc<BottomLevelAccelerationStructure>,
    ) -> Result<Arc<Self>> {
        let device = command_pool.queue().device();
        let type_info = VkAccelerationStructureCreateGeometryTypeInfoKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_GEOMETRY_TYPE_INFO_KHR,
            pNext: ptr::null(),
            geometryType: VkGeometryTypeKHR::VK_GEOMETRY_TYPE_INSTANCES_KHR,
            maxPrimitiveCount: 1,
            indexType: VkIndexType::VK_INDEX_TYPE_UINT16,
            maxVertexCount: 0,
            vertexFormat: VkFormat::VK_FORMAT_UNDEFINED,
            allowsTransforms: VK_FALSE,
        };
        let create_info = VkAccelerationStructureCreateInfoKHR {
            sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_CREATE_INFO_KHR,
            pNext: ptr::null(),
            compactedSize: 0,
            r#type: VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR,
            flags: VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR as VkFlags,
            maxGeometryCount: 1,
            pGeometryInfos: &type_info,
            deviceAddress: 0,
        };
        let structure = AccelerationStructure::new(device, &create_info)
            .unwrap();
        let transform_matrix = VkTransformMatrixKHR {
            matrix: [[1.0, 0.0, 0.0, 0.0], 
                    [0.0, 1.0, 0.0, 0.0], 
                    [0.0, 0.0, 1.0, 0.0]],
        };
        let instance = VkAccelerationStructureInstanceKHR {
            transform: transform_matrix,
            instanceCustomIndexAndMask: 0xff << 24,
            instanceShaderBindingTableRecordOffsetAndFlags: 
                (VK_GEOMETRY_INSTANCE_TRIANGLE_FACING_CULL_DISABLE_BIT_KHR as VkFlags) << 24,
            accelerationStructureReference: bottom_level.structure_device_address(),
        };
        let instances_size = std::mem::size_of::<VkAccelerationStructureInstanceKHR>();
        let instances_buffer = DedicatedStagingBuffer::new(command_pool, 
            VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT as VkBufferUsageFlags, 
            VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
            instances_size as VkDeviceSize)
            .unwrap();
        instances_buffer.write(&instance as *const _ as *const c_void, instances_size);
        // build
        {
            let geometry_instances = VkAccelerationStructureGeometryInstancesDataKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_INSTANCES_DATA_KHR,
                pNext: ptr::null(),
                arrayOfPointers: VK_FALSE,
                data: instances_buffer.device_buffer_memory().buffer_device_address(),
            };
            let geometry_data = VkAccelerationStructureGeometryDataKHR {
                instances: geometry_instances,
            };
            let geometry = VkAccelerationStructureGeometryKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_GEOMETRY_KHR,
                pNext: ptr::null(),
                flags: VK_GEOMETRY_OPAQUE_BIT_KHR as VkGeometryFlagsKHR,
                geometryType: VkGeometryTypeKHR::VK_GEOMETRY_TYPE_INSTANCES_KHR,
                geometry: geometry_data,
            };
            let geometry_vec = vec![geometry];
            let scratch_size = structure.scratch_memory_requirements()
                .memoryRequirements.size;
            let scratch_buffer_memory = DedicatedBufferMemory::new(
                device, 
                VK_BUFFER_USAGE_RAY_TRACING_BIT_KHR as VkBufferUsageFlags
                    | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT as VkBufferUsageFlags,
                VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
                scratch_size)
                .unwrap();
            let build_info = VkAccelerationStructureBuildGeometryInfoKHR {
                sType: VK_STRUCTURE_TYPE_ACCELERATION_STRUCTURE_BUILD_GEOMETRY_INFO_KHR,
                pNext: ptr::null(),
                r#type: VK_ACCELERATION_STRUCTURE_TYPE_TOP_LEVEL_KHR,
                flags: VK_BUILD_ACCELERATION_STRUCTURE_PREFER_FAST_TRACE_BIT_KHR as VkFlags,
                update: VK_FALSE,
                srcAccelerationStructure: ptr::null_mut(),
                dstAccelerationStructure: structure.handle(),
                geometryArrayOfPointers: VK_FALSE,
                geometryCount: 1,
                ppGeometries: &geometry_vec.as_ptr() ,
                scratchData: scratch_buffer_memory.buffer_device_address(),
            };
            let offset = VkAccelerationStructureBuildOffsetInfoKHR {
                primitiveCount: 1,
                primitiveOffset: 0,
                firstVertex: 0,
                transformOffset: 0,
            };
            let offset_ptr_vec = vec![&offset as *const VkAccelerationStructureBuildOffsetInfoKHR];
            let command_buffer = CommandBufferBuilder::new(command_pool).build(|command_buffer| {
                dispatch_vkCmdBuildAccelerationStructureKHR(device.handle(), 
                    command_buffer, 1, &build_info, offset_ptr_vec.as_ptr());
            });
            let command_buffers = vec![command_buffer.handle()];
            command_pool.queue()
                .submit_then_wait(command_buffers.as_slice())
                .unwrap();
        }
        let top_level_structure = TopLevelAccelerationStructure {
            instances_buffer,
            structure,
            bottom_level: Arc::clone(bottom_level),
        };
        Ok(Arc::new(top_level_structure))
    }

    #[inline]
    pub fn handle(&self) -> VkAccelerationStructureKHR {
        self.structure.handle()
    }
}


pub struct RayTracingGraphicsPipeline {
    device: Arc<Device>,
    layout: VkPipelineLayout,
    handle: VkPipeline,
    descriptor_set_layout: VkDescriptorSetLayout,
}

impl RayTracingGraphicsPipeline {
    pub fn new(
        device: &Arc<Device>,
    ) -> Result<Arc<Self>> {
        unsafe {
            Self::init(device)
        }
    }

    unsafe fn init(device: &Arc<Device>) -> Result<Arc<Self>> {
        // Descriptor Set Layout
        let mut descriptor_set_layout = MaybeUninit::<VkDescriptorSetLayout>::zeroed();
        {
            let bindings = vec![
                VkDescriptorSetLayoutBinding::new(
                    VkDescriptorType::VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, 
                    VkShaderStageFlagBits::VK_SHADER_STAGE_RAYGEN_BIT_KHR as u32,
                    0,
                ),
                VkDescriptorSetLayoutBinding::new(
                    VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, 
                    VkShaderStageFlagBits::VK_SHADER_STAGE_RAYGEN_BIT_KHR as u32,
                    1,
                ),
                VkDescriptorSetLayoutBinding::new(
                    VkDescriptorType::VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 
                    VkShaderStageFlagBits::VK_SHADER_STAGE_RAYGEN_BIT_KHR as u32,
                    2,
                ),
                VkDescriptorSetLayoutBinding::new(
                    VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 
                    VkShaderStageFlagBits::VK_SHADER_STAGE_CLOSEST_HIT_BIT_KHR as u32,
                    3,
                ),
                VkDescriptorSetLayoutBinding::new(
                    VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 
                    VkShaderStageFlagBits::VK_SHADER_STAGE_CLOSEST_HIT_BIT_KHR as u32,
                    4,
                ),
            ];
            let create_info = VkDescriptorSetLayoutCreateInfo::new(bindings.len() as u32, bindings.as_ptr());
            vkCreateDescriptorSetLayout(device.handle(), &create_info, ptr::null(), descriptor_set_layout.as_mut_ptr())
                .into_result()
                .unwrap();
        }
        let descriptor_set_layout = descriptor_set_layout.assume_init();
        // Pipeline Layout
        let mut pipeline_layout = MaybeUninit::<VkPipelineLayout>::zeroed();
        {
            let create_info = VkPipelineLayoutCreateInfo::new(1, &descriptor_set_layout);
            vkCreatePipelineLayout(device.handle(), &create_info, ptr::null(), pipeline_layout.as_mut_ptr())
                .into_result()
                .unwrap();
        }
        let pipeline_layout = pipeline_layout.assume_init();
        // Shader Stages
        let raygen_shader_module = ShaderModule::new(device, ShaderModuleSource::from_file("data/shaders/ray.raygen.rgen.spv")).unwrap();
        let rmiss_shader_module = ShaderModule::new(device, ShaderModuleSource::from_file("data/shaders/ray.miss.rmiss.spv")).unwrap();
        let rchit_shader_module = ShaderModule::new(device, ShaderModuleSource::from_file("data/shaders/ray.closesthit.rchit.spv")).unwrap();
        let shader_entry_point = CString::new("main").unwrap();
        const INDEX_RAYGEN: u32 = 0;
        const INDEX_MISS: u32 = 1;
        const INDEX_CLOSEST_HIT: u32 = 2;
        let shader_stages = vec![
            VkPipelineShaderStageCreateInfo {
                sType: VkStructureType::VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO,
                pNext: ptr::null(),
                flags: 0,
                stage: VkShaderStageFlagBits::VK_SHADER_STAGE_RAYGEN_BIT_KHR,
                module: raygen_shader_module.handle(),
                pName: shader_entry_point.as_ptr(),
                pSpecializationInfo: ptr::null(),
            },
            VkPipelineShaderStageCreateInfo {
                sType: VkStructureType::VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO,
                pNext: ptr::null(),
                flags: 0,
                stage: VkShaderStageFlagBits::VK_SHADER_STAGE_MISS_BIT_KHR,
                module: rmiss_shader_module.handle(),
                pName: shader_entry_point.as_ptr(),
                pSpecializationInfo: ptr::null(),
            },
            VkPipelineShaderStageCreateInfo {
                sType: VkStructureType::VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO,
                pNext: ptr::null(),
                flags: 0,
                stage: VkShaderStageFlagBits::VK_SHADER_STAGE_CLOSEST_HIT_BIT_KHR,
                module: rchit_shader_module.handle(),
                pName: shader_entry_point.as_ptr(),
                pSpecializationInfo: ptr::null(),
            },
        ];
        let shader_groups = vec![
            VkRayTracingShaderGroupCreateInfoKHR {
                sType: VK_STRUCTURE_TYPE_RAY_TRACING_SHADER_GROUP_CREATE_INFO_KHR,
                pNext: ptr::null(),
                r#type: VkRayTracingShaderGroupTypeKHR::VK_RAY_TRACING_SHADER_GROUP_TYPE_GENERAL_KHR,
                generalShader: INDEX_RAYGEN,
                closestHitShader: VK_SHADER_UNUSED_KHR,
                anyHitShader: VK_SHADER_UNUSED_KHR,
                intersectionShader: VK_SHADER_UNUSED_KHR,
                pShaderGroupCaptureReplayHandle: ptr::null(),
            },
            VkRayTracingShaderGroupCreateInfoKHR {
                sType: VK_STRUCTURE_TYPE_RAY_TRACING_SHADER_GROUP_CREATE_INFO_KHR,
                pNext: ptr::null(),
                r#type: VkRayTracingShaderGroupTypeKHR::VK_RAY_TRACING_SHADER_GROUP_TYPE_GENERAL_KHR,
                generalShader: INDEX_MISS,
                closestHitShader: VK_SHADER_UNUSED_KHR,
                anyHitShader: VK_SHADER_UNUSED_KHR,
                intersectionShader: VK_SHADER_UNUSED_KHR,
                pShaderGroupCaptureReplayHandle: ptr::null(),
            },
            VkRayTracingShaderGroupCreateInfoKHR {
                sType: VK_STRUCTURE_TYPE_RAY_TRACING_SHADER_GROUP_CREATE_INFO_KHR,
                pNext: ptr::null(),
                r#type: VkRayTracingShaderGroupTypeKHR::VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_KHR,
                generalShader: VK_SHADER_UNUSED_KHR,
                closestHitShader: INDEX_CLOSEST_HIT,
                anyHitShader: VK_SHADER_UNUSED_KHR,
                intersectionShader: VK_SHADER_UNUSED_KHR,
                pShaderGroupCaptureReplayHandle: ptr::null(),
            },
        ];
        let libraries = VkPipelineLibraryCreateInfoKHR {
            sType: VK_STRUCTURE_TYPE_PIPELINE_LIBRARY_CREATE_INFO_KHR,
            pNext: ptr::null(),
            libraryCount: 0,
            pLibraries: ptr::null(),
        };
        let create_info = VkRayTracingPipelineCreateInfoKHR {
            sType: VK_STRUCTURE_TYPE_RAY_TRACING_PIPELINE_CREATE_INFO_KHR,
            pNext: ptr::null(),
            flags: 0,
            stageCount: shader_stages.len() as u32,
            pStages: shader_stages.as_ptr(),
            groupCount: shader_groups.len() as u32,
            pGroups: shader_groups.as_ptr(),
            maxRecursionDepth: 1,
            libraries: libraries,
            pLibraryInterface: ptr::null(),
            layout: pipeline_layout,
            basePipelineHandle: ptr::null_mut(),
            basePipelineIndex: 0,
        };
        let mut handle = MaybeUninit::<VkPipeline>::zeroed();
        vkCreateRayTracingPipelinesKHR(device.handle(), ptr::null_mut(), 1, &create_info, ptr::null(), handle.as_mut_ptr())
            .into_result()
            .unwrap();
        let handle = handle.assume_init();
        let layout = RayTracingGraphicsPipeline {
            device: Arc::clone(device),
            layout: pipeline_layout,
            handle,
            descriptor_set_layout,
        };
        Ok(Arc::new(layout))
    }

    #[inline]
    pub fn layout(&self) -> VkPipelineLayout {
        self.layout
    }

    #[inline]
    pub fn handle(&self) -> VkPipeline {
        self.handle
    }

    #[inline]
    pub fn descriptor_set_layout(&self) -> VkDescriptorSetLayout {
        self.descriptor_set_layout
    }

    #[inline]
    pub fn device(&self) -> &Arc<Device> {
        &self.device
    }
}

impl Drop for RayTracingGraphicsPipeline {
    fn drop(&mut self) {
        log_debug!("Drop RayTracingGraphicsPipeline");
        unsafe {
            let device = &self.device;
            vkDestroyPipelineLayout(device.handle(), self.layout, ptr::null());
            vkDestroyDescriptorSetLayout(device.handle(), self.descriptor_set_layout, ptr::null());
            vkDestroyPipeline(device.handle(), self.handle, ptr::null());
        }
    }
}

pub struct RayTracingDescriptorSets {
    device: Arc<Device>,
    pipeline: Arc<RayTracingGraphicsPipeline>,
    acceleration_structure: Arc<TopLevelAccelerationStructure>,
    storage_image: Arc<ColorImage>,
    scene_uniform_buffer: Arc<UniformBuffer>,
    vertex_storage_buffer: Arc<StorageBuffer>,
    index_storage_buffer: Arc<StorageBuffer>,
    descriptor_pool: VkDescriptorPool,
    descriptor_set: VkDescriptorSet,
}

impl RayTracingDescriptorSets {
    pub fn new(
        pipeline: &Arc<RayTracingGraphicsPipeline>, 
        acceleration_structure: &Arc<TopLevelAccelerationStructure>,
        storage_image: &Arc<ColorImage>,
        scene_uniform_buffer: &Arc<UniformBuffer>,
        vertex_storage_buffer: &Arc<StorageBuffer>,
        index_storage_buffer: &Arc<StorageBuffer>,
    ) -> Result<Arc<Self>> {
        unsafe {
            Self::init(pipeline, acceleration_structure, storage_image, scene_uniform_buffer, vertex_storage_buffer, index_storage_buffer)
        }
    }

    unsafe fn init(
        pipeline: &Arc<RayTracingGraphicsPipeline>, 
        acceleration_structure: &Arc<TopLevelAccelerationStructure>,
        storage_image: &Arc<ColorImage>,
        scene_uniform_buffer: &Arc<UniformBuffer>,
        vertex_storage_buffer: &Arc<StorageBuffer>,
        index_storage_buffer: &Arc<StorageBuffer>,
    ) -> Result<Arc<Self>> {
        let device = pipeline.device();
        // Descriptor Pool
        let mut descriptor_pool = MaybeUninit::<VkDescriptorPool>::zeroed();
        {
            let sizes = vec![
                VkDescriptorPoolSize::new(VkDescriptorType::VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR, 1),
                VkDescriptorPoolSize::new(VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, 1),
                VkDescriptorPoolSize::new(VkDescriptorType::VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER, 1),
                VkDescriptorPoolSize::new(VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1),
                VkDescriptorPoolSize::new(VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER, 1),
            ];
            let create_info = VkDescriptorPoolCreateInfo::new(1, sizes.len() as u32, sizes.as_ptr());
            vkCreateDescriptorPool(device.handle(), &create_info, ptr::null(), descriptor_pool.as_mut_ptr())
                .into_result()
                .unwrap();
        }
        let descriptor_pool = descriptor_pool.assume_init();
        // Allocate Descriptor Set
        let mut descriptor_set = MaybeUninit::<VkDescriptorSet>::zeroed();
        {
            let descriptor_set_layout = pipeline.descriptor_set_layout();
            let alloc_info = VkDescriptorSetAllocateInfo::new(descriptor_pool, 1, &descriptor_set_layout);
            vkAllocateDescriptorSets(device.handle(), &alloc_info, descriptor_set.as_mut_ptr())
                .into_result()
                .unwrap();
        }
        let descriptor_set = descriptor_set.assume_init();
        let acceleration_structure_handle = acceleration_structure.handle();
        let write_acceleration_structure_info = VkWriteDescriptorSetAccelerationStructureKHR {
            sType: VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET_ACCELERATION_STRUCTURE_KHR,
            pNext: ptr::null(),
            accelerationStructureCount: 1,
            pAccelerationStructures: &acceleration_structure_handle,
        };
        let write_acceleration_structure = VkWriteDescriptorSet {
            sType: VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET,
            pNext: &write_acceleration_structure_info as *const _ as *const c_void,
            dstSet: descriptor_set,
            dstBinding: 0,
            dstArrayElement: 0,
            descriptorCount: 1,
            descriptorType: VkDescriptorType::VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_KHR,
            pImageInfo: ptr::null(),
            pBufferInfo: ptr::null(),
            pTexelBufferView: ptr::null(),
        };
        let write_image_info = VkDescriptorImageInfo {
            sampler: ptr::null_mut(),
            imageView: storage_image.view(),
            imageLayout: VkImageLayout::VK_IMAGE_LAYOUT_GENERAL,
        };
        let write_image = VkWriteDescriptorSet::from_image(descriptor_set, 
            VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_IMAGE,
            1,
            &write_image_info);
        let write_uniform_buffer_info = VkDescriptorBufferInfo {
            buffer: scene_uniform_buffer.device_buffer_memory().buffer(),
            offset: 0,
            range: scene_uniform_buffer.device_buffer_memory().size(),
        };
        let write_uniform_buffer = VkWriteDescriptorSet::from_buffer(descriptor_set, 
            VkDescriptorType::VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER,
            2,
            &write_uniform_buffer_info);
        let write_vertex_buffer_info = VkDescriptorBufferInfo {
            buffer: vertex_storage_buffer.device_buffer_memory().buffer(),
            offset: 0,
            range: vertex_storage_buffer.device_buffer_memory().size(),
        };
        let write_vertex_buffer = VkWriteDescriptorSet::from_buffer(descriptor_set, 
            VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
            3,
            &write_vertex_buffer_info);
        let write_index_buffer_info = VkDescriptorBufferInfo {
            buffer: index_storage_buffer.device_buffer_memory().buffer(),
            offset: 0,
            range: index_storage_buffer.device_buffer_memory().size(),
        };
        let write_index_buffer = VkWriteDescriptorSet::from_buffer(descriptor_set, 
            VkDescriptorType::VK_DESCRIPTOR_TYPE_STORAGE_BUFFER,
            4,
            &write_index_buffer_info);
        let write_descriptor_sets = vec![
            write_acceleration_structure,
            write_image,
            write_uniform_buffer,
            write_vertex_buffer,
            write_index_buffer,
        ];
        vkUpdateDescriptorSets(device.handle(), 
            write_descriptor_sets.len() as u32, 
            write_descriptor_sets.as_ptr(), 
            0, 
            ptr::null());
        let descriptors = Self {
            device: Arc::clone(device),
            pipeline: Arc::clone(pipeline),
            acceleration_structure: Arc::clone(acceleration_structure),
            storage_image: Arc::clone(storage_image),
            scene_uniform_buffer: Arc::clone(scene_uniform_buffer),
            vertex_storage_buffer: Arc::clone(vertex_storage_buffer),
            index_storage_buffer: Arc::clone(index_storage_buffer),
            descriptor_pool,
            descriptor_set,
        };
        Ok(Arc::new(descriptors))
    }

    #[inline]
    pub fn handle(&self) -> VkDescriptorSet {
        self.descriptor_set
    }
}

impl Drop for RayTracingDescriptorSets {
    fn drop(&mut self) {
        unsafe {
            let device = &self.device;
            vkDestroyDescriptorPool(device.handle(), self.descriptor_pool, ptr::null());
        }
    }
}

pub struct ShaderBindingTable {
    staging_buffer: Arc<DedicatedStagingBuffer>,
    pipeline: Arc<RayTracingGraphicsPipeline>,
}

impl ShaderBindingTable {
    pub fn new(command_pool: &Arc<CommandPool>, pipeline: &Arc<RayTracingGraphicsPipeline>) -> Result<Arc<Self>> {
        unsafe {
            Self::init(command_pool, pipeline)
        }
    }

    unsafe fn init(command_pool: &Arc<CommandPool>, pipeline: &Arc<RayTracingGraphicsPipeline>) -> Result<Arc<Self>> {
        let device = command_pool.queue().device();
        let properties = device.physical_device().properties_ray_tracing();
        let table_size = (properties.shaderGroupHandleSize * 3) as VkDeviceSize;
        let staging_buffer = DedicatedStagingBuffer::new(command_pool, 
            VK_BUFFER_USAGE_TRANSFER_SRC_BIT as VkBufferUsageFlags 
                | VK_BUFFER_USAGE_RAY_TRACING_BIT_KHR as VkBufferUsageFlags,
            VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT as VkMemoryPropertyFlags,
            table_size)
            .unwrap();
        staging_buffer.update(table_size, |data| {
            vkGetRayTracingShaderGroupHandlesKHR(device.handle(), pipeline.handle(), 0, 3, table_size as size_t, data)
                .into_result()
                .unwrap();
        });
        let table = Self {
            staging_buffer,
            pipeline: Arc::clone(pipeline),
        };
        Ok(Arc::new(table))
    }

    #[inline]
    fn buffer(&self) -> VkBuffer {
        self.staging_buffer.device_buffer_memory().buffer()
    }
}

pub struct RayTracingGraphicsRender {
    command_pool: Arc<CommandPool>,
    pipeline: Arc<RayTracingGraphicsPipeline>,
    descriptor_sets: Arc<RayTracingDescriptorSets>,
    shader_binding_table: Arc<ShaderBindingTable>,
    properties: Arc<VkPhysicalDeviceRayTracingPropertiesKHR>,
}

impl RayTracingGraphicsRender {
    pub fn new(
        command_pool: &Arc<CommandPool>, 
        pipeline: &Arc<RayTracingGraphicsPipeline>,
        descriptor_sets: &Arc<RayTracingDescriptorSets>,
    ) -> Result<Arc<Self>> {
        unsafe {
            Self::init(command_pool, pipeline, descriptor_sets)
        }
    }

    unsafe fn init(
        command_pool: &Arc<CommandPool>, 
        pipeline: &Arc<RayTracingGraphicsPipeline>,
        descriptor_sets: &Arc<RayTracingDescriptorSets>,
    ) -> Result<Arc<Self>> {
        let shader_binding_table = ShaderBindingTable::new(command_pool, pipeline)
            .unwrap();
        let device = command_pool.queue().device();
        let properties = device.physical_device().properties_ray_tracing();
        let render = Self {
            command_pool: Arc::clone(command_pool),
            pipeline: Arc::clone(pipeline),
            descriptor_sets: Arc::clone(descriptor_sets),
            shader_binding_table,
            properties: Arc::new(properties),
        };
        Ok(Arc::new(render))
    }

    pub unsafe fn command(&self, command_buffer: VkCommandBuffer, area: VkRect2D) {
        let device = self.command_pool.queue().device();
        let shader_binding_table = &self.shader_binding_table;
        let handle_size = self.properties.shaderGroupHandleSize as VkDeviceSize;
        let raygen_entry = VkStridedBufferRegionKHR {
            buffer: shader_binding_table.buffer(),
            offset: handle_size * 0,
            stride: 0,
            size: handle_size,
        };
        let miss_entry = VkStridedBufferRegionKHR {
            buffer: shader_binding_table.buffer(),
            offset: handle_size * 1,
            stride: 0,
            size: handle_size,
        };
        let hit_entry = VkStridedBufferRegionKHR {
            buffer: shader_binding_table.buffer(),
            offset: handle_size * 2,
            stride: 0,
            size: handle_size,
        };
        let callable_entry = VkStridedBufferRegionKHR::default();
        let descriptor_set = self.descriptor_sets.handle();
        vkCmdBindPipeline(command_buffer, VkPipelineBindPoint::VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR, self.pipeline.handle());
        vkCmdBindDescriptorSets(command_buffer, VkPipelineBindPoint::VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR,
            self.pipeline.layout(), 0, 1, &descriptor_set, 0, ptr::null());
        dispatch_vkCmdTraceRaysKHR(device.handle(), 
            command_buffer, 
            &raygen_entry, 
            &miss_entry, 
            &hit_entry, 
            &callable_entry, 
            area.extent.width, 
            area.extent.height, 
            1);
    }
}