gridoxide-core 0.1.0

//! Observability analysis: which parts of the state the measurements actually
//! determine.
//!
//! An unobservable system is not a numerical accident, and treating it as one
//! produces the worst diagnostic in the library: `SeStatus::Singular`, which
//! says a factorization failed and nothing about why. The useful answer names
//! the unknowns nobody is watching.
//!
//! # Two kinds of unobservable
//!
//! **Structural.** A column of `H` that is identically zero: no measurement
//! function mentions that unknown at all. [`super::nr::estimate`] already finds
//! these and pins them, because it has to — they would make the gain matrix
//! singular on their own. In gridoxide they are usually the virtual slack buses
//! synthesized per source.
//!
//! **Numerical.** A column that is present but linearly dependent on the
//! others. Two branch-flow measurements on a radial feeder with no injection
//! measurement between them constrain the same combination of angles twice and
//! leave another combination free. Nothing about the sparsity pattern gives this
//! away; it takes a rank computation.
//!
//! # Why pivoted Cholesky
//!
//! `G = HᵀWH` is symmetric positive *semi*definite by construction, and for
//! that class the standard rank-revealing factorization is a Cholesky with
//! symmetric diagonal pivoting: pivots are taken largest-first, and the
//! factorization stops when the largest remaining diagonal falls below a
//! tolerance. The number of steps taken is the rank, and the unknowns left in
//! the trailing block are the ones the measurements do not pin down.
//!
//! The factorization itself is `faer`'s
//! (`linalg::cholesky::llt_pivoting`) — blocked and vectorized, rather than the
//! naive triple loop this module originally carried.
//!
//! The rank *decision*, however, is made here rather than taken from faer's
//! `PivLltInfo::rank`. faer stops at `eps · n · max_diag`, i.e. around 1e-16
//! relative: the threshold for "numerically not positive definite".
//! Observability wants a much looser one. A grid whose measurements determine a
//! direction only barely — a weak coupling that survives at 1e-12 of the
//! leading pivot — is unobservable for every practical purpose, and reporting
//! it as observable would be a worse answer than reporting it as not. So the
//! factor's diagonal is thresholded here at [`RANK_TOLERANCE`], relative to the
//! largest pivot, and faer's own rank is an upper bound on the result.
//!
//! The alternative — reading zero pivots out of the LU that
//! [`crate::solver::LinearSolver`] already computes — was the first choice,
//! but none of the five backends expose their pivots (`faer`'s
//! `ColPivQr` has no rank accessor, and `klu_native::factor` returns only
//! `Option<Numeric>`). Widening the trait would force all five to implement
//! something only this module wants.
//!
//! The cost is that this densifies `G`, so it is `O(n³)` time and `O(n²)`
//! memory. That is fine for an analysis pass on the grids this is useful for and
//! wrong for a large one, so [`analyze`] refuses above [`DENSE_LIMIT`] rather
//! than quietly allocating gigabytes. A sparse rank-revealing method is the
//! follow-up.

use faer::dyn_stack::{MemBuffer, MemStack};
use faer::linalg::cholesky::llt_pivoting::factor::{cholesky_in_place, cholesky_in_place_scratch};
use faer::{Mat, Par};

use crate::measurement::Measurement;
use crate::types::Bus;

use super::SeNetwork;
use super::jacobian::{StateLayout, measurement_jacobian};

/// Largest state dimension [`analyze`] will densify, chosen so the gain matrix
/// stays under ~32 MB (`2000² × 8` bytes).
pub const DENSE_LIMIT: usize = 2000;

/// Relative pivot threshold below which a column counts as dependent.
///
/// Applied against the largest pivot, which makes the check a statement about
/// the gain matrix's *conditioning* as much as its rank — and on a network with
/// a very stiff source those are not the same question. gridoxide expands a
/// source into an impedance branch whose admittance follows `sk`, so a fixture
/// with `sk = 1e10` carries branch admittances of order 1e7; squared into the
/// gain matrix and weighted, the pivots span some fourteen decades, and a
/// voltage row's own contribution of order 1e4 falls below this threshold
/// relative to them. The report then names most of the network unobservable
/// when nothing of the sort is true.
///
/// Not a reason to loosen the threshold, which would blind it to genuine
/// dependence. It is a reason to read a report on such a network with the
/// conditioning in mind, and to answer a question about *symmetries* — which is
/// usually what "is this observable" means — by asking the measurement functions
/// directly, as `tests/se_three_phase_test.rs` does.
pub const RANK_TOLERANCE: f64 = 1e-10;

/// Which of a bus's two unknowns an [`Unknown`] refers to.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum Quantity {
    Angle,
    Magnitude,
}

/// One state variable, named in terms of the grid rather than of the solver.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub struct Unknown {
    pub bus: usize,
    pub quantity: Quantity,
}

/// What the measurements do and do not determine.
#[derive(Clone, Debug)]
pub struct ObservabilityReport {
    pub n_unknowns: usize,
    /// Rank of the gain matrix. Equal to `n_unknowns` exactly when the state is
    /// fully observable.
    pub rank: usize,
    /// Unknowns no measurement function mentions at all.
    pub structurally_unmeasured: Vec<Unknown>,
    /// Unknowns left undetermined once linear dependence is accounted for.
    ///
    /// A superset of [`structurally_unmeasured`](Self::structurally_unmeasured)
    /// in effect — a zero column is also rank-deficient — though the specific
    /// variables reported can differ, since which member of a dependent group
    /// gets blamed depends on the pivot order. The *count* is what is
    /// meaningful; the names are representatives.
    pub unobservable: Vec<Unknown>,
    /// Set when the system was too large to analyze densely, in which case only
    /// the structural half of the report is filled in.
    pub skipped_numerical: bool,
    /// Unknowns belonging to buses that carry no voltage at all.
    ///
    /// These are not a gap in the sensor plan and no sensor would close them.
    /// A de-energized bus is reported at exactly zero by every estimator path
    /// here — `nr::estimate` writes it, `iterative::estimate` skips its rows,
    /// `linear_start` starts it there — so its columns are determined by the
    /// network rather than by measurements, and they are zero columns of `H` by
    /// construction. Counting them against the rank would report every CGMES
    /// model containing one switched-out node as unobservable, which is the
    /// same mistake, in the same function, that ignoring constraint rows was.
    ///
    /// They are excluded from
    /// [`structurally_unmeasured`](Self::structurally_unmeasured),
    /// [`unobservable`](Self::unobservable) and
    /// [`is_observable`](Self::is_observable), and reported here instead.
    pub de_energized: Vec<Unknown>,
    /// A global-angle current sensor is present with nothing to measure its
    /// angle against.
    ///
    /// Such a sensor reports `I = i·e^{jθ}` with `θ` absolute, which is only
    /// meaningful if something else fixes what that reference *is*. With no
    /// voltage angle in the set, [`StateLayout`] pins a reference bus instead —
    /// and that pin is then a false constraint, rotating the estimate away from
    /// the angle the sensor actually measured. The rank check will not catch it,
    /// because the system is perfectly determined; it is determined to the wrong
    /// thing.
    ///
    /// power-grid-model refuses to run at all here, raising `NotObservableError`
    /// with "Global angle current sensors require at least one voltage angle
    /// measurement as a reference point". gridoxide reports rather than refuses,
    /// on the grounds that this analysis is the place that says what is wrong
    /// and the estimator's job is to answer the question it was asked.
    pub global_current_without_angle_reference: bool,
}

impl ObservabilityReport {
    /// Whether every state variable is determined.
    ///
    /// Deliberately does *not* fold in
    /// [`global_current_without_angle_reference`](Self::global_current_without_angle_reference):
    /// that state is fully determined, just to the wrong reference, and calling
    /// it unobservable would misname it.
    pub fn is_observable(&self) -> bool {
        self.rank + self.de_energized.len() == self.n_unknowns
            && self.structurally_unmeasured.is_empty()
    }
}

/// Names the bus and quantity a state-vector column refers to.
fn describe(layout: &StateLayout, col: usize) -> Unknown {
    let magnitude_start = layout.vmag(0);
    if col >= magnitude_start {
        Unknown {
            bus: col - magnitude_start,
            quantity: Quantity::Magnitude,
        }
    } else {
        let bus = (0..layout.n_buses)
            .find(|&b| layout.theta(b) == Some(col))
            .expect("angle column belongs to some bus");
        Unknown {
            bus,
            quantity: Quantity::Angle,
        }
    }
}

/// Rank of a symmetric positive semidefinite matrix, and the pivot order.
///
/// Returns `(rank, permutation)`: the first `rank` entries of the permutation
/// are the columns that were eliminated with a pivot above threshold, and the
/// tail is the deficient block — the unknowns the measurements do not
/// determine.
///
/// The factorization is faer's blocked pivoted `LLᵀ`; the rank decision is this
/// module's, for the reason given in the module comment. `None` means the
/// factorization itself failed (a NaN pivot), which for a gain matrix means the
/// inputs were already corrupt rather than merely rank-deficient.
fn pivoted_cholesky_rank(mut a: Mat<f64>, tol: f64) -> Option<(usize, Vec<usize>)> {
    let n = a.nrows();
    if n == 0 {
        return Some((0, Vec::new()));
    }

    let mut perm = vec![0usize; n];
    let mut perm_inv = vec![0usize; n];
    // `MemBuffer` rather than a hand-rolled byte vector: faer's scratch is
    // allocated as `f64`, and a plain `Vec<u8>` is not guaranteed to be aligned
    // for that, so the stack silently loses bytes to alignment and then runs
    // out.
    let mut buffer = MemBuffer::new(cholesky_in_place_scratch::<usize, f64>(
        n,
        Par::Seq,
        Default::default(),
    ));
    let stack = MemStack::new(&mut buffer);

    let (info, _) = cholesky_in_place(
        a.as_mut(),
        &mut perm,
        &mut perm_inv,
        Par::Seq,
        stack,
        Default::default(),
    )
    .ok()?;

    // faer stopped either at full rank or at its own eps-level threshold; apply
    // the looser observability threshold to the pivots it did compute. The
    // diagonal holds L's entries, so a pivot is the square of its diagonal.
    let pivots: Vec<f64> = (0..info.rank).map(|k| a[(k, k)] * a[(k, k)]).collect();
    let largest = pivots.iter().copied().fold(0.0f64, f64::max);
    let rank = if largest <= 0.0 {
        0
    } else {
        pivots.iter().take_while(|&&p| p > tol * largest).count()
    };

    Some((rank, perm))
}

/// Analyzes what `measurements` determine about the state at `buses`.
///
/// The analysis is linearization-dependent: `H` is evaluated at the state it is
/// given, so a flat start and a converged estimate can in principle disagree.
/// In practice observability is a structural property and they do not, but the
/// honest reading of a report is "at this operating point".
pub fn analyze(
    measurements: &[Measurement],
    buses: &[Bus],
    net: &SeNetwork,
    layout: &StateLayout,
    constraints: &crate::se::constraints::Constraints,
) -> ObservabilityReport {
    let n = layout.n_unknowns();

    // Measurements *and* constraints determine state, and until now only the
    // former were counted — so a bus whose voltage is fixed by a zero-injection
    // constraint was reported unobservable even though the estimator solves it
    // exactly. `se::constraints::augment` has always put these rows into the
    // system; this analysis simply did not know about them.
    //
    // A constraint is a hard equality, i.e. a measurement of unbounded weight.
    // Rank does not depend on the magnitude — `rank(HᵀWH) = rank(H)` for any
    // positive `W` — so unit weight is the right choice here, and avoids
    // putting a huge number into a matrix that is about to be factorized.
    let mut rows = measurement_jacobian(measurements, buses, net, layout);
    let mut weights: Vec<f64> = measurements.iter().map(|m| m.weight()).collect();
    let (_, constraint_rows) = constraints.evaluate(buses, net, layout);
    let n_constraints = constraint_rows.len();
    rows.extend(constraint_rows);
    weights.extend(std::iter::repeat_n(1.0, n_constraints));

    // A global-angle current sensor supplies an absolute phase; a voltage angle
    // is what gives that phase a meaning. `StateLayout` pins a reference bus
    // when no voltage angle exists, which would silently contradict the sensor.
    let has_global_current = measurements.iter().any(|m| {
        matches!(
            m.target,
            crate::measurement::Target::BranchTerminalCurrent {
                frame: crate::measurement::AngleFrame::Global,
                ..
            }
        ) && m.weight() > 0.0
    });
    let has_voltage_angle = measurements
        .iter()
        .any(|m| m.kind == crate::measurement::MeasurementKind::VoltageAngle && m.weight() > 0.0);
    let global_current_without_angle_reference = has_global_current && !has_voltage_angle;

    // Structural half: a column no row mentions with a nonzero coefficient.
    // Note this asks for a nonzero *value*, unlike the estimator's mask, which
    // deliberately asks only for structural presence so its sparsity pattern
    // stays fixed. Here there is no pattern to preserve and the stronger
    // question is the useful one.
    let mut touched = vec![false; n];
    for row in &rows {
        for &(c, v) in row {
            if v != 0.0 {
                touched[c] = true;
            }
        }
    }
    let live = |u: &Unknown| net.energized.get(u.bus).copied().unwrap_or(true);
    let de_energized: Vec<Unknown> = (0..n)
        .map(|c| describe(layout, c))
        .filter(|u| !live(u))
        .collect();
    let untouched = (0..n).filter(|&c| !touched[c]).count();
    let structurally_unmeasured: Vec<Unknown> = (0..n)
        .filter(|&c| !touched[c])
        .map(|c| describe(layout, c))
        .filter(live)
        .collect();

    if n > DENSE_LIMIT {
        return ObservabilityReport {
            n_unknowns: n,
            rank: n - untouched,
            structurally_unmeasured,
            unobservable: Vec::new(),
            de_energized,
            skipped_numerical: true,
            global_current_without_angle_reference,
        };
    }

    let mut g = Mat::<f64>::zeros(n, n);
    for (row, &w) in rows.iter().zip(&weights) {
        if !w.is_finite() || w == 0.0 {
            continue;
        }
        for &(i, hi) in row {
            for &(j, hj) in row {
                g[(i, j)] += w * hi * hj;
            }
        }
    }

    let Some((rank, perm)) = pivoted_cholesky_rank(g, RANK_TOLERANCE) else {
        // A gain matrix that cannot be factorized at all is not a statement
        // about observability; report nothing determined rather than guess.
        return ObservabilityReport {
            n_unknowns: n,
            rank: 0,
            structurally_unmeasured,
            unobservable: (0..n).map(|c| describe(layout, c)).filter(live).collect(),
            de_energized,
            skipped_numerical: false,
            global_current_without_angle_reference,
        };
    };
    let unobservable = perm[rank..]
        .iter()
        .map(|&c| describe(layout, c))
        .filter(live)
        .collect();

    ObservabilityReport {
        n_unknowns: n,
        rank,
        structurally_unmeasured,
        unobservable,
        de_energized,
        skipped_numerical: false,
        global_current_without_angle_reference,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::branch_flow::Terminal;
    use crate::measurement::{MeasurementKind, Target};
    use crate::se::constraints::Constraints;

    fn m(kind: MeasurementKind, target: Target) -> Measurement {
        Measurement {
            kind,
            target,
            value: 0.0,
            sigma: 0.01,
        }
    }

    /// Builds a dense matrix from rows, for the kernel tests.
    fn mat(rows: &[&[f64]]) -> Mat<f64> {
        let n = rows.len();
        let mut m = Mat::<f64>::zeros(n, n);
        for (i, row) in rows.iter().enumerate() {
            for (j, &v) in row.iter().enumerate() {
                m[(i, j)] = v;
            }
        }
        m
    }

    #[test]
    fn identity_is_full_rank() {
        let (rank, _) = pivoted_cholesky_rank(mat(&[&[1.0, 0.0], &[0.0, 1.0]]), RANK_TOLERANCE)
            .expect("factorizable");
        assert_eq!(rank, 2);
    }

    /// A rank-1 matrix built as `v vᵀ` must be detected as rank 1, and the
    /// pivot order must put the dependent column last.
    #[test]
    fn rank_one_outer_product_is_rank_one() {
        let v = [1.0, 2.0, -1.0];
        let rows: Vec<Vec<f64>> = (0..3)
            .map(|i| (0..3).map(|j| v[i] * v[j]).collect())
            .collect();
        let refs: Vec<&[f64]> = rows.iter().map(|r| r.as_slice()).collect();
        let (rank, _) = pivoted_cholesky_rank(mat(&refs), RANK_TOLERANCE).expect("factorizable");
        assert_eq!(rank, 1, "v v^T has rank 1");
    }

    /// The tolerance is relative, so a uniformly tiny matrix is still full rank
    /// — otherwise a grid measured entirely by high-sigma sensors would be
    /// reported unobservable purely because its weights are small.
    #[test]
    fn rank_detection_is_scale_free() {
        let (rank, _) = pivoted_cholesky_rank(mat(&[&[1e-12, 0.0], &[0.0, 1e-12]]), RANK_TOLERANCE)
            .expect("factorizable");
        assert_eq!(rank, 2);
    }

    /// Enough measurements to determine the whole state: full rank, nothing
    /// unobservable.
    #[test]
    fn well_measured_system_is_observable() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let measurements = vec![
            m(MeasurementKind::VoltageMagnitude, Target::Bus(0)),
            m(MeasurementKind::VoltageMagnitude, Target::Bus(1)),
            m(MeasurementKind::ActivePower, Target::Bus(1)),
            m(MeasurementKind::ReactivePower, Target::Bus(1)),
            m(
                MeasurementKind::ActivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);
        let report = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );
        assert!(
            report.is_observable(),
            "expected observable, got {report:?}"
        );
        assert_eq!(report.rank, report.n_unknowns);
    }

    /// A zero-injection constraint determines state just as a measurement does,
    /// and the report has to say so.
    ///
    /// This was wrong until `analyze` took the constraints: `se::constraints`
    /// has always put these rows into the system the estimator actually solves,
    /// so a state they determine *is* estimated — but the observability report
    /// looked only at measurements and called it unobservable, sending a user
    /// hunting for a sensor they do not need. Node-breaker models make it acute,
    /// since a merged group's internal structure is entirely
    /// constraint-determined, but it was already wrong on ordinary data.
    #[test]
    fn a_zero_injection_constraint_makes_state_observable() {
        let (net, buses) = crate::se::tests::two_bus_net();
        // Bus 1's own injection is not measured; only its magnitude is.
        let measurements = vec![
            m(MeasurementKind::VoltageMagnitude, Target::Bus(0)),
            m(MeasurementKind::VoltageMagnitude, Target::Bus(1)),
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);

        let without = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );
        assert!(
            !without.is_observable(),
            "the fixture must be under-determined without help"
        );

        // Declaring bus 1 a zero-injection node supplies the missing rows.
        let mut flags = vec![false; buses.len()];
        flags[1] = true;
        let with = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&flags),
        );
        assert!(
            with.rank > without.rank,
            "a zero-injection constraint determined nothing: rank {} vs {}",
            with.rank,
            without.rank
        );
    }

    /// Constraints must not be able to *reduce* what is reported as
    /// determined — adding rows to a rank computation can only raise it.
    #[test]
    fn constraints_never_lower_the_reported_rank() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let measurements = vec![
            m(MeasurementKind::VoltageMagnitude, Target::Bus(0)),
            m(MeasurementKind::VoltageMagnitude, Target::Bus(1)),
            m(MeasurementKind::ActivePower, Target::Bus(1)),
            m(MeasurementKind::ReactivePower, Target::Bus(1)),
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);
        let bare = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );

        let mut flags = vec![false; buses.len()];
        flags[1] = true;
        let constrained = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&flags),
        );
        assert!(constrained.rank >= bare.rank);
        assert!(constrained.structurally_unmeasured.len() <= bare.structurally_unmeasured.len());
    }

    /// One voltage magnitude cannot determine three unknowns, and the report
    /// should say which — this is the diagnosis that replaces a bare
    /// `Singular`.
    #[test]
    fn under_measured_system_names_what_is_missing() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let measurements = vec![m(MeasurementKind::VoltageMagnitude, Target::Bus(0))];
        let layout = StateLayout::new(&buses, &measurements, &net);
        let report = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );

        assert!(!report.is_observable());
        assert_eq!(report.rank, 1, "only the measured magnitude is determined");
        assert_eq!(report.unobservable.len(), report.n_unknowns - 1);
        // The measured bus's magnitude is the one thing that *is* observable.
        assert!(
            !report.unobservable.contains(&Unknown {
                bus: 0,
                quantity: Quantity::Magnitude
            }),
            "the measured quantity must not be reported unobservable: {report:?}"
        );
    }

    /// The case structural detection cannot see: every column is touched, and
    /// the state is still not determined.
    ///
    /// Two measurements at one branch terminal reach all three unknowns of this
    /// network — the near bus's angle and both magnitudes — so nothing is
    /// structurally missing and the estimator's own mask would report a clean
    /// bill. But two numbers cannot fix three unknowns, and only the rank
    /// computation says so. This is the capability the module exists for, on a
    /// network rather than on a hand-built matrix.
    #[test]
    fn structurally_complete_but_rank_deficient_is_caught() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let measurements = vec![
            m(
                MeasurementKind::ActivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
            m(
                MeasurementKind::ReactivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);
        let report = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );

        assert_eq!(report.n_unknowns, 3);
        assert!(
            report.structurally_unmeasured.is_empty(),
            "every unknown is reached by a measurement, so structure alone sees no problem: {report:?}"
        );
        assert_eq!(
            report.rank, 2,
            "two measurements cannot determine three unknowns"
        );
        assert!(!report.is_observable());
        assert_eq!(report.unobservable.len(), 1);
    }

    /// Redundant sensors add confidence, not rank.
    ///
    /// A third measurement duplicating the first leaves the rank where it was —
    /// the naive check of "enough measurements for the unknowns" would pass here
    /// and be wrong.
    #[test]
    fn a_duplicate_measurement_adds_no_rank() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let flow = m(
            MeasurementKind::ActivePower,
            Target::BranchTerminal {
                branch: 0,
                terminal: Terminal::From,
            },
        );
        let measurements = vec![
            flow,
            m(
                MeasurementKind::ReactivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
            // Same quantity, same terminal, independently reported.
            flow,
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);
        let report = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );

        assert_eq!(
            measurements.len(),
            report.n_unknowns,
            "as many rows as unknowns"
        );
        assert_eq!(report.rank, 2, "but only two of them are independent");
        assert!(!report.is_observable(), "{report:?}");
    }

    /// Measuring only powers leaves the global phase free, which is exactly the
    /// invariance `StateLayout` pins a reference for. With the reference pinned
    /// the remaining angles are determined; this checks the pinning actually
    /// buys observability rather than merely making the matrix square.
    #[test]
    fn pinned_reference_makes_angles_observable() {
        let (net, buses) = crate::se::tests::two_bus_net();
        let measurements = vec![
            m(MeasurementKind::VoltageMagnitude, Target::Bus(0)),
            m(MeasurementKind::VoltageMagnitude, Target::Bus(1)),
            m(
                MeasurementKind::ActivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
            m(
                MeasurementKind::ReactivePower,
                Target::BranchTerminal {
                    branch: 0,
                    terminal: Terminal::From,
                },
            ),
        ];
        let layout = StateLayout::new(&buses, &measurements, &net);
        assert!(
            layout.angle_ref.is_some(),
            "no angle measured, so one is pinned"
        );
        let report = analyze(
            &measurements,
            &buses,
            &net,
            &layout,
            &Constraints::from_flags(&[]),
        );
        assert!(report.is_observable(), "{report:?}");
    }
}