fuel-transformers 0.19.1

Minimalist ML framework.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
// SPDX-License-Identifier: MIT OR Apache-2.0
//! Marian NMT (Helsinki-NLP / Opus MT) ported to the lazy-graph API.
//!
//! Phase D specialized port. Marian is the **first encoder-decoder
//! port** in the Phase D lineup — every prior model has been
//! decoder-only. The architecture is a classic Transformer with:
//!
//!   1. **Separate encoder + decoder stacks** sharing a token
//!      embedding (`share_encoder_decoder_embeddings = true` for
//!      every Opus MT preset shipped).
//!   2. **Sinusoidal positional embeddings** — precomputed
//!      `(max_positions, d_model)` table with
//!      `[sin(t * inv_freq), cos(t * inv_freq)]` concat along the
//!      feature axis. No RoPE.
//!   3. **Post-LN sublayer structure**: `LN(x + sublayer(x))`.
//!      Each sublayer (self-attn, cross-attn, ffn) ends with its
//!      own LayerNorm.
//!   4. **Decoder cross-attention**: Q from decoder state, K/V
//!      from the (single) encoder output. This is the
//!      defining feature of an encoder-decoder model.
//!   5. **Q scaled by `head_dim ** -0.5`** at projection time
//!      (not at the score matmul, although the math is equivalent).
//!   6. **Tied lm_head** to `shared` token embedding +
//!      `final_logits_bias` of shape `[vocab]`.
//!   7. **Embedding scaling** by `sqrt(d_model)` when
//!      `scale_embedding == true` (all Opus MT presets do).
//!
//! Activation is config-driven; Opus MT shipped models use Relu
//! (tc-big) or Silu / Swish (smaller variants).
//!
//! # Scope (v1)
//!
//! Forward-only, single sequence (`batch == 1`), no KV cache,
//! F32. Both encoder + decoder forward in one call:
//! `forward(src_tokens, tgt_tokens) -> logits`. The decoder
//! sees the full target sequence (teacher-forced layout); a
//! production decode loop is out of scope.

use fuel_ir::Shape;
use fuel_ir::error::Result;
use fuel_tensor::Device;
use fuel_tensor::{lazy::Tensor, lazy::WeightStorage};
use std::sync::Arc;

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum MarianActivation {
    Relu,
    Silu,
    Gelu,
    GeluPytorchTanh,
}

#[derive(Debug, Clone, PartialEq)]
pub struct MarianConfig {
    pub vocab_size: usize,
    /// Defaults to `vocab_size` when `None`.
    pub decoder_vocab_size: Option<usize>,
    pub max_position_embeddings: usize,
    pub d_model: usize,
    pub encoder_layers: usize,
    pub encoder_ffn_dim: usize,
    pub encoder_attention_heads: usize,
    pub decoder_layers: usize,
    pub decoder_ffn_dim: usize,
    pub decoder_attention_heads: usize,
    pub scale_embedding: bool,
    pub share_encoder_decoder_embeddings: bool,
    pub activation_function: MarianActivation,
}

impl MarianConfig {
    pub fn target_vocab_size(&self) -> usize {
        self.decoder_vocab_size.unwrap_or(self.vocab_size)
    }
    pub fn encoder_head_dim(&self) -> usize {
        self.d_model / self.encoder_attention_heads
    }
    pub fn decoder_head_dim(&self) -> usize {
        self.d_model / self.decoder_attention_heads
    }

    /// `Helsinki-NLP/opus-mt-tc-big-fr-en` preset.
    pub fn opus_mt_tc_big_fr_en() -> Self {
        Self {
            vocab_size: 53017,
            decoder_vocab_size: Some(53017),
            max_position_embeddings: 1024,
            d_model: 1024,
            encoder_layers: 6,
            encoder_ffn_dim: 4096,
            encoder_attention_heads: 16,
            decoder_layers: 6,
            decoder_ffn_dim: 4096,
            decoder_attention_heads: 16,
            scale_embedding: true,
            share_encoder_decoder_embeddings: true,
            activation_function: MarianActivation::Relu,
        }
    }
}

#[derive(Debug, Clone)]
pub struct MarianAttentionWeights {
    pub q_proj: WeightStorage,
    pub q_proj_bias: Arc<[f32]>,
    pub k_proj: WeightStorage,
    pub k_proj_bias: Arc<[f32]>,
    pub v_proj: WeightStorage,
    pub v_proj_bias: Arc<[f32]>,
    pub out_proj: WeightStorage,
    pub out_proj_bias: Arc<[f32]>,
}

#[derive(Debug, Clone)]
pub struct MarianEncoderLayerWeights {
    pub self_attn: MarianAttentionWeights,
    pub self_attn_ln_gain: Arc<[f32]>,
    pub self_attn_ln_bias: Arc<[f32]>,
    pub fc1: WeightStorage,
    pub fc1_bias: Arc<[f32]>,
    pub fc2: WeightStorage,
    pub fc2_bias: Arc<[f32]>,
    pub final_ln_gain: Arc<[f32]>,
    pub final_ln_bias: Arc<[f32]>,
}

#[derive(Debug, Clone)]
pub struct MarianDecoderLayerWeights {
    pub self_attn: MarianAttentionWeights,
    pub self_attn_ln_gain: Arc<[f32]>,
    pub self_attn_ln_bias: Arc<[f32]>,
    pub encoder_attn: MarianAttentionWeights,
    pub encoder_attn_ln_gain: Arc<[f32]>,
    pub encoder_attn_ln_bias: Arc<[f32]>,
    pub fc1: WeightStorage,
    pub fc1_bias: Arc<[f32]>,
    pub fc2: WeightStorage,
    pub fc2_bias: Arc<[f32]>,
    pub final_ln_gain: Arc<[f32]>,
    pub final_ln_bias: Arc<[f32]>,
}

#[derive(Debug, Clone)]
pub struct MarianWeights {
    pub shared_embedding: Arc<[f32]>,
    pub encoder_layers: Vec<MarianEncoderLayerWeights>,
    pub decoder_layers: Vec<MarianDecoderLayerWeights>,
    /// `[vocab]` — added to logits before output.
    pub final_logits_bias: Arc<[f32]>,
}

#[derive(Debug, Clone)]
pub struct MarianModel {
    pub config: MarianConfig,
    pub weights: MarianWeights,
}

impl MarianModel {
    /// Encode + decode in one call. Returns logits of shape
    /// `[1, tgt_len, target_vocab_size]`.
    pub fn forward(&self, src_tokens: &[u32], tgt_tokens: &[u32]) -> Result<Tensor> {
        let cfg = &self.config;
        assert!(!src_tokens.is_empty(), "src_tokens must be non-empty");
        assert!(!tgt_tokens.is_empty(), "tgt_tokens must be non-empty");
        assert!(
            cfg.share_encoder_decoder_embeddings,
            "v1 only supports shared encoder+decoder embeddings",
        );
        // GAP-281: a typed decline, not a panic.
        if !cfg.d_model.is_multiple_of(cfg.encoder_attention_heads) {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianConfig: d_model ({}) must be divisible by encoder_attention_heads ({})",
                cfg.d_model, cfg.encoder_attention_heads,
            )));
        }
        // GAP-281: a typed decline, not a panic.
        if !cfg.d_model.is_multiple_of(cfg.decoder_attention_heads) {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianConfig: d_model ({}) must be divisible by decoder_attention_heads ({})",
                cfg.d_model, cfg.decoder_attention_heads,
            )));
        }

        // Build a single embed tensor (== single graph) and reuse it
        // for both encoder + decoder so cross-attention can matmul
        // across the two stacks.
        let embed = Tensor::from_f32(
            self.weights.shared_embedding.clone(),
            Shape::from_dims(&[cfg.vocab_size, cfg.d_model]),
            &Device::cpu(),
        )?;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_lt_shape = Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]);
        let pos_full = embed.const_f32_like(Arc::from(pos_table), pos_lt_shape)?;

        let enc_out = self.encode(&embed, &pos_full, src_tokens)?;
        let dec_out = self.decode(&embed, &pos_full, tgt_tokens, &enc_out)?;

        let lm_head = WeightStorage::F32(self.weights.shared_embedding.clone());
        let target_vocab = cfg.target_vocab_size();
        let logits = lm_head.apply_linear(&dec_out, cfg.d_model, target_vocab)?;
        let bias_t = dec_out.const_f32_like(
            Arc::clone(&self.weights.final_logits_bias),
            Shape::from_dims(&[target_vocab]),
        )?;
        logits.broadcast_add(&bias_t)
    }

    /// Run the encoder stack alone and return its per-token
    /// output `(1, src_len, d_model)`. Unlocks Marian-encoder
    /// based adapters (translation-quality embeddings, source
    /// language detection, etc.) without paying the decoder
    /// cost or requiring target tokens. Mirrors the
    /// `T5Model::forward_encoder` shape.
    pub fn forward_encoder(&self, src_tokens: &[u32]) -> Result<Tensor> {
        let cfg = &self.config;
        assert!(!src_tokens.is_empty(), "src_tokens must be non-empty");
        assert!(
            cfg.share_encoder_decoder_embeddings,
            "v1 only supports shared encoder+decoder embeddings",
        );
        // GAP-281: a typed decline, not a panic.
        if !cfg.d_model.is_multiple_of(cfg.encoder_attention_heads) {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianConfig: d_model ({}) must be divisible by encoder_attention_heads ({})",
                cfg.d_model, cfg.encoder_attention_heads,
            )));
        }
        let embed = Tensor::from_f32(
            self.weights.shared_embedding.clone(),
            Shape::from_dims(&[cfg.vocab_size, cfg.d_model]),
            &Device::cpu(),
        )?;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_lt_shape = Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]);
        let pos_full = embed.const_f32_like(Arc::from(pos_table), pos_lt_shape)?;
        self.encode(&embed, &pos_full, src_tokens)
    }

    /// Multimodal encoder entry point. Runs the Marian encoder over
    /// pre-embedded inputs `(1, src_len, d_model)`. Marian applies
    /// `scale_embedding` and the sinusoidal positional add internally
    /// (matches Qwen2 raw-embeds convention — caller passes token-
    /// level embeds; model handles seq-position-dependent positional
    /// encoding).
    pub fn forward_encoder_embeds(&self, src_embeds: &Tensor) -> Result<Tensor> {
        let cfg = &self.config;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_full = src_embeds.const_f32_like(
            Arc::from(pos_table),
            Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]),
        )?;
        self.encode_from_embeds(src_embeds, &pos_full)
    }

    /// Multimodal decoder entry point. Skips token embedding; runs the
    /// Marian decoder over pre-embedded inputs + cached encoder output
    /// and returns logits `(1, tgt_len, target_vocab)`. `enc_out`
    /// serves as the graph anchor for sinusoidal positional encoding
    /// + lm_head bias.
    pub fn forward_decoder_embeds(&self, tgt_embeds: &Tensor, enc_out: &Tensor) -> Result<Tensor> {
        let cfg = &self.config;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_full = enc_out.const_f32_like(
            Arc::from(pos_table),
            Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]),
        )?;
        let dec_out = self.decode_from_embeds(tgt_embeds, &pos_full, enc_out)?;

        let lm_head = WeightStorage::F32(self.weights.shared_embedding.clone());
        let target_vocab = cfg.target_vocab_size();
        let logits = lm_head.apply_linear(&dec_out, cfg.d_model, target_vocab)?;
        let bias_t = enc_out.const_f32_like(
            Arc::clone(&self.weights.final_logits_bias),
            Shape::from_dims(&[target_vocab]),
        )?;
        logits.broadcast_add(&bias_t)
    }

    /// Hidden-state variant of [`Self::forward_decoder_embeds`].
    /// Returns `(1, tgt_len, d_model)` post-cross-attention states
    /// without the LM head + final-logits bias.
    pub fn forward_decoder_hidden_embeds(
        &self,
        tgt_embeds: &Tensor,
        enc_out: &Tensor,
    ) -> Result<Tensor> {
        let cfg = &self.config;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_full = enc_out.const_f32_like(
            Arc::from(pos_table),
            Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]),
        )?;
        self.decode_from_embeds(tgt_embeds, &pos_full, enc_out)
    }

    /// Build per-token embeddings without running encoder or decoder.
    /// Returns `(1, seq, d_model)`. Marian shares the embedding
    /// matrix between encoder and decoder (v1 only supports this).
    pub fn embed_tokens_anchored(&self, anchor: &Tensor, tokens: &[u32]) -> Result<Tensor> {
        let cfg = &self.config;
        anchor.embed_tokens_anchored(
            self.weights.shared_embedding.clone(),
            cfg.vocab_size,
            cfg.d_model,
            tokens,
        )
    }

    /// Run only the Marian decoder, given a precomputed encoder
    /// output and target tokens, and return logits of shape
    /// `(1, tgt_len, target_vocab)`. Mirrors
    /// `WhisperModel::forward_decoder` and
    /// `T5Model::forward_decoder` — `enc_out` is the graph
    /// anchor so all decoder constants land on the same graph.
    /// Use this for autoregressive NMT generation where the
    /// encoder output is cached once and the decoder is invoked
    /// per generated token.
    pub fn forward_decoder(&self, tgt_tokens: &[u32], enc_out: &Tensor) -> Result<Tensor> {
        let cfg = &self.config;
        assert!(!tgt_tokens.is_empty(), "tgt_tokens must be non-empty");
        assert!(
            cfg.share_encoder_decoder_embeddings,
            "v1 only supports shared encoder+decoder embeddings",
        );
        // GAP-281: a typed decline, not a panic.
        if !cfg.d_model.is_multiple_of(cfg.decoder_attention_heads) {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianConfig: d_model ({}) must be divisible by decoder_attention_heads ({})",
                cfg.d_model, cfg.decoder_attention_heads,
            )));
        }

        let embed = enc_out.const_f32_like(
            self.weights.shared_embedding.clone(),
            Shape::from_dims(&[cfg.vocab_size, cfg.d_model]),
        )?;
        let pos_table = build_sinusoidal_table(cfg.max_position_embeddings, cfg.d_model)?;
        let pos_full = enc_out.const_f32_like(
            Arc::from(pos_table),
            Shape::from_dims(&[cfg.max_position_embeddings, cfg.d_model]),
        )?;

        let dec_out = self.decode(&embed, &pos_full, tgt_tokens, enc_out)?;

        let lm_head = WeightStorage::F32(self.weights.shared_embedding.clone());
        let target_vocab = cfg.target_vocab_size();
        let logits = lm_head.apply_linear(&dec_out, cfg.d_model, target_vocab)?;
        let bias_t = enc_out.const_f32_like(
            Arc::clone(&self.weights.final_logits_bias),
            Shape::from_dims(&[target_vocab]),
        )?;
        logits.broadcast_add(&bias_t)
    }

    fn encode(&self, embed: &Tensor, pos_full: &Tensor, src_tokens: &[u32]) -> Result<Tensor> {
        let cfg = &self.config;
        let src_len = src_tokens.len();
        let batch = 1;

        let ids = embed.const_u32_like(src_tokens.to_vec(), Shape::from_dims(&[src_len]))?;
        let src_embeds = embed
            .index_select(0_usize, &ids)?
            .reshape(Shape::from_dims(&[batch, src_len, cfg.d_model]))?;
        self.encode_from_embeds(&src_embeds, pos_full)
    }

    fn encode_from_embeds(&self, src_embeds: &Tensor, pos_full: &Tensor) -> Result<Tensor> {
        let cfg = &self.config;
        let dims = src_embeds.shape();
        let dims = dims.dims();
        if dims.len() != 3 || dims[0] != 1 || dims[2] != cfg.d_model {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianModel::forward_encoder_embeds: expected shape (1, src_len, d_model={}), got {:?}",
                cfg.d_model, dims,
            )).bt());
        }
        let src_len = dims[1];
        let batch = dims[0];
        if src_len == 0 {
            return Err(fuel_ir::error::Error::Msg(
                "MarianModel::forward_encoder_embeds: src_len must be > 0".into(),
            )
            .bt());
        }
        let mut x = src_embeds.clone();
        if cfg.scale_embedding {
            x = x.mul_scalar((cfg.d_model as f64).sqrt());
        }
        let pos_slice = pos_full
            .slice(0_usize, 0, src_len)?
            .reshape(Shape::from_dims(&[1, src_len, cfg.d_model]))?;
        x = x.add(&pos_slice.broadcast_to(Shape::from_dims(&[batch, src_len, cfg.d_model]))?)?;

        for layer in &self.weights.encoder_layers {
            x = self.apply_encoder_layer(&x, layer)?;
        }
        Ok(x)
    }

    fn decode(
        &self,
        embed: &Tensor,
        pos_full: &Tensor,
        tgt_tokens: &[u32],
        enc_out: &Tensor,
    ) -> Result<Tensor> {
        let cfg = &self.config;
        let tgt_len = tgt_tokens.len();
        let batch = 1;

        let ids = embed.const_u32_like(tgt_tokens.to_vec(), Shape::from_dims(&[tgt_len]))?;
        let tgt_embeds = embed
            .index_select(0_usize, &ids)?
            .reshape(Shape::from_dims(&[batch, tgt_len, cfg.d_model]))?;
        self.decode_from_embeds(&tgt_embeds, pos_full, enc_out)
    }

    fn decode_from_embeds(
        &self,
        tgt_embeds: &Tensor,
        pos_full: &Tensor,
        enc_out: &Tensor,
    ) -> Result<Tensor> {
        let cfg = &self.config;
        let dims = tgt_embeds.shape();
        let dims = dims.dims();
        if dims.len() != 3 || dims[0] != 1 || dims[2] != cfg.d_model {
            return Err(fuel_ir::error::Error::Msg(format!(
                "MarianModel::forward_decoder_embeds: expected tgt shape (1, tgt_len, d_model={}), got {:?}",
                cfg.d_model, dims,
            )).bt());
        }
        let tgt_len = dims[1];
        let batch = dims[0];
        if tgt_len == 0 {
            return Err(fuel_ir::error::Error::Msg(
                "MarianModel::forward_decoder_embeds: tgt_len must be > 0".into(),
            )
            .bt());
        }
        let mut x = tgt_embeds.clone();
        if cfg.scale_embedding {
            x = x.mul_scalar((cfg.d_model as f64).sqrt());
        }
        let pos_slice = pos_full
            .slice(0_usize, 0, tgt_len)?
            .reshape(Shape::from_dims(&[1, tgt_len, cfg.d_model]))?;
        x = x.add(&pos_slice.broadcast_to(Shape::from_dims(&[batch, tgt_len, cfg.d_model]))?)?;

        let mut mask_data = vec![0.0_f32; tgt_len * tgt_len];
        for i in 0..tgt_len {
            for j in (i + 1)..tgt_len {
                mask_data[i * tgt_len + j] = f32::NEG_INFINITY;
            }
        }
        let causal_mask =
            x.const_f32_like(mask_data, Shape::from_dims(&[1, 1, tgt_len, tgt_len]))?;

        for layer in &self.weights.decoder_layers {
            x = self.apply_decoder_layer(&x, layer, enc_out, &causal_mask)?;
        }
        Ok(x)
    }

    fn apply_encoder_layer(&self, x: &Tensor, layer: &MarianEncoderLayerWeights) -> Result<Tensor> {
        let cfg = &self.config;
        let attn = self.attention(
            x,
            x,
            &layer.self_attn,
            cfg.encoder_attention_heads,
            cfg.encoder_head_dim(),
            None,
        )?;
        let h1 = x.add(&attn)?.layer_norm_affine(
            std::sync::Arc::clone(&layer.self_attn_ln_gain),
            std::sync::Arc::clone(&layer.self_attn_ln_bias),
            1e-5,
        )?;
        let ffn = self.feed_forward(
            &h1,
            &layer.fc1,
            &layer.fc1_bias,
            &layer.fc2,
            &layer.fc2_bias,
            cfg.encoder_ffn_dim,
        )?;
        h1.add(&ffn)?.layer_norm_affine(
            std::sync::Arc::clone(&layer.final_ln_gain),
            std::sync::Arc::clone(&layer.final_ln_bias),
            1e-5,
        )
    }

    fn apply_decoder_layer(
        &self,
        x: &Tensor,
        layer: &MarianDecoderLayerWeights,
        enc_out: &Tensor,
        causal_mask: &Tensor,
    ) -> Result<Tensor> {
        let cfg = &self.config;
        // Self-attention with causal mask.
        let self_attn = self.attention(
            x,
            x,
            &layer.self_attn,
            cfg.decoder_attention_heads,
            cfg.decoder_head_dim(),
            Some(causal_mask),
        )?;
        let h1 = x.add(&self_attn)?.layer_norm_affine(
            std::sync::Arc::clone(&layer.self_attn_ln_gain),
            std::sync::Arc::clone(&layer.self_attn_ln_bias),
            1e-5,
        )?;
        // Cross-attention: Q from decoder state, K/V from encoder output.
        let cross_attn = self.attention(
            &h1,
            enc_out,
            &layer.encoder_attn,
            cfg.decoder_attention_heads,
            cfg.decoder_head_dim(),
            None,
        )?;
        let h2 = h1.add(&cross_attn)?.layer_norm_affine(
            std::sync::Arc::clone(&layer.encoder_attn_ln_gain),
            std::sync::Arc::clone(&layer.encoder_attn_ln_bias),
            1e-5,
        )?;
        let ffn = self.feed_forward(
            &h2,
            &layer.fc1,
            &layer.fc1_bias,
            &layer.fc2,
            &layer.fc2_bias,
            cfg.decoder_ffn_dim,
        )?;
        h2.add(&ffn)?.layer_norm_affine(
            std::sync::Arc::clone(&layer.final_ln_gain),
            std::sync::Arc::clone(&layer.final_ln_bias),
            1e-5,
        )
    }

    /// Generic multi-head attention. `q_src` provides Q; `kv_src`
    /// provides K and V. For self-attention they're the same;
    /// for cross-attention they differ.
    fn attention(
        &self,
        q_src: &Tensor,
        kv_src: &Tensor,
        w: &MarianAttentionWeights,
        n_heads: usize,
        head_dim: usize,
        attn_mask: Option<&Tensor>,
    ) -> Result<Tensor> {
        let d_model = self.config.d_model;
        let q_shape = q_src.shape();
        let q_dims = q_shape.dims();
        let batch = q_dims[0];
        let q_len = q_dims[1];
        let kv_shape = kv_src.shape();
        let kv_dims = kv_shape.dims();
        let kv_len = kv_dims[1];

        let scaling = (head_dim as f64).powf(-0.5);
        let q = add_bias_3d(
            w.q_proj.apply_linear(q_src, d_model, d_model)?,
            &w.q_proj_bias,
            d_model,
        )?
        .mul_scalar(scaling);
        let k = add_bias_3d(
            w.k_proj.apply_linear(kv_src, d_model, d_model)?,
            &w.k_proj_bias,
            d_model,
        )?;
        let v = add_bias_3d(
            w.v_proj.apply_linear(kv_src, d_model, d_model)?,
            &w.v_proj_bias,
            d_model,
        )?;

        let _ = (batch, q_len, kv_len);
        let q = q.split_heads(n_heads, head_dim)?;
        let k = k.split_heads(n_heads, head_dim)?;
        let v = v.split_heads(n_heads, head_dim)?;

        let k_t = k.transpose()?;
        let scores = q.matmul(&k_t)?;
        let scores = match attn_mask {
            None => scores,
            Some(mask) => scores.broadcast_add(mask)?,
        };
        let probs = scores.softmax_last_dim()?;
        let ctx = probs.matmul(&v)?;
        let merged = ctx.merge_heads()?;
        let out = w.out_proj.apply_linear(&merged, d_model, d_model)?;
        add_bias_3d(out, &w.out_proj_bias, d_model)
    }

    fn feed_forward(
        &self,
        x: &Tensor,
        fc1_w: &WeightStorage,
        fc1_b: &Arc<[f32]>,
        fc2_w: &WeightStorage,
        fc2_b: &Arc<[f32]>,
        ffn_dim: usize,
    ) -> Result<Tensor> {
        let cfg = &self.config;
        let fc1 = add_bias_3d(fc1_w.apply_linear(x, cfg.d_model, ffn_dim)?, fc1_b, ffn_dim)?;
        let activated = match cfg.activation_function {
            MarianActivation::Relu => fc1.relu(),
            MarianActivation::Silu => fc1.silu(),
            MarianActivation::Gelu => fc1.gelu(),
            MarianActivation::GeluPytorchTanh => fc1.gelu_tanh(),
        };
        let fc2 = add_bias_3d(
            fc2_w.apply_linear(&activated, ffn_dim, cfg.d_model)?,
            fc2_b,
            cfg.d_model,
        )?;
        Ok(fc2)
    }
}

/// Build the (`max_positions`, `d_model`)-shaped sinusoidal
/// position table used by Marian: the first `d_model/2` features
/// are `sin(t * inv_freq)`, the last `d_model/2` are
/// `cos(t * inv_freq)`, where `inv_freq[i] = 10000^(-i / d_model)`
/// for `i ∈ [0, d_model/2)`.
fn build_sinusoidal_table(max_positions: usize, d_model: usize) -> Result<Vec<f32>> {
    // GAP-281: a CONFIG property -- reject it rather than panicking. The
    // half-dimension split below assumes an even d_model.
    if !d_model.is_multiple_of(2) {
        return Err(fuel_ir::error::Error::Msg(format!(
            "build_sinusoidal_table: d_model ({d_model}) must be even"
        )));
    }
    let half = d_model / 2;
    let mut out = vec![0.0_f32; max_positions * d_model];
    let inv_freq: Vec<f32> = (0..half)
        .map(|i| 1.0_f32 / 10_000.0_f32.powf((2 * i) as f32 / d_model as f32))
        .collect();
    for t in 0..max_positions {
        for i in 0..half {
            let arg = t as f32 * inv_freq[i];
            out[t * d_model + i] = arg.sin();
            out[t * d_model + half + i] = arg.cos();
        }
    }
    Ok(out)
}

fn add_bias_3d(x: Tensor, bias: &Arc<[f32]>, n: usize) -> Result<Tensor> {
    let _ = n;
    x.add_trailing_bias(Arc::clone(bias))
}

// ---- HuggingFace safetensors loader ----------------------------------------

impl MarianAttentionWeights {
    fn load(
        st: &fuel_loaders::safetensors::MmapedSafetensors,
        prefix: &str,
        d_model: usize,
    ) -> Result<Self> {
        use fuel_tensor::{
            lazy::load_tensor_as_f32, lazy::load_transposed_matrix_preserve_dtype as ltm,
        };
        let q_proj = ltm(st, &format!("{prefix}.q_proj.weight"), d_model, d_model)?;
        let q_proj_bias = Arc::from(load_tensor_as_f32(st, &format!("{prefix}.q_proj.bias"))?);
        let k_proj = ltm(st, &format!("{prefix}.k_proj.weight"), d_model, d_model)?;
        let k_proj_bias = Arc::from(load_tensor_as_f32(st, &format!("{prefix}.k_proj.bias"))?);
        let v_proj = ltm(st, &format!("{prefix}.v_proj.weight"), d_model, d_model)?;
        let v_proj_bias = Arc::from(load_tensor_as_f32(st, &format!("{prefix}.v_proj.bias"))?);
        let out_proj = ltm(st, &format!("{prefix}.out_proj.weight"), d_model, d_model)?;
        let out_proj_bias = Arc::from(load_tensor_as_f32(st, &format!("{prefix}.out_proj.bias"))?);
        Ok(Self {
            q_proj,
            q_proj_bias,
            k_proj,
            k_proj_bias,
            v_proj,
            v_proj_bias,
            out_proj,
            out_proj_bias,
        })
    }
}

impl MarianWeights {
    /// Load Marian (Helsinki-NLP/opus-mt-*) weights from HuggingFace safetensors.
    pub fn load_from_mmapped(
        st: &fuel_loaders::safetensors::MmapedSafetensors,
        cfg: &MarianConfig,
    ) -> Result<Self> {
        use fuel_tensor::{
            lazy::load_tensor_as_f32, lazy::load_transposed_matrix_preserve_dtype as ltm,
        };
        let d = cfg.d_model;
        let enc_ffn = cfg.encoder_ffn_dim;
        let dec_ffn = cfg.decoder_ffn_dim;

        let shared_embedding = Arc::from(load_tensor_as_f32(st, "model.shared.weight")?);

        let mut encoder_layers = Vec::with_capacity(cfg.encoder_layers);
        for i in 0..cfg.encoder_layers {
            let p = format!("model.encoder.layers.{i}");
            let self_attn = MarianAttentionWeights::load(st, &format!("{p}.self_attn"), d)?;
            let self_attn_ln_gain = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.self_attn_layer_norm.weight"),
            )?);
            let self_attn_ln_bias = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.self_attn_layer_norm.bias"),
            )?);
            let fc1 = ltm(st, &format!("{p}.fc1.weight"), enc_ffn, d)?;
            let fc1_bias = Arc::from(load_tensor_as_f32(st, &format!("{p}.fc1.bias"))?);
            let fc2 = ltm(st, &format!("{p}.fc2.weight"), d, enc_ffn)?;
            let fc2_bias = Arc::from(load_tensor_as_f32(st, &format!("{p}.fc2.bias"))?);
            let final_ln_gain = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.final_layer_norm.weight"),
            )?);
            let final_ln_bias = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.final_layer_norm.bias"),
            )?);
            encoder_layers.push(MarianEncoderLayerWeights {
                self_attn,
                self_attn_ln_gain,
                self_attn_ln_bias,
                fc1,
                fc1_bias,
                fc2,
                fc2_bias,
                final_ln_gain,
                final_ln_bias,
            });
        }

        let mut decoder_layers = Vec::with_capacity(cfg.decoder_layers);
        for i in 0..cfg.decoder_layers {
            let p = format!("model.decoder.layers.{i}");
            let self_attn = MarianAttentionWeights::load(st, &format!("{p}.self_attn"), d)?;
            let self_attn_ln_gain = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.self_attn_layer_norm.weight"),
            )?);
            let self_attn_ln_bias = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.self_attn_layer_norm.bias"),
            )?);
            let encoder_attn = MarianAttentionWeights::load(st, &format!("{p}.encoder_attn"), d)?;
            let encoder_attn_ln_gain = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.encoder_attn_layer_norm.weight"),
            )?);
            let encoder_attn_ln_bias = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.encoder_attn_layer_norm.bias"),
            )?);
            let fc1 = ltm(st, &format!("{p}.fc1.weight"), dec_ffn, d)?;
            let fc1_bias = Arc::from(load_tensor_as_f32(st, &format!("{p}.fc1.bias"))?);
            let fc2 = ltm(st, &format!("{p}.fc2.weight"), d, dec_ffn)?;
            let fc2_bias = Arc::from(load_tensor_as_f32(st, &format!("{p}.fc2.bias"))?);
            let final_ln_gain = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.final_layer_norm.weight"),
            )?);
            let final_ln_bias = Arc::from(load_tensor_as_f32(
                st,
                &format!("{p}.final_layer_norm.bias"),
            )?);
            decoder_layers.push(MarianDecoderLayerWeights {
                self_attn,
                self_attn_ln_gain,
                self_attn_ln_bias,
                encoder_attn,
                encoder_attn_ln_gain,
                encoder_attn_ln_bias,
                fc1,
                fc1_bias,
                fc2,
                fc2_bias,
                final_ln_gain,
                final_ln_bias,
            });
        }

        // `final_logits_bias` is a registered buffer; tolerate absence (zeros).
        let target_vocab = cfg.target_vocab_size();
        let final_logits_bias = match load_tensor_as_f32(st, "final_logits_bias") {
            Ok(v) => Arc::from(v),
            Err(_) => Arc::from(vec![0.0_f32; target_vocab]),
        };

        Ok(Self {
            shared_embedding,
            encoder_layers,
            decoder_layers,
            final_logits_bias,
        })
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn tiny_attention_weights(
        d_model: usize,
        next_box: &mut Box<dyn FnMut() -> f32>,
    ) -> MarianAttentionWeights {
        let vec_of = |n: usize, next: &mut dyn FnMut() -> f32| -> Arc<[f32]> {
            Arc::from((0..n).map(|_| next()).collect::<Vec<_>>())
        };
        MarianAttentionWeights {
            q_proj: WeightStorage::F32(vec_of(d_model * d_model, &mut **next_box)),
            q_proj_bias: vec_of(d_model, &mut **next_box),
            k_proj: WeightStorage::F32(vec_of(d_model * d_model, &mut **next_box)),
            k_proj_bias: vec_of(d_model, &mut **next_box),
            v_proj: WeightStorage::F32(vec_of(d_model * d_model, &mut **next_box)),
            v_proj_bias: vec_of(d_model, &mut **next_box),
            out_proj: WeightStorage::F32(vec_of(d_model * d_model, &mut **next_box)),
            out_proj_bias: vec_of(d_model, &mut **next_box),
        }
    }

    fn tiny_weights(cfg: &MarianConfig) -> MarianWeights {
        let mut s: u32 = 64646;
        let next = move || -> f32 {
            s = s.wrapping_mul(1103515245).wrapping_add(12345);
            ((s >> 16) as u16 as f32 / 65535.0 - 0.5) * 0.05
        };
        let d = cfg.d_model;
        let enc_ffn = cfg.encoder_ffn_dim;
        let dec_ffn = cfg.decoder_ffn_dim;
        let mut nb: Box<dyn FnMut() -> f32> = Box::new(next);

        let vec_of = |n: usize, next: &mut dyn FnMut() -> f32| -> Arc<[f32]> {
            Arc::from((0..n).map(|_| next()).collect::<Vec<_>>())
        };
        let shared_embedding = vec_of(cfg.vocab_size * d, &mut *nb);

        let encoder_layers: Vec<MarianEncoderLayerWeights> = (0..cfg.encoder_layers)
            .map(|_| MarianEncoderLayerWeights {
                self_attn: tiny_attention_weights(d, &mut nb),
                self_attn_ln_gain: Arc::from(vec![1.0_f32; d]),
                self_attn_ln_bias: Arc::from(vec![0.0_f32; d]),
                fc1: WeightStorage::F32(vec_of(d * enc_ffn, &mut *nb)),
                fc1_bias: vec_of(enc_ffn, &mut *nb),
                fc2: WeightStorage::F32(vec_of(enc_ffn * d, &mut *nb)),
                fc2_bias: vec_of(d, &mut *nb),
                final_ln_gain: Arc::from(vec![1.0_f32; d]),
                final_ln_bias: Arc::from(vec![0.0_f32; d]),
            })
            .collect();
        let decoder_layers: Vec<MarianDecoderLayerWeights> = (0..cfg.decoder_layers)
            .map(|_| MarianDecoderLayerWeights {
                self_attn: tiny_attention_weights(d, &mut nb),
                self_attn_ln_gain: Arc::from(vec![1.0_f32; d]),
                self_attn_ln_bias: Arc::from(vec![0.0_f32; d]),
                encoder_attn: tiny_attention_weights(d, &mut nb),
                encoder_attn_ln_gain: Arc::from(vec![1.0_f32; d]),
                encoder_attn_ln_bias: Arc::from(vec![0.0_f32; d]),
                fc1: WeightStorage::F32(vec_of(d * dec_ffn, &mut *nb)),
                fc1_bias: vec_of(dec_ffn, &mut *nb),
                fc2: WeightStorage::F32(vec_of(dec_ffn * d, &mut *nb)),
                fc2_bias: vec_of(d, &mut *nb),
                final_ln_gain: Arc::from(vec![1.0_f32; d]),
                final_ln_bias: Arc::from(vec![0.0_f32; d]),
            })
            .collect();
        let target_vocab = cfg.target_vocab_size();
        let final_logits_bias = vec_of(target_vocab, &mut *nb);

        MarianWeights {
            shared_embedding,
            encoder_layers,
            decoder_layers,
            final_logits_bias,
        }
    }

    fn tiny_config() -> MarianConfig {
        MarianConfig {
            vocab_size: 16,
            decoder_vocab_size: None,
            max_position_embeddings: 16,
            d_model: 8,
            encoder_layers: 2,
            encoder_ffn_dim: 16,
            encoder_attention_heads: 2,
            decoder_layers: 2,
            decoder_ffn_dim: 16,
            decoder_attention_heads: 2,
            scale_embedding: true,
            share_encoder_decoder_embeddings: true,
            activation_function: MarianActivation::Relu,
        }
    }

    #[test]
    fn forward_shape_and_finite() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3, 4];
        let tgt = [5_u32, 6, 7];
        let logits = model.forward(&src, &tgt).unwrap();
        assert_eq!(
            logits.shape().dims(),
            &[1, tgt.len(), cfg.target_vocab_size()]
        );
        for &v in &logits.realize_f32() {
            assert!(v.is_finite(), "got non-finite logit {v}");
        }
    }

    /// Source change must alter target logits — proves cross-
    /// attention actually conditions on the encoder output.
    #[test]
    fn cross_attention_is_wired() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let tgt = [5_u32, 6, 7];
        let a = model.forward(&[1, 2, 3, 4], &tgt).unwrap().realize_f32();
        let b = model.forward(&[8, 9, 10, 11], &tgt).unwrap().realize_f32();
        let mut max_diff = 0.0_f32;
        for (x, y) in a.iter().zip(b.iter()) {
            max_diff = max_diff.max((x - y).abs());
        }
        assert!(
            max_diff > 1e-6,
            "cross-attention must condition on encoder output: changing src must change tgt logits, max_diff = {max_diff}"
        );
    }

    /// Decoder causal mask is enforced: changing target token at
    /// position t must NOT change logits at positions < t.
    #[test]
    fn decoder_causal_mask_is_enforced() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3];
        let tgt_a = [5_u32, 6, 7, 8];
        let tgt_b = [5_u32, 6, 7, 15]; // last token changed
        let a = model.forward(&src, &tgt_a).unwrap().realize_f32();
        let b = model.forward(&src, &tgt_b).unwrap().realize_f32();
        // Compare logits at positions 0, 1, 2 (which precede the changed token).
        let v = cfg.target_vocab_size();
        for t in 0..3 {
            for col in 0..v {
                let i = t * v + col;
                assert!(
                    (a[i] - b[i]).abs() < 1e-5,
                    "causal mask violated at t={t}, col={col}: {} vs {}",
                    a[i],
                    b[i],
                );
            }
        }
    }

    /// Sinusoidal table sanity: position 0 must be all-zero in
    /// the sin half and all-one in the cos half.
    #[test]
    fn sinusoidal_table_position_0() {
        let t = build_sinusoidal_table(4, 8).unwrap();
        let half = 4;
        for i in 0..half {
            assert!((t[i]).abs() < 1e-6, "sin[0, {i}] = {} != 0", t[i]);
            assert!(
                (t[half + i] - 1.0).abs() < 1e-6,
                "cos[0, {i}] = {} != 1",
                t[half + i]
            );
        }
    }

    #[test]
    fn presets_construct() {
        let c = MarianConfig::opus_mt_tc_big_fr_en();
        assert_eq!(c.d_model, 1024);
        assert_eq!(c.encoder_attention_heads, 16);
        assert_eq!(c.target_vocab_size(), 53017);
    }

    #[test]
    fn forward_encoder_shape_and_finite() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3, 4, 5];
        let enc = model.forward_encoder(&src).unwrap();
        assert_eq!(enc.shape().dims(), &[1, src.len(), cfg.d_model]);
        for &v in &enc.realize_f32() {
            assert!(v.is_finite(), "non-finite encoder output: {v}");
        }
    }

    /// `forward_encoder` must produce the same encoder output
    /// that `forward` consumes internally. Prove this by
    /// computing the cross-attention contribution two ways:
    /// (1) via `forward` directly, and (2) by re-running
    /// `forward_encoder` and confirming the result tensor has
    /// the same per-position L2 norm distribution as a baseline.
    /// We check determinism: same input → same output across
    /// two calls.
    #[test]
    fn forward_encoder_deterministic() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3, 4];
        let a = model.forward_encoder(&src).unwrap().realize_f32();
        let b = model.forward_encoder(&src).unwrap().realize_f32();
        assert_eq!(a.len(), b.len());
        for (x, y) in a.iter().zip(b.iter()) {
            assert!(
                (x - y).abs() < 1e-7,
                "non-deterministic encoder: {x} vs {y}"
            );
        }
    }

    #[test]
    fn forward_decoder_shape_and_finite() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let enc = model.forward_encoder(&[1_u32, 2, 3, 4]).unwrap();
        let tgt = [5_u32, 6, 7];
        let logits = model.forward_decoder(&tgt, &enc).unwrap();
        assert_eq!(
            logits.shape().dims(),
            &[1, tgt.len(), cfg.target_vocab_size()]
        );
        for &v in &logits.realize_f32() {
            assert!(v.is_finite(), "non-finite decoder logit: {v}");
        }
    }

    /// `forward_decoder(tgt, forward_encoder(src))` must match
    /// `forward(src, tgt)` — the two paths compute the same
    /// graph.
    #[test]
    fn forward_decoder_matches_full_forward() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3];
        let tgt = [5_u32, 6, 7];
        let full = model.forward(&src, &tgt).unwrap().realize_f32();
        let enc = model.forward_encoder(&src).unwrap();
        let split = model.forward_decoder(&tgt, &enc).unwrap().realize_f32();
        assert_eq!(full.len(), split.len());
        for (a, b) in full.iter().zip(split.iter()) {
            assert!(
                (a - b).abs() < 1e-5,
                "forward_decoder must match forward: {a} vs {b}"
            );
        }
    }

    #[test]
    fn forward_encoder_embeds_matches_forward_encoder() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3];
        let enc_ref = model.forward_encoder(&src).unwrap().realize_f32();
        let anchor =
            Tensor::from_f32(vec![0.0_f32], Shape::from_dims(&[1]), &Device::cpu()).unwrap();
        let src_embeds = model.embed_tokens_anchored(&anchor, &src).unwrap();
        let enc_via_embeds = model
            .forward_encoder_embeds(&src_embeds)
            .unwrap()
            .realize_f32();
        let max_diff = enc_ref
            .iter()
            .zip(enc_via_embeds.iter())
            .map(|(a, b)| (a - b).abs())
            .fold(0.0_f32, f32::max);
        assert!(
            max_diff < 1e-5,
            "Marian forward_encoder vs forward_encoder_embeds must agree (max diff {max_diff})"
        );
    }

    #[test]
    fn forward_decoder_embeds_matches_forward_decoder() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3];
        let tgt = [5_u32, 6, 7];
        let enc = model.forward_encoder(&src).unwrap();
        let dec_ref = model.forward_decoder(&tgt, &enc).unwrap().realize_f32();
        let tgt_embeds = model.embed_tokens_anchored(&enc, &tgt).unwrap();
        let dec_via_embeds = model
            .forward_decoder_embeds(&tgt_embeds, &enc)
            .unwrap()
            .realize_f32();
        let max_diff = dec_ref
            .iter()
            .zip(dec_via_embeds.iter())
            .map(|(a, b)| (a - b).abs())
            .fold(0.0_f32, f32::max);
        assert!(
            max_diff < 1e-5,
            "Marian forward_decoder vs forward_decoder_embeds must agree (max diff {max_diff})"
        );
    }

    #[test]
    fn forward_encoder_embeds_rejects_bad_shape() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let bad = Tensor::from_f32(
            vec![0.0_f32; 3 * (cfg.d_model + 1)],
            Shape::from_dims(&[1, 3, cfg.d_model + 1]),
            &Device::cpu(),
        )
        .unwrap();
        assert!(model.forward_encoder_embeds(&bad).is_err());
    }

    #[test]
    fn forward_decoder_hidden_embeds_skips_lm_head() {
        let cfg = tiny_config();
        let model = MarianModel {
            config: cfg.clone(),
            weights: tiny_weights(&cfg),
        };
        let src = [1_u32, 2, 3];
        let tgt = [5_u32, 6, 7];
        let enc = model.forward_encoder(&src).unwrap();
        let tgt_embeds = model.embed_tokens_anchored(&enc, &tgt).unwrap();
        let hidden = model
            .forward_decoder_hidden_embeds(&tgt_embeds, &enc)
            .unwrap();
        assert_eq!(hidden.shape().dims(), &[1, tgt.len(), cfg.d_model]);
        for &v in &hidden.realize_f32() {
            assert!(v.is_finite(), "non-finite hidden: {v}");
        }
    }

    /// GAP-281 (dim/head relation): `d_model % {encoder,decoder}_attention_heads`
    /// must DECLINE, not panic.
    ///
    /// ⚠️ Weights are built FOR the bad config. This check sits inside `forward`,
    /// so weights sized to the VALID config would fail a shape check first and the
    /// test would measure that instead -- the short-circuit route to a vacuous
    /// oracle, which cost a fixture on `parler_tts` earlier in this family.
    ///
    /// Born-red by sabotage: dropping a divisibility check fails this arm alone.
    #[test]
    fn dim_head_mismatch_declines_rather_than_panicking() {
        let valid = tiny_config();
        let src = [1_u32, 2, 3, 4];
        let tgt = [5_u32, 6, 7];

        // CONTROL: the conforming config still runs.
        let good = MarianModel {
            config: valid.clone(),
            weights: tiny_weights(&valid),
        };
        good.forward(&src, &tgt)
            .expect("control: the conforming config must still run");

        let mut bad = valid.clone();
        bad.encoder_attention_heads = 3; // d_model 8 % 3 == 2
        let model = MarianModel {
            config: bad.clone(),
            weights: tiny_weights(&bad),
        };
        let err = model
            .forward(&src, &tgt)
            .expect_err("a non-dividing head count must DECLINE, not panic");
        let msg = format!("{err}");
        assert!(
            msg.contains("d_model") && msg.contains("encoder_attention_heads"),
            "the decline must name both operands, got: {msg}"
        );
    }

    /// GAP-281: an odd `d_model` must DECLINE, not panic. `half = d_model / 2`
    /// truncates silently otherwise, so it is a CONFIG property.
    ///
    /// Asserts on the MESSAGE, not merely that an `Err` arrived: a later guard
    /// on the same path can supply an `Err` of its own (measured in
    /// `lazy_mamba2`), which makes an `expect_err`-only arm pass under
    /// sabotage while reporting the guard as live.
    #[test]
    fn odd_d_model_declines_rather_than_panicking() {
        // CONTROL: the conforming even value must still build.
        build_sinusoidal_table(4, 8).expect("control: an even d_model must still build");

        let err = build_sinusoidal_table(4, 7).expect_err("an odd d_model must DECLINE, not panic");
        let msg = format!("{err}");
        assert!(
            msg.contains("d_model") && msg.contains('7'),
            "the decline must name the operand and its value, got: {msg}"
        );
    }
}