frugalos 1.2.0

Frugal Object Storage
//! Definitions for frugalos set-repair-config
use clap::{App, Arg, ArgMatches, SubCommand};
use libfrugalos::repair::{
    RepairConcurrencyLimit, RepairConfig, RepairIdleness, SegmentGcConcurrencyLimit,
};
use sloggers::Build;
use sloggers::LoggerBuilder;
use std::time::Duration;
use trackable::error::ErrorKindExt;

use crate::command::rpc_addr;
use crate::command::{warn_if_there_are_unknown_fields, FrugalosSubcommand};
use crate::{Error, ErrorKind};

/// frugalos set-repair-config
pub struct SetRepairConfigCommand;

static REPAIR_IDLENESS_THRESHOLD: &str = "REPAIR_IDLENESS_THRESHOLD";
static REPAIR_IDLENESS_THRESHOLD_LONG_ARG: &str = "repair-idleness-threshold";
static DISABLE_REPAIR_IDLENESS: &str = "DISABLE_REPAIR_IDLENESS";
static DISABLE_REPAIR_IDLENESS_LONG_ARG: &str = "disable-repair-idleness";
static REPAIR_CONCURRENCY_LIMIT: &str = "REPAIR_CONCURRENCY_LIMIT";
static REPAIR_CONCURRENCY_LIMIT_LONG_ARG: &str = "repair-concurrency-limit";
static SEGMENT_GC_CONCURRENCY_LIMIT: &str = "SEGMENT_GC_CONCURRENCY_LIMIT";
static SEGMENT_GC_CONCURRENCY_LIMIT_LONG_ARG: &str = "segment-gc-concurrency-limit";

impl FrugalosSubcommand for SetRepairConfigCommand {
    fn get_subcommand<'a, 'b: 'a>(&self) -> App<'a, 'b> {
        SubCommand::with_name("set-repair-config")
            .arg(rpc_addr::get_arg())
            .arg(
                Arg::with_name(REPAIR_IDLENESS_THRESHOLD)
                    .long(REPAIR_IDLENESS_THRESHOLD_LONG_ARG)
                    .takes_value(true),
            )
            .arg(
                Arg::with_name(DISABLE_REPAIR_IDLENESS)
                    .long(DISABLE_REPAIR_IDLENESS_LONG_ARG)
                    .takes_value(false),
            )
            .arg(
                Arg::with_name(REPAIR_CONCURRENCY_LIMIT)
                    .long(REPAIR_CONCURRENCY_LIMIT_LONG_ARG)
                    .takes_value(true),
            )
            .arg(
                Arg::with_name(SEGMENT_GC_CONCURRENCY_LIMIT)
                    .long(SEGMENT_GC_CONCURRENCY_LIMIT_LONG_ARG)
                    .takes_value(true),
            )
    }

    fn check_matches<'a>(&self, matches: &'a ArgMatches<'a>) -> Option<&'a ArgMatches<'a>> {
        matches.subcommand_matches("set-repair-config")
    }

    fn handle_matches(
        &self,
        logger_builder: LoggerBuilder,
        matches: &ArgMatches,
        unknown_fields: &[String],
    ) {
        let mut logger = track_try_unwrap!(logger_builder.build());
        warn_if_there_are_unknown_fields(&mut logger, &unknown_fields);
        let rpc_addr = rpc_addr::from_matches(&matches);
        let repair_config = Self::get_repair_config_from_matches(matches);
        let logger = logger.new(o!("rpc_addr" => rpc_addr.to_string(),
            "repair_config" => format!("{:?}", repair_config)));
        track_try_unwrap!(crate::daemon::set_repair_config(
            &logger,
            rpc_addr,
            repair_config,
        ));
    }
}

impl SetRepairConfigCommand {
    fn get_repair_config_from_matches(matches: &ArgMatches) -> RepairConfig {
        let repair_idleness_threshold: Option<RepairIdleness>;
        // if DISABLE_REPAIR_IDLENESS is present, REPAIR_IDLENESS_THRESHOLD is ignored.
        if matches.is_present(DISABLE_REPAIR_IDLENESS) {
            repair_idleness_threshold = Some(RepairIdleness::Disabled);
        } else {
            repair_idleness_threshold = matches.value_of(REPAIR_IDLENESS_THRESHOLD).map(|str| {
                let duration_secs: f64 = track_try_unwrap!(str.parse().map_err(|_| Error::from(
                    ErrorKind::InvalidInput.cause("repair-idleness-threshold must be a float")
                )));
                // TODO check if duration_secs is non-negative
                RepairIdleness::Threshold(Duration::from_millis((duration_secs * 1000.0) as u64))
            })
        }
        let repair_concurrency_limit = matches.value_of(REPAIR_CONCURRENCY_LIMIT).map(|str| {
            let limit: u64 = track_try_unwrap!(str.parse().map_err(|_| Error::from(
                ErrorKind::InvalidInput.cause("repair-concurrency-limit must be a u64")
            )));
            RepairConcurrencyLimit(limit)
        });
        let segment_gc_concurrency_limit =
            matches.value_of(SEGMENT_GC_CONCURRENCY_LIMIT).map(|str| {
                let limit: u64 = track_try_unwrap!(str.parse().map_err(|_| Error::from(
                    ErrorKind::InvalidInput.cause("segment-gc-concurrency-limit must be a u64")
                )));
                SegmentGcConcurrencyLimit(limit)
            });
        RepairConfig {
            repair_concurrency_limit,
            repair_idleness_threshold,
            segment_gc_concurrency_limit,
        }
    }
}

#[cfg(test)]
mod tests {
    use clap::App;
    use libfrugalos::repair::{RepairConcurrencyLimit, RepairConfig, RepairIdleness};
    use std::time::Duration;

    use super::SetRepairConfigCommand;
    use crate::command::FrugalosSubcommand;

    #[test]
    fn get_repair_config_from_matches_work_correctly() {
        let set_repair_config_command = SetRepairConfigCommand;
        let matches = App::new("frugalos-test")
            .subcommand(set_repair_config_command.get_subcommand())
            .get_matches_from(vec![
                "frugalos-test",
                "set-repair-config",
                "--repair-idleness-threshold",
                "4.0",
                "--repair-concurrency-limit",
                "100",
            ]);
        if let Some(matches) = set_repair_config_command.check_matches(&matches) {
            let repair_config = SetRepairConfigCommand::get_repair_config_from_matches(&matches);
            // TODO: we want to check repair_config directly, but it's not possible because RepairConfig doesn't implement Eq.
            // To circumvent this, we perform pattern matching.
            if let RepairConfig {
                repair_concurrency_limit: Some(RepairConcurrencyLimit(100)),
                repair_idleness_threshold: Some(RepairIdleness::Threshold(duration)),
                segment_gc_concurrency_limit: None,
            } = repair_config
            {
                assert_eq!(duration, Duration::from_secs(4))
            } else {
                panic!();
            }
        }
    }
    #[test]
    fn get_repair_config_from_matches_work_correctly_disable() {
        let set_repair_config_command = SetRepairConfigCommand;
        let matches = App::new("frugalos-test")
            .subcommand(set_repair_config_command.get_subcommand())
            .get_matches_from(vec![
                "frugalos-test",
                "set-repair-config",
                "--disable-repair-idleness", // This option neutralizes --repair-idleness-threshold that appears later
                "--repair-idleness-threshold",
                "10.0",
            ]);
        if let Some(matches) = set_repair_config_command.check_matches(&matches) {
            let repair_config = SetRepairConfigCommand::get_repair_config_from_matches(&matches);
            // TODO: we want to check repair_config directly, but it's not possible because RepairConfig doesn't implement Eq.
            // To circumvent this, we perform pattern matching.
            if let RepairConfig {
                repair_concurrency_limit: None,
                repair_idleness_threshold: Some(RepairIdleness::Disabled),
                segment_gc_concurrency_limit: None,
            } = repair_config
            {
            } else {
                panic!();
            }
        }
    }
}