cha-core 0.6.5

Core analysis engine for Cha — pluggable code smell detection
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65

use crate::{AnalysisContext, Finding, Location, Plugin, Severity, SmellCategory};

/// Detect interfaces/traits with only one implementation (over-abstraction).
pub struct SpeculativeGeneralityAnalyzer;

impl Default for SpeculativeGeneralityAnalyzer {
    fn default() -> Self {
        Self
    }
}

impl Plugin for SpeculativeGeneralityAnalyzer {
    fn name(&self) -> &str {
        "speculative_generality"
    }

    fn description(&self) -> &str {
        "Interface with too few implementations"
    }

    fn analyze(&self, ctx: &AnalysisContext) -> Vec<Finding> {
        // Count how many classes extend/implement each interface in this file
        let interfaces: Vec<_> = ctx
            .model
            .classes
            .iter()
            .filter(|c| c.is_interface)
            .collect();
        if interfaces.is_empty() {
            return vec![];
        }
        let mut findings = Vec::new();
        for iface in &interfaces {
            let impl_count = ctx
                .model
                .classes
                .iter()
                .filter(|c| c.parent_name.as_deref() == Some(&iface.name))
                .count();
            // Only flag if exactly 0 or 1 implementations in the same file
            if impl_count <= 1 {
                findings.push(Finding {
                    smell_name: "speculative_generality".into(),
                    category: SmellCategory::Dispensables,
                    severity: Severity::Hint,
                    location: Location {
                        path: ctx.file.path.clone(),
                        start_line: iface.start_line,
                        end_line: iface.end_line,
                        name: Some(iface.name.clone()),
                    },
                    message: format!(
                        "Interface `{}` has only {} implementation(s) in this file, consider Collapse Hierarchy",
                        iface.name, impl_count
                    ),
                    suggested_refactorings: vec![
                        "Collapse Hierarchy".into(),
                        "Inline Class".into(),
                    ],
                });
            }
        }
        findings
    }
}