cha-core 0.6.5

Core analysis engine for Cha — pluggable code smell detection
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50

use crate::{AnalysisContext, Finding, Location, Plugin, Severity, SmellCategory};

/// Detect classes that only have fields and accessor methods (no real behavior).
pub struct DataClassAnalyzer {
    pub min_fields: usize,
}

impl Default for DataClassAnalyzer {
    fn default() -> Self {
        Self { min_fields: 2 }
    }
}

impl Plugin for DataClassAnalyzer {
    fn name(&self) -> &str {
        "data_class"
    }

    fn description(&self) -> &str {
        "Class with only data, no behavior"
    }

    fn analyze(&self, ctx: &AnalysisContext) -> Vec<Finding> {
        ctx.model
            .classes
            .iter()
            .filter_map(|c| {
                if c.is_interface || c.field_count < self.min_fields || c.has_behavior {
                    return None;
                }
                Some(Finding {
                    smell_name: "data_class".into(),
                    category: SmellCategory::Dispensables,
                    severity: Severity::Hint,
                    location: Location {
                        path: ctx.file.path.clone(),
                        start_line: c.start_line,
                        end_line: c.end_line,
                        name: Some(c.name.clone()),
                    },
                    message: format!(
                        "Class `{}` has {} fields but no behavior methods, consider Move Method",
                        c.name, c.field_count
                    ),
                    suggested_refactorings: vec!["Move Method".into(), "Encapsulate Field".into()],
                })
            })
            .collect()
    }
}