bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150

#![allow(clippy::unwrap_used)]
#![allow(clippy::expect_used)]
#![allow(non_snake_case)]

//! CLI integration tests for semantic lint analysis (PMAT-212)
//!
//! Tests SEM001 (unused variable) and SEM002 (undefined variable) rules
//! powered by the AST-based SemanticAnalyzer.

use assert_cmd::Command;
use predicates::prelude::*;
use std::io::Write;
use tempfile::NamedTempFile;

#[allow(deprecated)]
fn bashrs_cmd() -> Command {
    assert_cmd::cargo_bin_cmd!("bashrs")
}

fn shell_file(content: &str) -> NamedTempFile {
    let mut f = NamedTempFile::with_suffix(".sh").unwrap();
    writeln!(f, "{content}").unwrap();
    f
}

// ---------------------------------------------------------------------------
// SEM001: Unused variable detection
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_sem001_unused_variable() {
    let f = shell_file("#!/bin/bash\nunused=\"hello\"\necho world");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        .stdout(predicate::str::contains("SEM001"))
        .stdout(predicate::str::contains("unused"));
}

#[test]
fn test_PMAT212_sem001_exported_variable_not_flagged() {
    let f = shell_file("#!/bin/bash\nexport API_KEY=\"secret\"\necho done");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        .stdout(predicate::str::contains("SEM001").not());
}

#[test]
fn test_PMAT212_sem001_underscore_prefix_not_flagged() {
    let f = shell_file("#!/bin/bash\n_unused=\"ignored\"\necho done");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        .stdout(predicate::str::contains("SEM001").not());
}

#[test]
fn test_PMAT212_sem001_multiple_unused() {
    let f = shell_file("#!/bin/bash\na=\"one\"\nb=\"two\"\necho done");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        .stdout(predicate::str::contains("SEM001"));
}

// ---------------------------------------------------------------------------
// Clean scripts should NOT trigger SEM rules
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_clean_script_no_sem() {
    let f = shell_file("#!/bin/sh\necho \"hello world\"");
    let output = bashrs_cmd().arg("lint").arg(f.path()).output().unwrap();
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        !stdout.contains("SEM001") && !stdout.contains("SEM002"),
        "Clean script should not trigger SEM rules, got: {stdout}"
    );
}

// ---------------------------------------------------------------------------
// Semantic analysis is tolerant of parse failures
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_parse_failure_graceful() {
    // Invalid bash syntax — semantic analysis should silently skip,
    // regex rules should still fire for what they can catch
    let f = shell_file("#!/bin/bash\nif then fi\necho $RANDOM");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        // Should still get regex-based DET001 for $RANDOM
        .stdout(predicate::str::contains("DET001"));
}

// ---------------------------------------------------------------------------
// SEM rules appear in JSON output
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_sem001_json_format() {
    let f = shell_file("#!/bin/bash\nunused=\"hello\"\necho world");
    bashrs_cmd()
        .arg("lint")
        .arg("--format")
        .arg("json")
        .arg(f.path())
        .assert()
        .stdout(predicate::str::contains("SEM001"))
        .stdout(predicate::str::contains("semantic analysis"));
}

// ---------------------------------------------------------------------------
// Suppression works with SEM rules
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_sem001_suppression() {
    let f = shell_file("#!/bin/bash\n# shellcheck disable=SEM001\nunused=\"hello\"\necho world");
    let output = bashrs_cmd().arg("lint").arg(f.path()).output().unwrap();
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        !stdout.contains("SEM001"),
        "SEM001 should be suppressed, got: {stdout}"
    );
}

// ---------------------------------------------------------------------------
// Integration: SEM rules coexist with regex rules
// ---------------------------------------------------------------------------

#[test]
fn test_PMAT212_sem_and_regex_coexist() {
    let f = shell_file("#!/bin/bash\nunused=\"hello\"\necho $RANDOM");
    bashrs_cmd()
        .arg("lint")
        .arg(f.path())
        .assert()
        // SEM001 from semantic analyzer
        .stdout(predicate::str::contains("SEM001"))
        // DET001 from regex rule
        .stdout(predicate::str::contains("DET001"));
}