bashrs 6.66.0

Rust-to-Shell transpiler for deterministic bootstrap scripts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
#![allow(deprecated)]
#![allow(clippy::unwrap_used)]
#![allow(clippy::expect_used)]
// Tests can use unwrap() for simplicity
// Integration Tests for Dockerfile Purification - End-to-End Workflows
// EXTREME TDD Phase 7: INTEGRATION
//
// Test Naming Convention: test_integration_<workflow>_<scenario>
//
// Purpose: Verify complete end-to-end workflows combining multiple transformations
#![allow(non_snake_case)] // Test naming convention allows descriptive names

use assert_cmd::Command;
use std::fs;
use std::io::Write;
use tempfile::{NamedTempFile, TempDir};

// ============================================================================
// Helper Functions
// ============================================================================

/// Create a bashrs command (MANDATORY pattern per CLAUDE.md)
#[allow(deprecated)]
fn bashrs_cmd() -> Command {
    assert_cmd::cargo_bin_cmd!("bashrs")
}

/// Create a temporary Dockerfile with given content
fn create_temp_dockerfile(content: &str) -> NamedTempFile {
    let mut file = NamedTempFile::new().expect("Failed to create temp file");
    file.write_all(content.as_bytes())
        .expect("Failed to write to temp file");
    file
}

// ============================================================================
// Integration Test 1: Multi-Transformation Workflow
// ============================================================================

#[test]
fn test_integration_all_transformations_combined() {
    // Test that all 6 DOCKER transformations work together correctly
    let dockerfile = r#"FROM ubuntu:latest
RUN apt-get update && apt-get install -y curl wget
ADD https://example.com/file.tar.gz /tmp/
ADD local-file.txt /app/
COPY app.py /app/
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile.purified");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify DOCKER001: FROM latest → FROM ubuntu:22.04 (versioned)
    // NOTE: Current implementation pins version but doesn't add -slim suffix
    // This matches DOCKER002 behavior (version pinning only)
    assert!(
        purified.contains("FROM ubuntu:22.04") || purified.contains("FROM ubuntu:20.04"),
        "DOCKER001 transformation failed: {}",
        purified
    );

    // Verify DOCKER005: --no-install-recommends added
    assert!(
        purified.contains("--no-install-recommends"),
        "DOCKER005 transformation failed"
    );

    // Verify DOCKER003: Package cleanup added
    assert!(
        purified.contains("/var/lib/apt/lists"),
        "DOCKER003 transformation failed"
    );

    // Verify DOCKER006: ADD → COPY for local files
    assert!(
        purified.contains("COPY local-file.txt"),
        "DOCKER006 transformation failed (local file)"
    );

    // Verify DOCKER006: ADD preserved for URLs
    assert!(
        purified.contains("ADD https://example.com"),
        "DOCKER006 transformation failed (URL preservation)"
    );
}

// ============================================================================
// Integration Test 2: Real-World Node.js Dockerfile
// ============================================================================

#[test]
fn test_integration_nodejs_dockerfile() {
    // Realistic Node.js application Dockerfile
    let dockerfile = r#"FROM node:latest
WORKDIR /app
COPY package*.json ./
RUN npm install
COPY . .
EXPOSE 3000
CMD ["node", "server.js"]
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify FROM latest is transformed
    assert!(
        !purified.contains("node:latest"),
        "Node.js Dockerfile should not have :latest tag"
    );

    // Verify structure is preserved
    assert!(purified.contains("WORKDIR /app"));
    assert!(purified.contains("EXPOSE 3000"));
    assert!(purified.contains("CMD"));
}

// ============================================================================
// Integration Test 3: Real-World Python Dockerfile
// ============================================================================

#[test]
fn test_integration_python_dockerfile() {
    // Realistic Python application Dockerfile
    let dockerfile = r#"FROM python:latest
WORKDIR /app
RUN apt-get update && apt-get install -y gcc g++ make
COPY requirements.txt .
RUN pip install --no-cache-dir -r requirements.txt
COPY . .
CMD ["python", "app.py"]
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify all transformations applied
    assert!(!purified.contains("python:latest"));
    assert!(purified.contains("--no-install-recommends"));
    assert!(purified.contains("/var/lib/apt/lists"));
}

// ============================================================================
// Integration Test 4: Idempotency Verification
// ============================================================================

#[test]
fn test_integration_idempotency_purify_twice() {
    // Verify that purifying twice produces identical results
    let dockerfile = r#"FROM ubuntu:latest
RUN apt-get install -y nginx
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let temp_dir = TempDir::new().expect("Failed to create temp dir");

    // First purification
    let output1 = temp_dir.path().join("Dockerfile.purified1");
    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output1)
        .assert()
        .success();

    let purified1 = fs::read_to_string(&output1).expect("Failed to read first purified file");

    // Second purification (purify the purified file)
    let output2 = temp_dir.path().join("Dockerfile.purified2");
    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(&output1)
        .arg("-o")
        .arg(&output2)
        .assert()
        .success();

    let purified2 = fs::read_to_string(&output2).expect("Failed to read second purified file");

    // Verify idempotency: purify(purify(x)) == purify(x)
    assert_eq!(
        purified1, purified2,
        "Purification should be idempotent (same result when applied twice)"
    );
}

// ============================================================================
// Integration Test 5: Comments Preserved During Transformations
// ============================================================================

#[test]
fn test_integration_comments_preserved() {
    // Verify that comments are preserved during all transformations
    let dockerfile = r#"# Base image
FROM ubuntu:latest

# Update and install packages
RUN apt-get update && apt-get install -y curl

# Copy application files
COPY app.py /app/
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify all comments are preserved
    assert!(purified.contains("# Base image"));
    assert!(purified.contains("# Update and install packages"));
    assert!(purified.contains("# Copy application files"));

    // Verify transformations still applied
    assert!(!purified.contains("ubuntu:latest"));
}

// ============================================================================
// Integration Test 6: Complex Multi-Line RUN Commands
// ============================================================================

#[test]
fn test_integration_complex_multiline_run() {
    // Test transformation of complex multi-line RUN commands
    let dockerfile = r#"FROM ubuntu:latest
RUN apt-get update && \
    apt-get install -y \
        curl \
        wget \
        git && \
    rm -rf /var/cache/apt/*
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // NOTE: Multi-line RUN commands with backslash continuations are NOT transformed
    // This is a known architectural limitation of line-by-line processing (see commands.rs:1072-1105)
    // Similar to Issue #2, would require preprocessing to handle continuation lines
    //
    // Current behavior: Multi-line commands are preserved but NOT transformed
    // Verify the multi-line structure is preserved (not broken)
    assert!(
        purified.contains("apt-get update && \\"),
        "Multi-line structure should be preserved"
    );
    assert!(
        purified.contains("apt-get install -y \\"),
        "Multi-line continuation should be preserved"
    );

    // FROM transformation still works (single-line)
    assert!(!purified.contains("ubuntu:latest"));
}

// ============================================================================
// Integration Test 7: Alpine Linux (apk) Workflow
// ============================================================================

#[test]
fn test_integration_alpine_apk_workflow() {
    // Test complete workflow with Alpine Linux and apk package manager
    let dockerfile = r#"FROM alpine:latest
RUN apk update && apk add curl wget
COPY app.sh /app/
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify Alpine-specific transformations
    assert!(!purified.contains("alpine:latest"));
    assert!(purified.contains("/var/cache/apk"));
}

// ============================================================================
// Integration Test 8: Empty Dockerfile
// ============================================================================

#[test]
fn test_integration_empty_dockerfile() {
    // Test handling of empty/minimal Dockerfiles
    let dockerfile = "# Just a comment\n";

    let input_file = create_temp_dockerfile(dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify comment is preserved
    assert!(purified.contains("# Just a comment"));
}

// ============================================================================
// Integration Test 9: Determinism Verification
// ============================================================================

#[test]
fn test_integration_determinism_multiple_runs() {
    // Verify that multiple purifications produce identical byte-for-byte results
    let dockerfile = r#"FROM ubuntu:latest
RUN apt-get update && apt-get install -y nginx curl
ADD local.txt /app/
"#;

    let input_file = create_temp_dockerfile(dockerfile);
    let temp_dir = TempDir::new().expect("Failed to create temp dir");

    // Run purification 3 times
    let mut outputs = Vec::new();
    for i in 0..3 {
        let output = temp_dir.path().join(format!("Dockerfile.purified{}", i));
        bashrs_cmd()
            .arg("dockerfile")
            .arg("purify")
            .arg(input_file.path())
            .arg("-o")
            .arg(&output)
            .assert()
            .success();

        let content = fs::read_to_string(&output).expect("Failed to read purified file");
        outputs.push(content);
    }

    // Verify all 3 outputs are identical
    assert_eq!(
        outputs[0], outputs[1],
        "Run 1 and 2 should produce identical results"
    );
    assert_eq!(
        outputs[1], outputs[2],
        "Run 2 and 3 should produce identical results"
    );
}

// ============================================================================
// Integration Test 10: Large Dockerfile Performance
// ============================================================================

#[test]
fn test_integration_large_dockerfile_performance() {
    // Test performance with a large Dockerfile (50+ instructions)
    let mut dockerfile = String::from("FROM ubuntu:latest\n");
    for i in 0..50 {
        dockerfile.push_str(&format!("RUN apt-get install -y package{}\n", i));
    }

    let input_file = create_temp_dockerfile(&dockerfile);
    let output_dir = TempDir::new().expect("Failed to create temp dir");
    let output_file = output_dir.path().join("Dockerfile");

    // Verify purification completes successfully (performance test)
    bashrs_cmd()
        .arg("dockerfile")
        .arg("purify")
        .arg(input_file.path())
        .arg("-o")
        .arg(&output_file)
        .assert()
        .success();

    let purified = fs::read_to_string(&output_file).expect("Failed to read purified file");

    // Verify all transformations applied to all RUN commands
    assert_eq!(
        purified.matches("--no-install-recommends").count(),
        50,
        "All 50 RUN commands should have --no-install-recommends"
    );
}