1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
use super::*;
use crate::device_communication_control::DeviceCommunicationControlAuthorizationContext;
use bacnet_types::enums::AuditOperation;
#[path = "comm_state.rs"]
mod comm_state;
pub(crate) use comm_state::CommState;
pub use comm_state::DccState;
/// Last-owner destruction aborts the timer even if server Drop could not acquire
/// the async slot while a request was replacing it.
#[derive(Default)]
pub(crate) struct TimerSlot(pub(crate) Option<JoinHandle<()>>);
impl std::ops::Deref for TimerSlot {
type Target = Option<JoinHandle<()>>;
fn deref(&self) -> &Self::Target {
&self.0
}
}
impl std::ops::DerefMut for TimerSlot {
fn deref_mut(&mut self) -> &mut Self::Target {
&mut self.0
}
}
impl Drop for TimerSlot {
fn drop(&mut self) {
if let Some(task) = &self.0 {
task.abort();
}
}
}
// Borrow the handle in its owning slot through the join. Cancelling the caller
// leaves the (possibly already aborted) handle available for the next cleanup.
pub(super) async fn cancel(slot: &mut Option<JoinHandle<()>>) {
if let Some(task) = slot.as_mut() {
task.abort();
let _ = task.await;
}
*slot = None;
}
/// Commit accepted WARMSTART/COLDSTART while the caller holds the timer slot.
/// Abort first so the old deadline cannot outlive this transition. Joining
/// remains a separate cancellable cleanup step; acceptance must enable now.
/// This is not a DCC request or timer expiry and records neither outcome/Audit.
pub(super) fn enable_for_restart(
slot: &Option<JoinHandle<()>>,
comm: &CommState,
cov_resume: &crate::cov::timed::TimedStore,
) {
if let Some(task) = slot {
task.abort();
}
comm.set(DccState::Enable);
cov_resume.rearm();
}
/// One DeviceCommunicationControl request and where it came from.
pub(super) struct DccRequest<'a> {
pub(super) service_data: &'a [u8],
pub(super) source_mac: &'a [u8],
pub(super) source: Option<&'a bacnet_encoding::npdu::NpduAddress>,
/// This network's own number as read for the request, against which a
/// routed source restriction entry names a direct requester (#1458).
pub(super) local_network: Option<u16>,
/// The ingress snapshot the policy's principal comes from (#1964).
pub(super) provenance: bacnet_transport::port::TransportProvenance,
/// The request's invoke ID, for the policy's context.
pub(super) invoke_id: u8,
}
/// Apply a DCC request and own its revert timer. Whenever communication is
/// enabled again, by the request or when the timer expires, `cov_resume` is
/// rearmed so timestamped COV changes held meanwhile go out promptly (#856).
///
/// With target Audit configured, each change carried out is reported
/// (Table 19-5, #1387): DEVICE_DISABLE_COMM for DISABLE_INITIATION and
/// DEVICE_ENABLE_COMM for ENABLE, from `audit`'s requester, and
/// DEVICE_ENABLE_COMM from this device when a timed disable runs out. A
/// refused request changes nothing and reports nothing. The record is
/// admitted under the timer slot with the change, so records follow the
/// order changes take effect in; the disable's goes out under the state it
/// reports, as audit notifications do (#1370).
pub(super) async fn replace<T: TransportPort + 'static>(
services: &super::request_services::RequestServices<T>,
request: DccRequest<'_>,
request_tasks: &super::request_tasks::RequestTaskSpawner,
cov_resume: &crate::cov::timed::TimedStore,
audit: &mut super::audit_reporter::WriteAudit<'_, T>,
) -> Result<dcc_outcomes::DccMetadata, handlers::device_mgmt::DccFailure> {
let super::request_services::RequestServices {
dcc_timer: timer,
comm_state,
config,
..
} = services;
let DccRequest {
service_data,
source_mac,
source,
local_network,
provenance,
invoke_id,
} = request;
// Decode and validate once, retaining only non-secret proposed state and
// metadata. Never change live state before a cancellable await.
let (proposed, duration) =
handlers::device_mgmt::validate_dcc(service_data, &config.dcc_password, config.dcc_policy)?;
let mode = bacnet_types::enums::EnableDisable::from(proposed).to_raw();
// Short-circuit source refusal, then the installed ServerPolicy (#1964; a
// panic in it denies), before touching the shared disable budget, so a
// refused requester never spends it. ENABLE never checks the budget. A
// successful charge precedes every cancellable await.
// The policy is asked on Tokio's blocking pool (#2032), so a policy that
// blocks can't hold up stop(); nothing has changed before that await.
let source_refused = config
.dcc_source_restriction
.as_ref()
.is_some_and(|restriction| {
config.dcc_policy != DccPolicy::RequirePassword
|| !restriction.allows(source_mac, source, local_network)
});
let policy_refused = match (&config.policy, source_refused) {
(Some(policy), false) => {
let context = DeviceCommunicationControlAuthorizationContext {
source_mac: MacAddr::from_slice(source_mac),
source_network: source.cloned(),
provenance,
invoke_id,
requested_state: proposed,
duration_minutes: duration,
};
!super::requests::ask_policy(policy, context, |policy, context| {
policy.authorize_device_communication_control(context)
})
.await
}
_ => false,
};
if source_refused
|| policy_refused
|| (proposed == DccState::DisableInitiation && !request_tasks.admit_dcc_disable())
{
return Err(handlers::device_mgmt::DccFailure {
error: Error::protocol(ErrorClass::SERVICES, ErrorCode::SERVICE_REQUEST_DENIED),
outcome: dcc_outcomes::DccOutcome::PolicyDenied,
metadata: dcc_outcomes::DccMetadata {
mode: Some(mode),
duration,
},
});
}
let mut slot = timer.lock().await;
// The database guard the record needs is taken before the old timer is
// cancelled, so no suspension separates that cancel from the commit.
// Expiry takes the slot and then the database too, in the same order.
let mut audit_db = match &config.audit_reporters {
Some(_) => Some(services.db.write().await),
None => None,
};
cancel(&mut slot).await;
// Replacement, expiry, and shutdown share this linearization boundary.
// No suspension between the live commit and installing the new owner.
comm_state.set(proposed);
if proposed == DccState::Enable {
cov_resume.rearm();
}
if let Some(minutes) = duration {
let owner = Arc::downgrade(timer);
let comm = Arc::clone(comm_state);
let cov_resume = cov_resume.clone();
// Only a disable running out re-enables communication; an ENABLE's
// own timer changes nothing when it fires, so it reports nothing.
let expiry_audit = DccAudit::of(services).filter(|_| proposed != DccState::Enable);
// The duration runs from the commit, not from the task's first poll.
let deadline = tokio::time::Instant::now() + Duration::from_secs(minutes as u64 * 60);
**slot = Some(tokio::spawn(async move {
tokio::time::sleep_until(deadline).await;
if let Some(owner) = owner.upgrade() {
// An old task waiting here can be aborted and joined while a
// replacement holds the slot; it never joins or removes itself.
let _slot = owner.lock().await;
let mut db = match &expiry_audit {
Some(audit) => Some(audit.db.write().await),
None => None,
};
comm.set(DccState::Enable);
cov_resume.rearm();
if let (Some(audit), Some(db)) = (&expiry_audit, db.as_deref_mut()) {
audit.record_expiry(db);
}
debug!(
"DCC timer expired after {} min, state reverted to ENABLE",
minutes
);
}
// A timer nothing cancelled may outlive every other handle on
// the database (#1560).
if let Some(audit) = expiry_audit {
audit.release();
}
}));
}
if let Some(db) = audit_db.as_deref_mut() {
audit.device_operation(
db,
if proposed == DccState::Enable {
AuditOperation::DEVICE_ENABLE_COMM
} else {
AuditOperation::DEVICE_DISABLE_COMM
},
);
}
Ok(dcc_outcomes::DccMetadata {
mode: Some(mode),
duration,
})
}
/// The handles a DCC change's Audit record is admitted with (#1387), held
/// by a disable's timer for the record its expiry owes. Present only with
/// target Audit configured, so a server without it never takes the
/// database guard for DCC.
pub(super) struct DccAudit<T: TransportPort + 'static> {
db: Arc<RwLock<ObjectDatabase>>,
network: Arc<NetworkLayer<T>>,
transactions: Arc<NotificationTransactions>,
config: Arc<ServerConfig>,
}
impl<T: TransportPort + 'static> DccAudit<T> {
fn of(services: &super::request_services::RequestServices<T>) -> Option<Self> {
services.config.audit_reporters.as_ref()?;
Some(Self {
db: Arc::clone(&services.db),
network: Arc::clone(&services.network),
transactions: Arc::clone(&services.notification_transactions),
config: Arc::clone(&services.config),
})
}
/// Let go of the database through [`drop_database_off_runtime`], for a
/// timer that ends on its own.
fn release(self) {
drop(drop_database_off_runtime(self.db));
}
/// Report a timed disable running out: DEVICE_ENABLE_COMM, with this
/// device as its source and no invoke ID, since no request caused it.
fn record_expiry(&self, db: &mut ObjectDatabase) {
if let Some(mut audit) = super::audit_reporter::WriteAudit::local(
&self.config,
&self.network,
&self.transactions,
db,
) {
audit.device_operation(db, AuditOperation::DEVICE_ENABLE_COMM);
}
}
}