Struct FixupParser 

pub struct FixupParser {
    pub mode: FixupMode,
    pub sandbox_root: SandboxRoot,
}

Main fixup parser that handles detection and parsing of fixup plans

Security

FixupParser uses SandboxRoot to validate all target paths before any file operations. This ensures that:

• Paths cannot escape the workspace root via .. traversal
• Absolute paths are rejected
• Symlinks are rejected by default (configurable via SandboxConfig)
• Hardlinks are rejected by default (configurable via SandboxConfig)

All path validation happens through SandboxRoot::join() which provides comprehensive security checks before any file I/O.

Fields

mode: FixupMode

Operating mode (preview or apply)

sandbox_root: SandboxRoot

Sandboxed root directory for resolving and validating relative paths

Implementations

impl FixupParser

pub fn preview_changes( &self, diffs: &[UnifiedDiff], ) -> Result<FixupPreview, FixupError>

Preview changes without applying them

Line endings are normalized before calculating diff statistics (FR-FIX-010)

Security

All target paths are validated through SandboxRoot::join() to ensure:

• Paths cannot escape the workspace root via .. traversal
• Absolute paths are rejected
• Symlinks are rejected by default (configurable via SandboxConfig)
• Hardlinks are rejected by default (configurable via SandboxConfig)

pub fn apply_changes( &self, diffs: &[UnifiedDiff], ) -> Result<FixupResult, FixupError>

Apply changes to files using atomic writes (FR-FIX-005, FR-FIX-006, FR-FIX-008)

This method implements the atomic write pattern:

1. Validate target path using SandboxPath (security check)
2. Write to .tmp file with fsync
3. Create .bak backup if file exists
4. Atomic rename with Windows retry
5. Preserve file permissions (Unix) or attributes (Windows)
6. Record warnings if permission preservation fails

Security

All target paths are validated through SandboxRoot::join() to ensure:

• Paths cannot escape the workspace root via .. traversal
• Absolute paths are rejected
• Symlinks are rejected by default (configurable via SandboxConfig)
• Hardlinks are rejected by default (configurable via SandboxConfig)

pub fn apply_changes_with_git( &self, diffs: &[UnifiedDiff], ) -> Result<FixupResult, FixupError>

Apply changes to files (legacy git apply method - kept for compatibility)

impl FixupParser

pub fn new(mode: FixupMode, base_dir: PathBuf) -> Result<Self, FixupError>

Create a new fixup parser with a sandboxed root directory.

Arguments

• mode - The operating mode (preview or apply)
• base_dir - The base directory to use as a sandbox root

Errors

Returns an error if base directory cannot be used as a sandbox root (e.g., doesn’t exist, isn’t a directory, or can’t be canonicalized).

pub fn with_config( mode: FixupMode, base_dir: PathBuf, config: SandboxConfig, ) -> Result<Self, FixupError>

Create a new fixup parser with custom sandbox configuration.

Arguments

• mode - The operating mode (preview or apply)
• base_dir - The base directory to use as a sandbox root
• config - Custom sandbox configuration (e.g., to allow symlinks)

Errors

Returns an error if base directory cannot be used as a sandbox root.

pub fn base_dir(&self) -> &Path

Get the sandbox root path.

pub fn has_fixup_markers(&self, content: &str) -> bool

Detect if review output contains fixup markers.

pub fn detect_fixup_markers(&self, content: &str) -> Option<String>

Detect fixup markers in review output. Returns the content after the first marker if found.

pub fn parse_diffs(&self, content: &str) -> Result<Vec<UnifiedDiff>, FixupError>

Parse unified diff blocks from fixup content.