Enum Severity 

pub enum Severity {
    Blocking,
    NonBlocking,
    Nit,
}

Only Blocking gates a merge. This is the whole defence against the nitpick spiral: a competent reviewer can always find something, so “no objections remaining” is not a stopping condition but “no blocking objections” is.

Variants

Blocking

NonBlocking

Nit

Implementations

impl Severity

pub fn as_str(self) -> &'static str

pub fn parse_lenient(text: &str) -> Option<Self>

Accept the canonical spelling, any listed alias, and any difference in case, spacing, hyphens, or underscores.

Examples found in repository

examples/preview.rs (line 22)

fn finding(severity: &str, title: &str, detail: &str, file: &str, in_scope: bool) -> Finding {
    Finding {
        severity: Severity::parse_lenient(severity).expect("severity"),
        title: title.into(),
        detail: detail.into(),
        file: file.into(),
        in_scope,
    }
}

pub fn valid_values() -> String

impl Severity

pub fn rank(self) -> u8

How badly it matters, independent of the order the variants happen to be declared in. Relying on derived Ord here would silently invert the moment somebody reorders the enum.

pub fn graver(self, other: Self) -> Self

The graver of two judgements.

Two reviewers disagreeing about severity is resolved upward on purpose. Nothing here gates a merge, it is all advice to a person, and advice that under-reports a real defect is worse than advice that over-reports a small one.

Trait Implementations

impl Clone for Severity

fn clone(&self) -> Severity

Returns a duplicate of the value.

fn clone_from(&mut self, source: &Self)

Performs copy-assignment from source.

impl Copy for Severity

impl Debug for Severity

fn fmt(&self, f: &mut Formatter<'_>) -> Result

Formats the value using the given formatter.

impl<'de> Deserialize<'de> for Severity

fn deserialize<D: Deserializer<'de>>(d: D) -> Result<Self, D::Error>

Deserialize this value from the given Serde deserializer.

impl Display for Severity

fn fmt(&self, f: &mut Formatter<'_>) -> Result

Formats the value using the given formatter.

impl Eq for Severity

impl Hash for Severity

fn hash<__H: Hasher>(&self, state: &mut __H)

Feeds this value into the given Hasher.

fn hash_slice<H>(data: &[Self], state: &mut H)

where H: Hasher, Self: Sized,

Feeds a slice of this type into the given Hasher.

impl Ord for Severity

fn cmp(&self, other: &Severity) -> Ordering

This method returns an Ordering between self and other.

fn max(self, other: Self) -> Self

where Self: Sized,

Compares and returns the maximum of two values.

fn min(self, other: Self) -> Self

where Self: Sized,

Compares and returns the minimum of two values.

fn clamp(self, min: Self, max: Self) -> Self

where Self: Sized,

Restrict a value to a certain interval.

impl PartialEq for Severity

fn eq(&self, other: &Severity) -> bool

Equality operator ==.

fn ne(&self, other: &Rhs) -> bool

Inequality operator !=.

impl PartialOrd for Severity

fn partial_cmp(&self, other: &Severity) -> Option<Ordering>

This method returns an ordering between self and other values if one exists.

fn lt(&self, other: &Rhs) -> bool

Tests less than (for self and other) and is used by the < operator.

fn le(&self, other: &Rhs) -> bool

Tests less than or equal to (for self and other) and is used by the <= operator.

fn gt(&self, other: &Rhs) -> bool

Tests greater than (for self and other) and is used by the > operator.

fn ge(&self, other: &Rhs) -> bool

Tests greater than or equal to (for self and other) and is used by the >= operator.

impl Serialize for Severity

fn serialize<S: Serializer>(&self, s: S) -> Result<S::Ok, S::Error>

Serialize this value into the given Serde serializer.

impl StructuralPartialEq for Severity