rusticity_term/ui/cw/

logs.rs

// CloudWatch Logs UI rendering and state
use crate::app::App;
use crate::common::{
    format_bytes, format_timestamp, render_pagination_text, render_vertical_scrollbar, CyclicEnum,
    InputFocus, SortDirection,
};
use crate::cw::insights::{DateRangeType, TimeUnit};
use crate::cw::logs::{EventColumn, LogGroupColumn, StreamColumn};
use crate::keymap::Mode;
use crate::table::TableWindow;
use crate::ui::table::{expanded_from_columns, render_table, Column as TableColumn, TableConfig};
use crate::ui::{
    calculate_dynamic_height, filter_area, format_title, get_cursor, labeled_field,
    render_fields_with_dynamic_columns, render_tabs,
};
use ratatui::{prelude::*, widgets::*};
use rusticity_core::{LogEvent, LogGroup, LogStream};

// State
pub struct CloudWatchLogGroupsState {
    pub log_groups: crate::table::TableState<LogGroup>,
    pub log_streams: Vec<LogStream>,
    pub log_events: Vec<LogEvent>,
    pub tags: crate::table::TableState<(String, String)>,
    pub selected_stream: usize,
    pub selected_event: usize,
    pub loading: bool,
    pub loading_message: String,
    pub detail_tab: DetailTab,
    pub stream_filter: String,
    pub exact_match: bool,
    pub show_expired: bool,
    pub filter_mode: bool,
    pub input_focus: InputFocus,
    pub stream_page: usize,
    pub stream_sort: StreamSort,
    pub stream_sort_desc: bool,
    pub event_filter: String,
    pub event_scroll_offset: usize,
    pub event_horizontal_scroll: usize,
    pub has_older_events: bool,
    pub event_input_focus: EventFilterFocus,
    pub stream_page_size: usize,
    pub stream_current_page: usize,
    pub expanded_event: Option<usize>,
    pub expanded_stream: Option<usize>,
    pub next_backward_token: Option<String>,
    pub start_time: Option<i64>,
    pub end_time: Option<i64>,
    pub date_range_type: DateRangeType,
    pub relative_amount: String,
    pub relative_unit: TimeUnit,
}

impl CloudWatchLogGroupsState {
    pub fn new() -> Self {
        Self::default()
    }
}

impl Default for CloudWatchLogGroupsState {
    fn default() -> Self {
        Self {
            log_groups: crate::table::TableState::new(),
            log_streams: Vec::new(),
            log_events: Vec::new(),
            tags: crate::table::TableState::new(),
            selected_stream: 0,
            selected_event: 0,
            loading: false,
            loading_message: String::new(),
            detail_tab: DetailTab::LogStreams,
            stream_filter: String::new(),
            exact_match: false,
            show_expired: false,
            filter_mode: false,
            input_focus: InputFocus::Filter,
            stream_page: 0,
            stream_sort: StreamSort::LastEventTime,
            stream_sort_desc: true,
            event_filter: String::new(),
            event_scroll_offset: 0,
            event_horizontal_scroll: 0,
            has_older_events: true,
            event_input_focus: EventFilterFocus::Filter,
            stream_page_size: 20,
            stream_current_page: 0,
            expanded_event: None,
            expanded_stream: None,
            next_backward_token: None,
            start_time: None,
            end_time: None,
            date_range_type: DateRangeType::Relative,
            relative_amount: String::new(),
            relative_unit: TimeUnit::Hours,
        }
    }
}

// Enums
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum StreamSort {
    Name,
    CreationTime,
    LastEventTime,
}

pub const FILTER_CONTROLS: [InputFocus; 4] = [
    InputFocus::Filter,
    InputFocus::Checkbox("ExactMatch"),
    InputFocus::Checkbox("ShowExpired"),
    InputFocus::Pagination,
];

/// Simplified controls for the log groups list view (no checkboxes).
pub const LIST_FILTER_CONTROLS: [InputFocus; 2] = [InputFocus::Filter, InputFocus::Pagination];

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum EventFilterFocus {
    Filter,
    DateRange,
}

impl EventFilterFocus {
    const ALL: [EventFilterFocus; 2] = [EventFilterFocus::Filter, EventFilterFocus::DateRange];

    pub fn next(self) -> Self {
        let idx = Self::ALL.iter().position(|&f| f == self).unwrap_or(0);
        Self::ALL[(idx + 1) % Self::ALL.len()]
    }

    pub fn prev(self) -> Self {
        let idx = Self::ALL.iter().position(|&f| f == self).unwrap_or(0);
        Self::ALL[(idx + Self::ALL.len() - 1) % Self::ALL.len()]
    }
}

#[derive(Debug, Clone, Copy, PartialEq)]
pub enum DetailTab {
    LogStreams,
    Tags,
    AnomalyDetection,
    MetricFilter,
    SubscriptionFilters,
    ContributorInsights,
    DataProtection,
    FieldIndexes,
    Transformer,
}

impl CyclicEnum for DetailTab {
    const ALL: &'static [Self] = &[Self::LogStreams, Self::Tags];
}

impl DetailTab {
    pub fn name(&self) -> &'static str {
        match self {
            DetailTab::LogStreams => "Log streams",
            DetailTab::Tags => "Tags",
            DetailTab::AnomalyDetection => "Anomaly detection",
            DetailTab::MetricFilter => "Metric filter",
            DetailTab::SubscriptionFilters => "Subscription filters",
            DetailTab::ContributorInsights => "Contributor insights",
            DetailTab::DataProtection => "Data protection",
            DetailTab::FieldIndexes => "Field indexes",
            DetailTab::Transformer => "Transformer",
        }
    }

    pub fn all() -> Vec<DetailTab> {
        vec![DetailTab::LogStreams, DetailTab::Tags]
    }
}

// Helper functions

pub fn selected_log_group(app: &App) -> Option<&LogGroup> {
    app.log_groups_state
        .log_groups
        .items
        .get(app.log_groups_state.log_groups.selected)
}

pub fn filtered_log_groups(app: &App) -> Vec<&LogGroup> {
    if app.log_groups_state.log_groups.filter.is_empty() {
        app.log_groups_state.log_groups.items.iter().collect()
    } else {
        app.log_groups_state
            .log_groups
            .items
            .iter()
            .filter(|group| {
                if app.log_groups_state.exact_match {
                    group.name == app.log_groups_state.log_groups.filter
                } else {
                    group.name.contains(&app.log_groups_state.log_groups.filter)
                }
            })
            .collect()
    }
}

pub fn filtered_log_streams(app: &App) -> Vec<&LogStream> {
    let mut streams: Vec<&LogStream> = if app.log_groups_state.stream_filter.is_empty() {
        app.log_groups_state.log_streams.iter().collect()
    } else {
        app.log_groups_state
            .log_streams
            .iter()
            .filter(|stream| {
                if app.log_groups_state.exact_match {
                    stream.name == app.log_groups_state.stream_filter
                } else {
                    stream.name.contains(&app.log_groups_state.stream_filter)
                }
            })
            .collect()
    };

    // Filter out expired streams unless show_expired is enabled
    if !app.log_groups_state.show_expired {
        if let Some(group) = selected_log_group(app) {
            if let Some(retention_days) = group.retention_days {
                let now = chrono::Utc::now();
                let retention_cutoff = now - chrono::Duration::days(retention_days as i64);

                streams.retain(|stream| {
                    stream
                        .last_event_time
                        .map(|t| t > retention_cutoff)
                        .unwrap_or(false)
                });
            }
        }
    }

    streams.sort_by(|a, b| {
        let cmp = match app.log_groups_state.stream_sort {
            StreamSort::Name => a.name.cmp(&b.name),
            StreamSort::CreationTime => a.creation_time.cmp(&b.creation_time),
            StreamSort::LastEventTime => a.last_event_time.cmp(&b.last_event_time),
        };
        if app.log_groups_state.stream_sort_desc {
            cmp.reverse()
        } else {
            cmp
        }
    });

    streams
}

pub fn filtered_log_events(app: &App) -> Vec<&LogEvent> {
    if app.log_groups_state.event_filter.is_empty() {
        app.log_groups_state.log_events.iter().collect()
    } else {
        app.log_groups_state
            .log_events
            .iter()
            .filter(|event| event.message.contains(&app.log_groups_state.event_filter))
            .collect()
    }
}

pub fn render_groups_list(frame: &mut Frame, app: &App, area: Rect) {
    let chunks = Layout::default()
        .direction(Direction::Vertical)
        .constraints([
            Constraint::Length(3), // Filter
            Constraint::Min(0),    // Table
        ])
        .split(area);

    let placeholder = "Filter loaded log groups or try prefix search";
    let view = app
        .log_groups_state
        .log_groups
        .prepare_view(filtered_log_groups(app), TableWindow::ScrollOffset);
    let pagination = render_pagination_text(view.current_page, view.total_pages);

    crate::ui::filter::render_simple_filter(
        frame,
        chunks[0],
        crate::ui::filter::SimpleFilterConfig {
            filter_text: &app.log_groups_state.log_groups.filter,
            placeholder,
            pagination: &pagination,
            mode: app.mode,
            is_input_focused: app.log_groups_state.input_focus == InputFocus::Filter,
            is_pagination_focused: app.log_groups_state.input_focus == InputFocus::Pagination,
        },
    );

    let mut columns: Vec<Box<dyn TableColumn<LogGroup>>> = vec![];

    for col_id in &app.cw_log_group_visible_column_ids {
        let Some(col) = LogGroupColumn::from_id(col_id) else {
            continue;
        };
        columns.push(Box::new(col));
    }

    let config = TableConfig {
        items: view.items,
        selected_index: view.selected_index,
        expanded_index: view.expanded_index,
        columns: &columns,
        sort_column: "",
        sort_direction: SortDirection::Asc,
        title: format_title(&format!("Log groups ({})", view.total_items)),
        area: chunks[1],
        get_expanded_content: Some(Box::new(|group: &LogGroup| {
            expanded_from_columns(&columns, group)
        })),
        is_active: app.mode != Mode::FilterInput,
    };

    render_table(frame, config);
}

pub fn render_group_detail(frame: &mut Frame, app: &App, area: Rect) {
    frame.render_widget(Clear, area);

    let is_active = !matches!(
        app.mode,
        Mode::SpaceMenu
            | Mode::ServicePicker
            | Mode::ColumnSelector
            | Mode::ErrorModal
            | Mode::HelpModal
            | Mode::RegionPicker
            | Mode::CalendarPicker
            | Mode::TabPicker
    );
    let border_style = if is_active {
        Style::default().fg(Color::Green)
    } else {
        Style::default()
    };

    let detail_height = if let Some(group) = selected_log_group(app) {
        let arn = format!(
            "arn:aws:logs:{}:{}:log-group:{}:*",
            app.config.region, app.config.account_id, group.name
        );
        let creation_time = group
            .creation_time
            .map(|t| format_timestamp(&t))
            .unwrap_or_else(|| "-".to_string());
        let stored_bytes = format_bytes(group.stored_bytes.unwrap_or(0));
        let deletion_protection = if group.deletion_protection_enabled.unwrap_or(false) {
            "On"
        } else {
            "Off"
        };

        let lines = vec![
            labeled_field("Log class", "Standard"),
            labeled_field("Retention", "Never expire"),
            labeled_field("Stored bytes", stored_bytes),
            labeled_field("Deletion protection", deletion_protection),
            labeled_field("Creation time", creation_time),
            labeled_field("ARN", arn),
            Line::from(vec![
                Span::styled(
                    "Metric filters: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("0"),
            ]),
            Line::from(vec![
                Span::styled(
                    "Subscription filters: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("0"),
            ]),
            Line::from(vec![
                Span::styled(
                    "KMS key ID: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("-"),
            ]),
        ];

        calculate_dynamic_height(&lines, area.width.saturating_sub(2)) + 2
    } else {
        3
    };

    let chunks = Layout::default()
        .direction(Direction::Vertical)
        .constraints([
            Constraint::Length(detail_height),
            Constraint::Length(1),
            Constraint::Min(0),
        ])
        .split(area);

    if let Some(group) = selected_log_group(app) {
        let detail_block = Block::default()
            .title(format_title("Log group details"))
            .borders(Borders::ALL)
            .border_type(BorderType::Rounded)
            .border_style(Style::default());
        let inner = detail_block.inner(chunks[0]);
        frame.render_widget(detail_block, chunks[0]);
        frame.render_widget(Clear, inner);

        let arn = format!(
            "arn:aws:logs:{}:{}:log-group:{}:*",
            app.config.region, app.config.account_id, group.name
        );
        let creation_time = group
            .creation_time
            .map(|t| format_timestamp(&t))
            .unwrap_or_else(|| "-".to_string());
        let stored_bytes = format_bytes(group.stored_bytes.unwrap_or(0));
        let deletion_protection = if group.deletion_protection_enabled.unwrap_or(false) {
            "On"
        } else {
            "Off"
        };

        let lines = vec![
            labeled_field("Log class", "Standard"),
            labeled_field("Retention", "Never expire"),
            labeled_field("Stored bytes", stored_bytes),
            labeled_field("Deletion protection", deletion_protection),
            labeled_field("Creation time", creation_time),
            labeled_field("ARN", arn),
            Line::from(vec![
                Span::styled(
                    "Metric filters: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("0"),
            ]),
            Line::from(vec![
                Span::styled(
                    "Subscription filters: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("0"),
            ]),
            Line::from(vec![
                Span::styled(
                    "KMS key ID: ",
                    Style::default().add_modifier(Modifier::BOLD),
                ),
                Span::raw("-"),
            ]),
        ];

        render_fields_with_dynamic_columns(frame, inner, lines);
    }

    render_tab_menu(frame, app, chunks[1]);

    match app.log_groups_state.detail_tab {
        DetailTab::LogStreams => render_log_streams_table(frame, app, chunks[2], border_style),
        DetailTab::Tags => render_tags_table(frame, app, chunks[2], border_style),
        _ => render_tab_placeholder(frame, app, chunks[2], border_style),
    }
}

fn render_tab_menu(frame: &mut Frame, app: &App, area: Rect) {
    frame.render_widget(Clear, area);
    let all_tabs = DetailTab::all();
    let tabs: Vec<(&str, DetailTab)> = all_tabs.iter().map(|tab| (tab.name(), *tab)).collect();

    // Debug: verify we have both tabs
    debug_assert_eq!(tabs.len(), 2, "Should have 2 tabs: LogStreams and Tags");

    render_tabs(frame, area, &tabs, &app.log_groups_state.detail_tab);
}

fn render_tab_placeholder(frame: &mut Frame, app: &App, area: Rect, border_style: Style) {
    frame.render_widget(Clear, area);
    let text = format!("{} - Coming soon", app.log_groups_state.detail_tab.name());
    let paragraph = Paragraph::new(text)
        .block(
            Block::default()
                .borders(Borders::ALL)
                .border_type(BorderType::Rounded)
                .border_style(border_style),
        )
        .style(Style::default().fg(Color::Gray));
    frame.render_widget(paragraph, area);
}
fn render_log_streams_table(frame: &mut Frame, app: &App, area: Rect, border_style: Style) {
    frame.render_widget(Clear, area);

    let chunks = Layout::default()
        .direction(Direction::Vertical)
        .constraints([Constraint::Length(3), Constraint::Min(0)])
        .split(area);

    let placeholder = "Filter loaded log streams or try prefix search";

    let exact_match_text = if app.log_groups_state.exact_match {
        "☑ Exact match"
    } else {
        "☐ Exact match"
    };
    let show_expired_text = if app.log_groups_state.show_expired {
        "☑ Show expired"
    } else {
        "☐ Show expired"
    };

    let filtered_streams = filtered_log_streams(app);
    let count = filtered_streams.len();
    let page_size = app.log_groups_state.stream_page_size;
    let total_pages = count.div_ceil(page_size);
    let current_page = app
        .log_groups_state
        .stream_current_page
        .min(total_pages.saturating_sub(1));

    // Paginate the filtered streams
    let start_idx = current_page * page_size;
    let end_idx = (start_idx + page_size).min(count);
    let paginated_streams = filtered_streams[start_idx..end_idx].to_vec();

    let pagination = render_pagination_text(current_page, total_pages);

    crate::ui::filter::render_filter_bar(
        frame,
        crate::ui::filter::FilterConfig {
            filter_text: &app.log_groups_state.stream_filter,
            placeholder,
            mode: app.mode,
            is_input_focused: app.log_groups_state.input_focus == InputFocus::Filter,
            controls: vec![
                crate::ui::filter::FilterControl {
                    text: exact_match_text.to_string(),
                    is_focused: app.log_groups_state.input_focus
                        == InputFocus::Checkbox("ExactMatch"),
                },
                crate::ui::filter::FilterControl {
                    text: show_expired_text.to_string(),
                    is_focused: app.log_groups_state.input_focus
                        == InputFocus::Checkbox("ShowExpired"),
                },
                crate::ui::filter::FilterControl {
                    text: pagination,
                    is_focused: app.log_groups_state.input_focus == InputFocus::Pagination,
                },
            ],
            area: chunks[0],
        },
    );

    let columns: Vec<Box<dyn TableColumn<LogStream>>> = app
        .cw_log_stream_visible_column_ids
        .iter()
        .filter_map(|col_id| {
            StreamColumn::from_id(col_id)
                .map(|col| Box::new(col) as Box<dyn TableColumn<LogStream>>)
        })
        .collect();

    let count_display = if count >= 100 {
        "100+".to_string()
    } else {
        count.to_string()
    };

    let sort_column = match app.log_groups_state.stream_sort {
        StreamSort::Name => "Log stream",
        StreamSort::CreationTime => "Creation time",
        StreamSort::LastEventTime => "Last event time",
    };

    let sort_direction = if app.log_groups_state.stream_sort_desc {
        SortDirection::Desc
    } else {
        SortDirection::Asc
    };

    let config = TableConfig {
        items: paginated_streams,
        selected_index: if count > 0 {
            app.log_groups_state
                .selected_stream
                .saturating_sub(start_idx)
                .min(page_size.saturating_sub(1))
        } else {
            0
        },
        expanded_index: app
            .log_groups_state
            .expanded_stream
            .map(|idx| idx.saturating_sub(start_idx)),
        columns: &columns,
        sort_column,
        sort_direction,
        title: format_title(&format!("Log streams ({})", count_display)),
        area: chunks[1],
        get_expanded_content: Some(Box::new(|stream: &LogStream| {
            expanded_from_columns(&columns, stream)
        })),
        is_active: border_style.fg == Some(Color::Green)
            && (app.mode != Mode::FilterInput
                || app.log_groups_state.input_focus != InputFocus::Filter),
    };

    render_table(frame, config);
}

pub fn render_events(frame: &mut Frame, app: &App, area: Rect) {
    frame.render_widget(Clear, area);

    let is_active = !matches!(
        app.mode,
        Mode::SpaceMenu
            | Mode::ServicePicker
            | Mode::ColumnSelector
            | Mode::ErrorModal
            | Mode::HelpModal
            | Mode::RegionPicker
            | Mode::CalendarPicker
            | Mode::TabPicker
    );
    let border_style = if is_active {
        Style::default().fg(Color::Green)
    } else {
        Style::default()
    };

    let chunks = Layout::default()
        .direction(Direction::Vertical)
        .constraints([Constraint::Length(3), Constraint::Min(0)])
        .split(area);

    // Filter and date range
    let filter_chunks = Layout::default()
        .direction(Direction::Horizontal)
        .constraints([Constraint::Percentage(50), Constraint::Percentage(50)])
        .split(chunks[0]);

    let cursor = get_cursor(
        app.mode == Mode::EventFilterInput
            && app.log_groups_state.event_input_focus == EventFilterFocus::Filter,
    );
    let filter_text =
        if app.log_groups_state.event_filter.is_empty() && app.mode != Mode::EventFilterInput {
            vec![
                Span::styled(
                    "Filter events - press ⏎ to search",
                    Style::default().fg(Color::DarkGray),
                ),
                Span::styled(cursor, Style::default().fg(Color::Yellow)),
            ]
        } else {
            vec![
                Span::raw(&app.log_groups_state.event_filter),
                Span::styled(cursor, Style::default().fg(Color::Yellow)),
            ]
        };

    let is_filter_active = app.mode == Mode::EventFilterInput
        && app.log_groups_state.event_input_focus == EventFilterFocus::Filter;
    let filter = filter_area(filter_text, is_filter_active);

    let date_border_style = if app.mode == Mode::EventFilterInput
        && app.log_groups_state.event_input_focus == EventFilterFocus::DateRange
    {
        Style::default().fg(Color::Green)
    } else {
        Style::default()
    };

    let date_range_text = vec![
        Span::raw(format!(
            "Last [{}] <{}>",
            if app.log_groups_state.relative_amount.is_empty() {
                "_"
            } else {
                &app.log_groups_state.relative_amount
            },
            app.log_groups_state.relative_unit.name()
        )),
        Span::styled(cursor, Style::default().fg(Color::Yellow)),
    ];

    let date_range = Paragraph::new(Line::from(date_range_text)).block(
        Block::default()
            .title(format_title("Date range"))
            .borders(Borders::ALL)
            .border_type(BorderType::Rounded)
            .border_style(date_border_style),
    );

    frame.render_widget(filter, filter_chunks[0]);
    frame.render_widget(date_range, filter_chunks[1]);

    // Events table with banner
    let table_area = chunks[1];

    let header_cells = app
        .cw_log_event_visible_column_ids
        .iter()
        .enumerate()
        .filter_map(|(i, col_id)| {
            EventColumn::from_id(col_id).map(|col| {
                let name = if i > 0 {
                    format!("⋮ {}", col.name())
                } else {
                    col.name().to_string()
                };
                Cell::from(name).style(Style::default().add_modifier(Modifier::BOLD))
            })
        })
        .collect::<Vec<_>>();
    let header = Row::new(header_cells)
        .style(Style::default().bg(Color::White).fg(Color::Black))
        .height(1);

    let visible_events: Vec<_> = filtered_log_events(app).into_iter().collect();

    // Add banner as first row if there are older events
    let mut all_rows: Vec<Row> = Vec::new();

    if app.log_groups_state.has_older_events {
        let banner_cells = vec![
            Cell::from(""),
            Cell::from("There are older events to load. Scroll up to load more.")
                .style(Style::default().fg(Color::Yellow)),
        ];
        all_rows.push(Row::new(banner_cells).height(1));
    }

    // Calculate available width for message column
    let table_width = table_area.width.saturating_sub(4) as usize; // borders + spacing
    let fixed_width: usize = app
        .cw_log_event_visible_column_ids
        .iter()
        .filter_map(|col_id| EventColumn::from_id(col_id))
        .filter(|col| col.width() > 0)
        .map(|col| col.width() as usize + 1) // +1 for spacing
        .sum();
    let message_max_width = table_width.saturating_sub(fixed_width).saturating_sub(3); // -3 for highlight symbol

    let mut table_row_to_event_idx = Vec::new();
    let event_rows = visible_events.iter().enumerate().flat_map(|(idx, event)| {
        let is_expanded = app.log_groups_state.expanded_event == Some(idx);
        let is_selected = idx == app.log_groups_state.event_scroll_offset;

        let mut rows = Vec::new();

        // Main row with columns - always show first line or truncated message
        let mut cells: Vec<Cell> = Vec::new();
        for (i, col_id) in app.cw_log_event_visible_column_ids.iter().enumerate() {
            let Some(col) = EventColumn::from_id(col_id) else {
                continue;
            };
            let content = match col {
                EventColumn::Timestamp => {
                    let timestamp_str = format_timestamp(&event.timestamp);
                    crate::ui::table::format_expandable_with_selection(
                        &timestamp_str,
                        is_expanded,
                        is_selected,
                    )
                }
                EventColumn::Message => {
                    let msg = event
                        .message
                        .lines()
                        .next()
                        .unwrap_or("")
                        .replace('\t', " ");
                    if msg.len() > message_max_width {
                        format!("{}…", &msg[..message_max_width.saturating_sub(1)])
                    } else {
                        msg
                    }
                }
                EventColumn::IngestionTime => event
                    .ingestion_time
                    .map(|t| format_timestamp(&t))
                    .unwrap_or_else(|| "-".to_string()),
                EventColumn::EventId => "-".to_string(),
                EventColumn::LogStreamName => app
                    .log_groups_state
                    .log_streams
                    .get(app.log_groups_state.selected_stream)
                    .map(|s| s.name.clone())
                    .unwrap_or_else(|| "-".to_string()),
            };

            let cell_content = if i > 0 {
                format!("⋮ {}", content)
            } else {
                content
            };

            cells.push(Cell::from(cell_content));
        }
        table_row_to_event_idx.push(idx);
        rows.push(Row::new(cells).height(1));

        // If expanded, add empty rows to reserve space for overlay
        if is_expanded {
            // Calculate wrapped line count
            let max_width = (table_area.width.saturating_sub(3)) as usize;
            let mut line_count = 0;

            for col_id in &app.cw_log_event_visible_column_ids {
                let Some(col) = EventColumn::from_id(col_id) else {
                    continue;
                };
                let value = match col {
                    EventColumn::Timestamp => format_timestamp(&event.timestamp),
                    EventColumn::Message => event.message.replace('\t', "    "),
                    _ => "-".to_string(),
                };
                let full_line = format!("{}: {}", col.name(), value);
                line_count += full_line.len().div_ceil(max_width);
            }

            for _ in 0..line_count {
                // Empty row to reserve space - will be covered by overlay
                table_row_to_event_idx.push(idx);
                rows.push(Row::new(vec![Cell::from("")]).height(1));
            }
        }

        rows
    });

    all_rows.extend(event_rows);

    let banner_offset = if app.log_groups_state.has_older_events {
        1
    } else {
        0
    };
    let mut table_state_index = banner_offset;
    for (i, &event_idx) in table_row_to_event_idx.iter().enumerate() {
        if event_idx == app.log_groups_state.event_scroll_offset {
            table_state_index = banner_offset + i;
            break;
        }
    }

    let widths: Vec<Constraint> = app
        .cw_log_event_visible_column_ids
        .iter()
        .filter_map(|col_id| {
            EventColumn::from_id(col_id).map(|col| {
                if col.width() == 0 {
                    Constraint::Min(0)
                } else {
                    Constraint::Length(col.width())
                }
            })
        })
        .collect();

    let table = Table::new(all_rows, widths)
        .header(header)
        .block(
            Block::default()
                .title(format_title(&format!(
                    "Log events ({})",
                    visible_events.len()
                )))
                .borders(Borders::ALL)
                .border_type(BorderType::Rounded)
                .border_style(border_style),
        )
        .column_spacing(1)
        .row_highlight_style(Style::default().bg(Color::DarkGray))
        .highlight_symbol("");

    let mut state = TableState::default();
    state.select(Some(table_state_index));

    frame.render_stateful_widget(table, table_area, &mut state);

    // Render expanded content as overlay
    if let Some(expanded_idx) = app.log_groups_state.expanded_event {
        if let Some(event) = visible_events.get(expanded_idx) {
            // Find row position
            let mut row_y = 0;
            for (i, &event_idx) in table_row_to_event_idx.iter().enumerate() {
                if event_idx == expanded_idx {
                    row_y = i;
                    break;
                }
            }

            let banner_offset = if app.log_groups_state.has_older_events {
                1
            } else {
                0
            };

            // Build content with column names
            let mut lines = Vec::new();
            let max_width = table_area.width.saturating_sub(3) as usize;

            for col_id in &app.cw_log_event_visible_column_ids {
                let Some(col) = EventColumn::from_id(col_id) else {
                    continue;
                };
                let value = match col {
                    EventColumn::Timestamp => format_timestamp(&event.timestamp),
                    EventColumn::Message => event.message.replace('\t', "    "),
                    EventColumn::IngestionTime => event
                        .ingestion_time
                        .map(|t| format_timestamp(&t))
                        .unwrap_or_else(|| "-".to_string()),
                    EventColumn::EventId => "-".to_string(),
                    EventColumn::LogStreamName => app
                        .log_groups_state
                        .log_streams
                        .get(app.log_groups_state.selected_stream)
                        .map(|s| s.name.clone())
                        .unwrap_or_else(|| "-".to_string()),
                };
                let col_name = format!("{}: ", col.name());
                let full_line = format!("{}{}", col_name, value);

                // Wrap long lines, marking first line
                if full_line.len() <= max_width {
                    lines.push((full_line, true)); // true = first line with column name
                } else {
                    // First chunk includes column name
                    let first_chunk_len = max_width.min(full_line.len());
                    lines.push((full_line[..first_chunk_len].to_string(), true));

                    // Remaining chunks are continuation
                    let mut remaining = &full_line[first_chunk_len..];
                    while !remaining.is_empty() {
                        let take = max_width.min(remaining.len());
                        lines.push((remaining[..take].to_string(), false)); // false = continuation
                        remaining = &remaining[take..];
                    }
                }
            }

            // Render each line as overlay
            // Clear entire expanded area once
            let start_y = table_area.y + 2 + banner_offset as u16 + row_y as u16 + 1;
            let max_y = table_area.y + table_area.height - 1;

            // Only render if start_y is within bounds
            if start_y < max_y {
                let available_height = (max_y - start_y) as usize;
                let visible_lines = lines.len().min(available_height);

                if visible_lines > 0 {
                    let clear_area = Rect {
                        x: table_area.x + 1,
                        y: start_y,
                        width: table_area.width.saturating_sub(3),
                        height: visible_lines as u16,
                    };
                    frame.render_widget(Clear, clear_area);
                }

                for (line_idx, (line, is_first)) in lines.iter().enumerate() {
                    let y = start_y + line_idx as u16;
                    if y >= max_y {
                        break;
                    }

                    let line_area = Rect {
                        x: table_area.x + 1,
                        y,
                        width: table_area.width.saturating_sub(3), // Leave room for scrollbar
                        height: 1,
                    };

                    // Add expansion indicator on the left
                    let is_last_line = line_idx == lines.len() - 1;
                    let indicator = if is_last_line {
                        "╰ "
                    } else if *is_first {
                        "├ "
                    } else {
                        "│ "
                    };

                    // Bold column name only on first line of each field
                    let spans = if *is_first {
                        if let Some(colon_pos) = line.find(": ") {
                            let col_name = &line[..colon_pos + 2];
                            let rest = &line[colon_pos + 2..];
                            vec![
                                Span::raw(indicator),
                                Span::styled(
                                    col_name.to_string(),
                                    Style::default().add_modifier(Modifier::BOLD),
                                ),
                                Span::raw(rest.to_string()),
                            ]
                        } else {
                            vec![Span::raw(indicator), Span::raw(line.clone())]
                        }
                    } else {
                        // Continuation line - no bold
                        vec![Span::raw(indicator), Span::raw(line.clone())]
                    };

                    let paragraph = Paragraph::new(Line::from(spans));
                    frame.render_widget(paragraph, line_area);
                }
            }
        }
    }

    // Render scrollbar
    let event_count = app.log_groups_state.log_events.len();
    if event_count > 0 {
        render_vertical_scrollbar(
            frame,
            table_area.inner(Margin {
                vertical: 1,
                horizontal: 0,
            }),
            event_count,
            app.log_groups_state.event_scroll_offset,
        );
    }
}

fn render_tags_table(frame: &mut Frame, app: &App, area: Rect, _border_style: Style) {
    use crate::cw::TagColumn;
    use crate::ui::filter::{render_simple_filter, SimpleFilterConfig};
    use crate::ui::table::{render_table, Column, TableConfig};
    use crate::ui::vertical;

    let chunks = vertical(
        [
            Constraint::Length(3), // Filter with pagination
            Constraint::Min(0),    // Table
        ],
        area,
    );

    // Filter tags
    let page_size = app.log_groups_state.tags.page_size.value().max(1);
    let filtered_tags: Vec<_> = app
        .log_groups_state
        .tags
        .items
        .iter()
        .filter(|t| {
            if app.log_groups_state.tags.filter.is_empty() {
                true
            } else {
                t.0.to_lowercase()
                    .contains(&app.log_groups_state.tags.filter.to_lowercase())
                    || t.1
                        .to_lowercase()
                        .contains(&app.log_groups_state.tags.filter.to_lowercase())
            }
        })
        .collect();

    let filtered_count = filtered_tags.len();
    let total_pages = filtered_count.div_ceil(page_size);
    let current_page = app.log_groups_state.tags.selected / page_size;
    let pagination = render_pagination_text(current_page, total_pages);

    render_simple_filter(
        frame,
        chunks[0],
        SimpleFilterConfig {
            filter_text: &app.log_groups_state.tags.filter,
            placeholder: "Search",
            pagination: &pagination,
            mode: app.mode,
            is_input_focused: app.log_groups_state.input_focus == InputFocus::Filter,
            is_pagination_focused: app.log_groups_state.input_focus == InputFocus::Pagination,
        },
    );

    // Paginate
    let scroll_offset = app.log_groups_state.tags.scroll_offset;
    let page_tags: Vec<&(String, String)> = filtered_tags
        .into_iter()
        .skip(scroll_offset)
        .take(page_size)
        .collect();

    let columns: Vec<Box<dyn Column<(String, String)>>> = app
        .cw_log_tag_visible_column_ids
        .iter()
        .filter_map(|col_id| {
            TagColumn::from_id(col_id).map(|col| Box::new(col) as Box<dyn Column<(String, String)>>)
        })
        .collect();

    let config = TableConfig {
        items: page_tags,
        selected_index: app
            .log_groups_state
            .tags
            .selected
            .saturating_sub(scroll_offset),
        expanded_index: None,
        columns: &columns,
        sort_column: "Key",
        sort_direction: crate::common::SortDirection::Asc,
        title: format_title(&format!("Tags ({})", filtered_count)),
        area: chunks[1],
        get_expanded_content: None,
        is_active: app.mode == Mode::Normal,
    };

    render_table(frame, config);
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::app::App;

    fn test_app() -> App {
        App::new_without_client("test".to_string(), Some("us-east-1".to_string()))
    }

    #[test]
    fn test_prepared_groups_uses_scroll_offset_and_handles_stale_window() {
        use ratatui::{backend::TestBackend, Terminal};
        let mut app = test_app();
        app.mode = Mode::Normal;
        app.log_groups_state.log_groups.items = (0..25)
            .map(|i| LogGroup {
                name: format!("group{i:02}"),
                creation_time: None,
                stored_bytes: None,
                retention_days: None,
                log_class: None,
                arn: None,
                log_group_arn: None,
                deletion_protection_enabled: None,
            })
            .collect();
        app.log_groups_state.log_groups.page_size = crate::common::PageSize::Ten;
        app.log_groups_state.log_groups.scroll_offset = 7;
        app.log_groups_state.log_groups.selected = 14;
        app.log_groups_state.log_groups.expanded_item = Some(9);
        let mut terminal = Terminal::new(TestBackend::new(200, 45)).unwrap();
        terminal
            .draw(|f| render_groups_list(f, &app, f.area()))
            .unwrap();
        let content = terminal
            .backend()
            .buffer()
            .content()
            .iter()
            .map(|c| c.symbol())
            .collect::<String>();
        assert!(content.contains("Log groups (25)"));
        assert!(content.contains(&render_pagination_text(0, 3)));
        assert!(content.contains("group07"));
        assert!(content.contains("group16"));
        assert!(content.contains("► group14"));
        assert!(content.contains("▼ group09"));
        assert!(!content.contains("group06"));
        assert!(!content.contains("group17"));

        app.log_groups_state.log_groups.filter = "no-match".into();
        terminal
            .draw(|f| render_groups_list(f, &app, f.area()))
            .unwrap();
        let content = terminal
            .backend()
            .buffer()
            .content()
            .iter()
            .map(|c| c.symbol())
            .collect::<String>();
        assert!(content.contains("Log groups (0)"));
        assert!(!content.contains("group14"));
        assert_eq!(app.log_groups_state.log_groups.scroll_offset, 7);
        assert_eq!(app.log_groups_state.log_groups.selected, 14);
    }

    #[test]
    fn test_input_focus_enum_cycling() {
        use InputFocus;
        assert_eq!(
            InputFocus::Filter.next(&FILTER_CONTROLS),
            InputFocus::Checkbox("ExactMatch")
        );
        assert_eq!(
            InputFocus::Checkbox("ExactMatch").next(&FILTER_CONTROLS),
            InputFocus::Checkbox("ShowExpired")
        );
        assert_eq!(
            InputFocus::Checkbox("ShowExpired").next(&FILTER_CONTROLS),
            InputFocus::Pagination
        );
        assert_eq!(
            InputFocus::Pagination.next(&FILTER_CONTROLS),
            InputFocus::Filter
        );

        assert_eq!(
            InputFocus::Filter.prev(&FILTER_CONTROLS),
            InputFocus::Pagination
        );
        assert_eq!(
            InputFocus::Pagination.prev(&FILTER_CONTROLS),
            InputFocus::Checkbox("ShowExpired")
        );
        assert_eq!(
            InputFocus::Checkbox("ShowExpired").prev(&FILTER_CONTROLS),
            InputFocus::Checkbox("ExactMatch")
        );
        assert_eq!(
            InputFocus::Checkbox("ExactMatch").prev(&FILTER_CONTROLS),
            InputFocus::Filter
        );
    }

    #[test]
    fn test_exact_match_toggle_with_space() {
        use crate::app::{Service, ViewMode};
        use crate::keymap::{Action, Mode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.view_mode = ViewMode::Detail;
        app.mode = Mode::FilterInput;
        app.log_groups_state.detail_tab = DetailTab::LogStreams;
        app.log_groups_state.input_focus = InputFocus::Checkbox("ExactMatch");

        // Initially false
        assert!(!app.log_groups_state.exact_match);

        // Toggle with space
        app.handle_action(Action::ToggleFilterCheckbox);
        assert!(app.log_groups_state.exact_match);

        // Toggle again
        app.handle_action(Action::ToggleFilterCheckbox);
        assert!(!app.log_groups_state.exact_match);
    }

    #[test]
    fn test_exact_match_filters_log_groups() {
        use crate::app::Service;
        use rusticity_core::LogGroup;

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;

        // Add test log groups
        app.log_groups_state.log_groups.items = vec![
            LogGroup {
                name: "/aws/lambda/test".to_string(),
                creation_time: None,
                stored_bytes: None,
                retention_days: None,
                log_class: None,
                arn: None,
                log_group_arn: None,
                deletion_protection_enabled: None,
            },
            LogGroup {
                name: "/aws/lambda/test-prod".to_string(),
                creation_time: None,
                stored_bytes: None,
                retention_days: None,
                log_class: None,
                arn: None,
                log_group_arn: None,
                deletion_protection_enabled: None,
            },
            LogGroup {
                name: "/aws/lambda/production".to_string(),
                creation_time: None,
                stored_bytes: None,
                retention_days: None,
                log_class: None,
                arn: None,
                log_group_arn: None,
                deletion_protection_enabled: None,
            },
        ];

        // Test partial match (default)
        app.log_groups_state.log_groups.filter = "test".to_string();
        app.log_groups_state.exact_match = false;
        let filtered = filtered_log_groups(&app);
        assert_eq!(filtered.len(), 2); // Matches "test" and "test-prod"

        // Test exact match
        app.log_groups_state.exact_match = true;
        let filtered = filtered_log_groups(&app);
        assert_eq!(filtered.len(), 0); // No exact match for "test"

        // Test exact match with full name
        app.log_groups_state.log_groups.filter = "/aws/lambda/test".to_string();
        let filtered = filtered_log_groups(&app);
        assert_eq!(filtered.len(), 1); // Exact match
        assert_eq!(filtered[0].name, "/aws/lambda/test");
    }

    #[test]
    fn test_exact_match_filters_log_streams() {
        use crate::app::{Service, ViewMode};
        use rusticity_core::LogStream;

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.view_mode = ViewMode::Detail;

        // Add test log streams
        app.log_groups_state.log_streams = vec![
            LogStream {
                name: "2024/01/01/stream1".to_string(),
                creation_time: None,
                last_event_time: None,
            },
            LogStream {
                name: "2024/01/01/stream1-backup".to_string(),
                creation_time: None,
                last_event_time: None,
            },
            LogStream {
                name: "2024/01/02/stream2".to_string(),
                creation_time: None,
                last_event_time: None,
            },
        ];

        // Test partial match (default)
        app.log_groups_state.stream_filter = "stream1".to_string();
        app.log_groups_state.exact_match = false;
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 2); // Matches "stream1" and "stream1-backup"

        // Test exact match
        app.log_groups_state.exact_match = true;
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 0); // No exact match for "stream1"

        // Test exact match with full name
        app.log_groups_state.stream_filter = "2024/01/01/stream1".to_string();
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 1); // Exact match
        assert_eq!(filtered[0].name, "2024/01/01/stream1");
    }

    #[test]
    fn test_exact_match_checkbox_focus_cycle() {
        use crate::app::{Service, ViewMode};
        use crate::keymap::{Action, Mode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.view_mode = ViewMode::Detail;
        app.mode = Mode::FilterInput;
        app.log_groups_state.detail_tab = DetailTab::LogStreams;
        app.log_groups_state.input_focus = InputFocus::Filter;

        // Cycle to exact match checkbox
        app.handle_action(Action::NextFilterFocus);
        assert_eq!(
            app.log_groups_state.input_focus,
            InputFocus::Checkbox("ExactMatch")
        );

        // Space should toggle exact match
        assert!(!app.log_groups_state.exact_match);
        app.handle_action(Action::ToggleFilterCheckbox);
        assert!(app.log_groups_state.exact_match);

        // Cycle to next control
        app.handle_action(Action::NextFilterFocus);
        assert_eq!(
            app.log_groups_state.input_focus,
            InputFocus::Checkbox("ShowExpired")
        );

        // Cycle back
        app.handle_action(Action::PrevFilterFocus);
        assert_eq!(
            app.log_groups_state.input_focus,
            InputFocus::Checkbox("ExactMatch")
        );
    }

    #[test]
    fn test_tags_tab_in_detail_view() {
        use crate::app::{Service, ViewMode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.view_mode = ViewMode::Detail;

        // Initially on LogStreams tab
        assert_eq!(app.log_groups_state.detail_tab, DetailTab::LogStreams);

        // Cycle to Tags tab
        app.log_groups_state.detail_tab = app.log_groups_state.detail_tab.next();
        assert_eq!(app.log_groups_state.detail_tab, DetailTab::Tags);

        // Cycle back to LogStreams
        app.log_groups_state.detail_tab = app.log_groups_state.detail_tab.next();
        assert_eq!(app.log_groups_state.detail_tab, DetailTab::LogStreams);
    }

    #[test]
    fn test_tags_tab_preferences_cycling() {
        use crate::app::{Service, ViewMode};
        use crate::keymap::{Action, Mode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.view_mode = ViewMode::Detail;
        app.log_groups_state.detail_tab = DetailTab::Tags;
        app.mode = Mode::ColumnSelector;
        app.column_selector_index = 0;

        // Tab from Columns to PageSize
        let page_size_idx = app.cw_log_tag_column_ids.len() + 2;
        app.handle_action(Action::NextPreferences);
        assert_eq!(app.column_selector_index, page_size_idx);

        // Tab from PageSize back to Columns
        app.handle_action(Action::NextPreferences);
        assert_eq!(app.column_selector_index, 0);

        // Shift+Tab from Columns to PageSize
        app.handle_action(Action::PrevPreferences);
        assert_eq!(app.column_selector_index, page_size_idx);
    }

    #[test]
    fn test_tags_tab_filter_mode() {
        use crate::app::{Service, ViewMode};
        use crate::keymap::{Action, Mode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::Detail;
        app.log_groups_state.detail_tab = DetailTab::Tags;
        app.mode = Mode::Normal;

        // Press 'i' to enter filter mode
        app.handle_action(Action::StartFilter);
        assert_eq!(app.mode, Mode::FilterInput);
        assert_eq!(app.log_groups_state.input_focus, InputFocus::Filter);
    }

    #[test]
    fn test_log_streams_tab_filter_mode() {
        use crate::app::{Service, ViewMode};
        use crate::keymap::{Action, Mode};

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::Detail;
        app.log_groups_state.detail_tab = DetailTab::LogStreams;
        app.mode = Mode::Normal;

        // Press 'i' to enter filter mode
        app.handle_action(Action::StartFilter);
        assert_eq!(app.mode, Mode::FilterInput);
        assert_eq!(app.log_groups_state.input_focus, InputFocus::Filter);
    }

    #[test]
    fn test_detail_tab_all_matches_cyclic_enum() {
        // Ensure DetailTab::all() returns the same tabs as CyclicEnum::ALL
        let all_tabs = DetailTab::all();
        let cyclic_tabs: Vec<DetailTab> = DetailTab::ALL.to_vec();

        assert_eq!(
            all_tabs.len(),
            cyclic_tabs.len(),
            "DetailTab::all() must return same number of tabs as CyclicEnum::ALL"
        );

        for (i, tab) in all_tabs.iter().enumerate() {
            assert_eq!(
                tab, &cyclic_tabs[i],
                "DetailTab::all() must return tabs in same order as CyclicEnum::ALL"
            );
        }
    }

    #[test]
    fn test_show_expired_filters_streams_by_retention() {
        use crate::app::{Service, ViewMode};
        use chrono::Utc;
        use rusticity_core::LogGroup;

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::Detail;

        let now = Utc::now();
        let retention_days = 7;

        // Add log group with 7-day retention
        app.log_groups_state.log_groups.items = vec![LogGroup {
            name: "/aws/lambda/test".to_string(),
            creation_time: None,
            stored_bytes: None,
            retention_days: Some(retention_days),
            log_class: None,
            arn: None,
            log_group_arn: None,
            deletion_protection_enabled: None,
        }];

        // Add streams: one recent, one expired
        app.log_groups_state.log_streams = vec![
            LogStream {
                name: "recent-stream".to_string(),
                creation_time: None,
                last_event_time: Some(now - chrono::Duration::days(3)),
            },
            LogStream {
                name: "expired-stream".to_string(),
                creation_time: None,
                last_event_time: Some(now - chrono::Duration::days(10)),
            },
        ];

        // With show_expired = false, should only show recent stream
        app.log_groups_state.show_expired = false;
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 1);
        assert_eq!(filtered[0].name, "recent-stream");

        // With show_expired = true, should show both
        app.log_groups_state.show_expired = true;
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 2);
    }

    #[test]
    fn test_show_expired_no_retention_shows_all() {
        use crate::app::{Service, ViewMode};
        use chrono::Utc;
        use rusticity_core::LogGroup;

        let mut app = test_app();
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::Detail;

        let now = Utc::now();

        // Add log group with no retention (None)
        app.log_groups_state.log_groups.items = vec![LogGroup {
            name: "/aws/lambda/test".to_string(),
            creation_time: None,
            stored_bytes: None,
            retention_days: None,
            log_class: None,
            arn: None,
            log_group_arn: None,
            deletion_protection_enabled: None,
        }];

        app.log_groups_state.log_streams = vec![
            LogStream {
                name: "stream1".to_string(),
                creation_time: None,
                last_event_time: Some(now - chrono::Duration::days(100)),
            },
            LogStream {
                name: "stream2".to_string(),
                creation_time: None,
                last_event_time: Some(now - chrono::Duration::days(1)),
            },
        ];

        // With no retention, all streams shown regardless of show_expired
        app.log_groups_state.show_expired = false;
        let filtered = filtered_log_streams(&app);
        assert_eq!(filtered.len(), 2);
    }

    #[test]
    fn test_log_streams_pagination_right_arrow_increments_by_one_page() {
        // Regression: handle_page_down was adding page_size (20) to stream_current_page
        // which is a PAGE INDEX, not an item offset. Result: page 1 → page 21 instead of page 2.
        use crate::app::ViewMode;
        use crate::app::{App, Service};
        use crate::common::InputFocus;
        use crate::keymap::Mode;

        let mut app = App::new_without_client("default".to_string(), None);
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::Detail;
        app.mode = Mode::FilterInput;
        app.log_groups_state.input_focus = InputFocus::Pagination;
        app.log_groups_state.stream_page_size = 20;
        app.log_groups_state.stream_current_page = 0;
        app.log_groups_state.selected_stream = 0;

        // Create 60 streams (3 pages of 20)
        app.log_groups_state.log_streams = (0..60)
            .map(|i| rusticity_core::types::LogStream {
                name: format!("stream-{}", i),
                creation_time: None,
                last_event_time: None,
            })
            .collect();

        crate::cw::actions::logs_page_down_filter_input(&mut app);

        assert_eq!(
            app.log_groups_state.stream_current_page, 1,
            "Right arrow must advance to page 2 (index 1), not page 21"
        );
        assert_eq!(app.log_groups_state.selected_stream, 20);

        crate::cw::actions::logs_page_up_filter_input(&mut app);
        assert_eq!(
            app.log_groups_state.stream_current_page, 0,
            "Left arrow must go back to page 1 (index 0)"
        );
        assert_eq!(app.log_groups_state.selected_stream, 0);
    }

    #[test]
    fn test_log_groups_list_tab_cycles_only_filter_and_pagination() {
        // Regression: FILTER_CONTROLS had 4 entries (Filter, ExactMatch, ShowExpired, Pagination).
        // In list view, Tab was cycling through ExactMatch/ShowExpired which are
        // only relevant in the streams detail view and not visible in the list filter bar.
        use crate::app::ViewMode;
        use crate::app::{App, Service};
        use crate::common::InputFocus;
        use crate::keymap::Mode;

        let mut app = App::new_without_client("default".to_string(), None);
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::List;
        app.mode = Mode::FilterInput;
        app.log_groups_state.input_focus = InputFocus::Filter;

        crate::cw::actions::logs_next_filter_focus(&mut app);
        assert_eq!(
            app.log_groups_state.input_focus,
            InputFocus::Pagination,
            "In list view, Tab from Filter must go directly to Pagination (skip ExactMatch/ShowExpired)"
        );

        crate::cw::actions::logs_next_filter_focus(&mut app);
        assert_eq!(
            app.log_groups_state.input_focus,
            InputFocus::Filter,
            "Tab from Pagination must wrap back to Filter"
        );
    }

    #[test]
    fn test_log_groups_down_arrow_stays_within_page_and_updates_selection() {
        // Regression: next_item adjusted scroll_offset by 1 (not page-aligned), causing
        // selected_index = selected % page_size to point to the wrong visible row.
        // After the fix, scroll_offset is snapped to page boundary so selected_index
        // equals selected - scroll_offset correctly.
        use crate::app::ViewMode;
        use crate::app::{App, Service};
        use crate::common::PageSize;
        use rusticity_core::types::LogGroup;

        let mut app = App::new_without_client("default".to_string(), None);
        app.current_service = Service::CloudWatchLogGroups;
        app.service_selected = true;
        app.view_mode = ViewMode::List;
        app.log_groups_state.log_groups.page_size = PageSize::Ten;

        // Create 21 log groups
        app.log_groups_state.log_groups.items = (0..21)
            .map(|i| LogGroup {
                name: format!("/aws/group/{}", i),
                stored_bytes: Some(0),
                retention_days: None,
                log_class: None,
                arn: None,
                log_group_arn: None,
                deletion_protection_enabled: None,
                creation_time: None,
            })
            .collect();

        // Simulate page jump to page 3 (selected=20, scroll_offset=20)
        app.log_groups_state.log_groups.selected = 20;
        app.log_groups_state.log_groups.scroll_offset = 20;

        // Down arrow — already at last item, should stay
        crate::cw::actions::logs_next_item(&mut app);
        assert_eq!(
            app.log_groups_state.log_groups.selected, 20,
            "Can't go past last item"
        );
        assert_eq!(
            app.log_groups_state.log_groups.scroll_offset, 20,
            "scroll_offset must stay page-aligned"
        );

        // Navigate back to page 2 via up arrow from item 20 to item 19
        app.log_groups_state.log_groups.selected = 20;
        app.log_groups_state.log_groups.scroll_offset = 20;
        crate::cw::actions::logs_prev_item(&mut app);
        assert_eq!(app.log_groups_state.log_groups.selected, 19);
        // scroll_offset follows selection (non-page-aligned viewport scrolling is OK)
        let scroll = app.log_groups_state.log_groups.scroll_offset;
        assert!(
            scroll <= 19,
            "scroll_offset {scroll} must be <= selected 19"
        );
    }
}