Skip to main content

ReviewRound

Struct ReviewRound 

Source
pub struct ReviewRound {
Show 17 fields pub round: usize, pub head: String, pub verified_head: Option<String>, pub reviews: Vec<ReviewRecord>, pub e2e: Vec<CommandOutcome>, pub verify_retried: bool, pub e2e_deferred: bool, pub e2e_defer_reason: Option<String>, pub fix: Option<FixRecord>, pub blocking: usize, pub answered: usize, pub expected: usize, pub clean: bool, pub progressed: bool, pub vote_split: bool, pub reconsideration: Vec<ReviewRevoteRecord>, pub verdict: Option<ReviewVote>,
}
Expand description

One review + verify + fix round.

Fields§

§round: usize

1-based round number.

§head: String

Commit the round reviewed.

§verified_head: Option<String>

Commit actually checked by a catch-up e2e, when it differs from the reviewed commit. Kept separate so reports never attribute a command result to a review target the command did not inspect.

§reviews: Vec<ReviewRecord>

Reviewer reports.

§e2e: Vec<CommandOutcome>

E2E command outcomes for this round.

§verify_retried: bool

True when the first verify attempt this round could not build or link, and e2e above holds a second attempt run before concluding. A run must never be decided on a red it could not tell from an unrelated build race.

§e2e_deferred: bool

True when e2e was intentionally left empty this round: the round already had blocking findings and another round was available, so graph::Runner::review_loop sent the fixer straight at them instead of spending a full verify run on a head it already knew would need another fix. Distinct from an e2e that is simply empty because verify.e2e has no commands configured — e2e.is_empty() alone cannot tell those apart, and conflating them is exactly how a deferred check would get painted green. A record written before this field existed defaults to false, which is the truth for it: every round used to run e2e unconditionally.

§e2e_defer_reason: Option<String>

Why e2e was deferred, set only when Self::e2e_deferred is true. Carried to the fixer’s prompt and shown in the report so “deferred” never reads as silence.

§fix: Option<FixRecord>

Fixer response, absent when the round was already clean.

§blocking: usize

Findings that hold the merge.

§answered: usize

Reviewer seats that answered (did not time out, crash, or return something unparsable).

§expected: usize

Reviewer seats the round expected an answer from — normally graph.reviewers, but recorded per round so a config change between runs never has to be inferred from history.

§clean: bool

Round ended with no blocking findings and green verification, judged against the seats that answered. See Self::incomplete for whether that verdict is missing input.

§progressed: bool

Did the tree actually move against base this round, comparing the diff after the fix to the diff the reviewers saw at the start of the round?

Never derived from the fixer’s own addressed/rejected count: that self-report has been caught lying twice on this workload (runs b455 and 6218, both of which committed a real, substantial diff while reporting 0 addressed). git does not lie about whether the tree changed, so this is what graph::Runner::review_loop counts rounds of no progress against. Absent on a round with no fix attempt (already clean, or the round the budget ran out on), where it defaults to false and is not consulted.

§vote_split: bool

Did the seats’ initial votes (ReviewRecord::vote) disagree?

§reconsideration: Vec<ReviewRevoteRecord>

One round of revoting, run only when vote_split: each seat that cast an initial vote reads every seat’s findings and votes, then revotes. Empty when the initial votes already agreed, the same as a solo candidate leaving deliberation empty.

§verdict: Option<ReviewVote>

The round’s verdict: the most cautious vote among the seats that answered, using each seat’s revote where reconsideration ran and its initial vote otherwise. None when no seat produced a usable vote — including every record written before votes existed, which is the truth for those rounds, not a gap in this one.

Implementations§

Source§

impl ReviewRound

Source

pub fn incomplete(&self) -> bool

Did at least one reviewer seat fail to answer this round?

Source

pub fn e2e_status(&self) -> E2eStatus

The honest state of this round’s e2e leg.

Never derive this from e2e.is_empty() alone anywhere else in the codebase — NotConfigured and Deferred both leave it empty, and only this method (backed by Self::e2e_deferred) tells them apart.

Trait Implementations§

Source§

impl Clone for ReviewRound

Source§

fn clone(&self) -> ReviewRound

Returns a duplicate of the value. Read more
1.0.0 (const: unstable) · Source§

fn clone_from(&mut self, source: &Self)

Performs copy-assignment from source. Read more
Source§

impl Debug for ReviewRound

Source§

fn fmt(&self, f: &mut Formatter<'_>) -> Result

Formats the value using the given formatter. Read more
Source§

impl<'de> Deserialize<'de> for ReviewRound

Source§

fn deserialize<__D>(__deserializer: __D) -> Result<Self, __D::Error>
where __D: Deserializer<'de>,

Deserialize this value from the given Serde deserializer. Read more
Source§

impl Serialize for ReviewRound

Source§

fn serialize<__S>(&self, __serializer: __S) -> Result<__S::Ok, __S::Error>
where __S: Serializer,

Serialize this value into the given Serde serializer. Read more

Auto Trait Implementations§

Blanket Implementations§

Source§

impl<T> Any for T
where T: 'static + ?Sized,

Source§

fn type_id(&self) -> TypeId

Gets the TypeId of self. Read more
Source§

impl<T> Borrow<T> for T
where T: ?Sized,

Source§

fn borrow(&self) -> &T

Immutably borrows from an owned value. Read more
Source§

impl<T> BorrowMut<T> for T
where T: ?Sized,

Source§

fn borrow_mut(&mut self) -> &mut T

Mutably borrows from an owned value. Read more
Source§

impl<T> CloneToUninit for T
where T: Clone,

Source§

unsafe fn clone_to_uninit(&self, dest: *mut u8)

🔬This is a nightly-only experimental API. (clone_to_uninit)
Performs copy-assignment from self to dest. Read more
Source§

impl<T> DeserializeOwned for T
where T: for<'de> Deserialize<'de>,

Source§

impl<T> From<T> for T

Source§

fn from(t: T) -> T

Returns the argument unchanged.

Source§

impl<T> FromRef<T> for T
where T: Clone,

Source§

fn from_ref(input: &T) -> T

Converts to this type from a reference to the input type.
Source§

impl<T> Instrument for T

Source§

fn instrument(self, span: Span) -> Instrumented<Self>

Instruments this type with the provided Span, returning an Instrumented wrapper. Read more
Source§

fn in_current_span(self) -> Instrumented<Self>

Instruments this type with the current Span, returning an Instrumented wrapper. Read more
Source§

impl<T, U> Into<U> for T
where U: From<T>,

Source§

fn into(self) -> U

Calls U::from(self).

That is, this conversion is whatever the implementation of From<T> for U chooses to do.

Source§

impl<T> IntoEither for T

Source§

fn into_either(self, into_left: bool) -> Either<Self, Self>

Converts self into a Left variant of Either<Self, Self> if into_left is true. Converts self into a Right variant of Either<Self, Self> otherwise. Read more
Source§

fn into_either_with<F>(self, into_left: F) -> Either<Self, Self>
where F: FnOnce(&Self) -> bool,

Converts self into a Left variant of Either<Self, Self> if into_left(&self) returns true. Converts self into a Right variant of Either<Self, Self> otherwise. Read more
Source§

impl<T> PolicyExt for T
where T: ?Sized,

Source§

fn and<P, B, E>(self, other: P) -> And<T, P>
where T: Sized + Policy<B, E>, P: Policy<B, E>,

Create a new Policy that returns Action::Follow only if self and other return Action::Follow. Read more
Source§

fn or<P, B, E>(self, other: P) -> Or<T, P>
where T: Sized + Policy<B, E>, P: Policy<B, E>,

Create a new Policy that returns Action::Follow if either self or other returns Action::Follow. Read more
Source§

impl<T> ToOwned for T
where T: Clone,

Source§

type Owned = T

The resulting type after obtaining ownership.
Source§

fn to_owned(&self) -> T

Creates owned data from borrowed data, usually by cloning. Read more
Source§

fn clone_into(&self, target: &mut T)

Uses borrowed data to replace owned data, usually by cloning. Read more
Source§

impl<T, U> TryFrom<U> for T
where U: Into<T>,

Source§

type Error = !

The type returned in the event of a conversion error.
Source§

fn try_from(value: U) -> Result<T, !>

Performs the conversion.
Source§

impl<T, U> TryInto<U> for T
where U: TryFrom<T>,

Source§

type Error = <U as TryFrom<T>>::Error

The type returned in the event of a conversion error.
Source§

fn try_into(self) -> Result<U, <U as TryFrom<T>>::Error>

Performs the conversion.
Source§

impl<T> WithSubscriber for T

Source§

fn with_subscriber<S>(self, subscriber: S) -> WithDispatch<Self>
where S: Into<Dispatch>,

Attaches the provided Subscriber to this type, returning a WithDispatch wrapper. Read more
Source§

fn with_current_subscriber(self) -> WithDispatch<Self>

Attaches the current default Subscriber to this type, returning a WithDispatch wrapper. Read more