zv 0.9.0

Ziglang Version Manager and Project Starter
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
//! Self-update command for zv binary using async GitHub API and self-replace crate
//!
//! Checks GitHub releases for newer versions and updates the binary if available.
//! Intelligently handles updates whether zv is running from ZV_DIR/bin or elsewhere.

use color_eyre::eyre::{Context, Result, bail, eyre};
use semver::Version;
use serde::Deserialize;
use std::{path::Path, time::Duration};
use tokio::task;
use yansi::Paint;

use crate::{App, app::utils, tools};
use walkdir::WalkDir;

#[derive(Deserialize, Debug, Clone)]
struct GitHubRelease {
    tag_name: String,
    assets: Vec<GitHubAsset>,
}

#[derive(Deserialize, Debug, Clone)]
struct GitHubAsset {
    name: String,
    browser_download_url: String,
}

pub async fn update_zv(app: &mut App, force: bool, include_prerelease: bool) -> Result<()> {
    println!("{}", "Checking for zv updates...".cyan());

    let current_version = Version::parse(env!("CARGO_PKG_VERSION"))
        .expect("CARGO_PKG_VERSION should be valid semver");

    println!("Current version: {}", Paint::yellow(&current_version));

    // Get target triple for this platform
    // The TARGET env var is set at compile time via build.rs
    let target = env!("TARGET");

    println!("  {} Detected platform: {}", "".blue(), target);

    // Fetch releases from GitHub API
    let client = reqwest::Client::builder()
        .user_agent(utils::zv_agent())
        .connect_timeout(Duration::from_secs(*crate::app::FETCH_TIMEOUT_SECS))
        .build()
        .wrap_err("Failed to create HTTP client")?;

    let (latest_release, latest_version) = if include_prerelease {
        let releases = fetch_all_releases(&client)
            .await
            .wrap_err("Failed to fetch releases from GitHub")?;

        find_latest_version(&releases, true).wrap_err("No valid releases found")?
    } else {
        let release = fetch_latest_release(&client)
            .await
            .wrap_err("Failed to fetch latest release from GitHub")?;

        // Parse version from tag_name (remove 'v' prefix if present)
        let version_str = release
            .tag_name
            .strip_prefix('v')
            .unwrap_or(&release.tag_name);
        let version = Version::parse(version_str)
            .wrap_err("Failed to parse latest version from GitHub release tag")?;

        (release, version)
    };

    let release_type = if latest_version.pre.is_empty() {
        "stable"
    } else {
        "pre-release"
    };
    println!(
        "  {} Latest {} version from releases:  {}",
        "".blue(),
        release_type,
        Paint::green(&latest_version)
    );

    // Compare versions
    if latest_version <= current_version && !force {
        println!("  {} Already up to date!", "".green());
        return Ok(());
    }

    if force && latest_version <= current_version {
        println!(
            "  {} Forcing reinstall of version {}",
            "".blue(),
            latest_version
        );
    } else {
        println!(
            "  {} Update available: {} -> {}",
            "".blue(),
            Paint::yellow(&current_version),
            Paint::green(&latest_version)
        );
    }

    // Find the correct asset for this platform
    // The naming convention is: zv-{target}.{extension}
    let asset = if cfg!(windows) {
        // Windows: only look for .zip
        let expected_asset_name = format!("zv-{target}.zip");
        latest_release
            .assets
            .iter()
            .find(|asset| asset.name == expected_asset_name)
            .ok_or_else(|| {
                let available_assets: Vec<&str> = latest_release
                    .assets
                    .iter()
                    .map(|a| a.name.as_str())
                    .filter(|name| name.starts_with("zv-") && name.ends_with(".zip"))
                    .collect();
                eyre!(
                    "No compatible release asset found for platform: {} (expected: {})\nAvailable assets: {:?}",
                    target,
                    expected_asset_name,
                    available_assets
                )
            })?
    } else {
        // MacOS/Linux: prefer .tar.gz, fallback to .tar.xz
        let gz_asset_name = format!("zv-{target}.tar.gz");
        let xz_asset_name = format!("zv-{target}.tar.xz");

        latest_release
            .assets
            .iter()
            .find(|asset| asset.name == gz_asset_name)
            .or_else(|| {
                latest_release
                    .assets
                    .iter()
                    .find(|asset| asset.name == xz_asset_name)
            })
            .ok_or_else(|| {
                let available_assets: Vec<&str> = latest_release
                    .assets
                    .iter()
                    .map(|a| a.name.as_str())
                    .filter(|name| {
                        name.starts_with("zv-") && (name.ends_with(".tar.gz") || name.ends_with(".tar.xz"))
                    })
                    .collect();
                eyre!(
                    "No compatible release asset found for platform: {} (tried: {} and {})\nAvailable assets: {:?}",
                    target,
                    gz_asset_name,
                    xz_asset_name,
                    available_assets
                )
            })?
    };

    tracing::trace!(target: "zv::update", "Found asset: {}", asset.name);

    // Check if we're running from ZV_DIR/bin/zv or somewhere else
    let current_exe = std::env::current_exe().wrap_err("Failed to get current executable path")?;
    let (zv_dir, _) = tools::fetch_zv_dir()?;
    let expected_zv_exe_path = zv_dir
        .join("bin")
        .join(if cfg!(windows) { "zv.exe" } else { "zv" });

    let running_from_zv_dir = tools::canonicalize(&current_exe)
        .ok()
        .and_then(|ce| {
            tools::canonicalize(&expected_zv_exe_path)
                .ok()
                .map(|ez| ce == ez)
        })
        .unwrap_or(false);

    if running_from_zv_dir {
        // Standard case: running from ZV_DIR/bin/zv
        // Download and replace the binary in place
        println!("  {} Downloading and installing update...", "".blue());

        let _temp_extract_dir =
            download_and_replace_binary(&client, asset, &expected_zv_exe_path, true)
                .await
                .wrap_err("Failed to update zv")?;
        // Keep _temp_extract_dir alive until after self_replace completes

        println!(
            "  {} Updated successfully to zv {}!",
            "".green(),
            latest_version
        );
    } else {
        // Running from outside ZV_DIR (e.g., cargo install, custom location)
        // Download to temp location and then copy to ZV_DIR
        println!(
            "  {} Running from outside ZV_DIR, downloading to temporary location...",
            "".blue()
        );

        // Use tempfile to create a temporary directory that will be cleaned up automatically
        let temp_dir = tempfile::Builder::new()
            .prefix("zv-update-")
            .tempdir()
            .wrap_err("Failed to create temporary directory")?;

        let temp_binary = temp_dir
            .path()
            .join(if cfg!(windows) { "zv.exe" } else { "zv" });

        // Download the binary to temp location
        let _temp_extract_dir = download_and_replace_binary(&client, asset, &temp_binary, false)
            .await
            .wrap_err("Failed to download binary to temporary location")?;
        // Keep _temp_extract_dir alive until after copy completes

        println!("  {} Downloaded version {}", "".green(), latest_version);

        // Copy the new binary to ZV_DIR/bin/zv
        println!("  {} Installing ...", "".blue());

        // Ensure ZV_DIR/bin exists
        if let Some(parent) = expected_zv_exe_path.parent() {
            tokio::fs::create_dir_all(parent).await.wrap_err_with(|| {
                format!(
                    "Failed to create ZV_DIR/bin directory: {}",
                    parent.display()
                )
            })?;
        }

        // Copy the binary
        tokio::fs::copy(&temp_binary, &expected_zv_exe_path)
            .await
            .wrap_err("Failed to copy binary to ZV_DIR")?;

        #[cfg(unix)]
        {
            use std::os::unix::fs::PermissionsExt;
            if let Err(e) = tokio::fs::set_permissions(
                &expected_zv_exe_path,
                std::fs::Permissions::from_mode(0o755),
            )
            .await
            {
                tools::warn(format!("Failed to set binary permissions: {}", e));
            }
        }

        println!(
            "  {} Updated successfully to zv {}!",
            "".green(),
            latest_version
        );
    }
    // Regenerate shims to ensure zig/zls symlinks point to the updated zv binary
    if let Some(install) = app.toolchain_manager.get_active_install() {
        println!("  {} Regenerating shims...", "".blue());
        app.toolchain_manager
            .deploy_shims(install, true, false)
            .await
            .wrap_err("Failed to regenerate shims after update")?;
        println!("  {} Shims regenerated successfully", "".green());
    }

    // Run migrations after update
    if let Err(e) = crate::app::migrations::migrate(app.path()).await {
        eprintln!("  {} Warning: Migration failed: {}", "".yellow(), e);
    }

    println!("\n{} {}", "".green(), "Update complete".green().bold());

    Ok(())
}

/// Fetch the latest release from GitHub API
async fn fetch_latest_release(client: &reqwest::Client) -> Result<GitHubRelease> {
    let url = "https://api.github.com/repos/weezy20/zv/releases/latest";

    let response = client
        .get(url)
        .send()
        .await
        .wrap_err("Failed to send request to GitHub API")?;

    if !response.status().is_success() {
        bail!(
            "GitHub API request failed with status: {}",
            response.status()
        );
    }

    let release = response
        .json::<GitHubRelease>()
        .await
        .wrap_err("Failed to parse GitHub API response")?;

    Ok(release)
}

/// Fetch all releases from GitHub API (including pre-releases)
async fn fetch_all_releases(client: &reqwest::Client) -> Result<Vec<GitHubRelease>> {
    let url = "https://api.github.com/repos/weezy20/zv/releases";

    let response = client
        .get(url)
        .send()
        .await
        .wrap_err("Failed to send request to GitHub API")?;

    if !response.status().is_success() {
        bail!(
            "GitHub API request failed with status: {}",
            response.status()
        );
    }

    let releases = response
        .json::<Vec<GitHubRelease>>()
        .await
        .wrap_err("Failed to parse GitHub API response")?;

    Ok(releases)
}

/// Find the latest version from a list of releases
/// If include_prerelease is true, considers all releases; otherwise only stable releases
fn find_latest_version(
    releases: &[GitHubRelease],
    include_prerelease: bool,
) -> Result<(GitHubRelease, Version)> {
    let mut best_release: Option<&GitHubRelease> = None;
    let mut best_version: Option<Version> = None;

    for release in releases {
        // Parse version from tag_name (remove 'v' prefix if present)
        let version_str = release
            .tag_name
            .strip_prefix('v')
            .unwrap_or(&release.tag_name);

        if let Ok(version) = Version::parse(version_str) {
            // Skip pre-releases if not requested
            if !include_prerelease && !version.pre.is_empty() {
                continue;
            }

            // Check if this is the best version so far
            if best_version.as_ref().map_or(true, |best| version > *best) {
                best_version = Some(version);
                best_release = Some(release);
            }
        }
    }

    match (best_release, best_version) {
        (Some(release), Some(version)) => Ok((release.clone(), version)),
        _ => bail!("No valid releases found"),
    }
}

/// Download and extract/replace the binary from a GitHub release asset
/// Returns the temporary directory handle to keep it alive until the caller is done
async fn download_and_replace_binary(
    client: &reqwest::Client,
    asset: &GitHubAsset,
    target_path: &Path,
    use_self_replace: bool,
) -> Result<tempfile::TempDir> {
    // Create a temporary file for the download with the correct extension
    let temp_dir =
        tempfile::tempdir().wrap_err("Failed to create temporary directory for download")?;
    let temp_file_path = temp_dir.path().join(&asset.name);

    // Download the asset
    println!("  {} Downloading {}...", "".blue(), asset.name);

    let response = client
        .get(&asset.browser_download_url)
        .send()
        .await
        .wrap_err("Failed to download release asset")?;

    if !response.status().is_success() {
        bail!("Failed to download asset: HTTP {}", response.status());
    }

    // Write to temporary file
    let mut file = tokio::fs::File::create(&temp_file_path)
        .await
        .wrap_err("Failed to create temporary download file")?;

    let mut stream = response.bytes_stream();
    use futures::StreamExt;
    use tokio::io::AsyncWriteExt;

    while let Some(chunk) = stream.next().await {
        let chunk = chunk.wrap_err("Failed to read download chunk")?;
        file.write_all(&chunk)
            .await
            .wrap_err("Failed to write download chunk")?;
    }

    file.sync_all()
        .await
        .wrap_err("Failed to sync download file to disk")?;
    drop(file); // Close the file

    // Fetch sha256 checksum file:
    println!("  {} Verifying checksum...", "".blue());
    let checksum_url = format!("{}.sha256", &asset.browser_download_url);
    let checksum_response = client
        .get(&checksum_url)
        .send()
        .await
        .wrap_err("Failed to download checksum file")?;

    if !checksum_response.status().is_success() {
        bail!(
            "Failed to download checksum file: HTTP {}",
            checksum_response.status()
        );
    }

    let checksum_content = checksum_response
        .text()
        .await
        .wrap_err("Failed to read checksum file content")?;

    // Parse the checksum file - it typically contains "<hash>  <filename>" or just "<hash>"
    // For ours the format contains "<hash> *<filename>"
    // We extract just the hash part (first 64 hex characters)
    let expected_shasum = checksum_content
        .split_whitespace()
        .next()
        .ok_or_else(|| eyre!("Checksum file is empty or invalid"))?
        .trim();

    // Verify the downloaded file's checksum
    utils::verify_checksum(&temp_file_path, expected_shasum)
        .await
        .wrap_err("Checksum verification failed - the downloaded file may be corrupted")?;

    println!("  {} Checksum verified successfully", "".green());
    println!("  {} Extracting binary...", "".blue());

    // Extract the binary from the archive
    let temp_extract_dir =
        tempfile::tempdir().wrap_err("Failed to create temporary extraction directory")?;

    extract(&temp_file_path, temp_extract_dir.path()).await?;

    // Find the zv binary in the extracted files
    // Based on cargo-dist:
    // - Unix archives (.tar.gz/.tar.xz) have a subdirectory like "zv-{target}/zv"
    // - Windows archives (.zip) extract files directly to the temp directory
    let target = env!("TARGET");
    let binary_name = if cfg!(windows) { "zv.exe" } else { "zv" };

    // Try the subdirectory structure first (Unix archives)
    let mut extracted_binary = temp_extract_dir
        .path()
        .join(format!("zv-{target}"))
        .join(binary_name);

    // If not found, try the root of the extraction directory (Windows zip)
    if !extracted_binary.is_file() {
        extracted_binary = temp_extract_dir.path().join(binary_name);
    }

    if !extracted_binary.is_file() {
        println!("  {} Debug: Listing extracted contents...", "!".yellow());
        // walkdir does the recursion for you
        for entry in WalkDir::new(temp_extract_dir.path())
            .into_iter()
            .filter_map(Result::ok)
        {
            let depth = entry.depth();
            let prefix = "  ".repeat(1 + depth); // 1 base indent + 2 spaces per level
            println!("{prefix}{}", entry.path().display());
        }

        bail!(
            "Could not find zv binary in extracted archive at: {}",
            extracted_binary.display()
        );
    }

    // Install the binary
    println!("  {} Installing update...", "".blue());

    // Ensure target directory exists
    if let Some(parent) = target_path.parent() {
        tokio::fs::create_dir_all(parent)
            .await
            .wrap_err("Failed to create target directory")?;
    }

    if use_self_replace {
        // Use self-replace to atomically replace the binary (when running from ZV_DIR)
        self_replace::self_replace(&extracted_binary)
            .wrap_err("Failed to replace binary with updated version")?;
    } else {
        tokio::fs::copy(&extracted_binary, target_path)
            .await
            .wrap_err("Failed to copy binary to target location")?;

        #[cfg(unix)]
        {
            use std::os::unix::fs::PermissionsExt;
            if let Err(e) =
                tokio::fs::set_permissions(target_path, std::fs::Permissions::from_mode(0o755))
                    .await
            {
                tools::warn(format!("Failed to set binary permissions: {}", e));
            }
        }
    }

    Ok(temp_extract_dir)
}

/// Dispatch extraction for zip/tar.xz/tar.gz
async fn extract(archive: &Path, dest: &Path) -> Result<()> {
    let ext = archive
        .extension()
        .and_then(|e| e.to_str())
        .unwrap_or_default();
    let ext2 = archive
        .file_stem()
        .and_then(|n| n.to_str()?.rsplit_once('.'))
        .map(|(_, e)| e); // foo.tar.gz  ->  tar

    match (ext, ext2) {
        ("gz", Some("tar")) => extract_tar(archive, dest, TarDecoder::Gz).await,
        ("xz", Some("tar")) => extract_tar(archive, dest, TarDecoder::Xz).await,
        ("zip", _) => extract_zip(archive, dest).await,
        _ => bail!("Unsupported archive type: {}", archive.display()),
    }
}

enum TarDecoder {
    Gz,
    Xz,
}

async fn extract_tar(archive: &Path, dest: &Path, decoder: TarDecoder) -> Result<()> {
    let archive = archive.to_owned();
    let dest = dest.to_owned();

    task::spawn_blocking(move || {
        let file = std::fs::File::open(&archive).wrap_err("Failed to open tar archive")?;

        let boxed_decoder: Box<dyn std::io::Read> = match decoder {
            TarDecoder::Gz => Box::new(flate2::read::GzDecoder::new(file)),
            TarDecoder::Xz => Box::new(xz2::read::XzDecoder::new(file)),
        };

        let mut archive = tar::Archive::new(boxed_decoder);
        archive
            .unpack(&dest)
            .wrap_err("Failed to unpack tar archive")?;

        Ok(())
    })
    .await
    .wrap_err("tar extraction task panicked")?
}

async fn extract_zip(archive: &Path, dest: &Path) -> Result<()> {
    let archive = archive.to_owned();
    let dest = dest.to_owned();

    task::spawn_blocking(move || {
        let file = std::fs::File::open(&archive).wrap_err("Failed to open zip archive")?;
        let mut zip = zip::ZipArchive::new(file).wrap_err("Failed to read zip archive")?;

        for i in 0..zip.len() {
            let mut entry = zip.by_index(i)?;
            let out_path = match entry.enclosed_name() {
                Some(p) => dest.join(p),
                None => continue,
            };

            if entry.name().ends_with('/') {
                std::fs::create_dir_all(&out_path)?;
            } else {
                if let Some(parent) = out_path.parent() {
                    std::fs::create_dir_all(parent)?;
                }
                let mut out = std::fs::File::create(&out_path)?;
                std::io::copy(&mut entry, &mut out)?;
            }

            #[cfg(unix)]
            if let Some(mode) = entry.unix_mode() {
                use std::os::unix::fs::PermissionsExt;
                std::fs::set_permissions(&out_path, std::fs::Permissions::from_mode(mode))?;
            }
        }

        Ok(())
    })
    .await
    .wrap_err("zip extraction task panicked")?
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_find_latest_version_stable_only() {
        let releases = vec![
            GitHubRelease {
                tag_name: "v0.3.1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.4.0-rc1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.4.0-rc.2".to_string(),
                assets: vec![],
            },
        ];

        let (_, version) = find_latest_version(&releases, false).unwrap();
        assert_eq!(version.to_string(), "0.3.1");
    }

    #[test]
    fn test_find_latest_version_with_prerelease() {
        let releases = vec![
            GitHubRelease {
                tag_name: "v0.3.1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.4.0-rc.1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.4.0-rc.2".to_string(),
                assets: vec![],
            },
        ];

        let (_, version) = find_latest_version(&releases, true).unwrap();
        assert_eq!(version.to_string(), "0.4.0-rc.2");
    }

    #[test]
    fn test_find_latest_version_mixed_order() {
        let releases = vec![
            GitHubRelease {
                tag_name: "v0.4.0-rc.1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.3.1".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.4.0-rc.2".to_string(),
                assets: vec![],
            },
            GitHubRelease {
                tag_name: "v0.5.0".to_string(),
                assets: vec![],
            },
        ];

        // Should find latest stable (0.5.0) when not including prereleases
        let (_, version) = find_latest_version(&releases, false).unwrap();
        assert_eq!(version.to_string(), "0.5.0");

        // Should find latest overall (0.5.0) when including prereleases
        let (_, version) = find_latest_version(&releases, true).unwrap();
        assert_eq!(version.to_string(), "0.5.0");
    }
}