zinit 0.3.9

Process supervisor with dependency management
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
//! Rhai integration for zinit client
//!
//! This module provides Rhai scripting support for zinit operations.
//! Updated for the new zinit_mos backend with TOML configuration format.

use crate::client::client::{
    DependencyDef, HealthCommon, HealthDef, LifecycleDef, LoggingDef, RestartPolicy, ServiceClass,
    ServiceConfig, ServiceDef, SocketAddr, State, Status, XinetConfig, XinetStatusFull,
};
use crate::client::handle::ZinitHandle;
use rhai::{Dynamic, Engine, EvalAltResult, Map, Position};
use std::collections::HashMap;
use std::sync::Mutex;
use std::time::Duration;

// Global handle for chained builder methods
lazy_static::lazy_static! {
    static ref GLOBAL_HANDLE: Mutex<Option<ZinitHandle>> = Mutex::new(None);
    static ref OUTPUT_BUFFER: Mutex<Vec<String>> = Mutex::new(Vec::new());
    static ref LOG_LEVEL: Mutex<u32> = Mutex::new(1);  // Default to minimal logging
}

/// Set the global handle for use by chained builder methods
pub fn set_global_handle(handle: ZinitHandle) {
    if let Ok(mut h) = GLOBAL_HANDLE.lock() {
        *h = Some(handle);
    }
}

/// Get a clone of the global handle
pub fn get_global_handle() -> Option<ZinitHandle> {
    GLOBAL_HANDLE.lock().ok().and_then(|h| h.clone())
}

/// Get current log level
#[allow(dead_code)]
fn get_log_level() -> u32 {
    LOG_LEVEL.lock().ok().map(|l| *l).unwrap_or(1)
}

/// Set log level (0-3)
fn set_log_level(level: u32) {
    if let Ok(mut l) = LOG_LEVEL.lock() {
        *l = level.min(3);
    }
}

/// Log a message based on current log level
#[allow(dead_code)]
fn log_at_level(message: &str, min_level: u32) {
    let current_level = get_log_level();
    if current_level >= min_level {
        println!("{}", message);
    }
}

/// Append to the output buffer
fn append_output(s: &str) {
    if let Ok(mut buf) = OUTPUT_BUFFER.lock() {
        buf.push(s.to_string());
    }
    // Always print to console
    println!("{}", s);
}

/// Normalize a service name: replace - with _, lowercase
pub fn normalize_service_name(name: &str) -> String {
    name.replace('-', "_").to_lowercase()
}

/// Create a Rhai runtime error
fn make_error<T>(msg: impl Into<String>) -> Result<T, Box<EvalAltResult>> {
    Err(Box::new(EvalAltResult::ErrorRuntime(
        Dynamic::from(msg.into()),
        Position::NONE,
    )))
}

// ============================================================================
// ZinitFactory - Factory for creating zinit client connections
// ============================================================================

/// Factory for creating and configuring zinit client connections.
/// Provides fluent API: zinit.socket(...).log_level(3).connect()
#[derive(Debug, Clone)]
pub struct ZinitFactory {
    socket_path: Option<String>,
    log_level: u32,
}

impl ZinitFactory {
    /// Create a new zinit factory with defaults
    pub fn new() -> Self {
        Self {
            socket_path: None,
            log_level: 1,
        }
    }

    /// Set the socket path for connection
    pub fn socket(mut self, path: &str) -> Self {
        self.socket_path = Some(path.to_string());
        self
    }

    /// Set the log level (0-3, clamped to 3)
    pub fn log_level(mut self, level: i64) -> Self {
        self.log_level = (level as u32).min(3);
        self
    }

    /// Connect to zinit server and return a connected handle.
    ///
    /// Performs a health check (ping) to verify the connection is working.
    /// The connection test is done at the Rust level via `ZinitHandle::with_socket()`
    /// or `ZinitHandle::new()`, which internally calls `test_connection()`.
    ///
    /// # Errors
    ///
    /// Returns a Rhai error if:
    /// - The socket path is invalid or the server is not running
    /// - The ping request fails (server not responding)
    pub fn connect(&self) -> Result<ZinitHandle, Box<EvalAltResult>> {
        // Set the global log level
        set_log_level(self.log_level);

        // Create handle with connection test - uses Rust-level test_connection()
        // which performs a ping and returns a descriptive error on failure.
        let handle = if let Some(ref path) = self.socket_path {
            // Use custom socket path
            ZinitHandle::with_socket(path)
        } else {
            // Use default socket path
            ZinitHandle::new()
        };

        // Convert Rust error to Rhai error with proper context
        let handle = handle.map_err(|e| {
            Box::new(EvalAltResult::ErrorRuntime(
                Dynamic::from(e.to_string()),
                Position::NONE,
            ))
        })?;

        // Set as global handle for use by other Rhai functions
        set_global_handle(handle.clone());

        // Log connection success at level 1+
        if self.log_level >= 1 {
            println!("✓ Connected to zinit server");
        }

        Ok(handle)
    }
}

impl Default for ZinitFactory {
    fn default() -> Self {
        Self::new()
    }
}

// ============================================================================
// ServiceBuilder - Builder pattern for creating service configurations
// ============================================================================

/// Builder for creating service configurations in Rhai.
/// Builds the new TOML-based ServiceConfig format.
#[derive(Debug, Clone)]
pub struct ServiceBuilder {
    // [service] section
    name: String,
    exec: String,
    dir: Option<String>,
    oneshot: bool,
    env: HashMap<String, String>,
    status: Status,
    class: ServiceClass,
    critical: bool,
    ports: Vec<u16>,

    // [dependencies] section
    after: Vec<String>,
    requires: Vec<String>,
    wants: Vec<String>,
    conflicts: Vec<String>,

    // [lifecycle] section
    restart: RestartPolicy,
    restart_delay_ms: u64,
    restart_delay_max_ms: u64,
    max_restarts: u32,
    stability_period_ms: u64,
    start_timeout_ms: u64,
    stop_timeout_ms: u64,
    stop_signal: String,

    // [health] section (optional)
    health_type: Option<String>, // "tcp", "http", "exec"
    health_target: String,
    health_expect_status: u16, // for http
    health_interval_ms: u64,
    health_timeout_ms: u64,
    health_retries: u32,
    health_start_period_ms: u64,

    // [logging] section
    log_buffer_lines: usize,
    log_file: Option<String>,
    log_forward: Option<String>,

    // Builder flags
    reset: bool,
    kill_others: bool,            // Kill other processes using declared ports
    process_filters: Vec<String>, // Process name filters for conflict detection
}

impl Default for ServiceBuilder {
    fn default() -> Self {
        Self::new()
    }
}

impl ServiceBuilder {
    /// Create a new service builder with default values
    pub fn new() -> Self {
        Self {
            // [service]
            name: String::new(),
            exec: String::new(),
            dir: None,
            oneshot: false,
            env: HashMap::new(),
            status: Status::Start,
            class: ServiceClass::User,
            critical: false,
            ports: Vec::new(),

            // [dependencies]
            after: Vec::new(),
            requires: Vec::new(),
            wants: Vec::new(),
            conflicts: Vec::new(),

            // [lifecycle]
            restart: RestartPolicy::OnFailure,
            restart_delay_ms: 1000,
            restart_delay_max_ms: 300000,
            max_restarts: 10,
            stability_period_ms: 30000,
            start_timeout_ms: 30000,
            stop_timeout_ms: 10000,
            stop_signal: "SIGTERM".to_string(),

            // [health]
            health_type: None,
            health_target: String::new(),
            health_expect_status: 200,
            health_interval_ms: 10000,
            health_timeout_ms: 5000,
            health_retries: 3,
            health_start_period_ms: 0,

            // [logging]
            log_buffer_lines: 1000,
            log_file: None,
            log_forward: None,

            // flags
            reset: false,
            kill_others: false,
            process_filters: Vec::new(),
        }
    }

    /// Check if reset flag is set
    pub fn should_reset(&self) -> bool {
        self.reset
    }

    /// Get the service name
    pub fn get_name(&self) -> &str {
        &self.name
    }

    // ============ [service] section setters ============

    /// Set the service name
    pub fn name(mut self, name: &str) -> Self {
        self.name = name.to_string();
        self
    }

    /// Set the command to execute
    pub fn exec(mut self, exec: &str) -> Self {
        self.exec = exec.to_string();
        self
    }

    /// Set the working directory
    pub fn dir(mut self, dir: &str) -> Self {
        self.dir = Some(dir.to_string());
        self
    }

    /// Set oneshot mode
    pub fn oneshot(mut self, oneshot: bool) -> Self {
        self.oneshot = oneshot;
        self
    }

    /// Set an environment variable
    pub fn env(mut self, key: &str, value: &str) -> Self {
        self.env.insert(key.to_string(), value.to_string());
        self
    }

    /// Set desired status: start (default), stop, or ignore
    pub fn status(mut self, status: &str) -> Self {
        self.status = match status.to_lowercase().as_str() {
            "stop" => Status::Stop,
            "ignore" => Status::Ignore,
            _ => Status::Start,
        };
        self
    }

    /// Set service class: user (default) or system
    pub fn class(mut self, class: &str) -> Self {
        self.class = match class.to_lowercase().as_str() {
            "system" => ServiceClass::System,
            _ => ServiceClass::User,
        };
        self
    }

    /// Mark as critical (failure triggers emergency shell in PID1 mode)
    pub fn critical(mut self, critical: bool) -> Self {
        self.critical = critical;
        self
    }

    // ============ [dependencies] section setters ============

    /// Add an "after" dependency (ordering only)
    pub fn after(mut self, dep: &str) -> Self {
        self.after.push(dep.to_string());
        self
    }

    /// Add a "requires" dependency (hard dependency)
    pub fn requires(mut self, dep: &str) -> Self {
        self.requires.push(dep.to_string());
        self
    }

    /// Add a "wants" dependency (soft dependency)
    pub fn wants(mut self, dep: &str) -> Self {
        self.wants.push(dep.to_string());
        self
    }

    /// Add a "conflicts" dependency
    pub fn conflicts(mut self, dep: &str) -> Self {
        self.conflicts.push(dep.to_string());
        self
    }

    // ============ [lifecycle] section setters ============

    /// Set restart policy: always, on-failure, never
    pub fn restart(mut self, policy: &str) -> Self {
        self.restart = match policy.to_lowercase().as_str() {
            "always" => RestartPolicy::Always,
            "never" => RestartPolicy::Never,
            _ => RestartPolicy::OnFailure,
        };
        self
    }

    /// Set restart delay in milliseconds
    pub fn restart_delay_ms(mut self, ms: i64) -> Self {
        self.restart_delay_ms = ms.max(0) as u64;
        self
    }

    /// Set max restart delay in milliseconds
    pub fn restart_delay_max_ms(mut self, ms: i64) -> Self {
        self.restart_delay_max_ms = ms.max(0) as u64;
        self
    }

    /// Set max restarts (0 = unlimited)
    pub fn max_restarts(mut self, count: i64) -> Self {
        self.max_restarts = count.max(0) as u32;
        self
    }

    /// Set stability period in milliseconds
    pub fn stability_period_ms(mut self, ms: i64) -> Self {
        self.stability_period_ms = ms.max(0) as u64;
        self
    }

    /// Set start timeout in milliseconds
    pub fn start_timeout_ms(mut self, ms: i64) -> Self {
        self.start_timeout_ms = ms.max(0) as u64;
        self
    }

    /// Set stop timeout in milliseconds
    pub fn stop_timeout_ms(mut self, ms: i64) -> Self {
        self.stop_timeout_ms = ms.max(0) as u64;
        self
    }

    /// Set stop signal (e.g., "SIGTERM", "SIGKILL")
    pub fn stop_signal(mut self, signal: &str) -> Self {
        self.stop_signal = signal.to_uppercase();
        self
    }

    // ============ [health] section setters ============

    /// Set TCP health check
    pub fn health_tcp(mut self, target: &str) -> Self {
        self.health_type = Some("tcp".to_string());
        self.health_target = target.to_string();
        self
    }

    /// Set HTTP health check
    pub fn health_http(mut self, target: &str) -> Self {
        self.health_type = Some("http".to_string());
        self.health_target = target.to_string();
        self
    }

    /// Set exec health check
    pub fn health_exec(mut self, target: &str) -> Self {
        self.health_type = Some("exec".to_string());
        self.health_target = target.to_string();
        self
    }

    /// Set expected HTTP status code (default: 200)
    pub fn health_expect_status(mut self, status: i64) -> Self {
        self.health_expect_status = status.max(100).min(599) as u16;
        self
    }

    /// Set health check interval in milliseconds
    pub fn health_interval_ms(mut self, ms: i64) -> Self {
        self.health_interval_ms = ms.max(1000) as u64;
        self
    }

    /// Set health check timeout in milliseconds
    pub fn health_timeout_ms(mut self, ms: i64) -> Self {
        self.health_timeout_ms = ms.max(0) as u64;
        self
    }

    /// Set health check retries
    pub fn health_retries(mut self, count: i64) -> Self {
        self.health_retries = count.max(1) as u32;
        self
    }

    /// Set health check start period in milliseconds
    pub fn health_start_period_ms(mut self, ms: i64) -> Self {
        self.health_start_period_ms = ms.max(0) as u64;
        self
    }

    // ============ [logging] section setters ============

    /// Set log buffer lines
    pub fn log_buffer_lines(mut self, lines: i64) -> Self {
        self.log_buffer_lines = lines.max(0) as usize;
        self
    }

    /// Set log file path
    pub fn log_file(mut self, path: &str) -> Self {
        self.log_file = Some(path.to_string());
        self
    }

    /// Set log forward address
    pub fn log_forward(mut self, addr: &str) -> Self {
        self.log_forward = Some(addr.to_string());
        self
    }

    /// Add a TCP port used by this service (can be called multiple times).
    /// When service starts, zinit checks if port is already in use by another service.
    pub fn port(mut self, port: i64) -> Self {
        if port > 0 && port <= 65535 {
            self.ports.push(port as u16);
        }
        self
    }

    // ============ Builder flags ============

    /// Enable reset mode (delete existing service before creating)
    pub fn reset(mut self) -> Self {
        self.reset = true;
        self
    }

    /// Enable kill_others mode (kill processes using declared ports)
    pub fn kill_others(mut self) -> Self {
        self.kill_others = true;
        self
    }

    /// Add a process name filter (partial match, case-insensitive).
    /// Can be called multiple times to add multiple filters.
    ///
    /// Example: process_filter("Server") matches "myServer", "TestServer"
    pub fn process_filter(mut self, filter: &str) -> Self {
        self.process_filters.push(filter.to_string());
        self
    }

    // ============ Conversion methods ============

    /// Convert to ServiceConfig for RPC
    pub fn to_config(&self) -> ServiceConfig {
        let health = self.health_type.as_ref().map(|t| {
            let common = HealthCommon {
                interval_ms: self.health_interval_ms,
                timeout_ms: self.health_timeout_ms,
                retries: self.health_retries,
                start_period_ms: self.health_start_period_ms,
            };
            match t.as_str() {
                "tcp" => HealthDef::Tcp {
                    target: self.health_target.clone(),
                    common,
                },
                "http" => HealthDef::Http {
                    target: self.health_target.clone(),
                    expect_status: self.health_expect_status,
                    common,
                },
                "exec" => HealthDef::Exec {
                    target: self.health_target.clone(),
                    common,
                },
                _ => HealthDef::Tcp {
                    target: self.health_target.clone(),
                    common,
                },
            }
        });

        ServiceConfig {
            service: ServiceDef {
                name: self.name.clone(),
                exec: self.exec.clone(),
                dir: self.dir.clone(),
                oneshot: self.oneshot,
                env: self.env.clone(),
                status: self.status,
                class: self.class,
                critical: self.critical,
                ports: self.ports.clone(),
                kill_others: self.kill_others,
                process_filters: self.process_filters.clone(),
            },
            dependencies: DependencyDef {
                after: self.after.clone(),
                requires: self.requires.clone(),
                wants: self.wants.clone(),
                conflicts: self.conflicts.clone(),
            },
            lifecycle: LifecycleDef {
                restart: self.restart,
                restart_delay_ms: self.restart_delay_ms,
                restart_delay_max_ms: self.restart_delay_max_ms,
                max_restarts: self.max_restarts,
                stability_period_ms: self.stability_period_ms,
                start_timeout_ms: self.start_timeout_ms,
                stop_timeout_ms: self.stop_timeout_ms,
                stop_signal: self.stop_signal.clone(),
            },
            health,
            logging: LoggingDef {
                buffer_lines: self.log_buffer_lines,
                file: self.log_file.clone(),
                forward: self.log_forward.clone(),
            },
        }
    }

    /// Convert to a Dynamic map for Rhai inspection
    pub fn to_dynamic(&self) -> Dynamic {
        let mut map = Map::new();
        map.insert("name".into(), self.name.clone().into());
        map.insert("exec".into(), self.exec.clone().into());
        map.insert("oneshot".into(), self.oneshot.into());
        map.insert(
            "restart".into(),
            match self.restart {
                RestartPolicy::Always => "always",
                RestartPolicy::OnFailure => "on-failure",
                RestartPolicy::Never => "never",
            }
            .into(),
        );
        if let Some(ref dir) = self.dir {
            map.insert("dir".into(), dir.clone().into());
        }
        if !self.after.is_empty() {
            let arr: Vec<Dynamic> = self.after.iter().map(|s| s.clone().into()).collect();
            map.insert("after".into(), arr.into());
        }
        if !self.requires.is_empty() {
            let arr: Vec<Dynamic> = self.requires.iter().map(|s| s.clone().into()).collect();
            map.insert("requires".into(), arr.into());
        }
        if let Some(ref ht) = self.health_type {
            map.insert("health_type".into(), ht.clone().into());
            map.insert("health_target".into(), self.health_target.clone().into());
        }
        Dynamic::from_map(map)
    }

    /// Convert to a TOML representation
    pub fn to_toml(&self) -> String {
        match self.to_config().to_toml() {
            Ok(s) => s,
            Err(_) => String::from("# Error generating TOML"),
        }
    }

    /// Convert to a markdown representation
    pub fn to_markdown(&self) -> String {
        let mut output = String::new();
        output.push_str(&format!(
            "## Service: {}\n\n",
            if self.name.is_empty() {
                "(unnamed)"
            } else {
                &self.name
            }
        ));
        output.push_str("### [service]\n");
        output.push_str("| Property | Value |\n");
        output.push_str("|----------|-------|\n");
        output.push_str(&format!("| exec | `{}` |\n", self.exec));
        output.push_str(&format!("| oneshot | {} |\n", self.oneshot));
        output.push_str(&format!("| status | {:?} |\n", self.status));
        output.push_str(&format!("| class | {:?} |\n", self.class));
        if let Some(ref dir) = self.dir {
            output.push_str(&format!("| dir | {} |\n", dir));
        }
        if self.critical {
            output.push_str("| critical | true |\n");
        }

        if !self.after.is_empty()
            || !self.requires.is_empty()
            || !self.wants.is_empty()
            || !self.conflicts.is_empty()
        {
            output.push_str("\n### [dependencies]\n");
            output.push_str("| Type | Services |\n");
            output.push_str("|------|----------|\n");
            if !self.after.is_empty() {
                output.push_str(&format!("| after | {} |\n", self.after.join(", ")));
            }
            if !self.requires.is_empty() {
                output.push_str(&format!("| requires | {} |\n", self.requires.join(", ")));
            }
            if !self.wants.is_empty() {
                output.push_str(&format!("| wants | {} |\n", self.wants.join(", ")));
            }
            if !self.conflicts.is_empty() {
                output.push_str(&format!("| conflicts | {} |\n", self.conflicts.join(", ")));
            }
        }

        output.push_str("\n### [lifecycle]\n");
        output.push_str("| Property | Value |\n");
        output.push_str("|----------|-------|\n");
        output.push_str(&format!("| restart | {:?} |\n", self.restart));
        output.push_str(&format!(
            "| restart_delay_ms | {} |\n",
            self.restart_delay_ms
        ));
        output.push_str(&format!(
            "| start_timeout_ms | {} |\n",
            self.start_timeout_ms
        ));
        output.push_str(&format!("| stop_timeout_ms | {} |\n", self.stop_timeout_ms));
        output.push_str(&format!("| stop_signal | {} |\n", self.stop_signal));

        if let Some(ref ht) = self.health_type {
            output.push_str("\n### [health]\n");
            output.push_str("| Property | Value |\n");
            output.push_str("|----------|-------|\n");
            output.push_str(&format!("| type | {} |\n", ht));
            output.push_str(&format!("| target | {} |\n", self.health_target));
            if ht == "http" {
                output.push_str(&format!(
                    "| expect_status | {} |\n",
                    self.health_expect_status
                ));
            }
            output.push_str(&format!("| interval_ms | {} |\n", self.health_interval_ms));
            output.push_str(&format!("| timeout_ms | {} |\n", self.health_timeout_ms));
            output.push_str(&format!("| retries | {} |\n", self.health_retries));
        }

        output
    }
}

impl std::fmt::Display for ServiceBuilder {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.to_toml())
    }
}

// ============================================================================
// XinetBuilder - Builder pattern for xinet proxies
// ============================================================================

/// Builder for creating xinet proxy configurations in Rhai
#[derive(Debug, Clone)]
pub struct XinetBuilder {
    name: String,
    listen_addrs: Vec<SocketAddr>,
    backend: Option<SocketAddr>,
    service: String,
    connect_timeout: u64,
    idle_timeout: u64,
    single_connection: bool,
    reset: bool,
}

impl Default for XinetBuilder {
    fn default() -> Self {
        Self::new()
    }
}

impl XinetBuilder {
    /// Create a new xinit builder with default values
    pub fn new() -> Self {
        Self {
            name: String::new(),
            listen_addrs: Vec::new(),
            backend: None,
            service: String::new(),
            connect_timeout: 30,
            idle_timeout: 0,
            single_connection: false,
            reset: false,
        }
    }

    /// Check if reset flag is set
    pub fn should_reset(&self) -> bool {
        self.reset
    }

    /// Get the proxy name
    pub fn get_name(&self) -> &str {
        &self.name
    }

    /// Set the proxy name
    pub fn name(mut self, name: &str) -> Self {
        self.name = name.to_string();
        self
    }

    /// Set a TCP listen address (replaces existing)
    pub fn listen_tcp(mut self, addr: &str) -> Self {
        self.listen_addrs = vec![SocketAddr::tcp(addr)];
        self
    }

    /// Set a Unix socket listen address (replaces existing)
    pub fn listen_unix(mut self, path: &str) -> Self {
        self.listen_addrs = vec![SocketAddr::unix(path)];
        self
    }

    /// Add an additional TCP listen address
    pub fn add_listen_tcp(mut self, addr: &str) -> Self {
        self.listen_addrs.push(SocketAddr::tcp(addr));
        self
    }

    /// Add an additional Unix socket listen address
    pub fn add_listen_unix(mut self, path: &str) -> Self {
        self.listen_addrs.push(SocketAddr::unix(path));
        self
    }

    /// Set the TCP backend address
    pub fn backend_tcp(mut self, addr: &str) -> Self {
        self.backend = Some(SocketAddr::tcp(addr));
        self
    }

    /// Set the Unix socket backend address
    pub fn backend_unix(mut self, path: &str) -> Self {
        self.backend = Some(SocketAddr::unix(path));
        self
    }

    /// Set the associated service name
    pub fn service(mut self, service: &str) -> Self {
        self.service = service.to_string();
        self
    }

    /// Enable reset mode (unregister existing proxy before creating)
    pub fn reset(mut self) -> Self {
        self.reset = true;
        self
    }

    /// Set connect timeout in seconds
    pub fn connect_timeout(mut self, seconds: i64) -> Self {
        self.connect_timeout = seconds.max(1) as u64;
        self
    }

    /// Set idle timeout in seconds (0 = never auto-stop)
    pub fn idle_timeout(mut self, seconds: i64) -> Self {
        self.idle_timeout = seconds.max(0) as u64;
        self
    }

    /// Enable single connection mode
    pub fn single_connection(mut self, single: bool) -> Self {
        self.single_connection = single;
        self
    }

    /// Get formatted listen addresses string
    pub fn listen_addrs_string(&self) -> String {
        self.listen_addrs
            .iter()
            .map(|a| a.to_string())
            .collect::<Vec<_>>()
            .join(", ")
    }

    /// Convert to XinetConfig for RPC
    pub fn to_config(&self) -> Option<XinetConfig> {
        let backend = self.backend.clone()?;
        Some(XinetConfig {
            name: self.name.clone(),
            listen: self.listen_addrs.clone(),
            backend,
            service: self.service.clone(),
            connect_timeout: self.connect_timeout,
            idle_timeout: self.idle_timeout,
            single_connection: self.single_connection,
        })
    }

    /// Convert to a TOML representation
    pub fn to_toml(&self) -> String {
        let mut output = String::new();
        output.push_str(&format!(
            "# Xinet Proxy: {}\n",
            if self.name.is_empty() {
                "(unnamed)"
            } else {
                &self.name
            }
        ));
        output.push_str(&format!("name = \"{}\"\n", self.name));
        if self.listen_addrs.len() == 1 {
            output.push_str(&format!("listen = \"{}\"\n", self.listen_addrs[0]));
        } else {
            let addrs: Vec<String> = self
                .listen_addrs
                .iter()
                .map(|a| format!("\"{}\"", a))
                .collect();
            output.push_str(&format!("listen = [{}]\n", addrs.join(", ")));
        }
        if let Some(ref backend) = self.backend {
            output.push_str(&format!("backend = \"{}\"\n", backend));
        }
        if !self.service.is_empty() {
            output.push_str(&format!("service = \"{}\"\n", self.service));
        }
        output.push_str(&format!("connect_timeout = {}\n", self.connect_timeout));
        if self.idle_timeout > 0 {
            output.push_str(&format!("idle_timeout = {}\n", self.idle_timeout));
        }
        if self.single_connection {
            output.push_str("single_connection = true\n");
        }
        output
    }

    /// Convert to a markdown representation
    pub fn to_markdown(&self) -> String {
        let mut output = String::new();
        output.push_str(&format!(
            "## Xinet Proxy: {}\n\n",
            if self.name.is_empty() {
                "(unnamed)"
            } else {
                &self.name
            }
        ));
        output.push_str("| Property | Value |\n");
        output.push_str("|----------|-------|\n");
        output.push_str(&format!("| listen | {} |\n", self.listen_addrs_string()));
        if let Some(ref backend) = self.backend {
            output.push_str(&format!("| backend | {} |\n", backend));
        }
        if !self.service.is_empty() {
            output.push_str(&format!("| service | {} |\n", self.service));
        }
        output.push_str(&format!(
            "| connect_timeout | {}s |\n",
            self.connect_timeout
        ));
        if self.idle_timeout > 0 {
            output.push_str(&format!("| idle_timeout | {}s |\n", self.idle_timeout));
        }
        if self.single_connection {
            output.push_str("| single_connection | true |\n");
        }
        output
    }
}

impl std::fmt::Display for XinetBuilder {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.to_toml())
    }
}

// ============================================================================
// Rhai Registration Functions
// ============================================================================

/// Register all zinit module functions with the Rhai engine
///
/// This registers:
/// - ServiceBuilder type and methods
/// - XinetBuilder type and methods
/// - Zinit client functions (requires handle to be set via set_global_handle)
pub fn register_zinit_module(engine: &mut Engine) -> Result<(), Box<EvalAltResult>> {
    // Register ZinitFactory type and methods (main factory API)
    engine
        .register_type_with_name::<ZinitFactory>("ZinitFactory")
        .register_fn("zinit", ZinitFactory::new)
        .register_fn("socket", |f: ZinitFactory, path: &str| f.socket(path))
        .register_fn("log_level", |f: ZinitFactory, level: i64| {
            f.log_level(level)
        })
        .register_fn("connect", |f: ZinitFactory| f.connect());

    // Register ServiceBuilder type and methods
    engine
        .register_type_with_name::<ServiceBuilder>("ServiceBuilder")
        .register_fn("zinit_service_new", ServiceBuilder::new)
        // [service] section
        .register_fn("name", service_name)
        .register_fn("exec", service_exec)
        .register_fn("dir", service_dir)
        .register_fn("oneshot", service_oneshot)
        .register_fn("env", service_env)
        .register_fn("status", service_status)
        .register_fn("class", service_class)
        .register_fn("critical", service_critical)
        // [dependencies] section
        .register_fn("after", service_after)
        .register_fn("requires", service_requires)
        .register_fn("wants", service_wants)
        .register_fn("conflicts", service_conflicts)
        // [lifecycle] section
        .register_fn("restart", service_restart)
        .register_fn("restart_delay_ms", service_restart_delay_ms)
        .register_fn("restart_delay_max_ms", service_restart_delay_max_ms)
        .register_fn("max_restarts", service_max_restarts)
        .register_fn("stability_period_ms", service_stability_period_ms)
        .register_fn("start_timeout_ms", service_start_timeout_ms)
        .register_fn("stop_timeout_ms", service_stop_timeout_ms)
        .register_fn("stop_signal", service_stop_signal)
        // [health] section
        .register_fn("health_tcp", service_health_tcp)
        .register_fn("health_http", service_health_http)
        .register_fn("health_exec", service_health_exec)
        .register_fn("health_expect_status", service_health_expect_status)
        .register_fn("health_interval_ms", service_health_interval_ms)
        .register_fn("health_timeout_ms", service_health_timeout_ms)
        .register_fn("health_retries", service_health_retries)
        .register_fn("health_start_period_ms", service_health_start_period_ms)
        // [port declarations] section
        .register_fn("port", service_port)
        // [logging] section
        .register_fn("log_buffer_lines", service_log_buffer_lines)
        .register_fn("log_file", service_log_file)
        .register_fn("log_forward", service_log_forward)
        // builder operations
        .register_fn("reset", service_reset)
        .register_fn("kill_others", service_kill_others)
        .register_fn("to_map", service_to_map)
        .register_fn("to_string", service_to_string)
        .register_fn("to_toml", service_to_toml)
        .register_fn("to_markdown", service_to_markdown)
        .register_fn("register", service_register)
        .register_fn("start", service_start)
        .register_fn("wait", service_wait);

    // Register XinetBuilder type and methods
    engine
        .register_type_with_name::<XinetBuilder>("XinetBuilder")
        .register_fn("xinet_proxy_new", XinetBuilder::new)
        .register_fn("name", xinet_name)
        .register_fn("listen_tcp", xinet_listen_tcp)
        .register_fn("listen_unix", xinet_listen_unix)
        .register_fn("add_listen_tcp", xinet_add_listen_tcp)
        .register_fn("add_listen_unix", xinet_add_listen_unix)
        .register_fn("backend_tcp", xinet_backend_tcp)
        .register_fn("backend_unix", xinet_backend_unix)
        .register_fn("service", xinet_service)
        .register_fn("connect_timeout", xinet_connect_timeout)
        .register_fn("idle_timeout", xinet_idle_timeout)
        .register_fn("single_connection", xinet_single_connection)
        .register_fn("reset", xinet_reset)
        .register_fn("to_string", xinet_to_string)
        .register_fn("to_toml", xinet_to_toml)
        .register_fn("to_markdown", xinet_to_markdown)
        .register_fn("register", xinet_register);

    // Try to connect to zinit and register client functions
    if let Ok(handle) = ZinitHandle::new() {
        register_zinit_client_functions(engine, handle);
    }

    Ok(())
}

/// Register zinit client functions that require a handle
pub fn register_zinit_client_functions(engine: &mut Engine, handle: ZinitHandle) {
    set_global_handle(handle.clone());

    // ============ System Functions ============

    // zinit_ping() -> map
    let h = handle.clone();
    engine.register_fn(
        "zinit_ping",
        move || -> Result<Dynamic, Box<EvalAltResult>> {
            match h.ping() {
                Ok(resp) => {
                    let mut map = Map::new();
                    map.insert("version".into(), resp.version.into());
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_ping failed: {}", e)),
            }
        },
    );

    // zinit_shutdown()
    let h = handle.clone();
    engine.register_fn(
        "zinit_shutdown",
        move || -> Result<(), Box<EvalAltResult>> {
            match h.shutdown() {
                Ok(_) => {
                    append_output("Server shutting down");
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_shutdown failed: {}", e)),
            }
        },
    );

    // ============ Service Functions ============

    // zinit_list() -> array
    let h = handle.clone();
    engine.register_fn(
        "zinit_list",
        move || -> Result<Dynamic, Box<EvalAltResult>> {
            match h.list() {
                Ok(services) => Ok(Dynamic::from_array(
                    services.into_iter().map(Dynamic::from).collect(),
                )),
                Err(e) => make_error(format!("zinit_list failed: {}", e)),
            }
        },
    );

    // zinit_list_md() -> prints markdown table
    let h = handle.clone();
    engine.register_fn(
        "zinit_list_md",
        move || -> Result<(), Box<EvalAltResult>> {
            match h.list() {
                Ok(services) => {
                    if services.is_empty() {
                        append_output("No services registered.");
                    } else {
                        let mut output = String::new();
                        output.push_str("| Service | State | PID |\n");
                        output.push_str("|---------|-------|-----|\n");
                        for name in services {
                            match h.status(&name) {
                                Ok(status) => {
                                    output.push_str(&format!(
                                        "| {} | {} | {} |\n",
                                        status.name, status.state, status.pid
                                    ));
                                }
                                Err(_) => {
                                    output.push_str(&format!("| {} | unknown | - |\n", name));
                                }
                            }
                        }
                        append_output(&output);
                    }
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_list_md failed: {}", e)),
            }
        },
    );

    // zinit_status(name) -> map
    let h = handle.clone();
    engine.register_fn(
        "zinit_status",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.status(&name) {
                Ok(status) => {
                    let mut map = Map::new();
                    map.insert("name".into(), status.name.into());
                    map.insert("pid".into(), (status.pid as i64).into());
                    map.insert("state".into(), status.state.to_string().into());
                    if let Some(exit_code) = status.exit_code {
                        map.insert("exit_code".into(), (exit_code as i64).into());
                    }
                    if let Some(error) = status.error {
                        map.insert("error".into(), error.into());
                    }
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_status '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_status_md(name) -> prints markdown table
    let h = handle.clone();
    engine.register_fn(
        "zinit_status_md",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.status(&name) {
                Ok(status) => {
                    let mut output = String::new();
                    output.push_str("| Property | Value |\n");
                    output.push_str("|----------|-------|\n");
                    output.push_str(&format!("| Name | {} |\n", status.name));
                    output.push_str(&format!("| State | {} |\n", status.state));
                    output.push_str(&format!("| PID | {} |\n", status.pid));
                    if let Some(exit_code) = status.exit_code {
                        output.push_str(&format!("| Exit Code | {} |\n", exit_code));
                    }
                    if let Some(ref error) = status.error {
                        output.push_str(&format!("| Error | {} |\n", error));
                    }
                    append_output(&output);
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_status_md '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_start(name)
    let h = handle.clone();
    engine.register_fn(
        "zinit_start",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.start(&name) {
                Ok(_) => {
                    append_output(&format!("Started: {}", name));
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_start '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_stop(name)
    let h = handle.clone();
    engine.register_fn(
        "zinit_stop",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.stop(&name) {
                Ok(_) => {
                    append_output(&format!("Stopped: {}", name));
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_stop '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_restart(name)
    let h = handle.clone();
    engine.register_fn(
        "zinit_restart",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.restart(&name) {
                Ok(_) => {
                    append_output(&format!("Restarted: {}", name));
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_restart '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_kill(name, signal)
    let h = handle.clone();
    engine.register_fn(
        "zinit_kill",
        move |name: &str, signal: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.kill(&name, Some(signal)) {
                Ok(_) => {
                    append_output(&format!("Sent {} to: {}", signal, name));
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_kill '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_why(name) -> map
    let h = handle.clone();
    engine.register_fn(
        "zinit_why",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.why(&name) {
                Ok(why) => {
                    let mut map = Map::new();
                    map.insert("name".into(), why.name.into());
                    map.insert("blocked".into(), why.blocked.into());
                    let waiting: Vec<Dynamic> =
                        why.waiting_on.into_iter().map(Dynamic::from).collect();
                    map.insert("waiting_on".into(), waiting.into());
                    let conflicts: Vec<Dynamic> =
                        why.conflicts_with.into_iter().map(Dynamic::from).collect();
                    map.insert("conflicts_with".into(), conflicts.into());
                    map.insert("ascii".into(), why.ascii.into());
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_why '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_tree() -> string (ASCII art)
    let h = handle.clone();
    engine.register_fn(
        "zinit_tree",
        move || -> Result<String, Box<EvalAltResult>> {
            match h.tree() {
                Ok(tree) => Ok(tree),
                Err(e) => make_error(format!("zinit_tree failed: {}", e)),
            }
        },
    );

    // zinit_tree_print() -> prints the tree
    let h = handle.clone();
    engine.register_fn(
        "zinit_tree_print",
        move || -> Result<(), Box<EvalAltResult>> {
            match h.tree() {
                Ok(tree) => {
                    append_output(&tree);
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_tree_print failed: {}", e)),
            }
        },
    );

    // zinit_delete(name)
    let h = handle.clone();
    engine.register_fn(
        "zinit_delete",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.service_delete(&name) {
                Ok(_) => {
                    append_output(&format!("Deleted: {}", name));
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_delete '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_stats(name) -> map
    let h = handle.clone();
    engine.register_fn(
        "zinit_stats",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.stats(&name) {
                Ok(stats) => {
                    let mut map = Map::new();
                    map.insert("pid".into(), (stats.pid as i64).into());
                    map.insert("memory_bytes".into(), (stats.memory_bytes as i64).into());
                    map.insert("cpu_percent".into(), (stats.cpu_percent as f64).into());
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_stats '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_stats_md(name) -> prints markdown table
    let h = handle.clone();
    engine.register_fn(
        "zinit_stats_md",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.stats(&name) {
                Ok(stats) => {
                    let mut output = String::new();
                    output.push_str("| Metric | Value |\n");
                    output.push_str("|--------|-------|\n");
                    output.push_str(&format!("| PID | {} |\n", stats.pid));
                    output.push_str(&format!("| Memory | {} bytes |\n", stats.memory_bytes));
                    output.push_str(&format!("| CPU | {:.2}% |\n", stats.cpu_percent));
                    append_output(&output);
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_stats_md '{}' failed: {}", name, e)),
            }
        },
    );

    // zinit_is_running(name) -> bool
    let h = handle.clone();
    engine.register_fn("zinit_is_running", move |name: &str| -> bool {
        let name = normalize_service_name(name);
        h.is_running(&name).unwrap_or(false)
    });

    // zinit_wait_for(name, timeout_secs) -> bool
    let h = handle.clone();
    engine.register_fn("zinit_wait_for", move |name: &str, secs: i64| -> bool {
        let name = normalize_service_name(name);
        let deadline = std::time::Instant::now() + Duration::from_secs(secs.max(1) as u64);
        loop {
            if std::time::Instant::now() >= deadline {
                return false;
            }
            if let Ok(status) = h.status(&name) {
                if status.state == State::Running {
                    return true;
                }
                if status.state == State::Failed || status.state == State::Exited {
                    return false;
                }
            }
            std::thread::sleep(Duration::from_millis(100));
        }
    });

    // ============ Service Set/Get ============

    // zinit_service_set(config) - Create or update a service via RPC
    let h = handle.clone();
    engine.register_fn(
        "zinit_service_set",
        move |builder: &mut ServiceBuilder| -> Result<Dynamic, Box<EvalAltResult>> {
            let config = builder.to_config();
            match h.service_set(config) {
                Ok(result) => {
                    let mut map = Map::new();
                    map.insert("name".into(), result.name.into());
                    if let Some(path) = result.path {
                        map.insert("path".into(), path.into());
                    }
                    if !result.warnings.is_empty() {
                        let warnings: Vec<Dynamic> =
                            result.warnings.into_iter().map(Dynamic::from).collect();
                        map.insert("warnings".into(), warnings.into());
                    }
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_service_set failed: {}", e)),
            }
        },
    );

    // zinit_service_get(name) -> ServiceConfig as map
    let h = handle.clone();
    engine.register_fn(
        "zinit_service_get",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.service_get(&name) {
                Ok(config) => {
                    let mut map = Map::new();
                    map.insert("name".into(), config.service.name.into());
                    map.insert("exec".into(), config.service.exec.into());
                    map.insert("oneshot".into(), config.service.oneshot.into());
                    if let Some(ref dir) = config.service.dir {
                        map.insert("dir".into(), dir.clone().into());
                    }
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("zinit_service_get '{}' failed: {}", name, e)),
            }
        },
    );

    // ============ Log Functions ============

    // zinit_logs(name) -> array
    let h = handle.clone();
    engine.register_fn(
        "zinit_logs",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.logs(Some(&name), None) {
                Ok(logs) => Ok(Dynamic::from_array(
                    logs.into_iter().map(Dynamic::from).collect(),
                )),
                Err(e) => make_error(format!("zinit_logs failed: {}", e)),
            }
        },
    );

    // zinit_logs_n(name, lines) -> array
    let h = handle.clone();
    engine.register_fn(
        "zinit_logs_n",
        move |name: &str, lines: i64| -> Result<Dynamic, Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.logs(Some(&name), Some(lines.max(1) as usize)) {
                Ok(logs) => Ok(Dynamic::from_array(
                    logs.into_iter().map(Dynamic::from).collect(),
                )),
                Err(e) => make_error(format!("zinit_logs_n failed: {}", e)),
            }
        },
    );

    // zinit_logs_print(name)
    let h = handle.clone();
    engine.register_fn(
        "zinit_logs_print",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            let name = normalize_service_name(name);
            match h.logs(Some(&name), None) {
                Ok(logs) => {
                    for line in logs {
                        append_output(&line);
                    }
                    Ok(())
                }
                Err(e) => make_error(format!("zinit_logs_print failed: {}", e)),
            }
        },
    );

    // zinit_logs_all() -> array (get all logs, no service filter)
    let h = handle.clone();
    engine.register_fn(
        "zinit_logs_all",
        move || -> Result<Dynamic, Box<EvalAltResult>> {
            match h.logs(None, None) {
                Ok(logs) => Ok(Dynamic::from_array(
                    logs.into_iter().map(Dynamic::from).collect(),
                )),
                Err(e) => make_error(format!("zinit_logs_all failed: {}", e)),
            }
        },
    );

    // ============ Xinet Functions ============

    // xinet_list() -> array
    let h = handle.clone();
    engine.register_fn(
        "xinet_list",
        move || -> Result<Dynamic, Box<EvalAltResult>> {
            match h.xinet_list() {
                Ok(proxies) => Ok(Dynamic::from_array(
                    proxies.into_iter().map(Dynamic::from).collect(),
                )),
                Err(e) => make_error(format!("xinet_list failed: {}", e)),
            }
        },
    );

    // xinet_delete(name)
    let h = handle.clone();
    engine.register_fn(
        "xinet_delete",
        move |name: &str| -> Result<(), Box<EvalAltResult>> {
            match h.xinet_delete(name) {
                Ok(_) => {
                    append_output(&format!("Deleted xinet proxy '{}'", name));
                    Ok(())
                }
                Err(e) => make_error(format!("xinet_delete '{}' failed: {}", name, e)),
            }
        },
    );

    // xinet_status(name) -> map
    let h = handle.clone();
    engine.register_fn(
        "xinet_status",
        move |name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            match h.xinet_status(name) {
                Ok(status) => {
                    let mut map = Map::new();
                    map.insert("name".into(), status.name.into());
                    map.insert("running".into(), status.running.into());
                    map.insert(
                        "active_connections".into(),
                        (status.active_connections as i64).into(),
                    );
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("xinet_status '{}' failed: {}", name, e)),
            }
        },
    );

    // xinet_status_all() -> array of maps
    let h = handle.clone();
    engine.register_fn(
        "xinet_status_all",
        move || -> Result<Dynamic, Box<EvalAltResult>> {
            match h.xinet_status_all() {
                Ok(statuses) => {
                    let arr: Vec<Dynamic> = statuses
                        .into_iter()
                        .map(|status: XinetStatusFull| {
                            let mut map = Map::new();
                            map.insert("name".into(), status.name.into());
                            map.insert("listen".into(), status.listen.into());
                            map.insert("backend".into(), status.backend.into());
                            map.insert("service".into(), status.service.into());
                            map.insert("running".into(), status.running.into());
                            map.insert(
                                "total_connections".into(),
                                (status.total_connections as i64).into(),
                            );
                            map.insert(
                                "active_connections".into(),
                                (status.active_connections as i64).into(),
                            );
                            map.insert(
                                "bytes_to_backend".into(),
                                (status.bytes_to_backend as i64).into(),
                            );
                            map.insert(
                                "bytes_from_backend".into(),
                                (status.bytes_from_backend as i64).into(),
                            );
                            Dynamic::from_map(map)
                        })
                        .collect();
                    Ok(Dynamic::from_array(arr))
                }
                Err(e) => make_error(format!("xinet_status_all failed: {}", e)),
            }
        },
    );
}

// ============================================================================
// ServiceBuilder Rhai wrapper functions
// ============================================================================

fn service_name(builder: &mut ServiceBuilder, name: &str) -> ServiceBuilder {
    builder.clone().name(name)
}

fn service_exec(builder: &mut ServiceBuilder, exec: &str) -> ServiceBuilder {
    builder.clone().exec(exec)
}

fn service_dir(builder: &mut ServiceBuilder, dir: &str) -> ServiceBuilder {
    builder.clone().dir(dir)
}

fn service_oneshot(builder: &mut ServiceBuilder, oneshot: bool) -> ServiceBuilder {
    builder.clone().oneshot(oneshot)
}

fn service_env(builder: &mut ServiceBuilder, key: &str, value: &str) -> ServiceBuilder {
    builder.clone().env(key, value)
}

fn service_status(builder: &mut ServiceBuilder, status: &str) -> ServiceBuilder {
    builder.clone().status(status)
}

fn service_class(builder: &mut ServiceBuilder, class: &str) -> ServiceBuilder {
    builder.clone().class(class)
}

fn service_critical(builder: &mut ServiceBuilder, critical: bool) -> ServiceBuilder {
    builder.clone().critical(critical)
}

fn service_after(builder: &mut ServiceBuilder, dep: &str) -> ServiceBuilder {
    builder.clone().after(dep)
}

fn service_requires(builder: &mut ServiceBuilder, dep: &str) -> ServiceBuilder {
    builder.clone().requires(dep)
}

fn service_wants(builder: &mut ServiceBuilder, dep: &str) -> ServiceBuilder {
    builder.clone().wants(dep)
}

fn service_conflicts(builder: &mut ServiceBuilder, dep: &str) -> ServiceBuilder {
    builder.clone().conflicts(dep)
}

fn service_restart(builder: &mut ServiceBuilder, policy: &str) -> ServiceBuilder {
    builder.clone().restart(policy)
}

fn service_restart_delay_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().restart_delay_ms(ms)
}

fn service_restart_delay_max_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().restart_delay_max_ms(ms)
}

fn service_max_restarts(builder: &mut ServiceBuilder, count: i64) -> ServiceBuilder {
    builder.clone().max_restarts(count)
}

fn service_stability_period_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().stability_period_ms(ms)
}

fn service_start_timeout_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().start_timeout_ms(ms)
}

fn service_stop_timeout_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().stop_timeout_ms(ms)
}

fn service_stop_signal(builder: &mut ServiceBuilder, signal: &str) -> ServiceBuilder {
    builder.clone().stop_signal(signal)
}

fn service_health_tcp(builder: &mut ServiceBuilder, target: &str) -> ServiceBuilder {
    builder.clone().health_tcp(target)
}

fn service_health_http(builder: &mut ServiceBuilder, target: &str) -> ServiceBuilder {
    builder.clone().health_http(target)
}

fn service_health_exec(builder: &mut ServiceBuilder, target: &str) -> ServiceBuilder {
    builder.clone().health_exec(target)
}

fn service_health_expect_status(builder: &mut ServiceBuilder, status: i64) -> ServiceBuilder {
    builder.clone().health_expect_status(status)
}

fn service_health_interval_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().health_interval_ms(ms)
}

fn service_health_timeout_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().health_timeout_ms(ms)
}

fn service_health_retries(builder: &mut ServiceBuilder, count: i64) -> ServiceBuilder {
    builder.clone().health_retries(count)
}

fn service_health_start_period_ms(builder: &mut ServiceBuilder, ms: i64) -> ServiceBuilder {
    builder.clone().health_start_period_ms(ms)
}

fn service_port(builder: &mut ServiceBuilder, port: i64) -> ServiceBuilder {
    builder.clone().port(port)
}

fn service_log_buffer_lines(builder: &mut ServiceBuilder, lines: i64) -> ServiceBuilder {
    builder.clone().log_buffer_lines(lines)
}

fn service_log_file(builder: &mut ServiceBuilder, path: &str) -> ServiceBuilder {
    builder.clone().log_file(path)
}

fn service_log_forward(builder: &mut ServiceBuilder, addr: &str) -> ServiceBuilder {
    builder.clone().log_forward(addr)
}

fn service_reset(builder: &mut ServiceBuilder) -> ServiceBuilder {
    builder.clone().reset()
}

fn service_kill_others(builder: &mut ServiceBuilder) -> ServiceBuilder {
    builder.clone().kill_others()
}

fn service_to_map(builder: &mut ServiceBuilder) -> Dynamic {
    builder.to_dynamic()
}

fn service_to_string(builder: &mut ServiceBuilder) -> String {
    builder.to_toml()
}

fn service_to_toml(builder: &mut ServiceBuilder) -> String {
    builder.to_toml()
}

fn service_to_markdown(builder: &mut ServiceBuilder) -> String {
    builder.to_markdown()
}

/// Wait for service to be running
fn service_wait(builder: &mut ServiceBuilder, secs: i64) -> Result<(), Box<EvalAltResult>> {
    let handle = match get_global_handle() {
        Some(h) => h,
        None => return make_error("No zinit connection available"),
    };

    let name = builder.get_name();
    if name.is_empty() {
        return make_error("wait: service name not set");
    }
    let name = normalize_service_name(name);

    if secs <= 0 {
        return Ok(());
    }

    let deadline = std::time::Instant::now() + Duration::from_secs(secs as u64);
    let mut consecutive_errors = 0;

    loop {
        if std::time::Instant::now() >= deadline {
            let final_state = handle
                .status(&name)
                .map(|s| s.state.to_string())
                .unwrap_or_else(|_| "unknown".to_string());
            return make_error(format!(
                "service '{}' did not start within {} seconds (state: {})",
                name, secs, final_state
            ));
        }
        match handle.status(&name) {
            Ok(status) => {
                consecutive_errors = 0;

                if status.state == State::Running {
                    return Ok(());
                }

                if status.state == State::Failed {
                    let err = status.error.unwrap_or_else(|| "unknown".to_string());
                    return make_error(format!("service '{}' failed: {}", name, err));
                }
            }
            Err(e) => {
                consecutive_errors += 1;
                if consecutive_errors >= 10 {
                    return make_error(format!(
                        "service '{}' status check failed repeatedly: {}",
                        name, e
                    ));
                }
            }
        }
        std::thread::sleep(Duration::from_millis(100));
    }
}

/// Register service via RPC (service.set - always persisted)
fn service_register(builder: &mut ServiceBuilder) -> Result<ServiceBuilder, Box<EvalAltResult>> {
    let handle = match get_global_handle() {
        Some(h) => h,
        None => return make_error("No zinit connection available"),
    };

    let name = builder.get_name();
    if name.is_empty() {
        return make_error("service creation: .name() is required");
    }
    if builder.exec.is_empty() {
        return make_error("service creation: .exec() is required");
    }

    let name = normalize_service_name(name);

    // If reset is set, try to delete existing service first
    if builder.should_reset() {
        let _ = handle.service_delete(&name);
    }

    let config = builder.to_config();
    match handle.service_set(config) {
        Ok(result) => {
            let path_info = result.path.map(|p| format!(" ({})", p)).unwrap_or_default();
            println!("Registered: {}{}", result.name, path_info);
            Ok(builder.clone())
        }
        Err(e) => make_error(format!("service '{}' registration failed: {}", name, e)),
    }
}

/// Start a service (automatically registers and resets if needed)
fn service_start(builder: &mut ServiceBuilder) -> Result<String, Box<EvalAltResult>> {
    let handle = match get_global_handle() {
        Some(h) => h,
        None => return make_error("No zinit connection available"),
    };

    let name = builder.get_name();
    if name.is_empty() {
        return make_error("service start: .name() is required");
    }
    if builder.exec.is_empty() {
        return make_error("service start: .exec() is required");
    }

    let name = normalize_service_name(name);

    // Step 1: Reset (delete existing service if present)
    if builder.should_reset() {
        let _ = handle.service_delete(&name);
    }

    // Step 2: Register via RPC (service.set - always persisted)
    let config = builder.to_config();
    if let Err(e) = handle.service_set(config) {
        return make_error(format!("failed to register service '{}': {}", name, e));
    }

    // Step 3: Start the service
    match handle.start(&name) {
        Ok(_) => {
            let msg = format!("Registered and started service: {}", name);
            println!("{}", msg);
            Ok(msg)
        }
        Err(e) => make_error(format!("failed to start service '{}': {}", name, e)),
    }
}

// ============================================================================
// XinetBuilder Rhai wrapper functions
// ============================================================================

fn xinet_name(builder: &mut XinetBuilder, name: &str) -> XinetBuilder {
    builder.clone().name(name)
}

fn xinet_listen_tcp(builder: &mut XinetBuilder, addr: &str) -> XinetBuilder {
    builder.clone().listen_tcp(addr)
}

fn xinet_listen_unix(builder: &mut XinetBuilder, path: &str) -> XinetBuilder {
    builder.clone().listen_unix(path)
}

fn xinet_add_listen_tcp(builder: &mut XinetBuilder, addr: &str) -> XinetBuilder {
    builder.clone().add_listen_tcp(addr)
}

fn xinet_add_listen_unix(builder: &mut XinetBuilder, path: &str) -> XinetBuilder {
    builder.clone().add_listen_unix(path)
}

fn xinet_backend_tcp(builder: &mut XinetBuilder, addr: &str) -> XinetBuilder {
    builder.clone().backend_tcp(addr)
}

fn xinet_backend_unix(builder: &mut XinetBuilder, path: &str) -> XinetBuilder {
    builder.clone().backend_unix(path)
}

fn xinet_service(builder: &mut XinetBuilder, service: &str) -> XinetBuilder {
    builder.clone().service(service)
}

fn xinet_connect_timeout(builder: &mut XinetBuilder, seconds: i64) -> XinetBuilder {
    builder.clone().connect_timeout(seconds)
}

fn xinet_idle_timeout(builder: &mut XinetBuilder, seconds: i64) -> XinetBuilder {
    builder.clone().idle_timeout(seconds)
}

fn xinet_single_connection(builder: &mut XinetBuilder, single: bool) -> XinetBuilder {
    builder.clone().single_connection(single)
}

fn xinet_reset(builder: &mut XinetBuilder) -> XinetBuilder {
    builder.clone().reset()
}

fn xinet_to_string(builder: &mut XinetBuilder) -> String {
    builder.to_toml()
}

fn xinet_to_toml(builder: &mut XinetBuilder) -> String {
    builder.to_toml()
}

fn xinet_to_markdown(builder: &mut XinetBuilder) -> String {
    builder.to_markdown()
}

/// Register xinet proxy via RPC (xinet.set - replaces existing)
fn xinet_register(builder: &mut XinetBuilder) -> Result<(), Box<EvalAltResult>> {
    let handle = match get_global_handle() {
        Some(h) => h,
        None => return make_error("No zinit connection available"),
    };

    let name = builder.get_name();
    if name.is_empty() {
        return make_error("xinet proxy: .name() is required");
    }
    if builder.listen_addrs.is_empty() {
        return make_error("xinet proxy: listen address is required");
    }
    if builder.backend.is_none() {
        return make_error("xinet proxy: backend address is required");
    }

    // If reset is set, delete existing proxy first
    if builder.should_reset() {
        let _ = handle.xinet_delete(name);
    }

    let config = builder.to_config().unwrap();

    match handle.xinet_set(config) {
        Ok(_) => {
            let idle_info = if builder.idle_timeout > 0 {
                format!(" (idle timeout: {}s)", builder.idle_timeout)
            } else {
                String::new()
            };
            let listen_str = builder.listen_addrs_string();
            let backend_str = builder
                .backend
                .as_ref()
                .map(|b| b.to_string())
                .unwrap_or_default();
            println!(
                "Registered xinet proxy '{}': {} -> {}{}",
                name, listen_str, backend_str, idle_info
            );
            Ok(())
        }
        Err(e) => {
            let err_str = e.to_string();
            if err_str.contains("already") {
                return make_error(format!(
                    "xinet proxy '{}' already exists. Use .reset() to delete it first",
                    name
                ));
            }
            make_error(format!("xinet proxy '{}' registration failed: {}", name, e))
        }
    }
}

// ============================================================================
// Script Execution Entry Point
// ============================================================================

/// Create a configured Rhai engine with all zinit functions registered
fn create_rhai_engine() -> Engine {
    let mut engine = Engine::new();

    // Register all zinit module functions
    let _ = register_zinit_module(&mut engine);

    // Register ZinitHandle methods (for calling methods on the zinit object returned by connect())
    register_handle_methods(&mut engine);

    engine
}

/// Register ZinitHandle methods with the Rhai engine
fn register_handle_methods(engine: &mut Engine) {
    // Register ZinitHandle type
    engine.register_type_with_name::<ZinitHandle>("ZinitHandle");

    // list() -> array
    engine.register_fn(
        "list",
        |h: &mut ZinitHandle| -> Result<rhai::Array, Box<EvalAltResult>> {
            match h.list() {
                Ok(services) => {
                    let arr: rhai::Array = services.into_iter().map(|s| Dynamic::from(s)).collect();
                    Ok(arr)
                }
                Err(e) => make_error(format!("list failed: {}", e)),
            }
        },
    );

    // status(name) -> map
    engine.register_fn(
        "status",
        |h: &mut ZinitHandle, name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            match h.status(name) {
                Ok(status) => {
                    let mut map = Map::new();
                    map.insert("name".into(), status.name.into());
                    map.insert("state".into(), status.state.to_string().into());
                    map.insert("pid".into(), (status.pid as i64).into());
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("status failed: {}", e)),
            }
        },
    );

    // service_new() -> ServiceBuilder
    engine.register_fn("service_new", |_h: &mut ZinitHandle| ServiceBuilder::new());

    // start(name) -> map
    engine.register_fn(
        "start",
        |h: &mut ZinitHandle, name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            match h.start(name) {
                Ok(_) => {
                    let mut map = Map::new();
                    map.insert("success".into(), true.into());
                    map.insert(
                        "message".into(),
                        format!("Started service: {}", name).into(),
                    );
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("start failed: {}", e)),
            }
        },
    );

    // stop(name) -> map
    engine.register_fn(
        "stop",
        |h: &mut ZinitHandle, name: &str| -> Result<Dynamic, Box<EvalAltResult>> {
            match h.stop(name) {
                Ok(_) => {
                    let mut map = Map::new();
                    map.insert("success".into(), true.into());
                    map.insert(
                        "message".into(),
                        format!("Stopped service: {}", name).into(),
                    );
                    Ok(Dynamic::from_map(map))
                }
                Err(e) => make_error(format!("stop failed: {}", e)),
            }
        },
    );
}

/// Execute a Rhai script string with access to zinit client
pub fn execute_script(script: &str) -> Result<(), Box<dyn std::error::Error>> {
    // Create a Rhai engine with all registered functions
    let engine = create_rhai_engine();

    // Create a scope with the zinit factory available as a global variable
    let mut scope = rhai::Scope::new();
    scope.push("zinit", ZinitFactory::new());

    // Strip shebang if present
    let script_content = if script.starts_with("#!") {
        // Find the end of the shebang line
        script.lines().skip(1).collect::<Vec<_>>().join("\n")
    } else {
        script.to_string()
    };

    // Evaluate the script with the zinit factory in scope
    let _result: () = engine.eval_with_scope(&mut scope, &script_content)?;

    Ok(())
}