use crate::error::{ZfsError, classify_stderr};
use crate::runner::{Cmd, CommandRunner};
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct DiscoveredPool {
pub name: String,
pub id: String,
pub state: String,
pub status: Option<String>,
}
pub fn parse_discovery(text: &str) -> Vec<DiscoveredPool> {
let mut pools = Vec::new();
let mut current: Option<DiscoveredPool> = None;
for line in text.lines() {
let trimmed = line.trim_start();
if let Some(rest) = trimmed.strip_prefix("pool:") {
if let Some(p) = current.take() {
pools.push(p);
}
current = Some(DiscoveredPool {
name: rest.trim().to_string(),
id: String::new(),
state: String::new(),
status: None,
});
continue;
}
let Some(p) = current.as_mut() else {
continue;
};
if let Some(rest) = trimmed.strip_prefix("id:") {
p.id = rest.trim().to_string();
} else if let Some(rest) = trimmed.strip_prefix("state:") {
p.state = rest.trim().to_string();
} else if let Some(rest) = trimmed.strip_prefix("status:") {
p.status = Some(rest.trim().to_string());
}
}
if let Some(p) = current.take() {
pools.push(p);
}
pools.retain(|p| !p.name.is_empty());
pools
}
pub async fn discover(runner: &dyn CommandRunner) -> Result<Vec<DiscoveredPool>, ZfsError> {
let output = runner.run(Cmd::new("zpool").arg("import")).await?;
let combined = format!(
"{}\n{}",
String::from_utf8_lossy(&output.stdout),
String::from_utf8_lossy(&output.stderr),
);
let pools = parse_discovery(&combined);
if output.status.success() || !pools.is_empty() {
return Ok(pools);
}
if combined.contains("no pools available to import") {
return Ok(Vec::new());
}
Err(classify_stderr(
&String::from_utf8_lossy(&output.stderr),
output.status.code(),
))
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn parse_empty_input_yields_empty_vec() {
assert!(parse_discovery("").is_empty());
assert!(parse_discovery("no pools available to import\n").is_empty());
}
#[test]
fn parse_single_online_pool() {
let text = " pool: tank\n id: 9316430153991325696\n state: ONLINE\n";
let pools = parse_discovery(text);
assert_eq!(pools.len(), 1);
assert_eq!(pools[0].name, "tank");
assert_eq!(pools[0].id, "9316430153991325696");
assert_eq!(pools[0].state, "ONLINE");
assert!(pools[0].status.is_none());
}
#[test]
fn parse_multiple_pools_separated_by_blank_lines() {
let text = "\
pool: a
id: 1
state: ONLINE
pool: b
id: 2
state: ONLINE
";
let pools = parse_discovery(text);
assert_eq!(pools.len(), 2);
assert_eq!(pools[0].name, "a");
assert_eq!(pools[1].name, "b");
}
#[test]
fn parse_captures_status_for_degraded() {
let text = "\
pool: dpool
id: 42
state: DEGRADED
status: One or more devices could not be opened.
action: Attach the missing device.
";
let pools = parse_discovery(text);
assert_eq!(pools.len(), 1);
assert_eq!(pools[0].state, "DEGRADED");
assert_eq!(
pools[0].status.as_deref(),
Some("One or more devices could not be opened.")
);
}
#[test]
fn parse_ignores_lines_before_first_pool() {
let text = "some preamble text\n pool: tank\n state: ONLINE\n";
let pools = parse_discovery(text);
assert_eq!(pools.len(), 1);
assert_eq!(pools[0].name, "tank");
}
#[test]
fn parse_ignores_unknown_keys() {
let text = "\
pool: tank
id: 1
state: ONLINE
cachefile: /etc/zfs/zpool.cache
comment: my pool
config:
\ttank ONLINE
";
let pools = parse_discovery(text);
assert_eq!(pools.len(), 1);
assert_eq!(pools[0].state, "ONLINE");
}
}