zellij-client 0.44.3

The client-side library for Zellij
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
use crate::os_input_output::{AsyncSignals, AsyncStdin, ClientOsApi, SignalEvent};
use crate::remote_attach::websockets::MaybeTls;
use crate::remote_attach::WebSocketConnections;
use crate::run_remote_client_terminal_loop;
use crate::web_client::control_message::{
    WebClientToWebServerControlMessage, WebClientToWebServerControlMessagePayload,
    WebServerToWebClientControlMessage,
};
use async_trait::async_trait;
use futures_util::{SinkExt, StreamExt};
use serial_test::serial;
use std::io::{self, Write};
use std::sync::{Arc, Mutex};
use std::time::Duration;
use tokio::net::TcpStream;
use tokio::sync::mpsc;
use tokio_tungstenite::tungstenite::Message;
use zellij_utils::data::Palette;
use zellij_utils::errors::ErrorContext;
use zellij_utils::ipc::{ClientToServerMsg, ServerToClientMsg};
use zellij_utils::pane_size::Size;

/// Mock stdin that allows tests to inject input data
struct MockAsyncStdin {
    rx: Arc<tokio::sync::Mutex<mpsc::UnboundedReceiver<Vec<u8>>>>,
}

#[async_trait]
impl AsyncStdin for MockAsyncStdin {
    async fn read(&mut self) -> io::Result<Vec<u8>> {
        match self.rx.lock().await.recv().await {
            Some(data) => Ok(data),
            None => Ok(Vec::new()), // EOF
        }
    }
}

/// Mock signal listener that allows tests to inject signals
struct MockAsyncSignals {
    rx: Arc<tokio::sync::Mutex<mpsc::UnboundedReceiver<SignalEvent>>>,
}

#[async_trait]
impl AsyncSignals for MockAsyncSignals {
    async fn recv(&mut self) -> Option<SignalEvent> {
        self.rx.lock().await.recv().await
    }
}

/// Mock ClientOsApi for testing
#[derive(Clone)]
struct TestClientOsApi {
    stdout_buffer: Arc<Mutex<Vec<u8>>>,
    stdin_rx: Arc<tokio::sync::Mutex<mpsc::UnboundedReceiver<Vec<u8>>>>,
    signal_rx: Arc<tokio::sync::Mutex<mpsc::UnboundedReceiver<SignalEvent>>>,
    terminal_size: Size,
}

impl TestClientOsApi {
    fn new(
        stdin_rx: mpsc::UnboundedReceiver<Vec<u8>>,
        signal_rx: mpsc::UnboundedReceiver<SignalEvent>,
    ) -> Self {
        Self {
            stdout_buffer: Arc::new(Mutex::new(Vec::new())),
            stdin_rx: Arc::new(tokio::sync::Mutex::new(stdin_rx)),
            signal_rx: Arc::new(tokio::sync::Mutex::new(signal_rx)),
            terminal_size: Size { rows: 24, cols: 80 },
        }
    }
}

impl std::fmt::Debug for TestClientOsApi {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("TestClientOsApi").finish()
    }
}

impl ClientOsApi for TestClientOsApi {
    fn get_terminal_size(&self) -> Size {
        self.terminal_size
    }

    fn set_raw_mode(&mut self) {}

    fn unset_raw_mode(&self) -> Result<(), std::io::Error> {
        Ok(())
    }

    fn get_stdout_writer(&self) -> Box<dyn Write> {
        Box::new(TestWriter {
            buffer: self.stdout_buffer.clone(),
        })
    }

    fn get_stdin_reader(&self) -> Box<dyn io::BufRead> {
        Box::new(io::Cursor::new(Vec::new()))
    }

    fn update_session_name(&mut self, _new_session_name: String) {}

    fn read_from_stdin(&mut self) -> Result<Vec<u8>, &'static str> {
        Ok(Vec::new())
    }

    fn box_clone(&self) -> Box<dyn ClientOsApi> {
        Box::new(self.clone())
    }

    fn send_to_server(&self, _msg: ClientToServerMsg) {}

    fn recv_from_server(&self) -> Option<(ServerToClientMsg, ErrorContext)> {
        None
    }

    fn handle_signals(
        &self,
        _sigwinch_cb: Box<dyn Fn()>,
        _quit_cb: Box<dyn Fn()>,
        _resize_receiver: Option<std::sync::mpsc::Receiver<()>>,
    ) {
    }

    fn connect_to_server(&self, _path: &std::path::Path) {}

    fn load_palette(&self) -> Palette {
        Palette::default()
    }

    fn enable_mouse(&self) -> anyhow::Result<()> {
        Ok(())
    }

    fn disable_mouse(&self) -> anyhow::Result<()> {
        Ok(())
    }

    fn get_async_stdin_reader(&self) -> Box<dyn AsyncStdin> {
        Box::new(MockAsyncStdin {
            rx: self.stdin_rx.clone(),
        })
    }

    fn get_async_signal_listener(&self) -> io::Result<Box<dyn AsyncSignals>> {
        Ok(Box::new(MockAsyncSignals {
            rx: self.signal_rx.clone(),
        }))
    }
}

struct TestWriter {
    buffer: Arc<Mutex<Vec<u8>>>,
}

impl Write for TestWriter {
    fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
        self.buffer.lock().unwrap().extend_from_slice(buf);
        Ok(buf.len())
    }

    fn flush(&mut self) -> io::Result<()> {
        Ok(())
    }
}

mod mock_ws_server {
    use super::*;
    use axum::{
        extract::{
            ws::{WebSocket, WebSocketUpgrade},
            State,
        },
        routing::get,
        Router,
    };
    use tokio::net::TcpListener;
    use tokio::task::JoinHandle;

    #[derive(Clone)]
    struct WsState {
        client_tx: Arc<Mutex<mpsc::UnboundedSender<Message>>>,
        server_rx: Arc<Mutex<mpsc::UnboundedReceiver<Message>>>,
    }

    pub struct MockWsServer {
        pub terminal_to_client_tx: mpsc::UnboundedSender<Message>,
        pub control_to_client_tx: mpsc::UnboundedSender<Message>,
        pub client_to_terminal_rx: Arc<Mutex<mpsc::UnboundedReceiver<Message>>>,
        pub client_to_control_rx: Arc<Mutex<mpsc::UnboundedReceiver<Message>>>,
    }

    impl MockWsServer {
        pub async fn start() -> (u16, Self, JoinHandle<()>) {
            let (terminal_to_client_tx, terminal_to_client_rx) = mpsc::unbounded_channel();
            let (client_to_terminal_tx, client_to_terminal_rx) = mpsc::unbounded_channel();
            let (control_to_client_tx, control_to_client_rx) = mpsc::unbounded_channel();
            let (client_to_control_tx, client_to_control_rx) = mpsc::unbounded_channel();

            let terminal_state = WsState {
                client_tx: Arc::new(Mutex::new(client_to_terminal_tx)),
                server_rx: Arc::new(Mutex::new(terminal_to_client_rx)),
            };

            let control_state = WsState {
                client_tx: Arc::new(Mutex::new(client_to_control_tx)),
                server_rx: Arc::new(Mutex::new(control_to_client_rx)),
            };

            let app = Router::new()
                .route(
                    "/ws/terminal",
                    get(terminal_handler).with_state(terminal_state.clone()),
                )
                .route(
                    "/ws/control",
                    get(control_handler).with_state(control_state.clone()),
                );

            let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
            let port = listener.local_addr().unwrap().port();

            let server_handle = tokio::spawn(async move {
                axum::serve(listener, app).await.unwrap();
            });

            // Wait for server to start
            tokio::time::sleep(Duration::from_millis(100)).await;

            let server = MockWsServer {
                terminal_to_client_tx,
                control_to_client_tx,
                client_to_terminal_rx: Arc::new(Mutex::new(client_to_terminal_rx)),
                client_to_control_rx: Arc::new(Mutex::new(client_to_control_rx)),
            };

            (port, server, server_handle)
        }
    }

    async fn terminal_handler(
        ws: WebSocketUpgrade,
        State(state): State<WsState>,
    ) -> impl axum::response::IntoResponse {
        ws.on_upgrade(move |socket| handle_websocket(socket, state))
    }

    async fn control_handler(
        ws: WebSocketUpgrade,
        State(state): State<WsState>,
    ) -> impl axum::response::IntoResponse {
        ws.on_upgrade(move |socket| handle_websocket(socket, state))
    }

    async fn handle_websocket(socket: WebSocket, state: WsState) {
        let (mut ws_tx, mut ws_rx) = socket.split();
        let client_tx = state.client_tx.clone();

        let recv_task = tokio::spawn(async move {
            while let Some(Ok(axum_msg)) = ws_rx.next().await {
                // Convert axum::extract::ws::Message to tokio_tungstenite::tungstenite::Message
                let tungstenite_msg = match axum_msg {
                    axum::extract::ws::Message::Text(text) => Message::Text(text.to_string()),
                    axum::extract::ws::Message::Binary(data) => Message::Binary(data.to_vec()),
                    axum::extract::ws::Message::Ping(data) => Message::Ping(data.to_vec()),
                    axum::extract::ws::Message::Pong(data) => Message::Pong(data.to_vec()),
                    axum::extract::ws::Message::Close(frame) => {
                        if let Some(f) = frame {
                            Message::Close(Some(tokio_tungstenite::tungstenite::protocol::CloseFrame {
                                code: tokio_tungstenite::tungstenite::protocol::frame::coding::CloseCode::from(f.code),
                                reason: std::borrow::Cow::Owned(f.reason.to_string()),
                            }))
                        } else {
                            Message::Close(None)
                        }
                    },
                };
                let _ = client_tx.lock().unwrap().send(tungstenite_msg);
            }
        });

        loop {
            let msg = state.server_rx.lock().unwrap().try_recv();
            match msg {
                Ok(tungstenite_msg) => {
                    // Convert tokio_tungstenite::tungstenite::Message to axum::extract::ws::Message
                    let axum_msg = match tungstenite_msg {
                        Message::Text(text) => axum::extract::ws::Message::Text(text.into()),
                        Message::Binary(data) => axum::extract::ws::Message::Binary(data.into()),
                        Message::Ping(data) => axum::extract::ws::Message::Ping(data.into()),
                        Message::Pong(data) => axum::extract::ws::Message::Pong(data.into()),
                        Message::Close(frame) => {
                            if let Some(f) = frame {
                                axum::extract::ws::Message::Close(Some(
                                    axum::extract::ws::CloseFrame {
                                        code: f.code.into(),
                                        reason: f.reason.to_string().into(),
                                    },
                                ))
                            } else {
                                axum::extract::ws::Message::Close(None)
                            }
                        },
                        Message::Frame(_) => continue, // Skip raw frames
                    };
                    if ws_tx.send(axum_msg).await.is_err() {
                        break;
                    }
                },
                Err(_) => {
                    tokio::time::sleep(Duration::from_millis(10)).await;
                },
            }
        }

        recv_task.abort();
    }
}

#[tokio::test]
#[serial]
async fn test_stdin_forwarded_to_terminal_websocket() {
    // Setup mock WebSocket server
    let (port, server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    // Create WebSocket connections
    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-stdin".to_string(),
    };

    // Create mock OS API with controllable stdin
    let (stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (_signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = Box::new(TestClientOsApi::new(stdin_rx, signal_rx));

    // Spawn the async loop
    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Send stdin data
    let test_data = b"hello from stdin\n".to_vec();
    stdin_tx.send(test_data.clone()).unwrap();

    // Verify terminal WebSocket received the data
    tokio::time::sleep(Duration::from_millis(200)).await;
    let received = tokio::time::timeout(
        Duration::from_secs(1),
        server.client_to_terminal_rx.lock().unwrap().recv(),
    )
    .await
    .expect("Timeout")
    .expect("No message");

    match received {
        Message::Binary(data) => assert_eq!(data, test_data),
        _ => panic!("Expected Binary message, got: {:?}", received),
    }

    // Cleanup: send EOF via stdin
    drop(stdin_tx);
    let _ = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit")
        .unwrap();
}

#[tokio::test]
#[serial]
async fn test_terminal_output_written_to_stdout() {
    let (port, server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-stdout".to_string(),
    };

    let (_stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (_signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = TestClientOsApi::new(stdin_rx, signal_rx);
    let stdout_buffer = os_input.stdout_buffer.clone();
    let os_input = Box::new(os_input);

    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Send terminal output from server
    let test_output = "Hello from terminal";
    server
        .terminal_to_client_tx
        .send(Message::Text(test_output.to_string()))
        .unwrap();

    tokio::time::sleep(Duration::from_millis(200)).await;

    // Verify stdout received the output
    let stdout = stdout_buffer.lock().unwrap().clone();
    let stdout_str = String::from_utf8_lossy(&stdout);
    assert!(
        stdout_str.contains(test_output),
        "Expected stdout to contain '{}', got: '{}'",
        test_output,
        stdout_str
    );

    // Cleanup
    server
        .terminal_to_client_tx
        .send(Message::Close(None))
        .unwrap();
    let _ = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit")
        .unwrap();
}

#[tokio::test]
#[serial]
async fn test_resize_signal_sends_control_message() {
    let (port, server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-resize".to_string(),
    };

    let (_stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = Box::new(TestClientOsApi::new(stdin_rx, signal_rx));

    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Wait for initial resize message to be sent on startup
    tokio::time::sleep(Duration::from_millis(200)).await;

    // Consume the initial resize message
    let _ = tokio::time::timeout(
        Duration::from_millis(500),
        server.client_to_control_rx.lock().unwrap().recv(),
    )
    .await;

    // Send resize signal
    signal_tx.send(SignalEvent::Resize).unwrap();

    tokio::time::sleep(Duration::from_millis(200)).await;

    // Verify control WebSocket received resize message
    let received = tokio::time::timeout(
        Duration::from_secs(1),
        server.client_to_control_rx.lock().unwrap().recv(),
    )
    .await
    .expect("Timeout")
    .expect("No message");

    match received {
        Message::Text(text) => {
            let parsed: WebClientToWebServerControlMessage =
                serde_json::from_str(&text).expect("Failed to parse");
            assert!(
                matches!(
                    parsed.payload,
                    WebClientToWebServerControlMessagePayload::TerminalResize(_)
                ),
                "Expected TerminalResize, got: {:?}",
                parsed.payload
            );
        },
        _ => panic!("Expected Text message, got: {:?}", received),
    }

    // Cleanup
    signal_tx.send(SignalEvent::Quit).unwrap();
    let _ = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit")
        .unwrap();
}

#[tokio::test]
#[serial]
async fn test_quit_signal_exits_loop() {
    let (port, _server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-quit".to_string(),
    };

    let (_stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = Box::new(TestClientOsApi::new(stdin_rx, signal_rx));

    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Send quit signal
    signal_tx.send(SignalEvent::Quit).unwrap();

    // Verify loop exits cleanly
    let result = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit within timeout")
        .expect("Loop panicked");

    assert!(result.is_ok(), "Expected Ok result, got: {:?}", result);
}

#[tokio::test]
#[serial]
async fn test_websocket_close_exits_loop() {
    let (port, server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-close".to_string(),
    };

    let (_stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (_signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = Box::new(TestClientOsApi::new(stdin_rx, signal_rx));

    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Send close message
    server
        .terminal_to_client_tx
        .send(Message::Close(None))
        .unwrap();

    // Verify loop exits cleanly
    let result = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit within timeout")
        .expect("Loop panicked");

    assert!(result.is_ok(), "Expected Ok result, got: {:?}", result);
}

#[tokio::test]
#[serial]
async fn test_control_message_handling() {
    let (port, server, _server_handle) = mock_ws_server::MockWsServer::start().await;

    let terminal_url = format!("ws://127.0.0.1:{}/ws/terminal", port);
    let control_url = format!("ws://127.0.0.1:{}/ws/control", port);

    let terminal_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (terminal_ws, _) = tokio_tungstenite::client_async_with_config(
        &terminal_url,
        MaybeTls::Plain(terminal_tcp),
        None,
    )
    .await
    .unwrap();
    let control_tcp = TcpStream::connect(format!("127.0.0.1:{}", port))
        .await
        .unwrap();
    let (control_ws, _) = tokio_tungstenite::client_async_with_config(
        &control_url,
        MaybeTls::Plain(control_tcp),
        None,
    )
    .await
    .unwrap();

    let connections = WebSocketConnections {
        terminal_ws,
        control_ws,
        web_client_id: "test-control".to_string(),
    };

    let (_stdin_tx, stdin_rx) = mpsc::unbounded_channel();
    let (_signal_tx, signal_rx) = mpsc::unbounded_channel();

    let os_input = TestClientOsApi::new(stdin_rx, signal_rx);
    let terminal_size = os_input.terminal_size;
    let os_input = Box::new(os_input);

    let loop_handle =
        tokio::spawn(async move { run_remote_client_terminal_loop(os_input, connections).await });

    // Wait for initial resize message to be sent on startup
    tokio::time::sleep(Duration::from_millis(200)).await;

    // Consume the initial resize message
    let _ = tokio::time::timeout(
        Duration::from_millis(500),
        server.client_to_control_rx.lock().unwrap().recv(),
    )
    .await;

    // Send QueryTerminalSize control message
    let query_msg = WebServerToWebClientControlMessage::QueryTerminalSize;
    server
        .control_to_client_tx
        .send(Message::Text(serde_json::to_string(&query_msg).unwrap()))
        .unwrap();

    tokio::time::sleep(Duration::from_millis(200)).await;

    // Verify we receive a resize response
    let received = tokio::time::timeout(
        Duration::from_secs(1),
        server.client_to_control_rx.lock().unwrap().recv(),
    )
    .await
    .expect("Timeout")
    .expect("No message");

    match received {
        Message::Text(text) => {
            let parsed: WebClientToWebServerControlMessage =
                serde_json::from_str(&text).expect("Failed to parse");
            let WebClientToWebServerControlMessagePayload::TerminalResize(size) = parsed.payload
            else {
                panic!("Expected TerminalResize, got: {:?}", parsed.payload);
            };
            assert_eq!(size, terminal_size);
        },
        _ => panic!("Expected Text message, got: {:?}", received),
    }

    // Test Log message (should not crash)
    let log_msg = WebServerToWebClientControlMessage::Log {
        lines: vec!["Test log".to_string()],
    };
    server
        .control_to_client_tx
        .send(Message::Text(serde_json::to_string(&log_msg).unwrap()))
        .unwrap();

    tokio::time::sleep(Duration::from_millis(100)).await;

    // Cleanup
    server
        .terminal_to_client_tx
        .send(Message::Close(None))
        .unwrap();
    let _ = tokio::time::timeout(Duration::from_secs(2), loop_handle)
        .await
        .expect("Loop didn't exit")
        .unwrap();
}