zebflow 0.6.0

Reactive web automation platform — pipelines, templates, and real-time collaboration in a single binary.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
//! HTTP request node for pulling external/internal data into pipeline flow.

use std::collections::BTreeMap;
use std::sync::Arc;
use std::time::Duration;

use async_trait::async_trait;
use base64::Engine as _;
use serde::{Deserialize, Serialize};
use serde_json::{Value, json};

use crate::language::LanguageEngine;
use crate::pipeline::{
    NodeDefinition, PipelineError,
    nodes::{NodeExecutionInput, NodeExecutionOutput, NodeHandler},
};
use crate::platform::services::CredentialService;

use super::util::{eval_deno_expr, metadata_scope, resolve_path_cloned};
use crate::pipeline::model::{DslFlag, DslFlagKind, LayoutItem};

pub const NODE_KIND: &str = "n.http.request";
pub const INPUT_PIN_IN: &str = "in";
pub const OUTPUT_PIN_OUT: &str = "out";

fn default_response_type() -> String {
    "json".to_string()
}
fn default_body_type() -> String {
    "json".to_string()
}

/// Unified node-definition metadata for `n.http.request`.
pub fn definition() -> NodeDefinition {
    NodeDefinition {
        kind: NODE_KIND.to_string(),
        title: "HTTP Request".to_string(),
        description: "Perform HTTP call with support for JSON, text, and binary (bytes) responses. \
            Supports JSON, raw text, and multipart form-data request bodies including __zf_bytes file parts. \
            Returns normalized { request, response } envelope."
            .to_string(),
        input_schema: serde_json::json!({
            "type":"object",
            "description":"Input context used for optional body binding."
        }),
        output_schema: serde_json::json!({
            "type":"object",
            "properties":{
                "request":{"type":"object"},
                "response":{"type":"object"}
            }
        }),
        input_pins: vec![INPUT_PIN_IN.to_string()],
        output_pins: vec![OUTPUT_PIN_OUT.to_string()],
        script_available: true,
        script_bridge: Some(crate::pipeline::NodeScriptBridge {
            name: "n.http.request".to_string(),
            enabled: false,
        }),
        config_schema: Default::default(),
        dsl_flags: vec![
            DslFlag { flag: "--credential".to_string(), config_key: "credential_id".to_string(), description: "Optional credential for HTTP auth. secure_request: template-driven. oauth2: auto-refresh Bearer token.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--bind".to_string(), config_key: "request_bindings".to_string(), description: "Binding expression for one secure_request variable. Repeatable: --bind USER_ID=input.player_id".to_string(), kind: DslFlagKind::KeyValuePairs, required: false },
            DslFlag { flag: "--url".to_string(), config_key: "url".to_string(), description: "Target URL for the HTTP request.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--url-expr".to_string(), config_key: "url_expr".to_string(), description: "JS expression returning the target URL. Evaluated against input payload at runtime.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--method".to_string(), config_key: "method".to_string(), description: "HTTP method: GET (default), POST, PUT, PATCH, DELETE.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--method-expr".to_string(), config_key: "method_expr".to_string(), description: "JS expression returning the HTTP method.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--body-path".to_string(), config_key: "body_path".to_string(), description: "Dot-notation path into input payload whose value is sent as the request body.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--body-expr".to_string(), config_key: "body_expr".to_string(), description: "JS expression returning the request body value. Evaluated against input payload.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--header".to_string(), config_key: "headers".to_string(), description: "Static request header. Repeat for each header. Format: Header-Name=value. e.g. --header Content-Type=application/json".to_string(), kind: DslFlagKind::KeyValuePairs, required: false },
            DslFlag { flag: "--headers-expr".to_string(), config_key: "headers_expr".to_string(), description: "JS expression returning an object of request headers. Evaluated against input payload.".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--timeout-ms".to_string(), config_key: "timeout_ms".to_string(), description: "Request timeout in milliseconds (default 10000, max 120000).".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--response-type".to_string(), config_key: "response_type".to_string(), description: "How to read the response: json (default, parses body as JSON), text (raw string), bytes (base64-encoded binary with __zf_bytes convention).".to_string(), kind: DslFlagKind::Scalar, required: false },
            DslFlag { flag: "--body-type".to_string(), config_key: "body_type".to_string(), description: "How to send the request body: json (default), text (raw string), form-data (multipart with __zf_bytes support).".to_string(), kind: DslFlagKind::Scalar, required: false },
        ],
        fields: {
            use crate::pipeline::model::{NodeFieldDef, NodeFieldType, SelectOptionDef};
            vec![
                NodeFieldDef { name: "title".to_string(), label: "Title".to_string(), field_type: NodeFieldType::Text, help: Some("Override display title for this node.".to_string()), ..Default::default() },
                NodeFieldDef { name: "credential_id".to_string(), label: "Request Profile".to_string(), field_type: NodeFieldType::Select, data_source: Some(crate::pipeline::model::NodeFieldDataSource::CredentialsHttpAuth), help: Some("Credential for HTTP authentication. secure_request: template-driven request. oauth2: Bearer token auto-refresh.".to_string()), ..Default::default() },
                NodeFieldDef { name: "request_bindings".to_string(), label: "Profile Bindings".to_string(), field_type: NodeFieldType::SecureRequestBindings, help: Some("JS expressions for the variables declared by the selected secure_request profile. Example: input.player_id or ctx.nodes.n3.unit.code".to_string()), span: Some("full".to_string()), ..Default::default() },
                NodeFieldDef { name: "url".to_string(), label: "URL".to_string(), field_type: NodeFieldType::Text, help: Some("Fallback URL when url_expr is empty.".to_string()), default_value: Some(serde_json::json!("https://example.com")), ..Default::default() },
                NodeFieldDef { name: "method".to_string(), label: "Method".to_string(), field_type: NodeFieldType::Select, options: vec!["GET","POST","PUT","PATCH","DELETE"].iter().map(|m| SelectOptionDef { value: m.to_string(), label: m.to_string() }).collect(), help: Some("Fallback HTTP method when method_expr is empty.".to_string()), ..Default::default() },
                NodeFieldDef { name: "timeout_ms".to_string(), label: "Timeout (ms)".to_string(), field_type: NodeFieldType::Text, help: Some("Request timeout in milliseconds.".to_string()), ..Default::default() },
                NodeFieldDef {
                    name: "response_type".to_string(),
                    label: "Response Type".to_string(),
                    field_type: NodeFieldType::Select,
                    options: vec![
                        SelectOptionDef { value: "json".to_string(), label: "JSON (parse body)".to_string() },
                        SelectOptionDef { value: "text".to_string(), label: "Text (raw string)".to_string() },
                        SelectOptionDef { value: "bytes".to_string(), label: "Bytes (base64 binary)".to_string() },
                    ],
                    help: Some("How to read the response body. 'bytes' returns __zf_bytes convention for binary pipelines.".to_string()),
                    default_value: Some(json!("json")),
                    ..Default::default()
                },
                NodeFieldDef {
                    name: "body_type".to_string(),
                    label: "Body Type".to_string(),
                    field_type: NodeFieldType::Select,
                    options: vec![
                        SelectOptionDef { value: "json".to_string(), label: "JSON".to_string() },
                        SelectOptionDef { value: "text".to_string(), label: "Text (raw string)".to_string() },
                        SelectOptionDef { value: "form-data".to_string(), label: "Form Data (multipart)".to_string() },
                    ],
                    help: Some("How to send the request body. 'form-data' supports __zf_bytes objects as file parts.".to_string()),
                    default_value: Some(json!("json")),
                    ..Default::default()
                },
                NodeFieldDef { name: "headers".to_string(), label: "Static Headers".to_string(), field_type: NodeFieldType::KeyValuePairs, help: Some("Static request headers. Overridden by headers_expr if set.".to_string()), ..Default::default() },
                NodeFieldDef { name: "url_expr".to_string(), label: "URL Expr".to_string(), field_type: NodeFieldType::Textarea, rows: Some(3), help: Some("Optional JS expression returning string URL.".to_string()), ..Default::default() },
                NodeFieldDef { name: "method_expr".to_string(), label: "Method Expr".to_string(), field_type: NodeFieldType::Textarea, rows: Some(3), help: Some("Optional JS expression returning string method.".to_string()), ..Default::default() },
                NodeFieldDef { name: "body_path".to_string(), label: "Body Path".to_string(), field_type: NodeFieldType::Text, help: Some("Payload path used as request body when body_expr is empty.".to_string()), ..Default::default() },
                NodeFieldDef { name: "headers_expr".to_string(), label: "Headers Expr".to_string(), field_type: NodeFieldType::Textarea, rows: Some(4), help: Some("JS expression returning header object. Overrides static headers.".to_string()), ..Default::default() },
                NodeFieldDef { name: "body_expr".to_string(), label: "Body Expr".to_string(), field_type: NodeFieldType::Textarea, rows: Some(4), help: Some("JS expression returning request body value.".to_string()), ..Default::default() },
            ]
        },
        layout: vec![
            LayoutItem::Row { row: vec![LayoutItem::Field("title".to_string()), LayoutItem::Field("credential_id".to_string())] },
            LayoutItem::Field("request_bindings".to_string()),
            LayoutItem::Row { row: vec![LayoutItem::Field("method".to_string()), LayoutItem::Field("timeout_ms".to_string())] },
            LayoutItem::Row { row: vec![LayoutItem::Field("response_type".to_string()), LayoutItem::Field("body_type".to_string())] },
            LayoutItem::Field("url".to_string()),
            LayoutItem::Field("headers".to_string()),
            LayoutItem::Field("body_path".to_string()),
            LayoutItem::Field("url_expr".to_string()),
            LayoutItem::Field("method_expr".to_string()),
            LayoutItem::Field("headers_expr".to_string()),
            LayoutItem::Field("body_expr".to_string()),
        ],
        ai_tool: crate::pipeline::model::NodeAiToolDefinition {
            registered: true,
            tool_name: "http_request".to_string(),
            tool_description: "Make an HTTP request. Args: url (required), method (GET/POST/etc.), body (string), headers (object), response_type (json/text/bytes), body_type (json/text/form-data).".to_string(),
            tool_input_schema: serde_json::json!({
                "type": "object",
                "properties": {
                    "url":     { "type": "string", "description": "Target URL" },
                    "method":  { "type": "string", "description": "HTTP method (default GET)" },
                    "body":    { "type": "string", "description": "Request body (optional)" },
                    "headers": { "type": "object", "description": "Additional headers (optional)" },
                    "response_type": { "type": "string", "description": "json (default), text, or bytes" },
                    "body_type": { "type": "string", "description": "json (default), text, or form-data" }
                },
                "required": ["url"]
            }),
        },
    }
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Config {
    #[serde(default)]
    pub credential_id: Option<String>,
    #[serde(default)]
    pub request_bindings: BTreeMap<String, String>,
    #[serde(default)]
    pub url: String,
    #[serde(default = "default_method")]
    pub method: String,
    #[serde(default)]
    pub headers: BTreeMap<String, String>,
    #[serde(default)]
    pub body_path: Option<String>,
    #[serde(default)]
    pub timeout_ms: Option<u64>,
    #[serde(default)]
    pub url_expr: Option<String>,
    #[serde(default)]
    pub method_expr: Option<String>,
    #[serde(default)]
    pub headers_expr: Option<String>,
    #[serde(default)]
    pub body_expr: Option<String>,
    /// How to read the response: "json" (default), "text", "bytes".
    #[serde(default = "default_response_type")]
    pub response_type: String,
    /// How to send the request body: "json" (default), "text", "form-data".
    #[serde(default = "default_body_type")]
    pub body_type: String,
}

impl Default for Config {
    fn default() -> Self {
        Self {
            credential_id: None,
            request_bindings: BTreeMap::new(),
            url: String::new(),
            method: default_method(),
            headers: BTreeMap::new(),
            body_path: None,
            timeout_ms: None,
            url_expr: None,
            method_expr: None,
            headers_expr: None,
            body_expr: None,
            response_type: default_response_type(),
            body_type: default_body_type(),
        }
    }
}

fn default_method() -> String {
    "GET".to_string()
}

#[derive(Debug, Clone, Deserialize, Default)]
struct SecureRequestVariableDef {
    name: String,
    #[serde(default)]
    required: bool,
    #[serde(default)]
    default_expr: String,
}

#[derive(Debug, Clone, Deserialize, Default)]
struct SecureRequestTemplate {
    #[serde(default = "default_method")]
    method: String,
    #[serde(default)]
    url: String,
    #[serde(default)]
    headers: BTreeMap<String, String>,
    #[serde(default)]
    body: String,
}

#[derive(Debug, Clone, Deserialize, Default)]
struct SecureRequestSecret {
    #[serde(default)]
    request: SecureRequestTemplate,
    #[serde(default)]
    variables: Vec<SecureRequestVariableDef>,
    #[serde(default)]
    secrets: BTreeMap<String, String>,
}

struct PreparedRequest {
    url: String,
    visible_url: String,
    method: String,
    visible_method: String,
    headers: BTreeMap<String, String>,
    body: Option<Value>,
    redact_tokens: Vec<String>,
    credential_id: Option<String>,
}

pub struct Node {
    config: Config,
    language: Arc<dyn LanguageEngine>,
    credentials: Option<Arc<CredentialService>>,
}

impl Node {
    pub fn new(
        config: Config,
        language: Arc<dyn LanguageEngine>,
        credentials: Option<Arc<CredentialService>>,
    ) -> Result<Self, PipelineError> {
        let url = config.url.trim();
        let has_credential = !config
            .credential_id
            .as_deref()
            .map(str::trim)
            .unwrap_or_default()
            .is_empty();
        let url_expr_empty = config
            .url_expr
            .as_deref()
            .map(str::trim)
            .unwrap_or_default()
            .is_empty();
        if url.is_empty() && url_expr_empty && !has_credential {
            return Err(PipelineError::new(
                "FW_NODE_HTTP_REQUEST_CONFIG",
                "config.url or config.credential_id must not be empty",
            ));
        }
        if !url.is_empty() && !url.starts_with("http://") && !url.starts_with("https://") {
            return Err(PipelineError::new(
                "FW_NODE_HTTP_REQUEST_CONFIG",
                "config.url must start with http:// or https://",
            ));
        }
        Ok(Self {
            config,
            language,
            credentials,
        })
    }
}

#[async_trait]
impl NodeHandler for Node {
    fn kind(&self) -> &'static str {
        NODE_KIND
    }

    fn input_pins(&self) -> &'static [&'static str] {
        &[INPUT_PIN_IN]
    }

    fn output_pins(&self) -> &'static [&'static str] {
        &[OUTPUT_PIN_OUT]
    }

    async fn execute_async(
        &self,
        input: NodeExecutionInput,
    ) -> Result<NodeExecutionOutput, PipelineError> {
        if input.input_pin != INPUT_PIN_IN {
            return Err(PipelineError::new(
                "FW_NODE_HTTP_REQUEST_INPUT_PIN",
                format!("unsupported input pin '{}'", input.input_pin),
            ));
        }

        let timeout_ms = self.config.timeout_ms.unwrap_or(10_000).clamp(100, 120_000);

        let prepared = if let Some(credential_id) = self
            .config
            .credential_id
            .as_deref()
            .map(str::trim)
            .filter(|v| !v.is_empty())
        {
            let Some(credentials) = &self.credentials else {
                return Err(PipelineError::new(
                    "FW_NODE_HTTP_REQUEST_CREDENTIALS_UNAVAILABLE",
                    "credential service is not configured on this pipeline engine",
                ));
            };
            let (owner, project, _, _) = metadata_scope(&input.metadata)?;
            let credential = credentials
                .get_project_credential(owner, project, credential_id)
                .map_err(|err| {
                    PipelineError::new("FW_NODE_HTTP_REQUEST_CREDENTIAL", err.to_string())
                })?
                .ok_or_else(|| {
                    PipelineError::new(
                        "FW_NODE_HTTP_REQUEST_CREDENTIAL_MISSING",
                        format!("credential '{}' not found", credential_id),
                    )
                })?;
            match credential.kind.as_str() {
                "secure_request" => build_request_from_secure_credential(
                    credential_id,
                    self.language.as_ref(),
                    &self.config,
                    &credential.secret,
                    &input.payload,
                    &input.metadata,
                )?,
                "oauth2" => {
                    // Get a valid access token, auto-refreshing if expired.
                    let token = credentials
                        .get_valid_oauth2_token(owner, project, credential_id)
                        .await
                        .map_err(|err| {
                            PipelineError::new("FW_NODE_HTTP_REQUEST_OAUTH2", err.to_string())
                        })?;
                    // Resolve URL/method/headers/body from node config (not from credential template).
                    let url = resolve_http_string_binding(
                        self.language.as_ref(),
                        &input.payload,
                        &input.metadata,
                        self.config.url_expr.as_deref(),
                        &self.config.url,
                        "url",
                    )?;
                    if !url.starts_with("http://") && !url.starts_with("https://") {
                        return Err(PipelineError::new(
                            "FW_NODE_HTTP_REQUEST_CONFIG",
                            "resolved url must start with http:// or https://",
                        ));
                    }
                    let method = resolve_http_string_binding(
                        self.language.as_ref(),
                        &input.payload,
                        &input.metadata,
                        self.config.method_expr.as_deref(),
                        &self.config.method,
                        "method",
                    )?
                    .to_uppercase();
                    let mut headers = if let Some(expr) = self.config.headers_expr.as_deref() {
                        let value = eval_deno_expr(
                            self.language.as_ref(),
                            expr,
                            &input.payload,
                            &input.metadata,
                        )?;
                        parse_headers(value)?
                    } else {
                        self.config.headers.clone()
                    };
                    // Inject Bearer token as Authorization header.
                    headers.insert("Authorization".to_string(), format!("Bearer {token}"));
                    let body_value = if let Some(expr) = self.config.body_expr.as_deref() {
                        Some(eval_deno_expr(
                            self.language.as_ref(),
                            expr,
                            &input.payload,
                            &input.metadata,
                        )?)
                    } else {
                        resolve_path_cloned(&input.payload, self.config.body_path.as_deref())
                    };
                    PreparedRequest {
                        visible_url: url.clone(),
                        url,
                        visible_method: method.clone(),
                        method,
                        headers,
                        body: body_value,
                        redact_tokens: vec![token],
                        credential_id: Some(credential_id.to_string()),
                    }
                }
                other => {
                    return Err(PipelineError::new(
                        "FW_NODE_HTTP_REQUEST_CREDENTIAL_KIND",
                        format!(
                            "credential '{}' has kind '{}' — expected secure_request or oauth2",
                            credential.credential_id, other
                        ),
                    ));
                }
            }
        } else {
            let url = resolve_http_string_binding(
                self.language.as_ref(),
                &input.payload,
                &input.metadata,
                self.config.url_expr.as_deref(),
                &self.config.url,
                "url",
            )?;
            if !url.starts_with("http://") && !url.starts_with("https://") {
                return Err(PipelineError::new(
                    "FW_NODE_HTTP_REQUEST_CONFIG",
                    "resolved url must start with http:// or https://",
                ));
            }
            let method = resolve_http_string_binding(
                self.language.as_ref(),
                &input.payload,
                &input.metadata,
                self.config.method_expr.as_deref(),
                &self.config.method,
                "method",
            )?
            .to_uppercase();
            let headers = if let Some(expr) = self.config.headers_expr.as_deref() {
                let value = eval_deno_expr(
                    self.language.as_ref(),
                    expr,
                    &input.payload,
                    &input.metadata,
                )?;
                parse_headers(value)?
            } else {
                self.config.headers.clone()
            };
            let body_value = if let Some(expr) = self.config.body_expr.as_deref() {
                Some(eval_deno_expr(
                    self.language.as_ref(),
                    expr,
                    &input.payload,
                    &input.metadata,
                )?)
            } else {
                resolve_path_cloned(&input.payload, self.config.body_path.as_deref())
            };
            PreparedRequest {
                visible_url: url.clone(),
                url,
                visible_method: method.clone(),
                method,
                headers,
                body: body_value,
                redact_tokens: Vec::new(),
                credential_id: None,
            }
        };

        let request_visible_url = prepared.visible_url.clone();
        let request_method = prepared.visible_method.clone();
        let request_credential_id = prepared.credential_id.clone();
        crate::pipeline::security::validate_outbound_http_url(&prepared.url, NODE_KIND)?;

        // ── Build reqwest client + request ───────────────────────────────────────
        let client = reqwest::Client::builder()
            .timeout(Duration::from_millis(timeout_ms))
            .build()
            .map_err(|e| PipelineError::new("FW_NODE_HTTP_REQUEST_CLIENT", e.to_string()))?;

        let method_parsed = reqwest::Method::from_bytes(prepared.method.as_bytes())
            .map_err(|e| PipelineError::new("FW_NODE_HTTP_REQUEST_METHOD", e.to_string()))?;

        let mut req = client.request(method_parsed.clone(), &prepared.url);
        for (key, value) in &prepared.headers {
            req = req.header(key.as_str(), value.as_str());
        }

        // ── Send body based on body_type ─────────────────────────────────────────
        let body_type = self.config.body_type.trim().to_lowercase();
        let has_body = !matches!(
            method_parsed.as_str(),
            "GET" | "HEAD" | "DELETE" | "OPTIONS"
        );

        if has_body {
            if let Some(body) = &prepared.body {
                match body_type.as_str() {
                    "form-data" => {
                        req = build_multipart_request(req, body)?;
                    }
                    "text" => {
                        let body_str = match body {
                            Value::String(s) => s.clone(),
                            other => other.to_string(),
                        };
                        // Only set content-type if not already in headers
                        if !prepared
                            .headers
                            .keys()
                            .any(|k| k.to_lowercase() == "content-type")
                        {
                            req = req.header("content-type", "text/plain");
                        }
                        req = req.body(body_str);
                    }
                    _ => {
                        // "json" (default)
                        let body_str = match body {
                            Value::String(s) => s.clone(),
                            other => other.to_string(),
                        };
                        if !prepared
                            .headers
                            .keys()
                            .any(|k| k.to_lowercase() == "content-type")
                        {
                            req = req.header("content-type", "application/json");
                        }
                        req = req.body(body_str);
                    }
                }
            }
        }

        // ── Execute request ──────────────────────────────────────────────────────
        let transport_visible_url = prepared.visible_url.clone();
        let transport_raw_url = prepared.url.clone();

        let resp = req.send().await.map_err(|err| {
            let mut message = err.to_string();
            if transport_raw_url != transport_visible_url && !transport_visible_url.is_empty() {
                message = message.replace(&transport_raw_url, &transport_visible_url);
            }
            PipelineError::new("FW_NODE_HTTP_REQUEST_TRANSPORT", message)
        })?;

        let status = resp.status().as_u16();
        let content_type = resp
            .headers()
            .get("content-type")
            .and_then(|v| v.to_str().ok())
            .unwrap_or("application/octet-stream")
            .to_string();

        // ── Read response based on response_type ─────────────────────────────────
        let response_type = self.config.response_type.trim().to_lowercase();
        let body: Value = match response_type.as_str() {
            "bytes" => {
                let bytes = resp.bytes().await.map_err(|err| {
                    PipelineError::new("FW_NODE_HTTP_REQUEST_READ_BODY", err.to_string())
                })?;
                let encoded = base64::engine::general_purpose::STANDARD.encode(&bytes);
                json!({
                    "__zf_bytes": encoded,
                    "__zf_mime": content_type,
                    "__zf_size": bytes.len()
                })
            }
            "text" => {
                let text = resp.text().await.map_err(|err| {
                    PipelineError::new("FW_NODE_HTTP_REQUEST_READ_BODY", err.to_string())
                })?;
                Value::String(text)
            }
            _ => {
                // "json" (default): try parse, fall back to string
                let text = resp.text().await.map_err(|err| {
                    PipelineError::new("FW_NODE_HTTP_REQUEST_READ_BODY", err.to_string())
                })?;
                serde_json::from_str::<Value>(&text).unwrap_or(Value::String(text))
            }
        };

        // ── Build output ─────────────────────────────────────────────────────────
        let request_obj = if let Some(credential_id) = request_credential_id {
            json!({
                "credential_id": credential_id,
                "secured": true,
                "url": request_visible_url,
                "method": request_method,
                "timeout_ms": timeout_ms
            })
        } else {
            json!({
                "url": request_visible_url,
                "method": request_method,
                "timeout_ms": timeout_ms
            })
        };
        let response_obj = json!({
            "status": status,
            "ok": (200..400).contains(&status),
            "content_type": content_type,
            "body": body
        });
        let mut payload = json!({ "request": request_obj, "response": response_obj });
        if !prepared.redact_tokens.is_empty() {
            if let Value::Object(map) = &mut payload {
                map.insert(
                    "__zf_private_redact".to_string(),
                    Value::Array(
                        prepared
                            .redact_tokens
                            .iter()
                            .map(|item| Value::String(item.clone()))
                            .collect(),
                    ),
                );
                map.insert(
                    "__zf_private_redact_except_paths".to_string(),
                    Value::Array(vec![Value::String("response.body".to_string())]),
                );
            }
        }
        Ok(NodeExecutionOutput {
            output_pins: vec![OUTPUT_PIN_OUT.to_string()],
            payload,
            trace: vec![format!("node_kind={NODE_KIND}")],
        })
    }
}

/// Build a multipart/form-data request from a JSON value.
/// - Scalar fields become text parts.
/// - Objects with `__zf_bytes` become file parts (base64-decoded).
fn build_multipart_request(
    req: reqwest::RequestBuilder,
    body: &Value,
) -> Result<reqwest::RequestBuilder, PipelineError> {
    let map = match body {
        Value::Object(m) => m,
        _ => {
            return Err(PipelineError::new(
                "FW_NODE_HTTP_REQUEST_BODY",
                "form-data body_type requires an object value (from body_path or body_expr)",
            ));
        }
    };

    let mut form = reqwest::multipart::Form::new();
    for (key, value) in map {
        match value {
            Value::Object(obj) if obj.contains_key("__zf_bytes") => {
                let b64 = obj
                    .get("__zf_bytes")
                    .and_then(|v| v.as_str())
                    .unwrap_or_default();
                let mime = obj
                    .get("__zf_mime")
                    .and_then(|v| v.as_str())
                    .unwrap_or("application/octet-stream");
                let bytes = base64::engine::general_purpose::STANDARD
                    .decode(b64)
                    .map_err(|e| {
                        PipelineError::new(
                            "FW_NODE_HTTP_REQUEST_BODY",
                            format!("form-data: base64 decode error for field '{key}': {e}"),
                        )
                    })?;
                let filename = derive_filename_from_mime(mime);
                let part = reqwest::multipart::Part::bytes(bytes)
                    .file_name(filename)
                    .mime_str(mime)
                    .map_err(|e| {
                        PipelineError::new(
                            "FW_NODE_HTTP_REQUEST_BODY",
                            format!("form-data: invalid mime for field '{key}': {e}"),
                        )
                    })?;
                form = form.part(key.clone(), part);
            }
            Value::String(s) => {
                form = form.text(key.clone(), s.clone());
            }
            Value::Number(n) => {
                form = form.text(key.clone(), n.to_string());
            }
            Value::Bool(b) => {
                form = form.text(key.clone(), b.to_string());
            }
            Value::Null => {}
            other => {
                form = form.text(key.clone(), other.to_string());
            }
        }
    }
    Ok(req.multipart(form))
}

fn derive_filename_from_mime(mime: &str) -> String {
    let base = mime.split(';').next().unwrap_or("").trim();
    let ext = match base {
        "audio/mpeg" => "mp3",
        "audio/wav" | "audio/x-wav" => "wav",
        "audio/ogg" => "ogg",
        "audio/mp4" | "audio/m4a" => "m4a",
        "image/jpeg" => "jpg",
        "image/png" => "png",
        "image/webp" => "webp",
        "image/gif" => "gif",
        "application/pdf" => "pdf",
        "video/mp4" => "mp4",
        "video/webm" => "webm",
        "application/octet-stream" => "bin",
        _ => "bin",
    };
    format!("download.{ext}")
}

fn resolve_http_string_binding(
    language: &dyn LanguageEngine,
    input: &Value,
    metadata: &Value,
    expr: Option<&str>,
    fallback: &str,
    field: &str,
) -> Result<String, PipelineError> {
    if let Some(expr) = expr {
        let value = eval_deno_expr(language, expr, input, metadata)?;
        return value.as_str().map(ToString::to_string).ok_or_else(|| {
            PipelineError::new(
                "FW_NODE_HTTP_REQUEST_BINDING",
                format!("binding expression for '{field}' must return string"),
            )
        });
    }
    let out = fallback.trim();
    if out.is_empty() {
        return Err(PipelineError::new(
            "FW_NODE_HTTP_REQUEST_BINDING",
            format!("resolved '{field}' must not be empty"),
        ));
    }
    Ok(out.to_string())
}

fn build_request_from_secure_credential(
    credential_id: &str,
    language: &dyn LanguageEngine,
    config: &Config,
    credential_secret: &Value,
    input: &Value,
    metadata: &Value,
) -> Result<PreparedRequest, PipelineError> {
    let secret: SecureRequestSecret =
        serde_json::from_value(credential_secret.clone()).map_err(|err| {
            PipelineError::new(
                "FW_NODE_HTTP_REQUEST_SECURE_REQUEST",
                format!("invalid secure_request secret: {err}"),
            )
        })?;

    if secret.request.url.trim().is_empty() {
        return Err(PipelineError::new(
            "FW_NODE_HTTP_REQUEST_SECURE_REQUEST",
            "secure_request credential requires secret.request.url",
        ));
    }

    let bindings = resolve_secure_request_bindings(language, config, &secret, input, metadata)?;
    let mut tokens = secret.secrets.clone();
    for (key, value) in bindings {
        tokens.insert(key, value);
    }
    let redact_tokens = tokens
        .values()
        .filter_map(|item| {
            let trimmed = item.trim();
            if trimmed.is_empty() {
                None
            } else {
                Some(trimmed.to_string())
            }
        })
        .collect::<Vec<_>>();

    let url = render_secure_request_template(&secret.request.url, &tokens);
    if !url.starts_with("http://") && !url.starts_with("https://") {
        return Err(PipelineError::new(
            "FW_NODE_HTTP_REQUEST_SECURE_REQUEST",
            "resolved secure_request url must start with http:// or https://",
        ));
    }

    let method = render_secure_request_template(&secret.request.method, &tokens).to_uppercase();
    let headers = secret
        .request
        .headers
        .iter()
        .map(|(key, value)| (key.clone(), render_secure_request_template(value, &tokens)))
        .collect::<BTreeMap<_, _>>();
    let body = if secret.request.body.trim().is_empty() {
        None
    } else {
        Some(Value::String(render_secure_request_template(
            &secret.request.body,
            &tokens,
        )))
    };
    Ok(PreparedRequest {
        visible_url: "••••••".to_string(),
        url,
        method,
        visible_method: "••••••".to_string(),
        headers,
        body,
        redact_tokens,
        credential_id: Some(credential_id.to_string()),
    })
}

fn resolve_secure_request_bindings(
    language: &dyn LanguageEngine,
    config: &Config,
    credential: &SecureRequestSecret,
    input: &Value,
    metadata: &Value,
) -> Result<BTreeMap<String, String>, PipelineError> {
    let mut out = BTreeMap::new();
    for item in &credential.variables {
        let expr = config
            .request_bindings
            .get(&item.name)
            .map(|value| value.trim())
            .filter(|value| !value.is_empty())
            .map(ToString::to_string)
            .or_else(|| {
                let fallback = item.default_expr.trim();
                if fallback.is_empty() {
                    None
                } else {
                    Some(fallback.to_string())
                }
            });
        let Some(expr) = expr else {
            if item.required {
                return Err(PipelineError::new(
                    "FW_NODE_HTTP_REQUEST_BINDING",
                    format!("missing required secure_request binding '{}'", item.name),
                ));
            }
            continue;
        };
        out.insert(
            item.name.clone(),
            eval_binding_to_string(language, &expr, input, metadata)?,
        );
    }
    for (key, expr) in &config.request_bindings {
        if out.contains_key(key) {
            continue;
        }
        let expr = expr.trim();
        if expr.is_empty() {
            continue;
        }
        out.insert(
            key.clone(),
            eval_binding_to_string(language, expr, input, metadata)?,
        );
    }
    Ok(out)
}

fn eval_binding_to_string(
    language: &dyn LanguageEngine,
    expr: &str,
    input: &Value,
    metadata: &Value,
) -> Result<String, PipelineError> {
    let value = eval_deno_expr(language, expr, input, metadata)?;
    match value {
        Value::Null => Ok(String::new()),
        Value::String(value) => Ok(value),
        Value::Bool(value) => Ok(value.to_string()),
        Value::Number(value) => Ok(value.to_string()),
        other => Ok(other.to_string()),
    }
}

fn render_secure_request_template(template: &str, tokens: &BTreeMap<String, String>) -> String {
    let mut out = template.to_string();
    for (key, value) in tokens {
        let placeholder = format!("<{key}>");
        out = out.replace(&placeholder, value);
    }
    out
}

fn parse_headers(value: Value) -> Result<BTreeMap<String, String>, PipelineError> {
    let mut out = BTreeMap::new();
    let Value::Object(map) = value else {
        return Err(PipelineError::new(
            "FW_NODE_HTTP_REQUEST_BINDING",
            "headers_expr must return object",
        ));
    };
    for (k, v) in map {
        let Some(s) = v.as_str() else {
            return Err(PipelineError::new(
                "FW_NODE_HTTP_REQUEST_BINDING",
                "headers_expr values must be strings",
            ));
        };
        out.insert(k, s.to_string());
    }
    Ok(out)
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;
    use std::time::Duration;

    use axum::{Json, Router, routing::get};
    use reqwest::StatusCode;
    use serde_json::{Value, json};
    use tokio::net::TcpListener;
    use tokio::time::timeout;

    use crate::language::NoopLanguageEngine;
    use crate::pipeline::nodes::{NodeExecutionInput, NodeHandler};

    use super::{Config, INPUT_PIN_IN, Node, build_request_from_secure_credential};

    #[tokio::test(flavor = "current_thread")]
    async fn self_call_to_private_network_is_blocked_from_same_server_request_handler() {
        let listener = TcpListener::bind("127.0.0.1:0")
            .await
            .expect("bind test server");
        let addr = listener.local_addr().expect("resolve test server addr");
        let echo_url = format!("http://{addr}/echo");

        let app = Router::new()
            .route("/echo", get(|| async { Json(json!({ "ok": true })) }))
            .route(
                "/self",
                get({
                    let echo_url = echo_url.clone();
                    move || {
                        let echo_url = echo_url.clone();
                        async move {
                            let node = Node::new(
                                Config {
                                    url: echo_url,
                                    method: "GET".to_string(),
                                    timeout_ms: Some(1_000),
                                    ..Default::default()
                                },
                                Arc::new(NoopLanguageEngine),
                                None,
                            )
                            .expect("build http.request node");

                            let err = node
                                .execute_async(NodeExecutionInput {
                                    node_id: "n0".to_string(),
                                    input_pin: INPUT_PIN_IN.to_string(),
                                    payload: json!({}),
                                    metadata: json!({}),
                                    step_tx: None,
                                })
                                .await
                                .expect_err("self-call should be blocked");

                            Json(json!({ "code": err.code, "message": err.message }))
                        }
                    }
                }),
            );

        let server = tokio::spawn(async move {
            axum::serve(listener, app).await.expect("serve test app");
        });

        let client = reqwest::Client::builder()
            .timeout(Duration::from_secs(2))
            .build()
            .expect("build client");
        let response = timeout(
            Duration::from_secs(2),
            client.get(format!("http://{addr}/self")).send(),
        )
        .await
        .expect("outer timeout waiting for self handler")
        .expect("send request to self handler");

        assert_eq!(response.status(), StatusCode::OK);
        let payload: Value = response.json().await.expect("decode response payload");
        assert_eq!(payload["code"], "FW_EGRESS_DENIED");

        server.abort();
    }

    #[test]
    fn secure_request_masks_credential_owned_request_fields() {
        let prepared = build_request_from_secure_credential(
            "salam-login-request",
            &NoopLanguageEngine,
            &Config::default(),
            &json!({
                "request": {
                    "method": "POST",
                    "url": "https://api.uinsgd.ac.id/salam/v1/index.php/auth/login",
                    "headers": {
                        "Content-Type": "application/x-www-form-urlencoded"
                    },
                    "body": "username=<USERNAME>&password=<PASSWORD>"
                },
                "variables": [],
                "secrets": {}
            }),
            &json!({}),
            &json!({}),
        )
        .expect("build prepared request");

        assert_eq!(prepared.visible_url, "••••••");
        assert_eq!(prepared.visible_method, "••••••");
        assert_eq!(
            prepared.credential_id.as_deref(),
            Some("salam-login-request")
        );
        assert_eq!(
            prepared.url,
            "https://api.uinsgd.ac.id/salam/v1/index.php/auth/login"
        );
        assert_eq!(prepared.method, "POST");
    }
}