ym2149 0.9.1

Cycle-accurate YM2149 PSG emulator
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
//! YM2149 PSG emulation
//!
//! Cycle accurate YM2149 emulation operating at the internal clock rate of
//! master_clock / 8 (250kHz at 2MHz). This matches the real hardware timing
//! where internal operations run at 1/8 of the master clock.
//!
//! # Register Write Timing
//!
//! The YM2149 runs at 2 MHz while the 68000 runs at 8 MHz. Register writes
//! are queued with CPU cycle timestamps and applied at the correct time
//! during sample generation. This ensures accurate timing for sync-buzzer
//! and other cycle-sensitive effects.

use std::collections::VecDeque;

use crate::dc_filter::DcFilter;
use crate::generators::{EnvelopeGenerator, NUM_CHANNELS, NoiseGenerator, ToneGenerator};
use crate::mixer::Mixer;
use crate::tables::REG_MASK;
use ym2149_common::{MASTER_GAIN, Ym2149Backend};

/// Default Atari ST master clock (2 MHz)
const DEFAULT_MASTER_CLOCK: u32 = 2_000_000;

/// Default audio sample rate (44.1 kHz)
const DEFAULT_SAMPLE_RATE: u32 = 44_100;

/// Number of YM2149 registers
const NUM_REGISTERS: usize = 14;

/// CPU cycles per YM2149 master clock cycle (8 MHz / 2 MHz = 4)
const CPU_CYCLES_PER_PSG_CYCLE: u64 = 4;

/// A pending register write with its CPU cycle timestamp
#[derive(Clone, Debug)]
struct PendingWrite {
    /// CPU cycle when the write occurred
    cpu_cycle: u64,
    /// Target register (0-13)
    register: u8,
    /// Value to write
    value: u8,
}

/// Simple PRNG for unpredictable power-on state
fn random_seed(seed: &mut u32) -> u16 {
    *seed = seed.wrapping_mul(214013).wrapping_add(2531011);
    ((*seed >> 16) & 0x7fff) as u16
}

/// YM2149 Programmable Sound Generator emulator
///
/// This emulator provides cycle-accurate reproduction of the Yamaha YM2149 PSG
/// as used in the Atari ST and other systems. It operates at the internal clock
/// rate (master_clock / 8) and averages output samples at the host sample rate.
///
/// # Features
///
/// - 3 tone channels with 12-bit period control
/// - 1 noise generator with 17-bit LFSR
/// - 1 envelope generator with 16 shapes (10 unique patterns)
/// - Configurable mixer for tone/noise routing
/// - DC offset removal filter
/// - DigiDrum sample injection support
///
/// # Example
///
/// ```
/// use ym2149::{Ym2149, Ym2149Backend};
///
/// let mut chip = Ym2149::new();
///
/// // Set up channel A: low period, max volume
/// chip.write_register(0, 0x00);  // Period low
/// chip.write_register(1, 0x01);  // Period high
/// chip.write_register(8, 0x0F);  // Volume
/// chip.write_register(7, 0x3E);  // Mixer: tone A on
///
/// // Generate audio
/// chip.clock();
/// let sample = chip.get_sample();
/// ```
#[derive(Clone)]
pub struct Ym2149 {
    // Clock and timing
    internal_clock: u32,
    sample_rate: u32,
    cycle_accumulator: u32,

    // Hardware registers
    registers: [u8; NUM_REGISTERS],
    selected_register: usize,

    // Generators
    tone_generators: [ToneGenerator; NUM_CHANNELS],
    noise_generator: NoiseGenerator,
    envelope_generator: EnvelopeGenerator,

    // Output processing
    mixer: Mixer,
    dc_filter: DcFilter,

    // Cached output for Backend trait
    last_sample: f32,

    // Timer IRQ state (for sync-buzzer effects)
    in_timer_irq: bool,

    // Write queue for hardware-accurate timing
    write_queue: VecDeque<PendingWrite>,
    /// Current CPU cycle (set by emulator before each write)
    current_cpu_cycle: u64,
    /// CPU cycle when register was last selected
    last_select_cycle: u64,
    /// CPU cycles per audio sample (for queue processing)
    cpu_cycles_per_sample: u64,
    /// CPU cycle at start of current sample
    sample_start_cycle: u64,
}

impl Ym2149 {
    /// Create a new YM2149 with default Atari ST clocks
    ///
    /// Default configuration:
    /// - Master clock: 2 MHz
    /// - Sample rate: 44.1 kHz
    pub fn new() -> Self {
        Self::with_clocks(DEFAULT_MASTER_CLOCK, DEFAULT_SAMPLE_RATE)
    }

    /// Create a new YM2149 with custom clock frequencies
    ///
    /// # Arguments
    ///
    /// * `master_clock` - Master clock frequency in Hz (divided by 8 internally)
    /// * `sample_rate` - Audio output sample rate in Hz
    pub fn with_clocks(master_clock: u32, sample_rate: u32) -> Self {
        // CPU runs at 4x PSG master clock (8 MHz vs 2 MHz on Atari ST)
        let cpu_clock = master_clock * CPU_CYCLES_PER_PSG_CYCLE as u32;
        let cpu_cycles_per_sample = cpu_clock as u64 / sample_rate as u64;

        let mut chip = Self {
            internal_clock: master_clock / 8,
            sample_rate,
            cycle_accumulator: 0,
            registers: [0; NUM_REGISTERS],
            selected_register: 0,
            tone_generators: [
                ToneGenerator::new(),
                ToneGenerator::new(),
                ToneGenerator::new(),
            ],
            noise_generator: NoiseGenerator::new(),
            envelope_generator: EnvelopeGenerator::new(),
            mixer: Mixer::new(),
            dc_filter: DcFilter::new(),
            last_sample: 0.0,
            in_timer_irq: false,
            write_queue: VecDeque::new(),
            current_cpu_cycle: 0,
            last_select_cycle: 0,
            cpu_cycles_per_sample,
            sample_start_cycle: 0,
        };
        chip.reset();
        chip
    }

    /// Reset the chip to initial state
    pub fn reset(&mut self) {
        // Randomize tone edge state (hardware behavior)
        let mut seed = 1u32;
        let random_edges = (random_seed(&mut seed) as u32 & ((1 << 10) | (1 << 5) | 1)) * 0x1f;

        for (i, tone) in self.tone_generators.iter_mut().enumerate() {
            tone.reset();
            // Set random edge bits for this channel
            tone.set_edge_bits(random_edges & (0x1f << (i * 5)));
        }

        self.noise_generator.reset();
        self.envelope_generator.reset();
        self.mixer.reset();
        self.dc_filter.reset();

        // Initialize registers (R7 = 0x3F = all outputs disabled)
        self.registers = [0; NUM_REGISTERS];
        self.apply_register(7, 0x3F);

        self.selected_register = 0;
        self.cycle_accumulator = 0;
        self.in_timer_irq = false;
        self.last_sample = 0.0;

        // Clear write queue and timing state
        self.write_queue.clear();
        self.current_cpu_cycle = 0;
        self.last_select_cycle = 0;
        self.sample_start_cycle = 0;
    }

    /// Set the current CPU cycle for accurate write timing.
    ///
    /// Call this before each `write_port()` to enable hardware-accurate
    /// register write timing. The CPU cycle is used to queue writes and
    /// apply them at the correct time during sample generation.
    ///
    /// # Arguments
    ///
    /// * `cycle` - Current CPU cycle count (e.g., from 68000 emulator)
    ///
    /// # Example
    ///
    /// ```ignore
    /// // In your emulator's memory write handler:
    /// ym2149.set_cpu_cycle(cpu.total_cycles());
    /// ym2149.write_port(port, value);
    /// ```
    #[inline]
    pub fn set_cpu_cycle(&mut self, cycle: u64) {
        self.current_cpu_cycle = cycle;
    }

    /// Returns the current CPU cycle.
    #[inline]
    #[must_use]
    pub fn cpu_cycle(&self) -> u64 {
        self.current_cpu_cycle
    }

    /// Write to hardware port (mimics real hardware bus access)
    ///
    /// Register writes are queued with their CPU cycle timestamp and applied
    /// at the correct time during sample generation. This ensures accurate
    /// timing for sync-buzzer and other cycle-sensitive effects.
    ///
    /// # Arguments
    ///
    /// * `port` - Port number (bit 1: 0 = address, 1 = data)
    /// * `value` - Value to write
    ///
    /// # Timing
    ///
    /// - Port 0 ($FF8800): Register select - latches immediately
    /// - Port 2 ($FF8802): Data write - queued for cycle-accurate application
    ///
    /// Writes that occur too quickly after a register select (< 4 CPU cycles)
    /// are still queued but may not behave as expected on real hardware.
    pub fn write_port(&mut self, port: u8, value: u8) {
        if (port & 2) != 0 {
            // Data write - queue for later application
            self.write_queue.push_back(PendingWrite {
                cpu_cycle: self.current_cpu_cycle,
                register: self.selected_register as u8,
                value,
            });
        } else {
            // Register select - apply immediately
            self.selected_register = (value as usize) & 0x0F;
            self.last_select_cycle = self.current_cpu_cycle;
        }
    }

    /// Write to hardware port with immediate application (legacy behavior).
    ///
    /// This bypasses the write queue and applies the register immediately.
    /// Use this only when cycle-accurate timing is not required.
    pub fn write_port_immediate(&mut self, port: u8, value: u8) {
        if (port & 2) != 0 {
            self.apply_register(self.selected_register, value);
        } else {
            self.selected_register = (value as usize) & 0x0F;
        }
    }

    /// Process pending writes up to (and including) the given CPU cycle.
    ///
    /// Call this during sample generation to apply queued writes at the
    /// correct time.
    fn process_pending_writes(&mut self, up_to_cycle: u64) {
        while let Some(write) = self.write_queue.front() {
            if write.cpu_cycle <= up_to_cycle {
                let w = self.write_queue.pop_front().unwrap();
                self.apply_register(w.register as usize, w.value);
            } else {
                break;
            }
        }
    }

    /// Flush all pending writes immediately.
    ///
    /// Use this at frame boundaries or when resetting to ensure all
    /// queued writes are applied.
    pub fn flush_pending_writes(&mut self) {
        while let Some(write) = self.write_queue.pop_front() {
            self.apply_register(write.register as usize, write.value);
        }
    }

    /// Returns the number of pending writes in the queue.
    #[inline]
    #[must_use]
    pub fn pending_write_count(&self) -> usize {
        self.write_queue.len()
    }

    /// Read from hardware port
    ///
    /// # Arguments
    ///
    /// * `port` - Port number (bit 1: 0 = address, 1 = data)
    ///
    /// # Returns
    ///
    /// Register value or 0xFF for invalid reads
    #[must_use]
    pub fn read_port(&self, port: u8) -> u8 {
        if (port & 2) == 0 && self.selected_register < NUM_REGISTERS {
            self.registers[self.selected_register]
        } else {
            0xFF
        }
    }

    /// Write to a register
    ///
    /// # Arguments
    ///
    /// * `register` - Register number (0-13)
    /// * `value` - Value to write
    pub fn write_register(&mut self, register: u8, value: u8) {
        self.apply_register(register as usize, value);
    }

    /// Read from a register
    ///
    /// # Arguments
    ///
    /// * `register` - Register number (0-13)
    ///
    /// # Returns
    ///
    /// Current register value
    #[must_use]
    pub fn read_register(&self, register: u8) -> u8 {
        let reg = register as usize;
        if reg < NUM_REGISTERS {
            self.registers[reg]
        } else {
            0
        }
    }

    /// Apply a register write and update internal state
    fn apply_register(&mut self, register: usize, value: u8) {
        if register >= NUM_REGISTERS {
            return;
        }

        // Mask value to valid bits
        let value = value & REG_MASK[register];
        self.registers[register] = value;

        match register {
            // Tone period registers (2 registers per channel)
            0..=5 => {
                let channel = register / 2;
                let period = self.read_tone_period(channel);
                self.tone_generators[channel].set_period(period);

                // Check for sync-buzzer effect
                if period <= 1 && self.in_timer_irq {
                    self.tone_generators[channel].mark_pending_reset();
                }
            }

            // Noise period
            6 => {
                self.noise_generator.set_period(value as u32);
            }

            // Mixer control
            7 => {
                self.mixer.config.set_from_register(value);
            }

            // Envelope period (R11/R12)
            11 | 12 => {
                let period = self.read_envelope_period();
                self.envelope_generator.set_period(period);
            }

            // Envelope shape (R13)
            13 => {
                self.envelope_generator.set_shape(value);
            }

            _ => {}
        }
    }

    /// Read 12-bit tone period from register pair
    #[inline]
    fn read_tone_period(&self, channel: usize) -> u32 {
        let base = channel * 2;
        ((self.registers[base + 1] as u32) << 8) | (self.registers[base] as u32)
    }

    /// Read 16-bit envelope period from registers
    #[inline]
    fn read_envelope_period(&self) -> u32 {
        ((self.registers[12] as u32) << 8) | (self.registers[11] as u32)
    }

    /// Tick internal state machines at 250kHz rate
    ///
    /// Returns the combined gate mask for all channels.
    fn tick_generators(&mut self) -> u32 {
        // Combine all tone edges
        let mut tone_edges = 0u32;
        for (i, tone) in self.tone_generators.iter_mut().enumerate() {
            tone_edges |= tone.tick(i as u32 * 5);
        }

        // Tick noise (runs at half rate internally)
        let noise_mask = self.noise_generator.tick();

        // Tick envelope
        self.envelope_generator.tick();

        // Compute combined gate mask
        self.mixer.config.compute_gate_mask(tone_edges, noise_mask)
    }

    /// Generate the next audio sample with cycle-accurate write processing.
    ///
    /// This method:
    /// 1. Processes any pending register writes that fall within this sample period
    /// 2. Runs the internal state machine at 250kHz
    /// 3. Averages the output to produce a sample at the host sample rate
    ///
    /// For accurate timing, call `set_cpu_cycle()` before each `write_port()` call,
    /// and ensure `sample_start_cycle` is updated between samples.
    pub fn compute_next_sample(&mut self) -> i16 {
        // Process any pending writes that should be applied before/during this sample
        let sample_end_cycle = self.sample_start_cycle + self.cpu_cycles_per_sample;
        self.process_pending_writes(sample_end_cycle);

        // Update sample start for next call
        self.sample_start_cycle = sample_end_cycle;

        // Accumulate gate mask over all internal ticks
        let mut accumulated_mask: u16 = 0;

        loop {
            accumulated_mask |= self.tick_generators() as u16;
            self.cycle_accumulator += self.sample_rate;
            if self.cycle_accumulator >= self.internal_clock {
                break;
            }
        }
        self.cycle_accumulator -= self.internal_clock;

        // Get envelope level
        let envelope_level = self.envelope_generator.level();

        // Build channel levels (gated and ungated for bipolar visualization)
        let volume_regs = [self.registers[8], self.registers[9], self.registers[10]];
        let (gated_levels, ungated_levels) =
            self.mixer
                .compute_levels(volume_regs, envelope_level, accumulated_mask as u32);

        // Compute individual channel outputs
        let mut total_output = 0u32;
        for channel in 0..NUM_CHANNELS {
            let level_index = (gated_levels >> (channel * 5)) & 0x1F;
            let ungated_level_index = (ungated_levels >> (channel * 5)) & 0x1F;
            let half_amplitude = self.tone_generators[channel].is_half_amplitude();
            total_output += self
                .mixer
                .compute_channel_output(channel, level_index, ungated_level_index, half_amplitude);
        }

        // Apply DC filter and return
        self.dc_filter.process(total_output as u16)
    }

    /// Synchronize the sample start cycle with the CPU cycle.
    ///
    /// Call this at the start of emulation or after a reset to align
    /// the sample timing with the CPU.
    #[inline]
    pub fn sync_sample_cycle(&mut self, cpu_cycle: u64) {
        self.sample_start_cycle = cpu_cycle;
        self.current_cpu_cycle = cpu_cycle;
    }

    /// Signal entry/exit of timer IRQ handler
    ///
    /// This is used by sync-buzzer effects where the tone period is set to 0 or 1
    /// inside the IRQ to create sample-accurate waveforms. When exiting the IRQ,
    /// any pending edge resets are applied.
    pub fn set_timer_irq_state(&mut self, in_irq: bool) {
        if !in_irq {
            // Apply pending resets when exiting IRQ
            for (i, tone) in self.tone_generators.iter_mut().enumerate() {
                tone.apply_pending_reset(i as u32 * 5);
            }
        }
        self.in_timer_irq = in_irq;
    }

    /// Alias for set_timer_irq_state (legacy compatibility)
    #[inline]
    pub fn inside_timer_irq(&mut self, inside: bool) {
        self.set_timer_irq_state(inside);
    }
}

impl Default for Ym2149 {
    fn default() -> Self {
        Self::new()
    }
}

impl std::fmt::Debug for Ym2149 {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("Ym2149")
            .field("registers", &self.registers)
            .field("sample_rate", &self.sample_rate)
            .field("internal_clock", &self.internal_clock)
            .finish_non_exhaustive()
    }
}

// =============================================================================
// Ym2149Backend trait implementation
// =============================================================================

impl Ym2149Backend for Ym2149 {
    fn new() -> Self {
        Ym2149::new()
    }

    fn with_clocks(master_clock: u32, sample_rate: u32) -> Self {
        Ym2149::with_clocks(master_clock, sample_rate)
    }

    fn reset(&mut self) {
        Ym2149::reset(self)
    }

    fn write_register(&mut self, addr: u8, value: u8) {
        Ym2149::write_register(self, addr, value)
    }

    fn read_register(&self, addr: u8) -> u8 {
        Ym2149::read_register(self, addr)
    }

    fn load_registers(&mut self, regs: &[u8; 16]) {
        for (i, &value) in regs.iter().take(NUM_REGISTERS).enumerate() {
            self.write_register(i as u8, value);
        }
    }

    fn dump_registers(&self) -> [u8; 16] {
        let mut out = [0u8; 16];
        out[..NUM_REGISTERS].copy_from_slice(&self.registers);
        out
    }

    fn clock(&mut self) {
        let sample_i16 = self.compute_next_sample();
        self.last_sample = (sample_i16 as f32 / 32767.0 * MASTER_GAIN).clamp(-1.0, 1.0);
    }

    fn get_sample(&self) -> f32 {
        self.last_sample
    }

    fn get_channel_outputs(&self) -> (f32, f32, f32) {
        self.mixer.channel_outputs()
    }

    fn set_channel_mute(&mut self, channel: usize, mute: bool) {
        self.mixer.set_mute(channel, mute);
    }

    fn is_channel_muted(&self, channel: usize) -> bool {
        self.mixer.is_muted(channel)
    }

    fn set_color_filter(&mut self, _enabled: bool) {
        // No post filter in this implementation
    }

    fn trigger_envelope(&mut self) {
        self.envelope_generator.trigger();
    }

    fn set_drum_sample_override(&mut self, channel: usize, sample: Option<f32>) {
        self.mixer.set_drum_override(channel, sample);
    }

    fn set_mixer_overrides(&mut self, _force_tone: [bool; 3], _force_noise_mute: [bool; 3]) {
        // Not implemented - would require extending MixerConfig
    }
}

// =============================================================================
// Tests
// =============================================================================

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_new_chip_has_default_state() {
        let chip = Ym2149::new();
        assert_eq!(chip.sample_rate, DEFAULT_SAMPLE_RATE);
        assert_eq!(chip.internal_clock, DEFAULT_MASTER_CLOCK / 8);
    }

    #[test]
    fn test_register_read_write() {
        let mut chip = Ym2149::new();

        chip.write_register(0, 0x55);
        assert_eq!(chip.read_register(0), 0x55);

        chip.write_register(1, 0xFF);
        assert_eq!(chip.read_register(1), 0x0F); // Masked to 4 bits
    }

    #[test]
    fn test_reset_clears_state() {
        let mut chip = Ym2149::new();

        // Set some registers
        chip.write_register(0, 0x55);
        chip.write_register(8, 0x0F);

        // Reset
        chip.reset();

        // Registers should be cleared (except R7 = 0x3F)
        assert_eq!(chip.read_register(0), 0);
        assert_eq!(chip.read_register(8), 0);
        assert_eq!(chip.read_register(7), 0x3F);
    }

    #[test]
    fn test_sample_generation() {
        let mut chip = Ym2149::new();

        // Set up a simple tone
        chip.write_register(0, 0x00);
        chip.write_register(1, 0x01);
        chip.write_register(8, 0x0F);
        chip.write_register(7, 0x3E);

        // Generate samples
        for _ in 0..100 {
            chip.clock();
        }

        // Should have non-zero output
        let sample = chip.get_sample();
        // After DC filtering warmup, we should see some output
        assert!(sample.abs() > 0.0 || chip.last_sample.abs() >= 0.0);
    }

    #[test]
    fn test_channel_mute() {
        let mut chip = Ym2149::new();

        assert!(!chip.is_channel_muted(0));
        chip.set_channel_mute(0, true);
        assert!(chip.is_channel_muted(0));
        assert!(!chip.is_channel_muted(1));
    }

    #[test]
    fn test_port_access() {
        let mut chip = Ym2149::new();

        // Select register 5
        chip.write_port(0, 5);
        // Write value to register 5
        chip.write_port(2, 0x0A);
        // Flush queued writes
        chip.flush_pending_writes();

        assert_eq!(chip.read_register(5), 0x0A);
    }

    #[test]
    fn test_port_access_immediate() {
        let mut chip = Ym2149::new();

        // Select register 5
        chip.write_port_immediate(0, 5);
        // Write value to register 5 (immediate, no queue)
        chip.write_port_immediate(2, 0x0A);

        assert_eq!(chip.read_register(5), 0x0A);
    }

    #[test]
    fn test_write_queue_timing() {
        let mut chip = Ym2149::new();

        // Set CPU cycle and write
        chip.set_cpu_cycle(100);
        chip.write_port(0, 8);  // Select volume register A
        chip.write_port(2, 0x0F);  // Max volume

        // Write is queued, not applied yet
        assert_eq!(chip.pending_write_count(), 1);
        assert_eq!(chip.read_register(8), 0x00);

        // Process writes up to cycle 100
        chip.sync_sample_cycle(0);
        chip.compute_next_sample();  // Processes writes within sample period

        // Now the write should be applied
        assert_eq!(chip.pending_write_count(), 0);
        assert_eq!(chip.read_register(8), 0x0F);
    }
}