yip-io 0.1.0

//! Local TUN `virtio_net_hdr` (GSO/GRO) framing + the RX coalescer / TX splitter.
//! Purely local to the yipd↔kernel-TUN boundary — never touches the wire.

pub const VNET_HDR_LEN: usize = 10;
pub const GSO_NONE: u8 = 0;
pub const GSO_TCPV4: u8 = 1;
pub const GSO_TCPV6: u8 = 4;
pub const GSO_UDP_L4: u8 = 5;
pub const F_NEEDS_CSUM: u8 = 1;
pub const F_DATA_VALID: u8 = 2;

#[repr(C)]
#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
pub struct VirtioNetHdr {
    pub flags: u8,
    pub gso_type: u8,
    pub hdr_len: u16,
    pub gso_size: u16,
    pub csum_start: u16,
    pub csum_offset: u16,
}

pub type VnetHdr = VirtioNetHdr;

/// Slices a GSO super-packet payload into segments of at most `mss` bytes.
///
/// Returns an empty vector if `buf` is empty. If `mss == 0`, returns a single slice containing `buf`.
pub fn slice_gso_payload(buf: &[u8], mss: usize) -> Vec<&[u8]> {
    if buf.is_empty() {
        return Vec::new();
    }
    if mss == 0 {
        return vec![buf];
    }
    buf.chunks(mss).collect()
}

/// Slices a GSO super-packet into segments of at most `mss` bytes.
#[inline]
pub fn slice_gso_packet(buf: &[u8], mss: usize) -> Vec<&[u8]> {
    slice_gso_payload(buf, mss)
}

pub fn read_vnet_hdr(buf: &[u8]) -> Option<VirtioNetHdr> {
    if buf.len() < VNET_HDR_LEN {
        return None;
    }
    let u16h = |a: usize| u16::from_ne_bytes([buf[a], buf[a + 1]]);
    Some(VirtioNetHdr {
        flags: buf[0],
        gso_type: buf[1],
        hdr_len: u16h(2),
        gso_size: u16h(4),
        csum_start: u16h(6),
        csum_offset: u16h(8),
    })
}

pub fn write_vnet_hdr(h: &VirtioNetHdr, out: &mut [u8]) {
    assert!(out.len() >= VNET_HDR_LEN);
    out[0] = h.flags;
    out[1] = h.gso_type;
    out[2..4].copy_from_slice(&h.hdr_len.to_ne_bytes());
    out[4..6].copy_from_slice(&h.gso_size.to_ne_bytes());
    out[6..8].copy_from_slice(&h.csum_start.to_ne_bytes());
    out[8..10].copy_from_slice(&h.csum_offset.to_ne_bytes());
}

pub(crate) const TCP_FLAG_FIN: u8 = 0x01;
pub(crate) const TCP_FLAG_RST: u8 = 0x04;
pub(crate) const TCP_FLAG_PSH: u8 = 0x08;
pub(crate) const TCP_FLAG_URG: u8 = 0x20;

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(crate) struct FlowKey {
    pub src: [u8; 4],
    pub dst: [u8; 4],
    pub sport: u16,
    pub dport: u16,
}

pub(crate) struct Ipv4Tcp<'a> {
    pub ip_hdr_len: usize,
    #[cfg_attr(
        not(test),
        expect(
            dead_code,
            reason = "read only by parse_ipv4_tcp_extracts_fields; split_gro/Coalescer derive \
                      the segment header length from payload_off instead"
        )
    )]
    pub tcp_hdr_len: usize,
    pub total_len: usize,
    pub key: FlowKey,
    pub seq: u32,
    pub flags: u8,
    pub payload_off: usize,
    pub payload_len: usize,
    pub bytes: &'a [u8],
}

pub(crate) fn parse_ipv4_tcp(pkt: &[u8]) -> Option<Ipv4Tcp<'_>> {
    if pkt.len() < 20 || (pkt[0] >> 4) != 4 {
        return None;
    }
    let ihl = usize::from(pkt[0] & 0x0F) * 4;
    if ihl < 20 || pkt.len() < ihl {
        return None;
    }
    if pkt[9] != 6 {
        return None;
    } // not TCP
      // fragmentation: MF (bit) or non-zero frag offset in bytes 6..8
    let frag = u16::from_be_bytes([pkt[6], pkt[7]]);
    if (frag & 0x2000) != 0 || (frag & 0x1FFF) != 0 {
        return None;
    }
    let total_len = usize::from(u16::from_be_bytes([pkt[2], pkt[3]]));
    if total_len < ihl || pkt.len() < total_len {
        return None;
    }
    if total_len < ihl + 20 {
        return None;
    }
    let t = ihl;
    let data_off = usize::from(pkt[t + 12] >> 4) * 4;
    if data_off < 20 || total_len < ihl + data_off {
        return None;
    }
    let sport = u16::from_be_bytes([pkt[t], pkt[t + 1]]);
    let dport = u16::from_be_bytes([pkt[t + 2], pkt[t + 3]]);
    let seq = u32::from_be_bytes([pkt[t + 4], pkt[t + 5], pkt[t + 6], pkt[t + 7]]);
    let flags = pkt[t + 13];
    let payload_off = ihl + data_off;
    Some(Ipv4Tcp {
        ip_hdr_len: ihl,
        tcp_hdr_len: data_off,
        total_len,
        key: FlowKey {
            src: [pkt[12], pkt[13], pkt[14], pkt[15]],
            dst: [pkt[16], pkt[17], pkt[18], pkt[19]],
            sport,
            dport,
        },
        seq,
        flags,
        payload_off,
        payload_len: total_len - payload_off,
        bytes: pkt,
    })
}

pub(crate) fn ipv4_checksum(hdr: &mut [u8]) {
    hdr[10] = 0;
    hdr[11] = 0;
    let mut sum: u32 = 0;
    for c in hdr.chunks(2) {
        let word = if c.len() == 2 {
            u16::from_be_bytes([c[0], c[1]])
        } else {
            u16::from(c[0]) << 8
        };
        sum += u32::from(word);
    }
    while (sum >> 16) != 0 {
        sum = (sum & 0xFFFF) + (sum >> 16);
    }
    let ck = !u16::try_from(sum & 0xFFFF).expect("folded sum fits u16");
    hdr[10..12].copy_from_slice(&ck.to_be_bytes());
}

pub(crate) fn tcp_checksum(pkt: &mut [u8], ip_hdr_len: usize) {
    let total = pkt.len();
    let tcp_off = ip_hdr_len;
    // zero the checksum field
    pkt[tcp_off + 16] = 0;
    pkt[tcp_off + 17] = 0;
    let tcp_len = total - tcp_off;
    let mut sum: u32 = 0;
    // pseudo-header: src(4)+dst(4)+zero+proto(6)+tcp_len
    for i in (12..20).step_by(2) {
        sum += u32::from(u16::from_be_bytes([pkt[i], pkt[i + 1]]));
    }
    sum += u32::from(6u16);
    sum += u32::try_from(tcp_len).expect("tcp_len fits u32") & 0xFFFF;
    for c in pkt[tcp_off..total].chunks(2) {
        let w = if c.len() == 2 {
            u16::from_be_bytes([c[0], c[1]])
        } else {
            u16::from(c[0]) << 8
        };
        sum += u32::from(w);
    }
    while (sum >> 16) != 0 {
        sum = (sum & 0xFFFF) + (sum >> 16);
    }
    let ck = !u16::try_from(sum & 0xFFFF).expect("folded fits u16");
    pkt[tcp_off + 16..tcp_off + 18].copy_from_slice(&ck.to_be_bytes());
}

/// Complete a partial (`F_NEEDS_CSUM`) L4 checksum in `pkt` (an L3 packet) as
/// delivered by a vnet_hdr TUN read. The 16-bit field at `csum_start +
/// csum_offset` holds the pseudo-header partial sum; the final checksum is the
/// one's-complement of the folded internet-checksum sum over `pkt[csum_start..]`
/// (which includes that partial field). A computed 0 on a UDP packet (proto 17)
/// is transmitted as `0xFFFF` per RFC 768. Malformed offsets are left untouched.
fn complete_partial_csum(pkt: &mut [u8], csum_start: usize, csum_offset: usize) {
    let field = csum_start + csum_offset;
    if csum_start >= pkt.len() || field + 2 > pkt.len() {
        return;
    }
    let region = &pkt[csum_start..];
    let mut sum: u32 = 0;
    let mut i = 0;
    while i + 1 < region.len() {
        sum += u32::from(u16::from_be_bytes([region[i], region[i + 1]]));
        i += 2;
    }
    if i < region.len() {
        sum += u32::from(u16::from(region[i]) << 8);
    }
    while (sum >> 16) != 0 {
        sum = (sum & 0xFFFF) + (sum >> 16);
    }
    let mut ck = !u16::try_from(sum & 0xFFFF).expect("folded sum fits u16");
    if ck == 0 && pkt.get(9) == Some(&17) {
        ck = 0xFFFF; // UDP: 0 means "no checksum", the real zero is 0xFFFF
    }
    pkt[field..field + 2].copy_from_slice(&ck.to_be_bytes());
}

pub fn split_gro(frame: &[u8], out: &mut Vec<u8>, offsets: &mut Vec<(usize, usize)>) -> bool {
    out.clear();
    offsets.clear();
    let Some(h) = read_vnet_hdr(frame) else {
        return false;
    };
    let body = &frame[VNET_HDR_LEN..];
    if h.gso_type == GSO_NONE || h.gso_size == 0 {
        let start = out.len();
        out.extend_from_slice(body);
        // A vnet_hdr read with F_NEEDS_CSUM carries an *incomplete* L4 checksum
        // (the kernel offloaded it): the 16-bit field at csum_start+csum_offset
        // holds the pseudo-header partial. We complete it here, because this
        // packet is about to be encrypted and shipped over the wire — the far
        // end writes it back to its TUN as a plain (F_NEEDS_CSUM=0) frame and its
        // kernel/apps expect a valid checksum. Without this, large offloaded
        // packets (e.g. bulk transfers) arrive with a bad checksum and are
        // silently dropped, while tiny packets the kernel checksums in full
        // (e.g. pings) pass — the classic vnet_hdr read-side gotcha.
        if (h.flags & F_NEEDS_CSUM) != 0 {
            let len = out.len() - start;
            complete_partial_csum(
                &mut out[start..start + len],
                usize::from(h.csum_start),
                usize::from(h.csum_offset),
            );
        }
        offsets.push((start, body.len()));
        return true;
    }
    let Some(x) = parse_ipv4_tcp(body) else {
        return false;
    };
    let seg = usize::from(h.gso_size);
    let hdr = x.payload_off; // ip_hdr_len + tcp_hdr_len
    let payload = &body[x.payload_off..x.payload_off + x.payload_len];
    let mut seq = x.seq;
    let mut ip_id = u16::from_be_bytes([body[4], body[5]]);
    let mut off = 0usize;
    while off < payload.len() {
        let n = seg.min(payload.len() - off);
        let start = out.len();
        out.extend_from_slice(&body[..hdr]); // clone IP+TCP header
        out.extend_from_slice(&payload[off..off + n]);
        let s = &mut out[start..start + hdr + n];
        // patch IP total-length, IP ID, TCP seq; recompute both checksums
        let total = u16::try_from(hdr + n).expect("segment fits u16");
        s[2..4].copy_from_slice(&total.to_be_bytes());
        s[4..6].copy_from_slice(&ip_id.to_be_bytes());
        s[x.ip_hdr_len + 4..x.ip_hdr_len + 8].copy_from_slice(&seq.to_be_bytes());
        ipv4_checksum(&mut s[..x.ip_hdr_len]);
        tcp_checksum(s, x.ip_hdr_len);
        offsets.push((start, hdr + n));
        seq = seq.wrapping_add(u32::try_from(n).expect("n fits u32"));
        ip_id = ip_id.wrapping_add(1);
        off += n;
    }
    true
}

pub const MAX_GSO_SEGMENTS: usize = 64;
pub const MAX_GSO_PAYLOAD: usize = 65_535;

pub struct Coalescer {
    pending: Vec<u8>, // [vnet_hdr | ip+tcp hdr | payloads]; empty ⇒ nothing pending
    out: Vec<u8>,     // holds a flushed frame for the returned borrow
    has_pending: bool,
    is_tcp_run: bool, // false ⇒ pending is a GSO_NONE singleton
    sealed: bool,     // pending cannot be extended (PSH/FIN/non-TCP/no-payload)
    key: FlowKey,
    next_seq: u32,
    gso_size: u16,
    ip_hdr_len: usize,
    l3_hdr_len: usize, // ip_hdr_len + tcp_hdr_len (payload offset within the L3 packet)
    segs: usize,
}

impl Coalescer {
    pub fn new() -> Self {
        Self {
            pending: Vec::with_capacity(MAX_GSO_PAYLOAD + 64),
            out: Vec::with_capacity(MAX_GSO_PAYLOAD + 64),
            has_pending: false,
            is_tcp_run: false,
            sealed: false,
            key: FlowKey {
                src: [0; 4],
                dst: [0; 4],
                sport: 0,
                dport: 0,
            },
            next_seq: 0,
            gso_size: 0,
            ip_hdr_len: 0,
            l3_hdr_len: 0,
            segs: 0,
        }
    }

    /// Finalize the pending run into `self.out` and return the borrow (or None).
    fn take_pending(&mut self) -> Option<&[u8]> {
        if !self.has_pending {
            return None;
        }
        if self.is_tcp_run {
            // patch IP total-length + IP checksum, then set the vnet_hdr.
            let ip = VNET_HDR_LEN;
            let l3_len = self.pending.len() - VNET_HDR_LEN;
            let total = u16::try_from(l3_len).unwrap_or(u16::MAX);
            self.pending[ip + 2..ip + 4].copy_from_slice(&total.to_be_bytes());
            ipv4_checksum(&mut self.pending[ip..ip + self.ip_hdr_len]);
            let h = VnetHdr {
                flags: F_NEEDS_CSUM,
                gso_type: GSO_TCPV4,
                hdr_len: u16::try_from(self.l3_hdr_len).unwrap_or(0),
                gso_size: self.gso_size,
                csum_start: u16::try_from(self.ip_hdr_len).unwrap_or(0), // L4 offset within L3 frame
                csum_offset: 16,                                         // TCP checksum offset
            };
            write_vnet_hdr(&h, &mut self.pending[..VNET_HDR_LEN]);
        }
        // (non-TCP singleton already has its GSO_NONE vnet_hdr written at start_singleton)
        std::mem::swap(&mut self.pending, &mut self.out);
        self.pending.clear();
        self.has_pending = false;
        Some(&self.out)
    }

    fn start_tcp_run(&mut self, x: &Ipv4Tcp<'_>, sealed: bool) {
        self.pending.clear();
        self.pending.resize(VNET_HDR_LEN, 0);
        self.pending.extend_from_slice(&x.bytes[..x.total_len]); // full first L3 packet
        self.has_pending = true;
        self.is_tcp_run = true;
        self.sealed = sealed;
        self.key = x.key;
        self.ip_hdr_len = x.ip_hdr_len;
        self.l3_hdr_len = x.payload_off;
        self.gso_size = u16::try_from(x.payload_len).unwrap_or(0);
        self.next_seq = x
            .seq
            .wrapping_add(u32::try_from(x.payload_len).unwrap_or(0));
        self.segs = 1;
    }

    fn start_singleton(&mut self, pkt: &[u8]) {
        self.pending.clear();
        self.pending.resize(VNET_HDR_LEN, 0);
        write_vnet_hdr(
            &VnetHdr {
                gso_type: GSO_NONE,
                ..VnetHdr::default()
            },
            &mut self.pending,
        );
        self.pending.extend_from_slice(pkt);
        self.has_pending = true;
        self.is_tcp_run = false;
        self.sealed = true;
    }

    pub fn push(&mut self, pkt: &[u8]) -> Option<&[u8]> {
        let parsed = parse_ipv4_tcp(pkt);
        // Can this packet extend the current (open, tcp) pending run?
        if self.has_pending && self.is_tcp_run && !self.sealed {
            if let Some(x) = &parsed {
                let cont = x.payload_len > 0
                    && (x.flags & (TCP_FLAG_PSH | TCP_FLAG_FIN | TCP_FLAG_RST | TCP_FLAG_URG)) == 0
                    && x.key == self.key
                    && x.seq == self.next_seq
                    && x.payload_off == self.l3_hdr_len
                    && self.segs < MAX_GSO_SEGMENTS
                    && (self.pending.len() - VNET_HDR_LEN - self.l3_hdr_len) + x.payload_len
                        <= MAX_GSO_PAYLOAD;
                if cont {
                    self.pending
                        .extend_from_slice(&x.bytes[x.payload_off..x.payload_off + x.payload_len]);
                    self.next_seq = self
                        .next_seq
                        .wrapping_add(u32::try_from(x.payload_len).unwrap_or(0));
                    self.segs += 1;
                    return None;
                }
            }
        }
        // Cannot extend: flush the pending run (if any), then start a new one from `pkt`.
        // Buffer the flushed frame's bytes so we can start the new run before returning it.
        let flushed: Option<Vec<u8>> = self.take_pending().map(<[u8]>::to_vec);
        match &parsed {
            Some(x) if x.payload_len > 0 => {
                let sealed =
                    (x.flags & (TCP_FLAG_PSH | TCP_FLAG_FIN | TCP_FLAG_RST | TCP_FLAG_URG)) != 0;
                self.start_tcp_run(x, sealed);
            }
            _ => self.start_singleton(pkt),
        }
        match flushed {
            Some(f) => {
                self.out = f;
                Some(&self.out)
            }
            None => None,
        }
    }

    pub fn flush(&mut self) -> Option<&[u8]> {
        self.take_pending()
    }
}

impl Default for Coalescer {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    // Internet-checksum fold of a 16-bit word sum over `data`.
    fn csum16(data: &[u8]) -> u16 {
        let mut sum: u32 = 0;
        let mut i = 0;
        while i + 1 < data.len() {
            sum += u32::from(u16::from_be_bytes([data[i], data[i + 1]]));
            i += 2;
        }
        if i < data.len() {
            sum += u32::from(u16::from(data[i]) << 8);
        }
        while (sum >> 16) != 0 {
            sum = (sum & 0xFFFF) + (sum >> 16);
        }
        u16::try_from(sum & 0xFFFF).unwrap()
    }

    #[test]
    fn complete_partial_csum_matches_full_udp_checksum() {
        // IPv4(20) + UDP(8) + payload, csum_start=20, csum_offset=6.
        let payload = [0x11u8, 0x22, 0x33, 0x44, 0x55];
        let udp_len = 8 + payload.len();
        let total = 20 + udp_len;
        let mut p = vec![0u8; total];
        p[0] = 0x45;
        p[2..4].copy_from_slice(&u16::try_from(total).unwrap().to_be_bytes());
        p[8] = 64;
        p[9] = 17; // UDP
        p[12..16].copy_from_slice(&[10, 0, 0, 1]);
        p[16..20].copy_from_slice(&[10, 0, 0, 2]);
        p[20..22].copy_from_slice(&1111u16.to_be_bytes()); // sport
        p[22..24].copy_from_slice(&2222u16.to_be_bytes()); // dport
        p[24..26].copy_from_slice(&u16::try_from(udp_len).unwrap().to_be_bytes());
        p[28..].copy_from_slice(&payload);

        // Pseudo-header 16-bit sum: src + dst + proto + udp_len.
        let mut pseudo = vec![0u8; 12];
        pseudo[..4].copy_from_slice(&[10, 0, 0, 1]);
        pseudo[4..8].copy_from_slice(&[10, 0, 0, 2]);
        pseudo[9] = 17;
        pseudo[10..12].copy_from_slice(&u16::try_from(udp_len).unwrap().to_be_bytes());
        let pseudo_sum = csum16(&pseudo);

        // Reference full UDP checksum (field zeroed): ~fold(pseudo + L4-with-zero-field).
        let good = !{
            let mut s = u32::from(pseudo_sum) + u32::from(csum16(&p[20..]));
            while (s >> 16) != 0 {
                s = (s & 0xFFFF) + (s >> 16);
            }
            u16::try_from(s & 0xFFFF).unwrap()
        };

        // Kernel delivers F_NEEDS_CSUM with the field pre-seeded to the pseudo sum.
        p[20 + 6..20 + 8].copy_from_slice(&pseudo_sum.to_be_bytes());
        complete_partial_csum(&mut p, 20, 6);
        let completed = u16::from_be_bytes([p[26], p[27]]);
        assert_eq!(
            completed, good,
            "completed checksum must equal the full UDP checksum"
        );
    }

    fn mk_tcp(
        src: [u8; 4],
        dst: [u8; 4],
        sport: u16,
        dport: u16,
        seq: u32,
        flags: u8,
        payload: &[u8],
    ) -> Vec<u8> {
        let ihl = 20usize;
        let thl = 20usize;
        let total = ihl + thl + payload.len();
        let mut p = vec![0u8; total];
        p[0] = 0x45; // v4, IHL=5
        p[2..4].copy_from_slice(&(u16::try_from(total).unwrap()).to_be_bytes());
        p[8] = 64;
        p[9] = 6; // TTL, proto=TCP
        p[12..16].copy_from_slice(&src);
        p[16..20].copy_from_slice(&dst);
        // TCP
        let t = ihl;
        p[t..t + 2].copy_from_slice(&sport.to_be_bytes());
        p[t + 2..t + 4].copy_from_slice(&dport.to_be_bytes());
        p[t + 4..t + 8].copy_from_slice(&seq.to_be_bytes());
        p[t + 12] = 0x50; // data offset = 5 (20 bytes)
        p[t + 13] = flags;
        p[t + 20..].copy_from_slice(payload);
        ipv4_checksum(&mut p[..ihl]);
        p
    }

    #[test]
    fn parse_ipv4_tcp_extracts_fields() {
        let p = mk_tcp(
            [10, 0, 0, 1],
            [10, 0, 0, 2],
            1234,
            80,
            1000,
            TCP_FLAG_PSH,
            b"hello",
        );
        let x = parse_ipv4_tcp(&p).expect("parse");
        assert_eq!(
            x.key,
            FlowKey {
                src: [10, 0, 0, 1],
                dst: [10, 0, 0, 2],
                sport: 1234,
                dport: 80
            }
        );
        assert_eq!(x.seq, 1000);
        assert_eq!(x.flags & TCP_FLAG_PSH, TCP_FLAG_PSH);
        assert_eq!(x.ip_hdr_len, 20);
        assert_eq!(x.tcp_hdr_len, 20);
        assert_eq!(x.payload_len, 5);
        assert_eq!(
            &x.bytes[x.payload_off..x.payload_off + x.payload_len],
            b"hello"
        );
    }

    #[test]
    fn parse_rejects_non_tcp_and_fragments() {
        let mut udp = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 1, 2, 0, 0, b"x");
        udp[9] = 17; // proto=UDP
        assert!(parse_ipv4_tcp(&udp).is_none());
        let mut frag = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 1, 2, 0, 0, b"x");
        frag[6] = 0x20; // MF set
        assert!(parse_ipv4_tcp(&frag).is_none());
    }

    #[test]
    fn ipv4_checksum_is_valid() {
        let p = mk_tcp([1, 2, 3, 4], [5, 6, 7, 8], 1, 2, 0, 0, b"z");
        // A correct IPv4 checksum makes the one's-complement sum of the header 0xFFFF.
        let sum: u32 = p[..20]
            .chunks(2)
            .map(|c| u32::from(u16::from_be_bytes([c[0], c[1]])))
            .sum();
        let folded = u16::try_from((sum & 0xFFFF) + (sum >> 16)).expect("folded sum fits u16");
        assert_eq!(folded, 0xFFFF);
    }

    #[test]
    fn vnet_hdr_roundtrip() {
        let h = VnetHdr {
            flags: F_NEEDS_CSUM,
            gso_type: GSO_TCPV4,
            hdr_len: 40,
            gso_size: 1400,
            csum_start: 20,
            csum_offset: 16,
        };
        let mut buf = [0u8; VNET_HDR_LEN];
        write_vnet_hdr(&h, &mut buf);
        let got = read_vnet_hdr(&buf).expect("parse");
        assert_eq!(got.gso_type, GSO_TCPV4);
        assert_eq!(got.gso_size, 1400);
        assert_eq!(got.hdr_len, 40);
        assert_eq!(got.csum_start, 20);
        assert_eq!(got.csum_offset, 16);
        assert_eq!(got.flags, F_NEEDS_CSUM);
    }

    #[test]
    fn read_vnet_hdr_rejects_short() {
        assert!(read_vnet_hdr(&[0u8; VNET_HDR_LEN - 1]).is_none());
    }

    // Helper: run a sequence of packets through a Coalescer, collecting every emitted frame
    // (both push-flushes and the final flush), returned as owned Vecs.
    fn run_coalescer(pkts: &[Vec<u8>]) -> Vec<Vec<u8>> {
        let mut c = Coalescer::new();
        let mut out = Vec::new();
        for p in pkts {
            if let Some(f) = c.push(p) {
                out.push(f.to_vec());
            }
        }
        if let Some(f) = c.flush() {
            out.push(f.to_vec());
        }
        out
    }

    #[test]
    fn coalesces_contiguous_same_flow() {
        // three 100-byte segments, seq 0,100,200 — must merge into ONE super-frame.
        let p0 = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 0, 0, &[0xAA; 100]);
        let p1 = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 100, 0, &[0xBB; 100]);
        let p2 = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 200, 0, &[0xCC; 100]);
        let out = run_coalescer(&[p0, p1, p2]);
        assert_eq!(out.len(), 1, "one coalesced super-frame");
        let h = read_vnet_hdr(&out[0]).unwrap();
        assert_eq!(h.gso_type, GSO_TCPV4);
        assert_eq!(h.gso_size, 100);
        // super-frame payload = 300 bytes after vnet_hdr + IP(20) + TCP(20)
        assert_eq!(out[0].len(), VNET_HDR_LEN + 20 + 20 + 300);
    }

    #[test]
    fn flushes_on_seq_gap() {
        let p0 = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 0, 0, &[0; 100]);
        let gap = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 500, 0, &[0; 100]); // non-contiguous
        assert_eq!(run_coalescer(&[p0, gap]).len(), 2);
    }

    #[test]
    fn flushes_on_flow_change() {
        let a = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 0, 0, &[0; 100]);
        let b = mk_tcp([10, 0, 0, 1], [10, 0, 0, 3], 9, 80, 0, 0, &[0; 100]); // different dst
        assert_eq!(run_coalescer(&[a, b]).len(), 2);
    }

    #[test]
    fn psh_and_fin_force_immediate_flush() {
        let p0 = mk_tcp(
            [10, 0, 0, 1],
            [10, 0, 0, 2],
            9,
            80,
            0,
            TCP_FLAG_PSH,
            &[0; 100],
        );
        let p1 = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 100, 0, &[0; 100]);
        // p0 has PSH → emitted immediately as its own frame; p1 starts a new run flushed at end.
        assert_eq!(run_coalescer(&[p0, p1]).len(), 2);
    }

    #[test]
    fn non_tcp_is_singleton_passthrough() {
        let mut udp = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 0, 0, &[0; 100]);
        udp[9] = 17;
        let out = run_coalescer(&[udp.clone()]);
        assert_eq!(out.len(), 1);
        // singleton: gso_type NONE, body == original packet bytes exactly
        assert_eq!(read_vnet_hdr(&out[0]).unwrap().gso_type, GSO_NONE);
        assert_eq!(&out[0][VNET_HDR_LEN..], &udp[..]);
    }

    #[test]
    fn split_none_passthrough() {
        let pkt = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 0, TCP_FLAG_PSH, b"hi");
        let mut frame = vec![0u8; VNET_HDR_LEN];
        write_vnet_hdr(
            &VnetHdr {
                gso_type: GSO_NONE,
                ..Default::default()
            },
            &mut frame,
        );
        frame.extend_from_slice(&pkt);
        let (mut out, mut offs) = (Vec::new(), Vec::new());
        assert!(split_gro(&frame, &mut out, &mut offs));
        assert_eq!(offs.len(), 1);
        assert_eq!(&out[offs[0].0..offs[0].0 + offs[0].1], &pkt[..]);
    }

    #[test]
    fn split_gro_segments_and_checksums() {
        // one super-frame: gso_size=100, 250 bytes payload → segments of 100,100,50.
        let mut big = mk_tcp(
            [10, 0, 0, 1],
            [10, 0, 0, 2],
            9,
            80,
            1000,
            0,
            &vec![0xEE; 250],
        );
        // fix IP total-length already set by mk_tcp; build the framed input:
        let mut frame = vec![0u8; VNET_HDR_LEN];
        write_vnet_hdr(
            &VnetHdr {
                flags: F_NEEDS_CSUM,
                gso_type: GSO_TCPV4,
                hdr_len: 40,
                gso_size: 100,
                csum_start: 20,
                csum_offset: 16,
            },
            &mut frame,
        );
        frame.extend_from_slice(&big);
        let (mut out, mut offs) = (Vec::new(), Vec::new());
        assert!(split_gro(&frame, &mut out, &mut offs));
        assert_eq!(offs.len(), 3);
        // each segment parses as valid IPv4/TCP with the right seq + payload size
        let sizes = [100usize, 100, 50];
        let mut expect_seq = 1000u32;
        for (i, &(s, l)) in offs.iter().enumerate() {
            let seg = &out[s..s + l];
            let x = parse_ipv4_tcp(seg).expect("valid segment");
            assert_eq!(x.payload_len, sizes[i]);
            assert_eq!(x.seq, expect_seq);
            expect_seq += u32::try_from(sizes[i]).unwrap();
            // IP checksum valid (header folds to 0xFFFF)
            let sum: u32 = seg[..20]
                .chunks(2)
                .map(|c| u32::from(u16::from_be_bytes([c[0], c[1]])))
                .sum();
            assert_eq!(
                u16::try_from((sum & 0xFFFF) + (sum >> 16)).expect("folded sum fits u16"),
                0xFFFF
            );
        }
        let _ = &mut big;
    }

    #[test]
    fn split_then_coalesce_roundtrip() {
        // Distinct (non-constant) bytes so any off-by-one/duplication bug is caught.
        let payload: Vec<u8> = (0..250usize)
            .map(|i| u8::try_from(i % 256).expect("fits u8"))
            .collect();
        let big = mk_tcp([10, 0, 0, 1], [10, 0, 0, 2], 9, 80, 1000, 0, &payload);
        let mut frame = vec![0u8; VNET_HDR_LEN];
        write_vnet_hdr(
            &VnetHdr {
                flags: F_NEEDS_CSUM,
                gso_type: GSO_TCPV4,
                hdr_len: 40,
                gso_size: 100,
                csum_start: 20,
                csum_offset: 16,
            },
            &mut frame,
        );
        frame.extend_from_slice(&big);

        let (mut out, mut offs) = (Vec::new(), Vec::new());
        assert!(split_gro(&frame, &mut out, &mut offs));
        assert_eq!(offs.len(), 3, "100,100,50-byte segments");

        // Feed each split segment (a raw IP/TCP packet, no vnet_hdr) through the Coalescer,
        // exactly as the poll RX path would after receiving them off the wire.
        let mut c = Coalescer::new();
        let mut frames: Vec<Vec<u8>> = Vec::new();
        for &(s, l) in &offs {
            let seg = &out[s..s + l];
            if let Some(f) = c.push(seg) {
                frames.push(f.to_vec());
            }
        }
        if let Some(f) = c.flush() {
            frames.push(f.to_vec());
        }

        // Reassemble the coalesced TCP payload bytes and compare to the original, byte-exact.
        let mut coalesced_payload = Vec::new();
        for f in &frames {
            let body = &f[VNET_HDR_LEN..];
            let x = parse_ipv4_tcp(body).expect("valid coalesced frame");
            coalesced_payload
                .extend_from_slice(&body[x.payload_off..x.payload_off + x.payload_len]);
        }
        assert_eq!(coalesced_payload, payload);
    }
}