yallm-config 0.1.0

Layered TOML config loading for yallm
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
//! Layered configuration loading for yallm.
//!
//! Priority (high to low), each layer overwrites lower layers:
//! 1. `.yallm/secrets.toml` - project secrets (gitignored)
//! 2. `.yallm/*.local.toml` - per-machine overrides (gitignored)
//! 3. `.yallm/config.toml` - project config (committed)
//! 4. `~/.yallm/config.toml` - user defaults
//! 5. OS env vars
//! 6. `.env` file (only fills keys absent from OS env)
//!
//! Config files can have an `[env]` section. Values are returned in a merged
//! map instead of being written back into the process environment.

use std::{
    collections::{HashMap, HashSet},
    env, fs,
    path::{Path, PathBuf},
};

use serde::{Deserialize, Deserializer};

#[derive(Debug, Clone, Default)]
pub struct LoadOptions {
    pub litellm_config: Option<PathBuf>,
}

#[derive(Debug, Clone, Default)]
pub struct LoadedConfig {
    pub env: HashMap<String, String>,
    pub litellm_models: Vec<LiteLlmModel>,
    pub warnings: Vec<String>,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct LiteLlmModel {
    pub model_name: String,
    pub provider: LiteLlmProvider,
    pub upstream_model: String,
    pub api_base: Option<String>,
    pub api_key: Option<String>,
    pub api_version: Option<String>,
}

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum LiteLlmProvider {
    OpenAI,
    Anthropic,
    Ollama,
}

/// Top-level yallm TOML structure.
#[derive(Debug, Deserialize, Default)]
pub struct ConfigFile {
    /// Env vars to inject into the merged config map.
    #[serde(default)]
    pub env: HashMap<String, String>,
}

/// Load config from all layers using default options.
pub fn load() -> LoadedConfig {
    load_with_options(LoadOptions::default())
}

/// Load config from all layers.
pub fn load_with_options(options: LoadOptions) -> LoadedConfig {
    let current_dir = env::current_dir().unwrap_or_default();
    let mut merged_env: HashMap<String, String> = env::vars().collect();
    let mut warnings = Vec::new();

    // .env only fills keys absent from OS env (matches dotenvy/python-dotenv default).
    apply_dotenv(&current_dir.join(".env"), &mut merged_env, &mut warnings);

    if let Some(path) = user_config_path(&merged_env) {
        apply_toml_file(&path, &mut merged_env, "user config", &mut warnings);
    }
    let project_dir = current_dir.join(".yallm");
    apply_toml_file(
        &project_dir.join("config.toml"),
        &mut merged_env,
        "project config",
        &mut warnings,
    );
    apply_toml_glob(
        &project_dir,
        ".local.toml",
        &mut merged_env,
        "local override",
        &mut warnings,
    );
    apply_toml_file(
        &project_dir.join("secrets.toml"),
        &mut merged_env,
        "project secrets",
        &mut warnings,
    );

    let litellm_path = options.litellm_config.or_else(|| {
        merged_env
            .get("YALLM_LITELLM_CONFIG")
            .map(String::as_str)
            .map(str::trim)
            .filter(|s| !s.is_empty())
            .map(PathBuf::from)
    });

    let litellm_models = litellm_path
        .as_deref()
        .map(|path| parse_litellm_config_file(path, &merged_env, &mut warnings))
        .unwrap_or_default();

    LoadedConfig {
        env: merged_env,
        litellm_models,
        warnings,
    }
}

fn apply_toml_file(
    path: &Path,
    env_map: &mut HashMap<String, String>,
    label: &str,
    warnings: &mut Vec<String>,
) {
    let raw = match fs::read_to_string(path) {
        Ok(s) => s,
        Err(_) => return,
    };
    let cfg: ConfigFile = match toml::from_str(&raw) {
        Ok(c) => c,
        Err(e) => {
            warnings.push(format!("yallm-config: {label} parse error: {e}"));
            return;
        }
    };
    for (key, val) in cfg.env {
        env_map.insert(key, val);
    }
}

fn apply_dotenv(path: &Path, env_map: &mut HashMap<String, String>, warnings: &mut Vec<String>) {
    let raw = match fs::read_to_string(path) {
        Ok(s) => s,
        Err(_) => return,
    };
    for (key, val) in parse_dotenv(&raw, warnings) {
        // Only fill keys absent from OS env (or earlier layers); never override.
        env_map.entry(key).or_insert(val);
    }
}

/// Apply every TOML file in `dir` whose name ends with `suffix`.
/// Files are sorted by name for deterministic ordering; later files overwrite earlier ones.
fn apply_toml_glob(
    dir: &Path,
    suffix: &str,
    env_map: &mut HashMap<String, String>,
    label: &str,
    warnings: &mut Vec<String>,
) {
    let entries = match fs::read_dir(dir) {
        Ok(e) => e,
        Err(_) => return,
    };
    let mut files: Vec<PathBuf> = entries
        .filter_map(Result::ok)
        .map(|e| e.path())
        .filter(|p| {
            p.is_file()
                && p.file_name()
                    .and_then(|n| n.to_str())
                    .is_some_and(|n| n.ends_with(suffix))
        })
        .collect();
    files.sort();
    for path in files {
        apply_toml_file(&path, env_map, label, warnings);
    }
}

fn parse_dotenv(raw: &str, warnings: &mut Vec<String>) -> HashMap<String, String> {
    let mut out = HashMap::new();
    for (idx, line) in raw.lines().enumerate() {
        let line = line.trim();
        if line.is_empty() || line.starts_with('#') {
            continue;
        }
        let Some((key, val)) = line.split_once('=') else {
            warnings.push(format!(
                "yallm-config: ignored malformed .env line {}",
                idx + 1
            ));
            continue;
        };
        let key = key.trim();
        if key.is_empty() {
            warnings.push(format!(
                "yallm-config: ignored empty .env key on line {}",
                idx + 1
            ));
            continue;
        }
        out.insert(key.to_string(), unquote_env_value(val.trim()));
    }
    out
}

fn unquote_env_value(value: &str) -> String {
    if value.len() >= 2
        && ((value.starts_with('"') && value.ends_with('"'))
            || (value.starts_with('\'') && value.ends_with('\'')))
    {
        value[1..value.len() - 1].to_string()
    } else {
        value.to_string()
    }
}

fn user_config_path(env_map: &HashMap<String, String>) -> Option<PathBuf> {
    let home = env_map
        .get("HOME")
        .or_else(|| env_map.get("USERPROFILE"))
        .filter(|s| !s.is_empty())?;
    Some(PathBuf::from(home).join(".yallm").join("config.toml"))
}

fn parse_litellm_config_file(
    path: &Path,
    env_map: &HashMap<String, String>,
    warnings: &mut Vec<String>,
) -> Vec<LiteLlmModel> {
    let raw = match fs::read_to_string(path) {
        Ok(s) => s,
        Err(e) => {
            warnings.push(format!(
                "yallm-config: failed to read LiteLLM config {}: {e}",
                path.display()
            ));
            return Vec::new();
        }
    };
    parse_litellm_config_str(&raw, env_map, warnings)
}

pub fn parse_litellm_config_str(
    raw: &str,
    env_map: &HashMap<String, String>,
    warnings: &mut Vec<String>,
) -> Vec<LiteLlmModel> {
    let cfg: LiteLlmConfigFile = match serde_yaml_ng::from_str(raw) {
        Ok(cfg) => cfg,
        Err(e) => {
            warnings.push(format!("yallm-config: LiteLLM config parse error: {e}"));
            return Vec::new();
        }
    };

    let mut seen = HashSet::new();
    let mut out = Vec::new();
    for entry in cfg.model_list {
        let model_name = entry.model_name.unwrap_or_default().trim().to_string();
        if model_name.is_empty() {
            warnings.push("yallm-config: skipped LiteLLM model with empty model_name".to_string());
            continue;
        }
        if model_name == "*" {
            warnings.push("yallm-config: skipped LiteLLM wildcard model_name '*'".to_string());
            continue;
        }

        // yallm_params wins over litellm_params when both are present.
        let resolved = match entry.yallm_params {
            Some(yp) => resolve_from_yallm_params(&model_name, yp, env_map, warnings),
            None => {
                resolve_from_litellm_params(&model_name, entry.litellm_params, env_map, warnings)
            }
        };
        let Some(model) = resolved else {
            continue;
        };

        if !seen.insert(model.model_name.clone()) {
            warnings.push(format!(
                "yallm-config: skipped duplicate model_name '{}'",
                model.model_name
            ));
            continue;
        }

        out.push(model);
    }
    out
}

fn resolve_from_yallm_params(
    model_name: &str,
    params: YallmParams,
    env_map: &HashMap<String, String>,
    warnings: &mut Vec<String>,
) -> Option<LiteLlmModel> {
    let upstream_model = params.model.unwrap_or_default().trim().to_string();
    if upstream_model.is_empty() || upstream_model == "*" {
        warnings.push(format!(
            "yallm-config: skipped model '{model_name}' with empty or wildcard yallm_params.model"
        ));
        return None;
    }
    // Provider must be explicit in yallm_params — no prefix-encoded fallback.
    let Some(provider_str) = params
        .provider
        .as_deref()
        .map(str::trim)
        .filter(|s| !s.is_empty())
    else {
        warnings.push(format!(
            "yallm-config: skipped model '{model_name}' with missing yallm_params.provider"
        ));
        return None;
    };
    let Some(provider) = parse_yallm_provider(provider_str) else {
        warnings.push(format!(
            "yallm-config: skipped model '{model_name}' with unsupported yallm_params.provider '{provider_str}'"
        ));
        return None;
    };

    let api_base = params
        .api_base
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_base", false, warnings));
    let api_key = params
        .api_key
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_key", true, warnings));
    let api_version = params
        .api_version
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_version", false, warnings));

    Some(LiteLlmModel {
        model_name: model_name.to_string(),
        provider,
        upstream_model,
        api_base,
        api_key,
        api_version,
    })
}

fn resolve_from_litellm_params(
    model_name: &str,
    params: LiteLlmParams,
    env_map: &HashMap<String, String>,
    warnings: &mut Vec<String>,
) -> Option<LiteLlmModel> {
    let litellm_model = params.model.unwrap_or_default();
    if litellm_model.trim().is_empty() || litellm_model.trim() == "*" {
        warnings.push(format!(
            "yallm-config: skipped LiteLLM model '{model_name}' with empty or wildcard upstream model"
        ));
        return None;
    }

    let Some((provider, upstream_model)) =
        infer_provider_and_model(&litellm_model, params.custom_llm_provider.as_deref())
    else {
        warnings.push(format!(
            "yallm-config: skipped unsupported LiteLLM model '{model_name}' ({litellm_model})"
        ));
        return None;
    };

    let api_base = params
        .api_base
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_base", false, warnings));
    let api_key = params
        .api_key
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_key", true, warnings));
    let api_version = params
        .api_version
        .as_deref()
        .and_then(|v| resolve_config_value(v, env_map, model_name, "api_version", false, warnings));

    Some(LiteLlmModel {
        model_name: model_name.to_string(),
        provider,
        upstream_model,
        api_base,
        api_key,
        api_version,
    })
}

fn parse_yallm_provider(s: &str) -> Option<LiteLlmProvider> {
    match s.trim().to_ascii_lowercase().as_str() {
        "openai" => Some(LiteLlmProvider::OpenAI),
        "anthropic" => Some(LiteLlmProvider::Anthropic),
        "ollama" => Some(LiteLlmProvider::Ollama),
        _ => None,
    }
}

fn infer_provider_and_model(
    model: &str,
    custom_provider: Option<&str>,
) -> Option<(LiteLlmProvider, String)> {
    let model = model.trim();
    let model_prefix = model.split_once('/').map(|(prefix, _)| prefix);
    let provider = custom_provider
        .map(str::trim)
        .filter(|s| !s.is_empty())
        .or(model_prefix)
        .unwrap_or("openai")
        .to_ascii_lowercase();

    match provider.as_str() {
        "openai" | "openai_compatible" | "openai-compatible" | "openai_like" | "openai-like" => {
            Some((LiteLlmProvider::OpenAI, strip_model_prefix(model, "openai")))
        }
        "anthropic" => Some((
            LiteLlmProvider::Anthropic,
            strip_model_prefix(model, "anthropic"),
        )),
        "ollama" => Some((LiteLlmProvider::Ollama, strip_model_prefix(model, "ollama"))),
        _ => None,
    }
}

fn strip_model_prefix(model: &str, provider: &str) -> String {
    model
        .strip_prefix(&format!("{provider}/"))
        .unwrap_or(model)
        .to_string()
}

fn resolve_config_value(
    value: &str,
    env_map: &HashMap<String, String>,
    model_name: &str,
    field: &str,
    warn_literal_secret: bool,
    warnings: &mut Vec<String>,
) -> Option<String> {
    let value = value.trim();
    if value.is_empty() || value.eq_ignore_ascii_case("none") {
        return None;
    }

    if let Some(name) = value.strip_prefix("os.environ/") {
        return env_lookup(name, env_map, model_name, field, warnings);
    }

    if let Some(name) = value.strip_prefix("${").and_then(|v| v.strip_suffix('}')) {
        return env_lookup(name, env_map, model_name, field, warnings);
    }

    if warn_literal_secret {
        warnings.push(format!(
            "yallm-config: LiteLLM model '{model_name}' uses a literal {field}; prefer os.environ/VAR"
        ));
    }
    Some(value.to_string())
}

fn env_lookup(
    name: &str,
    env_map: &HashMap<String, String>,
    model_name: &str,
    field: &str,
    warnings: &mut Vec<String>,
) -> Option<String> {
    let name = name.trim();
    match env_map.get(name).map(String::as_str).map(str::trim) {
        Some(value) if !value.is_empty() => Some(value.to_string()),
        _ => {
            warnings.push(format!(
                "yallm-config: LiteLLM model '{model_name}' references missing env var {name} for {field}"
            ));
            None
        }
    }
}

#[derive(Debug, Deserialize, Default)]
struct LiteLlmConfigFile {
    #[serde(default)]
    model_list: Vec<LiteLlmEntry>,
}

#[derive(Debug, Deserialize, Default)]
struct LiteLlmEntry {
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    model_name: Option<String>,
    /// yallm-native parameters. Takes priority over `litellm_params` when both
    /// are present on the same entry. Provider must be specified explicitly via
    /// the `provider` field instead of as a `provider/model` prefix.
    #[serde(default)]
    yallm_params: Option<YallmParams>,
    /// LiteLLM-compatible parameters. Used as a fallback when `yallm_params` is
    /// absent. Provider may be encoded as a `provider/model` prefix or via
    /// `custom_llm_provider`.
    #[serde(default)]
    litellm_params: LiteLlmParams,
}

#[derive(Debug, Deserialize, Default)]
struct YallmParams {
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    provider: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    model: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_base: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_key: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_version: Option<String>,
}

#[derive(Debug, Deserialize, Default)]
struct LiteLlmParams {
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    model: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_base: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_key: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    api_version: Option<String>,
    #[serde(default, deserialize_with = "deserialize_optional_string")]
    custom_llm_provider: Option<String>,
}

fn deserialize_optional_string<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>
where
    D: Deserializer<'de>,
{
    let value = Option::<serde_yaml_ng::Value>::deserialize(deserializer)?;
    Ok(value.and_then(yaml_value_to_string))
}

fn yaml_value_to_string(value: serde_yaml_ng::Value) -> Option<String> {
    match value {
        serde_yaml_ng::Value::Null => None,
        serde_yaml_ng::Value::Bool(v) => Some(v.to_string()),
        serde_yaml_ng::Value::Number(v) => Some(v.to_string()),
        serde_yaml_ng::Value::String(v) => Some(v),
        _ => None,
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn parse_empty_toml() {
        let c: ConfigFile = toml::from_str("").unwrap();
        assert!(c.env.is_empty());
    }

    #[test]
    fn parse_env_section() {
        let c: ConfigFile = toml::from_str(
            r#"
[env]
ANTHROPIC_API_KEY = "sk-ant-test"
YALLM_MODE = "proxy"
"#,
        )
        .unwrap();
        assert_eq!(c.env.get("ANTHROPIC_API_KEY").unwrap(), "sk-ant-test");
        assert_eq!(c.env.get("YALLM_MODE").unwrap(), "proxy");
    }

    #[test]
    fn dotenv_parses_simple_values() {
        let mut warnings = Vec::new();
        let env = parse_dotenv(
            r#"TEST_DOTENV_KEY=dotenv_value
ANOTHER_KEY="quoted val"
"#,
            &mut warnings,
        );

        assert_eq!(env.get("TEST_DOTENV_KEY").unwrap(), "dotenv_value");
        assert_eq!(env.get("ANOTHER_KEY").unwrap(), "quoted val");
        assert!(warnings.is_empty());
    }

    #[test]
    fn litellm_parses_supported_models_and_env_key() {
        let mut env = HashMap::new();
        env.insert("OPENAI_KEY".to_string(), "sk-env".to_string());
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: gpt-alias
    litellm_params:
      model: openai/gpt-4o
      api_base: https://openai-compatible.test/v1
      api_key: os.environ/OPENAI_KEY
      ignored_field: true
  - model_name: claude-alias
    litellm_params:
      model: anthropic/claude-3-haiku-20240307
      api_key: none
  - model_name: llama-alias
    litellm_params:
      model: ollama/llama3
"#,
            &env,
            &mut warnings,
        );

        assert_eq!(models.len(), 3);
        assert_eq!(models[0].model_name, "gpt-alias");
        assert_eq!(models[0].provider, LiteLlmProvider::OpenAI);
        assert_eq!(models[0].upstream_model, "gpt-4o");
        assert_eq!(models[0].api_key.as_deref(), Some("sk-env"));
        assert_eq!(models[1].provider, LiteLlmProvider::Anthropic);
        assert_eq!(models[1].api_key, None);
        assert_eq!(models[2].provider, LiteLlmProvider::Ollama);
        assert!(warnings.is_empty());
    }

    #[test]
    fn litellm_warns_for_literal_api_key() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: literal
    litellm_params:
      model: gpt-4o
      api_key: sk-literal
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 1);
        assert_eq!(models[0].api_key.as_deref(), Some("sk-literal"));
        assert!(warnings.iter().any(|w| w.contains("literal api_key")));
    }

    #[test]
    fn litellm_missing_env_reference_leaves_key_unset() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: missing
    litellm_params:
      model: gpt-4o
      api_key: ${MISSING_OPENAI_KEY}
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 1);
        assert_eq!(models[0].api_key, None);
        assert!(warnings.iter().any(|w| w.contains("MISSING_OPENAI_KEY")));
    }

    #[test]
    fn litellm_skips_unsupported_and_duplicate_models() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: gpt
    litellm_params:
      model: gpt-4o
  - model_name: gpt
    litellm_params:
      model: openai/gpt-4o-mini
  - model_name: azure-gpt
    litellm_params:
      model: azure/gpt-4o
      api_key: os.environ/AZURE_API_KEY
      extra: ignored
  - model_name: mixed
    litellm_params:
      model: azure/gpt-4o
  - model_name: mixed
    litellm_params:
      model: gpt-4o
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 2);
        assert_eq!(models[0].model_name, "gpt");
        assert_eq!(models[1].model_name, "mixed");
        assert!(warnings.iter().any(|w| w.contains("duplicate")));
        assert!(warnings.iter().any(|w| w.contains("unsupported")));
    }

    #[test]
    fn yallm_params_takes_priority_over_litellm_params() {
        // Same entry has both blocks; yallm_params wins for every field.
        let mut env = HashMap::new();
        env.insert("YALLM_KEY".to_string(), "yallm-secret".to_string());
        env.insert("LITELLM_KEY".to_string(), "litellm-secret".to_string());
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: dual
    yallm_params:
      provider: anthropic
      model: claude-yallm
      api_base: https://yallm.test
      api_key: os.environ/YALLM_KEY
      api_version: "2025-01-01"
    litellm_params:
      model: openai/gpt-litellm
      api_base: https://litellm.test
      api_key: os.environ/LITELLM_KEY
      api_version: "2020-01-01"
"#,
            &env,
            &mut warnings,
        );

        assert_eq!(models.len(), 1);
        assert_eq!(models[0].provider, LiteLlmProvider::Anthropic);
        assert_eq!(models[0].upstream_model, "claude-yallm");
        assert_eq!(models[0].api_base.as_deref(), Some("https://yallm.test"));
        assert_eq!(models[0].api_key.as_deref(), Some("yallm-secret"));
        assert_eq!(models[0].api_version.as_deref(), Some("2025-01-01"));
        assert!(warnings.is_empty());
    }

    #[test]
    fn yallm_params_requires_explicit_provider() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: bad
    yallm_params:
      model: gpt-4o
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 0);
        assert!(
            warnings
                .iter()
                .any(|w| w.contains("missing yallm_params.provider"))
        );
    }

    #[test]
    fn yallm_params_rejects_unknown_provider() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: nope
    yallm_params:
      provider: bedrock
      model: anthropic.claude-3
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 0);
        assert!(warnings.iter().any(|w| w.contains("'bedrock'")));
    }

    #[test]
    fn entry_without_yallm_params_falls_back_to_litellm_params() {
        let mut warnings = Vec::new();
        let models = parse_litellm_config_str(
            r#"
model_list:
  - model_name: legacy
    litellm_params:
      model: anthropic/claude-x
"#,
            &HashMap::new(),
            &mut warnings,
        );

        assert_eq!(models.len(), 1);
        assert_eq!(models[0].provider, LiteLlmProvider::Anthropic);
        assert_eq!(models[0].upstream_model, "claude-x");
    }

    #[test]
    fn dotenv_does_not_override_existing_env() {
        let dir = tmpdir("yallm_dotenv_no_override");
        let env_path = dir.join(".env");
        fs::write(&env_path, "FOO=from_dotenv\nBAR=from_dotenv\n").unwrap();

        let mut env_map = HashMap::new();
        env_map.insert("FOO".to_string(), "from_os".to_string());
        let mut warnings = Vec::new();
        apply_dotenv(&env_path, &mut env_map, &mut warnings);

        assert_eq!(env_map.get("FOO").unwrap(), "from_os");
        assert_eq!(env_map.get("BAR").unwrap(), "from_dotenv");
        assert!(warnings.is_empty());
        let _ = fs::remove_dir_all(&dir);
    }

    #[test]
    fn toml_glob_applies_local_overrides_in_order() {
        let dir = tmpdir("yallm_toml_glob");
        fs::write(
            dir.join("01.local.toml"),
            "[env]\nFOO = \"layer1\"\nBAR = \"layer1\"\n",
        )
        .unwrap();
        fs::write(dir.join("02.local.toml"), "[env]\nFOO = \"layer2\"\n").unwrap();
        // Non-matching file ignored.
        fs::write(dir.join("ignore.toml"), "[env]\nFOO = \"ignored\"\n").unwrap();

        let mut env_map = HashMap::new();
        let mut warnings = Vec::new();
        apply_toml_glob(&dir, ".local.toml", &mut env_map, "local", &mut warnings);

        assert_eq!(env_map.get("FOO").unwrap(), "layer2");
        assert_eq!(env_map.get("BAR").unwrap(), "layer1");
        assert!(warnings.is_empty());
        let _ = fs::remove_dir_all(&dir);
    }

    #[test]
    fn secrets_toml_overrides_config_toml() {
        let dir = tmpdir("yallm_secrets_layer");
        fs::write(
            dir.join("config.toml"),
            "[env]\nANTHROPIC_API_KEY = \"public\"\n",
        )
        .unwrap();
        fs::write(
            dir.join("secrets.toml"),
            "[env]\nANTHROPIC_API_KEY = \"sk-real\"\n",
        )
        .unwrap();

        let mut env_map = HashMap::new();
        let mut warnings = Vec::new();
        apply_toml_file(
            &dir.join("config.toml"),
            &mut env_map,
            "project",
            &mut warnings,
        );
        apply_toml_file(
            &dir.join("secrets.toml"),
            &mut env_map,
            "secrets",
            &mut warnings,
        );

        assert_eq!(env_map.get("ANTHROPIC_API_KEY").unwrap(), "sk-real");
        let _ = fs::remove_dir_all(&dir);
    }

    fn tmpdir(name: &str) -> PathBuf {
        let nonce = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map(|d| d.as_nanos())
            .unwrap_or(0);
        let dir = env::temp_dir().join(format!("{name}_{nonce}_{}", std::process::id()));
        fs::create_dir_all(&dir).unwrap();
        dir
    }
}