xsil 0.2.2

Reference CLI for the .xsil RISC-V ISA extension package format. Scaffold, build, run, test and publish custom RISC-V instruction packages.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
//! ExtenSilica CLI — publish, install, run, and test `.xsil` packages.

use clap::{Parser, Subcommand};
use colored::*;
use indicatif::{ProgressBar, ProgressStyle};
use std::fs;
use std::path::PathBuf;
use anyhow::{bail, Context, Result};
use simplelog::*;
use std::fs::File;
use std::io::Read;
use semver::Version;
use std::collections::HashSet;

mod types;
mod registry;
mod manager;
mod init;
mod wizard;
mod constants;
mod resolver;

use registry::RegistryClient;
use manager::ExtensionManager;
use types::{Manifest, RegistryPackage, RegistryVersion};

// ── CLI definition ────────────────────────────────────────────────────────────

#[derive(Parser)]
#[command(
    name = "xsil",
    bin_name = "xsil",
    about = "ExtenSilica CLI — the package manager for .xsil packages",
    long_about = "Publish, install, run, and test .xsil packages from the ExtenSilica registry.",
    version
)]
struct Cli {
    #[command(subcommand)]
    command: Commands,

    /// Validate and pack without uploading or executing anything.
    #[arg(long, global = true)]
    dry_run: bool,
}

#[derive(Subcommand, Debug)]
enum Commands {
    /// Authenticate with the registry (stores an API token locally)
    ///
    /// The CLI now creates a *named* API token on each login so you can see it
    /// in `/dashboard/tokens` and revoke it individually. Other devices /
    /// browser sessions for the same account keep working. Default name:
    /// `xsil-cli @ <hostname>`.
    Login {
        /// Override the token label shown in /dashboard/tokens.
        #[arg(long, value_name = "NAME")]
        name: Option<String>,
    },

    /// Invalidate the current API token and clear local credentials
    Logout,

    /// Print the currently authenticated user
    Whoami,

    /// Manage API tokens (list, create, revoke)
    ///
    /// Each user can hold many independent tokens — one per device, CLI
    /// install, or bot. Revoking one does not affect the others.
    Token {
        #[command(subcommand)]
        action: TokenCommand,
    },

    /// Publish a package to the registry
    ///
    /// Accepts an unpacked directory (with manifest.json) or a pre-built .xsil file.
    Publish {
        /// Path to an unpacked package directory or a .xsil archive
        path: String,
        /// Override message included in the version entry
        #[arg(long, default_value = "")]
        changelog: String,
    },

    /// Create a new local package directory (manifest, sim/, tests/, docs/, toolchain stub)
    Init {
        /// Unscoped package slug: lowercase letters, digits, hyphens (also the directory name)
        name: String,
        /// Parent directory for `<name>/` (default: current working directory)
        #[arg(long, value_name = "DIR")]
        parent: Option<PathBuf>,
        /// Remove an existing `<parent>/<name>` directory before creating files
        #[arg(long)]
        force: bool,
        /// Value for `manifest.author` (default: `git config user.name`, else `your-username`)
        #[arg(long, value_name = "NAME")]
        author: Option<String>,
    },

    /// Extension Wizard — like `init` plus opcodes.json, examples/, and Spike-friendly templates.
    ///
    /// Runs interactively by default (asks for description, ISA, license, custom
    /// instructions, optional extra targets). Pass `--non-interactive` with the
    /// flags below to script it.
    New {
        /// Unscoped package slug (also the directory name)
        name: String,
        /// Parent directory for `<name>/` (default: current working directory)
        #[arg(long, value_name = "DIR")]
        parent: Option<PathBuf>,
        /// Remove an existing `<parent>/<name>` directory before creating files
        #[arg(long)]
        force: bool,
        /// Skip prompts; use defaults + flags only
        #[arg(long)]
        non_interactive: bool,
        /// `manifest.description` (one line)
        #[arg(long, value_name = "TEXT")]
        description: Option<String>,
        /// `manifest.author`
        #[arg(long, value_name = "NAME")]
        author: Option<String>,
        /// Initial semver, default `0.1.0`
        #[arg(long, value_name = "X.Y.Z")]
        version: Option<String>,
        /// Base ISA (e.g. RV64GC, RV32IMAFC). Default: `RV64GC`
        #[arg(long, value_name = "ISA")]
        isa: Option<String>,
        /// SPDX license id, default `Apache-2.0`
        #[arg(long, value_name = "LICENSE")]
        license: Option<String>,
        /// Repository URL (required, http or https). The wizard will prompt
        /// for it when missing in interactive mode.
        #[arg(long, value_name = "URL")]
        repository: Option<String>,
        /// Optional homepage URL (http or https)
        #[arg(long, value_name = "URL")]
        homepage: Option<String>,
        /// Honest classification of the extension's relationship to the
        /// RISC-V standard. One of: ratified, draft, vendor, research, custom.
        ///
        /// Required (the wizard prompts for it in interactive mode). Don't
        /// label something `ratified` unless RISC-V International has frozen
        /// the spec — the registry checks this and surfaces it on the
        /// package page.
        #[arg(long = "standard-status", value_name = "STATUS")]
        standard_status: Option<String>,
        /// Free-text spec authority (e.g. "RISC-V International",
        /// "T-Head / XuanTie", "University of Michigan"). Required.
        #[arg(long, value_name = "TEXT")]
        authority: Option<String>,
        /// Add `qemu` placeholder target with `status: planned`
        #[arg(long)]
        with_qemu: bool,
        /// Add `binutils` placeholder target with `status: planned`
        #[arg(long)]
        with_binutils: bool,
        /// Add `llvm` placeholder target with `status: planned`
        #[arg(long)]
        with_llvm: bool,
    },

    /// Download and install a package under ~/.extensilica/extensions/
    Install {
        /// Registry slug, slug@version, .xsil file path, or unpacked directory
        package: String,
        #[arg(long, help = "Reinstall even if this version is already present")]
        force: bool,
        #[arg(long, help = "Install yanked versions (not recommended)")]
        override_security: bool,
    },

    /// Fetch, verify, and execute the package entry point
    Run {
        /// Registry slug, slug@version, .xsil file path, or unpacked directory
        package: String,
    },

    /// Fetch, verify, and run the package test suite
    Test {
        /// Registry slug, slug@version, .xsil file path, or unpacked directory
        package: String,
    },

    /// Display registry metadata and local install status for a package
    Info {
        /// Registry slug or local .xsil path
        package: String,
    },

    /// Search the registry by name, description, or keyword
    Search {
        /// Search query
        query: String,
        #[arg(long, default_value = "10", help = "Maximum results to display")]
        limit: usize,
    },

    /// Yank a published version so it is excluded from default installs
    ///
    /// Yanked versions remain accessible with `xsil install <pkg>@<ver> --override-security`
    /// but are hidden from version resolution and marked in `xsil info` output.
    ///
    /// Examples:
    ///   xsil yank rvx-demo@1.0.0
    ///   xsil yank rvx-demo@1.0.0 --reason "Critical bug in sim/run.sh"
    ///   xsil yank @risc-v-labs/riscv-aes@1.0.0
    ///   xsil yank rvx-demo@1.0.0 --restore
    Yank {
        /// Package identifier including version: slug@x.y.z or @scope/pkg@x.y.z
        package_version: String,

        /// Short explanation shown in registry UI and `xsil info` output
        #[arg(long, short = 'r', value_name = "REASON")]
        reason: Option<String>,

        /// Restore (un-yank) the version instead of yanking it
        #[arg(long)]
        restore: bool,
    },
}

#[derive(Subcommand, Debug)]
enum TokenCommand {
    /// List every API token on the current account (live and revoked)
    List,

    /// Create a new named API token. The raw value is printed once.
    Create {
        /// Human-recognisable label shown in /dashboard/tokens (1–80 chars)
        name: String,
    },

    /// Revoke an API token by id (find it with `xsil token list`)
    Revoke {
        /// Numeric id of the token to revoke
        id: u32,
    },
}

// ── Entry points ──────────────────────────────────────────────────────────────

fn main() {
    if let Err(e) = run() {
        eprintln!("{}: {:#}", "error".red().bold(), e);
        std::process::exit(1);
    }
}

fn run() -> Result<()> {
    let cli = Cli::parse();
    let (_config_file, _extensions_dir, root_dir) = setup_paths()?;

    let log_file = root_dir.join("logs").join("cli.log");
    let _ = WriteLogger::init(
        LevelFilter::Info,
        Config::default(),
        File::options()
            .create(true)
            .append(true)
            .open(log_file)
            .unwrap_or_else(|_| std::fs::File::create("/dev/null").unwrap()),
    );

    let registry = RegistryClient::from_config();
    let manager = ExtensionManager::new(root_dir.clone());

    log::info!("CLI command: {:?}", cli.command);

    match &cli.command {
        // ── Auth commands ─────────────────────────────────────────────────────
        Commands::Login { name } => {
            registry.login(name.as_deref())?;
        }

        Commands::Logout => {
            registry.logout()?;
        }

        Commands::Whoami => {
            let user = registry.whoami()?;
            println!("  Username : {}", user.username.bold());
            println!("  Email    : {}", user.email);
            if let Some(bio) = &user.bio {
                if !bio.is_empty() {
                    println!("  Bio      : {}", bio);
                }
            }
            if let Some(created) = &user.created_at {
                println!("  Member since : {}", created);
            }
        }

        Commands::Token { action } => {
            cmd_token(&registry, action)?;
        }

        // ── Publish ───────────────────────────────────────────────────────────
        Commands::Publish { path, changelog } => {
            cmd_publish(&registry, &manager, path, changelog, cli.dry_run)?;
        }

        Commands::Init {
            name,
            parent,
            force,
            author,
        } => {
            if cli.dry_run {
                println!(
                    "{} Would create package skeleton at {}/{}",
                    "".green(),
                    parent
                        .as_ref()
                        .map(|p| p.display().to_string())
                        .unwrap_or_else(|| ".".to_string()),
                    name
                );
            } else {
                let created = init::cmd_init(&manager, name, parent.as_deref(), *force, author.as_deref())?;
                println!(
                    "{} Created package skeleton at {}",
                    "".green(),
                    created.display().to_string().bold()
                );
                println!("  {}", "Next:".dimmed());
                println!("    cd {}", created.display());
                println!("    xsil run .");
                println!("    xsil test .");
                println!("    xsil publish . --dry-run");
            }
        }

        Commands::New {
            name,
            parent,
            force,
            non_interactive,
            description,
            author,
            version,
            isa,
            license,
            repository,
            homepage,
            standard_status,
            authority,
            with_qemu,
            with_binutils,
            with_llvm,
        } => {
            if cli.dry_run {
                println!(
                    "{} Would create wizard package at {}/{}",
                    "".green(),
                    parent
                        .as_ref()
                        .map(|p| p.display().to_string())
                        .unwrap_or_else(|| ".".to_string()),
                    name
                );
            } else {
                let args = wizard::WizardArgs {
                    name: name.clone(),
                    parent: parent.clone(),
                    force: *force,
                    non_interactive: *non_interactive,
                    author: author.clone(),
                    description: description.clone(),
                    version: version.clone(),
                    isa: isa.clone(),
                    license: license.clone(),
                    repository: repository.clone(),
                    homepage: homepage.clone(),
                    standard_status: standard_status.clone(),
                    authority: authority.clone(),
                    instructions: vec![],
                    targets: wizard::WizardTargets {
                        qemu: *with_qemu,
                        binutils: *with_binutils,
                        llvm: *with_llvm,
                    },
                };
                let created = wizard::cmd_new(&manager, args)?;
                println!(
                    "{} Created wizard package at {}",
                    "".green(),
                    created.display().to_string().bold()
                );
                println!("  {}", "Next:".dimmed());
                println!("    cd {}", created.display());
                println!("    xsil run .");
                println!("    xsil test .");
                println!("    xsil publish . --dry-run");
            }
        }

        // ── Install ───────────────────────────────────────────────────────────
        Commands::Install {
            package,
            force,
            override_security,
        } => {
            let _lock = manager.acquire_lock()?;
            cmd_install(&registry, &manager, package, *force, *override_security, cli.dry_run)?;
        }

        // ── Run ───────────────────────────────────────────────────────────────
        Commands::Run { package } => {
            let (work_dir, manifest, cleanup) = resolve_and_load(&registry, &manager, package)?;
            let entry = manifest
                .effective_entry()
                .context("manifest has no entry (set `execution.entry` or legacy `entry`)")?;
            let resolved = resolver::resolve_execution_env(&manifest, &work_dir, Some(&registry))?;
            let exec_env: std::collections::HashMap<String, String> = manifest
                .execution
                .as_ref()
                .and_then(|e| e.get("env"))
                .and_then(|v| v.as_object())
                .map(|o| {
                    o.iter()
                        .filter_map(|(k, v)| v.as_str().map(|s| (k.clone(), s.to_string())))
                        .collect()
                })
                .unwrap_or_default();
            if cli.dry_run {
                println!("{} Dry run: would execute entry: {}", "".green(), entry);
            } else {
                println!("{} Running: {}", "".blue(), entry);
                manager.run_shell_in_package_resolved(&work_dir, &entry, &resolved, &exec_env)?;
                println!("{} Done.", "".green());
            }
            if cleanup {
                fs::remove_dir_all(&work_dir).ok();
            }
        }

        // ── Test ──────────────────────────────────────────────────────────────
        Commands::Test { package } => {
            let (work_dir, manifest, cleanup) = resolve_and_load(&registry, &manager, package)?;
            let test_cmd = if let Some(te) = manifest.effective_test_entry() {
                te
            } else if work_dir.join("tests/run.sh").is_file() {
                "tests/run.sh".to_string()
            } else {
                if cleanup {
                    fs::remove_dir_all(&work_dir).ok();
                }
                bail!("No test entry: set `execution.testEntry` (or legacy `testEntry`) or add tests/run.sh");
            };
            let resolved = resolver::resolve_execution_env(&manifest, &work_dir, Some(&registry))?;
            let exec_env: std::collections::HashMap<String, String> = manifest
                .execution
                .as_ref()
                .and_then(|e| e.get("env"))
                .and_then(|v| v.as_object())
                .map(|o| {
                    o.iter()
                        .filter_map(|(k, v)| v.as_str().map(|s| (k.clone(), s.to_string())))
                        .collect()
                })
                .unwrap_or_default();
            if cli.dry_run {
                println!("{} Dry run: would run tests: {}", "".green(), test_cmd);
            } else {
                println!("{} Running tests: {}", "".blue(), test_cmd);
                manager.run_shell_in_package_resolved(&work_dir, &test_cmd, &resolved, &exec_env)?;
                println!("{} Tests passed.", "".green());
            }
            if cleanup {
                fs::remove_dir_all(&work_dir).ok();
            }
        }

        // ── Info ──────────────────────────────────────────────────────────────
        Commands::Info { package } => {
            cmd_info(&registry, &manager, package)?;
        }

        // ── Search ────────────────────────────────────────────────────────────
        Commands::Search { query, limit } => {
            cmd_search(&registry, query, *limit)?;
        }

        // ── Yank ──────────────────────────────────────────────────────────────
        Commands::Yank { package_version, reason, restore } => {
            cmd_yank(&registry, package_version, reason.as_deref(), *restore)?;
        }
    }

    Ok(())
}

// ── Command implementations ───────────────────────────────────────────────────

fn cmd_token(registry: &RegistryClient, action: &TokenCommand) -> Result<()> {
    match action {
        TokenCommand::List => {
            let rows = registry.list_tokens()?;
            if rows.is_empty() {
                println!("No tokens. Run `xsil token create <name>` to mint one.");
                return Ok(());
            }
            let (live, revoked): (Vec<_>, Vec<_>) =
                rows.iter().partition(|r| r.revoked_at.is_none());

            println!("{}", "Active tokens".bold());
            print_token_table(&live);
            if !revoked.is_empty() {
                println!();
                println!("{}", "Revoked tokens".dimmed());
                print_token_table(&revoked);
            }
        }
        TokenCommand::Create { name } => {
            let (raw, row) = registry.create_token(name)?;
            println!("{} Created token {} (id {}).", "".green(), row.name.bold(), row.id);
            println!();
            println!("  {}", "Copy this token NOW — it will not be shown again:".yellow());
            println!("    {}", raw.bold());
            println!();
            println!("  {}", "Use it with the CLI on another machine:".dimmed());
            println!("    xsil login --name \"{}\"  # to mint a separate token interactively", row.name);
            println!("    # or paste the raw value into ~/.config/xsil/config.json");
        }
        TokenCommand::Revoke { id } => {
            let already = registry.revoke_token(*id)?;
            if already {
                println!("{} Token #{} was already revoked.", "i".cyan(), id);
            } else {
                println!("{} Revoked token #{}.", "".green(), id);
            }
        }
    }
    Ok(())
}

fn print_token_table(rows: &[&types::ApiTokenRow]) {
    println!(
        "  {:<6} {:<32} {:<22} {:<22}",
        "id".dimmed(),
        "name".dimmed(),
        "created".dimmed(),
        "last used".dimmed(),
    );
    for row in rows {
        println!(
            "  {:<6} {:<32} {:<22} {:<22}",
            row.id,
            truncate_for_display(&row.name, 32),
            short_iso(&row.created_at),
            row.last_used_at.as_deref().map(short_iso).unwrap_or_else(|| "".to_string()),
        );
    }
}

fn truncate_for_display(s: &str, max: usize) -> String {
    if s.chars().count() <= max {
        s.to_string()
    } else {
        let mut out: String = s.chars().take(max.saturating_sub(1)).collect();
        out.push('');
        out
    }
}

/// Trim an ISO-8601 timestamp to "YYYY-MM-DD HH:MM" for the token table.
fn short_iso(iso: &str) -> String {
    let cleaned = iso.replace('T', " ");
    cleaned.split('.').next().unwrap_or(iso).to_string()
}

fn cmd_publish(
    registry: &RegistryClient,
    manager: &ExtensionManager,
    path: &str,
    changelog: &str,
    dry_run: bool,
) -> Result<()> {
    let input = PathBuf::from(path);

    // Determine if input is a directory or an existing .xsil file.
    // The `from_dir` flag drives how we compute the payload hash below — for
    // directories we hash the source tree, for archives we hash the unpacked
    // contents so the result matches what install/run will recompute.
    let (xsil_bytes, manifest, from_dir) = if input.is_dir() {
        // Validate manifest.
        let manifest_path = input.join("manifest.json");
        if !manifest_path.exists() {
            bail!("manifest.json not found in {}", input.display());
        }
        let content = fs::read_to_string(&manifest_path)?;
        let manifest: Manifest = serde_json::from_str(&content)
            .context("manifest.json is not valid JSON")?;

        // Validate required fields.
        validate_publish_manifest(&manifest)?;

        println!("{} Packing {}...", "".blue(), input.display());
        let bytes = manager.pack_directory(&input)?;
        (bytes, manifest, true)
    } else if input.extension().map_or(false, |e| e == "xsil") {
        let bytes = fs::read(&input).context("Failed to read .xsil file")?;
        // Extract manifest from the archive.
        let manifest = extract_manifest_from_bytes(&bytes)?;
        validate_publish_manifest(&manifest)?;
        (bytes, manifest, false)
    } else {
        bail!("Expected a directory or a .xsil file, got: {}", path);
    };

    let slug = &manifest.name;
    let version = &manifest.version;
    let isa = manifest.isa.as_deref().unwrap_or("");
    let targets_json = manifest
        .targets
        .as_ref()
        .map(|t| t.to_string())
        .unwrap_or_else(|| "{}".to_string());
    let toolchain = manifest
        .toolchain
        .as_ref()
        .map(|t| t.to_string())
        .unwrap_or_default();
    let keywords_csv = manifest
        .keywords
        .as_deref()
        .map(|kw| kw.join(","))
        .unwrap_or_default();

    // Compute checksums.  Choose the source by input kind: source-tree hash
    // for directories, unpacked-archive hash for `.xsil` files.  Previously
    // both branches called `compute_payload_hash(path)`; for a `.xsil` file
    // that returned the SHA-256 of zero bytes (`e3b0c44…`) because the file
    // walker silently treats non-directory paths as empty, which the backend
    // then rejected as a checksum mismatch.
    let checksum_payload = if from_dir {
        manager.compute_payload_hash(&input)?
    } else {
        manager.compute_payload_hash_from_archive_bytes(&xsil_bytes)?
    };
    let checksum_archive = manager.compute_archive_checksum(&xsil_bytes);
    let size = xsil_bytes.len() as u64;

    println!(
        "{} {} v{} ({} bytes)",
        "".green(),
        slug.bold(),
        version.cyan(),
        size
    );
    println!("  checksumPayload : sha256:{}", checksum_payload);
    println!("  checksumArchive : sha256:{}", checksum_archive);

    if dry_run {
        println!("{} Dry run — no upload performed.", "".green());
        return Ok(());
    }

    println!("{} Uploading to registry...", "".blue());
    let result = registry.publish(
        slug,
        version,
        changelog,
        isa,
        &targets_json,
        &toolchain,
        &keywords_csv,
        &format!("sha256:{}", checksum_payload),
        &format!("sha256:{}", checksum_archive),
        size,
        xsil_bytes,
    )?;

    let url = result
        .get("xsilUrl")
        .and_then(|v| v.as_str())
        .unwrap_or("(registry)");

    println!(
        "{} Published: {} v{}\n  {}",
        "".green(),
        slug.bold(),
        version.cyan(),
        url
    );

    Ok(())
}

fn cmd_install(
    registry: &RegistryClient,
    manager: &ExtensionManager,
    package: &str,
    force: bool,
    override_security: bool,
    dry_run: bool,
) -> Result<()> {
    let path = PathBuf::from(package);

    // Local .xsil file.
    if path.is_file() && path.extension().map_or(false, |e| e == "xsil") {
        println!("{} Installing from file {}...", "".blue(), package);
        let bytes = fs::read(&path).context("Failed to read .xsil file")?;
        let manifest = extract_manifest_from_bytes(&bytes)?;
        if dry_run {
            println!(
                "{} Dry run: would install {} v{}",
                "".green(),
                manifest.name.bold(),
                manifest.version
            );
            return Ok(());
        }
        // Prefetch resolved dependencies before committing install so package is ready immediately.
        let (prefetch_dir, prefetch_manifest) = manager.extract_and_validate_xsil(&bytes)?;
        let prefetch_result = resolver::resolve_execution_env(&prefetch_manifest, &prefetch_dir, Some(registry));
        fs::remove_dir_all(&prefetch_dir).ok();
        prefetch_result?;
        manager.install_extension(&manifest.name, &manifest.version, &bytes, force)?;
        println!(
            "{} Installed {} v{}",
            "".green(),
            manifest.name.bold(),
            manifest.version.cyan()
        );
        return Ok(());
    }

    // Resolve slug (with optional @version).
    let (slug, requested_version) = parse_package_arg(package);

    println!("{} Resolving {}...", "".blue(), slug.bold());
    let pkg = registry.get_package(&slug)?;

    let version = resolve_version(&pkg, requested_version.as_deref(), override_security)?;

    if version.is_yanked && !override_security {
        bail!(
            "Version {} of {} is yanked. Use --override-security to force.",
            version.version,
            slug
        );
    }
    if version.is_yanked {
        println!(
            "{} WARNING: installing yanked version {} (--override-security).",
            "!".red(),
            version.version
        );
    }

    // Downgrade check.
    if let Ok(installed_path) = manager.get_installed_extension_path(&slug) {
        if let Ok(m) = manager.read_manifest(&installed_path) {
            if let (Ok(installed_ver), Ok(target_ver)) = (
                Version::parse(&m.version),
                Version::parse(&version.version),
            ) {
                if target_ver < installed_ver && !force {
                    bail!(
                        "Would install older version ({} < {}). Use --force.",
                        target_ver, installed_ver
                    );
                }
            }
        }
    }

    if dry_run {
        println!(
            "{} Dry run: would install {} v{}",
            "".green(),
            slug.bold(),
            version.version
        );
        return Ok(());
    }

    let pb = progress_spinner("Downloading...");
    let bytes = registry.download_from_url(&version.xsil_url)?;
    pb.finish_with_message("Download complete");

    // Prefetch resolved dependencies before install commit.
    let (prefetch_dir, prefetch_manifest) = manager.extract_and_validate_xsil(&bytes)?;
    let prefetch_result = resolver::resolve_execution_env(&prefetch_manifest, &prefetch_dir, Some(registry));
    fs::remove_dir_all(&prefetch_dir).ok();
    prefetch_result?;

    manager.install_extension(&slug, &version.version, &bytes, force)?;
    println!(
        "{} Installed {} v{}",
        "".green(),
        slug.bold(),
        version.version.cyan()
    );
    Ok(())
}

fn format_resolution_mode(mode: &str) -> String {
    match mode.trim().to_ascii_lowercase().as_str() {
        "bundled" => "bundled — reproducible; no resolved tool downloads".to_string(),
        "resolved" => "resolved — dependencies.tools may be fetched per policy".to_string(),
        "host-dependent" | "host_dependent" | "hostdependent" => {
            "host-dependent — toolchain or host may differ".to_string()
        }
        _ => mode.to_string(),
    }
}

/// Summarise `targets` JSON from the registry (object keys or string array).
fn summarize_registry_targets(raw: Option<&str>) -> Option<String> {
    let s = raw?.trim();
    if s.is_empty() {
        return None;
    }
    let v: serde_json::Value = serde_json::from_str(s).ok()?;
    match v {
        serde_json::Value::Object(map) => {
            let mut keys: Vec<_> = map.keys().map(|k| k.as_str().to_string()).collect();
            keys.sort();
            if keys.is_empty() {
                None
            } else {
                Some(keys.join(", "))
            }
        }
        serde_json::Value::Array(a) => {
            let parts: Vec<String> = a
                .iter()
                .filter_map(|x| x.as_str().map(|s| s.to_string()))
                .collect();
            if parts.is_empty() {
                None
            } else {
                Some(parts.join(", "))
            }
        }
        _ => Some(s.chars().take(96).collect()),
    }
}

fn registry_toolchain_one_line(raw: Option<&str>) -> Option<String> {
    let s = raw?.trim();
    if s.is_empty() {
        return None;
    }
    if s.starts_with('{') {
        if let Ok(v) = serde_json::from_str::<serde_json::Value>(s) {
            let triple = v
                .get("triple")
                .and_then(|x| x.as_str())
                .unwrap_or("")
                .trim();
            let ext = v.get("external").and_then(|x| x.as_bool()).unwrap_or(false);
            let mut out = if triple.is_empty() {
                v.to_string().chars().take(120).collect::<String>()
            } else if ext {
                format!("{triple} (external)")
            } else {
                format!("{triple} (bundled)")
            };
            if out.len() > 140 {
                out.truncate(137);
                out.push_str("...");
            }
            return Some(out);
        }
    }
    Some(s.chars().take(140).collect())
}

fn dependencies_brief(raw: Option<&str>) -> Option<String> {
    let s = raw?.trim();
    if s.is_empty() {
        return None;
    }
    let v: serde_json::Value = serde_json::from_str(s).ok()?;
    let n = v.get("tools").and_then(|t| t.as_array())?.len();
    if n == 0 {
        None
    } else {
        Some(format!("{n} tool(s) declared in manifest"))
    }
}

fn safe_parse_json_value(raw: Option<&str>) -> Option<serde_json::Value> {
    let s = raw?.trim();
    if s.is_empty() {
        return None;
    }
    serde_json::from_str(s).ok()
}

fn safe_parse_json_object(raw: Option<&str>) -> Option<serde_json::Map<String, serde_json::Value>> {
    let v = safe_parse_json_value(raw)?;
    v.as_object().cloned()
}

fn toolchain_external_flag(raw: Option<&str>) -> Option<bool> {
    let tc = raw?.trim();
    if tc.is_empty() {
        return None;
    }
    if tc.starts_with('{') {
        let o = safe_parse_json_object(Some(tc))?;
        o.get("external").and_then(|x| x.as_bool())
    } else {
        None
    }
}

fn execution_indicates_tests(execution_raw: Option<&str>) -> bool {
    let Some(o) = safe_parse_json_object(execution_raw) else {
        return false;
    };
    o.get("testEntry")
        .and_then(|x| x.as_str())
        .map(str::trim)
        .map(|s| !s.is_empty())
        .unwrap_or(false)
        || o
            .get("tests")
            .and_then(|x| x.as_str())
            .map(str::trim)
            .map(|s| !s.is_empty())
            .unwrap_or(false)
}

fn targets_object_keys(raw: Option<&str>) -> Vec<String> {
    let Some(o) = safe_parse_json_object(raw) else {
        return vec![];
    };
    o.keys().cloned().collect()
}

/// Mirrors `store-frontend/lib/xsil-parser.ts` `computeCapabilityBadges` (badges + RL level).
fn compute_capability_badges(v: &RegistryVersion) -> (HashSet<&'static str>, u8) {
    let mut badges: HashSet<&'static str> = HashSet::new();

    if v.isa.as_deref().map(str::trim).filter(|s| !s.is_empty()).is_some() {
        badges.insert("ISA");
    }

    let tc_external = toolchain_external_flag(v.toolchain.as_deref());
    if tc_external == Some(true) {
        badges.insert("Toolchain: external");
    } else if tc_external == Some(false) {
        badges.insert("Toolchain: bundled");
    }

    let keys = targets_object_keys(v.targets.as_deref());
    let key = |k: &str| keys.iter().any(|x| x == k);
    if key("spike") {
        badges.insert("Sim: Spike");
    }
    if key("qemu") {
        badges.insert("Emu: QEMU");
    }
    if key("fpga") {
        badges.insert("FPGA");
    }
    if key("rtl") {
        badges.insert("RTL");
    }

    if execution_indicates_tests(v.execution.as_deref()) {
        badges.insert("Tests");
    }

    let rm = v
        .resolution_mode
        .as_deref()
        .unwrap_or("")
        .trim()
        .to_lowercase();
    if rm == "bundled" {
        badges.insert("Repro: bundled");
    } else if rm == "resolved" {
        badges.insert("Repro: resolved");
    } else if rm == "host-dependent" || rm == "host_dependent" || rm == "hostdependent" {
        badges.insert("Repro: host-dependent");
    } else if tc_external == Some(true) {
        badges.insert("Repro: host-dependent");
    }

    let has_sim = key("spike") || key("qemu");
    let has_hw = key("fpga") || key("rtl");
    let bundled_toolchain = tc_external == Some(false);
    let has_tests = execution_indicates_tests(v.execution.as_deref());

    let mut level: u8 = 1;
    if has_sim {
        level = 2;
    }
    if level >= 2 && bundled_toolchain {
        level = 3;
    }
    if level >= 2 && has_tests {
        level = 4;
    }
    if has_hw && level >= 2 {
        level = 5;
    }

    (badges, level)
}

fn stored_capabilities_tokens(raw: Option<&str>) -> HashSet<String> {
    let mut out = HashSet::new();
    let Some(v) = safe_parse_json_value(raw) else {
        return out;
    };
    if let Some(arr) = v.as_array() {
        for x in arr {
            if let Some(t) = x.as_str() {
                let t = t.trim();
                if !t.is_empty() {
                    out.insert(t.to_string());
                }
            }
        }
    }
    out
}

fn readiness_name(level: u8) -> &'static str {
    match level {
        1 => "Packaged",
        2 => "Runnable",
        3 => "Reproducible",
        4 => "Testable",
        5 => "HW-evaluable",
        _ => "Readiness",
    }
}

fn print_readiness_block(v: &RegistryVersion) {
    let (mut badge_set, inferred_level) = compute_capability_badges(v);
    let rl = v.readiness_level.unwrap_or(inferred_level);
    println!(
        "  Readiness   : RL{}{}",
        rl,
        readiness_name(rl)
    );

    let stored = stored_capabilities_tokens(v.capabilities.as_deref());
    const BADGE_KEYS: [&str; 10] = [
        "Repro: bundled",
        "Repro: resolved",
        "Repro: host-dependent",
        "Toolchain: bundled",
        "Toolchain: external",
        "Sim: Spike",
        "Emu: QEMU",
        "RTL",
        "FPGA",
        "Tests",
    ];
    for t in &stored {
        // Stored capabilities are authoritative when present.
        if let Some(k) = BADGE_KEYS.iter().copied().find(|k| *k == t.as_str()) {
            badge_set.insert(k);
        }
    }

    let exec_obj = safe_parse_json_object(v.execution.as_deref());
    let has_entry = exec_obj
        .as_ref()
        .and_then(|o| o.get("entry"))
        .and_then(|x| x.as_str())
        .map(str::trim)
        .map(|s| !s.is_empty())
        .unwrap_or(false)
        || stored.contains("entry");
    let has_test_entry = exec_obj
        .as_ref()
        .and_then(|o| o.get("testEntry"))
        .and_then(|x| x.as_str())
        .map(str::trim)
        .map(|s| !s.is_empty())
        .unwrap_or(false)
        || stored.contains("testEntry");

    println!("  Capabilities:");
    let rows: [(&str, bool); 12] = [
        ("Runnable (entry declared)", has_entry),
        ("Testable (testEntry declared)", has_test_entry),
        ("Repro: bundled", badge_set.contains("Repro: bundled")),
        ("Repro: resolved", badge_set.contains("Repro: resolved")),
        (
            "Repro: host-dependent",
            badge_set.contains("Repro: host-dependent"),
        ),
        (
            "Toolchain: bundled",
            badge_set.contains("Toolchain: bundled"),
        ),
        (
            "Toolchain: external",
            badge_set.contains("Toolchain: external"),
        ),
        ("Sim: Spike", badge_set.contains("Sim: Spike")),
        ("Emu: QEMU", badge_set.contains("Emu: QEMU")),
        ("RTL", badge_set.contains("RTL")),
        ("FPGA", badge_set.contains("FPGA")),
        ("Tests", badge_set.contains("Tests")),
    ];
    for (label, ok) in rows {
        let mark = if ok { "" } else { "" };
        println!("    {mark} {label}");
    }
}

fn print_registry_version_repro_fields(v: &RegistryVersion) {
    if let Some(ref m) = v.resolution_mode {
        let t = m.trim();
        if !t.is_empty() {
            println!("  Resolution  : {}", format_resolution_mode(t));
        }
    }
    if let Some(ref s) = summarize_registry_targets(v.targets.as_deref()) {
        println!("  Targets     : {}", s);
    }
    if let Some(ref line) = registry_toolchain_one_line(v.toolchain.as_deref()) {
        println!("  Toolchain   : {}", line);
    }
    if let Some(ref dep) = dependencies_brief(v.dependencies.as_deref()) {
        println!("  Dependencies: {}", dep);
    }
    if let Some(ref exec_raw) = v.execution {
        let ex = exec_raw.trim();
        if !ex.is_empty() {
            if let Ok(val) = serde_json::from_str::<serde_json::Value>(ex) {
                if let Some(e) = val
                    .get("entry")
                    .and_then(|x| x.as_str())
                    .map(str::trim)
                    .filter(|s| !s.is_empty())
                {
                    println!("  entry         : {}", e);
                }
                if let Some(e) = val
                    .get("testEntry")
                    .and_then(|x| x.as_str())
                    .map(str::trim)
                    .filter(|s| !s.is_empty())
                {
                    println!("  testEntry     : {}", e);
                }
            } else {
                println!(
                    "  execution     : {}",
                    ex.chars().take(120).collect::<String>()
                );
            }
        }
    }
}

fn cmd_info(
    registry: &RegistryClient,
    manager: &ExtensionManager,
    package: &str,
) -> Result<()> {
    // Parse optional @version suffix (e.g. "rvx-demo@1.2.0" or "rvx-demo@latest").
    let (slug, requested_version) = parse_package_arg(package);

    println!("{} Fetching info for {}...", "".blue(), slug.bold());
    let pkg = registry.get_package(&slug)?;

    println!("  Name        : {}", pkg.name.bold());
    println!("  Slug        : {}", pkg.slug);
    println!("  Author      : {}", pkg.author);
    println!("  Description : {}", pkg.description);

    if let Some(ref kw) = pkg.keywords {
        if !kw.is_empty() {
            println!("  Keywords    : {}", kw.join(", "));
        }
    }
    if let Some(ref license) = pkg.license {
        println!("  License     : {}", license);
    }
    if let Some(ref repo) = pkg.repository_url {
        println!("  Repository  : {}", repo);
    }
    if let Some(ref hp) = pkg.homepage_url {
        println!("  Homepage    : {}", hp);
    }
    if let Some(ref o) = pkg.org {
        println!(
            "  Organization: @{} ({})",
            o.slug.bold(),
            o.display_name
        );
    }
    println!("  Downloads   : {}", pkg.total_downloads);
    println!("  Weekly dl   : {}", pkg.weekly_downloads);
    println!("  Versions    : {}", pkg.versions.len());

    if let Some(ref latest) = pkg.latest_version {
        println!("  Latest      : {}", latest.cyan());
    } else if let Some(v) = pkg.versions.first() {
        println!("  Latest      : {}", v.version.cyan());
    }

    // If a specific version was requested, show its details.
    if let Some(ref ver_str) = requested_version {
        match resolve_version(&pkg, Some(ver_str.as_str()), false) {
            Ok(v) => {
                println!();
                println!("  ── Version {} ──", v.version.cyan().bold());
                let isa = v.isa.as_deref().unwrap_or("");
                let dl = v.download_count;
                println!("  ISA         : {}", isa);
                println!("  Downloads   : {}", dl);
                println!("  Published   : {}", v.published_at.as_deref().unwrap_or(""));
                print_readiness_block(v);
                print_registry_version_repro_fields(v);
                if let Some(ref cs) = v.checksum {
                    println!("  Checksum    : {}", &cs[..cs.len().min(20)]);
                }
                let cl = v.changelog.as_deref().unwrap_or("");
                if let Some(first_line) = cl.lines().next().map(str::trim).filter(|s| !s.is_empty()) {
                    println!("  Changelog   : {}", first_line);
                }
                if v.is_yanked {
                    println!("  {} This version is yanked.", "".yellow());
                    if let Some(ref reason) = v.yank_reason {
                        println!("  Reason      : {}", reason);
                    }
                }
                println!();
                println!("  Install     : xsil install {}@{}", pkg.slug, v.version);
            }
            Err(e) => {
                eprintln!("{} {}", "".yellow(), e);
            }
        }
    }

    // When no @version: show reproducibility / execution snapshot for semver-latest.
    if requested_version.is_none() {
        if let Ok(lv) = resolve_version(&pkg, None, false) {
            println!();
            println!(
                "  ── Latest version (v{}) — registry metadata ──",
                lv.version.cyan()
            );
            print_readiness_block(lv);
            print_registry_version_repro_fields(lv);
        }
    }

    // Show non-yanked version list when no specific version was requested.
    if requested_version.is_none() {
        let active: Vec<&RegistryVersion> = pkg.versions.iter().filter(|v| !v.is_yanked).collect();
        if !active.is_empty() {
            println!("  Available   :");
            for v in &active {
                let dl = v.download_count;
                let isa = v.isa.as_deref().unwrap_or("?");
                let is_latest = pkg.latest_version.as_deref() == Some(v.version.as_str());
                let tag = if is_latest { " (latest)".green().to_string() } else { String::new() };
                println!("    {} ({}{} dl){}", v.version.cyan(), isa, dl, tag);
            }
        }
    }

    // Local install status.
    if let Ok(installed_path) = manager.get_installed_extension_path(&slug) {
        if let Ok(m) = manager.read_manifest(&installed_path) {
            println!("  Installed   : {} at {}", m.version.green(), installed_path.display());
        }
    }

    Ok(())
}

fn cmd_search(registry: &RegistryClient, query: &str, limit: usize) -> Result<()> {
    println!("{} Searching for \"{}\"...", "".blue(), query);
    let results = registry.search_packages(query)?;

    if results.is_empty() {
        println!("No packages found.");
        return Ok(());
    }

    let shown = results.iter().take(limit);
    for pkg in shown {
        let latest = pkg.latest_version.as_deref().unwrap_or("?");
        println!(
            "  {} {}{}",
            pkg.slug.bold(),
            latest.cyan(),
            pkg.description
        );
    }

    let total = results.len();
    if total > limit {
        println!("  … and {} more. Use --limit to show more.", total - limit);
    }

    Ok(())
}

// ── Package resolution helpers ────────────────────────────────────────────────

/// Resolve and load a package workspace for run/test commands.
/// Returns (work_dir, manifest, needs_cleanup).
fn resolve_and_load(
    registry: &RegistryClient,
    manager: &ExtensionManager,
    package: &str,
) -> Result<(PathBuf, Manifest, bool)> {
    let path = PathBuf::from(package);

    // Unpacked local directory.
    if path.is_dir() {
        let (dir, manifest) = manager.validate_local_package_directory(&path)?;
        return Ok((dir, manifest, false));
    }

    // Local .xsil file.
    if path.is_file() && path.extension().map_or(false, |e| e == "xsil") {
        let bytes = fs::read(&path).context("Failed to read .xsil file")?;
        let (dir, manifest) = manager.extract_and_validate_xsil(&bytes)?;
        return Ok((dir, manifest, true));
    }

    // Registry slug.
    let (slug, requested_version) = parse_package_arg(package);

    println!("{} Resolving {}...", "".blue(), slug.bold());
    let pkg = registry.get_package(&slug)?;
    let version = resolve_version(&pkg, requested_version.as_deref(), false)?;

    if version.is_yanked {
        bail!(
            "Version {} is yanked. Use --override-security if you must.",
            version.version
        );
    }

    let pb = progress_spinner("Downloading...");
    let bytes = registry.download_from_url(&version.xsil_url)?;
    pb.finish_with_message("Download complete");

    println!("{} Validating integrity...", "".blue());
    let (dir, manifest) = manager.extract_and_validate_xsil(&bytes)?;
    Ok((dir, manifest, true))
}

/// Parse "slug" or "slug@version" into (slug, Option<version>).
///
/// Handles scoped packages correctly:
///   - `pkg`              → ("pkg",        None)
///   - `pkg@1.0.0`        → ("pkg",        Some("1.0.0"))
///   - `@scope/pkg`       → ("@scope/pkg", None)
///   - `@scope/pkg@1.0.0` → ("@scope/pkg", Some("1.0.0"))
fn parse_package_arg(package: &str) -> (String, Option<String>) {
    if let Some(rest) = package.strip_prefix('@') {
        // Scoped package — find the version separator *after* the slash
        // e.g. "scope/pkg@1.0.0" → slug="@scope/pkg", ver="1.0.0"
        if let Some(at_pos) = rest.find('@') {
            let slug = format!("@{}", &rest[..at_pos]);
            let ver  = rest[at_pos + 1..].to_string();
            (slug, Some(ver))
        } else {
            (package.to_string(), None)
        }
    } else {
        // Unscoped package
        match package.split_once('@') {
            Some((name, ver)) => (name.to_string(), Some(ver.to_string())),
            None => (package.to_string(), None),
        }
    }
}

/// Pick the correct version from registry metadata.
///
/// Version resolution rules:
/// - `None` or `"latest"` → highest non-yanked semver (backend already returns versions
///   in semver-descending order, so the first non-yanked entry is the latest)
/// - Any other string     → exact version match
fn resolve_version<'a>(
    pkg: &'a RegistryPackage,
    requested: Option<&str>,
    allow_yanked: bool,
) -> Result<&'a RegistryVersion> {
    match requested {
        None | Some("latest") => {
            // Prefer the latestVersion field the registry provides as an explicit tag.
            if let Some(ref tagged) = pkg.latest_version {
                if let Some(v) = pkg.versions.iter().find(|ver| ver.version == *tagged) {
                    return Ok(v);
                }
            }
            // Fall back: first non-yanked in the (semver-sorted) list.
            pkg.versions
                .iter()
                .find(|ver| !ver.is_yanked)
                .or_else(|| if allow_yanked { pkg.versions.first() } else { None })
                .with_context(|| format!("No installable versions found for {}", pkg.slug))
        }
        Some(v) => {
            pkg.versions
                .iter()
                .find(|ver| ver.version == v)
                .with_context(|| format!(
                    "Version '{}' not found for '{}'. Run `xsil info {}` to see available versions.",
                    v, pkg.slug, pkg.slug
                ))
        }
    }
}

/// Extract `manifest.json` from raw `.xsil` bytes without unpacking to disk.
fn extract_manifest_from_bytes(data: &[u8]) -> Result<Manifest> {
    let tar = flate2::read::GzDecoder::new(data);
    let mut archive = tar::Archive::new(tar);
    for entry in archive.entries()? {
        let mut entry = entry?;
        let path = entry.path()?;
        if path.file_name().map_or(false, |n| n == "manifest.json")
            && path.components().count() == 1
        {
            let mut content = String::new();
            entry.read_to_string(&mut content)?;
            return serde_json::from_str(&content).context("Invalid manifest.json in archive");
        }
    }
    bail!("manifest.json not found in archive root");
}

/// Validate the fields required before publishing.
fn validate_publish_manifest(m: &Manifest) -> Result<()> {
    if m.name.is_empty() {
        bail!("manifest.name is required");
    }
    if m.version.is_empty() {
        bail!("manifest.version is required");
    }
    if Version::parse(&m.version).is_err() {
        bail!("manifest.version '{}' is not valid semver (e.g. 1.0.0)", m.version);
    }
    if m.description.is_empty() {
        bail!("manifest.description is required");
    }
    if m.author.is_empty() {
        bail!("manifest.author is required");
    }
    if m.effective_entry().is_none() {
        bail!("manifest entry is required (set `execution.entry` or legacy `entry`).");
    }
    Ok(())
}

fn cmd_yank(
    registry: &RegistryClient,
    package_version: &str,
    reason: Option<&str>,
    restore: bool,
) -> Result<()> {
    // Parse "pkg@x.y.z" or "@scope/pkg@x.y.z".
    let (slug, version_opt) = parse_package_arg(package_version);

    let version = version_opt.with_context(|| {
        format!(
            "Version is required: use <package>@<version> (e.g. {}@1.0.0)",
            slug
        )
    })?;

    if slug.is_empty() {
        bail!("Package name is required (e.g. rvx-demo@1.0.0)");
    }
    if Version::parse(&version).is_err() {
        bail!("'{}' is not a valid semver version (e.g. 1.0.0)", version);
    }

    if restore {
        println!("{} Restoring {}@{}...", "".blue(), slug.bold(), version.cyan());
    } else {
        println!("{} Yanking {}@{}...", "".blue(), slug.bold(), version.cyan());
        if let Some(r) = reason {
            println!("  Reason  : {}", r);
        }
    }

    let result = registry.yank_version(&slug, &version, !restore, reason)?;

    let is_yanked = result
        .get("isYanked")
        .and_then(|v| v.as_bool())
        .unwrap_or(!restore);

    let latest = result
        .get("latestVersion")
        .and_then(|v| v.as_str());

    if is_yanked {
        println!("{} Yanked {}@{}", "".green(), slug.bold(), version.cyan());
        if reason.is_some() {
            println!("  Reason  : {}", reason.unwrap_or(""));
        }
    } else {
        println!("{} Restored {}@{}", "".green(), slug.bold(), version.cyan());
    }

    match latest {
        Some(v) if !v.is_empty() => println!("  Latest  : {}", v.green()),
        _ => println!(
            "  {} All versions of {} are yanked — no installable version available.",
            "".yellow(),
            slug.bold()
        ),
    }

    Ok(())
}

fn progress_spinner(msg: &str) -> ProgressBar {
    let pb = ProgressBar::new_spinner();
    pb.set_style(
        ProgressStyle::default_spinner()
            .template("{spinner:.green} [{elapsed_precise}] {msg}")
            .unwrap_or_else(|_| ProgressStyle::default_spinner()),
    );
    pb.set_message(msg.to_string());
    pb
}

// ── Path setup ────────────────────────────────────────────────────────────────

fn setup_paths() -> Result<(PathBuf, PathBuf, PathBuf)> {
    let home = directories::UserDirs::new()
        .ok_or_else(|| anyhow::anyhow!("Could not find user home directory"))?;
    let root = home.home_dir().join(".extensilica");
    let extensions = root.join("extensions");
    let config_file = root.join("config.json");
    let logs = root.join("logs");
    let tmp = root.join("tmp");

    for dir in &[&extensions, &logs, &tmp] {
        if !dir.exists() {
            fs::create_dir_all(dir)?;
        }
    }
    if !config_file.exists() {
        fs::write(&config_file, "{}")?;
    }

    Ok((config_file, extensions, root))
}