1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
/// A Sample State
use xmrs::fixed::fixed::Q15;
use xmrs::fixed::units::{
Amp, ChannelVolume, Finetune, Frequency, Panning, PitchDelta, SampleRate,
};
use xmrs::sample::{LoopType, Sample};
const M: u32 = 25; // 25 bits for fract part seems the better i can have
const M_MASK: u32 = (1 << M) - 1;
#[derive(Clone)]
pub struct StateSample<'a> {
sample: &'a Sample,
/// Voice finetune contribution in semitones (was `f32`).
/// Stored as `Finetune` Q1.15 — represents fractional
/// semitones in `[-1, +1)`. The tracker formats put a
/// signed byte here `(byte/127)` semitones; Q1.15 has
/// 1/32768 ≈ 0.003 semitone resolution, well below the
/// XM byte's 1/127 step.
finetune: Finetune,
/// current sustain state
sustained: bool,
/// current seek position
position: (u32, u32), // ( Position, Fract part M shifted )
/// step is freq / rate
step: Option<u32>, // step, M shifted
/// Output sample-rate (was `f32`). Q-typed `u32` Hz
/// throughout — `set_step` multiplies as `u64` to keep
/// the precision of the previous f32 path with no rounding
/// surprises.
rate: SampleRate,
// Cached loop / length parameters from the underlying `Sample`.
//
// These mirror `Sample::len`, `Sample::loop_*` and
// `Sample::sustain_loop_*` and are populated once at construction.
// The `Sample` itself is borrowed immutably for the lifetime of
// this `StateSample`, so caching is safe — these values cannot
// change underneath us.
//
// The point is to keep the per-sample hot path (`tick` →
// `seek_cached`) free of the
// `match self.data { Mono8(v) => v.len(), Mono16(v) => ... }`
// walk inside `Sample::len` and `SampleDataType::len`. With
// `#[inline(always)]` alone these matches inline at every call
// site but still execute the chain of branches; caching the
// resolved `usize` makes the hot path purely arithmetic. After
// the inline-only patches, profiling still showed `Sample::len`
// and `Sample::is_empty` cumulatively eating ~15% of total
// runtime — the cache eliminates that entirely.
cached_len: usize,
/// `cached_len - 1` (or 0 if empty). Hot path uses this as the
/// last-valid-index clamp; precomputing eliminates the
/// subtraction (and the underflow check) inside `seek_cached`.
cached_len_minus_1: usize,
cached_loop_start: usize,
cached_loop_length: usize,
/// `cached_loop_start + cached_loop_length`. Materialising the
/// end of the loop region avoids recomputing it inside the
/// per-frame seek.
cached_loop_end: usize,
cached_loop_flag: LoopType,
cached_sustain_loop_start: usize,
cached_sustain_loop_length: usize,
cached_sustain_loop_end: usize,
cached_sustain_loop_flag: LoopType,
}
impl<'a> StateSample<'a> {
pub fn new(sample: &'a Sample, rate: SampleRate) -> Self {
let finetune = sample.finetune;
let cached_len = sample.len();
let cached_loop_start = sample.loop_start as usize;
let cached_loop_length = sample.loop_length as usize;
let cached_sustain_loop_start = sample.sustain_loop_start as usize;
let cached_sustain_loop_length = sample.sustain_loop_length as usize;
Self {
sample,
finetune,
sustained: true,
position: (0, 0),
step: None,
rate,
cached_len,
cached_len_minus_1: cached_len.saturating_sub(1),
cached_loop_start,
cached_loop_length,
cached_loop_end: cached_loop_start + cached_loop_length,
cached_loop_flag: sample.loop_flag,
cached_sustain_loop_start,
cached_sustain_loop_length,
cached_sustain_loop_end: cached_sustain_loop_start + cached_sustain_loop_length,
cached_sustain_loop_flag: sample.sustain_loop_flag,
}
}
pub fn reset(&mut self) {
self.position = (0, 0);
self.sustained = true;
self.step = None;
}
/// Compute the integer-fixed-point sample step from the
/// playback `frequency` (Q24.8 Hz) and the engine's
/// sample-rate. All math is `u64` integer — no f32.
///
/// `step = (2^M × frequency_hz) / rate_hz`, expanded into
/// `(frequency_q24_8 << (M - 8)) / rate_hz` where the
/// `<< (M - 8)` is exact (M = 25 ≥ 8) and the `u64`
/// intermediate keeps full precision until the final
/// truncation back to `u32`.
pub fn set_step(&mut self, frequency: Frequency) {
if self.cached_len == 0 {
self.disable();
} else {
let rate_hz = self.rate.hz();
if rate_hz == 0 {
self.disable();
return;
}
// Promote both operands to u64. M ≥ 8 so the shift
// is non-negative; with M = 25 the worst-case
// `frequency << 17 ≈ 16M × 2^17 ≈ 2 × 10^12`, well
// within u64.
let num: u64 = (frequency.raw_q24_8() as u64) << (M - 8);
let step = num / rate_hz as u64;
self.step = Some(step.min(u32::MAX as u64) as u32);
}
}
#[inline(always)]
pub fn is_enabled(&self) -> bool {
self.step.is_some()
}
/// `true` if the underlying sample has any kind of loop (forward,
/// ping-pong, or sustain). Used by the voice pool's eviction
/// heuristic — looping voices can ring indefinitely so they're
/// cheaper to drop than one-shot tails.
pub fn is_looping(&self) -> bool {
self.cached_loop_flag != LoopType::No || self.cached_sustain_loop_flag != LoopType::No
}
pub fn disable(&mut self) {
self.step = None;
}
pub fn get_panning(&self) -> Panning {
self.sample.panning
}
pub fn get_volume(&self) -> ChannelVolume {
self.sample.volume
}
/// Sample's pitch contribution: integer relative-pitch
/// semitones plus fractional finetune. Returns a
/// [`PitchDelta`] (Q8.8 semitones) — the pitch chain unit.
///
/// Encoding: `relative_pitch i8` widens to `i16` semitones
/// then shifts left 8 (Q8.8 raw); finetune `Q1.15 raw` >> 7
/// gives the matching Q8.8 fractional bits (lossy by 7 bits
/// of finetune precision = 1/128 of a semitone, well below
/// the XM byte's 1/127 step). Saturating add at the i16
/// boundary — `relative_pitch` is clamped to `[-95, 96]`
/// at import time so the sum can't overflow in practice
/// either way.
pub fn get_finetuned_pitch(&self) -> PitchDelta {
let rel_q88 = (self.sample.relative_pitch as i16).saturating_mul(256);
let fine_q88 = self.finetune.into_q15().raw() >> 7;
PitchDelta::from_q8_8_i16(rel_q88.saturating_add(fine_q88))
}
pub fn set_finetune(&mut self, finetune: Finetune) {
self.finetune = finetune;
}
pub fn set_sustained(&mut self, sustained: bool) {
self.position.0 = self
.sample
.meta_seek(self.position.0 as usize, self.sustained) as u32;
self.sustained = sustained;
}
/// Resolve a play-head position to a sample-index, honouring
/// the active loop region.
///
/// Returns `None` when the play head has run past the end of a
/// non-looping sample — at which point the voice is done and
/// must be shut off, otherwise it would hold the tail frame
/// indefinitely and produce an audible drone on any instrument
/// whose tail isn't silent.
///
/// **Hot path**: this fires twice per audio frame per active
/// voice (once for `pos`, once for `pos + 1` for linear
/// interpolation). Everything is read from the per-state cache
/// (no `Sample::len`, no enum dispatch on `SampleDataType`),
/// the dispatch on `LoopType` happens once (no nested helper),
/// and the loop end is precomputed (no `start + length` per
/// call).
#[inline(always)]
fn seek_cached(&self, pos: usize) -> Option<usize> {
if self.cached_len == 0 {
return None;
}
let (start, end, length, loop_type) =
if self.sustained && self.cached_sustain_loop_flag != LoopType::No {
(
self.cached_sustain_loop_start,
self.cached_sustain_loop_end,
self.cached_sustain_loop_length,
self.cached_sustain_loop_flag,
)
} else {
(
self.cached_loop_start,
self.cached_loop_end,
self.cached_loop_length,
self.cached_loop_flag,
)
};
match loop_type {
LoopType::No => {
if pos < self.cached_len {
Some(pos)
} else {
None
}
}
LoopType::Forward => {
if length == 0 || pos < end {
Some(pos.min(self.cached_len_minus_1))
} else {
Some(start + (pos - start) % length)
}
}
LoopType::PingPong => {
if length == 0 || pos < end {
Some(pos.min(self.cached_len_minus_1))
} else {
let total_length = 2 * length;
let mod_pos = (pos - start) % total_length;
if mod_pos < length {
Some(start + mod_pos)
} else {
Some(end - (mod_pos - length) - 1)
}
}
}
}
}
#[inline(always)]
fn tick(&mut self) -> (Amp, Amp) {
// Ask the sample where we actually are. `seek_cached` returns
// `None` when the play head has run past the end of a non-
// looping sample — at which point the voice is done and must
// be shut off, otherwise it would hold the tail frame
// indefinitely and produce an audible drone on any instrument
// whose tail isn't silent.
let pos = self.position.0 as usize;
let useek = match self.seek_cached(pos) {
Some(s) => s,
None => {
self.disable();
return (Amp::SILENCE, Amp::SILENCE);
}
};
// Linear interpolation peek: the "next" sample follows the
// same rules. If the next frame is past the end, reuse the
// current one rather than blending into silence.
let vseek = self.seek_cached(pos + 1).unwrap_or(useek);
// Position fraction in Q1.15. `get_position_fraction()`
// returns a `u32` in `[0, 1 << M)` (M is the player's
// sub-sample bit count, typically 25). Right-shift by
// `M - 15` to bring it into the Q1.15 numerator space —
// exact for any `M ≥ 15`, no f32.
let frac = self.get_position_fraction();
let t = Q15::from_raw((frac >> (M - 15)) as i16);
let u = self.sample.at(useek);
let v = self.sample.at(vseek);
self.increment_position();
// `Amp::lerp` is a saturating Q1.15 lerp — `u + (v - u) * t`
// computed in widened i32. Replaces the f32 lerp helper.
(u.0.lerp(v.0, t), u.1.lerp(v.1, t))
}
pub fn set_position(&mut self, position: usize) {
self.position.0 = position as u32;
self.position.1 = 0;
}
/// Length of the underlying sample in sample frames. Used by the
/// channel's Oxx-past-end branch to decide whether to clamp
/// (IT old-effects) or drop the offset (IT default / XM / etc.).
pub fn sample_len(&self) -> usize {
self.cached_len
}
#[inline(always)]
fn increment_position(&mut self) -> u32 {
if let Some(step) = self.step {
// Split `step` into integer and fractional parts *before*
// accumulating, so the fractional register never overflows
// u32 on 32-bit targets. With M = 25:
// step & M_MASK < 2^25
// position.1 <= M_MASK < 2^25
// → position.1 + (step & M_MASK) < 2^26 (safe u32 add)
//
// The naive `position.1 += step` panicked whenever `step`
// saturated to u32::MAX — which happens as soon as the
// `f32 as u32` cast in `set_step` is fed a multi-MHz
// frequency (e.g. S3M portamento-up driving the Amiga
// period toward zero). Branchless form below keeps the
// hot path free of conditional jumps.
self.position.1 += step & M_MASK;
let carry = self.position.1 >> M; // 0 or 1
self.position.0 = self
.position
.0
.wrapping_add((step >> M).wrapping_add(carry));
self.position.1 &= M_MASK;
}
self.position.0
}
#[inline(always)]
fn get_position_fraction(&self) -> u32 {
self.position.1 & M_MASK
}
}
impl<'a> Iterator for StateSample<'a> {
type Item = (Amp, Amp);
#[inline(always)]
fn next(&mut self) -> Option<Self::Item> {
if self.is_enabled() {
Some(self.tick())
} else {
None
}
}
}