xll-utils 0.1.0

PE/COFF parsing and export verification utilities for Excel XLL development
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
//! End-to-end integration tests exercising the full parse -> verify -> report workflow.

use xll_utils::exports::{export_diff, verify_dll_exports, verify_dll_exports_strict, verify_pe_exports};
use xll_utils::pe::{parse_pe_bytes, parse_pe_file};
use xll_utils::types::{Architecture, ExportInfo, PeFile};
use xll_utils::xll::{is_valid_xll, verify_xll_entry_points, xll_info};

fn fixture_path() -> std::path::PathBuf {
    std::path::Path::new(env!("CARGO_MANIFEST_DIR"))
        .join("tests")
        .join("fixtures")
        .join("test_xll.xll")
}

// ---------------------------------------------------------------------------
// Full workflow: parse -> verify -> xll_info
// ---------------------------------------------------------------------------

#[test]
fn full_workflow_parse_verify_xll_info() {
    let path = fixture_path();

    // Step 1: Parse PE
    let pe = parse_pe_file(&path).unwrap();
    assert!(pe.is_dll());
    assert_eq!(pe.architecture(), Architecture::X64);

    // Step 2: Verify exports
    let expected = &[
        "xlAutoOpen",
        "xlAutoClose",
        "xlAutoFree12",
        "xlAddInManagerInfo12",
        "xl_add",
        "xl_multiply",
        "xl_negate",
        "xl_version",
    ];
    let report = verify_pe_exports(&pe, expected);
    assert!(report.complete, "missing: {:?}", report.missing);
    assert_eq!(report.found.len(), expected.len());

    // Step 3: Validate as XLL
    assert!(verify_xll_entry_points(&pe));

    // Step 4: Extract metadata
    let info = xll_info(&path).unwrap();
    assert_eq!(info.name, "test_xll");
    assert!(info.has_auto_open);
    assert!(info.has_auto_free);
    assert_eq!(info.architecture, pe.architecture());
    assert_eq!(info.export_count, pe.exports().len());
}

#[test]
fn workflow_verify_then_strict_verify() {
    let path = fixture_path();
    let expected = &["xlAutoOpen", "xlAutoClose"];

    // Regular verification
    let report = verify_dll_exports(&path, expected).unwrap();
    assert!(report.complete);

    // Strict case-insensitive with correct casing — no mismatches
    let strict = verify_dll_exports_strict(&path, expected, false).unwrap();
    assert!(strict.complete);
    assert!(strict.mismatches.is_empty());

    // Both should agree on unexpected exports
    assert_eq!(report.unexpected.len(), strict.unexpected.len());
}

#[test]
fn workflow_diff_file_against_itself() {
    let pe = parse_pe_file(fixture_path()).unwrap();
    let names = pe.export_names();
    let expected: Vec<&str> = names.iter().map(|s| s.as_str()).collect();

    let diff = export_diff(&expected, pe.exports());
    assert!(diff.missing.is_empty(), "diffing against self should have no missing");
    assert!(diff.extra.is_empty(), "diffing against self should have no extra");
    assert_eq!(diff.common.len(), names.len());
}

#[test]
fn workflow_parse_bytes_then_verify() {
    let data = std::fs::read(fixture_path()).unwrap();
    let pe = parse_pe_bytes(&data).unwrap();

    let report = verify_pe_exports(&pe, &["xlAutoOpen", "xlAutoFree12"]);
    assert!(report.complete);

    // Path should be empty when parsed from bytes (no file path available)
    assert_eq!(report.dll_path, std::path::PathBuf::new());
}

#[test]
fn xll_info_consistent_with_pe() {
    let path = fixture_path();
    let pe = parse_pe_file(&path).unwrap();
    let info = xll_info(&path).unwrap();

    // Export count must match
    assert_eq!(info.export_count, pe.exports().len());

    // Export names from xll_info must match PeFile::export_names
    assert_eq!(info.exports, pe.export_names());

    // Architecture must match
    assert_eq!(info.architecture, pe.architecture());

    // Entry point booleans must be consistent with find_export
    assert_eq!(info.has_auto_open, pe.find_export("xlAutoOpen").is_some());
    assert_eq!(info.has_auto_close, pe.find_export("xlAutoClose").is_some());
    assert_eq!(info.has_auto_free, pe.find_export("xlAutoFree12").is_some());
    assert_eq!(
        info.has_addin_manager_info,
        pe.find_export("xlAddInManagerInfo12").is_some()
    );
}

// ---------------------------------------------------------------------------
// Edge cases: verify_xll_entry_points with synthetic PeFile
// ---------------------------------------------------------------------------

fn make_pe_file(export_names: &[&str]) -> PeFile {
    let exports: Vec<ExportInfo> = export_names
        .iter()
        .enumerate()
        .map(|(i, name)| ExportInfo {
            name: Some(name.to_string()),
            ordinal: i as u32 + 1,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x1000 + i as u32 * 0x100),
        })
        .collect();

    PeFile {
        path: std::path::PathBuf::from("synthetic.xll"),
        architecture: Architecture::X64,
        is_dll: true,
        image_base: 0x180000000,
        entry_point_rva: 0x1000,
        export_directory: None,
        exports,
    }
}

#[test]
fn entry_points_missing_auto_open() {
    let pe = make_pe_file(&["xlAutoFree12", "xlAutoClose", "myFunc"]);
    assert!(!verify_xll_entry_points(&pe), "should fail without xlAutoOpen");
}

#[test]
fn entry_points_missing_auto_free() {
    let pe = make_pe_file(&["xlAutoOpen", "xlAutoClose", "myFunc"]);
    assert!(!verify_xll_entry_points(&pe), "should fail without xlAutoFree12");
}

#[test]
fn entry_points_missing_both() {
    let pe = make_pe_file(&["xlAutoClose", "myFunc"]);
    assert!(!verify_xll_entry_points(&pe));
}

#[test]
fn entry_points_no_exports() {
    let pe = make_pe_file(&[]);
    assert!(!verify_xll_entry_points(&pe));
}

#[test]
fn entry_points_valid_minimal() {
    let pe = make_pe_file(&["xlAutoOpen", "xlAutoFree12"]);
    assert!(verify_xll_entry_points(&pe));
}

// ---------------------------------------------------------------------------
// Edge cases: verify_pe_exports with synthetic PeFile
// ---------------------------------------------------------------------------

#[test]
fn verify_pe_exports_duplicate_expected_names() {
    let pe = make_pe_file(&["foo", "bar"]);
    // Pass "foo" twice in expected — should still only find it once
    let report = verify_pe_exports(&pe, &["foo", "foo"]);
    assert!(report.complete);
    assert_eq!(report.found, vec!["foo".to_string(), "foo".to_string()]);
}

#[test]
fn verify_pe_exports_no_exports_in_pe() {
    let pe = make_pe_file(&[]);
    let report = verify_pe_exports(&pe, &["foo"]);
    assert!(!report.complete);
    assert_eq!(report.missing, vec!["foo".to_string()]);
    assert!(report.unexpected.is_empty());
    assert_eq!(report.total_exports, 0);
}

#[test]
fn verify_pe_exports_no_expected() {
    let pe = make_pe_file(&["foo", "bar"]);
    let report = verify_pe_exports(&pe, &[]);
    assert!(report.complete);
    assert_eq!(report.unexpected, vec!["bar".to_string(), "foo".to_string()]);
}

// ---------------------------------------------------------------------------
// Edge cases: export_diff
// ---------------------------------------------------------------------------

#[test]
fn diff_completely_disjoint() {
    let actual = vec![
        ExportInfo {
            name: Some("a".into()),
            ordinal: 1,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x1000),
        },
        ExportInfo {
            name: Some("b".into()),
            ordinal: 2,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x2000),
        },
    ];
    let diff = export_diff(&["x", "y"], &actual);
    assert_eq!(diff.missing, vec!["x".to_string(), "y".to_string()]);
    assert_eq!(diff.extra, vec!["a".to_string(), "b".to_string()]);
    assert!(diff.common.is_empty());
}

#[test]
fn diff_identical_lists() {
    let actual = vec![
        ExportInfo {
            name: Some("foo".into()),
            ordinal: 1,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x1000),
        },
    ];
    let diff = export_diff(&["foo"], &actual);
    assert!(diff.missing.is_empty());
    assert!(diff.extra.is_empty());
    assert_eq!(diff.common, vec!["foo".to_string()]);
}

#[test]
fn diff_ordinal_only_exports_ignored() {
    // Exports without names should not appear in diff results.
    let actual = vec![
        ExportInfo {
            name: None,
            ordinal: 1,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x1000),
        },
        ExportInfo {
            name: Some("named".into()),
            ordinal: 2,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x2000),
        },
    ];
    let diff = export_diff(&["named"], &actual);
    assert!(diff.missing.is_empty());
    assert!(diff.extra.is_empty());
    assert_eq!(diff.common, vec!["named".to_string()]);
}

// ---------------------------------------------------------------------------
// Edge cases: PE parsing
// ---------------------------------------------------------------------------

#[test]
fn parse_empty_data() {
    let err = parse_pe_bytes(&[]).unwrap_err();
    assert!(matches!(err, xll_utils::Error::InvalidFileFormat));
}

#[test]
fn parse_truncated_mz_header() {
    // Just "MZ" and nothing else
    let err = parse_pe_bytes(b"MZ").unwrap_err();
    assert!(matches!(err, xll_utils::Error::InvalidFileFormat));
}

#[test]
fn parse_random_bytes() {
    let data = vec![0xDE, 0xAD, 0xBE, 0xEF, 0x00, 0x11, 0x22, 0x33];
    let err = parse_pe_bytes(&data).unwrap_err();
    assert!(matches!(err, xll_utils::Error::InvalidFileFormat));
}

// ---------------------------------------------------------------------------
// Edge cases: is_valid_xll on non-XLL
// ---------------------------------------------------------------------------

#[test]
fn is_valid_xll_invalid_file_data() {
    // Write a temporary non-PE file and check is_valid_xll returns an error.
    let dir = std::env::temp_dir().join("xll_utils_test");
    std::fs::create_dir_all(&dir).unwrap();
    let path = dir.join("not_a_pe.xll");
    std::fs::write(&path, b"this is not a PE file").unwrap();

    let result = is_valid_xll(&path);
    assert!(result.is_err());

    // Cleanup
    let _ = std::fs::remove_file(&path);
    let _ = std::fs::remove_dir(&dir);
}

// ---------------------------------------------------------------------------
// Serde roundtrip (feature-gated)
// ---------------------------------------------------------------------------

#[cfg(feature = "serde")]
mod serde_tests {
    use super::*;

    #[test]
    fn architecture_serde_roundtrip() {
        for arch in [
            Architecture::X86,
            Architecture::X64,
            Architecture::Arm,
            Architecture::Arm64,
            Architecture::Unknown(0x1234),
        ] {
            let json = serde_json::to_string(&arch).unwrap();
            let back: Architecture = serde_json::from_str(&json).unwrap();
            assert_eq!(arch, back);
        }
    }

    #[test]
    fn export_info_serde_roundtrip() {
        let info = ExportInfo {
            name: Some("xlAutoOpen".into()),
            ordinal: 1,
            is_forwarded: false,
            forward_to: None,
            relative_address: Some(0x1234),
        };
        let json = serde_json::to_string(&info).unwrap();
        let back: ExportInfo = serde_json::from_str(&json).unwrap();
        assert_eq!(info, back);
    }

    #[test]
    fn export_info_forwarded_serde_roundtrip() {
        let info = ExportInfo {
            name: Some("ForwardedFunc".into()),
            ordinal: 42,
            is_forwarded: true,
            forward_to: Some("OTHER.dll.Func".into()),
            relative_address: None,
        };
        let json = serde_json::to_string(&info).unwrap();
        let back: ExportInfo = serde_json::from_str(&json).unwrap();
        assert_eq!(info, back);
    }

    #[test]
    fn verification_report_serde_roundtrip() {
        let report = xll_utils::VerificationReport {
            dll_path: std::path::PathBuf::from("test.xll"),
            total_exports: 5,
            found: vec!["a".into(), "b".into()],
            missing: vec!["c".into()],
            complete: false,
            unexpected: vec!["d".into()],
            mismatches: vec![xll_utils::NameMismatch {
                expected: "Foo".into(),
                actual: "foo".into(),
                ordinal: 3,
            }],
            architecture: Architecture::X64,
        };
        let json = serde_json::to_string_pretty(&report).unwrap();
        let back: xll_utils::VerificationReport = serde_json::from_str(&json).unwrap();
        assert_eq!(back.dll_path, report.dll_path);
        assert_eq!(back.total_exports, report.total_exports);
        assert_eq!(back.complete, report.complete);
        assert_eq!(back.found, report.found);
        assert_eq!(back.missing, report.missing);
        assert_eq!(back.mismatches, report.mismatches);
    }

    #[test]
    fn xll_info_serde_roundtrip() {
        let info = xll_info(fixture_path()).unwrap();
        let json = serde_json::to_string_pretty(&info).unwrap();
        let back: xll_utils::xll::XllInfo = serde_json::from_str(&json).unwrap();
        assert_eq!(back.name, info.name);
        assert_eq!(back.architecture, info.architecture);
        assert_eq!(back.export_count, info.export_count);
        assert_eq!(back.has_auto_open, info.has_auto_open);
        assert_eq!(back.exports, info.exports);
    }

    #[test]
    fn export_diff_serde_roundtrip() {
        let diff = xll_utils::ExportDiff {
            missing: vec!["a".into()],
            extra: vec!["b".into()],
            common: vec!["c".into()],
        };
        let json = serde_json::to_string(&diff).unwrap();
        let back: xll_utils::ExportDiff = serde_json::from_str(&json).unwrap();
        assert_eq!(back.missing, diff.missing);
        assert_eq!(back.extra, diff.extra);
        assert_eq!(back.common, diff.common);
    }
}