xed-sys 0.6.0+xed-2024.05.20

Rust FFI bindings for Intel XED.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
/* BEGIN_LEGAL 

Copyright (c) 2024 Intel Corporation

  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
  
END_LEGAL */
/// @file xed-encode-direct.c

////////////////////////////////////////////////////////////////////////////
// This file contains the public interface to the encoder. 
////////////////////////////////////////////////////////////////////////////
#include "xed-internal-header.h"
#include "xed-operand-accessors.h"
#include "xed-reg-class.h"
#include "xed-encode-direct.h"
#include <stdarg.h>  // va_list, etc
#include <stdlib.h>  //abort()
#include <stdio.h>  //vfprintf()

#if !defined(_MSC_VER)
// Turn off unused-function warning for this file while we are doing early development
# pragma GCC diagnostic ignored "-Wunused-function"
#endif



/// evex register for evex-VSIB
void enc_evex_vindex_xmm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_sibbase(r,offset&7);
    set_rexx(r,(offset >> 3) & 1);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_vindex_ymm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_sibbase(r,offset&7);
    set_rexx(r,(offset >> 3) & 1);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_vindex_zmm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ZMM_FIRST;
    set_sibbase(r,offset&7);
    set_rexx(r,(offset >> 3) & 1);
    set_evexvv(r,(offset >> 4) & 1);
}
/// vex register for vex-VSIB
void enc_vex_vindex_xmm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_sibbase(r,offset&7);
    set_rexx(r,(offset >> 3) & 1);
}
void enc_vex_vindex_ymm(xed_enc2_req_t* r,
                        xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_sibbase(r,offset&7);
    set_rexx(r,(offset >> 3) & 1);
}

// evex registers k0..k7 regs
void enc_evex_vvvv_kreg(xed_enc2_req_t* r,
                        xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_vvvv(r, offset & 7);
    set_evexvv(r,0);
}
void enc_evex_modrm_reg_kreg(xed_enc2_req_t* r,
                            xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_reg(r, offset & 7);
    //set_rexr(r,0);  // ZERO OPTIMIZATION
    //set_evexrr(r,0);
}
void enc_evex_modrm_rm_kreg(xed_enc2_req_t* r,
                            xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_rm(r, offset & 7);
    //set_rexb(r,0);   // ZERO OPTIMIZATION
    //set_rexx(r,0);
}

void enc_vex_vvvv_kreg(xed_enc2_req_t* r,     
                           xed_reg_enum_t dst) {  ///VEX
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_vvvv(r, offset & 7);
}
void enc_modrm_reg_kreg(xed_enc2_req_t* r,
                        xed_reg_enum_t dst) { ///VEX
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r,0); // gets inverted on vex emit
}
void enc_modrm_rm_kreg(xed_enc2_req_t* r,
                       xed_reg_enum_t dst) { ///VEX
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST; 
    set_rm(r, offset & 7);
    set_rexb(r,0); // gets inverted on vex emit
}


void enc_evex_kmask(xed_enc2_req_t* r,
                    xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MASK_FIRST;
    set_evexaaa(r, offset & 7);
}

// evex registers vvvv, modrm.reg, modrm.rm for xmm, ymm, zmm
void enc_evex_vvvv_reg_xmm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r, (offset >> 4) & 1);    
}
void enc_evex_modrm_reg_xmm(xed_enc2_req_t* r,
                            xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_xmm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexx(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_ymm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r, (offset >> 4) & 1);    
}
void enc_evex_modrm_reg_ymm(xed_enc2_req_t* r,
                            xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_ymm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexx(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_zmm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ZMM_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r, (offset >> 4) & 1);    
}
void enc_evex_modrm_reg_zmm(xed_enc2_req_t* r,
                            xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ZMM_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_zmm(xed_enc2_req_t* r,
                           xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ZMM_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexx(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_gpr8(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR8_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_modrm_reg_gpr8(xed_enc2_req_t* r,
                              xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR8_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_gpr8(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR8_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_gpr16(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_modrm_reg_gpr16(xed_enc2_req_t* r,
                              xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_gpr16(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_gpr32(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_modrm_reg_gpr32(xed_enc2_req_t* r,
                              xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_gpr32(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}



void enc_evex_vvvv_reg_gpr64(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r,(offset >> 4) & 1);
}
void enc_evex_modrm_reg_gpr64(xed_enc2_req_t* r,
                              xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
void enc_evex_modrm_rm_gpr64(xed_enc2_req_t* r,
                             xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}



/// AVX register

void enc_vvvv_reg_xmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_vvvv(r, offset & 15);
}
void enc_vvvv_reg_ymm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_vvvv(r, offset & 15);
}

#if defined(XED_REG_TREG_FIRST_DEFINED)
void enc_vvvv_reg_tmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_vvvv(r, offset & 7);
}

void enc_modrm_reg_tmm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_reg(r, offset & 7);
    //set_rexr(r,0); // zero init optimization
}

void enc_modrm_rm_tmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_rm(r, offset & 7);
    //set_rexb(r,0); // zero init optimization
}

void enc_evex_modrm_reg_tmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}

void enc_evex_modrm_rm_tmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexx(r, (offset >> 4) & 1);
}

void enc_evex_vvvv_reg_tmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_TREG_FIRST;
    set_vvvv(r, offset & 15);
    set_evexvv(r,  (offset >> 4) & 1);
}

#endif

void enc_dfv(xed_enc2_req_t* r, xed_reg_enum_t dst){
    xed_uint_t offset =  dst-XED_REG_DFV0;
    set_vvvv(r, offset & 15);
}

void enc_vvvv_reg_gpr32(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_vvvv(r, offset & 15);
}
void enc_vvvv_reg_gpr64(xed_enc2_req_t* r,
                        xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_vvvv(r, offset & 15);
}



void enc_modrm_rm_x87(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ST0;
    set_rm(r, offset & 7);
}
void enc_modrm_reg_xmm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r,(offset >> 3) & 1);
}
void enc_modrm_rm_xmm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r,(offset >> 3) & 1);
}
void enc_modrm_reg_ymm(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r,(offset >> 3) & 1);
}

void enc_modrm_rm_ymm(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_rm(r, offset & 7);
    set_rexb(r,(offset >> 3) & 1);
}


/// MMX registers

void enc_modrm_reg_mmx(xed_enc2_req_t* r,
                       xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MMX0;
    set_reg(r, offset & 7);
}
void enc_modrm_rm_mmx(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_MMX0;
    set_rm(r, offset & 7);
}

/// GPRs

void enc_modrm_reg_gpr8(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    /* encode modrm.reg with a register.  Might imply a rex bit setting */
    xed_uint_t offset = dst-XED_REG_GPR8_FIRST;   
    if (dst >= XED_REG_AH && dst <= XED_REG_BH)
        offset = dst-XED_REG_GPR8h_FIRST+4;  // AH,CH,DH,BH
   
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
    //SPL, BPL, SIL, DIL need REX no matter what
    if (dst >= XED_REG_SPL && dst <= XED_REG_DIL)
        set_need_rex(r);
}
    
void enc_modrm_rm_gpr8(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    /* encode modrm.rm with a register */
    xed_uint_t offset = dst-XED_REG_GPR8_FIRST; 
    if (dst >= XED_REG_AH && dst <= XED_REG_BH)
        offset = dst-XED_REG_GPR8h_FIRST+4;  // AH,CH,DH,BH

    set_mod(r, 3);
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
    //SPL, BPL, SIL, DIL need REX no matter what
    if (dst >= XED_REG_SPL && dst <= XED_REG_DIL)
        set_need_rex(r);
}

void enc_modrm_reg_gpr16(xed_enc2_req_t* r,
                         xed_reg_enum_t dst) {
    /* encode modrm.reg with a register.  Might imply a rex bit setting */
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
    
void enc_modrm_rm_gpr16(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    /* encode modrm.rm with a register */
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_mod(r, 3);
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}





void enc_modrm_reg_gpr32(xed_enc2_req_t* r,
                       xed_reg_enum_t dst) {
    /* encode modrm.reg with a register.  Might imply a rex bit setting */
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
    
void enc_modrm_rm_gpr32(xed_enc2_req_t* r,
                      xed_reg_enum_t dst) {
    /* encode modrm.rm with a register */
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_mod(r, 3);
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}



void enc_modrm_reg_gpr64(xed_enc2_req_t* r,
                       xed_reg_enum_t dst) {
    /* encode modrm.reg with a register.  Might imply a rex bit setting */
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_reg(r, offset & 7);
    set_rexr(r, (offset >> 3) & 1);
    set_rexr4(r, (offset >> 4) & 1);
}
    
void enc_modrm_rm_gpr64(xed_enc2_req_t* r,
                        xed_reg_enum_t dst) {
    /* encode modrm.rm with a register */
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_mod(r, 3);
    set_rm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}


 // partial opcode _SRM field

void enc_srm_gpr8(xed_enc2_req_t* r,
                   xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR8_FIRST;
    if (dst >= XED_REG_AH && dst <= XED_REG_BH)
        offset = dst-XED_REG_GPR8h_FIRST+4;  // AH,CH,DH,BH

    set_srm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
    
    //SPL, BPL, SIL, DIL need REX no matter what
    if (dst >= XED_REG_SPL && dst <= XED_REG_DIL)
        set_need_rex(r);
}

void enc_srm_gpr16(xed_enc2_req_t* r,
                   xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR16_FIRST;
    set_srm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}
void enc_srm_gpr32(xed_enc2_req_t* r,
                   xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR32_FIRST;
    set_srm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}
void enc_srm_gpr64(xed_enc2_req_t* r,
                   xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_GPR64_FIRST;
    set_srm(r, offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    set_rexb4(r, (offset >> 4) & 1);
}

void enc_imm8_reg_xmm(xed_enc2_req_t* r, // _SE imm8 reg
                      xed_reg_enum_t dst) { 
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_imm8_reg(r, offset<<4);
}
void enc_imm8_reg_ymm(xed_enc2_req_t* r,  // _SE imm8 reg
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_imm8_reg(r, offset<<4);
}

void enc_imm8_reg_xmm_and_imm(xed_enc2_req_t* r, // _SE imm8 reg
                              xed_reg_enum_t dst,
                              xed_uint_t imm) { 
    xed_uint_t offset =  dst-XED_REG_XMM_FIRST;
    set_imm8_reg(r, (offset<<4)|imm);
}
void enc_imm8_reg_ymm_and_imm(xed_enc2_req_t* r,  // _SE imm8 reg
                              xed_reg_enum_t dst,
                              xed_uint_t imm) {
    xed_uint_t offset =  dst-XED_REG_YMM_FIRST;
    set_imm8_reg(r, (offset<<4)|imm);
}

// CRs and DRs, SEG regs

void enc_modrm_reg_cr(xed_enc2_req_t* r,  
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_CR_FIRST;
    set_reg(r, offset&7);
    set_rexr(r, (offset >> 3) & 1);
}
void enc_modrm_reg_dr(xed_enc2_req_t* r, 
                      xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_DR_FIRST;
    set_reg(r, offset&7);
}
void enc_modrm_reg_seg(xed_enc2_req_t* r, 
                       xed_reg_enum_t dst) {
    xed_uint_t offset =  dst-XED_REG_ES;
    set_reg(r, offset&7);
}


void emit_modrm_sib(xed_enc2_req_t* r) {
    emit_modrm(r);
    // some base reg encodings require sib and some of those require modrm
    // some base reg encodings require disp (rip-rel)
    if (get_has_sib(r))
        emit_sib(r);
}

////////////////////////////////////////

/// ERROR HANDLING

static xed_user_abort_handler_t* user_abort_handler = 0;

void xed_enc2_set_error_handler(xed_user_abort_handler_t* fn) {
    user_abort_handler = fn;
}

void xed_enc2_error(const char* fmt, ...) { 
    va_list args;

    if (user_abort_handler) {
        va_start(args, fmt);
        (*user_abort_handler)(fmt, args);
        va_end(args);
    }
    else {
        printf("XED ENC2 ERROR: ");
        va_start(args, fmt);
        vprintf(fmt, args);
        va_end(args);
        printf(".\n");
    }
    abort(); 
}


///////////////////////////////////



static void scale_test_and_set(xed_enc2_req_t* r, xed_uint_t scale) {
    static const xed_uint_t scale_encode[9] = { 9,0,1,9, 2,9,9,9, 3};
    xed_uint8_t e;
    if (scale > 8)
        xed_enc2_error( "bad scale value");
    e = scale_encode[scale];
    if (e > 8)
        xed_enc2_error( "bad scale value");
    set_sibscale(r, e);
}


// 64b addressing

static void enc_modrm_rm_mem_disp_a64_internal(xed_enc2_req_t* r,
                                               xed_reg_enum_t base,
                                               xed_reg_enum_t indx,
                                               xed_uint_t scale)
{
    //a64 = address size 64
    // FIXME: range test base & index for GPR64 + INVALID
    xed_uint_t offset = base - XED_REG_GPR64_FIRST;

    if (base == XED_REG_RIP) {
        if (get_mod(r) == 1)
            xed_enc2_error("Wrong size displacement for RIP relative addressing");
        set_mod(r,0); // disp32 for RIP-rel
        set_rm(r,5);
        if (indx != XED_REG_INVALID)
            xed_enc2_error( "cannot have index register with RIP as base");
    }
    else if (base == XED_REG_INVALID ||
             base == XED_REG_RSP ||
             base == XED_REG_R12 ||
             base == XED_REG_R20 ||
             base == XED_REG_R28 ||
             indx != XED_REG_INVALID) {         // need sib
        xed_uint_t offset_indx;
        set_has_sib(r);
        set_rm(r,4);

        if (base == XED_REG_INVALID) {
            set_sibbase(r,5);
        }
        else { 
            set_sibbase(r, offset & 7);
            set_rexb(r, (offset >> 3) & 1);
            set_rexb4(r, (offset >> 4) & 1);
        }
        
        // nothing speical required if base == XED_REG_RBP or XED_REG_R13
        // since we already have a displacment; the mod field will be set
        // to 1 or 2.

        if (indx == XED_REG_INVALID) {
            set_sibindex(r,4);
        }
        else {
            offset_indx = indx - XED_REG_GPR64_FIRST;
            if (indx == XED_REG_RSP)
                xed_enc2_error( "bad index register == RSP");
            set_sibindex(r,offset_indx & 7);
            set_rexx(r, (offset_indx >> 3) & 1);
            set_rexx4(r, (offset_indx >> 4) & 1);

            scale_test_and_set(r, scale);
        }
    }
    else { // reasonable base, no index
        set_rm(r, offset & 7);
        set_rexb(r, (offset >> 3) & 1);
        set_rexb4(r, (offset >> 4) & 1);
    }
}
static void enc_modrm_rm_mem_nodisp_a64_internal(xed_enc2_req_t* r,
                                                 xed_reg_enum_t base,
                                                 xed_reg_enum_t indx,
                                                 xed_uint_t scale)
{
    //a64 = address size 64
    // FIXME: range test base & index for GPR64 + INVALID
    xed_uint_t offset = base - XED_REG_GPR64_FIRST;

    if (base == XED_REG_RIP) {
        set_has_disp32(r);// supply a fake zero valued disp
        set_rm(r,5);
        if (indx != XED_REG_INVALID)
            xed_enc2_error( "cannot have index register with RIP as base");
    }
    else if (base == XED_REG_INVALID ||
             base == XED_REG_RSP ||
             base == XED_REG_R12 ||
             base == XED_REG_RBP ||
             base == XED_REG_R13 ||
             base == XED_REG_R20 ||
             base == XED_REG_R21 ||
             base == XED_REG_R28 ||
             base == XED_REG_R29 ||
             indx != XED_REG_INVALID) {        // need sib
        xed_uint_t offset_indx;
     
        set_has_sib(r);
        set_rm(r,4);

        if (base == XED_REG_INVALID) {
            set_sibbase(r,5);
        }
        else { 
            set_sibbase(r, offset & 7);
            set_rexb(r, (offset >> 3) & 1);
            set_rexb4(r, (offset >> 4) & 1);
        }
        
        if ( base == XED_REG_RBP ||
             base == XED_REG_R13 ||
             base == XED_REG_R21 ||
             base == XED_REG_R29) {
            set_mod(r,1);              // potentially overwriting earlier setting
            set_has_disp8(r);          // force a disp8 with value 0.
        }

        if (indx == XED_REG_INVALID) {
            set_sibindex(r,4);
        }
        else {
            offset_indx = indx - XED_REG_GPR64_FIRST;
            if (indx == XED_REG_RSP)
                xed_enc2_error( "bad index register == RSP");
            set_sibindex(r,offset_indx & 7);
            set_rexx(r, (offset_indx >> 3) & 1);
            set_rexx4(r, (offset_indx >> 4) & 1);

            scale_test_and_set(r, scale);
        }
    }
    else { // reasonable base, no index
        set_rm(r,offset & 7);
        set_rexb(r, (offset >> 3) & 1);
        set_rexb4(r, (offset >> 4) & 1);
    }
}

void enc_modrm_rm_mem_bisd32_a64(xed_enc2_req_t* r,
                                 xed_reg_enum_t base,
                                 xed_reg_enum_t indx,
                                 xed_uint_t scale)
{
    set_mod(r,2); 
    enc_modrm_rm_mem_disp_a64_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_bd32_a64(xed_enc2_req_t* r,
                                   xed_reg_enum_t base)
{
    set_mod(r,2); 
    enc_modrm_rm_mem_disp_a64_internal(r,base,XED_REG_INVALID,0);
}
void enc_modrm_rm_mem_bisd8_a64(xed_enc2_req_t* r,
                                xed_reg_enum_t base,
                                xed_reg_enum_t indx,
                                xed_uint_t scale)
{
    set_mod(r,1); 
    enc_modrm_rm_mem_disp_a64_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_bd8_a64(xed_enc2_req_t* r,
                              xed_reg_enum_t base)
{
    set_mod(r,1); 
    enc_modrm_rm_mem_disp_a64_internal(r,base,XED_REG_INVALID,0);
}
void enc_modrm_rm_mem_bis_a64(xed_enc2_req_t* r,
                              xed_reg_enum_t base,
                              xed_reg_enum_t indx,
                              xed_uint_t scale)
{
    set_mod(r,0); // no-disp (may be overwritten if funky base specified)
    enc_modrm_rm_mem_nodisp_a64_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_b_a64(xed_enc2_req_t* r,
                            xed_reg_enum_t base)
{
    set_mod(r,0); // no-disp (may be overwritten if funky base specified)
    enc_modrm_rm_mem_nodisp_a64_internal(r,base,XED_REG_INVALID,0);
}


// 64b avx2 vsib

static void enc_modrm_vsib_bis_a64_internal_nodisp(xed_enc2_req_t* r,
                                                   xed_reg_enum_t base,
                                                   xed_reg_enum_t indx,
                                                   xed_uint_t scale,
                                                   xed_reg_enum_t vreg_first) {
    const xed_uint_t index_offset = indx-vreg_first;
    const xed_uint_t base_offset  = base-XED_REG_GPR64_FIRST;
    set_mod(r,0); // no-disp (may be overwritten if funky base specified)
    set_rm(r,4); // need sib
    set_has_sib(r);

    
    set_sibindex(r, index_offset & 7); // encode x/y/zmm as sibscale
    set_rexx(r, (index_offset >> 3) & 1);
    set_evexvv(r, (index_offset >> 4) & 1);
    
    scale_test_and_set(r,scale);

    if (base == XED_REG_RBP ||
        base == XED_REG_R13 ||
        base == XED_REG_R21 ||
        base == XED_REG_R29) {
        set_mod(r,1);              // overwriting earlier setting
        set_has_disp8(r);          // force a disp8 with value 0.
    }
    set_sibbase(r,base_offset & 7);
    set_rexb(r, (base_offset >> 3) & 1);
    set_rexb4(r, (base_offset >> 4) & 1);
}
static void enc_modrm_vsib_a64_internal_disp(xed_enc2_req_t* r,
                                             xed_reg_enum_t base,
                                             xed_reg_enum_t indx,
                                             xed_uint_t scale,
                                             xed_reg_enum_t vreg_first) {
    const xed_uint_t index_offset = indx-vreg_first;
    const xed_uint_t base_offset  = base-XED_REG_GPR64_FIRST;
    set_rm(r,4); // need sib
    set_has_sib(r);
    
    set_sibindex(r, index_offset & 7); // encode xmm as sibscale
    set_rexx(r, (index_offset >> 3) & 1);
    set_evexvv(r, (index_offset >> 4) & 1);
    
    scale_test_and_set(r,scale);

    set_sibbase(r,base_offset & 7);
    set_rexb(r, (base_offset >> 3) & 1);
    set_rexb4(r, (base_offset >> 4) & 1);
}


void enc_avx_modrm_vsib_xmm_bis_a64(xed_enc2_req_t* r,
                                    xed_reg_enum_t base,
                                    xed_reg_enum_t indx,
                                    xed_uint_t scale) {
    enc_modrm_vsib_bis_a64_internal_nodisp(r,base,indx,scale,XED_REG_XMM_FIRST);
}



void enc_avx_modrm_vsib_xmm_bisd8_a64(xed_enc2_req_t* r,
                                      xed_reg_enum_t base,
                                      xed_reg_enum_t indx,
                                      xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx_modrm_vsib_xmm_bisd32_a64(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}

void enc_avx_modrm_vsib_ymm_bis_a64(xed_enc2_req_t* r,
                                    xed_reg_enum_t base,
                                    xed_reg_enum_t indx,
                                    xed_uint_t scale) {
    enc_modrm_vsib_bis_a64_internal_nodisp(r,base,indx,scale,XED_REG_YMM_FIRST);
}

void enc_avx_modrm_vsib_ymm_bisd8_a64(xed_enc2_req_t* r,
                                      xed_reg_enum_t base,
                                      xed_reg_enum_t indx,
                                      xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx_modrm_vsib_ymm_bisd32_a64(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


// 64b avx512 vsib

void enc_avx512_modrm_vsib_xmm_bis_a64(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a64_internal_nodisp(r,base,indx,scale,XED_REG_XMM_FIRST);
}

void enc_avx512_modrm_vsib_xmm_bisd8_a64(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_xmm_bisd32_a64(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


void enc_avx512_modrm_vsib_ymm_bis_a64(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a64_internal_nodisp(r,base,indx,scale,XED_REG_YMM_FIRST);
}

void enc_avx512_modrm_vsib_ymm_bisd8_a64(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_ymm_bisd32_a64(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


void enc_avx512_modrm_vsib_zmm_bis_a64(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a64_internal_nodisp(r,base,indx,scale,XED_REG_ZMM_FIRST);
}

void enc_avx512_modrm_vsib_zmm_bisd8_a64(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_ZMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_zmm_bisd32_a64(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a64_internal_disp(r,base,indx,scale, XED_REG_ZMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}




/// 32b addressing

static void enc_modrm_rm_mem_disp_a32_internal(xed_enc2_req_t* r,
                                               xed_reg_enum_t base,
                                               xed_reg_enum_t indx,
                                               xed_uint_t scale)
{
    //a32  (32b mode or 64b mode)  for MOD=1 (disp8) or MOD=2 (disp32)
    // FIXME: better not have rex.b or rex.x set in 32b mode
    // FIXME: range test base & index for GPR32 + INVALID
    xed_uint_t offset = base - XED_REG_GPR32_FIRST;

    if (base == XED_REG_INVALID ||
        base == XED_REG_ESP ||
        base == XED_REG_R12D ||
        base == XED_REG_R20D ||
        base == XED_REG_R28D ||
        indx != XED_REG_INVALID) {
        xed_uint_t offset_indx;
        // need sib
        set_has_sib(r);
        set_rm(r,4);
        if (base == XED_REG_INVALID) {
            set_sibbase(r,5);
        }
        else { 
            set_sibbase(r, offset & 7);
            set_rexb(r, (offset >> 3) & 1);
            set_rexb4(r, (offset >> 4) & 1);
        }

        if (indx == XED_REG_INVALID) {
            set_sibindex(r,4);
        }
        else {
            offset_indx = indx - XED_REG_GPR32_FIRST;
            if (indx == XED_REG_ESP)
                xed_enc2_error( "bad index register == ESP");
            set_sibindex(r,offset_indx & 7);
            set_rexx(r, (offset_indx >> 3) & 1);
            set_rexx4(r, (offset_indx >> 4) & 1);

            scale_test_and_set(r, scale);
        }
    }
    else { // reasonable base, no index
        set_rm(r,offset & 7);
        set_rexb(r, (offset >> 3) & 1);
        set_rexb4(r, (offset >> 4) & 1);
    }
}

static void enc_modrm_rm_mem_nodisp_a32_internal(xed_enc2_req_t* r,
                                                 xed_reg_enum_t base,
                                                 xed_reg_enum_t indx,
                                                 xed_uint_t scale)
{
    //a32  (32b mode or 64b mode)
    // FIXME: better not have rex.b or rex.x set in 32b mode
    // FIXME: range test base & index for GPR32 + INVALID
    
    // Note: using EBP or R13 as a base register requires that we add a
    // displacement. We add a disp8 with the value 0.
    
    xed_uint_t offset = base - XED_REG_GPR32_FIRST;

    if (base == XED_REG_INVALID ||
        base == XED_REG_ESP     ||
        base == XED_REG_R12D    ||
        base == XED_REG_EBP     ||
        base == XED_REG_R13D    ||
        base == XED_REG_R20D    ||
        base == XED_REG_R21D    ||
        base == XED_REG_R28D    ||
        base == XED_REG_R29D    ||
        indx != XED_REG_INVALID  ) {         // need sib
        xed_uint_t offset_indx;

        set_has_sib(r);
        set_rm(r,4);
        if (base == XED_REG_INVALID) {
            set_sibbase(r,5);
        }
        else { 
            set_sibbase(r, offset & 7);
            set_rexb(r, (offset >> 3) & 1);
            set_rexb4(r, (offset >> 4) & 1);
        }
        if (base == XED_REG_EBP  || 
            base == XED_REG_R13D ||
            base == XED_REG_R21D ||
            base == XED_REG_R29D) {
            set_mod(r,1);              // potentially overwriting earlier setting
            set_has_disp8(r);          // force a disp8 with value 0.
        }

        if (indx == XED_REG_INVALID) {
            set_sibindex(r,4);
        }
        else {
            offset_indx = indx - XED_REG_GPR32_FIRST;
            if (indx == XED_REG_ESP)
                xed_enc2_error( "bad index register == ESP");
            set_sibindex(r,offset_indx & 7);
            set_rexx(r, (offset_indx >> 3) & 1);
            set_rexx4(r,(offset_indx >> 4) & 1);
                           
            scale_test_and_set(r, scale);
        }
    }
    else { // reasonable base, no index
        set_rm(r,offset & 7);
        set_rexb(r, (offset >> 3) & 1);
        set_rexb4(r, (offset >> 4) & 1);
    }
}



void enc_modrm_rm_mem_bisd32_a32(xed_enc2_req_t* r,
                                 xed_reg_enum_t base,
                                 xed_reg_enum_t indx,
                                 xed_uint_t scale)
{
    set_mod(r,2); // disp32
    enc_modrm_rm_mem_disp_a32_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_bd32_a32(xed_enc2_req_t* r,
                               xed_reg_enum_t base)
{
    set_mod(r,2); // disp32
    enc_modrm_rm_mem_disp_a32_internal(r,base,XED_REG_INVALID,0);
}
void enc_modrm_rm_mem_bisd8_a32(xed_enc2_req_t* r,
                                xed_reg_enum_t base,
                                xed_reg_enum_t indx,
                                xed_uint_t scale)
{
    set_mod(r,1); // disp8
    enc_modrm_rm_mem_disp_a32_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_bd8_a32(xed_enc2_req_t* r,
                              xed_reg_enum_t base)
{
    set_mod(r,1); // disp8
    enc_modrm_rm_mem_disp_a32_internal(r,base,XED_REG_INVALID,0);
}
void enc_modrm_rm_mem_bis_a32(xed_enc2_req_t* r,
                              xed_reg_enum_t base,
                              xed_reg_enum_t indx,
                              xed_uint_t scale)
{
    set_mod(r,0); // no-disp (may be overwritten if EBP/R13D used as base)
    enc_modrm_rm_mem_nodisp_a32_internal(r,base,indx,scale);
}
void enc_modrm_rm_mem_b_a32(xed_enc2_req_t* r,
                            xed_reg_enum_t base)

{
    set_mod(r,0); // no-disp (may be overwritten if EBP/R13D used as base)
    enc_modrm_rm_mem_nodisp_a32_internal(r,base,XED_REG_INVALID,0);
}





static void enc_modrm_vsib_bis_a32_internal_nodisp(xed_enc2_req_t* r,
                                                   xed_reg_enum_t base,
                                                   xed_reg_enum_t indx,
                                                   xed_uint_t scale,
                                                   xed_reg_enum_t vreg_first) {
    const xed_uint_t index_offset = indx-vreg_first;
    const xed_uint_t base_offset  = base-XED_REG_GPR32_FIRST;
    set_mod(r,0); // no-disp (may be overwritten if funky base specified)
    set_rm(r,4); // need sib
    set_has_sib(r);
    
    set_sibindex(r, index_offset & 7); // encode xmm as sibscale
    set_rexx(r, (index_offset >> 3) & 1);
    set_evexvv(r, (index_offset >> 4) & 1);
    
    scale_test_and_set(r,scale);

    if (base == XED_REG_EBP  || 
        base == XED_REG_R13D ||
        base == XED_REG_R21D ||
        base == XED_REG_R29D) {
        set_mod(r,1);              // overwriting earlier setting
        set_has_disp8(r);          // force a disp8 with value 0.
    }
    set_sibbase(r,base_offset & 7);
    set_rexb(r, (base_offset >> 3) & 1);
    set_rexb4(r, (base_offset >> 4) & 1);
}
static void enc_modrm_vsib_a32_internal_disp(xed_enc2_req_t* r,
                                             xed_reg_enum_t base,
                                             xed_reg_enum_t indx,
                                             xed_uint_t scale,
                                             xed_reg_enum_t vreg_first) {
    const xed_uint_t index_offset = indx-vreg_first;
    const xed_uint_t base_offset  = base-XED_REG_GPR32_FIRST;
    set_rm(r,4); // need sib
    set_has_sib(r);
    
    set_sibindex(r, index_offset & 7); // encode xmm as sibscale
    set_rexx(r, (index_offset >> 3) & 1);
    set_evexvv(r, (index_offset >> 4) & 1);
    
    scale_test_and_set(r,scale);

    set_sibbase(r,base_offset & 7);
    set_rexb(r, (base_offset >> 3) & 1);
    set_rexb4(r, (base_offset >> 4) & 1);
}


void enc_avx_modrm_vsib_xmm_bis_a32(xed_enc2_req_t* r,
                                    xed_reg_enum_t base,
                                    xed_reg_enum_t indx,
                                    xed_uint_t scale) {
    enc_modrm_vsib_bis_a32_internal_nodisp(r,base,indx,scale,XED_REG_XMM_FIRST);
}



void enc_avx_modrm_vsib_xmm_bisd8_a32(xed_enc2_req_t* r,
                                      xed_reg_enum_t base,
                                      xed_reg_enum_t indx,
                                      xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx_modrm_vsib_xmm_bisd32_a32(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}

void enc_avx_modrm_vsib_ymm_bis_a32(xed_enc2_req_t* r,
                                    xed_reg_enum_t base,
                                    xed_reg_enum_t indx,
                                    xed_uint_t scale) {
    enc_modrm_vsib_bis_a32_internal_nodisp(r,base,indx,scale,XED_REG_YMM_FIRST);
}

void enc_avx_modrm_vsib_ymm_bisd8_a32(xed_enc2_req_t* r,
                                      xed_reg_enum_t base,
                                      xed_reg_enum_t indx,
                                      xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx_modrm_vsib_ymm_bisd32_a32(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


// 64b avx512 vsib

void enc_avx512_modrm_vsib_xmm_bis_a32(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a32_internal_nodisp(r,base,indx,scale,XED_REG_XMM_FIRST);
}

void enc_avx512_modrm_vsib_xmm_bisd8_a32(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_xmm_bisd32_a32(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_XMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


void enc_avx512_modrm_vsib_ymm_bis_a32(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a32_internal_nodisp(r,base,indx,scale,XED_REG_YMM_FIRST);
}

void enc_avx512_modrm_vsib_ymm_bisd8_a32(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_ymm_bisd32_a32(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_YMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}


void enc_avx512_modrm_vsib_zmm_bis_a32(xed_enc2_req_t* r,
                                       xed_reg_enum_t base,
                                       xed_reg_enum_t indx,
                                       xed_uint_t scale) {
    enc_modrm_vsib_bis_a32_internal_nodisp(r,base,indx,scale,XED_REG_ZMM_FIRST);
}

void enc_avx512_modrm_vsib_zmm_bisd8_a32(xed_enc2_req_t* r,
                                         xed_reg_enum_t base,
                                         xed_reg_enum_t indx,
                                         xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_ZMM_FIRST);
    set_mod(r,1); // disp8
    set_has_disp8(r); 
}

void enc_avx512_modrm_vsib_zmm_bisd32_a32(xed_enc2_req_t* r,
                                          xed_reg_enum_t base,
                                          xed_reg_enum_t indx,
                                          xed_uint_t scale) {
    enc_modrm_vsib_a32_internal_disp(r,base,indx,scale, XED_REG_ZMM_FIRST);
    set_mod(r,2); // disp32
    set_has_disp32(r); 
}









// 16b addressing

static void enc_modrm_rm_mem_nodisp_a16_internal(xed_enc2_req_t* r,
                                                 xed_reg_enum_t base,
                                                 xed_reg_enum_t indx)
{
    //FIXME: replace with a table.
    // this has no disp, except for the no-base-or-index case (MOD=00)
    switch(base) {
      case XED_REG_BX:
        switch(indx) {
          case XED_REG_SI:            set_rm(r,0); break;
          case XED_REG_DI:            set_rm(r,1); break;
          case XED_REG_INVALID:       set_rm(r,7); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_BP:
        switch(indx) {
          case XED_REG_SI:            set_rm(r,2); break;
          case XED_REG_DI:            set_rm(r,3); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_INVALID:  // look at index
        switch(indx) {
          case XED_REG_BX:            set_rm(r,7); break;
          case XED_REG_SI:            set_rm(r,4); break;
          case XED_REG_DI:            set_rm(r,5); break;
          case XED_REG_INVALID:       set_rm(r,6); break; // disp16!
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_SI:
        switch(indx) {
          case XED_REG_BX:            set_rm(r,0); break;
          case XED_REG_BP:            set_rm(r,3); break;
          case XED_REG_INVALID:       set_rm(r,4); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_DI:
        switch(indx) {
          case XED_REG_BX:            set_rm(r,1); break;
          case XED_REG_BP:            set_rm(r,3); break;
          case XED_REG_INVALID:       set_rm(r,5); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      default:
        xed_enc2_error("Bad 16b base reg");
    }
}



static void enc_modrm_rm_mem_a16_disp_internal(xed_enc2_req_t* r,
                                               xed_reg_enum_t base,
                                               xed_reg_enum_t indx)
{
    //FIXME: replace with a table.
    // this has a disp8 or disp16 (MOD=1 or 2)
    switch(base) {
      case XED_REG_BX:
        switch(indx) {
          case XED_REG_SI:            set_rm(r,0); break;
          case XED_REG_DI:            set_rm(r,1); break;
          case XED_REG_INVALID:       set_rm(r,7); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_BP:
        switch(indx) {
          case XED_REG_SI:            set_rm(r,2); break;
          case XED_REG_DI:            set_rm(r,3); break;
          case XED_REG_INVALID:       set_rm(r,6); break; 
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_INVALID:  // look at index
        switch(indx) {
          case XED_REG_BX:            set_rm(r,7); break;
          case XED_REG_BP:            set_rm(r,6); break;
          case XED_REG_SI:            set_rm(r,4); break;
          case XED_REG_DI:            set_rm(r,5); break;

          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_SI:
        switch(indx) {
          case XED_REG_BX:            set_rm(r,0); break;
          case XED_REG_BP:            set_rm(r,3); break;
          case XED_REG_INVALID:       set_rm(r,4); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      case XED_REG_DI:
        switch(indx) {
          case XED_REG_BX:            set_rm(r,1); break;
          case XED_REG_BP:            set_rm(r,3); break;
          case XED_REG_INVALID:       set_rm(r,5); break;
          default:
            xed_enc2_error("Bad 16b index reg");
        }; break;
      default:
        xed_enc2_error("Bad 16b base reg");
    }
}

void enc_modrm_rm_mem_bi_a16(xed_enc2_req_t* r,
                                 xed_reg_enum_t base,
                                 xed_reg_enum_t indx)
{
    set_mod(r,0);
    enc_modrm_rm_mem_nodisp_a16_internal(r,base,indx);
}
void enc_modrm_rm_mem_b_a16(xed_enc2_req_t* r,
                            xed_reg_enum_t base)
{
    set_mod(r,0);
    enc_modrm_rm_mem_nodisp_a16_internal(r,base,XED_REG_INVALID);
}
void enc_modrm_rm_mem_bid8_a16(xed_enc2_req_t* r,
                                xed_reg_enum_t base,
                                xed_reg_enum_t indx)
{
    set_mod(r,1);
    enc_modrm_rm_mem_a16_disp_internal(r,base,indx);
}
void enc_modrm_rm_mem_bd8_a16(xed_enc2_req_t* r,
                                xed_reg_enum_t base)
{
    set_mod(r,1);
    enc_modrm_rm_mem_a16_disp_internal(r,base,XED_REG_INVALID);
}
void enc_modrm_rm_mem_bid16_a16(xed_enc2_req_t* r,
                                xed_reg_enum_t base,
                                xed_reg_enum_t indx)
{
    set_mod(r,2);
    enc_modrm_rm_mem_a16_disp_internal(r,base,indx);
}
void enc_modrm_rm_mem_bd16_a16(xed_enc2_req_t* r,
                                 xed_reg_enum_t base)
{
    set_mod(r,2);
    enc_modrm_rm_mem_a16_disp_internal(r,base,XED_REG_INVALID);
}

/// handling partial opcodes

xed_uint8_t emit_partial_opcode_and_rmreg(xed_enc2_req_t* r,
                                          xed_uint8_t opcode,
                                          xed_reg_enum_t rmreg,
                                          xed_reg_enum_t first)
{
    xed_uint_t offset = rmreg - first;
    xed_uint8_t opcode_out = opcode | (offset & 7);
    set_rexb(r, (offset >> 3) & 1);
    return opcode_out;
}
xed_uint8_t emit_partial_opcode_and_rmreg_gpr16(xed_enc2_req_t* r,
                                                xed_uint8_t opcode,
                                                xed_reg_enum_t rmreg)
{
    return emit_partial_opcode_and_rmreg(r,opcode,rmreg, XED_REG_GPR16_FIRST);
}
xed_uint8_t emit_partial_opcode_and_rmreg_gpr32(xed_enc2_req_t* r,
                                                xed_uint8_t opcode,
                                                xed_reg_enum_t rmreg)
{
    return emit_partial_opcode_and_rmreg(r,opcode,rmreg, XED_REG_GPR32_FIRST);
}
xed_uint8_t emit_partial_opcode_and_rmreg_gpr64(xed_enc2_req_t* r,
                                                xed_uint8_t opcode,
                                                xed_reg_enum_t rmreg)
{
    return emit_partial_opcode_and_rmreg(r,opcode,rmreg, XED_REG_GPR64_FIRST);
}


void xed_emit_seg_prefix(xed_enc2_req_t* r,
                         xed_reg_enum_t reg) {
    static const xed_uint8_t seg_prefixes[] = { 0x26, 0x2e, 0x36, 0x3e, 0x64, 0x65 };
    if (reg >= XED_REG_ES && reg <= XED_REG_GS) {
        xed_uint_t offset = reg - XED_REG_ES;
        emit_u8(r,seg_prefixes[offset]);
    }
    else {
        xed_enc2_error("Bad segment register prefix");
    }
}

xed_int32_t xed_chose_evex_scaled_disp(xed_enc2_req_t* r,
                                       xed_int32_t requested_displacement,
                                       xed_uint32_t reference_width_bytes)
{
    xed_int32_t scaled_displacement = requested_displacement / reference_width_bytes;
    if (scaled_displacement >= -128 && scaled_displacement <= 127) {
        set_mod(r,1);
        set_has_disp8(r);
        return scaled_displacement;
    }
    set_mod(r,2);
    set_has_disp32(r);
    return requested_displacement;
}

xed_int32_t xed_chose_evex_scaled_disp16(xed_enc2_req_t* r,
                                         xed_int32_t requested_displacement,
                                         xed_uint32_t reference_width_bytes)
{
    xed_int32_t scaled_displacement = requested_displacement / reference_width_bytes;
    if (scaled_displacement >= -128 && scaled_displacement <= 127) {
        set_mod(r,1);
        set_has_disp8(r);
        return scaled_displacement;
    }
    set_mod(r,2);
    set_has_disp16(r);
    return requested_displacement;
}