xdy 0.9.0

Complex RPG dice expression evaluator with histogram support.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
//! # Diagnostics
//!
//! Herein is the diagnostic layer for the `xDy` parser. The [`diagnose`]
//! function analyzes a source string by repeatedly parsing, detecting errors,
//! applying fixes, and re-parsing until all errors are collected. This produces
//! structured [`Diagnostic`]s with specific error kinds, source spans for
//! highlighting, human-readable messages, and suggested fixes — including
//! complete corrected source strings for unambiguous errors and templates with
//! highlighted placeholder regions for ambiguous ones.
//!
//! # Architecture
//!
//! The diagnostic layer is a consumer of the parser's [`ParseError`], not part
//! of the parser itself. The [`compile`](crate::compile) and
//! [`compile_unoptimized`](crate::compile_unoptimized) functions continue to
//! deal in [`ParseError`]; diagnostics are a separate concern for clients that
//! want richer error information (e.g., for IDE integration, syntax
//! highlighting on every keystroke, or autocompletion).
//!
//! # Error Recovery Strategy
//!
//! The doctor uses a **fix-and-retry loop**:
//!
//! ```text
//! ┌──────────────────────────────────────────────────────┐
//! │ parse(current_source)                                │
//! │   ├─ success → return diagnostics + corrected_source │
//! │   └─ error → analyze → apply fix → loop              │
//! └──────────────────────────────────────────────────────┘
//! ```
//!
//! Each fix inserts, removes, or wraps characters in the source string, making
//! progress toward a clean parse. An `OffsetMap` tracks cumulative
//! adjustments so that diagnostic spans are mapped back to positions in the
//! original source. The loop terminates when parsing succeeds or when an
//! unfixable error is encountered.

use std::fmt::{self, Display, Formatter};

use crate::parser::{self, ParseError};

////////////////////////////////////////////////////////////////////////////////
//                                   Types.                                   //
////////////////////////////////////////////////////////////////////////////////

/// A byte range in source text, suitable for highlighting a region.
///
/// # Notes
/// Both `start` and `end` are byte offsets. `end` is exclusive, following the
/// standard Rust range convention.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct SourceSpan
{
	/// The start byte offset (inclusive).
	pub start: usize,

	/// The end byte offset (exclusive).
	pub end: usize
}

impl Display for SourceSpan
{
	fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result
	{
		write!(f, "{}..{}", self.start, self.end)
	}
}

/// The specific kind of diagnostic, indicating what went wrong.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum DiagnosticKind
{
	/// An opening delimiter has no matching close.
	///
	/// # Examples
	/// `(3D6`, `{x`, `[1:6`
	UnclosedDelimiter
	{
		/// The opening delimiter character.
		opener: char,
		/// The expected closing delimiter character.
		expected_closer: char
	},

	/// A closing delimiter has no matching open.
	///
	/// # Examples
	/// `3D6)`, `x}`
	UnopenedDelimiter
	{
		/// The unmatched closing delimiter character.
		closer: char
	},

	/// A binary operator is missing its right operand.
	///
	/// # Examples
	/// `3D6 +`, `1 + * 2`
	MissingRightOperand
	{
		/// The binary operator character.
		operator: char
	},

	/// A binary operator is missing its left operand.
	///
	/// # Examples
	/// `+ 3D6`
	MissingLeftOperand
	{
		/// The binary operator character.
		operator: char
	},

	/// A bare identifier appears where only `{identifier}` is legal.
	///
	/// # Examples
	/// `xD6`, `abcD12`
	BareIdentifier,

	/// A dice operator has no face specification.
	///
	/// # Examples
	/// `3D`, `3d`
	MissingDiceFaces,

	/// A `drop` keyword is not followed by `lowest` or `highest`.
	///
	/// # Examples
	/// `4D6 drop`
	IncompleteDropClause,

	/// A parameter definition is missing the `:` separator and body.
	///
	/// # Examples
	/// `hello`, `x, y`
	IncompleteParameterDefinition,

	/// A valid expression is followed by unparseable input.
	///
	/// # Examples
	/// `3D6)`, `3D6 hello`
	TrailingInput,

	/// The input is empty or contains only whitespace.
	EmptyExpression,

	/// An unexpected token was encountered.
	UnexpectedToken,

	/// The input ended unexpectedly.
	UnexpectedEof
}

impl Display for DiagnosticKind
{
	fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result
	{
		match self
		{
			Self::UnclosedDelimiter { opener, .. } =>
			{
				write!(f, "unclosed `{}`", opener)
			},
			Self::UnopenedDelimiter { closer } =>
			{
				write!(f, "unexpected `{}`", closer)
			},
			Self::MissingRightOperand { operator } =>
			{
				write!(f, "missing right operand of `{}`", operator)
			},
			Self::MissingLeftOperand { operator } =>
			{
				write!(f, "missing left operand of `{}`", operator)
			},
			Self::BareIdentifier => write!(f, "bare identifier"),
			Self::MissingDiceFaces => write!(f, "missing dice faces"),
			Self::IncompleteDropClause =>
			{
				write!(f, "incomplete drop clause")
			},
			Self::IncompleteParameterDefinition =>
			{
				write!(f, "incomplete parameter definition")
			},
			Self::TrailingInput => write!(f, "trailing input"),
			Self::EmptyExpression => write!(f, "empty expression"),
			Self::UnexpectedToken => write!(f, "unexpected token"),
			Self::UnexpectedEof => write!(f, "unexpected end of input")
		}
	}
}

/// A diagnostic produced by the [`doctor`](diagnose).
///
/// # Notes
/// The `span` field refers to byte offsets in the **original** source string
/// passed to [`diagnose`], not in the corrected source.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Diagnostic
{
	/// The specific kind of error.
	pub kind: DiagnosticKind,

	/// The region of source text that is erroneous, as byte offsets in the
	/// original source.
	pub span: SourceSpan,

	/// A human-readable error message.
	pub message: String,

	/// Suggested fixes, from most to least specific.
	pub suggestions: Vec<Suggestion>
}

impl Display for Diagnostic
{
	fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result
	{
		write!(f, "{} ({}): {}", self.kind, self.span, self.message)
	}
}

/// A suggested fix for a diagnostic.
///
/// # Notes
/// The `corrected_source` is a complete, parseable source string. For
/// unambiguous fixes (e.g., `{x` → `{x}`), `placeholders` is empty. For
/// ambiguous fixes (e.g., `3D` → `3D6`), `placeholders` identifies the regions
/// that are defaults and can be replaced by the user.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Suggestion
{
	/// A human-readable description of the fix.
	pub description: String,

	/// The complete corrected source string.
	pub corrected_source: String,

	/// Placeholder regions in the corrected source that the user may want
	/// to replace. Empty for unambiguous fixes.
	pub placeholders: Vec<Placeholder>
}

/// A placeholder region in a corrected source template.
///
/// A sophisticated UI can highlight these regions and present the
/// `valid_kinds` as a picker, allowing the user to type over the default
/// value.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Placeholder
{
	/// The byte range of the placeholder in the corrected source string.
	pub span: SourceSpan,

	/// A description of what belongs here (e.g., "face count", "operand").
	pub description: &'static str,

	/// The kinds of expressions that are valid at this position.
	pub valid_kinds: &'static [&'static str]
}

/// The result of diagnosing a source string.
///
/// # Notes
/// If all errors are fixable, `corrected_source` contains a parseable source
/// string with all fixes applied. If any error is unfixable, `corrected_source`
/// is `None`.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct DiagnoseResult
{
	/// The diagnostics collected during analysis, in source order.
	pub diagnostics: Vec<Diagnostic>,

	/// The fully corrected source string, if all errors were fixable. This
	/// string will parse cleanly via [`parser::parse`].
	pub corrected_source: Option<String>
}

/// Valid expression kinds for operand positions.
const OPERAND_KINDS: &[&str] =
	&["integer", "{variable}", "(expression)", "dice expression"];

/// Valid expression kinds for face count positions.
const FACE_COUNT_KINDS: &[&str] = &["integer", "{variable}", "(expression)"];

/// Valid kinds for drop direction.
const DROP_DIRECTION_KINDS: &[&str] = &["lowest", "highest"];

////////////////////////////////////////////////////////////////////////////////
//                              Error analysis.                               //
////////////////////////////////////////////////////////////////////////////////

/// Analyze a [`ParseError`] and the current source text to produce a
/// [`Diagnostic`] with an appropriate fix.
///
/// # Parameters
/// - `source`: The current (possibly already partially fixed) source text.
/// - `error`: The parse error to analyze.
/// - `offset_map`: Tracks cumulative byte adjustments from prior fixes, used to
///   map positions back to the original source.
///
/// # Returns
/// A diagnostic describing the error, with suggestions for fixing it.
fn analyze_error(
	source: &str,
	error: &ParseError<'_>,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let rightmost = &error.errors[0];
	let pos = rightmost.0.location_offset();
	let at_eof =
		pos >= source.len() || source[pos..].chars().all(char::is_whitespace);

	// Collect all expectations at the rightmost parse position.
	let expectations = error
		.errors
		.iter()
		.take_while(|(span, _)| span.location_offset() == pos)
		.flat_map(|(_, kind)| kind.expectations())
		.collect::<Vec<_>>();

	// Check for specific patterns based on error structure and source context.
	let expects_expression = expectations.iter().any(|e| {
		let s = e.as_ref();
		s == "integer"
			|| s == "dice expression"
			|| s == "`(`"
			|| s == "`{`"
			|| s == "`[`"
			|| s == "`-`"
	});
	let expects_delimiter =
		expectations.iter().find_map(|e| match e.as_ref()
		{
			"`)`" => Some(('(', ')')),
			"`]`" => Some(('[', ']')),
			"`}`" => Some(('{', '}')),
			_ => None
		});

	// Pattern: closing delimiter expected at EOF → unclosed delimiter.
	if at_eof && let Some((opener, closer)) = expects_delimiter
	{
		let opener_pos = find_unmatched_opener(source, opener, closer, pos);
		return make_unclosed_delimiter(
			source, opener, closer, opener_pos, pos, offset_map
		);
	}

	// Pattern: expression expected, and the text at the error position is an
	// identifier → bare identifier in expression context.
	if expects_expression
		&& !at_eof
		&& let Some(diag) =
			detect_bare_identifier_at_pos(source, pos, offset_map)
	{
		return diag;
	}

	// Pattern: expression or identifier expected after delimiter/operator.
	let expects_identifier =
		expectations.iter().any(|e| e.as_ref() == "identifier");
	if (expects_expression || expects_identifier)
		&& let Some((prev, prev_pos)) = find_preceding_char(source, pos)
	{
		if prev == 'd' || prev == 'D'
		{
			return make_missing_dice_faces(source, prev_pos, pos, offset_map);
		}
		if "+-*×/÷%^".contains(prev)
		{
			return make_missing_right_operand(
				source, prev, prev_pos, pos, offset_map
			);
		}
		// Opening delimiter with no expression inside:
		// e.g., `(` → `(0)`, `[` → `[0:0]`, `{` → `{x}`.
		if prev == '(' || prev == '[' || prev == '{'
		{
			return make_incomplete_delimited(
				source, prev, prev_pos, pos, offset_map
			);
		}
		// After `:` inside a range, e.g., `[1:` → insert end expression and
		// `]`.
		if prev == ':'
			&& let Some(bracket_pos) = source[..prev_pos].rfind('[')
		{
			let orig_bracket = offset_map.to_original(bracket_pos);
			let mut corrected = source[..pos].to_string();
			let p_start = corrected.len();
			corrected.push('0');
			let p_end = corrected.len();
			corrected.push(']');
			corrected.push_str(&source[pos..]);
			return Diagnostic {
				kind: DiagnosticKind::UnclosedDelimiter {
					opener: '[',
					expected_closer: ']'
				},
				span: SourceSpan {
					start: orig_bracket,
					end: orig_bracket + 1
				},
				message: "expected `]` to close `[`".into(),
				suggestions: vec![Suggestion {
					description: "insert range end \
								and `]`"
						.into(),
					corrected_source: corrected,
					placeholders: vec![Placeholder {
						span: SourceSpan {
							start: p_start,
							end: p_end
						},
						description: "range end",
						valid_kinds: OPERAND_KINDS
					}]
				}]
			};
		}
	}

	// Pattern: drop direction expected → incomplete drop clause.
	if expectations
		.iter()
		.any(|e| e.as_ref() == "`lowest`" || e.as_ref() == "`highest`")
	{
		let drop_pos =
			source[..pos].rfind("drop").unwrap_or(pos.saturating_sub(5));
		let orig_drop = offset_map.to_original(drop_pos);
		let orig_end = offset_map.to_original((drop_pos + 4).min(source.len()));
		return make_incomplete_drop(
			source, orig_drop, orig_end, pos, offset_map
		);
	}

	// Pattern: operator at start of input → missing left operand.
	if !at_eof
	{
		let ch = source[pos..].chars().next().unwrap_or('\0');
		if "+-*×/÷%^".contains(ch) && pos == 0
		{
			return make_missing_left_operand(source, ch, offset_map);
		}
	}

	// Pattern: empty or whitespace-only input.
	if source.trim().is_empty()
	{
		return make_empty_expression(source);
	}

	// Pattern: bare identifier followed by `d`/`D` → BareIdentifier.
	// Must run before incomplete parameter detection, because `xD6` would
	// otherwise be interpreted as parameter `xD6` missing `:`.
	if let Some(diag) = detect_bare_identifier(source, pos, offset_map)
	{
		return diag;
	}

	// Pattern: bare identifier parsed as parameter, missing `:` and body.
	if expectations
		.iter()
		.any(|e| e.as_ref() == "`,`" || e.as_ref() == "`:`")
		&& let Some(diag) = detect_incomplete_parameter(source, pos, offset_map)
	{
		return diag;
	}

	// Pattern: end of input from all_consuming → trailing input.
	if expectations.iter().any(|e| e.as_ref() == "end of input") && !at_eof
	{
		let orig_pos = offset_map.to_original(pos);
		let orig_end = offset_map.to_original(source.len());
		return Diagnostic {
			kind: DiagnosticKind::TrailingInput,
			span: SourceSpan {
				start: orig_pos,
				end: orig_end
			},
			message: format!(
				"unexpected `{}` after expression",
				&source[pos..].split_whitespace().next().unwrap_or("")
			),
			suggestions: vec![Suggestion {
				description: "remove trailing input".into(),
				corrected_source: source[..pos].trim_end().to_string(),
				placeholders: vec![]
			}]
		};
	}

	// Catch-all: unexpected token or EOF.
	let orig_pos = offset_map.to_original(pos);
	if at_eof
	{
		Diagnostic {
			kind: DiagnosticKind::UnexpectedEof,
			span: SourceSpan {
				start: orig_pos,
				end: orig_pos
			},
			message: "unexpected end of input".into(),
			suggestions: vec![]
		}
	}
	else
	{
		let token_end = source[pos..]
			.find(|c: char| c.is_whitespace())
			.map_or(source.len(), |i| pos + i);
		let orig_end = offset_map.to_original(token_end);
		Diagnostic {
			kind: DiagnosticKind::UnexpectedToken,
			span: SourceSpan {
				start: orig_pos,
				end: orig_end
			},
			message: format!("unexpected `{}`", &source[pos..token_end]),
			suggestions: vec![]
		}
	}
}

/// Search backward from `pos` for the nearest non-whitespace character.
///
/// # Parameters
/// - `source`: The source text.
/// - `pos`: The position to search backward from.
///
/// # Returns
/// The character and its byte offset, if found.
fn find_preceding_char(source: &str, pos: usize) -> Option<(char, usize)>
{
	let before = &source[..pos];
	for (i, c) in before.char_indices().rev()
	{
		if !c.is_whitespace()
		{
			return Some((c, i));
		}
	}
	None
}

/// Find the byte offset of an unmatched opening delimiter before `pos`.
///
/// # Parameters
/// - `source`: The source text.
/// - `opener`: The opening delimiter character.
/// - `closer`: The closing delimiter character.
/// - `pos`: The position to search before.
///
/// # Returns
/// The byte offset of the unmatched opener, if found.
fn find_unmatched_opener(
	source: &str,
	opener: char,
	closer: char,
	pos: usize
) -> Option<usize>
{
	let mut depth = 0i32;
	let mut last_opener = None;
	for (i, c) in source[..pos].char_indices()
	{
		if c == opener
		{
			depth += 1;
			last_opener = Some(i);
		}
		else if c == closer
		{
			depth -= 1;
		}
	}
	if depth > 0 { last_opener } else { None }
}

/// Detect a bare identifier at the error position in an expression context.
///
/// When the parser expects an expression operand (e.g., after `+`) but the
/// text at the error position is an identifier, the user almost certainly
/// forgot to wrap it in `{}`.
///
/// # Parameters
/// - `source`: The source text.
/// - `pos`: The error position.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A `BareIdentifier` diagnostic if the text at `pos` is an identifier.
fn detect_bare_identifier_at_pos(
	source: &str,
	pos: usize,
	offset_map: &OffsetMap
) -> Option<Diagnostic>
{
	let remaining = &source[pos..];
	// Check if the text starts with an identifier character.
	let first = remaining.chars().next()?;
	if !first.is_alphabetic() && first != '_'
	{
		return None;
	}
	// Find the end of the identifier.
	let ident_end = remaining
		.find(|c: char| {
			!(c.is_alphanumeric()
				|| c == '_' || c == '-'
				|| c == '.' || (c.is_whitespace() && !matches!(c, '\n' | '\r')))
		})
		.unwrap_or(remaining.len());
	let name = remaining[..ident_end].trim_end();
	if name.is_empty()
	{
		return None;
	}
	let orig_start = offset_map.to_original(pos);
	let orig_end = offset_map.to_original(pos + name.len());
	let after = &source[pos + ident_end..];
	let mut suggestions = Vec::new();

	// Check if the identifier contains `d`/`D` — if so, offer both a split fix
	// (e.g., `{x}D6`) and a whole-variable fix (e.g., `{xD6}`).
	let split_pos = name.char_indices().find(|&(i, c)| {
		(c == 'd' || c == 'D')
			&& i > 0 && name[..i]
			.starts_with(|c: char| c.is_alphabetic() || c == '_')
	});
	if let Some((d_offset, _)) = split_pos
	{
		let prefix = &name[..d_offset];
		let suffix = &name[d_offset..];
		let mut split_fix = source[..pos].to_string();
		split_fix.push('{');
		split_fix.push_str(prefix);
		split_fix.push('}');
		split_fix.push_str(suffix);
		split_fix.push_str(after);
		suggestions.push(Suggestion {
			description: format!("wrap `{}` in braces", prefix),
			corrected_source: split_fix,
			placeholders: vec![]
		});
	}
	// Always offer wrapping the whole identifier.
	let mut whole_fix = source[..pos].to_string();
	whole_fix.push('{');
	whole_fix.push_str(name);
	whole_fix.push('}');
	whole_fix.push_str(after);
	suggestions.push(Suggestion {
		description: format!("use `{}` as a variable name", name),
		corrected_source: whole_fix,
		placeholders: vec![]
	});

	// Use the first (most specific) suggestion's description for the message.
	// If there's a `d`/`D` split, the bare name is the prefix.
	let bare_name = split_pos.map(|(i, _)| &name[..i]).unwrap_or(name);
	Some(Diagnostic {
		kind: DiagnosticKind::BareIdentifier,
		span: SourceSpan {
			start: orig_start,
			end: orig_end
		},
		message: format!(
			"bare identifier `{}` is not valid here; \
			 variables must be wrapped in `{{}}`",
			bare_name
		),
		suggestions
	})
}

/// Detect an incomplete parameter definition.
///
/// When the parser sees identifiers followed by `,` or at EOF without `:`,
/// and the fix `{ident}` would produce a valid expression, offer both
/// interpretations: completing the parameter definition or wrapping in `{}`.
///
/// # Parameters
/// - `source`: The source text.
/// - `pos`: The error position.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// An `IncompleteParameterDefinition` diagnostic if the pattern matches.
fn detect_incomplete_parameter(
	source: &str,
	pos: usize,
	offset_map: &OffsetMap
) -> Option<Diagnostic>
{
	let trimmed = source.trim();
	if trimmed.is_empty()
	{
		return None;
	}
	// Extract the parameter names from the source (everything before pos).
	let params_text = source[..pos].trim();
	if params_text.is_empty()
	{
		return None;
	}
	// Verify this looks like parameter names (identifiers separated by `,`).
	let params: Vec<&str> = params_text
		.split(',')
		.map(|s| s.trim())
		.filter(|s| !s.is_empty())
		.collect();
	if params.is_empty()
		|| !params
			.iter()
			.all(|p| p.starts_with(|c: char| c.is_alphabetic() || c == '_'))
	{
		return None;
	}
	let orig_start = offset_map.to_original(0);
	let orig_end = offset_map.to_original(pos);

	let mut suggestions = Vec::new();
	let trailing = source[pos..].trim_start();

	// Build the variable reference suggestion (single parameter only).
	let var_suggestion = if params.len() == 1
	{
		let name = params[0];
		let mut var_fix = format!("{{{}}}", name);
		if !trailing.is_empty()
		{
			var_fix.push(' ');
			var_fix.push_str(trailing);
		}
		Some(Suggestion {
			description: format!("use `{}` as a variable reference", name),
			corrected_source: var_fix,
			placeholders: vec![]
		})
	}
	else
	{
		None
	};

	// Build the parameter definition suggestion.
	let param_suggestion = {
		let mut fix = source[..pos].to_string();
		fix.push_str(": ");
		// Try incorporating trailing content as the body. Only use it if the
		// result actually parses; otherwise fall back to a placeholder.
		let trailing_works = if !trailing.is_empty()
		{
			let mut candidate = fix.clone();
			candidate.push_str(trailing);
			parser::parse(&candidate).is_ok()
		}
		else
		{
			false
		};
		if trailing_works
		{
			fix.push_str(trailing);
			Suggestion {
				description: "complete parameter definition".into(),
				corrected_source: fix,
				placeholders: vec![]
			}
		}
		else
		{
			let placeholder_start = fix.len();
			fix.push('0');
			let placeholder_end = fix.len();
			Suggestion {
				description: "complete parameter definition".into(),
				corrected_source: fix,
				placeholders: vec![Placeholder {
					span: SourceSpan {
						start: placeholder_start,
						end: placeholder_end
					},
					description: "expression",
					valid_kinds: OPERAND_KINDS
				}]
			}
		}
	};

	// When there's trailing content (like `* 3`), the variable reference
	// interpretation is more likely — put it first so the retry loop uses it.
	if !trailing.is_empty()
	{
		if let Some(vs) = var_suggestion
		{
			suggestions.push(vs);
		}
		suggestions.push(param_suggestion);
	}
	else
	{
		suggestions.push(param_suggestion);
		if let Some(vs) = var_suggestion
		{
			suggestions.push(vs);
		}
	}

	Some(Diagnostic {
		kind: DiagnosticKind::IncompleteParameterDefinition,
		span: SourceSpan {
			start: orig_start,
			end: orig_end
		},
		message: format!(
			"expected `:` and expression body after parameter{}",
			if params.len() > 1 { "s" } else { "" }
		),
		suggestions
	})
}

/// Detect a bare identifier followed by `d`/`D` in the source.
///
/// # Notes
/// Bare identifiers are only legal as parameter definitions. When the parser
/// sees `xD6`, it interprets `x` as a parameter name and then expects `:` or
/// `,`. If the character after the identifier is `d`/`D`, the user almost
/// certainly meant `{x}D6`.
///
/// # Parameters
/// - `source`: The source text.
/// - `error_pos`: Where the parse error occurred.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A `BareIdentifier` diagnostic if the pattern matches.
fn detect_bare_identifier(
	source: &str,
	error_pos: usize,
	offset_map: &OffsetMap
) -> Option<Diagnostic>
{
	// The error position is after the identifier (where `:` or `,` was
	// expected). Check if there's a `d`/`D` somewhere in the remaining source
	// that's part of what was parsed as an identifier. Walk backward from
	// error_pos to find the start of the identifier.
	let before = &source[..error_pos];

	// Find the last contiguous identifier-like region ending at error_pos.
	let ident_start = before
		.char_indices()
		.rev()
		.take_while(|(_, c)| {
			c.is_alphanumeric() || *c == '_' || *c == '-' || *c == '.'
		})
		.last()
		.map(|(i, _)| i)?;

	let ident = &source[ident_start..error_pos];

	// Check if the identifier contains `d` or `D` followed by digits or `[`.
	// E.g., "xD6" → identifier is "xD6", but the `D` is a dice operator.
	for (i, c) in ident.char_indices()
	{
		if (c == 'd' || c == 'D') && i > 0
		{
			let after_d = &ident[i + 1..];
			if after_d.is_empty()
				|| after_d.starts_with(|c: char| c.is_ascii_digit())
				|| after_d.starts_with('[')
				|| after_d.starts_with('(')
				|| after_d.starts_with('{')
			{
				let name = &ident[..i];
				// Verify the name part is a valid identifier start.
				if name.starts_with(|c: char| c.is_alphabetic() || c == '_')
				{
					let orig_start = offset_map.to_original(ident_start);
					let orig_end = offset_map.to_original(ident_start + i);
					// Suggestion 1: split at `d`/`D` → `{name}D...`
					let after = &source[ident_start + i..];
					let mut split_fix = source[..ident_start].to_string();
					split_fix.push('{');
					split_fix.push_str(name);
					split_fix.push('}');
					split_fix.push_str(after);
					// Suggestion 2: whole identifier as variable
					// → `{xD6}`
					let mut whole_fix = source[..ident_start].to_string();
					whole_fix.push('{');
					whole_fix.push_str(ident);
					whole_fix.push('}');
					whole_fix.push_str(&source[error_pos..]);
					return Some(Diagnostic {
						kind: DiagnosticKind::BareIdentifier,
						span: SourceSpan {
							start: orig_start,
							end: orig_end
						},
						message: format!(
							"bare identifier `{}` is not valid here; \
							 variables must be wrapped in `{{}}`",
							name
						),
						suggestions: vec![
							Suggestion {
								description: format!(
									"wrap `{}` in braces",
									name
								),
								corrected_source: split_fix,
								placeholders: vec![]
							},
							Suggestion {
								description: format!(
									"use `{}` as a variable \
									 name",
									ident
								),
								corrected_source: whole_fix,
								placeholders: vec![]
							},
						]
					});
				}
			}
		}
	}
	None
}

////////////////////////////////////////////////////////////////////////////////
//                              Fix generation.                               //
////////////////////////////////////////////////////////////////////////////////

/// Create a diagnostic for an unclosed delimiter. If the delimiter contains
/// no expression, a placeholder `0` is inserted alongside the closing
/// delimiter.
///
/// # Parameters
/// - `source`: The current source text.
/// - `opener`: The opening delimiter character (e.g., `(`).
/// - `closer`: The expected closing delimiter character (e.g., `)`).
/// - `opener_pos`: The byte offset of the opening delimiter, or `None` if
///   unknown.
/// - `error_pos`: The byte offset where the error was detected.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with an `UnclosedDelimiter` kind and a suggestion that
/// inserts the closing delimiter (and a placeholder expression if needed).
fn make_unclosed_delimiter(
	source: &str,
	opener: char,
	closer: char,
	opener_pos: Option<usize>,
	error_pos: usize,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let actual_opener = opener_pos.unwrap_or(0);
	let orig_opener = offset_map.to_original(actual_opener);
	// Check if there's meaningful content between opener and error position.
	let content_between = source[actual_opener + opener.len_utf8()..error_pos]
		.trim()
		.is_empty();
	let mut corrected = source[..error_pos].to_string();
	let mut placeholders = Vec::new();
	if content_between
	{
		// No expression between opener and closer — insert placeholder.
		let placeholder_start = corrected.len();
		corrected.push('0');
		let placeholder_end = corrected.len();
		placeholders.push(Placeholder {
			span: SourceSpan {
				start: placeholder_start,
				end: placeholder_end
			},
			description: "expression",
			valid_kinds: OPERAND_KINDS
		});
	}
	corrected.push(closer);
	corrected.push_str(&source[error_pos..]);
	Diagnostic {
		kind: DiagnosticKind::UnclosedDelimiter {
			opener,
			expected_closer: closer
		},
		span: SourceSpan {
			start: orig_opener,
			end: orig_opener + opener.len_utf8()
		},
		message: format!("expected `{}` to close `{}`", closer, opener),
		suggestions: vec![Suggestion {
			description: format!("insert `{}`", closer),
			corrected_source: corrected,
			placeholders
		}]
	}
}

/// Create a diagnostic for a missing right operand. Offers two suggestions:
/// inserting a placeholder operand, or dropping the operator.
///
/// # Parameters
/// - `source`: The current source text.
/// - `operator`: The binary operator character (e.g., `+`).
/// - `op_pos`: The byte offset of the operator in the current source.
/// - `error_pos`: The byte offset where the right operand was expected.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with a `MissingRightOperand` kind and two suggestions.
fn make_missing_right_operand(
	source: &str,
	operator: char,
	op_pos: usize,
	error_pos: usize,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let orig_error_pos = offset_map.to_original(error_pos);
	let orig_op_pos = offset_map.to_original(op_pos);
	// Suggestion 1: insert `0` at the error position with spacing.
	let mut insert_fix = source[..error_pos].to_string();
	if !insert_fix.is_empty() && !insert_fix.ends_with(' ')
	{
		insert_fix.push(' ');
	}
	let placeholder_start = insert_fix.len();
	insert_fix.push('0');
	let placeholder_end = insert_fix.len();
	if !source[error_pos..].is_empty() && !source[error_pos..].starts_with(' ')
	{
		insert_fix.push(' ');
	}
	insert_fix.push_str(&source[error_pos..]);

	// Suggestion 2: drop the operator.
	let before_op = source[..op_pos].trim_end();
	let mut drop_fix = before_op.to_string();
	if !source[error_pos..].is_empty()
	{
		if !drop_fix.is_empty()
		{
			drop_fix.push(' ');
		}
		drop_fix.push_str(source[error_pos..].trim_start());
	}

	Diagnostic {
		kind: DiagnosticKind::MissingRightOperand { operator },
		span: SourceSpan {
			start: orig_op_pos,
			end: orig_error_pos
		},
		message: format!("expected operand after `{}`", operator),
		suggestions: vec![
			Suggestion {
				description: format!("insert operand after `{}`", operator),
				corrected_source: insert_fix,
				placeholders: vec![Placeholder {
					span: SourceSpan {
						start: placeholder_start,
						end: placeholder_end
					},
					description: "operand",
					valid_kinds: OPERAND_KINDS
				}]
			},
			Suggestion {
				description: format!("remove `{}`", operator),
				corrected_source: drop_fix,
				placeholders: vec![]
			},
		]
	}
}

/// Create a diagnostic for a missing left operand. Offers two suggestions:
/// inserting a placeholder operand, or dropping the operator.
///
/// # Parameters
/// - `source`: The current source text.
/// - `operator`: The binary operator character at position 0.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with a `MissingLeftOperand` kind and two suggestions.
fn make_missing_left_operand(
	source: &str,
	operator: char,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let orig_pos = offset_map.to_original(0);
	// Suggestion 1: insert `0` before the operator.
	let mut insert_fix = String::from("0 ");
	insert_fix.push_str(source);

	// Suggestion 2: drop the operator.
	let after_op = source[operator.len_utf8()..].trim_start();
	let drop_fix = after_op.to_string();

	Diagnostic {
		kind: DiagnosticKind::MissingLeftOperand { operator },
		span: SourceSpan {
			start: orig_pos,
			end: orig_pos + operator.len_utf8()
		},
		message: format!("expected operand before `{}`", operator),
		suggestions: vec![
			Suggestion {
				description: format!("insert operand before `{}`", operator),
				corrected_source: insert_fix,
				placeholders: vec![Placeholder {
					span: SourceSpan { start: 0, end: 1 },
					description: "operand",
					valid_kinds: OPERAND_KINDS
				}]
			},
			Suggestion {
				description: format!("remove `{}`", operator),
				corrected_source: drop_fix,
				placeholders: vec![]
			},
		]
	}
}

/// Create a diagnostic for an incomplete delimited construct where the
/// expression inside is missing (e.g., `(` alone, `[` alone). The fix inserts
/// context-appropriate content: `0)` for groups, `0:0]` for ranges, `0]` for
/// custom faces, or `x}` for variables.
///
/// # Parameters
/// - `source`: The current source text.
/// - `opener`: The opening delimiter character.
/// - `opener_pos`: The byte offset of the opener in the current source.
/// - `error_pos`: The byte offset where the error was detected.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with an `UnclosedDelimiter` kind and a suggestion that
/// inserts the appropriate placeholder content and closing delimiter.
fn make_incomplete_delimited(
	source: &str,
	opener: char,
	opener_pos: usize,
	error_pos: usize,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let orig_opener = offset_map.to_original(opener_pos);
	let closer = match opener
	{
		'(' => ')',
		'[' => ']',
		'{' => '}',
		_ => ')'
	};
	let mut corrected = source[..error_pos].to_string();
	let mut placeholders = Vec::new();
	// Determine if `[` is a custom faces bracket (after `d`/`D`) or a range.
	let is_custom_faces = opener == '['
		&& opener_pos > 0
		&& source[..opener_pos]
			.chars()
			.last()
			.is_some_and(|c| c == 'd' || c == 'D');
	match opener
	{
		'[' if is_custom_faces =>
		{
			// Custom faces need a comma-separated list, e.g., `[1,2,3]`.
			let p_start = corrected.len();
			corrected.push('0');
			let p_end = corrected.len();
			placeholders.push(Placeholder {
				span: SourceSpan {
					start: p_start,
					end: p_end
				},
				description: "face value",
				valid_kinds: &["integer"]
			});
		},
		'[' =>
		{
			// Ranges need `start:end`, so insert `0:0`.
			let p1_start = corrected.len();
			corrected.push('0');
			let p1_end = corrected.len();
			corrected.push(':');
			let p2_start = corrected.len();
			corrected.push('0');
			let p2_end = corrected.len();
			placeholders.push(Placeholder {
				span: SourceSpan {
					start: p1_start,
					end: p1_end
				},
				description: "range start",
				valid_kinds: OPERAND_KINDS
			});
			placeholders.push(Placeholder {
				span: SourceSpan {
					start: p2_start,
					end: p2_end
				},
				description: "range end",
				valid_kinds: OPERAND_KINDS
			});
		},
		'{' =>
		{
			// Variables need an identifier.
			let p_start = corrected.len();
			corrected.push('x');
			let p_end = corrected.len();
			placeholders.push(Placeholder {
				span: SourceSpan {
					start: p_start,
					end: p_end
				},
				description: "identifier",
				valid_kinds: &["identifier"]
			});
		},
		_ =>
		{
			// Groups just need an expression.
			let p_start = corrected.len();
			corrected.push('0');
			let p_end = corrected.len();
			placeholders.push(Placeholder {
				span: SourceSpan {
					start: p_start,
					end: p_end
				},
				description: "expression",
				valid_kinds: OPERAND_KINDS
			});
		}
	}
	corrected.push(closer);
	corrected.push_str(&source[error_pos..]);
	Diagnostic {
		kind: DiagnosticKind::UnclosedDelimiter {
			opener,
			expected_closer: closer
		},
		span: SourceSpan {
			start: orig_opener,
			end: orig_opener + opener.len_utf8()
		},
		message: format!("expected `{}` to close `{}`", closer, opener),
		suggestions: vec![Suggestion {
			description: format!("insert expression and `{}`", closer),
			corrected_source: corrected,
			placeholders
		}]
	}
}

/// Create a diagnostic for missing dice faces after `d`/`D`. The fix inserts
/// `6` as a placeholder face count immediately after the dice operator.
///
/// # Parameters
/// - `source`: The current source text.
/// - `d_pos`: The byte offset of the `d`/`D` operator.
/// - `_error_pos`: The byte offset where the face count was expected (unused
///   because we insert at `d_pos + 1`).
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with a `MissingDiceFaces` kind and a suggestion with a
/// placeholder for the face count.
fn make_missing_dice_faces(
	source: &str,
	d_pos: usize,
	_error_pos: usize,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let orig_d_pos = offset_map.to_original(d_pos);
	// Insert `6` as a default face count right after the `d`/`D`, preserving
	// any whitespace between the operator and the error.
	let insert_pos = d_pos + 1;
	let mut corrected = source[..insert_pos].to_string();
	let placeholder_start = corrected.len();
	corrected.push('6');
	let placeholder_end = corrected.len();
	// Preserve content from after the `d`/`D` onward (including any whitespace
	// that was between the operator and the error position).
	corrected.push_str(&source[insert_pos..]);
	Diagnostic {
		kind: DiagnosticKind::MissingDiceFaces,
		span: SourceSpan {
			start: orig_d_pos,
			end: orig_d_pos + 1
		},
		message: format!(
			"expected face count after `{}`",
			&source[d_pos..d_pos + 1]
		),
		suggestions: vec![Suggestion {
			description: "insert face count".into(),
			corrected_source: corrected,
			placeholders: vec![Placeholder {
				span: SourceSpan {
					start: placeholder_start,
					end: placeholder_end
				},
				description: "face count",
				valid_kinds: FACE_COUNT_KINDS
			}]
		}]
	}
}

/// Create a diagnostic for an incomplete drop clause. The fix inserts
/// `lowest` as a placeholder direction after the `drop` keyword.
///
/// # Parameters
/// - `source`: The current source text.
/// - `orig_drop_start`: The byte offset of `drop` in the original source.
/// - `orig_drop_end`: The byte offset of the end of `drop` in the original
///   source.
/// - `error_pos`: The byte offset where the direction was expected.
/// - `offset_map`: For mapping positions back to the original source.
///
/// # Returns
/// A diagnostic with an `IncompleteDropClause` kind and a suggestion with a
/// placeholder for the drop direction.
fn make_incomplete_drop(
	source: &str,
	orig_drop_start: usize,
	orig_drop_end: usize,
	error_pos: usize,
	offset_map: &OffsetMap
) -> Diagnostic
{
	let _ = offset_map;
	// Insert ` lowest` after `drop`.
	let insert_pos = source[..error_pos]
		.rfind("drop")
		.map_or(error_pos, |p| p + 4);
	let mut corrected = source[..insert_pos].to_string();
	corrected.push(' ');
	let placeholder_start = corrected.len();
	corrected.push_str("lowest");
	let placeholder_end = corrected.len();
	corrected.push_str(&source[insert_pos..]);
	Diagnostic {
		kind: DiagnosticKind::IncompleteDropClause,
		span: SourceSpan {
			start: orig_drop_start,
			end: orig_drop_end
		},
		message: "expected `lowest` or `highest` after `drop`".into(),
		suggestions: vec![Suggestion {
			description: "insert drop direction".into(),
			corrected_source: corrected,
			placeholders: vec![Placeholder {
				span: SourceSpan {
					start: placeholder_start,
					end: placeholder_end
				},
				description: "direction",
				valid_kinds: DROP_DIRECTION_KINDS
			}]
		}]
	}
}

/// Create a diagnostic for an empty or whitespace-only expression. The fix
/// inserts `0` as a placeholder.
///
/// # Parameters
/// - `source`: The current source text (empty or whitespace-only).
///
/// # Returns
/// A diagnostic with an `EmptyExpression` kind and a suggestion with a
/// placeholder for the expression.
fn make_empty_expression(source: &str) -> Diagnostic
{
	let _ = source;
	Diagnostic {
		kind: DiagnosticKind::EmptyExpression,
		span: SourceSpan { start: 0, end: 0 },
		message: "expected expression".into(),
		suggestions: vec![Suggestion {
			description: "insert expression".into(),
			corrected_source: "0".into(),
			placeholders: vec![Placeholder {
				span: SourceSpan { start: 0, end: 1 },
				description: "expression",
				valid_kinds: OPERAND_KINDS
			}]
		}]
	}
}

////////////////////////////////////////////////////////////////////////////////
//                             Position mapping.                              //
////////////////////////////////////////////////////////////////////////////////

/// Tracks cumulative byte offset adjustments from applied fixes, enabling
/// positions in a modified source string to be mapped back to positions in the
/// original source.
#[derive(Debug, Clone)]
struct OffsetMap
{
	/// Each entry is `(modified_pos, delta)`, where `delta` is the number of
	/// bytes inserted (positive) or removed (negative) at `modified_pos`.
	adjustments: Vec<(usize, isize)>
}

impl OffsetMap
{
	/// Create a new, empty offset map with no adjustments recorded.
	///
	/// # Returns
	/// An offset map that maps all positions to themselves.
	fn new() -> Self
	{
		Self {
			adjustments: Vec::new()
		}
	}

	/// Record an adjustment: `delta` bytes were inserted (positive) or removed
	/// (negative) at `modified_pos` in the current source.
	///
	/// # Parameters
	/// - `modified_pos`: The byte offset in the current (modified) source where
	///   the edit occurred.
	/// - `delta`: The number of bytes inserted (positive) or removed
	///   (negative).
	fn record(&mut self, modified_pos: usize, delta: isize)
	{
		self.adjustments.push((modified_pos, delta));
	}

	/// Map a position in the current (modified) source back to the
	/// corresponding position in the original source.
	///
	/// # Parameters
	/// - `modified_pos`: A byte offset in the current source.
	///
	/// # Returns
	/// The corresponding byte offset in the original source.
	fn to_original(&self, modified_pos: usize) -> usize
	{
		let mut pos = modified_pos as isize;
		// Walk adjustments in reverse to undo them.
		for &(adj_pos, delta) in self.adjustments.iter().rev()
		{
			if modified_pos >= adj_pos
			{
				pos -= delta;
			}
		}
		pos.max(0) as usize
	}
}

////////////////////////////////////////////////////////////////////////////////
//                                The doctor.                                 //
////////////////////////////////////////////////////////////////////////////////

/// Diagnose a source string, collecting all parse errors and suggested fixes.
///
/// The doctor uses a fix-and-retry loop: parse, detect the error, generate a
/// fix, apply the fix, and re-parse. This continues until parsing succeeds (all
/// errors collected) or an unfixable error is encountered.
///
/// # Parameters
/// - `source`: The source string to diagnose.
///
/// # Returns
/// A [`DiagnoseResult`] containing all diagnostics and, if all errors were
/// fixable, the corrected source string.
///
/// # Performance
/// Designed for keystroke-speed execution. Each iteration involves a single
/// `nom` parse (microseconds for typical dice expressions) and a string fixup.
/// The loop runs at most `O(n)` times where `n` is the number of errors.
///
/// # Examples
/// Single error with an unambiguous fix:
///
/// ```rust
/// use xdy::diagnostics::{DiagnosticKind, diagnose};
///
/// let result = diagnose("{x");
/// assert_eq!(result.diagnostics.len(), 1);
/// assert!(matches!(
///     result.diagnostics[0].kind,
///     DiagnosticKind::UnclosedDelimiter { opener: '{', .. }
/// ));
/// assert_eq!(
///     result.corrected_source.as_deref(),
///     Some("{x}")
/// );
/// ```
///
/// Multiple errors collected via fix-and-retry:
///
/// ```rust
/// use xdy::diagnostics::{DiagnosticKind, diagnose};
///
/// let result = diagnose("3D6 + + 1D3");
/// assert_eq!(result.diagnostics.len(), 1);
/// assert!(matches!(
///     result.diagnostics[0].kind,
///     DiagnosticKind::MissingRightOperand { operator: '+' }
/// ));
/// // The corrected source inserts `0` as a placeholder operand.
/// assert!(result.corrected_source.is_some());
/// // The corrected source parses cleanly.
/// assert!(
///     xdy::parser::parse(
///         result.corrected_source.as_ref().unwrap()
///     ).is_ok()
/// );
/// ```
pub fn diagnose(source: &str) -> DiagnoseResult
{
	// Fast path: if the source parses cleanly, no diagnostics needed.
	if parser::parse(source).is_ok()
	{
		return DiagnoseResult {
			diagnostics: vec![],
			corrected_source: Some(source.to_string())
		};
	}

	let mut current_source = source.to_string();
	let mut diagnostics = Vec::new();
	let mut offset_map = OffsetMap::new();
	// Safety valve: at most one fix per character, plus a generous baseline for
	// empty and very short inputs.
	let max_iterations = source.len() + 16;

	for _ in 0..max_iterations
	{
		match parser::parse(&current_source)
		{
			Ok(_) =>
			{
				return DiagnoseResult {
					diagnostics,
					corrected_source: Some(current_source)
				};
			},
			Err(error) =>
			{
				let diag = analyze_error(&current_source, &error, &offset_map);
				if let Some(suggestion) = diag.suggestions.first()
				{
					let old_len = current_source.len() as isize;
					let new_source = suggestion.corrected_source.clone();
					let new_len = new_source.len() as isize;
					let delta = new_len - old_len;
					// Record the adjustment at position 0 (whole-string
					// replacement). This is a simplification; a more precise
					// approach would record the specific edit position.
					let error_pos = error.errors[0].0.location_offset();
					offset_map.record(error_pos, delta);
					current_source = new_source;
					diagnostics.push(diag);
				}
				else
				{
					// Unfixable error.
					diagnostics.push(diag);
					return DiagnoseResult {
						diagnostics,
						corrected_source: None
					};
				}
			}
		}
	}

	// Should not reach here, but if we do, return what we have.
	DiagnoseResult {
		diagnostics,
		corrected_source: None
	}
}

////////////////////////////////////////////////////////////////////////////////
//                            OffsetMap unit tests.                           //
////////////////////////////////////////////////////////////////////////////////

#[cfg(test)]
mod tests
{
	use super::OffsetMap;

	/// No adjustments → identity mapping.
	#[test]
	fn test_offset_map_identity()
	{
		let map = OffsetMap::new();
		assert_eq!(map.to_original(0), 0);
		assert_eq!(map.to_original(5), 5);
		assert_eq!(map.to_original(100), 100);
	}

	/// Single insertion: 2 bytes inserted at position 3.
	/// Original: `abc_efg` (7 bytes)
	/// Modified: `abc00_efg` (9 bytes)
	/// Position 0–2 in modified → 0–2 in original (before insertion).
	/// Position 3+ in modified → shifted back by 2.
	#[test]
	fn test_offset_map_single_insertion()
	{
		let mut map = OffsetMap::new();
		map.record(3, 2); // inserted 2 bytes at position 3
		// Positions before the insertion are unchanged.
		assert_eq!(map.to_original(0), 0);
		assert_eq!(map.to_original(2), 2);
		// Positions at or after the insertion shift back by 2.
		assert_eq!(map.to_original(3), 1);
		assert_eq!(map.to_original(5), 3);
		assert_eq!(map.to_original(8), 6);
	}

	/// Single deletion: 2 bytes removed at position 3.
	/// Original: `abcXX_efg` (9 bytes)
	/// Modified: `abc_efg` (7 bytes)
	/// Position 3+ in modified → shifted forward by 2.
	#[test]
	fn test_offset_map_single_deletion()
	{
		let mut map = OffsetMap::new();
		map.record(3, -2); // removed 2 bytes at position 3
		// Positions before the deletion are unchanged.
		assert_eq!(map.to_original(0), 0);
		assert_eq!(map.to_original(2), 2);
		// Positions at or after the deletion shift forward by 2.
		assert_eq!(map.to_original(3), 5);
		assert_eq!(map.to_original(5), 7);
	}

	/// Multiple insertions: simulates the fix-and-retry loop inserting `0`
	/// at two different positions.
	/// Original: `a + + b -` (9 bytes)
	/// After fix 1: `a + 0 + b -` (11 bytes, inserted 2 at pos 4)
	/// After fix 2: `a + 0 + b - 0` (13 bytes, inserted 2 at pos 12)
	#[test]
	fn test_offset_map_multiple_insertions()
	{
		let mut map = OffsetMap::new();
		map.record(4, 2); // first fix: inserted 2 bytes at position 4
		map.record(12, 2); // second fix: inserted 2 bytes at position 12
		// Position before both insertions.
		assert_eq!(map.to_original(0), 0);
		assert_eq!(map.to_original(3), 3);
		// Position after first insertion but before second.
		assert_eq!(map.to_original(6), 4);
		// Position after both insertions.
		assert_eq!(map.to_original(13), 9);
	}

	/// Position before any adjustment is unaffected.
	#[test]
	fn test_offset_map_position_before_adjustment()
	{
		let mut map = OffsetMap::new();
		map.record(10, 5); // inserted 5 bytes at position 10
		// Positions 0–9 are before the adjustment.
		for i in 0..10
		{
			assert_eq!(map.to_original(i), i);
		}
	}

	/// Mapping clamps to zero for extreme negative adjustments.
	#[test]
	fn test_offset_map_clamp_to_zero()
	{
		let mut map = OffsetMap::new();
		map.record(0, 10); // inserted 10 bytes at position 0
		// Position 0 in modified maps to original 0 (clamped, not -10).
		assert_eq!(map.to_original(0), 0);
		// Position 5 in modified would be -5, clamped to 0.
		assert_eq!(map.to_original(5), 0);
		// Position 10 in modified maps to original 0.
		assert_eq!(map.to_original(10), 0);
		// Position 11 in modified maps to original 1.
		assert_eq!(map.to_original(11), 1);
	}
}