use super::{base_caps, concepts_of, finding_from_concept};
use crate::domain::concepts::ConceptKind;
use crate::domain::model::LanguageModel;
use crate::domain::rule::{Rule, RuleMeta};
use crate::domain::types::{Confidence, Finding, Severity};
use std::sync::OnceLock;
#[derive(Default)]
pub struct MissingCleanupRule;
impl Rule for MissingCleanupRule {
fn meta(&self) -> &RuleMeta {
static META: OnceLock<RuleMeta> = OnceLock::new();
META.get_or_init(|| RuleMeta {
id: "missing-cleanup".into(),
name: "Missing cleanup on error".into(),
description: "Resource or lock cleanup may be skipped on failure paths.".into(),
default_severity: Severity::Medium,
required_capabilities: base_caps(),
autofix_safe: false,
})
}
fn evaluate(&self, model: &LanguageModel) -> Vec<Finding> {
concepts_of(model, ConceptKind::ResourceCleanup)
.map(|(lang, c)| {
finding_from_concept(
&self.meta().id,
lang,
c,
Severity::Medium,
Confidence::Low,
"Resource/lock cleanup may fail or be skipped after an error.",
"Leaked handles, held locks, or unflushed buffers cause deadlocks or data loss.",
"Use RAII / defer / finally patterns so cleanup runs on all paths.",
)
})
.collect()
}
}