wrkflw-secrets 0.8.0

Secrets management for wrkflw workflow execution engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
use regex::Regex;
use std::collections::{HashMap, HashSet};
use std::sync::{Arc, OnceLock, RwLock};

/// Compiled regex patterns for common secret formats
struct CompiledPatterns {
    github_pat: Regex,
    github_app: Regex,
    github_oauth: Regex,
    aws_access_key: Regex,
    aws_secret: Regex,
    jwt: Regex,
    api_key: Regex,
}

impl CompiledPatterns {
    fn new() -> Self {
        Self {
            github_pat: Regex::new(r"ghp_[a-zA-Z0-9]{36}").unwrap(),
            github_app: Regex::new(r"ghs_[a-zA-Z0-9]{36}").unwrap(),
            github_oauth: Regex::new(r"gho_[a-zA-Z0-9]{36}").unwrap(),
            aws_access_key: Regex::new(r"AKIA[0-9A-Z]{16}").unwrap(),
            aws_secret: Regex::new(r"[A-Za-z0-9/+=]{40}").unwrap(),
            jwt: Regex::new(r"eyJ[a-zA-Z0-9_-]*\.eyJ[a-zA-Z0-9_-]*\.[a-zA-Z0-9_-]*").unwrap(),
            api_key: Regex::new(r"(?i)(api[_-]?key|token)[\s:=]+[a-zA-Z0-9_-]{16,}").unwrap(),
        }
    }
}

/// Global compiled patterns (initialized once)
static PATTERNS: OnceLock<CompiledPatterns> = OnceLock::new();

/// Interior data protected by a single `RwLock` so that mutations
/// (add/remove/clear) are atomic — no window where `secrets` and
/// `secret_cache` can be out of sync.
struct SecretData {
    secrets: HashSet<String>,
    secret_cache: HashMap<String, String>,
    /// Pre-sorted (longest-first) pairs for `mask()`. Invalidated on mutation.
    /// Wrapped in `Arc` so `mask()` can cheaply clone a reference instead of
    /// deep-copying every secret string on every call.
    sorted_pairs: Option<Arc<Vec<(String, String)>>>,
}

/// Secret masking utility to prevent secrets from appearing in logs.
///
/// Uses interior mutability (`RwLock`) so secrets can be added through shared
/// references — e.g. when processing `::add-mask::` workflow commands during
/// step execution while the masker is shared across the job.
///
/// ## Poison recovery
///
/// All `RwLock` acquisitions use `.unwrap_or_else(|e| e.into_inner())` to
/// recover from poisoned locks rather than panicking. If a thread panics
/// while holding the lock the masker continues with the data as-is.
pub struct SecretMasker {
    data: RwLock<SecretData>,
    mask_char: char,
    min_length: usize,
}

impl SecretMasker {
    /// Create a new secret masker
    pub fn new() -> Self {
        Self {
            data: RwLock::new(SecretData {
                secrets: HashSet::new(),
                secret_cache: HashMap::new(),
                sorted_pairs: None,
            }),
            mask_char: '*',
            min_length: 3, // Don't mask very short strings
        }
    }

    /// Create a new secret masker with custom mask character (test-only).
    #[cfg(test)]
    pub fn with_mask_char(mask_char: char) -> Self {
        Self {
            data: RwLock::new(SecretData {
                secrets: HashSet::new(),
                secret_cache: HashMap::new(),
                sorted_pairs: None,
            }),
            mask_char,
            min_length: 3,
        }
    }

    /// Add a secret to be masked.
    ///
    /// Takes `&self` (not `&mut self`) thanks to interior mutability, so this
    /// can be called through a shared reference during workflow execution.
    pub fn add_secret(&self, secret: impl Into<String>) {
        let secret = secret.into();
        if secret.len() >= self.min_length {
            let masked = self.create_mask(&secret);
            let mut data = self.data.write().unwrap_or_else(|e| e.into_inner());
            data.secret_cache.insert(secret.clone(), masked);
            data.secrets.insert(secret);
            data.sorted_pairs = None; // invalidate cache
        }
    }

    /// Add multiple secrets to be masked.
    ///
    /// Acquires the write lock once for the entire batch instead of per-secret.
    pub fn add_secrets(&self, secrets: impl IntoIterator<Item = String>) {
        let pairs: Vec<(String, String)> = secrets
            .into_iter()
            .filter(|s| s.len() >= self.min_length)
            .map(|s| {
                let masked = self.create_mask(&s);
                (s, masked)
            })
            .collect();
        if !pairs.is_empty() {
            let mut data = self.data.write().unwrap_or_else(|e| e.into_inner());
            for (secret, masked) in pairs {
                data.secret_cache.insert(secret.clone(), masked);
                data.secrets.insert(secret);
            }
            data.sorted_pairs = None; // invalidate cache
        }
    }

    /// Remove a secret from masking
    pub fn remove_secret(&self, secret: &str) {
        let mut data = self.data.write().unwrap_or_else(|e| e.into_inner());
        data.secrets.remove(secret);
        data.secret_cache.remove(secret);
        data.sorted_pairs = None; // invalidate cache
    }

    /// Clear all secrets
    pub fn clear(&self) {
        let mut data = self.data.write().unwrap_or_else(|e| e.into_inner());
        data.secrets.clear();
        data.secret_cache.clear();
        data.sorted_pairs = None; // invalidate cache
    }

    /// Mask secrets in the given text
    pub fn mask(&self, text: &str) -> String {
        let mut result = text.to_string();

        // Use cached sorted pairs (longest-first) so overlapping secrets are
        // handled correctly (e.g. "secret123" is replaced before "secret").
        // The cache is rebuilt lazily on the first read after a mutation.
        let pairs = {
            // Try the read lock first (fast path: cached Arc available)
            let data = self.data.read().unwrap_or_else(|e| e.into_inner());
            if let Some(ref cached) = data.sorted_pairs {
                Arc::clone(cached)
            } else {
                drop(data);
                // Upgrade to write lock to rebuild the cache
                let mut data = self.data.write().unwrap_or_else(|e| e.into_inner());
                // Double-check after acquiring write lock
                if data.sorted_pairs.is_none() {
                    let mut p: Vec<(String, String)> = data
                        .secret_cache
                        .iter()
                        .map(|(k, v)| (k.clone(), v.clone()))
                        .collect();
                    p.sort_by_key(|pair| std::cmp::Reverse(pair.0.len()));
                    data.sorted_pairs = Some(Arc::new(p));
                }
                Arc::clone(data.sorted_pairs.as_ref().unwrap())
            }
        };

        for (secret, masked) in pairs.iter() {
            result = result.replace(secret.as_str(), masked.as_str());
        }

        // Also mask potential tokens and keys with regex patterns
        result = self.mask_patterns(&result);

        result
    }

    /// Create a fixed mask for a secret.
    ///
    /// Uses a fixed `***` replacement matching GitHub Actions behavior.
    /// Never leaks any characters of the original secret.
    fn create_mask(&self, _secret: &str) -> String {
        format!("{}{}{}", self.mask_char, self.mask_char, self.mask_char)
    }

    /// Mask common patterns that look like secrets
    fn mask_patterns(&self, text: &str) -> String {
        let patterns = PATTERNS.get_or_init(CompiledPatterns::new);
        let mut result = text.to_string();

        // GitHub Personal Access Tokens
        result = patterns
            .github_pat
            .replace_all(&result, "ghp_***")
            .to_string();

        // GitHub App tokens
        result = patterns
            .github_app
            .replace_all(&result, "ghs_***")
            .to_string();

        // GitHub OAuth tokens
        result = patterns
            .github_oauth
            .replace_all(&result, "gho_***")
            .to_string();

        // AWS Access Key IDs
        result = patterns
            .aws_access_key
            .replace_all(&result, "AKIA***")
            .to_string();

        // AWS Secret Access Keys (basic pattern)
        // Only mask if it's clearly in a secret context (basic heuristic)
        let lower = text.to_lowercase();
        if lower.contains("secret") || lower.contains("key") {
            result = patterns.aws_secret.replace_all(&result, "***").to_string();
        }

        // JWT tokens (basic pattern)
        result = patterns
            .jwt
            .replace_all(&result, "eyJ***.eyJ***.***")
            .to_string();

        // API keys with common prefixes — replace full match with ***
        result = patterns.api_key.replace_all(&result, "***").to_string();

        result
    }

    /// Check if text contains any secrets
    pub fn contains_secrets(&self, text: &str) -> bool {
        let data = self.data.read().unwrap_or_else(|e| e.into_inner());
        for secret in data.secrets.iter() {
            if text.contains(secret) {
                return true;
            }
        }
        drop(data);

        // Also check for common patterns
        self.has_secret_patterns(text)
    }

    /// Check if text contains common secret patterns
    fn has_secret_patterns(&self, text: &str) -> bool {
        let patterns = PATTERNS.get_or_init(CompiledPatterns::new);

        patterns.github_pat.is_match(text)
            || patterns.github_app.is_match(text)
            || patterns.github_oauth.is_match(text)
            || patterns.aws_access_key.is_match(text)
            || patterns.jwt.is_match(text)
            || patterns.api_key.is_match(text)
            || {
                let lower = text.to_lowercase();
                (lower.contains("secret") || lower.contains("key"))
                    && patterns.aws_secret.is_match(text)
            }
    }

    /// Get the number of secrets being tracked
    pub fn secret_count(&self) -> usize {
        self.data
            .read()
            .unwrap_or_else(|e| e.into_inner())
            .secrets
            .len()
    }

    /// Check if a specific secret is being tracked
    pub fn has_secret(&self, secret: &str) -> bool {
        self.data
            .read()
            .unwrap_or_else(|e| e.into_inner())
            .secrets
            .contains(secret)
    }
}

impl Default for SecretMasker {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_basic_masking() {
        let masker = SecretMasker::new();
        masker.add_secret("secret123");
        masker.add_secret("password456");

        let input = "The secret is secret123 and password is password456";
        let masked = masker.mask(input);

        assert!(!masked.contains("secret123"));
        assert!(!masked.contains("password456"));
        assert!(masked.contains("***"));
    }

    #[test]
    fn test_fixed_mask_replacement() {
        let masker = SecretMasker::new();
        masker.add_secret("verylongsecretkey123");

        let input = "Key: verylongsecretkey123";
        let masked = masker.mask(input);

        // Should use fixed *** mask with no character leakage
        assert_eq!(masked, "Key: ***");
        assert!(!masked.contains("verylongsecretkey123"));
    }

    #[test]
    fn test_github_token_patterns() {
        let masker = SecretMasker::new();

        let input = "Token: ghp_1234567890123456789012345678901234567890";
        let masked = masker.mask(input);

        assert!(!masked.contains("ghp_1234567890123456789012345678901234567890"));
        assert!(masked.contains("ghp_***"));
    }

    #[test]
    fn test_aws_access_key_patterns() {
        let masker = SecretMasker::new();

        let input = "AWS_ACCESS_KEY_ID=AKIAIOSFODNN7EXAMPLE";
        let masked = masker.mask(input);

        assert!(!masked.contains("AKIAIOSFODNN7EXAMPLE"));
        assert!(masked.contains("AKIA***"));
    }

    #[test]
    fn test_jwt_token_patterns() {
        let masker = SecretMasker::new();

        let input = "JWT: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c";
        let masked = masker.mask(input);

        assert!(masked.contains("eyJ***.eyJ***.***"));
        assert!(!masked.contains("SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c"));
    }

    #[test]
    fn test_contains_secrets() {
        let masker = SecretMasker::new();
        masker.add_secret("secret123");

        assert!(masker.contains_secrets("The secret is secret123"));
        assert!(!masker.contains_secrets("No secrets here"));
        assert!(masker.contains_secrets("Token: ghp_1234567890123456789012345678901234567890"));
    }

    #[test]
    fn test_short_secrets() {
        let masker = SecretMasker::new();
        masker.add_secret("ab"); // Too short, should not be added
        masker.add_secret("abc"); // Minimum length

        assert_eq!(masker.secret_count(), 1);
        assert!(!masker.has_secret("ab"));
        assert!(masker.has_secret("abc"));
    }

    #[test]
    fn test_custom_mask_char() {
        let masker = SecretMasker::with_mask_char('X');
        masker.add_secret("secret123");

        let input = "The secret is secret123";
        let masked = masker.mask(input);

        assert_eq!(masked, "The secret is XXX");
        assert!(!masked.contains("**"));
    }

    #[test]
    fn test_remove_secret() {
        let masker = SecretMasker::new();
        masker.add_secret("secret123");
        masker.add_secret("password456");

        assert_eq!(masker.secret_count(), 2);

        masker.remove_secret("secret123");
        assert_eq!(masker.secret_count(), 1);
        assert!(!masker.has_secret("secret123"));
        assert!(masker.has_secret("password456"));
    }

    #[test]
    fn test_clear_secrets() {
        let masker = SecretMasker::new();
        masker.add_secret("secret123");
        masker.add_secret("password456");

        assert_eq!(masker.secret_count(), 2);

        masker.clear();
        assert_eq!(masker.secret_count(), 0);
    }
}